On 10/30/19 11:49 AM, Fabian Grünbichler wrote:
> On October 28, 2019 12:59 pm, Stefan Reiter wrote:
>> First 3 patches are independant refactorings around get_host_arch.
>>
>> Rest of the series refactors QemuServer and creates three new packages:
>> * 'PVE::QemuSchema' for schema related code and
On October 28, 2019 12:59 pm, Stefan Reiter wrote:
> First 3 patches are independant refactorings around get_host_arch.
>
> Rest of the series refactors QemuServer and creates three new packages:
> * 'PVE::QemuSchema' for schema related code and common directory creation
> * 'PVE::QMP' for higher-
On October 28, 2019 12:59 pm, Stefan Reiter wrote:
> ...PVE::QemuServer::Machine.
>
> qemu_machine_feature_enabled is exported since it has a *lot* of users
> in PVE::QemuServer and a long enough name as it is.
>
> Signed-off-by: Stefan Reiter
> ---
>
> Not sure if PVE::QemuMachine wouldn't be
On 10/29/19 3:38 PM, Oguz Bektas wrote:
> adds the pending button for Resources, Options and DNS screens.
>
> Co-developed-by: Dominik Csapak
> Signed-off-by: Oguz Bektas
> ---
>
> v2->v3:
> * use getStore() instead of rstore while checking for datachanged, in
> light of Dominik's debugging (th
makes no sense to have the, more or less, exact same 25 line method 5
times..
could be moved to widget TK, but that's for another time.
Signed-off-by: Thomas Lamprecht
---
www/manager6/Makefile | 1 +
www/manager6/button/Revert.js | 38 +++
www/manag
On October 28, 2019 12:59 pm, Stefan Reiter wrote:
> ...in addition to PVE::QMPClient for low-level.
I think I'd rather name this PVE::Qemu::Monitor , since it does both HMP
and QMP ;) it probably makes sense to rename some of the methods, since
we need to change all the call sites anyway
PVE::
On October 28, 2019 12:59 pm, Stefan Reiter wrote:
> Also move check_cmdline, since check_running is its only user. Changes
> all uses of check_running in QemuServer, including mocking in snapshot
> tests.
>
> Signed-off-by: Stefan Reiter
> ---
> PVE/API2/Qemu.pm | 32 +++---
On October 28, 2019 12:59 pm, Stefan Reiter wrote:
> Also merge the 'mkdir's from QemuServer and QemuConfig to reduce
> duplication (both modules depend on QemuSchema anyway).
>
> nodename() is still called in multiple modules, but since it's cached by
> the INotify module it doesn't really matter
When doing an online migration with --targetstorage unused disks get migrated
to the specified target storage as well.
With this patch we keep track of those volumes and update the VM config with
their new locations. Unused volumes of the VM previously not present in the
config are added as well.
Signed-off-by: Fabian Ebner
---
PVE/API2/Qemu.pm | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/PVE/API2/Qemu.pm b/PVE/API2/Qemu.pm
index b2c0b0d..a3992c4 100644
--- a/PVE/API2/Qemu.pm
+++ b/PVE/API2/Qemu.pm
@@ -3361,7 +3361,7 @@ __PACKAGE__->register_method({
if (PVE
Doing an online migration with --targetstorage and two unused disks with the
same name on different storages failed, because they would collide on the
target storage. This patch makes sure that we don't use the same name twice.
Signed-off-by: Fabian Ebner
---
PVE/QemuMigrate.pm | 8 ++--
1 f
On 10/30/19 10:28 AM, Wolfgang Bumiller wrote:
> Explicitly close leftover connections in the destructor,
> otherwise the IO::Multiplex instance can be leaked causing
> the qmp connection to never be closed.
>
> This could occur for instance when cancelling vzdump with
> ctrl+c with extremely unlu
Explicitly close leftover connections in the destructor,
otherwise the IO::Multiplex instance can be leaked causing
the qmp connection to never be closed.
This could occur for instance when cancelling vzdump with
ctrl+c with extremely unlucky timing...
Signed-off-by: Wolfgang Bumiller
---
PVE/Q
On 10/30/19 10:08 AM, Stefan Reiter wrote:
> On 10/30/19 7:45 AM, Thomas Lamprecht wrote:
>> On 10/22/19 2:48 PM, Dominik Csapak wrote:
>>> otherwise, having multiple ipconfigX entries, can lead to different
>>> instance-ids on different startups, which is not desired
>>>
>>> Signed-off-by: Dominik
On 10/30/19 7:45 AM, Thomas Lamprecht wrote:
On 10/22/19 2:48 PM, Dominik Csapak wrote:
otherwise, having multiple ipconfigX entries, can lead to different
instance-ids on different startups, which is not desired
Signed-off-by: Dominik Csapak
---
2 issues i have with this:
* we have a cyclic d
applied, thanks :)
___
pve-devel mailing list
pve-devel@pve.proxmox.com
https://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
On 10/30/19 9:30 AM, Thomas Lamprecht wrote:
On 10/30/19 9:23 AM, Dominik Csapak wrote:
On 10/30/19 8:51 AM, Thomas Lamprecht wrote:
On 10/3/19 1:50 PM, Dominik Csapak wrote:
so that the user can edit the tags in the gui
IMO the options is not really "correct", it's not a guest option
at all
On 10/30/19 9:23 AM, Dominik Csapak wrote:
> On 10/30/19 8:51 AM, Thomas Lamprecht wrote:
>> On 10/3/19 1:50 PM, Dominik Csapak wrote:
>>> so that the user can edit the tags in the gui
>>
>> IMO the options is not really "correct", it's not a guest option
>> at all. Rather this fits to the "Notes"
On 10/30/19 8:51 AM, Thomas Lamprecht wrote:
On 10/3/19 1:50 PM, Dominik Csapak wrote:
so that the user can edit the tags in the gui
IMO the options is not really "correct", it's not a guest option
at all. Rather this fits to the "Notes" field of the Summary panel,
maybe finding there a place
On 10/29/19 3:50 PM, Oguz Bektas wrote:
> as we noticed at the lxc side, we should use diffStore in order to
> update the button status without delay.
>
> Co-developed-by: Dominik Csapak
> Signed-off-by: Oguz Bektas
> ---
> www/manager6/qemu/HardwareView.js | 4 ++--
> www/manager6/qemu/Options
On 10/29/19 7:28 PM, Thomas Lamprecht wrote:
On 10/28/19 10:57 AM, Fabian Ebner wrote:
When doing an online migration with --targetstorage unused disks get migrated
to the specified target storage as well.
With this patch we keep track of those volumes and update the VM config with
their new loc
On 10/16/19 11:05 AM, Thomas Lamprecht wrote:
> Don't track the binary trustedkeys.gpg but see it just as normal
> build product with the armored keys as source.
>
> This ensures we always ship those from TRUSTED_KEYS variable, not
> more, not less.
>
> Instead of the "gpg import+export in tempor
On 10/3/19 1:50 PM, Dominik Csapak wrote:
> it seems that this is not needed anymore, at least i cannot
> see any difference with/without it here (chromium 76)
>
> Signed-off-by: Dominik Csapak
> ---
> this is necessary for the TagSelector to be shown properly in
> chrome/chromium, otherwise it i
On 10/3/19 1:50 PM, Dominik Csapak wrote:
> so that the user can edit the tags in the gui
IMO the options is not really "correct", it's not a guest option
at all. Rather this fits to the "Notes" field of the Summary panel,
maybe finding there a place would be better..
>
> Signed-off-by: Dominik
On 10/3/19 1:50 PM, Dominik Csapak wrote:
> helpers to
> * generate a color from a string consistently
> * generate a html tag for a tag
> * related css classes
>
> Signed-off-by: Dominik Csapak
> ---
> www/css/ext6-pve.css | 13 +
> www/manager6/Utils.js | 34 ++
On 10/3/19 1:50 PM, Dominik Csapak wrote:
> this will be used for vm/ct tag-lists, so that (config) management systems
> or similar add additional information that does not reside in the
> description
>
> putting it here, since we want to eventually have it also for
> nodes,storages,etc.
>
> Sign
26 matches
Mail list logo
