[pve-devel] [PATCH container 2/6] clear reboot request in vm_start

2019-11-12 Thread Oguz Bektas
Signed-off-by: Oguz Bektas --- src/PVE/LXC.pm | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/PVE/LXC.pm b/src/PVE/LXC.pm index c77ee01..091d34a 100644 --- a/src/PVE/LXC.pm +++ b/src/PVE/LXC.pm @@ -1932,6 +1932,9 @@ sub userns_command { sub vm_start { my ($vmid, $conf,

[pve-devel] [PATCH widget-toolkit 5/6] add reboot for containers into task description table

2019-11-12 Thread Oguz Bektas
Signed-off-by: Oguz Bektas --- Utils.js | 1 + 1 file changed, 1 insertion(+) diff --git a/Utils.js b/Utils.js index e3dcfcd..3a8fa9a 100644 --- a/Utils.js +++ b/Utils.js @@ -494,6 +494,7 @@ Ext.define('Proxmox.Utils', { utilities: { vzmount: ['CT', gettext('Mount') ], vzumount:

[pve-devel] [PATCH container 4/6] pct: add 'pct reboot'

2019-11-12 Thread Oguz Bektas
Signed-off-by: Oguz Bektas --- src/PVE/CLI/pct.pm | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/PVE/CLI/pct.pm b/src/PVE/CLI/pct.pm index 3a32de4..98e2c6e 100755 --- a/src/PVE/CLI/pct.pm +++ b/src/PVE/CLI/pct.pm @@ -836,7 +836,8 @@ our $cmddef = { resume => [

[pve-devel] [PATCH 0/6] implement CT reboot

2019-11-12 Thread Oguz Bektas
this patch series implements the ability to reboot containers (main reason being to apply pending changes). most of the code is same/very similar with the qemu counterpart. i made the choice of using separate reboot triggers instead of the ones already used in prestart etc. hooks. the separate

[pve-devel] [PATCH manager 6/6] add reboot button for containers

2019-11-12 Thread Oguz Bektas
also use the opportunity to refactor the shutdown button code into the menu. Signed-off-by: Oguz Bektas --- www/manager6/lxc/Config.js | 35 +-- 1 file changed, 21 insertions(+), 14 deletions(-) diff --git a/www/manager6/lxc/Config.js

[pve-devel] [PATCH container 3/6] api: add reboot api call

2019-11-12 Thread Oguz Bektas
pretty much the same code with the qemu counterpart, minus the qmp stuff. Signed-off-by: Oguz Bektas --- src/PVE/API2/LXC/Status.pm | 52 ++ 1 file changed, 52 insertions(+) diff --git a/src/PVE/API2/LXC/Status.pm b/src/PVE/API2/LXC/Status.pm index

[pve-devel] [PATCH container 1/6] add reboot helpers to be used by containers

2019-11-12 Thread Oguz Bektas
code for create_reboot_request and clear_reboot_request is from qemu, the only difference is that we use /run/lxc/$vmid.reboot path instead of /run/qemu-server. there _is_ actually reboot triggers for lxc which are used by the prestart hook and similar, however i think it's better if we can

[pve-devel] applied: [PATCH kernel] disable alsa snd pcspkr module

2019-11-12 Thread Thomas Lamprecht
The PC speaker (beeper) can only be managed by one module, and there are two which could do so. The very basic INPUT_PCSPKR, and the more advanced SND_PCSP which allows it to be used as primitive ALSA soundcard, which for Proxmox Server projects, and all modern workstations is not much of use. As

Re: [pve-devel] [PATCH ct/common] mount point hotplugging & new mount api

2019-11-12 Thread Oguz Bektas
On Tue, Nov 12, 2019 at 03:09:27PM +0100, Oguz Bektas wrote: > hi, > > built the latest git version of pve-common and pve-container with > wolfgang's patches. > > with running kernel: 5.0.21-4-pve > and the latest pve-kernel-5.3 forgot to mention that it worked as expected with the newer kernel

Re: [pve-devel] [PATCH ct/common] mount point hotplugging & new mount api

2019-11-12 Thread Oguz Bektas
hi, built the latest git version of pve-common and pve-container with wolfgang's patches. with running kernel: 5.0.21-4-pve and the latest pve-kernel-5.3 found a small issue while testing. when one has an older kernel and tries to hotplug a mountpoint

Re: [pve-devel] [PATCH common 1/1] SysFSTools: do not assume pci domain 0000

2019-11-12 Thread Dominik Csapak
On 11/12/19 2:55 PM, Thomas Lamprecht wrote: On 11/12/19 2:23 PM, Dominik Csapak wrote: but prepend '' to ids where no domain is given, to keep the ability to use the shorthand syntax (e.g. 00:01.0 instead of :00:01.0) Signed-off-by: Dominik Csapak --- src/PVE/SysFSTools.pm | 20

Re: [pve-devel] [PATCH common 1/1] SysFSTools: do not assume pci domain 0000

2019-11-12 Thread Thomas Lamprecht
On 11/12/19 2:23 PM, Dominik Csapak wrote: > but prepend '' to ids where no domain is given, to keep the ability > to use the shorthand syntax (e.g. 00:01.0 instead of :00:01.0) > > Signed-off-by: Dominik Csapak > --- > src/PVE/SysFSTools.pm | 20 +--- > 1 file changed,

[pve-devel] [PATCH common/qemu-server/manager] fix #2436: do not hardcode pci domain

2019-11-12 Thread Dominik Csapak
this series improves the pci passthrouh/selection code such that we do not assume a pci domain of '' anymore. old configs still work, and the 'default domain', , will not be written out to the config (but shown in the gui) we can ignore the changes in qemus commandline, since such vms can

[pve-devel] [PATCH common 1/1] SysFSTools: do not assume pci domain 0000

2019-11-12 Thread Dominik Csapak
but prepend '' to ids where no domain is given, to keep the ability to use the shorthand syntax (e.g. 00:01.0 instead of :00:01.0) Signed-off-by: Dominik Csapak --- src/PVE/SysFSTools.pm | 20 +--- 1 file changed, 13 insertions(+), 7 deletions(-) diff --git

[pve-devel] [PATCH qemu-server 1/1] fix #2436: pci: do not hardcode pci domain to 0000

2019-11-12 Thread Dominik Csapak
relax the regex for hostpci to allow different pci domains than Signed-off-by: Dominik Csapak --- PVE/QemuServer.pm | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/PVE/QemuServer.pm b/PVE/QemuServer.pm index 1890448..709dcdb 100644 --- a/PVE/QemuServer.pm +++

[pve-devel] [PATCH manager 1/1] gui: pci passthrough: consider domain in PCISelector

2019-11-12 Thread Dominik Csapak
but remove the default domain '' before sending to the backend, and add it if no domain is given in the config Signed-off-by: Dominik Csapak --- www/manager6/form/PCISelector.js | 2 +- www/manager6/qemu/PCIEdit.js | 11 +-- 2 files changed, 10 insertions(+), 3 deletions(-)

[pve-devel] applied: [PATCH common] fix PVE::Tools::df for big mounts

2019-11-12 Thread Thomas Lamprecht
On 11/12/19 1:56 PM, Dominik Csapak wrote: > if the size/avail of a mount is bigger than a certain amount, > json_encode writes the number in scientific format, which did not > fit inside our \d+ regex > > this resulted in 'undef' values for the result hash and subsequently > led to errors and

[pve-devel] [PATCH pve-firewall 2/2] add synflood protection

2019-11-12 Thread Alexandre Derumier
Currently, a virtio-net + vhost-net can handle between 200-300 kpps for each vm (with 1core/queue=1). That mean than a vm can easily overloaded with a simple synflood (hping3 --flood -p 80 -S targetip). Also the conntrack of the host can be saturated easily. This patch introduce a new option,

[pve-devel] [PATCH pve-firewall 1/2] iptables : add raw table support

2019-11-12 Thread Alexandre Derumier
--- src/PVE/Firewall.pm | 122 +--- src/PVE/Service/pve_firewall.pm | 27 --- test/fwtester.pl| 10 +-- 3 files changed, 119 insertions(+), 40 deletions(-) diff --git a/src/PVE/Firewall.pm b/src/PVE/Firewall.pm index 97e5384..8f4ff1a

[pve-devel] [PATCH pve-firewall 0/2] Fix #2450: synflood protection

2019-11-12 Thread Alexandre Derumier
Currently, a virtio-net + vhost-net can handle between 200-300 kpps for each vm (with 1core/queue=1). That mean than a vm can easily overloaded with a simple synflood (hping3 --flood -p 80 -S targetip). Also the conntrack of the host can be saturated easily. This patch introduce a new option,

[pve-devel] [PATCH common] fix PVE::Tools::df for big mounts

2019-11-12 Thread Dominik Csapak
if the size/avail of a mount is bigger than a certain amount, json_encode writes the number in scientific format, which did not fit inside our \d+ regex this resulted in 'undef' values for the result hash and subsequently led to errors and warnings extend it to also catch scientific formatted

Re: [pve-devel] [PATCH storage] fix #2085: Handle non-default mount point in path() by introducing new mountpoint property

2019-11-12 Thread Thomas Lamprecht
On 11/12/19 12:18 PM, Fabian Ebner wrote: > > I don't see a clean way to do the automatic adding of the mount point > property (doing it in path() is possible, but we need to assume that our > caller doesn't hold the lock on storage.cfg). Maybe it's better to just do > the warning in

[pve-devel] applied: [PATCH docu] Fix #2459: qm: Make info about core limit clear

2019-11-12 Thread Thomas Lamprecht
On 11/12/19 10:08 AM, Dominic Jäger wrote: > 'assigning' could also mean that creating a VM with more cores than physically > available is impossible. However, this is not the case. Using 'starting' > instead is more precise and still easy to understand. > > Signed-off-by: Dominic Jäger > --- >

Re: [pve-devel] [PATCH storage] fix #2085: Handle non-default mount point in path() by introducing new mountpoint property

2019-11-12 Thread Fabian Grünbichler
On November 12, 2019 12:18 pm, Fabian Ebner wrote: > On 11/7/19 12:59 PM, Fabian Grünbichler wrote: >> On November 7, 2019 12:52 pm, Fabian Ebner wrote: >>> On 11/7/19 9:34 AM, Fabian Grünbichler wrote: On November 6, 2019 1:46 pm, Fabian Ebner wrote: > A new mountpoint property is added

Re: [pve-devel] [PATCH storage] fix #2085: Handle non-default mount point in path() by introducing new mountpoint property

2019-11-12 Thread Fabian Ebner
On 11/7/19 12:59 PM, Fabian Grünbichler wrote: On November 7, 2019 12:52 pm, Fabian Ebner wrote: On 11/7/19 9:34 AM, Fabian Grünbichler wrote: On November 6, 2019 1:46 pm, Fabian Ebner wrote: A new mountpoint property is added to the schema for ZFSPool storages. When needed for the first

Re: [pve-devel] [PATCH 17/23] allow ticket in auth header as fallback

2019-11-12 Thread Thomas Lamprecht
On 11/12/19 11:17 AM, Fabian Grünbichler wrote: > On November 12, 2019 11:05 am, Thomas Lamprecht wrote: >> On 11/12/19 10:46 AM, Fabian Grünbichler wrote: >>> On October 17, 2019 5:33 pm, Thomas Lamprecht wrote: On 10/17/19 3:14 PM, Fabian Grünbichler wrote: > @@ -1232,7 +1232,10 @@ sub

[pve-devel] applied: [PATCH manager] ui: vm opts: add hint for spice foldersharing

2019-11-12 Thread Thomas Lamprecht
On 11/6/19 1:17 PM, Aaron Lauterer wrote: > Spice foldersharing needs the webdavd daemon installed inside the guest. > This patch adds a hint to remind the user to install it in the VM. > > Signed-off-by: Aaron Lauterer > --- > www/manager6/form/SpiceEnhancementSelector.js | 13 + >

Re: [pve-devel] [PATCH 17/23] allow ticket in auth header as fallback

2019-11-12 Thread Fabian Grünbichler
On November 12, 2019 11:05 am, Thomas Lamprecht wrote: > On 11/12/19 10:46 AM, Fabian Grünbichler wrote: >> On October 17, 2019 5:33 pm, Thomas Lamprecht wrote: >>> On 10/17/19 3:14 PM, Fabian Grünbichler wrote: @@ -1232,7 +1232,10 @@ sub unshift_read_header { } elsif ($path

Re: [pve-devel] [PATCH 17/23] allow ticket in auth header as fallback

2019-11-12 Thread Thomas Lamprecht
On 11/12/19 10:46 AM, Fabian Grünbichler wrote: > On October 17, 2019 5:33 pm, Thomas Lamprecht wrote: >> On 10/17/19 3:14 PM, Fabian Grünbichler wrote: >>> @@ -1232,7 +1232,10 @@ sub unshift_read_header { >>> } elsif ($path =~ m/^\Q$base_uri\E/) { >>> my $token =

[pve-devel] [PATCH qemu-server] Use crm-command stop to allow shutdown with timeout and hard stop for HA

2019-11-12 Thread Fabian Ebner
The minimum value for timeout in vm_shutdown is changed from 0 to 1, since a value of 0 would trigger a hard stop for HA managed VMs. Like this the API description stays valid for all cases. Signed-off-by: Fabian Ebner --- In vm_shutdown we'd like to pass along the timeout parameter to the HA

[pve-devel] [PATCH container] Use crm-command stop to allow shutdown with timeout and hard stop for HA

2019-11-12 Thread Fabian Ebner
The minimum value for timeout in vm_shutdown is changed from 0 to 1, since a value of 0 would trigger a hard stop for HA managed containers. Like this the API description stays valid for all cases. Signed-off-by: Fabian Ebner --- src/PVE/API2/LXC/Status.pm | 6 +++--- 1 file changed, 3

Re: [pve-devel] [PATCH 17/23] allow ticket in auth header as fallback

2019-11-12 Thread Fabian Grünbichler
On October 17, 2019 5:33 pm, Thomas Lamprecht wrote: > On 10/17/19 3:14 PM, Fabian Grünbichler wrote: >> based on idea & RFC by Tim Marx, incorporating feedback by Thomas >> Lamprecht. this will be extended to support API tokens in the >> Authorization header as well, so make it generic. >> >>

[pve-devel] [PATCH docu] Fix #2459: qm: Make info about core limit clear

2019-11-12 Thread Dominic Jäger
'assigning' could also mean that creating a VM with more cores than physically available is impossible. However, this is not the case. Using 'starting' instead is more precise and still easy to understand. Signed-off-by: Dominic Jäger --- qm.adoc | 4 ++-- 1 file changed, 2 insertions(+), 2