[pve-devel] [PATCH pve-manager 2/2] sdn: enable SDN menu if /cluster/sdn api exist

2020-02-17 Thread Alexandre Derumier
Signed-off-by: Alexandre Derumier --- www/manager6/Workspace.js | 8 www/manager6/dc/Config.js | 3 ++- 2 files changed, 10 insertions(+), 1 deletion(-) diff --git a/www/manager6/Workspace.js b/www/manager6/Workspace.js index 1cc86999..8b5d5cff 100644 --- a/www/manager6/Workspace.js

[pve-devel] [PATCH pve-manager 1/2] add sdn gui

2020-02-17 Thread Alexandre Derumier
Signed-off-by: Alexandre Derumier --- www/manager6/Makefile | 17 +++ www/manager6/Makefile.rej | 9 ++ www/manager6/StateProvider.js | 4 +- www/manager6/Utils.js | 70 + www/manager6/Workspace.js

[pve-devel] [PATCH pve-manager 0/2] add conditionnal sdn GUI

2020-02-17 Thread Alexandre Derumier
Patch 1 is still the same Patch 2 enable the menu in datacenter if pve-network is installed Alexandre Derumier (2): add sdn gui sdn: enable SDN menu if /cluster/sdn api exist www/manager6/Makefile | 17 +++ www/manager6/Makefile.rej | 9 ++

Re: [pve-devel] [PATCH ifupdown2 2/2] add openvswitch addon

2020-02-17 Thread Thomas Lamprecht
On 2/18/20 7:08 AM, Alexandre DERUMIER wrote: >>> Oh, and yes, if this breaks the old way of specifying ovs interfaces some >>> compatibillity would be great, e.g., with your mentioned postinst script > > What do you think about this simple postinst script ? > > " > use PVE::INotify; > my

Re: [pve-devel] [PATCH ifupdown2 2/2] add openvswitch addon

2020-02-17 Thread Alexandre DERUMIER
>>Oh, and yes, if this breaks the old way of specifying ovs interfaces some >>compatibillity would be great, e.g., with your mentioned postinst script What do you think about this simple postinst script ? " use PVE::INotify; my $config = PVE::INotify::read_file('interfaces', 1); my $configdata

[pve-devel] [PATCH pve-common 2/2] INotify: fix unknown for unknown ovs_type

2020-02-17 Thread Alexandre Derumier
if user defined manually ovs_type OVSTunnel or OVSPatchPort, the type is empty. set type=unknown first to avoid this kind of mistake --- src/PVE/INotify.pm | 9 + 1 file changed, 1 insertion(+), 8 deletions(-) diff --git a/src/PVE/INotify.pm b/src/PVE/INotify.pm index 6e6ab53..bbba7e2

[pve-devel] [PATCH pve-common 0/2] INotify : ovs cleanup

2020-02-17 Thread Alexandre Derumier
I have detected some errors when trying to rewrite /etc/network/interfaces with ovs interfaces. OVSbond order was not managed for example. Alexandre Derumier (2): INotify : fix OVSBond && OvsintPort order + tests INotify: fix unknown for unknown ovs_type src/PVE/INotify.pm

[pve-devel] [PATCH pve-common 1/2] INotify : fix OVSBond && OvsintPort order + tests

2020-02-17 Thread Alexandre Derumier
OVSBond was missing OvsintPort under ethx interfaces --- src/PVE/INotify.pm| 13 ++-- .../t.create_network.pl | 77 +++ 2 files changed, 84 insertions(+), 6 deletions(-) diff --git a/src/PVE/INotify.pm b/src/PVE/INotify.pm index

Re: [pve-devel] working on ifupdown2 openvswitch addon

2020-02-17 Thread Alexandre DERUMIER
>>I'd maybe just hide it by default, and do a single api call on >>GET /nodes/NODE/sdn yes, good idea ! pvesh get /cluster/sdn ┌─┐ │ id │ ╞═╡ │ controllers │ ├─┤ │ vnets │ ├─┤ │ zones │ └─┘ (Could also be used to

Re: [pve-devel] working on ifupdown2 openvswitch addon

2020-02-17 Thread Thomas Lamprecht
On 2/17/20 4:13 PM, Alexandre DERUMIER wrote: >>> As said, I'm open to integrate the gui also, with a "experimental" title >>> and if only shown once pve-network is installed. This way you'd reach a >>> lot more people open for testing easier, as it does not requires them to >>> apply patches and

Re: [pve-devel] [PATCH pve-common 1/1] Network: tap_create|plug : sdn : use bridge_vlan

2020-02-17 Thread Alexandre DERUMIER
Any comment for this patch ? (It's needed for last pve-network patches) - Mail original - De: "aderumier" À: "pve-devel" Cc: "aderumier" Envoyé: Lundi 10 Février 2020 17:26:47 Objet: [PATCH pve-common 1/1] Network: tap_create|plug : sdn : use bridge_vlan find correct bridge/vlan from

Re: [pve-devel] [PATCH pve-manager 2/2] API2: Network: display vnets in any_bridge

2020-02-17 Thread Alexandre DERUMIER
Any comment for this patch ? - Mail original - De: "aderumier" À: "pve-devel" Cc: "aderumier" Envoyé: Lundi 10 Février 2020 17:27:11 Objet: [PATCH pve-manager 2/2] API2: Network: display vnets in any_bridge --- PVE/API2/Network.pm | 25 + 1 file changed, 25

Re: [pve-devel] working on ifupdown2 openvswitch addon

2020-02-17 Thread Alexandre DERUMIER
>>As said, I'm open to integrate the gui also, with a "experimental" title >>and if only shown once pve-network is installed. This way you'd reach a >>lot more people open for testing easier, as it does not requires them to >>apply patches and build packages them self or download unsigned packages

Re: [pve-devel] [PATCH ifupdown2 2/2] add openvswitch addon

2020-02-17 Thread Alexandre DERUMIER
>>could it be that the actual "pve/0008-add-openvswitch-addon.patch" patch >>wasn't added to the git index? :) sorry, I have send a v2 with the missing file >>Oh, and yes, if this breaks the old way of specifying ovs interfaces some >>compatibillity would be great, e.g., with your mentioned

[pve-devel] [PATCH v2 ifupdown2 2/2] add openvswitch addon

2020-02-17 Thread Alexandre Derumier
This reimplement the ifupdown1 script with same options, with reloading included ! --- .../pve/0008-add-openvswitch-addon.patch | 572 ++ debian/patches/series | 1 + 2 files changed, 573 insertions(+) create mode 100644

[pve-devel] [PATCH v2 ifupdown2 0/2] add openvswitch addon

2020-02-17 Thread Alexandre Derumier
This is an reimplementation of ifupdown1 ovs script, with reloading support. The only difference is that interfaces need to be defined with "auto ...", instead "allow-ovs , allow-vmbr..." as relationship between interface is correctly managed with ifupdown2. (Maybe could we add a prestart script

[pve-devel] [PATCH v2 ifupdown2 1/2] remove patch 0008-execute-addons-scripts-before-modules.patch

2020-02-17 Thread Alexandre Derumier
This was a workaround for openvswitch Signed-off-by: Alexandre Derumier --- ...xecute-addons-scripts-before-modules.patch | 71 --- debian/patches/series | 1 - 2 files changed, 72 deletions(-) delete mode 100644

Re: [pve-devel] [PATCH qemu-server] vzdump: exclude efidisks from backups of non-OVMF machines

2020-02-17 Thread Thomas Lamprecht
On 2/17/20 10:34 AM, Stefan Reiter wrote: > Machines running with SeaBIOS don't have the efidisk attached, so QEMU > cannot back it up and fails with "unknown drive". > > Signed-off-by: Stefan Reiter > --- > PVE/VZDump/QemuServer.pm | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git

Re: [pve-devel] [PATCH ifupdown2 2/2] add openvswitch addon

2020-02-17 Thread Thomas Lamprecht
On 2/17/20 1:51 PM, Alexandre Derumier wrote: > This reimplement the ifupdown1 script with same options, > > with reloading included ! > --- > debian/patches/series | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/debian/patches/series b/debian/patches/series > index 3f39fc8..b8c348c

Re: [pve-devel] working on ifupdown2 openvswitch addon

2020-02-17 Thread Thomas Lamprecht
On 2/17/20 1:56 PM, Alexandre DERUMIER wrote: >>> Yay ! >>> A bit too busy right now, but can't wait to test all your SDN plugins. > > I need beta testers, so if you have some time to test, tell me , I'll send > you gui patches and doc > As said, I'm open to integrate the gui also, with a

[pve-devel] applied: [PATCH manager 2/2] ceph api: Make systemd unit type suffix optional

2020-02-17 Thread Thomas Lamprecht
On 2/17/20 12:28 PM, Dominic Jäger wrote: > To (re)start and stop Ceph services the API calls systemd units using the > function ceph_service_cmd. If unspecified, this function assumes the type > ".target" for a unit. By making the unit type suffix in the API optional, it > can make use of this

[pve-devel] applied: [PATCH manager] gui: pci passthrough: fix 'Add PCI' dialog for new devices

2020-02-17 Thread Thomas Lamprecht
On 2/17/20 2:36 PM, Stefan Reiter wrote: > Commit 6033f465b8 (gui: pci passthrough: consider domain in PCISelector) > used 'values.host' without checking if it's set, resulting in an error > when the dialog was opened for a new device (where values.host is > undefined). > > Signed-off-by: Stefan

[pve-devel] applied: [PATCH manager 1/2] pveceph: Make service parameter optional

2020-02-17 Thread Thomas Lamprecht
On 2/17/20 12:28 PM, Dominic Jäger wrote: > The default value for "pveceph start" and "pveceph stop" is "ceph.target". > However, omitting the parameter to use the default has been forbidden. > > Signed-off-by: Dominic Jäger > --- > PVE/CLI/pveceph.pm | 4 ++-- > 1 file changed, 2

[pve-devel] [PATCH docs] pveceph: reword memory precondition

2020-02-17 Thread Alwin Antreich
and add the memory target for OSDs, included since Luminous. As well as distinguish the memory usage between the OSD backends. Signed-off-by: Alwin Antreich --- pveceph.adoc | 13 ++--- 1 file changed, 10 insertions(+), 3 deletions(-) diff --git a/pveceph.adoc b/pveceph.adoc index

[pve-devel] [PATCH manager] gui: pci passthrough: fix 'Add PCI' dialog for new devices

2020-02-17 Thread Stefan Reiter
Commit 6033f465b8 (gui: pci passthrough: consider domain in PCISelector) used 'values.host' without checking if it's set, resulting in an error when the dialog was opened for a new device (where values.host is undefined). Signed-off-by: Stefan Reiter --- www/manager6/qemu/PCIEdit.js | 15

[pve-devel] [PATCH pve-common] INotify: use auto for ovs interfaces with ifupdown2

2020-02-17 Thread Alexandre Derumier
Need the ifupdown2 openvswitch addon ! --- src/PVE/INotify.pm | 9 +++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/src/PVE/INotify.pm b/src/PVE/INotify.pm index ba952e3..55ff969 100644 --- a/src/PVE/INotify.pm +++ b/src/PVE/INotify.pm @@ -1320,7 +1320,12 @@ sub

Re: [pve-devel] working on ifupdown2 openvswitch addon

2020-02-17 Thread Alexandre DERUMIER
>>Yay ! >>A bit too busy right now, but can't wait to test all your SDN plugins. I need beta testers, so if you have some time to test, tell me , I'll send you gui patches and doc >>BTW, is there still advantages for OVS bridges over standard linux bridges >>once your SDN stuff is out ? IIUC,

[pve-devel] [PATCH ifupdown2 0/2] add openvswitch addon

2020-02-17 Thread Alexandre Derumier
This is an reimplementation of ifupdown1 ovs script, with reloading support. The only difference is that interfaces need to be defined with "auto ...", instead "allow-ovs , allow-vmbr..." as relationship between interface is correctly managed with ifupdown2. (Maybe could we add a prestart script

[pve-devel] [PATCH ifupdown2 1/2] remove patch 0008-execute-addons-scripts-before-modules.patch

2020-02-17 Thread Alexandre Derumier
This was a workaround for openvswitch Signed-off-by: Alexandre Derumier --- ...xecute-addons-scripts-before-modules.patch | 71 --- debian/patches/series | 1 - 2 files changed, 72 deletions(-) delete mode 100644

[pve-devel] [PATCH ifupdown2 2/2] add openvswitch addon

2020-02-17 Thread Alexandre Derumier
This reimplement the ifupdown1 script with same options, with reloading included ! --- debian/patches/series | 1 + 1 file changed, 1 insertion(+) diff --git a/debian/patches/series b/debian/patches/series index 3f39fc8..b8c348c 100644 --- a/debian/patches/series +++ b/debian/patches/series @@

[pve-devel] [PATCH v3 storage 2/2] Avoid using extra variable

2020-02-17 Thread Fabian Ebner
Signed-off-by: Fabian Ebner --- PVE/Storage/ZFSPoolPlugin.pm | 10 -- 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/PVE/Storage/ZFSPoolPlugin.pm b/PVE/Storage/ZFSPoolPlugin.pm index dbe0465..b29fba5 100644 --- a/PVE/Storage/ZFSPoolPlugin.pm +++

[pve-devel] [PATCH v3 qemu-server] qemu_block_resize: volume_resize now uses KiB instead of bytes

2020-02-17 Thread Fabian Ebner
Also gets rid of an error with qmp block_resize, which expects that the size is a multiple of 512 bytes for qcow2 volumes. Signed-off-by: Fabian Ebner --- PVE/QemuServer.pm | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/PVE/QemuServer.pm b/PVE/QemuServer.pm index

[pve-devel] [PATCH v3 container] volume_resize now uses KiB instead of bytes

2020-02-17 Thread Fabian Ebner
Signed-off-by: Fabian Ebner --- src/PVE/API2/LXC.pm | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/PVE/API2/LXC.pm b/src/PVE/API2/LXC.pm index 6652e2e..ebe8f18 100644 --- a/src/PVE/API2/LXC.pm +++ b/src/PVE/API2/LXC.pm @@ -1671,13 +1671,15 @@

[pve-devel] [PATCH v3 storage 1/2] volume_resize: use KiB instead of bytes

2020-02-17 Thread Fabian Ebner
Avoid some problems with 'qemu-img resize', which expects that the size is a multiple of 512 bytes for qcow2 images. Since vdisk_alloc already uses KiB, this also improves consistency a little. The tests for ZFS are also adapted to the new interface. Signed-off-by: Fabian Ebner --- Changes

[pve-devel] [PATCH manager 1/2] pveceph: Make service parameter optional

2020-02-17 Thread Dominic Jäger
The default value for "pveceph start" and "pveceph stop" is "ceph.target". However, omitting the parameter to use the default has been forbidden. Signed-off-by: Dominic Jäger --- PVE/CLI/pveceph.pm | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/PVE/CLI/pveceph.pm

[pve-devel] [PATCH manager 2/2] ceph api: Make systemd unit type suffix optional

2020-02-17 Thread Dominic Jäger
To (re)start and stop Ceph services the API calls systemd units using the function ceph_service_cmd. If unspecified, this function assumes the type ".target" for a unit. By making the unit type suffix in the API optional, it can make use of this assumption. Signed-off-by: Dominic Jäger ---

[pve-devel] applied: [RFC manager 5/6] gui/cluster: show all links (up to 8) in cluster overview

2020-02-17 Thread Thomas Lamprecht
On 1/29/20 11:27 AM, Stefan Reiter wrote: > Show only links found on the cluster. > > 'enableColumnHide' is set to false, since it causes confusing behaviour > for the user, considering we'd overwrite part of their choices every 5 > seconds. > > Signed-off-by: Stefan Reiter > --- >

[pve-devel] applied: [PATCH v3 docs] rewrite and extend pct documentation

2020-02-17 Thread Thomas Lamprecht
On 2/13/20 3:23 PM, Oguz Bektas wrote: > * rephrase some parts. > * update old information > * add info about pending changes and other "new" features > > Co-Authored-by: Aaron Lauterer > Co-Authored-by: Thomas Lamprecht > Signed-off-by: Oguz Bektas > --- > > v2->v3: > * move info about

[pve-devel] [PATCH qemu-server] vzdump: exclude efidisks from backups of non-OVMF machines

2020-02-17 Thread Stefan Reiter
Machines running with SeaBIOS don't have the efidisk attached, so QEMU cannot back it up and fails with "unknown drive". Signed-off-by: Stefan Reiter --- PVE/VZDump/QemuServer.pm | 3 +++ 1 file changed, 3 insertions(+) diff --git a/PVE/VZDump/QemuServer.pm b/PVE/VZDump/QemuServer.pm index