On 5/3/20 5:53 PM, Alwin Antreich wrote:
> to clean service directories as well as disable and stop Ceph services.
> Addtionally provide the option to remove crash and log information.
>
> This patch is in addtion to #2607, as the current cleanup doesn't allow
> to re-configure Ceph, without
On 4/28/20 12:00 PM, Oğuz Bektaş wrote:
>> Fabian Ebner hat am 28. April 2020 10:18 geschrieben:
>>
>>
>> by introducing a safe_compare helper. Fixes warnings, e.g.
>> pvesh get /nodes//network
>> would print "use of uninitialized"-warnings if there are inactive
>> network interfaces, because
On 4/27/20 4:40 PM, Dominik Csapak wrote:
> Signed-off-by: Dominik Csapak
> ---
> window/LanguageEdit.js | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/window/LanguageEdit.js b/window/LanguageEdit.js
> index dd7393c..9176cfd 100644
> --- a/window/LanguageEdit.js
> +++
On 5/4/20 2:02 PM, Stefan Reiter wrote:
> Signed-off-by: Stefan Reiter
> ---
> src/PVE/CLIHandler.pm | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/PVE/CLIHandler.pm b/src/PVE/CLIHandler.pm
> index 763cd60..9955d77 100644
> --- a/src/PVE/CLIHandler.pm
> +++
On 4/23/20 1:51 PM, Fabian Ebner wrote:
> No functional change is intended.
>
> Signed-off-by: Fabian Ebner
> ---
> PVE/AbstractConfig.pm | 8 +---
> 1 file changed, 1 insertion(+), 7 deletions(-)
>
> diff --git a/PVE/AbstractConfig.pm b/PVE/AbstractConfig.pm
> index beb10c7..f1b395c
On 4/27/20 10:24 AM, Fabian Grünbichler wrote:
> to protect against concurrent changes
>
> Signed-off-by: Fabian Grünbichler
> ---
> best viewed with --patience -w
>
> PVE/API2/Qemu.pm | 40 +++-
> 1 file changed, 23 insertions(+), 17 deletions(-)
>
On 4/27/20 10:24 AM, Fabian Grünbichler wrote:
> lock_file is used by PVE::QemuServer::Memory, but it does properly 'use
> PVE::Tools ...' itself so we can drop them in the main module.
>
> Signed-off-by: Fabian Grünbichler
> ---
> PVE/QemuServer.pm | 4 ++--
> 1 file changed, 2 insertions(+),
On 4/30/20 10:37 AM, Fabian Grünbichler wrote:
> similar to the recent changes for pve-guest-common - we start each API
> call with a cfs_update, but while we were waiting for the flock another
> R-M-W cycle might have happened, so we need to refresh after obtaining
> the lock.
>
> Signed-off-by:
On 3/4/20 10:51 AM, Fabian Ebner wrote:
> This reverts commit b5490d8a98e5e7328eb4cebb0ae0b60e6d406c38.
>
> When resizing a volume of a running VM, a qmp block_resize command
> is issued. This is non-blocking, so the size on the storage immediately
> after issuing the command might still be the
On 4/30/20 9:35 AM, Fabian Grünbichler wrote:
> by avoiding auto-vivification of $self->{online_local_volumes} via
> iteration. most code paths don't care whether it's undef or a reference
> to an empty list, but this caused the (already) fixed bug of calling
> nbd_stop without having started an
On 4/30/20 12:44 PM, Dominik Csapak wrote:
> we really only want to rescan the disk size of the disks we actually
> need, and that are only the local disks (for which we have to allocate
> the correct size on the target)
>
> also we want to always skip the efidisk, since we get the wanted
> size
As a first step to make the whole guest include logic more testable the
part from the API endpoint has been moved to its own method with as
little changes as possible.
Everything concerning `all` and `exclude` logic is still in the
PVE::VZDump->exec_backup() method.
Signed-off-by: Aaron Lauterer
Signed-off-by: Aaron Lauterer
---
v1 -> v2: adapt handling of return values, closer to what is used in
production code.
test/Makefile | 5 +-
test/vzdump_guest_included_test.pl | 191 +
2 files changed, 195 insertions(+), 1 deletion(-)
create
On 5/4/20 2:35 PM, Wolfgang Bumiller wrote:
> Move qemu_savevm_state_{header,setup} into the main loop and
> the rest of the iteration into a coroutine. The former need
> to lock the iothread (and we can't unlock it in the
> coroutine), and the latter can't deal with being in a
> separate thread,
As we don't currently support SLAAC in the nocloud network format code, remove
the reference from the docs.
Signed-off-by: Mira Limbeck
---
We have removed SLAAC from the GUI a while ago because cloud-init did
not support it back then but missed the reference in the docs.
explaining the main Requirements and limitations, as well as the
most important sync options
Signed-off-by: Dominik Csapak
---
changes from v2:
* incorporated suggestions from aaron
@aaron, regarding linking to character limitations,
sadly no, this is a sub based format, so even if we would have
Else one can pass almost arbitrary data as ID and break editing or
deletion of a plugin.
Signed-off-by: Thomas Lamprecht
---
src/PVE/ACME/Challenge.pm | 1 +
1 file changed, 1 insertion(+)
diff --git a/src/PVE/ACME/Challenge.pm b/src/PVE/ACME/Challenge.pm
index 0af77a3..0c679fc 100644
---
and use 4M for our savevm-async buffer size
Signed-off-by: Wolfgang Bumiller
---
Changes to v1: add missing call to free() in qemu_fclose.
...add-optional-buffer-size-to-QEMUFile.patch | 183 ++
debian/patches/series | 1 +
2 files changed, 184
Move qemu_savevm_state_{header,setup} into the main loop and
the rest of the iteration into a coroutine. The former need
to lock the iothread (and we can't unlock it in the
coroutine), and the latter can't deal with being in a
separate thread, so a coroutine it must be.
Signed-off-by: Wolfgang
with an additional commit adding '--rsyncable'.
thanks!
On April 28, 2020 3:58 pm, Alwin Antreich wrote:
> Zstandard (zstd) [0] is a data compression algorithm, in addition to
> gzip, lzo for our backup/restore. It can utilize multiple core CPUs. But
> by default it has one compression and one
On 4/29/20 3:45 PM, Mira Limbeck wrote:
> This removes icmpv6-type 'any' as it is not supported by ip6tables. Also
> introduced new icmpv6 types 'beyond-scope', 'failed-policy' and
> 'reject-route'. These values were taken from 'ip6tables -p icmpv6 -h'.
>
> Signed-off-by: Mira Limbeck
> ---
>
Signed-off-by: Thomas Lamprecht
---
src/PVE/Firewall.pm | 26 ++
1 file changed, 14 insertions(+), 12 deletions(-)
diff --git a/src/PVE/Firewall.pm b/src/PVE/Firewall.pm
index a6157e3..eadfc6b 100644
--- a/src/PVE/Firewall.pm
+++ b/src/PVE/Firewall.pm
@@ -812,6 +812,17
Signed-off-by: Thomas Lamprecht
---
src/PVE/Firewall.pm | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/PVE/Firewall.pm b/src/PVE/Firewall.pm
index 5d1a584..28dbb19 100644
--- a/src/PVE/Firewall.pm
+++ b/src/PVE/Firewall.pm
@@ -1082,7 +1082,7 @@ sub
Signed-off-by: Thomas Lamprecht
---
src/PVE/Firewall.pm | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/src/PVE/Firewall.pm b/src/PVE/Firewall.pm
index 28dbb19..a6157e3 100644
--- a/src/PVE/Firewall.pm
+++ b/src/PVE/Firewall.pm
@@ -2039,7 +2039,7 @@ sub ipt_rule_to_cmds {
For now without integer to full-name, and vice versa, mapping of
ICMP types.
Signed-off-by: Thomas Lamprecht
---
src/PVE/FirewallSimulator.pm | 9 +++--
test/test-basic1/100.fw | 2 ++
test/test-basic1/tests | 4
3 files changed, 13 insertions(+), 2 deletions(-)
diff --git
On 4/29/20 3:45 PM, Mira Limbeck wrote:
> This has to be done in both icmp and icmpv6 cases. Currently if
> 'ipv6-icmp' is set via the GUI ('icmpv6' is not available there) there
> is no icmp-type handling. As this is meant to fix the iptables-restore
> failure if an icmp-type > 255 is specified,
> On May 4, 2020 12:43 PM Stefan Reiter wrote:
>
>
> Fixes the SIGSEGV issues on Ceph with snapshot and rollback for me, so:
>
> Tested-by: Stefan Reiter
>
> Just for reference, I also bisected the bug this fixes to upstream
> commit 8c6b0356b53 ("util/async: make bh_aio_poll() O(1)"),
Signed-off-by: Stefan Reiter
---
src/PVE/CLIHandler.pm | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/PVE/CLIHandler.pm b/src/PVE/CLIHandler.pm
index 763cd60..9955d77 100644
--- a/src/PVE/CLIHandler.pm
+++ b/src/PVE/CLIHandler.pm
@@ -235,8 +235,8 @@ sub
CPU models are retrieved from the new /nodes/X/cpu call and ordered by
vendor to approximate the previous sort order (less change for accustomed
users).
With this, custom CPU models are now selectable via the GUI.
Signed-off-by: Stefan Reiter
---
v2:
* Put vendor map and order map into
Explicitly allows changing other properties than the cputype, even if
the currently set cputype is not accessible by the user. This way, an
administrator can assign a custom CPU type to a VM for a less privileged
user without breaking edit functionality for them.
Signed-off-by: Stefan Reiter
---
Permission handling, the beginnings of the API and getting the GUI to play nice
with custom models (no editor yet, but it'll behave as expected if a determined
user creates a custom model by editing the config).
First 3 patches are API stuff, 4 is an independent UI fix/cleanup, rest are new
GUI
More API calls will follow for this path, for now add the 'index' call to
list all custom and default CPU models.
Any user can list the default CPU models, as these are public anyway, but
custom models are restricted to users with Sys.Audit on /nodes.
Signed-off-by: Stefan Reiter
---
An administrator can set a custom CPU model for a VM where the general user
does not have permission to use this particular model. Prior to this change
the ProcessorEdit component would be broken by this, since the store of the
CPU type selector did not contain the configured CPU model.
Add it in
Signed-off-by: Stefan Reiter
---
Depends on updated qemu-server.
PVE/API2/Nodes.pm | 7 +++
1 file changed, 7 insertions(+)
diff --git a/PVE/API2/Nodes.pm b/PVE/API2/Nodes.pm
index 58497b2b..2ac838ea 100644
--- a/PVE/API2/Nodes.pm
+++ b/PVE/API2/Nodes.pm
@@ -34,6 +34,7 @@ use
Clean up the code in ProcessorEdit with a view model and fix a bug while at
it - previously, pressing the 'Reset' button on the form would always set
the value of the total core count field to 1, so mark 'totalcores' with
'isFormField: false' to avoid reset.
Signed-off-by: Stefan Reiter
---
v2:
On 5/4/20 12:02 PM, Wolfgang Bumiller wrote:
and use 4M for our savevm-async buffer size
Signed-off-by: Wolfgang Bumiller
---
...add-optional-buffer-size-to-QEMUFile.patch | 173 ++
debian/patches/series | 1 +
2 files changed, 174 insertions(+)
Fixes the SIGSEGV issues on Ceph with snapshot and rollback for me, so:
Tested-by: Stefan Reiter
Just for reference, I also bisected the bug this fixes to upstream
commit 8c6b0356b53 ("util/async: make bh_aio_poll() O(1)"), i.e. it only
breaks after this commit. Might be an upstream bug too
and use 4M for our savevm-async buffer size
Signed-off-by: Wolfgang Bumiller
---
...add-optional-buffer-size-to-QEMUFile.patch | 173 ++
debian/patches/series | 1 +
2 files changed, 174 insertions(+)
create mode 100644
On May 4, 2020 11:20 am, Tim Marx wrote:
>
>> Fabian Ebner hat am 4. Mai 2020 09:26 geschrieben:
>>
>>
>> On 5/2/20 11:40 AM, Alexandre DERUMIER wrote:
>> >>> The problem is that offline migration with target storage might not
>> >>> always work depending on supported export/import formats.
> Fabian Ebner hat am 4. Mai 2020 09:26 geschrieben:
>
>
> On 5/2/20 11:40 AM, Alexandre DERUMIER wrote:
> >>> The problem is that offline migration with target storage might not
> >>> always work depending on supported export/import formats. Then users
> >>> might start an offline migration,
so the current disk locations can be preserved even if
there are multiple local disks. And users don't have to
manually select the current storage if there is only one
local disk.
Signed-off-by: Fabian Ebner
---
www/manager6/window/Migrate.js | 8 ++--
1 file changed, 6 insertions(+), 2
The size of VM state files and the size of unused disks not
referenced by any snapshot is not saved in the VM configuration,
so it's not available here either.
Signed-off-by: Fabian Ebner
---
Changes from v1:
* use variable for size text and use format string
* drop patch exposing
On 5/2/20 11:40 AM, Alexandre DERUMIER wrote:
The problem is that offline migration with target storage might not
always work depending on supported export/import formats. Then users
might start an offline migration, which then fails after a few disks
have already been copied.
Hi,
43 matches
Mail list logo
