Re: [pve-devel] Feature HW Profiles

2013-04-16 Thread Dietmar Maurer
> >>but it seems i can't create a template without a drive ;-) I just
> >>wanted to have a template with settings for VMs. Like predefined
> >>configuration without a disk.
> 
> ok, I understand now ;)
> 
> Indeed, currently, a template is a vm with a base-xxx disk.
> 
> Maybe can we improve that ?

Yes, I guess we need to (re)introduce the 'template' config setting.

___
pve-devel mailing list
pve-devel@pve.proxmox.com
http://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel


Re: [pve-devel] Feature HW Profiles

2013-04-16 Thread Dietmar Maurer
> qm template 
> 
> - rename disk (if disk exist) to base-xxx
> - add template: 1

yes

> What happen if we have a vm with: (manual conf edit)
> 
> - template:1
> - non-base disk name
> 
> Is it a template or not ?  (because linked clone will not work)

It is a template.
___
pve-devel mailing list
pve-devel@pve.proxmox.com
http://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel


Re: [pve-devel] Count monthly traffic

2013-04-16 Thread Dietmar Maurer

> Am 12.03.2013 18:53, schrieb Dietmar Maurer:
> >> Why does a single file creates less load? Both contain the same amount of
> data.
> >
> > A VM can use up to 32 network devices. Updating 32 files create more load
> than updating a single file?
> 
> I want to proceed with this one. First i need to know how it works.

> There is:
> 
> Extract/read data FROM RRD:
>/usr/share/perl5/PVE/API2Tools.pm

The basic support is in PVE::Cluster (broadcast_rrd, create_rrd_data, 
create_rrd_graph)

> Get VM Status and store these data in a hash:
>/usr/share/perl5/PVE/QemuServer.pm: sub vmstatus
> 
> Then there is status.c in pve-cluster which has update_rrd_data.
> 
> So status.c seems to create and update the rrd files. 

yes.

> Who calls it and how does it  get it's data? 

Data is sent wit corosync when you do PVE::Cluster::broadcast_rrd()

> So with my idea i need to add another struct rrd_def_vm_net and
> another folder pve2-net?

It is still not clear if we want a single file, or multiple files. I guess this 
requires 
careful evaluation. How does such system behave when we have 3000VMs? We need
to test that before we go further.


___
pve-devel mailing list
pve-devel@pve.proxmox.com
http://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel


Re: [pve-devel] Feature HW Profiles

2013-04-16 Thread Dietmar Maurer

> return $rpcenv->fork_worker('qmtemplate', $vmid, $authuser, 
> $realcmd);
> 
> PVE::QemuServer::update_config_nolock($vmid, $conf, 1);
> };
> 
> The PVE::QemuServer::update_config_nolock($vmid, $conf, 1); get's never
> executed here in Qemu.pm
> 
> As we have a return before.

Yes, that looks like a bug to me.
___
pve-devel mailing list
pve-devel@pve.proxmox.com
http://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel


[pve-devel] new https server

2013-04-16 Thread Dietmar Maurer
I just committed the code for the new http server. You basically need to update
pve-manager and pve-access-control packages.

We do not longer need apache2 for the api, so you can safely stop and remove 
apache2.

The new service is called pveproxy, and only listens to port 8006 (no redirect 
for port 80 and 443).

The new http server code in PVE::HTTPServer is event based using AnyEvent 
(fully asynchronous). So
we can open many connection and support keep-alive.

The whole server is about 1000 LOC, but code is a bit hard to read because of
the 'continuation passing' style 
(http://en.wikipedia.org/wiki/Continuation-passing_style)

In future, it would be even possible to use Coro 
(http://search.cpan.org/~mlehmann/Coro-6.23/) to
further improve performance.

Please review the code, and report bugs and missing features.

- Dietmar





___
pve-devel mailing list
pve-devel@pve.proxmox.com
http://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel


Re: [pve-devel] Count monthly traffic

2013-04-17 Thread Dietmar Maurer
> > It is still not clear if we want a single file, or multiple files. I
> > guess this requires careful evaluation. How does such system behave
> > when we have 3000VMs? We need to test that before we go further.
> 
> Oh i thought a single file containing 32 net in/out values. I've no idea how 
> to test
> i'm not really familiar with rrd.

It is simply a requirement that you make yourself familiar with the required 
tools
before you start any development - it is not that hard ;-)

___
pve-devel mailing list
pve-devel@pve.proxmox.com
http://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel


Re: [pve-devel] Count monthly traffic

2013-04-17 Thread Dietmar Maurer
> Sure but how to benchmark? Just create a file with 32 values and create
> 2 files (this but be the avg of network interfaces) may be it is just 1.5.
> 
> And then update both each second and look at the disk i/o? Or how did you
> imagine this. I think it makes no sense to compare 32 values agains
> 32 files as most VMs won't have 32 nics.

I want to know how large a file with 32 values is, and how the system behaves 
when we
update 3000 files every 10 seconds. You can easily write a test program to 
write files
at that rate.

I am particularly interested in IO load (on normal ide disks) and memory 
requirements of rrdcached.



___
pve-devel mailing list
pve-devel@pve.proxmox.com
http://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel


Re: [pve-devel] Count monthly traffic

2013-04-17 Thread Dietmar Maurer
> > I am particularly interested in IO load (on normal ide disks) and memory
> requirements of rrdcached.
> 
> Don't have IDE Disks at all. Can only provide SSD or SAS or SATA2 Disks.

I know that you have quite fast hardware. But we need to test on 'normal' 
hardware.
Testing IO on SSDs makes no sense, so simply use the slowest SAS or SATA Disk 
you have ;-)

___
pve-devel mailing list
pve-devel@pve.proxmox.com
http://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel


Re: [pve-devel] Count monthly traffic

2013-04-17 Thread Dietmar Maurer
> But on IDE with 3000 Files it doesn't work every 10s. At least without 
> rrdcache.
> But that sounds in general a way to much for such a HW.

So maybe it is a bad idea to use rrd for that purpose - any other suggestions?

___
pve-devel mailing list
pve-devel@pve.proxmox.com
http://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel


Re: [pve-devel] Count monthly traffic

2013-04-17 Thread Dietmar Maurer
> How have you calculated your 3000 Files?
> 
> 3000 VMs all with 32 nics seems unrealistic to me.

I simply want to show you that this can overload all! servers inside a cluster 
by
just writing rrd files. I am not keen to spend any resources on that task.

> Another way could be to just allow to query actual tap counters through API 
> per
> NIC.
> 
> We then just have no SUM of this data and just a current value.

Where do you plan to store that data?

___
pve-devel mailing list
pve-devel@pve.proxmox.com
http://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel


Re: [pve-devel] Count monthly traffic

2013-04-17 Thread Dietmar Maurer
> How have you calculated your 3000 Files?
> 
> 3000 VMs all with 32 nics seems unrealistic to me.

BTW, we have several users with >500VMs, so I guess we can easily reach that 
limit.

___
pve-devel mailing list
pve-devel@pve.proxmox.com
http://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel


Re: [pve-devel] Count monthly traffic

2013-04-17 Thread Dietmar Maurer
> Nowhere ;-) how about just return the counter values for the correct tap 
> device
> through API?
> 
> So it is basically:
> 1.) a wrapper from netX to correct tap
> 2.) query tap counter inout / output values
> 3.) allow to query this through API
> 
> So it is at least possible to implement traffic account in external software. 
> You
> jsut have to query the API every X seconds and detect resets yourself. It acts
> than basically like SNMP traffic counters in switches.

sounds reasonable.

___
pve-devel mailing list
pve-devel@pve.proxmox.com
http://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel


Re: [pve-devel] Count monthly traffic

2013-04-17 Thread Dietmar Maurer
> >> 3000 VMs all with 32 nics seems unrealistic to me.
> >
> > BTW, we have several users with >500VMs, so I guess we can easily reach that
> limit.
> 
> Sure but those won't have 32 NICs. So if we go the way one file per NIC.
> We might have 3800 files for 3000 VMs. (800 VMs with 2 Nics so they have
> 1600 files and the rest with just one nic)
> 
> Updating those works pretty good even on IDE and even without rrdcached.
> It generates nearly no load at all just 10% I/O Wait. But running so many VMs
> shouldn't be done on IDE anyway.

I am confused now. If we have 500 VMs, we have at least 500 rrd files 
(currently). If you
add one additional file per VM we have 1000 rrd files. If we assume a VM has 
2nics on average
we are at 1500 files...

You wrote that the benchmark does not work at all with 3000 files, so I assume 
it also
generates serious load with 1600 files.


___
pve-devel mailing list
pve-devel@pve.proxmox.com
http://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel


Re: [pve-devel] Add "sound card" to VM's from WebUI

2013-04-17 Thread Dietmar Maurer
> Is this feature planned ?

no, not really.

> And if not, would patches be accepted to add this feature ?

I do not think that is needed.

> Use cases:
> 
> -Virtual Terminal Services (Required for RDS Remote Sound)
> -Virtual Desktop Infrastructure

All known VDI solutions provide some kind of virtual sound device (RDP, spice),
so there is no need to add any sound card.

___
pve-devel mailing list
pve-devel@pve.proxmox.com
http://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel


Re: [pve-devel] Process to submit patches

2013-04-17 Thread Dietmar Maurer
> We have been running this successfully for a few weeks now on the default PVE
> kernel with no issues.
> 
> I searched the list archives, and the issues I could see looked like they were
> related to the MTU on the parent physical interface being too small.
> 
> Linux does not clearly differentiate between L2 (interface) and L3 (IP) MTU, 
> and
> also has a hidden 4 byte allowance on the interface MTU, making it confusing.
> When running QinQ the parent physical interface needs a MTU of at least 1504
> bytes (allows a 1508 byte frame), any sub vlan's and bridges will then 
> inherit this
> MTU allowing for the "inner" tag to pass externally correctly.
> 
> Obviously if the users are not doing QinQ the parent physical interface can be
> the default 1500byte MTU and will work perfectly.

@Alexandre: Do you have some spare time to test that again using MTU 1504?

___
pve-devel mailing list
pve-devel@pve.proxmox.com
http://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel


Re: [pve-devel] Process to submit patches

2013-04-17 Thread Dietmar Maurer
> Linux does not clearly differentiate between L2 (interface) and L3 (IP) MTU, 
> and
> also has a hidden 4 byte allowance on the interface MTU, making it confusing.
> When running QinQ the parent physical interface needs a MTU of at least 1504
> bytes (allows a 1508 byte frame), any sub vlan's and bridges will then 
> inherit this
> MTU allowing for the "inner" tag to pass externally correctly.

And what are the correct settings for jumbo frames (MTU 9000)?

___
pve-devel mailing list
pve-devel@pve.proxmox.com
http://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel


Re: [pve-devel] Count monthly traffic

2013-04-17 Thread Dietmar Maurer
> Then let's go this way. It's much simpler than adding RRD.
> 
> So the question is should this be a completely new call 

Yes, I think this should be a new call:

GET /nodes//netstat

[
{vmid => 100, dev => net0, in => XXX, out => YYY},
{vmid => 100, dev => net1, in => XXX, out => YYY},
{vmid => 200, dev => net0, in => XXX, out => YYY},
]

So that we can get all data with one API call.






___
pve-devel mailing list
pve-devel@pve.proxmox.com
http://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel


Re: [pve-devel] Process to submit patches

2013-04-17 Thread Dietmar Maurer
> It depends on what size frame you are trying to pass.  Anything over
> 1504 bytes is considered "Jumbo".  An MTU of 9000 would allow you to pass a
> 9004byte frame.  If you were doing "jumbo" frames to one of your VM's and
> wanted double tagging you would set your physical interface with an MTU of
> 9004 to allow for a 9008byte frame.

But AFAIK MTU >9000 is not possible with most network hardware?

___
pve-devel mailing list
pve-devel@pve.proxmox.com
http://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel


Re: [pve-devel] Count monthly traffic

2013-04-17 Thread Dietmar Maurer
> Patch sent. I used a different output format which has the vmid as a key so 
> it is
> easier to access the right information as nobody needs to loop through the
> array.

But that format does not work with an ExtJS grid widget (in case someone wants 
to display it on the GUI)?

___
pve-devel mailing list
pve-devel@pve.proxmox.com
http://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel


Re: [pve-devel] new https server

2013-04-17 Thread Dietmar Maurer
> BTW, I finally get tls working with spice, I'll submit patches this week.
> Do you think it's possible to use this new http server as  CONNECT proxy ?

Honestly, I never implemented HTTP Connect method. But we now have full
control on the web server, so we can do anything we want ;-)

I guess it is possible.

BTW, does spice support websockets, or only HTTP Connect?
___
pve-devel mailing list
pve-devel@pve.proxmox.com
http://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel


Re: [pve-devel] Count monthly traffic

2013-04-17 Thread Dietmar Maurer
> Oh ok sorry didn't know that. I can change it but i don't see any useful 
> usage to
> display these values. They're just counters rising up to 64bit and then reset
> through the lifetime of a VM. I think without useful deltas and history there 
> is no
> usage. But i can still change it if you want. Just tell me.

yes, I would prefer the other format.

___
pve-devel mailing list
pve-devel@pve.proxmox.com
http://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel


Re: [pve-devel] [PATCH] implement node netstat call to get current tap network counters

2013-04-17 Thread Dietmar Maurer
> + $res->{$vmid}{'net'.$netid}{out} = $netdev->{$dev}->{receive};
> + $res->{$vmid}{'net'.$netid}{in} = $netdev->{$dev}->{transmit};

I also prefer "net$netid" instead of 'net'.$netid

___
pve-devel mailing list
pve-devel@pve.proxmox.com
http://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel


Re: [pve-devel] [PATCH] implement node netstat call to get current tap network counters

2013-04-17 Thread Dietmar Maurer
> Is this a bug?
> 
> The code in vmstatus seems to be wrong for netout and netin
> 
>  $d->{netout} += $netdev->{$dev}->{receive};
>  $d->{netin} += $netdev->{$dev}->{transmit};
> 
> 
> netin is receive and netout is transmit... isn't it?

Should be easy to test by downloading a file inside the VM - please can you 
test that?

___
pve-devel mailing list
pve-devel@pve.proxmox.com
http://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel


Re: [pve-devel] new https server

2013-04-18 Thread Dietmar Maurer
> We need to use websockets (for spice-html5), using websocky (python or C
> implementation)
> 
> https://github.com/kanaka/websockify

We can easily implement websockets with the new HTTPServer, so I guess there is 
no need
for an external server.

> I have redone tests with spice-html5 last week, it's works better than last 
> yeay,
> but they are some display bugs, and it's slower than spice-gtk.

I still prefer spice and VNC.
___
pve-devel mailing list
pve-devel@pve.proxmox.com
http://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel


Re: [pve-devel] cpu 100% when get vmstaus

2013-04-18 Thread Dietmar Maurer
I am finally able to reproduce this - will work on a fix now.

> -Original Message-
> From: lulin [mailto:f_e...@yeah.net]
> Sent: Montag, 25. Februar 2013 08:48
> To: Dietmar Maurer
> Cc: pve-devel@pve.proxmox.com
> Subject: Re:RE: [pve-devel] cpu 100% when get vmstaus
> 
> Hi
> 
> Not easy to reproduce it. I traced it for a long time, It seems if the server 
> have a
> heavy load it will be easier..
> 
> I tested with pve-qemu-kvm-1.3(with backup patches)..
> 
> 
> Regards
> 
> 
> 
> At 2013-02-25 13:28:43,"Dietmar Maurer"  wrote:
> 
> Is there a way to reproduce that behavior? You already tested with new pve-
> qemu-kvm (1.4)?
> 
> From: pve-devel-boun...@pve.proxmox.com [mailto:pve-devel-
> boun...@pve.proxmox.com] On Behalf Of lulin
> Sent: Samstag, 23. Februar 2013 11:33
> To: pve-devel@pve.proxmox.com
> Subject: [pve-devel] cpu 100% when get vmstaus
> 
> Hi
> I don't know if it is a bug, sometimes when you shudown a VM,  pvedaemon will
> have 100% cpu usage.

___
pve-devel mailing list
pve-devel@pve.proxmox.com
http://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel


Re: [pve-devel] [PATCH] [V3] implement node netstat call to get current tap network counters

2013-04-18 Thread Dietmar Maurer
I am unable to apply that patch, I get

error: API2/Nodes.pm: does not exist in index

correct path is PVE/API2/Nodes.pm?

> -Original Message-
> From: pve-devel-boun...@pve.proxmox.com [mailto:pve-devel-
> boun...@pve.proxmox.com] On Behalf Of Stefan Priebe
> Sent: Donnerstag, 18. April 2013 09:04
> To: pve-devel@pve.proxmox.com
> Subject: [pve-devel] [PATCH] [V3] implement node netstat call to get current 
> tap
> network counters
> 
> Changes since V2:
> - swap in / out / transmit / receive again
> 
> Changes since V1:
> - new return format (use an arrayref instead of a hash to be JS compatible)
> - swap in / out / transmit / receive
> 
> Signed-off-by: Stefan Priebe 
> ---
>  API2/Nodes.pm |   48
> 
>  1 file changed, 48 insertions(+)
> 
> diff --git a/API2/Nodes.pm b/API2/Nodes.pm index 0dac6af..ee351c3 100644
> --- a/API2/Nodes.pm
> +++ b/API2/Nodes.pm
> @@ -123,6 +123,7 @@ __PACKAGE__->register_method ({
>   { name => 'aplinfo' },
>   { name => 'startall' },
>   { name => 'stopall' },
> + { name => 'netstat' },
>   ];
> 
>   return $result;
> @@ -273,6 +274,53 @@ __PACKAGE__->register_method({
>  }});
> 
>  __PACKAGE__->register_method({
> +name => 'netstat',
> +path => 'netstat',
> +method => 'GET',
> +permissions => {
> + check => ['perm', '/nodes/{node}', [ 'Sys.Audit' ]],
> +},
> +description => "Read tap/vm network device interface counters",
> +proxyto => 'node',
> +parameters => {
> + additionalProperties => 0,
> + properties => {
> + node => get_standard_option('pve-node'),
> + },
> +},
> +returns => {
> +type => "array",
> +items => {
> +type => "object",
> +properties => {},
> +},
> +},
> +code => sub {
> + my ($param) = @_;
> +
> + my $res = [ ];
> +
> + my $netdev = PVE::ProcFSTools::read_proc_net_dev();
> + foreach my $dev (keys %$netdev) {
> + next if $dev !~ m/^tap([1-9]\d*)i(\d+)$/;
> + my $vmid = $1;
> + my $netid = $2;
> +
> +push(
> +@$res,
> +{
> +vmid => $vmid,
> +dev  => "net$netid",
> +in   => $netdev->{$dev}->{transmit},
> +out  => $netdev->{$dev}->{receive},
> +}
> +);
> + }
> +
> + return $res;
> +}});
> +
> +__PACKAGE__->register_method({
>  name => 'node_cmd',
>  path => 'status',
>  method => 'POST',
> --
> 1.7.10.4
> 
> ___
> pve-devel mailing list
> pve-devel@pve.proxmox.com
> http://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel


___
pve-devel mailing list
pve-devel@pve.proxmox.com
http://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel


Re: [pve-devel] new https server

2013-04-18 Thread Dietmar Maurer
What is the output of

# pveversion -v

I have:

# pveversion -v
pve-manager: 3.0-9 (pve-manager/3.0/849b37a1)
running kernel: 2.6.32-20-pve
pve-kernel-2.6.32-20-pve: 2.6.32-96
pve-kernel-2.6.32-19-pve: 2.6.32-94
lvm2: 2.02.95-pve3
clvm: 2.02.95-pve3
corosync-pve: 1.4.5-1
openais-pve: 1.1.4-3
libqb0: 0.11.1-2
redhat-cluster-pve: 3.2.0-2
resource-agents-pve: 3.9.2-4
fence-agents-pve: 4.0.0-1
pve-cluster: 3.0-1
qemu-server: 3.0-3
pve-firmware: 1.0-22
libpve-common-perl: 3.0-1
libpve-access-control: 3.0-2
libpve-storage-perl: 3.0-1
vncterm: 1.1-1
vzctl: 4.0-1pve3
vzprocps: 2.0.11-2
vzquota: 3.1-2


> -Original Message-
> From: Alexandre DERUMIER [mailto:aderum...@odiso.com]
> Sent: Donnerstag, 18. April 2013 15:50
> To: Dietmar Maurer
> Cc: pve-devel@pve.proxmox.com
> Subject: Re: [pve-devel] new https server
> 
> I have same error with pvedaemon
> 
> Maybe I have forgot something ?
> 
> I have updated : qemu-server,pve-manager,pve-access-control
___
pve-devel mailing list
pve-devel@pve.proxmox.com
http://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel


Re: [pve-devel] [PATCH] [V3] implement node netstat call to get current tap network counters

2013-04-18 Thread Dietmar Maurer
Will you send a correct patch?

> *urg* sorry yes correct path is PVE/API2/Nodes.pm.
> 
> Am 18.04.2013 11:17, schrieb Dietmar Maurer:
> > I am unable to apply that patch, I get
> >
> > error: API2/Nodes.pm: does not exist in index
> >
> > correct path is PVE/API2/Nodes.pm?

___
pve-devel mailing list
pve-devel@pve.proxmox.com
http://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel


Re: [pve-devel] [PATCH 3/3] template_create : add template:1 option.

2013-04-18 Thread Dietmar Maurer
Hi Akexandre,

I applied part1 and 2, but I do not really understand this one.

> diff --git a/PVE/QemuServer.pm b/PVE/QemuServer.pm
> index 7c20f55..1352e24 100644
> --- a/PVE/QemuServer.pm
> +++ b/PVE/QemuServer.pm
> @@ -4448,17 +4448,8 @@ sub template_create {
>   return if $disk && $ds ne $disk;
> 
>   my $volid = $drive->{file};
> - die "volume '$volid' does not support template/clone\n"
> - if !PVE::Storage::volume_has_feature($storecfg, 'template', $volid);
> -});

why do you remove that check?


___
pve-devel mailing list
pve-devel@pve.proxmox.com
http://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel


Re: [pve-devel] new https server

2013-04-19 Thread Dietmar Maurer
# md5sum /usr/share/perl5/PVE/QemuServer.pm
7ee43527e5cd9004b0f9fbabf3934ec9  /usr/share/perl5/PVE/QemuServer.pm

is that correct on your side?

> -Original Message-
> From: Alexandre DERUMIER [mailto:aderum...@odiso.com]
> Sent: Freitag, 19. April 2013 09:10
> To: Dietmar Maurer
> Cc: pve-devel@pve.proxmox.com
> Subject: Re: [pve-devel] new https server
> 
> seem to be related to path where we are we lauching pvedaemon or init script
> 
> any idea ?
___
pve-devel mailing list
pve-devel@pve.proxmox.com
http://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel


Re: [pve-devel] user rights

2013-04-19 Thread Dietmar Maurer
> I tried to limit a user to two pathes:
> /nodes/
> and
> /cluster/resources
> 
> but that did not work i added two entries to Rights. Is this not possible?

what did not work?


___
pve-devel mailing list
pve-devel@pve.proxmox.com
http://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel


Re: [pve-devel] new https server

2013-04-19 Thread Dietmar Maurer
oh, there is still some debugging code there:

use lib '..';

I removed that now. Please can you update pve-manager and re-test?

> -Original Message-
> From: Alexandre DERUMIER [mailto:aderum...@odiso.com]
> Sent: Freitag, 19. April 2013 09:44
> To: Dietmar Maurer
> Cc: pve-devel@pve.proxmox.com
> Subject: Re: [pve-devel] new https server
> 
> >>is that correct on your side?
> 
> yes :/
> 
> # md5sum /usr/share/perl5/PVE/QemuServer.pm
> 7ee43527e5cd9004b0f9fbabf3934ec9 /usr/share/perl5/PVE/QemuServer.pm
> 
> 
> seem to be related to pve-manager package, I have downgrade it and
> pvedaemon start fine now.
> 
> 
> 
> 
> - Mail original -
> 
> De: "Dietmar Maurer" 
> À: "Alexandre DERUMIER" 
> Cc: pve-devel@pve.proxmox.com
> Envoyé: Vendredi 19 Avril 2013 09:27:34
> Objet: RE: [pve-devel] new https server
> 
> # md5sum /usr/share/perl5/PVE/QemuServer.pm
> 7ee43527e5cd9004b0f9fbabf3934ec9 /usr/share/perl5/PVE/QemuServer.pm
> 
> is that correct on your side?
> 
> > -----Original Message-
> > From: Alexandre DERUMIER [mailto:aderum...@odiso.com]
> > Sent: Freitag, 19. April 2013 09:10
> > To: Dietmar Maurer
> > Cc: pve-devel@pve.proxmox.com
> > Subject: Re: [pve-devel] new https server
> >
> > seem to be related to path where we are we lauching pvedaemon or init script
> >
> > any idea ?

___
pve-devel mailing list
pve-devel@pve.proxmox.com
http://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel


Re: [pve-devel] user rights

2013-04-19 Thread Dietmar Maurer
> Access to /nodes/ works access to /cluster/resources did not work.
> 
> If i remove both and add:
> / userX
> 
> access to both worked.

Well, we do not have check at this fine grained level. Why do you need that?

___
pve-devel mailing list
pve-devel@pve.proxmox.com
http://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel


Re: [pve-devel] [PATCH 3/3] template_create : add template:1 option.

2013-04-19 Thread Dietmar Maurer
> Because you tell me that a template can have non-based name disk. (now a
> template is just a vm with template:1 option)

I just meant that we can tolerate that error if a use manually configure such 
nonsense.
I am quite unsure if we should make that a feature.

___
pve-devel mailing list
pve-devel@pve.proxmox.com
http://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel


Re: [pve-devel] [PATCH] rbd is format raw for qemu-img

2013-04-19 Thread Dietmar Maurer
applied, thanks

> -Original Message-
> From: pve-devel-boun...@pve.proxmox.com [mailto:pve-devel-
> boun...@pve.proxmox.com] On Behalf Of Stefan Priebe
> Sent: Freitag, 19. April 2013 08:36
> To: pve-devel@pve.proxmox.com
> Subject: [pve-devel] [PATCH] rbd is format raw for qemu-img
> 
> 
> Signed-off-by: Stefan Priebe 
> ---
>  PVE/QemuServer.pm |5 -
>  1 file changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git a/PVE/QemuServer.pm b/PVE/QemuServer.pm index
> 03e5018..5347a5b 100644
> --- a/PVE/QemuServer.pm
> +++ b/PVE/QemuServer.pm
> @@ -4542,7 +4542,10 @@ sub qemu_img_format {
>  elsif ($scfg->{type} eq 'lvm' || $scfg->{type} eq 'iscsi'){
>   return "host_device";
>  }
> -#sheepdog,rbd,or other qemu block driver
> +elsif ($scfg->{type} eq 'rbd'){
> + return "raw";
> +}
> +#sheepdog,or other qemu block driver
>  else{
>   return $scfg->{type};
>  }
> --
> 1.7.10.4
> 
> ___
> pve-devel mailing list
> pve-devel@pve.proxmox.com
> http://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel


___
pve-devel mailing list
pve-devel@pve.proxmox.com
http://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel


Re: [pve-devel] [PATCH] use vm create permissions for templates

2013-04-19 Thread Dietmar Maurer

applied
> -Original Message-
> From: pve-devel-boun...@pve.proxmox.com [mailto:pve-devel-
> boun...@pve.proxmox.com] On Behalf Of Stefan Priebe
> Sent: Freitag, 19. April 2013 08:38
> To: pve-devel@pve.proxmox.com
> Subject: [pve-devel] [PATCH] use vm create permissions for templates

___
pve-devel mailing list
pve-devel@pve.proxmox.com
http://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel


Re: [pve-devel] [PATCH] implement node netstat call to get current tap network counters

2013-04-19 Thread Dietmar Maurer
applied, thanks

> -Original Message-
> From: pve-devel-boun...@pve.proxmox.com [mailto:pve-devel-
> boun...@pve.proxmox.com] On Behalf Of Stefan Priebe
> Sent: Freitag, 19. April 2013 08:38
> To: pve-devel@pve.proxmox.com
> Subject: [pve-devel] [PATCH] implement node netstat call to get current tap
> network counters

___
pve-devel mailing list
pve-devel@pve.proxmox.com
http://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel


Re: [pve-devel] [PATCH] rbd is format raw for qemu-img

2013-04-19 Thread Dietmar Maurer
> applied, thanks

sorry - I have not applied that - ignore me.

> 
> > -Original Message-
> > From: pve-devel-boun...@pve.proxmox.com [mailto:pve-devel-
> > boun...@pve.proxmox.com] On Behalf Of Stefan Priebe
> > Sent: Freitag, 19. April 2013 08:36
> > To: pve-devel@pve.proxmox.com
> > Subject: [pve-devel] [PATCH] rbd is format raw for qemu-img
> >
> 


___
pve-devel mailing list
pve-devel@pve.proxmox.com
http://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel


Re: [pve-devel] user rights

2013-04-19 Thread Dietmar Maurer

> i like to restrict the users as much as possible.


Sure, but our permission works on resources (VMs, Storages), not on API paths.

For example /cluster/resources simply lists all resources you have 
access to (VM.Audit or VMs, Datastore.Audit for storage).


___
pve-devel mailing list
pve-devel@pve.proxmox.com
http://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel


Re: [pve-devel] user rights

2013-04-19 Thread Dietmar Maurer
> > Sure, but our permission works on resources (VMs, Storages), not on API 
> > paths.
> >
> > For example /cluster/resources simply lists all resources you have
> > access to (VM.Audit or VMs, Datastore.Audit for storage).
> 
> Ah sorry didn't know that. It looked like it is path based. Sorry for that.

Well, we use paths to specify resources, for example /vms/100 or /storage/test.
But we do not use the API access path to restrict the API call itself.

Hope I did not confused you totally now ;-)




___
pve-devel mailing list
pve-devel@pve.proxmox.com
http://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel


Re: [pve-devel] new vnc 1.2 works fine now with http://fqdn....

2013-04-19 Thread Dietmar Maurer
> just a report to say that new vnc 1.2 works fine for me now

What new vnc 1.2?
 


___
pve-devel mailing list
pve-devel@pve.proxmox.com
http://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel


Re: [pve-devel] new vnc 1.2 works fine now with http://fqdn....

2013-04-19 Thread Dietmar Maurer
I played around with new tigervnc 1.2.0, but never activated the new code.

So I guess you still run the old 1.1.0 code.

The good news is that the old code seems to run now.

We still not know why, but things started to magically work again last week.

There where java updates from oracle, and openssl/tls updates on wheezy, 
 
The bad news is that latest java always pops up a dialog (security warning)- 
what a mess.

> -Original Message-
> From: pve-devel-boun...@pve.proxmox.com [mailto:pve-devel-
> boun...@pve.proxmox.com] On Behalf Of Dietmar Maurer
> Sent: Freitag, 19. April 2013 16:04
> To: Alexandre DERUMIER; pve-devel@pve.proxmox.com
> Subject: Re: [pve-devel] new vnc 1.2 works fine now with http://fqdn
> 
> > just a report to say that new vnc 1.2 works fine for me now
> 
> What new vnc 1.2?
> 
> 
> 
> ___
> pve-devel mailing list
> pve-devel@pve.proxmox.com
> http://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel


___
pve-devel mailing list
pve-devel@pve.proxmox.com
http://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel


Re: [pve-devel] new vnc 1.2 works fine now with http://fqdn....

2013-04-19 Thread Dietmar Maurer
> I played around with new tigervnc 1.2.0, but never activated the new code.

For further info on that see:

https://sourceforge.net/tracker/?func=detail&aid=3488166&group_id=254363&atid=1126849



___
pve-devel mailing list
pve-devel@pve.proxmox.com
http://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel


Re: [pve-devel] new vnc 1.2 works fine now with http://fqdn....

2013-04-19 Thread Dietmar Maurer
> Oops, sorry, It's work fine after unblock, my vm was not started ;)
> 
> Don't known why all the code is not signed

Our Applet is signed, but seem that oracle does not like our certificate.
You can even install the CA as trusted CA, does not help.

But you can set java "Mixed Code" option to

"hide warning and run with protections"

IMHO, oracle does not really know what they do.
I mean, if a user wants to trust in something , why does he need to answer
that question again and again?

And why is the code mixed? (I sign the whole applet?)

Any insights are welcome.


___
pve-devel mailing list
pve-devel@pve.proxmox.com
http://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel


Re: [pve-devel] new vnc 1.2 works fine now with http://fqdn....

2013-04-20 Thread Dietmar Maurer


> -Original Message-
> From: Alexandre DERUMIER [mailto:aderum...@odiso.com]
> Sent: Samstag, 20. April 2013 09:03
> To: Dietmar Maurer
> Cc: pve-devel@pve.proxmox.com
> Subject: Re: [pve-devel] new vnc 1.2 works fine now with http://fqdn
> 
> If I understand, it seem that the problem is that we interact from extjs 
> javascript
> (unsigned code) with vnc java console (signed code).
> 
> Maybe adding "Trusted-Library: true " to VncViewer.jar manifest.mf could help 
> ?

What manifest.mf?
___
pve-devel mailing list
pve-devel@pve.proxmox.com
http://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel


Re: [pve-devel] new vnc 1.2 works fine now with http://fqdn....

2013-04-20 Thread Dietmar Maurer
> Per the release notes: As of JDK 7u21, JavaScript code that calls code within 
> a
> privileged applet is treated as mixed code and warning dialogs are raised if 
> the
> signed JAR files are not tagged with the Trusted-Library attribute.

But that is a good hint, thanks.

I will do further investigations next week.
___
pve-devel mailing list
pve-devel@pve.proxmox.com
http://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel


Re: [pve-devel] Disk removed from config but not named unused

2013-04-20 Thread Dietmar Maurer
> right now if i remove a disk from config it doesn't get reinserted as unused.
> Anybody seen this before?

The disk is 'owned' by the VM? (Disk name looks like 'vm-$VMID-a-name...'?) 

___
pve-devel mailing list
pve-devel@pve.proxmox.com
http://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel


Re: [pve-devel] new vnc 1.2 works fine now with http://fqdn....

2013-04-20 Thread Dietmar Maurer
Hi Alexandre,

that really solved the problem - please can you verify:

https://git.proxmox.com/?p=vncterm.git;a=summary

Many thanks for finding this!

Besides, I still do not understand how that improves security.

> -Original Message-
> From: Alexandre DERUMIER [mailto:aderum...@odiso.com]
> Sent: Samstag, 20. April 2013 09:03
> To: Dietmar Maurer
> Cc: pve-devel@pve.proxmox.com
> Subject: Re: [pve-devel] new vnc 1.2 works fine now with http://fqdn
> 
> If I understand, it seem that the problem is that we interact from extjs 
> javascript
> (unsigned code) with vnc java console (signed code).
> 
> Maybe adding "Trusted-Library: true " to VncViewer.jar manifest.mf could help 
> ?
> 
> 
> - Mail original -
> 
> De: "Alexandre DERUMIER" 
> À: "Dietmar Maurer" 
> Cc: pve-devel@pve.proxmox.com
> Envoyé: Samedi 20 Avril 2013 08:56:29
> Objet: Re: [pve-devel] new vnc 1.2 works fine now with http://fqdn
> 
> I found this on the net:
> 
> "
> Java 7 Update 21 was released on April 16 2013 and caused our applet to start
> showing this warning dialog.
> 
> Per the release notes: As of JDK 7u21, JavaScript code that calls code within 
> a
> privileged applet is treated as mixed code and warning dialogs are raised if 
> the
> signed JAR files are not tagged with the Trusted-Library attribute.
> 
> To fix this edit your manifest.mf file and add a line like this:
> 
> Trusted-Library: true
> You should be very careful before doing this though. If your signed applet 
> can be
> called from javascript then a malicious user can potentially do harmful 
> things on
> your users' computers.
> 
> One quick way to secure your applet is to prevent it from being run on other
> websites. Do this by putting code in the init() method that looks at
> getCodeBase().getHost() and throws an exception if it does not match your 
> site.
> "
> 
> - Mail original -
> 
> De: "Dietmar Maurer" 
> À: "Alexandre DERUMIER" 
> Cc: pve-devel@pve.proxmox.com
> Envoyé: Vendredi 19 Avril 2013 18:10:12
> Objet: RE: [pve-devel] new vnc 1.2 works fine now with http://fqdn
> 
> > Oops, sorry, It's work fine after unblock, my vm was not started ;)
> >
> > Don't known why all the code is not signed
> 
> Our Applet is signed, but seem that oracle does not like our certificate.
> You can even install the CA as trusted CA, does not help.
> 
> But you can set java "Mixed Code" option to
> 
> "hide warning and run with protections"
> 
> IMHO, oracle does not really know what they do.
> I mean, if a user wants to trust in something , why does he need to answer 
> that
> question again and again?
> 
> And why is the code mixed? (I sign the whole applet?)
> 
> Any insights are welcome.
> ___
> pve-devel mailing list
> pve-devel@pve.proxmox.com
> http://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

___
pve-devel mailing list
pve-devel@pve.proxmox.com
http://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel


Re: [pve-devel] Disk removed from config but not named unused

2013-04-20 Thread Dietmar Maurer
Do you have a re-producible test case?

> >> right now if i remove a disk from config it doesn't get reinserted as 
> >> unused.
> >> Anybody seen this before?
> >
> > The disk is 'owned' by the VM? (Disk name looks like 'vm-$VMID-a-name...'?)
> >
> Yes

___
pve-devel mailing list
pve-devel@pve.proxmox.com
http://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel


Re: [pve-devel] new vnc 1.2 works fine now with http://fqdn....

2013-04-20 Thread Dietmar Maurer
> > Besides, I still do not understand how that improves security.
> >
> It does not. Java applets are, security wise, defective by design! 

I do not really understand that. It is exactly the same if
you download and install a program? So why is java defective by design?

___
pve-devel mailing list
pve-devel@pve.proxmox.com
http://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel


Re: [pve-devel] new vnc 1.2 works fine now with http://fqdn....

2013-04-21 Thread Dietmar Maurer
> You miss the point. Once you accept a digitally signed applet from a specific
> source you have forever accepted any applet signed with this certificate
> regardless of the server sending it to you to run on your computer with full
> access. If the user also have answered yes to run this applet every time 
> there will
> be no warning the next time an applet signed with the same certificate wants 
> to
> run on the users computer regardless of the applets point of origin.

No, I do not miss the point. I do not say that this is particularly good,
but it is not really worse than an locally installed application with 
'auto-update' feature.
I am always scared when I see what my printer driver software is doing ;-)

Besides, I do not understand why oracle choose such defaults. I guess it would
be much safer to only allow specific applets.

___
pve-devel mailing list
pve-devel@pve.proxmox.com
http://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel


Re: [pve-devel] Disk removed from config but not named unused

2013-04-21 Thread Dietmar Maurer
> > Am 20.04.2013 16:15, schrieb Dietmar Maurer:
> >> Do you have a re-producible test case?
> >
> > Ah i got it. That VM / Disk had a parent snapshot...
> 
> mhm but even than shouldn't it be listed as unused0?

Yes, maybe that would be better.

___
pve-devel mailing list
pve-devel@pve.proxmox.com
http://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel


Re: [pve-devel] new vnc 1.2 works fine now with http://fqdn....

2013-04-21 Thread Dietmar Maurer
Would it be better if you use java webstart? Is that considered safer?

> > You miss the point. Once you accept a digitally signed applet from a
> > specific source you have forever accepted any applet signed with this
> > certificate regardless of the server sending it to you to run on your
> > computer with full access. If the user also have answered yes to run
> > this applet every time there will be no warning the next time an
> > applet signed with the same certificate wants to run on the users computer
> regardless of the applets point of origin.
> 
> No, I do not miss the point. I do not say that this is particularly good, but 
> it is not
> really worse than an locally installed application with 'auto-update' feature.
> I am always scared when I see what my printer driver software is doing ;-)
> 
> Besides, I do not understand why oracle choose such defaults. I guess it would
> be much safer to only allow specific applets.

___
pve-devel mailing list
pve-devel@pve.proxmox.com
http://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel


Re: [pve-devel] Disk removed from config but not named unused

2013-04-21 Thread Dietmar Maurer
> >>> Ah i got it. That VM / Disk had a parent snapshot...
> >>
> >> mhm but even than shouldn't it be listed as unused0?
> >
> > Yes, maybe that would be better.
> 
> Should i send a patch? Could you point me to the direction?

I am still not sure how to handle that correctly.

___
pve-devel mailing list
pve-devel@pve.proxmox.com
http://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel


Re: [pve-devel] how to get currently selected node in ExtJS?

2013-04-21 Thread Dietmar Maurer
> How to get currently selected node in ExtJS?
> 
> I tried stuff like:
> Ext.get('PVE.tree.ResourceTree')
> PVE.tree.ResourceTree.getSelection()[0]

AFAIK there is no such functionality, because it was not needed so far.

The question is why you need that?

___
pve-devel mailing list
pve-devel@pve.proxmox.com
http://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel


Re: [pve-devel] [PATCH] rbd -p parameter is only valid for the src (see man). Add the pool to the target as well.

2013-04-21 Thread Dietmar Maurer
applied, thanks!

> -Original Message-
> From: pve-devel-boun...@pve.proxmox.com [mailto:pve-devel-
> boun...@pve.proxmox.com] On Behalf Of Stefan Priebe
> Sent: Sonntag, 21. April 2013 20:05
> To: pve-devel@pve.proxmox.com
> Subject: [pve-devel] [PATCH] rbd -p parameter is only valid for the src (see 
> man).
> Add the pool to the target as well.

___
pve-devel mailing list
pve-devel@pve.proxmox.com
http://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel


Re: [pve-devel] how to get currently selected node in ExtJS?

2013-04-21 Thread Dietmar Maurer
> > The question is why you need that?
> >
> 
> All people i was talking to wanted the node they're currently selected to be
> preselected in the create wizard. They all created vms on the wrong nodes ;-)

In Workspace.js, we call setContent() every time the user selects someting.

Maybe you can use that to store the last selected node into a global var?

___
pve-devel mailing list
pve-devel@pve.proxmox.com
http://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel


Re: [pve-devel] how to get currently selected node in ExtJS?

2013-04-21 Thread Dietmar Maurer
> > All people i was talking to wanted the node they're currently selected
> > to be preselected in the create wizard. They all created vms on the
> > wrong nodes ;-)
> 
> In Workspace.js, we call setContent() every time the user selects someting.
> 
> Maybe you can use that to store the last selected node into a global var?

Or maybe it is better/easier to do that in PVE.node.Config

___
pve-devel mailing list
pve-devel@pve.proxmox.com
http://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel


Re: [pve-devel] [PATCH] template create : add template:1 option

2013-04-21 Thread Dietmar Maurer
Hi Alexandre,

after the weekend, I decided to commit your first version. I also applied some
cleanups.

Please can you check it that works for you?

> -Original Message-
> From: pve-devel-boun...@pve.proxmox.com [mailto:pve-devel-
> boun...@pve.proxmox.com] On Behalf Of Alexandre Derumier
> Sent: Freitag, 19. April 2013 15:57
> To: pve-devel@pve.proxmox.com
> Subject: [pve-devel] [PATCH] template create : add template:1 option

___
pve-devel mailing list
pve-devel@pve.proxmox.com
http://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel


Re: [pve-devel] new vnc 1.2 works fine now with http://fqdn....

2013-04-21 Thread Dietmar Maurer
> Would it be better if you use java webstart? Is that considered safer?

After reading more docs, I think webstart does not really offer any advantage 
for our use case.

___
pve-devel mailing list
pve-devel@pve.proxmox.com
http://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel


Re: [pve-devel] Disk removed from config but not named unused

2013-04-21 Thread Dietmar Maurer
> > I am still not sure how to handle that correctly.
> >
> 
> I think we must add it as unused otherwise the disk is lost... it makes more 
> sense
> to maybe prevent deleting of that unused one.

I thought about introducing 'hidden' disks. But I guess it is easier to just
add them as unused, and take special care to prevent deletion.

___
pve-devel mailing list
pve-devel@pve.proxmox.com
http://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel


Re: [pve-devel] [PATCH] template create : add template:1 option

2013-04-22 Thread Dietmar Maurer
So we need to adopt that check. I just applied a fix

die "unable to create template, because VM contains snapshots\n" 
if $conf->{snapshots} && scalar(keys %{$conf->{snapshots}});




> -Original Message-
> From: Alexandre DERUMIER [mailto:aderum...@odiso.com]
> Sent: Montag, 22. April 2013 09:03
> To: Dietmar Maurer
> Cc: pve-devel@pve.proxmox.com
> Subject: Re: [pve-devel] [PATCH] template create : add template:1 option
___
pve-devel mailing list
pve-devel@pve.proxmox.com
http://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel


Re: [pve-devel] [PATCH] template create : add template:1 option

2013-04-22 Thread Dietmar Maurer
sorry, just pushed the update - will arrive in a few minutes.

> -Original Message-
> From: Alexandre DERUMIER [mailto:aderum...@odiso.com]
> Sent: Montag, 22. April 2013 09:37
> To: Dietmar Maurer
> Cc: pve-devel@pve.proxmox.com
> Subject: Re: [pve-devel] [PATCH] template create : add template:1 option
> 
> 
> I don't see the commit in proxmox git ?
> 
> 
> 
> - Mail original -
> 
> De: "Dietmar Maurer" 
> À: "Alexandre DERUMIER" 
> Cc: pve-devel@pve.proxmox.com
> Envoyé: Lundi 22 Avril 2013 09:09:44
> Objet: RE: [pve-devel] [PATCH] template create : add template:1 option
> 
> So we need to adopt that check. I just applied a fix
> 
> die "unable to create template, because VM contains snapshots\n"
> if $conf->{snapshots} && scalar(keys %{$conf->{snapshots}});
> 
> 
> 
> 
> > -Original Message-
> > From: Alexandre DERUMIER [mailto:aderum...@odiso.com]
> > Sent: Montag, 22. April 2013 09:03
> > To: Dietmar Maurer
> > Cc: pve-devel@pve.proxmox.com
> > Subject: Re: [pve-devel] [PATCH] template create : add template:1 option
___
pve-devel mailing list
pve-devel@pve.proxmox.com
http://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel


Re: [pve-devel] how to get currently selected node in ExtJS?

2013-04-22 Thread Dietmar Maurer
> i would like todo it in pveResourceTree => selectionchange so i can store the
> node even if someone selects a VM.

OK

> I just don't know how to introduce a global var...

example:

PVE.lastSelectedNode = 'testnode';


___
pve-devel mailing list
pve-devel@pve.proxmox.com
http://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel


Re: [pve-devel] [PATCH] Nodeselector: change default sort to name instead of mem

2013-04-22 Thread Dietmar Maurer
why?

> -Original Message-
> From: pve-devel-boun...@pve.proxmox.com [mailto:pve-devel-
> boun...@pve.proxmox.com] On Behalf Of Stefan Priebe
> Sent: Montag, 22. April 2013 10:34
> To: pve-devel@pve.proxmox.com
> Subject: [pve-devel] [PATCH] Nodeselector: change default sort to name instead
> of mem
> 
> 
> Signed-off-by: Stefan Priebe 
> ---
>  www/manager/form/NodeSelector.js |   12 +++-
>  1 file changed, 7 insertions(+), 5 deletions(-)
> 
> diff --git a/www/manager/form/NodeSelector.js
> b/www/manager/form/NodeSelector.js
> index 5dc06c3..a472d7f 100644
> --- a/www/manager/form/NodeSelector.js
> +++ b/www/manager/form/NodeSelector.js
> @@ -18,13 +18,13 @@ Ext.define('PVE.form.NodeSelector', {
>   autoDestory: true,
>   sorters: [
>   {
> + property : 'node',
> + direction: 'ASC'
> + },
> + {
>   property : 'mem',
>   direction: 'DESC'
>   },
> - {
> - property : 'node',
> - direction: 'ASC'
> - }
>   ]
>   });
> 
> @@ -37,12 +37,14 @@ Ext.define('PVE.form.NodeSelector', {
>   {
>   header: 'Node',
>   dataIndex: 'node',
> + sortable: true,
>   hideable: false,
>   flex: 1
>   },
>   {
>   header: 'Memory usage',
>   renderer: PVE.Utils.render_mem_usage,
> + sortable: true,
>   width: 100,
>   dataIndex: 'mem'
>   },
> @@ -79,4 +81,4 @@ Ext.define('PVE.form.NodeSelector', {
> 
>  me.callParent();
>  }
> -});
> \ No newline at end of file
> +});
> --
> 1.7.10.4
> 
> ___
> pve-devel mailing list
> pve-devel@pve.proxmox.com
> http://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel


___
pve-devel mailing list
pve-devel@pve.proxmox.com
http://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel


Re: [pve-devel] Disk removed from config but not named unused

2013-04-22 Thread Dietmar Maurer
> I would provide a patch but i still can't find the code where the decision is 
> made
> not to add it as unused.


Maybe in QemuServer::write_vm_config()

___
pve-devel mailing list
pve-devel@pve.proxmox.com
http://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel


Re: [pve-devel] [PATCH] Nodeselector: change default sort to name instead of mem

2013-04-22 Thread Dietmar Maurer
> Maybe just me and personal guess i never understood why it is sorted by mem
> (also mem sorting did never worked for me values are "random").
> 
> I think an alphabetical order should be default and if someone wants to sort 
> by
> mem he could click on mem - but still this needs to be fixed - i wasn't able 
> to fix
> it.

The idea was to choose the node with most free memory by default.

___
pve-devel mailing list
pve-devel@pve.proxmox.com
http://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel


Re: [pve-devel] [PATCH] Nodeselector: change default sort to name instead of mem

2013-04-22 Thread Dietmar Maurer
> > I think an alphabetical order should be default and if someone wants
> > to sort by mem he could click on mem - but still this needs to be
> > fixed - i wasn't able to fix it.
> 
> The idea was to choose the node with most free memory by default.

So this does not really make sense anymore, because we want to select the last 
selected node by default?

___
pve-devel mailing list
pve-devel@pve.proxmox.com
http://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel


Re: [pve-devel] [PATCH] Nodeselector: change default sort to name instead of mem

2013-04-22 Thread Dietmar Maurer
> > So this does not really make sense anymore, because we want to select the
> last selected node by default?
> 
> Why is sorting the list and default value connected? To me these are two
> different things.

The first in the list is selected as default (if there is no default).

___
pve-devel mailing list
pve-devel@pve.proxmox.com
http://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel


Re: [pve-devel] [PATCH] Qemu CreateWizard preselect current node

2013-04-22 Thread Dietmar Maurer
Applying: Qemu CreateWizard preselect current node
error: patch failed: www/manager/form/NodeSelector.js:79
error: www/manager/form/NodeSelector.js: patch does not apply
Patch failed at 0001 Qemu CreateWizard preselect current node


> -Original Message-
> From: pve-devel-boun...@pve.proxmox.com [mailto:pve-devel-
> boun...@pve.proxmox.com] On Behalf Of Stefan Priebe
> Sent: Montag, 22. April 2013 10:32
> To: pve-devel@pve.proxmox.com
> Subject: [pve-devel] [PATCH] Qemu CreateWizard preselect current node
> 
> 


___
pve-devel mailing list
pve-devel@pve.proxmox.com
http://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel


Re: [pve-devel] [PATCH 1/5] add qemu_img_convert

2013-04-22 Thread Dietmar Maurer
> + my $src_format = qemu_img_format($src_scfg, $src_volname);
> + my $dst_format = qemu_img_format($dst_scfg, $dst_volname);
> +
> + my $src_path = PVE::Storage::path($storecfg, $src_volid, $snapname);
> + my $dst_path = PVE::Storage::path($storecfg, $dst_volid);
> +
> + my $cmd = [];
> + push @$cmd, '/usr/bin/qemu-img', 'convert', '-t', 'writeback', '-p', 
> '-C';
> + push @$cmd, '-s', $snapname if($snapname && $src_format eq
> "qcow2");
> + push @$cmd, '-f', $src_format, '-O', $dst_format, $src_path,
> +$dst_path;

Why is it necessary to specify source and destination format?

___
pve-devel mailing list
pve-devel@pve.proxmox.com
http://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel


Re: [pve-devel] [PATCH 1/5] add qemu_img_convert

2013-04-22 Thread Dietmar Maurer
> >>Why is it necessary to specify source and destination format?
> 
> It's more by security,
> 
> from doc:
> 
> "fmt is the disk image format. It is guessed automatically in most cases."
> 
> I don't like too much "in most cases" ;)

OK, lets keep that code.
___
pve-devel mailing list
pve-devel@pve.proxmox.com
http://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel


Re: [pve-devel] [PATCH] Qemu CreateWizard preselect current node

2013-04-23 Thread Dietmar Maurer
applied, thanks.

> -Original Message-
> From: pve-devel-boun...@pve.proxmox.com [mailto:pve-devel-
> boun...@pve.proxmox.com] On Behalf Of Stefan Priebe
> Sent: Montag, 22. April 2013 11:54
> To: pve-devel@pve.proxmox.com
> Subject: [pve-devel] [PATCH] Qemu CreateWizard preselect current node

___
pve-devel mailing list
pve-devel@pve.proxmox.com
http://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel


Re: [pve-devel] [PATCH] Nodeselector: change default sort to name instead of mem

2013-04-23 Thread Dietmar Maurer
I also get errors when I try to apply that patch.

error: patch failed: www/manager/form/NodeSelector.js:79
error: www/manager/form/NodeSelector.js: patch does not apply

> -Original Message-
> From: pve-devel-boun...@pve.proxmox.com [mailto:pve-devel-
> boun...@pve.proxmox.com] On Behalf Of Stefan Priebe
> Sent: Montag, 22. April 2013 10:34
> To: pve-devel@pve.proxmox.com
> Subject: [pve-devel] [PATCH] Nodeselector: change default sort to name instead
> of mem
> 
> 
> Signed-off-by: Stefan Priebe 
> ---
>  www/manager/form/NodeSelector.js |   12 +++-
>  1 file changed, 7 insertions(+), 5 deletions(-)
> 
> diff --git a/www/manager/form/NodeSelector.js
> b/www/manager/form/NodeSelector.js
> index 5dc06c3..a472d7f 100644
> --- a/www/manager/form/NodeSelector.js
> +++ b/www/manager/form/NodeSelector.js
> @@ -18,13 +18,13 @@ Ext.define('PVE.form.NodeSelector', {
>   autoDestory: true,
>   sorters: [
>   {
> + property : 'node',
> + direction: 'ASC'
> + },
> + {
>   property : 'mem',
>   direction: 'DESC'
>   },
> - {
> - property : 'node',
> - direction: 'ASC'
> - }
>   ]
>   });
> 
> @@ -37,12 +37,14 @@ Ext.define('PVE.form.NodeSelector', {
>   {
>   header: 'Node',
>   dataIndex: 'node',
> + sortable: true,
>   hideable: false,
>   flex: 1
>   },
>   {
>   header: 'Memory usage',
>   renderer: PVE.Utils.render_mem_usage,
> + sortable: true,
>   width: 100,
>   dataIndex: 'mem'
>   },
> @@ -79,4 +81,4 @@ Ext.define('PVE.form.NodeSelector', {
> 
>  me.callParent();
>  }
> -});
> \ No newline at end of file
> +});
> --
> 1.7.10.4
> 
> ___
> pve-devel mailing list
> pve-devel@pve.proxmox.com
> http://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel


___
pve-devel mailing list
pve-devel@pve.proxmox.com
http://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel


Re: [pve-devel] [PATCH] Nodeselector: change default sort to name instead of mem

2013-04-23 Thread Dietmar Maurer
> do you have any idea why memory sorting does not work? I tried to solve it 
> but i
> did not find the Problem.

I guess sorting work, but we display missleading % with the render function?

___
pve-devel mailing list
pve-devel@pve.proxmox.com
http://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel


Re: [pve-devel] [PATCH] Nodeselector: change default sort to name instead of mem

2013-04-23 Thread Dietmar Maurer
We just need another render function, which display the absolute value and the 
percentage?

From: Alexandre DERUMIER [mailto:aderum...@odiso.com]
Sent: Dienstag, 23. April 2013 18:05
To: Stefan Priebe - Profihost AG
Cc: pve-devel@pve.proxmox.com; Dietmar Maurer
Subject: Re: [pve-devel] [PATCH] Nodeselector: change default sort to name 
instead of mem

I can confirm that it's not sorting correctly for me too

here a default sorting migrate
[cid:image001.png@01CE40C0.B6B1FEE0]






De: "Stefan Priebe - Profihost AG" 
mailto:s.pri...@profihost.ag>>
À: "Dietmar Maurer" mailto:diet...@proxmox.com>>
Cc: pve-devel@pve.proxmox.com<mailto:pve-devel@pve.proxmox.com>
Envoyé: Mardi 23 Avril 2013 16:10:29
Objet: Re: [pve-devel] [PATCH] Nodeselector: change default sort to name 
instead of mem

Hi Dietmar,

do you have any idea why memory sorting does not work? I tried to solve
it but i did not find the Problem.

Stefan

Am 22.04.2013 11:21, schrieb Stefan Priebe - Profihost AG:
Am 22.04.2013 11:20, schrieb Dietmar Maurer:
So this does not really make sense anymore, because we want to select the
 last selected node by default?


 Why is sorting the list and default value connected? To me these are two
 different things.


 The first in the list is selected as default (if there is no default).


 Yes OK but if you want to manually select another one personally me
 expects to have alphabetical order. If i then want to have the one with
 lowest memory i can still sort manually. (if it worked can you find the
 bug?)

 Stefan

___

pve-devel mailing list
pve-devel@pve.proxmox.com<mailto:pve-devel@pve.proxmox.com>
http://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
<>___
pve-devel mailing list
pve-devel@pve.proxmox.com
http://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel


Re: [pve-devel] [PATCH] Nodeselector: change default sort to name instead of mem

2013-04-23 Thread Dietmar Maurer
> Do you see a problem in using the current master with squeeze? (sure i need to
> revert some binary path changes). I'll stay on Squeeze until summer.

I have no idea (I do not test that).


___
pve-devel mailing list
pve-devel@pve.proxmox.com
http://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel


Re: [pve-devel] [PATCH] Qemu CreateWizard preselect current node

2013-04-24 Thread Dietmar Maurer
> @@ -77,6 +79,10 @@ Ext.define('PVE.form.NodeSelector', {
>   }
>   });
> 
> +if (me.selectCurNode && PVE.curSelectedNode.data.node) {
> +me.value = PVE.curSelectedNode.data.node;
> +}
> +

This does not work, or it is not reliable. Seems we miss some change
signals.

I added a new option 'preferredValue' to PVE.form.ComboGrid.

This is used after load() as default value if the node exists.

Please can you test if that works for you.



___
pve-devel mailing list
pve-devel@pve.proxmox.com
http://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel


Re: [pve-devel] migrate a proxmox server to new hardware ? (backup/restore)

2013-04-24 Thread Dietmar Maurer
> If not, I'll try with a full rsync, I think it should work

should work.

___
pve-devel mailing list
pve-devel@pve.proxmox.com
http://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel


Re: [pve-devel] migrate a proxmox server to new hardware ? (backup/restore)

2013-04-25 Thread Dietmar Maurer
> What I don't known is /etc/pve ?
> 
> I think I need to NOT rsync it, as pve-cluster will mount it and get the 
> files from
> others nodes cluster.

The database is at /var/lib/pve-cluster/

As Stefan mention, you need to rsync when all service are down. That way you 
also sync the database.
___
pve-devel mailing list
pve-devel@pve.proxmox.com
http://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel


Re: [pve-devel] [PATCH 1/9] Nodeselector: change default sort to name instead of mem

2013-04-25 Thread Dietmar Maurer
Applied  this one.

I don't really understand why I need/want the rest of this series?

> -Original Message-
> From: pve-devel-boun...@pve.proxmox.com [mailto:pve-devel-
> boun...@pve.proxmox.com] On Behalf Of Stefan Priebe
> Sent: Mittwoch, 24. April 2013 11:53
> To: pve-devel@pve.proxmox.com
> Subject: [pve-devel] [PATCH 1/9] Nodeselector: change default sort to name
> instead of mem

___
pve-devel mailing list
pve-devel@pve.proxmox.com
http://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel


Re: [pve-devel] migrate a proxmox server to new hardware ? (backup/restore)

2013-04-25 Thread Dietmar Maurer
> >>The database is at /var/lib/pve-cluster/
> 
> Oh, I never notice that :)

It is a very simple sqlite database.
___
pve-devel mailing list
pve-devel@pve.proxmox.com
http://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel


Re: [pve-devel] [PATCH 1/9] Nodeselector: change default sort to name instead of mem

2013-04-25 Thread Dietmar Maurer
Note: This patch breaks lint:

[form/NodeSelector.js] Lint at line 29 character 2: Unexpected ','.
},

> -Original Message-
> From: pve-devel-boun...@pve.proxmox.com [mailto:pve-devel-
> boun...@pve.proxmox.com] On Behalf Of Stefan Priebe
> Sent: Mittwoch, 24. April 2013 11:53
> To: pve-devel@pve.proxmox.com
> Subject: [pve-devel] [PATCH 1/9] Nodeselector: change default sort to name
> instead of mem
> 
> 
> Signed-off-by: Stefan Priebe 
> ---
>  www/manager/form/NodeSelector.js |   10 ++
>  1 file changed, 6 insertions(+), 4 deletions(-)
> 
> diff --git a/www/manager/form/NodeSelector.js
> b/www/manager/form/NodeSelector.js
> index 0754cc2..e92dbbd 100644
> --- a/www/manager/form/NodeSelector.js
> +++ b/www/manager/form/NodeSelector.js
> @@ -20,13 +20,13 @@ Ext.define('PVE.form.NodeSelector', {
>   autoDestory: true,
>   sorters: [
>   {
> + property : 'node',
> + direction: 'ASC'
> + },
> + {
>   property : 'mem',
>   direction: 'DESC'
>   },
> - {
> - property : 'node',
> - direction: 'ASC'
> - }
>   ]
>   });
> 
> @@ -39,12 +39,14 @@ Ext.define('PVE.form.NodeSelector', {
>   {
>   header: 'Node',
>   dataIndex: 'node',
> + sortable: true,
>   hideable: false,
>   flex: 1
>   },
>   {
>   header: 'Memory usage',
>   renderer: PVE.Utils.render_mem_usage,
> + sortable: true,
>   width: 100,
>   dataIndex: 'mem'
>   },
> --
> 1.7.10.4
> 
> ___
> pve-devel mailing list
> pve-devel@pve.proxmox.com
> http://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel


___
pve-devel mailing list
pve-devel@pve.proxmox.com
http://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel


Re: [pve-devel] Snapshotting incl. RAM from stopped VM results in endless loop

2013-04-25 Thread Dietmar Maurer
@Stefan: Your mail server is rejection messages I sent to you.

Any idea what is wrong?

Note: We changed our IP address yesterday.

> Snapshotting incl. RAM from stopped VM results in endless loop. Can anybody
> reproduce?
> 

___
pve-devel mailing list
pve-devel@pve.proxmox.com
http://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel


Re: [pve-devel] [PATCH 1/5] add qemu_img_convert

2013-04-26 Thread Dietmar Maurer
> + my $parser = sub {
> + my $line = shift;
> + print $line."\n";
> + };
> +
> + eval  { run_command($cmd, timeout => undef, errfunc => sub {}, outfunc
> => $parser); };

Why do you suppress messages to stderr, and why do we need a $parser here?

___
pve-devel mailing list
pve-devel@pve.proxmox.com
http://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel


Re: [pve-devel] Snapshotting incl. RAM from stopped VM results in endless loop

2013-04-28 Thread Dietmar Maurer
> i can have a look if you can provide me the IP and Timestamp.
>

Apr 29 08:25:53 smtp7D8DD271FCC6: to=,
relay=mail.profihost.ag[85.158.179.208]:25, delay=0.18, delays=0.04/0/0.14/0,
dsn=4.0.0, status=deferred (host mail.profihost.ag[85.158.179.208] refused to
talk to me: 451 Sorry, too many connections from 94.136.31.129, try again
later)


Seems some mails went through at night, but now it blocks again.

___
pve-devel mailing list
pve-devel@pve.proxmox.com
http://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel


Re: [pve-devel] [PATCH 1/9] Nodeselector: change default sort to name instead of mem

2013-04-28 Thread Dietmar Maurer
> > I don't really understand why I need/want the rest of this series?
> 
> You don't ;-) i just liked them. It gave me a much better overview in the grid
> tables AND it fixes the sorting problem for used memory and added another
> column for free mem.

First, the series seems to mix several independent issue.

Second, it is very hard to find out what a patch is for if there is no 
description.
So above description should go into the patch documentation.


___
pve-devel mailing list
pve-devel@pve.proxmox.com
http://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel


Re: [pve-devel] [PATCH 1/9] Nodeselector: change default sort to name instead of mem

2013-04-29 Thread Dietmar Maurer
> Fixed - i can resend them all until you had a look at them.
> 
> Am 25.04.2013 10:22, schrieb Dietmar Maurer:
> > Note: This patch breaks lint:
> >
> > [form/NodeSelector.js] Lint at line 29 character 2: Unexpected ','.
> > },

I already cvommited a fix for that.

___
pve-devel mailing list
pve-devel@pve.proxmox.com
http://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel


Re: [pve-devel] bug : balloon qom-set error on snapshot rollback

2013-04-29 Thread Dietmar Maurer


> -Original Message-
> From: pve-devel-boun...@pve.proxmox.com [mailto:pve-devel-
> boun...@pve.proxmox.com] On Behalf Of Alexandre DERUMIER
> Sent: Montag, 29. April 2013 10:53
> To: pve-devel@pve.proxmox.com
> Subject: Re: [pve-devel] bug : balloon qom-set error on snapshot rollback
> 
> >>Maybe an eval could help ?
> 
> Better :
> 
> I think we don't need to send balloon qmp commands if we load a statefile.
> (As balloon service is already working in saved memory)

sounds reasonable.
___
pve-devel mailing list
pve-devel@pve.proxmox.com
http://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel


Re: [pve-devel] [PATCH 1/5] add qemu_img_convert

2013-04-29 Thread Dietmar Maurer
I finally applied this one and a first version of copy_vm.

I moved the code into an extra API call, because copy/clone has
different locking requirements than create_vm. We now create
a shared lock on the source VM. Also, permission checks are slightly
different, and  I think create_vm is already too complex to add more 
functionality.

What do you think? My plan was to get this basic functionality stable so
that we can include this with 3.0?


> -Original Message-
> From: pve-devel-boun...@pve.proxmox.com [mailto:pve-devel-
> boun...@pve.proxmox.com] On Behalf Of Alexandre Derumier
> Sent: Montag, 29. April 2013 08:41
> To: pve-devel@pve.proxmox.com
> Subject: [pve-devel] [PATCH 1/5] add qemu_img_convert
> 
> also work with snapshot as source for qcow2,rbd,sheepdog.
> 

___
pve-devel mailing list
pve-devel@pve.proxmox.com
http://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel


Re: [pve-devel] [PATCH 1/5] add qemu_img_convert

2013-04-29 Thread Dietmar Maurer
> >>My plan was to get this basic functionality stable so that we can
> >>include this with 3.0?
> 
> Yes, I think it could be a start, we can add features step by step.

Yes (will try to do that asap).

> When do you plan to release 3.0 ?

AFAIK Debian Wheeze is planned this weekend. We want RC1 shortly after that.
___
pve-devel mailing list
pve-devel@pve.proxmox.com
http://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel


Re: [pve-devel] [PATCH 1/2] vm_copy : fix typo in description

2013-04-29 Thread Dietmar Maurer
applied - thanks!

> -Original Message-
> From: pve-devel-boun...@pve.proxmox.com [mailto:pve-devel-
> boun...@pve.proxmox.com] On Behalf Of Alexandre Derumier
> Sent: Dienstag, 30. April 2013 06:18
> To: pve-devel@pve.proxmox.com
> Subject: [pve-devel] [PATCH 1/2] vm_copy : fix typo in description
> 
> 
> Signed-off-by: Alexandre Derumier 
> ---
>  PVE/API2/Qemu.pm |2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/PVE/API2/Qemu.pm b/PVE/API2/Qemu.pm index 04106b8..8a15abc
> 100644
> --- a/PVE/API2/Qemu.pm
> +++ b/PVE/API2/Qemu.pm
> @@ -1779,7 +1779,7 @@ __PACKAGE__->register_method({
>  method => 'POST',
>  protected => 1,
>  proxyto => 'node',
> -description => "Creat a copy of virtual machine/template.",
> +description => "Create a copy of virtual machine/template.",
>  permissions => {
>   description => "You need 'VM.Copy' permissions on /vms/{vmid}, and
> 'VM.Allocate' permissions " .
>   "on /vms/{newid} (or on the VM pool /pool/{pool}). You also need " .
> --
> 1.7.10.4
> 
> ___
> pve-devel mailing list
> pve-devel@pve.proxmox.com
> http://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel


___
pve-devel mailing list
pve-devel@pve.proxmox.com
http://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel


Re: [pve-devel] [PATCH 2/2] parse_drive : return correct format

2013-04-29 Thread Dietmar Maurer
applied.

Btw, your clone patches have the feature to set the format for each drive.
Do we really need that?

I mean, we want to be able to copy a single disk from one location to another,
and change the disk format on that action.

But is this related to VM copy.

Maybe it is enough to have an extra API for that (migrate_disk)?

> -Original Message-
> From: pve-devel-boun...@pve.proxmox.com [mailto:pve-devel-
> boun...@pve.proxmox.com] On Behalf Of Alexandre Derumier
> Sent: Dienstag, 30. April 2013 06:18
> To: pve-devel@pve.proxmox.com
> Subject: [pve-devel] [PATCH 2/2] parse_drive : return correct format
> 
> Currently format is always empty, we need to parse file extension

___
pve-devel mailing list
pve-devel@pve.proxmox.com
http://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel


Re: [pve-devel] [PATCH] don't send qmp balloon commands if vm is started with a state file

2013-04-29 Thread Dietmar Maurer
applied, thanks.

> -Original Message-
> From: pve-devel-boun...@pve.proxmox.com [mailto:pve-devel-
> boun...@pve.proxmox.com] On Behalf Of Alexandre Derumier
> Sent: Montag, 29. April 2013 14:14
> To: pve-devel@pve.proxmox.com
> Subject: [pve-devel] [PATCH] don't send qmp balloon commands if vm is started
> with a state file

___
pve-devel mailing list
pve-devel@pve.proxmox.com
http://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel


Re: [pve-devel] [PATCH 1/5] add qemu_img_convert

2013-04-29 Thread Dietmar Maurer
> I think it could be great to add a "name" parameter

yes, and a 'description'

> For full clone, we should add a target storage and output format options.
> (I think that only 1 target storage/output format for all disks is enough)

OK for me.
___
pve-devel mailing list
pve-devel@pve.proxmox.com
http://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel


Re: [pve-devel] [PATCH] copy_vm : add optional storage parameter

2013-04-29 Thread Dietmar Maurer
applied, thanks.

I will add a JSON schema requirement for option 'full':

storage => get_standard_option('pve-storage-id', {
description => "Target storage for full copy.",
requires => 'full',
optional => 1,
}),


> -Original Message-
> From: pve-devel-boun...@pve.proxmox.com [mailto:pve-devel-
> boun...@pve.proxmox.com] On Behalf Of Alexandre Derumier
> Sent: Dienstag, 30. April 2013 07:08
> To: pve-devel@pve.proxmox.com
> Subject: [pve-devel] [PATCH] copy_vm : add optional storage parameter
> 
> Optionnal target storage for full copy

___
pve-devel mailing list
pve-devel@pve.proxmox.com
http://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel


Re: [pve-devel] [PATCH 1/5] add qemu_img_convert

2013-04-29 Thread Dietmar Maurer
> Also, if name is not provided,
> maybe can we add a default name : " Copy of".$orignalname  ?
> 
> To avoid duplicate name ?

Yes. will do that.
___
pve-devel mailing list
pve-devel@pve.proxmox.com
http://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel


Re: [pve-devel] [PATCH 2/2] parse_drive : return correct format

2013-04-30 Thread Dietmar Maurer

> >>Btw, your clone patches have the feature to set the format for each
> >>drive. Do we really need that?
> 
> Yes, because we create the volume before using qemu-img convert.
> 
> But we also need to specify it to qemu-img convert, as auto-detection of the
> target volume format don't work.
> (I have tried, creating a .qcow2 file, qemu-img convert override it with raw
> format is no format specified)

Sorry, I do not really understand that. In the other mail you wrote that it 
would
be enough to specify one single -format parameter?

> >>Maybe it is enough to have an extra API for that (migrate_disk)?
> In my patches, I have a qm move api for storage migration, which reuse a
> common clone_disk{}.(using qemu-img convert offline or drive-mirror online)

Sure, I already saw that. I just split your patches into smaller steps. I want 
to test
and understand each single line of that code. Hope that is OK for you?

I will re-create the clone_disk() later if needed.



___
pve-devel mailing list
pve-devel@pve.proxmox.com
http://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel


[pve-devel] Copy from snapshot

2013-04-30 Thread Dietmar Maurer
Just committed a first versions:

https://git.proxmox.com/?p=qemu-server.git;a=blobdiff;f=PVE/API2/Qemu.pm;h=fc9b502581fadf9603c4a31bd501602e9d92e3f0;hp=e92a03e990d9fe299005c3f0b2613d4160698581;hb=9076d880a8496f5cd4e8b270b19840bc891250f5;hpb=4e4f83fea0936de1f2e746e2870f2e9d8962ab8a

It currently requires the "--full" parameter. Do you think we can conditionally 
clone if the feature is available (else we simply do a full copy)?

___
pve-devel mailing list
pve-devel@pve.proxmox.com
http://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel


Re: [pve-devel] Copy from snapshot

2013-04-30 Thread Dietmar Maurer
> >>It currently requires the "--full" parameter. Do you think we can 
> >>conditionally
> clone if the feature is available (else we simply do a full copy)?
> 
> "Do you think we can conditionally clone"
> 
> Do you mean linked  clone ?

Yes, 'linked clone'. I will try to use this wording in future.

> I think only full copy is enough, It'll be difficult to manage the 
> parent-child
> relationship without base-xxx name.

Ah, OK.

So what for is that check in your patches? Can't we always create a full clone 
from snapshot?

Or maybe you forgot to pass the $running parameter there?


+   die "clonemode $clonemode feature is not available" if 
!PVE::QemuServer::has_feature($clonemode, $parentconf, $storecfg, $snapname);


___
pve-devel mailing list
pve-devel@pve.proxmox.com
http://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel


  1   2   3   4   5   6   7   8   9   10   >