[pve-devel] [PATCH pve-common] new helper PVE::Tools::du() - get disk usage

We simply call the external binary 'du', so that we can abort the command when we run into a timeout. Signed-off-by: Dietmar Maurer <diet...@proxmox.com> --- src/PVE/Tools.pm | 20 1 file changed, 20 insertions(+) diff --git a/src/PVE/Tools.pm b/src/PVE/Tools.pm

Re: [pve-devel] VDI solution...

> You guys could integrate Apache Guacamole to Proxmox VE, perhaps. You can install an run that inside any VM. So I don't really understand what we should integrate? ___ pve-devel mailing list pve-devel@pve.proxmox.com

[pve-devel] applied: [PATCH v2 storage 0/2] show storage-utilization per pool

applied ___ pve-devel mailing list pve-devel@pve.proxmox.com https://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

Re: [pve-devel] pve-edk2-firmware and mirror_edk2

fixed - please test again. > On April 17, 2018 at 11:04 AM Rene Jochum wrote: > > > Hi, > > while building my packages for Buster i found that both repos in the > Subject aren't exported. > > I see those are pretty new, do they miss a "git-daemon-export-ok" or is > that

Re: [pve-devel] Gitlab-ci

> I've made some Dockerfiles for PVE (easy to add more for PMG). These > don't require the Docker HUB - so it will be able to build them > even when the hub goes down. > > https://git.lxch.eu/git/pve-dockerfiles > > Is that something Proxmox is interested in? If yes, I'll continue my >

[pve-devel] applied: [Patch V3 guest-common] fix #1694: make failure of snapshot removal non-fatal

applied with fixes - see comment inline: > On April 13, 2018 at 12:24 PM Wolfgang Link wrote: > > > In certain high-load scenarios ANY ZFS operation can block, > including registering an (async) destroy. > Since ZFS operations are implemented via ioctl's, > killing the user

Re: [pve-devel] [PATCH v3 storage 1/2] Fix #1542: show storage utilization per pool

comments inline. > On April 11, 2018 at 4:36 PM Alwin Antreich wrote: > > > - get the percent_used value for a ceph pool and >calculate it where ceph doesn't supply it (pre kraken) > - use librados2-perl for pool status > - add librados2-perl as build-depends and

Re: [pve-devel] [Patch V2 guest-common] fix #1694: Replication risks permanently losing sync in high loads due to timeout bug

> @@ -293,12 +303,16 @@ sub replicate { > die $err; > } > > -# remove old snapshots because they are no longer needed > -$cleanup_local_snapshots->($last_snapshots, $last_sync_snapname); > +eval { > + # remove old snapshots because they are no longer needed > +

Re: [pve-devel] [Patch V2 guest-common] fix #1694: Replication risks permanently losing sync in high loads due to timeout bug

> diff --git a/PVE/Replication.pm b/PVE/Replication.pm > index 9bc4e61..d8ccfaf 100644 > --- a/PVE/Replication.pm > +++ b/PVE/Replication.pm > @@ -136,8 +136,18 @@ sub prepare { > $last_snapshots->{$volid}->{$snap} = 1; > } elsif ($snap =~ m/^\Q$prefix\E/) { >

Re: [pve-devel] Wish-List for Mail-Gateway

> where can I send a wish list for the Mail-Gateway? I guess it is best to open an issue at bugzilla.proxmox.com for each topic. ___ pve-devel mailing list pve-devel@pve.proxmox.com https://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

[pve-devel] applied: [pmg-devel] [PATCH pmg-gui 1/1] overwrite run_editor of base class

applied ___ pve-devel mailing list pve-devel@pve.proxmox.com https://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

[pve-devel] applied: [pmg-devel] [PATCH manager 1/1] overwrite the built-in 'run_editor' function

applied ___ pve-devel mailing list pve-devel@pve.proxmox.com https://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

[pve-devel] applied: [PATCH manager] better focus of lxc/MPEdit

applied ___ pve-devel mailing list pve-devel@pve.proxmox.com https://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

[pve-devel] applied: [PATCH widget-toolkit 1/1] allow pressing enter in ObjectGrids to edit a field

applied ___ pve-devel mailing list pve-devel@pve.proxmox.com https://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

[pve-devel] applied: [PATCH widget-toolkit] better default focus selection

applied ___ pve-devel mailing list pve-devel@pve.proxmox.com https://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

[pve-devel] applied: [PATCH manager] merge cores, cpulimit and cpuunits for containers

applied ___ pve-devel mailing list pve-devel@pve.proxmox.com https://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

[pve-devel] applied: [PATCH docs 2/2] mention that NAT mode is not available on the WebUI

applied ___ pve-devel mailing list pve-devel@pve.proxmox.com https://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

[pve-devel] applied: [PATCH docs 1/2] fix wording for new memory dialog for qemu

applied ___ pve-devel mailing list pve-devel@pve.proxmox.com https://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

[pve-devel] applied: [PATCH manager] fix editor and set_button_status for cloudinit

applied ___ pve-devel mailing list pve-devel@pve.proxmox.com https://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

[pve-devel] applied: [PATCH manager 01/11] add advanced checkbox to the wizard

applied all (11) patches ___ pve-devel mailing list pve-devel@pve.proxmox.com https://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

[pve-devel] applied: [PATCH widget-toolkit 2/2] add a checkbox to edit windows for advanced options

applied ___ pve-devel mailing list pve-devel@pve.proxmox.com https://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

[pve-devel] applied: [PATCH widget-toolkit 1/2] add advanced options to the input panel

applied ___ pve-devel mailing list pve-devel@pve.proxmox.com https://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

Re: [pve-devel] [PATCH manager v2 1/5] dc: add simple cluster panel

fixed > the only thing not working is the 'nodecount' since the diffstore has no > 'load' event, thus the update never triggers > > but we can fix this in a followup by adding the event to the rstore > instead ___ pve-devel mailing list

[pve-devel] applied: [PATCH manager v2 0/5] cluster create/join UI

applied ___ pve-devel mailing list pve-devel@pve.proxmox.com https://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

[pve-devel] applied: [PATCH v2 librados2-perl 0/3] resend of last series

applied ___ pve-devel mailing list pve-devel@pve.proxmox.com https://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

[pve-devel] applied: [PATCH cluster] API/Cluster: autoflush STDOUT for join and create

applied ___ pve-devel mailing list pve-devel@pve.proxmox.com https://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

[pve-devel] applied: make aab and dab compatible with LXC 3 config properties

applied ___ pve-devel mailing list pve-devel@pve.proxmox.com https://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

Re: [pve-devel] [PATCH dab] use new config properties for sample lxc config

applied and bumped version to dab_3.0-9_all.deb Uploaded new package to pvetest respository: http://download.proxmox.com/debian/pve/dists/stretch/pvetest/binary-amd64/dab_3.0-9_all.deb > On April 5, 2018 at 9:53 AM Thomas Lamprecht wrote: > > > Signed-off-by: Thomas

Re: [pve-devel] [RFC manager 0/1] introduce pvesrd, replacing systemd pvesr.{timer, service}

My plan was to use pvestatd for that. We need to improve that daemon to run a forked worker for each storage, so I think it would be ease to add this functionality. Would save some memory ... > On April 3, 2018 at 4:02 PM Thomas Lamprecht wrote: > > > This is a POC

Re: [pve-devel] [PATCH librados2-perl] Split method pve_rados_connect

comments inline > On March 30, 2018 at 12:25 PM Alwin Antreich wrote: > > > To be able to connect through librados2 without a config file, the > method pve_rados_connect is split up into pve_rados_connect and > pve_rados_conf_read_file. > > Signed-off-by: Alwin

Re: [pve-devel] OAuth2 Authentication

Hi Andreas, > Is OAuth2 on the list of features you want to have in PVE and if so, > is someone working on it? > We're migration step-by-step every service in our infrastructure > towards OAuth2 and it would be great to authenticate against OAuth2 > too. I though OAuth2 is not even a

Re: [pve-devel] installer with ovs bridge option

The installer just generate a 'minimal' configuration. I don't want to bloat that up... IMHO it is easy enough to change that afterwards. > On March 24, 2018 at 8:45 AM tester wrote: > > > Hi, > would it be a problem to add an option in the installer to use ovs bridge > instead

[pve-devel] applied: [PATCH docs] vzdump: add restore bwlimit docs

applied ___ pve-devel mailing list pve-devel@pve.proxmox.com https://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

[pve-devel] applied: [PATCH docs] api-viewer: show full return info if available

applied ___ pve-devel mailing list pve-devel@pve.proxmox.com https://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

Re: [pve-devel] HTTP API : Cloudinit

> I am looking for any information about  support for cloudinit in HTTP > API in upcoming 5.2 release. > > Where can I find some information about that? Dominik sent you that. Just ask here if you have further questions. Also, it would be great to get some feedback: - is it helpful within your

[pve-devel] applied: [PATCH docs] add 'gen-qm-cloud-init-opts.pl' to doc-gen

applied ___ pve-devel mailing list pve-devel@pve.proxmox.com https://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

Re: [pve-devel] training week : students features request

I already added some docs here: https://git.proxmox.com/?p=pve-docs.git;a=blob;f=qm-cloud-init.adoc;h=cfac011c659440e4b4b91d985dea79f98e5f083c;hb=HEAD > On March 20, 2018 at 1:16 PM Alexandre DERUMIER wrote: > > > >>Sorry for newbie skills. > no problem. > > cloudinit

[pve-devel] [PATCH pve-container 2/2] clone: check storage permissions

Signed-off-by: Dietmar Maurer <diet...@proxmox.com> --- src/PVE/API2/LXC.pm | 7 +++ 1 file changed, 7 insertions(+) diff --git a/src/PVE/API2/LXC.pm b/src/PVE/API2/LXC.pm index 128a89b..0c9ee40 100644 --- a/src/PVE/API2/LXC.pm +++ b/src/PVE/API2/LXC.pm @@ -1326,6 +1326,13 @@ __PAC

[pve-devel] [PATCH pve-container 1/2] clone: implement target parameter

Signed-off-by: Dietmar Maurer <diet...@proxmox.com> --- src/PVE/API2/LXC.pm | 38 +- 1 file changed, 33 insertions(+), 5 deletions(-) diff --git a/src/PVE/API2/LXC.pm b/src/PVE/API2/LXC.pm index 9205215..128a89b 100644 --- a/src/PVE/API2/LXC.pm +++ b/s

Re: [pve-devel] training week : students features request

> >>Thanks for the feedback. I will add this to the (long) TODO list. Concerning > >> > >>backup, I would prefer an approach that work with all storage types. > > Any plan to add incremental support in vma ? (I think qemu backup incremental > is now complete ?) > During the training, this is

Re: [pve-devel] training week : students features request

Hi Alexandre, > student are very happy with the hard work done on proxmox5, > bugfixes,documentation and stability improvements. Great! > They have some features requests/suggestion > > > - vm balancing/redispatching based on cpu > - auto-snapshot feature (cron like) > - global/central backup

[pve-devel] applied: [PATCH manager] cloudinit: implement missing remove logic

applied ___ pve-devel mailing list pve-devel@pve.proxmox.com https://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

[pve-devel] applied: [PATCH V2 storage 01/10] Add CIFS Storage Plugin.

applied all 10 patches + a few cleanups on top ___ pve-devel mailing list pve-devel@pve.proxmox.com https://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

[pve-devel] [PATCH qemu-server 2/2] clone: add command line completion for newid

Signed-off-by: Dietmar Maurer <diet...@proxmox.com> --- PVE/API2/Qemu.pm | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/PVE/API2/Qemu.pm b/PVE/API2/Qemu.pm index 300e347..ac7fe4d 100644 --- a/PVE/API2/Qemu.pm +++ b/PVE/API2/Qemu.pm @@ -2455,7 +2455,9 @@ __PAC

[pve-devel] [PATCH qemu-server 1/2] clone: use better default for parameter 'full'

template => linked clone normal VM => full clone Signed-off-by: Dietmar Maurer <diet...@proxmox.com> --- PVE/API2/Qemu.pm | 20 ++-- 1 file changed, 14 insertions(+), 6 deletions(-) diff --git a/PVE/API2/Qemu.pm b/PVE/API2/Qemu.pm index b1c6896..300e347 100644 --

[pve-devel] applied: [PATCH pve-container 1/3] PVE/API2/LXC.pm: remove experimental parameter for clone/template

applied all 3 patches ___ pve-devel mailing list pve-devel@pve.proxmox.com https://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

[pve-devel] [PATCH pve-container 2/3] clone: allow clone to same storage without specifying storage parameter

Signed-off-by: Dietmar Maurer <diet...@proxmox.com> --- src/PVE/API2/LXC.pm | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/src/PVE/API2/LXC.pm b/src/PVE/API2/LXC.pm index e59eb10..4c1912c 100644 --- a/src/PVE/API2/LXC.pm +++ b/src/PVE/API2/LXC.pm @@ -1263,9 +

[pve-devel] [PATCH pve-container 3/3] clone: use better default for parameter 'full'

template => linked clone normal container => full clone Signed-off-by: Dietmar Maurer <diet...@proxmox.com> --- src/PVE/API2/LXC.pm | 11 --- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/src/PVE/API2/LXC.pm b/src/PVE/API2/LXC.pm index 4c1912c..55aff75 1006

[pve-devel] [PATCH pve-container 1/3] PVE/API2/LXC.pm: remove experimental parameter for clone/template

Signed-off-by: Dietmar Maurer <diet...@proxmox.com> --- src/PVE/API2/LXC.pm | 12 1 file changed, 12 deletions(-) diff --git a/src/PVE/API2/LXC.pm b/src/PVE/API2/LXC.pm index ec3a449..e59eb10 100644 --- a/src/PVE/API2/LXC.pm +++ b/src/PVE/API2/LXC.pm @@ -1126,12 +

[pve-devel] applied: [PATCH container v5] Fix pct skiplock

applied ___ pve-devel mailing list pve-devel@pve.proxmox.com https://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

Re: [pve-devel] [PATCH container v4] Fix pct skiplock

another comment inline > diff --git a/src/PVE/LXC.pm b/src/PVE/LXC.pm > index 7adbcd1..4398cfd 100644 > --- a/src/PVE/LXC.pm > +++ b/src/PVE/LXC.pm > @@ -1545,11 +1545,20 @@ sub vm_start { > > update_lxc_config($vmid, $conf); > > -local $ENV{PVE_SKIPLOCK}=1 if $skiplock; > +my

Re: [pve-devel] [PATCH container v4] Fix pct skiplock

> diff --git a/src/lxc-pve-prestart-hook b/src/lxc-pve-prestart-hook > index fd29423..79297da 100755 > --- a/src/lxc-pve-prestart-hook > +++ b/src/lxc-pve-prestart-hook > @@ -57,13 +57,16 @@ __PACKAGE__->register_method ({ > return undef if $param->{name} !~ m/^\d+$/; > > my $vmid =

Re: [pve-devel] [PATCH container v2] Fix pct skiplock

Please send those white-space cleanups as separate patch > diff --git a/src/PVE/LXC.pm b/src/PVE/LXC.pm > index 7adbcd1..acb5cfd 100644 > --- a/src/PVE/LXC.pm > +++ b/src/PVE/LXC.pm > @@ -393,7 +393,7 @@ sub update_lxc_config { > > # some init scripts expect a linux terminal (turnkey). >

Re: [pve-devel] [PATCH qemu] build: use 3.0 source format

I don't really like this. Why not simply: %: dh $@ --with quilt > diff --git a/debian/source/format b/debian/source/format > new file mode 100644 > index 000..163aaf8 > --- /dev/null > +++ b/debian/source/format > @@ -0,0 +1 @@ > +3.0 (quilt) > -- > 2.14.2 > > >

[pve-devel] applied: [PATCH REBASED v4 container 0/5] lxc clone/move volume patches

applied all 5 patches ___ pve-devel mailing list pve-devel@pve.proxmox.com https://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

[pve-devel] applied: [PATCH cluster 2/2] fix tainted input in backup_cfs_database

applied ___ pve-devel mailing list pve-devel@pve.proxmox.com https://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

[pve-devel] applied: [PATCH cluster 1/2] refactor backup_cfs_database

applied ___ pve-devel mailing list pve-devel@pve.proxmox.com https://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

[pve-devel] applied: [PATCH cluster 1/2] pvecm: check if APIClient exception code is defined

applied ___ pve-devel mailing list pve-devel@pve.proxmox.com https://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

[pve-devel] applied: [PATCH cluster 2/2] api: add fork worker ID for create and join

applied ___ pve-devel mailing list pve-devel@pve.proxmox.com https://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

[pve-devel] applied: [PATCH cluster] cluster join: ensure updatecerts gets called on quorate cluster

applied ___ pve-devel mailing list pve-devel@pve.proxmox.com https://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

[pve-devel] applied: [RFC qemu-server] cloud-init: make cipassword interactive on the CLI

applied ___ pve-devel mailing list pve-devel@pve.proxmox.com https://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

[pve-devel] applied: [RFC common] cli: more generic interactive parameter definition

applied ___ pve-devel mailing list pve-devel@pve.proxmox.com https://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

[pve-devel] applied: [PATCH container 2/2] Remove obsolete read from storage.cfg in vm_start api call

applied ___ pve-devel mailing list pve-devel@pve.proxmox.com https://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

[pve-devel] applied: [PATCH container 1/2] Fix #1547: on migration abort, the CT starts again

applied with syntax fix. ___ pve-devel mailing list pve-devel@pve.proxmox.com https://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

Re: [pve-devel] [PATCH container 1/2] Fix #1547: on migration abort, the CT starts again

looks good, only one small sytax error: > + # in restart mode, we start the container on the source node > + # on migration error > + if ($self->{opts}->{restart} && $self->{was_running}) { > + $self->log('info', "start container on source node"); > + my skiplock = 1;

[pve-devel] applied: [PATCH firewall 0/6] pve-firewall packaging cleanup

applied ___ pve-devel mailing list pve-devel@pve.proxmox.com https://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

[pve-devel] aplied: [PATCH v2 firewall] check multiport limit in port ranges

applied - and thanks for the cleanup! > On March 8, 2018 at 12:06 PM Wolfgang Bumiller wrote: > > > Signed-off-by: Wolfgang Bumiller > --- > Changes: > We don't actually use the returned $count for anything other than > checking whether it's

[pve-devel] applied: [pmg-devel] [PATCH pmg-gui/widget-toolkit] fix gettext for safari

applied > this series fixes the gettext definition for safari on macos > > for pve only the widget-toolkit patch is needed, but for > pmg we also need to patch the pmg-gui package > (it would be best if we add a dependecy on the next widget-toolkit > verision to pmg-gui then) > > [PATCH

Re: [pve-devel] [PATCH v4 qemu-server 03/10] implement cloudinit

> use PVE::Cluster qw (cfs_read_file cfs_write_file);; > use PVE::SafeSyslog; > @@ -64,7 +65,9 @@ my $check_storage_access = sub { > > my $volid = $drive->{file}; > > - if (!$volid || $volid eq 'none') { > + if (!$volid || ($volid eq 'none' || $volid eq 'cloudinit')) { > +

[pve-devel] [PATCH V2 pve-common 5/6] rename $can_read_pass to $read_password_func

Signed-off-by: Dietmar Maurer <diet...@proxmox.com> --- src/PVE/CLIHandler.pm | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/PVE/CLIHandler.pm b/src/PVE/CLIHandler.pm index 2d77145..5e2d3b8 100644 --- a/src/PVE/CLIHandler.pm +++ b/src/PVE/CLIHandler.pm @@

[pve-devel] [PATCH V2 pve-common 1/6] introduce compute_param_mapping_hash helper

This allows us to specify a arbitrary mapping func for any param. Signed-off-by: Dietmar Maurer <diet...@proxmox.com> --- src/PVE/RESTHandler.pm | 68 +- 1 file changed, 50 insertions(+), 18 deletions(-) diff --git a/src/PVE/RESTHandler.pm

[pve-devel] [PATCH V2 pve-common 6/6] use better name for string_param_file_mapping (param_mapping).

But keep old one for compatibility. Signed-off-by: Dietmar Maurer <diet...@proxmox.com> --- src/PVE/CLIHandler.pm | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/src/PVE/CLIHandler.pm b/src/PVE/CLIHandler.pm index 5e2d3b8..1fd7b02 100644 --- a/src/PVE/CLIHand

[pve-devel] [PATCH V2 pve-common 4/6] rename $pwcallback to $read_password_func

Signed-off-by: Dietmar Maurer <diet...@proxmox.com> --- src/PVE/CLIHandler.pm | 14 +++--- src/PVE/RESTHandler.pm | 6 +++--- 2 files changed, 10 insertions(+), 10 deletions(-) diff --git a/src/PVE/CLIHandler.pm b/src/PVE/CLIHandler.pm index 33b7aca..2d77145 100644 --- a/s

[pve-devel] [PATCH V2 pve-common 2/6] rename $stringfilemap to $param_mapping_func

Signed-off-by: Dietmar Maurer <diet...@proxmox.com> --- src/PVE/CLIHandler.pm | 14 +++--- src/PVE/RESTHandler.pm | 16 2 files changed, 15 insertions(+), 15 deletions(-) diff --git a/src/PVE/CLIHandler.pm b/src/PVE/CLIHandler.pm index 45c0427..736e5ec 100644 ---

[pve-devel] [PATCH V2 pve-common 3/6] rename $can_str_param_fmap to $param_mapping_func

Signed-off-by: Dietmar Maurer <diet...@proxmox.com> --- src/PVE/CLIHandler.pm | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/PVE/CLIHandler.pm b/src/PVE/CLIHandler.pm index 736e5ec..33b7aca 100644 --- a/src/PVE/CLIHandler.pm +++ b/src/PVE/CLIHandler.pm @@

[pve-devel] [PATCH V2 pve-common 0/6] CLI/RESTHandler: more generic parameter mapping

Changes since V1: - split patch into smaller parts - new helper $compute_param_mapping_hash() - improve parameter names - add some inline docs Besides, functionality should be still the same. Dietmar Maurer (6): introduce compute_param_mapping_hash helper rename $stringfilemap

Re: [pve-devel] [PATCH common] CLI/RESTHandler: more generic parameter mapping

Those renames disturb the whole patch: > my $can_read_pass = $cli_handler_class->can('read_password'); > -my $can_str_param_fmap = > $cli_handler_class->can('string_param_file_mapping'); > +my $can_map_params = $cli_handler_class->can('param_mapping') || > +

Re: [pve-devel] [PATCH common] CLI/RESTHandler: more generic parameter mapping

This patch is quite hard to read. I guess it would make sense to split this and do the function rename as extra patch? Some questions below: > -my $replace_file_names_with_contents = sub { > +my $replace_mapped_contents = sub { > my ($param, $mapping) = @_; > > if ($mapping) { >

Re: [pve-devel] [PATCH i18n 1/1] update french translation

There is something wrong with this mail. The attachment has the following content type: > Content-Type: text/plain; charset=y What is charset=y ? Please can you resend with correct content type? ___ pve-devel mailing list pve-devel@pve.proxmox.com

Re: [pve-devel] ZFS alternatives

> I have here a bounce of friends complain about ZFS, which is a memory eater > - and killer! > So, I wonder if Proxmox consider others alternatives, like BRTFS or > whatever. Yes, but there are still concerns about btrfs stability ... And btrfs is really slow in some scenarios (dpkg).

Re: [pve-devel] building pve-qemu

> How to build pve-qemu? There is a Makefile ___ pve-devel mailing list pve-devel@pve.proxmox.com https://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

[pve-devel] applied: [PATCH container v2] close #1668: add Devuan support

applied ___ pve-devel mailing list pve-devel@pve.proxmox.com https://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

Re: [pve-devel] Using zstd for backup

> Question @PVE-Devel: To finish this patch up we have to include a clone of > https://github.com/facebook/zstd to your git repositories > https://git.proxmox.com, is that possible? Instead, try to include that into Debian. ___ pve-devel mailing list

[pve-devel] applied: [PATCH dab] close #1668: add support for devuan jessie and ascii

applied ___ pve-devel mailing list pve-devel@pve.proxmox.com https://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

[pve-devel] applied: [PATCH dab-pve-appliances] close #1668: add Devuan Jessie template config

applied ___ pve-devel mailing list pve-devel@pve.proxmox.com https://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

Re: [pve-devel] [PATCH container] close #1668: add Devuan support

> diff --git a/src/PVE/LXC/Setup/Devuan.pm b/src/PVE/LXC/Setup/Devuan.pm > new file mode 100644 > index 000..2f35de6 > --- /dev/null > +++ b/src/PVE/LXC/Setup/Devuan.pm > @@ -0,0 +1,73 @@ > +package PVE::LXC::Setup::Devuan; > + > +use strict; > +use warnings; > + > +use PVE::Tools

[pve-devel] applied: [PATCH docs] fix typo in api viewer

applied ___ pve-devel mailing list pve-devel@pve.proxmox.com https://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

[pve-devel] applied: [[PATCH V4 docs] add VLAN explanation.] add VLAN explanation.

applied + cleanups ___ pve-devel mailing list pve-devel@pve.proxmox.com https://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

Re: [pve-devel] Support for Devuan LCX container

> This seems the only issue with Devuan container. > > You can test it by downloading the dab.conf and the Makefile at > https://github.com/siddolo/pve-devuan-appliances > > Can you support a Devuan container looking into /etc/devuan_version? Please can you file a bug at bugzilla.proxmox.com?

Re: [pve-devel] From LXC to LXD

LXC is the base technology for both LXD an PCT > Any change to migrate from LXC to LXD no (as explained above, LXD uses LXC) > It's seem to me that LXD is more advance than LXC! What do you, guys, thing > about it??? ___ pve-devel mailing list

Re: [pve-devel] [RFC PATCH] add kiosk option to vm

> with my patch as it is, only root can change the option > > afaics there is no option to set the target file (at least not on the > commandline) only 'TMPDIR' via an environment variable (but i guess this > is not what we want since it changes the location of all tmpfiles of qemu) I always

Re: [pve-devel] [PATCH common] replace brctl with iproute2 calls

nice - I like such cleanups :-) > On February 7, 2018 at 2:15 PM Wolfgang Bumiller > wrote: > > > And add a few helpers for the common cases. > > Signed-off-by: Wolfgang Bumiller > --- > This has been on my todo list for a while and as an extra

Re: [pve-devel] Cluster creation via web gui

we are working on that. > On January 31, 2018 at 11:26 PM Gilberto Nunes > wrote: > > > Hello friends > > I saw in last video about PMG, that is possible to create and join Cluster > via web gui. > So I wonder why us so difficult to bring the same feature to PVE. >

Re: [pve-devel] [PATCH cluster] datacenter.cfg: add bwlimit

I think this is the wrong place to add defaults. We need default for various different task, so we should use a more generic concept? > On January 30, 2018 at 4:34 PM Wolfgang Bumiller > wrote: > > > This will define the global defaults which can be overridden > by

Re: [pve-devel] proxmox 2018 : add support for "virtual" network and network plugins ?

> On January 29, 2018 at 1:31 PM Herman Bos <h...@osso.nl> wrote: > > > On 29 January 2018 at 12:22, Dietmar Maurer <diet...@proxmox.com> wrote: > > > > > > > Looks we simply need a flexible plugin architecture ... > > > > > You cou

Re: [pve-devel] LizardFS support - wishlist

> Well... It's just seems that LizardFS (which is a MooseFS fork, I guess), > is easier to implement, If I remember correctly, they run a single Master with no automatic failover? ___ pve-devel mailing list pve-devel@pve.proxmox.com

Re: [pve-devel] proxmox 2018 : add support for "virtual" network and network plugins ?

> It's not difficult if we can do bgp to the router. but I think Dietmar want > something > for user with a simple router/default gw. (so with some proxy-arp trick). No, I still do not know what I want - too many options ;-) Looks we simply need a flexible plugin architecture ...

Re: [pve-devel] proxmox 2018 : add support for "virtual" network and network plugins ?

> On January 26, 2018 at 6:18 PM Alexandre DERUMIER wrote: > > > > After all, if we don't do s-nat, nat 1:1, why not just configure the gateway > > > > of the vm to use the external router directly > > >>Because there is no route to the external router? Please can you

Re: [pve-devel] proxmox 2018 : add support for "virtual" network and network plugins ?

> After all, if we don't do s-nat, nat 1:1, why not just configure the gateway > of the vm to use the external router directly Because there is no route to the external router? Please can you elaborate on that? ___ pve-devel mailing list

Re: [pve-devel] proxmox 2018 : add support for "virtual" network and network plugins ?

> On January 26, 2018 at 2:26 PM Alexandre DERUMIER wrote: > > > >>What is wrong using proxy-arp? > > each vmbr which have the gateway, have the same ip AND mac address. The idea is to use a link local IP, and do not expose that IP to the router at all. I need to run

<    2   3   4   5   6   7   8   9   10   11   >