applied
___
pve-devel mailing list
pve-devel@pve.proxmox.com
https://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
applied
___
pve-devel mailing list
pve-devel@pve.proxmox.com
https://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
applied
___
pve-devel mailing list
pve-devel@pve.proxmox.com
https://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
applied
___
pve-devel mailing list
pve-devel@pve.proxmox.com
https://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
Some people would consider this an information leak?
> On June 21, 2017 at 11:51 AM Dominik Csapak wrote:
>
>
> this can be used to show the cluster we are on
___
pve-devel mailing list
pve-devel@pve.proxmox.com
https://pve.proxmox.com/cgi-bin/mailma
applied
___
pve-devel mailing list
pve-devel@pve.proxmox.com
https://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
applied
___
pve-devel mailing list
pve-devel@pve.proxmox.com
https://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
applied
___
pve-devel mailing list
pve-devel@pve.proxmox.com
https://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
applied
___
pve-devel mailing list
pve-devel@pve.proxmox.com
https://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
applied
___
pve-devel mailing list
pve-devel@pve.proxmox.com
https://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
applied
___
pve-devel mailing list
pve-devel@pve.proxmox.com
https://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
applied
___
pve-devel mailing list
pve-devel@pve.proxmox.com
https://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
question inline:
> On June 21, 2017 at 2:59 PM Wolfgang Bumiller wrote:
>
>
> ---
> PVE/Storage/LVMPlugin.pm | 11 ---
> PVE/Storage/LvmThinPlugin.pm | 15 +++
> 2 files changed, 23 insertions(+), 3 deletions(-)
>
> diff --git a/PVE/Storage/LVMPlugin.pm b/PVE/Storage/L
applied
___
pve-devel mailing list
pve-devel@pve.proxmox.com
https://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
comments inline
> On June 21, 2017 at 2:59 PM Wolfgang Bumiller wrote:
>
>
> All of them have a `+size` prefix to show that they're not
> "pure raw" or "pure tar" streams, because some storage may
> need to know in advance how much storage to allocate.
> The formats are explained in comments.
>
applied
___
pve-devel mailing list
pve-devel@pve.proxmox.com
https://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
Signed-off-by: Dietmar Maurer
---
src/PVE/LXC/Migrate.pm | 21 +
1 file changed, 21 insertions(+)
diff --git a/src/PVE/LXC/Migrate.pm b/src/PVE/LXC/Migrate.pm
index 8d7b50b..fb33e8c 100644
--- a/src/PVE/LXC/Migrate.pm
+++ b/src/PVE/LXC/Migrate.pm
@@ -11,6 +11,9 @@ use PVE
> > + foreach my $key (keys %{$stateobj->{$vmid}}) {
> > + if ($key =~ /^(.*\/)\Q$mig_node\E$/) {
> > + $tmp_state->{"$1$new_target"} = $stateobj->{$vmid}->{$key};
> > + } else {
> > + $tmp_state->{$key} = $stateobj->{$vmid}->{$key};
> > + }
> > + }
> > +
>
> diff --git a/PVE/QemuMigrate.pm b/PVE/QemuMigrate.pm
> index 8e541bf..0c931c5 100644
> --- a/PVE/QemuMigrate.pm
> +++ b/PVE/QemuMigrate.pm
> @@ -859,8 +859,21 @@ my $transfer_replication_state = sub {
> my $stateobj = PVE::ReplicationState::read_state();
>
> if (defined($stateobj->{$v
applied with suggested fixes
___
pve-devel mailing list
pve-devel@pve.proxmox.com
https://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
applied
___
pve-devel mailing list
pve-devel@pve.proxmox.com
https://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
applied
___
pve-devel mailing list
pve-devel@pve.proxmox.com
https://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
applied
___
pve-devel mailing list
pve-devel@pve.proxmox.com
https://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
applied
___
pve-devel mailing list
pve-devel@pve.proxmox.com
https://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
applied
___
pve-devel mailing list
pve-devel@pve.proxmox.com
https://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
applied
___
pve-devel mailing list
pve-devel@pve.proxmox.com
https://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
Signed-off-by: Dietmar Maurer
---
PVE/QemuMigrate.pm | 54 +-
1 file changed, 53 insertions(+), 1 deletion(-)
diff --git a/PVE/QemuMigrate.pm b/PVE/QemuMigrate.pm
index bf0bb44..85fa6ff 100644
--- a/PVE/QemuMigrate.pm
+++ b/PVE/QemuMigrate.pm
Signed-off-by: Dietmar Maurer
---
PVE/API2/Replication.pm| 6 +++---
bin/test/ReplicationTestEnv.pm | 2 +-
2 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/PVE/API2/Replication.pm b/PVE/API2/Replication.pm
index c4a37e4b..117fe57d 100644
--- a/PVE/API2/Replication.pm
+++ b
Signed-off-by: Dietmar Maurer
---
PVE/ReplicationConfig.pm | 13 +
1 file changed, 13 insertions(+)
diff --git a/PVE/ReplicationConfig.pm b/PVE/ReplicationConfig.pm
index 845d9c3..1e813dd 100644
--- a/PVE/ReplicationConfig.pm
+++ b/PVE/ReplicationConfig.pm
@@ -209,6 +209,19 @@ sub
Signed-off-by: Dietmar Maurer
---
PVE/Replication.pm | 24
PVE/ReplicationState.pm | 33 +
2 files changed, 37 insertions(+), 20 deletions(-)
diff --git a/PVE/Replication.pm b/PVE/Replication.pm
index 1762f2d..7686222 100644
--- a
This is just a cleanup (simply factor out code from replicate()).
Signed-off-by: Dietmar Maurer
---
PVE/Replication.pm | 73 +++---
1 file changed, 47 insertions(+), 26 deletions(-)
diff --git a/PVE/Replication.pm b/PVE/Replication.pm
index
used for regression tests
Signed-off-by: Dietmar Maurer
---
PVE/Replication.pm | 14 ++
1 file changed, 10 insertions(+), 4 deletions(-)
diff --git a/PVE/Replication.pm b/PVE/Replication.pm
index 64432eb..0db427d 100644
--- a/PVE/Replication.pm
+++ b/PVE/Replication.pm
@@ -301,7
Signed-off-by: Dietmar Maurer
---
PVE/Replication.pm | 15 ---
1 file changed, 12 insertions(+), 3 deletions(-)
diff --git a/PVE/Replication.pm b/PVE/Replication.pm
index 7686222..64432eb 100644
--- a/PVE/Replication.pm
+++ b/PVE/Replication.pm
@@ -208,7 +208,7 @@ sub replicate
applied
___
pve-devel mailing list
pve-devel@pve.proxmox.com
https://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
> BTW, great work for new storage replication code,
I will try to finish this this week.
> I'm going to test it soon, and maybe try to implement ceph rbd import/export
> on top of it)
great!
___
pve-devel mailing list
pve-devel@pve.proxmox.com
https:
> Any comments to include cloudinit for proxmox5 ?
> (I didn't have any comments on my last month patches serie)
AFAIR I already mentioned that we have no spare time to do it
for the 5.0 release...
___
pve-devel mailing list
pve-devel@pve.proxmox.com
ht
thanks. We also want a regression test for get_replicatable_volumes
here (similar to the one in qemu-server).
___
pve-devel mailing list
pve-devel@pve.proxmox.com
https://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
> but it looks qm create does not check the
> allowed content types so qm create ... local:4 worked in all case
I guess this is a bug we should fix?
___
pve-devel mailing list
pve-devel@pve.proxmox.com
https://pve.proxmox.com/cgi-bin/mailman/listinfo/pv
> @@ -848,13 +877,21 @@ sub phase3 {
> my $volids = $self->{volumes};
> return if $self->{phase2errors};
>
> +my $rep_cfg = PVE::ReplicationConfig->new();
> +my $new_target = $self->{opts}->{node};
Why $self->{opts}->{node} ? (instead of $self->{node})
___
applied all 7 patches
___
pve-devel mailing list
pve-devel@pve.proxmox.com
https://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
applied a similar patch (passes all regression tests).
___
pve-devel mailing list
pve-devel@pve.proxmox.com
https://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
> as for the cdrom, this fails already when you have one set to 'none' or
> 'cdrom' so if this patch is wrong,
> there is still an error here
OK, I fixed this and added regression tests:
https://git.proxmox.com/?p=qemu-server.git;a=commitdiff;h=3097a06bca518443ee902fd214ff3323d71aba28
If you fi
> On 06/13/2017 05:11 PM, Dietmar Maurer wrote:
> > I think this change is wrong!
> >
>
> any details as to why?
At least it changes the behavior of that method.
> we do not modify neither $attr nor $cleanup, so the data is the same in
> both locations.
>
applied
___
pve-devel mailing list
pve-devel@pve.proxmox.com
https://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
I think this change is wrong!
> Signed-off-by: Dominik Csapak
> ---
> PVE/QemuConfig.pm | 7 +++
> 1 file changed, 3 insertions(+), 4 deletions(-)
>
> diff --git a/PVE/QemuConfig.pm b/PVE/QemuConfig.pm
> index 3f59b4c..6f9bde9 100644
> --- a/PVE/QemuConfig.pm
> +++ b/PVE/QemuConfig.pm
> @@
I though this is disabled on a default installation? (local-lvm or local-zfs
are enabled)?
> On June 13, 2017 at 3:18 PM Emmanuel Kasper wrote:
>
>
> (using local storage as the qm config example a bit below also uses that)
> ---
> qm.adoc | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-
> > + if (defined($snaprefs)) {
> > + my $snapnames = join(', ', sort keys %$snaprefs);
> > + $msg .= " (referenced in snapshot - $snapnames)"
> >
>
> Here is a bracket missing
sorry, just committed a fix.
applied
___
pve-devel mailing list
pve-devel@pve.proxmox.com
https://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
applied
___
pve-devel mailing list
pve-devel@pve.proxmox.com
https://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
applied
___
pve-devel mailing list
pve-devel@pve.proxmox.com
https://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
> On June 13, 2017 at 8:38 AM Dietmar Maurer wrote:
>
>
> Signed-off-by: Dietmar Maurer
> ---
> PVE/QemuConfig.pm | 6 ++
> 1 file changed, 6 insertions(+)
>
> diff --git a/PVE/QemuConfig.pm b/PVE/QemuConfig.pm
> index 8a8cb5b..05447dc 100644
> --
applied fixed version.
> actually tested it, but this looks wrong to me. if a volid is
> referenced both in the current config and in a snapshot, we now ONLY do
> the config related checks (meaning we don't catch that it might not be
> migratable because it is referenced in a snapshot).
>
> the p
applied
___
pve-devel mailing list
pve-devel@pve.proxmox.com
https://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
applied
___
pve-devel mailing list
pve-devel@pve.proxmox.com
https://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
applied
___
pve-devel mailing list
pve-devel@pve.proxmox.com
https://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
> On June 13, 2017 at 8:47 AM Wolfgang Link wrote:
>
>
> On 06/13/2017 08:44 AM, Dietmar Maurer wrote:
> >> On 06/12/2017 04:01 PM, Dietmar Maurer wrote:
> >>>> +# add 'unusedX' volumes to volhash
> >>>> +foreach my
> On 06/12/2017 04:01 PM, Dietmar Maurer wrote:
> >> +# add 'unusedX' volumes to volhash
> >> +foreach my $key (keys %$conf) {
> >> + my $value = $conf->{$key};
> >> + if ($key =~ m/^unused/) {
> >> + my $drive = PVE::Q
Signed-off-by: Dietmar Maurer
---
PVE/QemuMigrate.pm | 42 +-
1 file changed, 17 insertions(+), 25 deletions(-)
diff --git a/PVE/QemuMigrate.pm b/PVE/QemuMigrate.pm
index 22c0d7d..2527cba 100644
--- a/PVE/QemuMigrate.pm
+++ b/PVE/QemuMigrate.pm
@@ -269,9
Signed-off-by: Dietmar Maurer
---
PVE/QemuConfig.pm | 22 --
1 file changed, 4 insertions(+), 18 deletions(-)
diff --git a/PVE/QemuConfig.pm b/PVE/QemuConfig.pm
index 05447dc..f31d996 100644
--- a/PVE/QemuConfig.pm
+++ b/PVE/QemuConfig.pm
@@ -69,9 +69,7 @@ sub
Signed-off-by: Dietmar Maurer
---
PVE/QemuConfig.pm | 6 ++
1 file changed, 6 insertions(+)
diff --git a/PVE/QemuConfig.pm b/PVE/QemuConfig.pm
index 8a8cb5b..05447dc 100644
--- a/PVE/QemuConfig.pm
+++ b/PVE/QemuConfig.pm
@@ -73,6 +73,12 @@ sub get_replicatable_volumes {
return if
That way we can pass more informations, i.e. the 'replicate' attribute.
Signed-off-by: Dietmar Maurer
---
PVE/QemuServer.pm | 16 ++--
1 file changed, 10 insertions(+), 6 deletions(-)
diff --git a/PVE/QemuServer.pm b/PVE/QemuServer.pm
index 0efab21..758b56a 100644
So that we can test if a volume is referenced in the main config, and/or
inside a snapshot config.
Signed-off-by: Dietmar Maurer
---
PVE/QemuServer.pm | 14 ++
1 file changed, 10 insertions(+), 4 deletions(-)
diff --git a/PVE/QemuServer.pm b/PVE/QemuServer.pm
index 758b56a..1a4860e
applied
___
pve-devel mailing list
pve-devel@pve.proxmox.com
https://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
Can we catch that at the caller site instead?
> On June 12, 2017 at 3:03 PM Dominik Csapak wrote:
>
>
> to avoid "use of uninitialized value in pattern match at line 105"
>
> Signed-off-by: Dominik Csapak
> ---
> src/PVE/CalendarEvent.pm | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff -
applied
___
pve-devel mailing list
pve-devel@pve.proxmox.com
https://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
applied
___
pve-devel mailing list
pve-devel@pve.proxmox.com
https://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
> +# add 'unusedX' volumes to volhash
> +foreach my $key (keys %$conf) {
> + my $value = $conf->{$key};
> + if ($key =~ m/^unused/) {
> + my $drive = PVE::QemuServer::parse_drive($key, $value);
AFAIR $value is already a volid, so what is the purpose of this parse_drive
call
why backwards?
> On June 12, 2017 at 1:29 PM Wolfgang Bumiller wrote:
>
>
> On Mon, Jun 12, 2017 at 11:35:58AM +0200, Dietmar Maurer wrote:
> > applied a modified version, renamed to write_vmid_job_states()
>
> Should have swapped the parameters while you were at
applied (rebased).
___
pve-devel mailing list
pve-devel@pve.proxmox.com
https://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
applied a modified version, renamed to write_vmid_job_states()
___
pve-devel mailing list
pve-devel@pve.proxmox.com
https://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
Why don't you use write_job_state() ?
> +sub set_remote_state {
> +my ($state, $vmid) = @_;
> +
> +my $update = sub {
> + my $stateobj = read_state();
> + $stateobj->{$vmid} = $state;
> + PVE::Tools::file_set_contents($state_path, encode_json($stateobj));
> +};
> +
> +m
applied
___
pve-devel mailing list
pve-devel@pve.proxmox.com
https://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
applied
___
pve-devel mailing list
pve-devel@pve.proxmox.com
https://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
applied
___
pve-devel mailing list
pve-devel@pve.proxmox.com
https://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
> misleading subject, as this is not in pve-manager :P
oh, sorry.
> but, shouldn't it actually be in PVE::AbstractConfig->snapshot_rollback?
Yes. Wolfgang (Link) is working on an improved version.
___
pve-devel mailing list
pve-devel@pve.proxmox.com
h
We want to remove all replication snapshots before rollback (some storage
backends (i.e. zfs) rejects rollback if there are newer snapshots).
Next replication can simply use the rolled-backed snapshot as base.
Signed-off-by: Dietmar Maurer
---
PVE/API2/Qemu.pm | 21 -
1
And remove all replication snapshots in that case. This is useful
for snapshot rollback.
Signed-off-by: Dietmar Maurer
---
PVE/Replication.pm | 12 +---
1 file changed, 9 insertions(+), 3 deletions(-)
diff --git a/PVE/Replication.pm b/PVE/Replication.pm
index f978267..0fa0ffe 100644
Hi all,
I finally moved PVE/Replication.pm to pve-guest-common, so that we can re-use
the code
for local disk migration.
https://git.proxmox.com/?p=pve-guest-common.git;a=commitdiff;h=a6538c1ec5e77af5a5ae4b16eb1306d98d4ced58
https://git.proxmox.com/?p=pve-manager.git;a=commitdiff;h=51e0615b6bf78d
applied
___
pve-devel mailing list
pve-devel@pve.proxmox.com
https://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
applied
___
pve-devel mailing list
pve-devel@pve.proxmox.com
https://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
Moved from PVE::Replication.
Signed-off-by: Dietmar Maurer
---
PVE/ReplicationConfig.pm | 12
1 file changed, 12 insertions(+)
diff --git a/PVE/ReplicationConfig.pm b/PVE/ReplicationConfig.pm
index 01e7206..845d9c3 100644
--- a/PVE/ReplicationConfig.pm
+++ b/PVE
Moved code from PVE::Replication.
Signed-off-by: Dietmar Maurer
---
PVE/ReplicationState.pm | 100
1 file changed, 100 insertions(+)
diff --git a/PVE/ReplicationState.pm b/PVE/ReplicationState.pm
index be5cf5f..22649f9 100644
--- a/PVE
applied
___
pve-devel mailing list
pve-devel@pve.proxmox.com
https://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
applied
___
pve-devel mailing list
pve-devel@pve.proxmox.com
https://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
> with v2 for #3, and a follow-up commit splitting the Depends: line.
>
> thanks - IMHO this has been long overdue!
Yes, thanks!!
___
pve-devel mailing list
pve-devel@pve.proxmox.com
https://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
> > > doesn't this return the first job which has this target node? and not
> > > the only job which has this guest ID and target node?
> >
> > We may also have different replication job types in future, and not all
> > of them have a 'target' property...
>
> hmm.. maybe a more abstract method to
applied
___
pve-devel mailing list
pve-devel@pve.proxmox.com
https://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
applied
___
pve-devel mailing list
pve-devel@pve.proxmox.com
https://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
applied
___
pve-devel mailing list
pve-devel@pve.proxmox.com
https://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
applied
___
pve-devel mailing list
pve-devel@pve.proxmox.com
https://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
applied
___
pve-devel mailing list
pve-devel@pve.proxmox.com
https://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
applied
___
pve-devel mailing list
pve-devel@pve.proxmox.com
https://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
applied
___
pve-devel mailing list
pve-devel@pve.proxmox.com
https://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
applied
___
pve-devel mailing list
pve-devel@pve.proxmox.com
https://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
applied
___
pve-devel mailing list
pve-devel@pve.proxmox.com
https://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
applied
___
pve-devel mailing list
pve-devel@pve.proxmox.com
https://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
> On June 9, 2017 at 11:17 AM Fabian Grünbichler
> wrote:
>
>
> On Fri, Jun 09, 2017 at 08:19:47AM +0200, Wolfgang Link wrote:
> > ---
> > PVE/ReplicationConfig.pm | 14 ++
> > 1 file changed, 14 insertions(+)
> >
> > diff --git a/PVE/ReplicationConfig.pm b/PVE/ReplicationConfig.
No, I don't want to generate multiple lock directories ...
AFAIK pve-storage also create locks there.
> On June 9, 2017 at 10:51 AM Fabian Grünbichler
> wrote:
>
>
> On Fri, Jun 09, 2017 at 09:55:58AM +0200, Wolfgang Bumiller wrote:
> > ---
> > PVE/GuestHelpers.pm | 3 ++-
> > 1 file changed,
> diff --git a/po/po2js.pl b/po/po2js.pl
> index 6941f5c0..76a84695 100755
> --- a/po/po2js.pl
> +++ b/po/po2js.pl
> @@ -67,7 +67,8 @@ foreach my $k (keys %$href) {
> #use Data::Dumper;
> #print STDERR Dumper(encode_json({test => decode('UTF-8', "müssen")}));
>
> -my $json = encode_json($catalo
So that we can (re)use methods from PVE::AbstractConfig.
Signed-off-by: Dietmar Maurer
---
PVE/Replication.pm| 62 +--
bin/test/replication_test2.pl | 7 -
2 files changed, 36 insertions(+), 33 deletions(-)
diff --git a/PVE
901 - 1000 of 7518 matches
Mail list logo
