[pve-devel] Another batch of fixes for the firewall tabpanel

Another batch bites the dust ___ pve-devel mailing list pve-devel@pve.proxmox.com http://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

[pve-devel] [PATCH pve-manager 3/3] ext6migrate: fix IPRefSelector ComboGrid

The IPrefSelector ComboGrid can have selected values which are not backed by the component store, ie the store only contains IP aliases, but the ComboGrid can contain an IP adress not registered as an IP alias. In that case we should not try to update the selection in the dropdown, as the

Re: [pve-devel] [RFC manager] ext6/triton: add some visual changes and fixes

On 02/10/2016 04:41 PM, Thomas Lamprecht wrote: > they are mostly intended to save space as the "new theme", if it > gets applied, takes up space like it's worth pure gold. The triton theme is supposed to be able to work on tablets. You need bigger buttons, bigger titles and bigger padding, so

[pve-devel] [PATCH pve-manager] ext6migrate: fix minor selection bug in the ComboGrid

up to now we were only updating the picker selection when the picker was created, which means that subsequent changes in the text field were not propagated to the drop-down list This patch creates a private syncSelection() method which is called each time the picker is shown This is roughly based

[pve-devel] [PATCH pve-manager 1/3] ext6migrate: remove our in house checkcolumn

This component is now available in the framework and works properly ( tested with FirewallRules.js who was the only one using it) --- www/manager6/grid/CheckColumn.js | 38 -- 1 file changed, 38 deletions(-) delete mode 100644 www/manager6/grid/CheckColumn.js

[pve-devel] [PATCH pve-manager 2/3] ext6migrate: enable the Firewall tab

--- www/manager6/dc/Config.js | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/www/manager6/dc/Config.js b/www/manager6/dc/Config.js index f60bb99..b67569c 100644 --- a/www/manager6/dc/Config.js +++ b/www/manager6/dc/Config.js @@ -95,10 +95,8 @@

[pve-devel] Enable part of the datacenter firewall with ExtJS6

This patch serie allows some of the firewall panel to work with ExtSJ6 (at the momment, only toggling the state of an already existing rule) ___ pve-devel mailing list pve-devel@pve.proxmox.com http://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

Re: [pve-devel] [PATCH pve-manager 1/3] When running with extjs=1, construct the includes lists based on manager6 dir content

On 01/25/2016 05:38 PM, Dietmar Maurer wrote: >> @@ -6,6 +9,13 @@ use warnings; >> sub get_index { >> my ($lang, $username, $csrftoken, $console) = @_; >> >> +my $manager_source_dir = '/usr/share/pve-manager/manager6/'; >> + >> +## exit early to avoid this being run by mistake >>

[pve-devel] [PATCH pve-manager 1/2] ext6migrate: remove 'comment' id from Comment column in our tables

The use of this field raise an error with ExtJS6 because it is not unique inside the application. Removing this is safe, because we never query the Comment column with an id. --- www/manager6/dc/AuthView.js | 1 - www/manager6/dc/UserView.js | 1 - www/manager6/form/PoolSelector.js |

[pve-devel] Patch serie to enable the Datacenter Auth Panel

This patch serie enables the Datacenter Auth Panel with ExtJS6 ___ pve-devel mailing list pve-devel@pve.proxmox.com http://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

[pve-devel] [PATCH pve-manager 2/2] ext6migrate: enable the AuthPanel

'data' is renamed to 'comboItems' to match the new KVComboBox --- www/manager6/dc/AuthEdit.js | 2 +- www/manager6/dc/Config.js | 6 ++ 2 files changed, 3 insertions(+), 5 deletions(-) diff --git a/www/manager6/dc/AuthEdit.js b/www/manager6/dc/AuthEdit.js index 356f004..e096dd1 100644 ---

[pve-devel] [PATCH pve-manager 1/3] ext6migrate: use Array.prototype.concat() instead of push()

Using push here would add an array of elements instead of the elements. Seems ExtJS6 can't cope with that. This fix is needed for buttons and columns to be properly displayed when loading the component. --- www/manager6/grid/FirewallRules.js | 6 +++--- 1 file changed, 3 insertions(+), 3

[pve-devel] Further patches for the firewall panel

This patch serie allows more of the Firewall panel to work. It is now possible to remove and edit existing rules ___ pve-devel mailing list pve-devel@pve.proxmox.com http://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

[pve-devel] [PATCH pve-manager 3/3] ext6migrate: adapt to new KVComboBox interface

--- www/manager6/grid/FirewallRules.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/www/manager6/grid/FirewallRules.js b/www/manager6/grid/FirewallRules.js index 7c5cfc0..5fdd581 100644 --- a/www/manager6/grid/FirewallRules.js +++ b/www/manager6/grid/FirewallRules.js

[pve-devel] [PATCH pve-manager 2/3] ext6migrate: replace new with Ext.create()

This allows us in the future to use the ExtJS class autoloader if we want --- www/manager6/grid/FirewallRules.js | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/www/manager6/grid/FirewallRules.js b/www/manager6/grid/FirewallRules.js index 37fc262..7c5cfc0 100644 ---

[pve-devel] [PATCH pve-manager v2] ext6migrate: push array elements separately

This fix is needed for buttons and columns to be properly displayed when loading the component. --- www/manager6/grid/FirewallRules.js | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/www/manager6/grid/FirewallRules.js b/www/manager6/grid/FirewallRules.js index

Re: [pve-devel] [PATCH pve-manager 1/3] ext6migrate: use Array.prototype.concat() instead of push()

On 02/03/2016 02:57 PM, Dietmar Maurer wrote: >> -me.column1.push([ >> +me.column1 = me.column1.concat([ > > removing the [ should do the job? > yes it does the job and shortens the code push() accepts n arguments v2 on the way ___ pve-devel

[pve-devel] [PATCH pve-manager 3/3] ext6migrate: adapt the Checkbox column of the firewall panel to ExtJS6

API changes in ExtJS6 involved here: * 'checkchange' event passes now the record index instead of the whole record * record.fields is now an array of Field objects, before it was an Object --- www/manager6/grid/FirewallRules.js | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff

Re: [pve-devel] [PATCH 1/4] refactor pveam to use it with our CLI Handler.

By the way what do pveam stand for ? Is that for pve appliance manager ? ( helps to remember purpose of command) On 02/24/2016 12:10 PM, Wolfgang Link wrote: > --- > PVE/CLI/Makefile | 2 +- > PVE/CLI/pveam.pm | 88 > > bin/Makefile

[pve-devel] [PATCH pve-manager 2/2] Revert "ext5migrate: do not set a custome idProperty for the KeyValue model"

This reverts commit 3150236aa5ebed6565c6eaf64126bb1195693396. Without using an idProperty in the KeyValue model, the id of each store item is autogenerated, and the DiffStore always recreate the whole store content every second instead of updating the fields where values have changed. Recreating

[pve-devel] [PATCH pve-manager 1/2] Add documentation header for ObjectGrid.js

also enhance the documentation header for DiffStore and UpdateStore --- www/manager6/data/DiffStore.js | 12 +++- www/manager6/data/UpdateStore.js | 3 +++ www/manager6/grid/ObjectGrid.js | 14 ++ 3 files changed, 24 insertions(+), 5 deletions(-) diff --git

[pve-devel] [PATCH pve-manager 3/3] load the store later, move non-dynamic properties and methods to class body

this fixes two problems: * we were loading the store before the parent ComboGrid class could put a listener on the load event * displayField must now be set in class body, take opportunity to move out what we can of the mega initComponent() this two fixes allow the HA GroupEdit Window to

[pve-devel] [PATCH pve-manager 1/3] change xtype name to follow ExtJS and our own conventions

this also fixes the problem that the method Ext.ComponentQuery.query() was outputting a warning since it did not know if it should perform a lookup for a class name or a xtype --- www/manager6/form/NodeSelector.js | 2 +- www/manager6/ha/GroupEdit.js | 2 +- www/manager6/window/Migrate.js

[pve-devel] [PATCH pve-manager 2/3] reload stores of tabpanel children on 'activate' event

Tabpanel reload -> send 'show' event -> reload child panel store do not work with ExtJS6 but Tabpanel reload -> reload child panel -> child send 'show' event -> reload a grid store in the panel still works so we don't blindly replace the 'show' events everywhere but only when the event was

Re: [pve-devel] [PATCH manager 1/4] ext6migrate: fix Task History for nodes

> diff --git a/ww/manager6/node/Tasks.js b/www/manager6/node/Tasks.js > index e76a982..6a73ef8 100644 > --- a/www/manager6/node/Tasks.js > +++ b/www/manager6/node/Tasks.js > @@ -2,7 +2,9 @@ Ext.define('PVE.node.Tasks', { > extend: 'Ext.grid.GridPanel', > > alias:

Re: [pve-devel] [PATCH manager 2/4] ext6migrate: fix LogView

> Signed-off-by: Dominik Csapak > --- > www/manager6/panel/LogView.js | 22 ++ > 1 file changed, 6 insertions(+), 16 deletions(-) > > diff --git a/www/manager6/panel/LogView.js b/www/manager6/panel/LogView.js > index 49be118..9ed1213 100644 > ---

[pve-devel] [PATCH pve-manager 1/4] move tabs of a sub tabpanel to the left by default

This takes a bit of screensize, but is fine as long as the browser horizontal screen size is at least 1280 px ( 92 % of desktop users in 2016 according to StatsCounter) Still usable for the remaining small displays, but horizontal scrolling is needed for grids with a lot of columns. Moving the

[pve-devel] [PATCH pve-manager 4/4] use 'refresh' event to reload the grid after the store content has changed

this fixes the problem that buttons and grid contents were not updated after a service stop/start --- www/manager6/node/ServiceView.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/www/manager6/node/ServiceView.js b/www/manager6/node/ServiceView.js index c701ccb..ab0c1a8

[pve-devel] [PATCH pve-manager 2/4] enable more node panels

--- www/manager6/node/Config.js | 12 1 file changed, 4 insertions(+), 8 deletions(-) diff --git a/www/manager6/node/Config.js b/www/manager6/node/Config.js index 7a65ae2..b617c86 100644 --- a/www/manager6/node/Config.js +++ b/www/manager6/node/Config.js @@ -134,26 +134,22 @@

Re: [pve-devel] [PATCH pve-manager 2/4] enable more node panels

On 02/29/2016 03:40 PM, Dietmar Maurer wrote: > The network panel shows "Pending changes" - always (although > there are no changes). > >> title: gettext('Network'), >> itemId: 'network', >> -// xtype: 'pveNodeNetworkView' >> -xtype:

[pve-devel] [PATCH pve-manager 2/3] adapt BondSelector to our ExtJS6 KVComboBox parameters

--- www/manager6/form/BondModeSelector.js | 14 -- 1 file changed, 4 insertions(+), 10 deletions(-) diff --git a/www/manager6/form/BondModeSelector.js b/www/manager6/form/BondModeSelector.js index 4504e8b..97445d5 100644 --- a/www/manager6/form/BondModeSelector.js +++

[pve-devel] [PATCH pve-manager 3/3] move component properties to prototype body

this is needed for 'displayField' also remove redundant truthiness test which is also taking place at the beginning of setNodeName() --- www/manager6/form/BridgeSelector.js | 66 + 1 file changed, 30 insertions(+), 36 deletions(-) diff --git

[pve-devel] [PATCH pve-manager 1/3] push column items individually

looks like ExtJS is not automatically flattening the array anymore and items in a multidimensionnal array are not displayed with ExtJS6 lxc/Config.js is still commented because we haven't reached this part in the upgrade, but fixing there too --- www/manager6/dc/AuthEdit.js | 4 ++--

[pve-devel] [PATCH pve-manager] fix HA Group Selector display

displayField must now be set in class body, take opportunity to move out other config properties from initComponent() --- www/manager6/ha/GroupSelector.js | 66 ++-- 1 file changed, 30 insertions(+), 36 deletions(-) diff --git

[pve-devel] File package

-4.24137/ The attached file is a patch for that (the file should work with git am) EmmanuelFrom 82824336351cdd2ea5115fec4969a66fa3bea524 Mon Sep 17 00:00:00 2001 From: Emmanuel Kasper <e.kas...@proxmox.com> Date: Thu, 21 Jan 2016 15:53:09 +0100 Subject: [PATCH] Add dependency to 'file' package, wh

[pve-devel] Two "plumbing" patches and one fix for ExtJS6

The first and second patch are temporary changes needed for developpement , the third patch is a bug fix ___ pve-devel mailing list pve-devel@pve.proxmox.com http://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

[pve-devel] [PATCH pve-manager 1/3] When running with extjs=1, construct the includes lists based on manager6 dir content

This way, we don't have to manage manually the list files and let the FS do it. For development purpose only. --- PVE/ExtJSIndex6.pm | 424 - 1 file changed, 223 insertions(+), 201 deletions(-) diff --git a/PVE/ExtJSIndex6.pm

[pve-devel] [PATCH pve-manager 3/3] ext6migrate: fix a long running bug where a logout from the GUI would break the workspace

If we pass true to the removeAll() , ExtJS6 will try to erase the leafes of a tree, and then try to to iterate throuch these leaves in onNodeRemove() ( this obviously do not work) The true parameter does not seem to be needed anyway anymore. After a call to removeAll, the childNodes[] property

[pve-devel] [PATCH pve-manager 2/3] Comment out missing/broken JS classes so we can select nodes in the left ressource tree with ExtJS6

--- www/manager6/lxc/Config.js | 152 www/manager6/qemu/Config.js | 12 ++-- www/manager6/storage/Browser.js | 19 +++-- 3 files changed, 98 insertions(+), 85 deletions(-) diff --git a/www/manager6/lxc/Config.js b/www/manager6/lxc/Config.js

[pve-devel] [PATCH 2/3] ext6migrate: fix ressource tree filter selection

the selection do not return an array but a single 'records' object so records.length is always undefined --- www/manager6/Workspace.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/www/manager6/Workspace.js b/www/manager6/Workspace.js index 5dc4d2a..57a66ac 100644 ---

[pve-devel] [PATCH 1/3] ext6migrate: move static fields to class body

Some fields need to be processed by initConfig(), which will be run before initComponent() in the component lifecycle. This fix the problem of the Selector default value whihc was not loading. --- www/manager6/form/ViewSelector.js | 17 - 1 file changed, 8 insertions(+), 9

[pve-devel] [PATCH 3/3] replace object creation via 'new' with ExtJS methods

This makes the code more homogeneous and allows us to use the ExtJS class autoloader in the future if we want (autoloader idea: ExtJS tries to load the JS class file over HTTP based on the class name, no need to maintain a list of includes) --- www/manager6/Workspace.js | 7 --- 1 file

[pve-devel] First patch serie for fixing the Ressource Tree

This patch series deals with the filtering of object in the ressource tree, the third patch is a cosmetic refactoring. ___ pve-devel mailing list pve-devel@pve.proxmox.com http://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

[pve-devel] [PATCH pve-manager] ext6migrate: fix picker dropdown on ViewSelector initial load

This fixes a nasty bug where an initial click on the ViewSelector trigger would display the picker but hide it immediatly afterwards. What was happening behind the scene, is that without queryMode 'local', the store bound to the picker was loaded on each picker display. Loading the store would

[pve-devel] [PATCH pve-manager 2/3] ext6migrate: set valueField as a class property

Also moves to full declarative style for IPProtocolSelector, saves 11 lines of of boilerplate code (works when the store is local and not pulled over the API) --- www/manager6/form/IPProtocolSelector.js | 69 ++--- www/manager6/grid/FirewallRules.js | 39

[pve-devel] [PATCH pve-manager 1/3] Ext6migrate: Update our ComboGrid component to work with ExtJS6

The ComboGrid combonent requires row-like selection something that the default ExtJS Ext.selection.DataViewModel used for ComboBox cannot do. This requires overriding the protected method onBindStore() where the selection model is set. --- www/manager6/form/ComboGrid.js | 271

[pve-devel] [PATCH pve-manager 1/3] Added UI elements for the backup job disabling function

Added a column in the datacenter backup job overview to see if a job is enabled or not. Added checkbox to the input panel, which enables or disables a job. This closes bug/feature request 492. This patch was missing in manager6 --- www/manager6/dc/Backup.js | 17 - 1 file

[pve-devel] [PATCH pve-manager 2/3] Fix warning in Browser console due to missing meta entry

We're not going to support mobile devices via the standard gui, but ExtJS 6 themes need this --- PVE/ExtJSIndex6.pm | 1 + 1 file changed, 1 insertion(+) diff --git a/PVE/ExtJSIndex6.pm b/PVE/ExtJSIndex6.pm index aa6ffa3..68183aa 100644 --- a/PVE/ExtJSIndex6.pm +++ b/PVE/ExtJSIndex6.pm @@ -21,6

[pve-devel] [PATCH pve-manager 3/3] Enable HA datacenter panel

No further changes needed here --- www/manager6/dc/Config.js | 8 +++- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/www/manager6/dc/Config.js b/www/manager6/dc/Config.js index b67569c..977d3c9 100644 --- a/www/manager6/dc/Config.js +++ b/www/manager6/dc/Config.js @@ -86,11

[pve-devel] Minor patches for ext6 migration

A couple of minor patches for manager6/ ___ pve-devel mailing list pve-devel@pve.proxmox.com http://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

[pve-devel] [PATCH pve-manager 2/2] Add class documentation header

--- www/manager6/panel/ConfigPanel.js | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/www/manager6/panel/ConfigPanel.js b/www/manager6/panel/ConfigPanel.js index bfa9211..94f8fbe 100644 --- a/www/manager6/panel/ConfigPanel.js +++ b/www/manager6/panel/ConfigPanel.js @@

[pve-devel] [PATCH pve-manager 1/2] use 'refresh' event to reload the grid after filtering the store

'datachanged' event was not reloading the store with ExtJS5, but 'refresh' does. According to the API description 'refresh' seems to be what we need: http://docs.sencha.com/extjs/5.1/5.1.0-apidocs/#!/api/Ext.data.AbstractStore-event-refresh also remove deprecated readme ( ExtJS6 do not have the

[pve-devel] [PATCH pve-manager 3/4] temporary disable accessibility warnings

ExtJS6 adds accessibility (aria) support to the framework, which means special handling of space/enter key and panels title, and a lot of warnings / errors in the browser console Aria support will be reenabled after all the components are migrated to ExtJS6 --- www/manager6/Utils.js | 7 +++

[pve-devel] [PATCH pve-manager 4/4] rename 'autoscroll' parameter to 'scrollable' following framework changes

also move static parameters out of initComponent() for proper panel initialization --- www/manager6/node/Summary.js | 13 +++-- 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/www/manager6/node/Summary.js b/www/manager6/node/Summary.js index 6d44869..b01f848 100644 ---

[pve-devel] [PATCH pve-manager 2/4] remove redundant model definition

pve-services is already declared in ServiceView.js provoking a namespace clash --- www/manager6/node/Subscription.js | 8 1 file changed, 8 deletions(-) diff --git a/www/manager6/node/Subscription.js b/www/manager6/node/Subscription.js index 8101d1b..c4e9979 100644 ---

[pve-devel] [PATCH pve-manager 1/4] Fix initial loading of Node tabpanel:

* push initial components individually * replace ifor the momment pvepanels with basic panels so we can at least load the first tabs * group ceph component with previous push call as they require the same capabilities --- www/manager6/node/Config.js | 65

[pve-devel] [PATCH pve-manager] rename component 'id' property to 'stateId'

ExtJS6 requires a stateId if we want to save the component state (seems it is not autogenerated anymore from 'id') this fix the selection of timeframes in the Summary View also move properties out of initComponent() also remove code which duplicates framework code: setting stateEvents to

Re: [pve-devel] [PATCH pve-manager] reselect the current node after a tree refresh

This patch triggers a not so beautiful flicker of the tab panel, please ignore I have a better patch on the way. On 03/10/2016 03:43 PM, Emmanuel Kasper wrote: > if the selected node has its status changed between stop & > running, the node is removed and then readded > during the

[pve-devel] [PATCH pve-manager] reselect the current node after a tree refresh

if the selected node has its status changed between stop & running, the node is removed and then readded during the remove / add process the 'selected' status of the node is lost if it has one, so we need to reselect it this fixes a graphical bug where starting/stopping a VM/container would

Re: [pve-devel] [PATCH manager 04/10] ext6migrate: fix dropboxes in Storage Edit windows

> fix dropboxes in Storage Edit windows I guess you mean comboboxes here, otherwie some people might thing we have a new cloud based storage plugin ! ___ pve-devel mailing list pve-devel@pve.proxmox.com

[pve-devel] [PATCH pve-manager] Don't set a fix size for MPResize window

Due to the font increase of the Crisp theme, the text was truncated Instead of setting manually window size, let the items of the component freely expend to what they need ( layout 'fit') --- www/manager6/lxc/MPResize.js | 2 -- 1 file changed, 2 deletions(-) diff --git

[pve-devel] [PATCH pve-manager v2] update leaf nodes instead of removing / readding them

if the selected node has its status changed between stop & running, the node was removed and then readded during the remove / add process the 'selected' status of the node was lost if it has one instead of deleting / readding the node, we update now its content this was the default behaviour for

[pve-devel] [PATCH pve-manager 1/3] css improvements for crisp theme

* usability improvement for enabled buttons: in the default theme, ExtJS uses two different nuances of grey to distinguish enabled or disabled buttons the problem is that compared to the full black of the panels titles, it gives the impression that everything is disabled (the contrast is not

[pve-devel] [PATCH pve-manager 3/3] Fix LXC summary view:

* replace scrollable with autoScroll and move to prototype body * use 'activate' to load store on F5 * do not set a height on the StatusView component: it hides some rows, and the framework sets a good working default height --- www/manager6/lxc/StatusView.js | 1 -

[pve-devel] [PATCH pve-manager 2/3] Enable last remaining lxc panels

--- www/manager6/lxc/Config.js | 36 +--- 1 file changed, 17 insertions(+), 19 deletions(-) diff --git a/www/manager6/lxc/Config.js b/www/manager6/lxc/Config.js index 8902c86..491a5f8 100644 --- a/www/manager6/lxc/Config.js +++ b/www/manager6/lxc/Config.js @@

[pve-devel] [PATCH pve-manager 1/5] use 'refresh' event to redisplay the grid after loading the store

'datachanged' event is not actualizing the component with ExtJS6, but 'refresh' does. --- www/manager6/lxc/Snapshot.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/www/manager6/lxc/Snapshot.js b/www/manager6/lxc/Snapshot.js index 7b2e33a..bded7cd 100644 ---

[pve-devel] [PATCH pve-manager 5/5] Enlarge Wizard window vertically to accomodate all our LXC settings

Without this, the summary grid in the end of the LXC creation wizard needs to be scrolled to see some settings. Note that we still want to use a fixed height, so that all wizard panels have the same height and next/previous buttons are always displayed at the same place. ---

[pve-devel] [PATCH pve-manager 4/5] use Ext.apply() instead of Ext.applyIf() to properly load child items

--- www/manager6/window/Wizard.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/www/manager6/window/Wizard.js b/www/manager6/window/Wizard.js index 0e6b02d..cc7f3fb 100644 --- a/www/manager6/window/Wizard.js +++ b/www/manager6/window/Wizard.js @@ -171,7 +171,7 @@

[pve-devel] [PATCH pve-manager 3/5] use proper xtype name

--- www/manager6/lxc/CreateWizard.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/www/manager6/lxc/CreateWizard.js b/www/manager6/lxc/CreateWizard.js index fee77d8..a1a7b57 100644 --- a/www/manager6/lxc/CreateWizard.js +++ b/www/manager6/lxc/CreateWizard.js @@ -58,7 +58,7

[pve-devel] [PATCH pve-manager 2/5] fix delayed store loading

Because the store loading delay, it can be that reload() fails on trying to load an undefined store, if the user switched tabs in the meantime --- www/manager6/grid/BackupView.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/www/manager6/grid/BackupView.js

[pve-devel] last fixes for LXC

this patch series completes the adaptation of lxc components to ExtJS all components should be now working in LXC except boot ordering settings which requires a class from the qemu folder ___ pve-devel mailing list pve-devel@pve.proxmox.com

[pve-devel] [PATCH pve-manager 3/5] replace calls to new() with Ext.create()

--- www/manager6/grid/ObjectGrid.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/www/manager6/grid/ObjectGrid.js b/www/manager6/grid/ObjectGrid.js index 466e7be..159c9c8 100644 --- a/www/manager6/grid/ObjectGrid.js +++ b/www/manager6/grid/ObjectGrid.js @@ -82,12 +82,12

[pve-devel] [PATCH pve-manager 4/5] Fixes Hardware View gridPanel for ExtJS6

* uses Ext.apply() instead of applyIf(), because the parent class already set a toolbar to 'null', and we want to override that * use 'activate' event to redisplay content on page reload * use a managed listener via mon() so we ignore events from the store when the component is not displayed

[pve-devel] first patch serie for LXC panel

this patch serie fixes a first group of Lxc tabs ___ pve-devel mailing list pve-devel@pve.proxmox.com http://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

[pve-devel] [PATCH pve-manager 2/6] load/reload stores of tabpanel children on 'activate' event

--- www/manager6/lxc/DNS.js | 5 ++--- www/manager6/lxc/Network.js | 4 +--- www/manager6/lxc/Options.js | 5 ++--- www/manager6/lxc/Resources.js| 2 +- www/manager6/lxc/SnapshotTree.js | 4 ++-- 5 files changed, 8 insertions(+), 12 deletions(-) diff --git

[pve-devel] [PATCH pve-manager 5/6] Fix ComboBoxes when adding a mountpoint

reasoning identic to: commit 548b29644df81408fc0fb4f3f450047e906c26c7 adapt KVComboBoxes to pass store items using 'comboItems' parameter --- www/manager6/lxc/ResourceEdit.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/www/manager6/lxc/ResourceEdit.js

[pve-devel] [PATCH pve-manager 1/6] fix lxc console selection ComboBox for extjs6

reasoning identic to commit 548b29644df81408fc0fb4f3f450047e906c26c7 adapt KVComboBoxes to pass store items using 'comboItems' parameter commit 7515e62236b9f3c8317c3aa0dbf470e2b8efdd71 ext6migrate fix model behaviour for KVComboBox --- www/manager6/lxc/Options.js | 6 +++--- 1 file changed, 3

[pve-devel] [PATCH pve-manager 3/6] fix display of lxc console button text

same reasoning as 841343e1c80a1d81a0e4fa90def389983f4a60fe do not use applyIf when adding items in initComponent() --- www/manager6/button/ConsoleButton.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/www/manager6/button/ConsoleButton.js

[pve-devel] [PATCH pve-manager 6/6] fix storage selector 'change' event handling

the initial loading of the storage selector fires a 'change' event via the 'onLoad' method of its parent class at that point the value of the storage selector is empty, and the callback function fails --- www/manager6/lxc/ResourceEdit.js | 3 +++ 1 file changed, 3 insertions(+) diff --git

[pve-devel] [PATCH pve-manager 4/6] copy missing methods from ExtJS 4 Parser.js

--- www/manager6/Parser.js | 142 - 1 file changed, 141 insertions(+), 1 deletion(-) diff --git a/www/manager6/Parser.js b/www/manager6/Parser.js index 5f15a76..68a6b70 100644 --- a/www/manager6/Parser.js +++ b/www/manager6/Parser.js @@ -5,6 +5,16

[pve-devel] [PATCH pve-manager] SafeDestroy.js: allow to submit the form with Enter key

also set focus on the confirm field of the Destroy Window on display --- www/manager6/window/SafeDestroy.js | 13 - 1 file changed, 12 insertions(+), 1 deletion(-) diff --git a/www/manager6/window/SafeDestroy.js b/www/manager6/window/SafeDestroy.js index ec4a2f5..fea9594 100644 ---

[pve-devel] [PATCH pve-manager] Readme.md: add pveproxy restart as neeed step for testing ExtJS6 GUI

--- www/manager6/Readme.md | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/www/manager6/Readme.md b/www/manager6/Readme.md index 81c3b26..e59c6aa 100644 --- a/www/manager6/Readme.md +++ b/www/manager6/Readme.md @@ -11,6 +11,10 @@ symlink the ext6 dir in pve-manager to the

[pve-devel] [PATCH pve-manager] Update French po files

iqu...@gmail.com>\n" +"PO-Revision-Date: 2016-04-05 16:52+0100\n" +"Last-Translator: Emmanuel Kasper <e.kas...@proxmox.com>\n" "Language-Team: French\n" "Language: fr\n" "MIME-Version: 1.0\n" "Content-Type: text/plain; ch

[pve-devel] [PATCH pve-manager v2] Update French po files

iqu...@gmail.com>\n" +"PO-Revision-Date: 2016-04-07 13:14+0100\n" +"Last-Translator: Emmanuel Kasper <e.kas...@proxmox.com>\n" "Language-Team: French\n" "Language: fr\n" "MIME-Version: 1.0\n" "Content-Type: text/plain; ch

[pve-devel] [PATCH pve-manager] Overrides Ext.Msg.alert() to always display an Error Icon

--- www/manager6/Toolkit.js | 22 ++ 1 file changed, 22 insertions(+) diff --git a/www/manager6/Toolkit.js b/www/manager6/Toolkit.js index 91a4fa6..a8089aa 100644 --- a/www/manager6/Toolkit.js +++ b/www/manager6/Toolkit.js @@ -137,6 +137,28 @@ Ext.define('PVE.Datepicker', {

[pve-devel] [PATCH pve-docs] Replace VM occurences with 'guest' or 'container' when appropriate

also replace Qemu/KVM with QemuServer as it is the detailed term used in the vzdump man page --- vzdump.adoc | 20 ++-- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/vzdump.adoc b/vzdump.adoc index fc42468..b8794d9 100644 --- a/vzdump.adoc +++ b/vzdump.adoc @@

Re: [pve-devel] Generic term to cover VMs and containers in the documentation

On 04/12/2016 02:09 PM, Fabian Grünbichler wrote: >> Emmanuel Kasper <e.kas...@proxmox.com> hat am 12. April 2016 um 13:55 >> geschrieben: >> What would be a good term to cover both of these ? >> >> I am thinking of either 'machine' or 'virtualized sys

[pve-devel] [PATCH pve-docs] Add subchapter about ACLs, and make even more clear what quotas are about

Some users thinks quotas relate to the amount of diskspace used for the mountpoint as the whole. --- pct.adoc | 11 +++ 1 file changed, 11 insertions(+) diff --git a/pct.adoc b/pct.adoc index 82f257b..cd817dd 100644 --- a/pct.adoc +++ b/pct.adoc @@ -401,6 +401,8 @@ Similarly device

[pve-devel] [PATCH pve-manager 1/2] Recheck field validation after manually enabling the input field of a ComboGrid

Calling setDisabled(true) on a component makes it valid, but calling setDisabled(false) afterwards did not retrigger a validation check This fixes a serious bug which was happening in the following conditions, for instance in the template tab of LXC Wizard: 1) user selects a storage 2) this

[pve-devel] [PATCH pve-manager 2/2] Do not disable a invalid previous tab, as this make the tab fields valid

disable_at() iterates over all the fields of the previously selected tab and disables them however disabling an input field makes it valid for validation purposes. I can't see a reason why disabling the tab fields is needed, since the tab already hidden and after testing, it seems safe to remove

Re: [pve-devel] [PATCH manager] www: monitor: support page up/down, home/end

On 04/11/2016 02:28 PM, Wolfgang Bumiller wrote: > Actually... the home/end key part might annoy some people... > Thoughts? Disclaimer: I rarely use the Monitor in the GUI. But yes people would expect HOME and END to interact within the input field, not with other stuff on the display, so it's

Re: [pve-devel] [PATCH pve-docs] Add subchapter about ACLs, and make even more clear what quotas are about

On 04/11/2016 05:28 PM, Dietmar Maurer wrote: >> +Please be aware that NFS do not store ACLs, so if you plan to do snapshots >> and >> +restores from a container to a NFS storage, it is advised to disable ACLs >> +in the options of your container mountpoint to avoid bad surprises later. > >

[pve-devel] [PATCH pve-docs v2] Add subchapter about ACLs, and make even more clear what quotas are about

Document that use of a tmpdir is recommended when doing a 'suspend' backup to a NFS share. --- changes since v1: * move NFS related hints to vzdump documentation, recommend tmpdir * reword quota description pct.adoc| 8 vzdump.adoc | 14 ++ 2 files changed, 18

[pve-devel] Generic term to cover VMs and containers in the documentation

Hi While reading the vzdump documentation, I notice that we use there the term VM to describe both containers and qemu based virtualized systems. For instance: 'vzdump' is a utility to make consistent snapshots of running virtual machines (VMs). It basically creates an archive of the VM private

[pve-devel] [PATCH pve-manager 1/5] Fix Qemu summary view:

* replace scrollable with autoScroll and move to prototype body * use 'activate' to load store on F5 * do not set a height on the StatusView component: it hides some rows, and the framework sets a good working default height * replace deprecated 'rows' parameter in textareafield with height in

[pve-devel] [PATCH pve-manager 5/5] Enable four first tabs of Qemu Panel

--- www/manager6/qemu/Config.js | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/www/manager6/qemu/Config.js b/www/manager6/qemu/Config.js index 1d66621..70734a7 100644 --- a/www/manager6/qemu/Config.js +++ b/www/manager6/qemu/Config.js @@ -135,9 +135,7 @@

[pve-devel] enable a first group of qemu panels

This patch serie enables proper displaying of a first group of Qemu tabs. Nothing really new in this patch serie compared to the changes we already did for other panels. ___ pve-devel mailing list pve-devel@pve.proxmox.com

[pve-devel] [PATCH pve-manager 2/5] initialize Diffstore sorters and filters with empty arrays

ExtJS expect this properties to be arrays of Filters/Sorters objects, but sets them to null setting an empty array here allows to push sorters/filters easily later This fix allows loading the Hardware Tab of the Qemu Panel --- www/manager6/grid/ObjectGrid.js | 5 - 1 file changed, 4

[pve-devel] [PATCH pve-manager v3] Do not use the term 'VM' as a generic name for containers and qemu VMs

and get the Window text to display from the calling function --- change since v2: * use the same gettext string for CTs and VMs to reduce the amount of stuff to localize www/manager6/lxc/Config.js | 11 +-- www/manager6/qemu/Config.js| 10 --

[pve-devel] [PATCH pve-manager v2] Do not turn the strings CT and VM into separate localizable strings

According to the PO files, translators keep 'CT' and 'VM' unchanged --- change since v1: * keep CT/VM out of the gettext string, to reduce the amount of translation needed www/manager6/lxc/CmdMenu.js | 10 +- www/manager6/qemu/CmdMenu.js | 8 2 files changed, 9

<    1   2   3   4   5   6   7   8   9   >