[pve-devel] [PATCH qemu-server] Use schema default values as default values

2017-10-23 Thread Emmanuel Kasper
This fix a bug where VMs where the memory parameter was not set where reported as having 0MB instead of 512 via `qm list` Signed-off-by: Emmanuel Kasper --- PVE/QemuServer.pm | 14 +++--- 1 file changed, 11 insertions(+), 3 deletions(-) diff --git a/PVE/QemuServer.pm b/PVE

Re: [pve-devel] [PATCH manager] prevent visual flashing of button when changing element in the tree

2017-10-31 Thread Emmanuel Kasper
Acked-by: Emmanuel Kasper On 10/30/2017 03:03 PM, Dominik Csapak wrote: > when changing between elements in the tree, either the > start or shutdown buttons were visually flashing (meaning they are > enabled/disabled for a short time and change state shortly after) > > this p

[pve-devel] [PATCH manager 0/3] Fix #1523: Disable 'Max Backup' entry when not applicable

2017-10-31 Thread Emmanuel Kasper
This patch serie fixes #1523. Instead of writing for each Storage a new ViewController, I created new ViewController class to be reused. Emmanuel Kasper (3): Add Storage Controller class Fix #1523: Display the Max Backups field only if relevant Move Max Backups field below the Content Type

[pve-devel] [PATCH manager 2/3] Fix #1523: Display the Max Backups field only if relevant

2017-10-31 Thread Emmanuel Kasper
Signed-off-by: Emmanuel Kasper --- www/manager6/storage/DirEdit.js | 3 +++ www/manager6/storage/GlusterFsEdit.js | 3 +++ www/manager6/storage/NFSEdit.js | 3 +++ 3 files changed, 9 insertions(+) diff --git a/www/manager6/storage/DirEdit.js b/www/manager6/storage/DirEdit.js index

[pve-devel] [PATCH manager 3/3] Move Max Backups field below the Content Type Selector

2017-10-31 Thread Emmanuel Kasper
Since the Max Backups field is now depending of having the Content Type set to 'backup', it makes sense to group these two fields. Signed-off-by: Emmanuel Kasper --- www/manager6/storage/DirEdit.js | 22 +++--- www/manager6/storage/GlusterFsEd

[pve-devel] [PATCH manager 1/3] Add Storage Controller class

2017-10-31 Thread Emmanuel Kasper
This controller will display the 'Max Backups' field only if the storage can hold backups. Signed-off-by: Emmanuel Kasper --- www/manager6/Makefile | 1 + www/manager6/controller/StorageEdit.js | 18 ++ 2 files changed, 19 insertions(+) create mode

Re: [pve-devel] [PATCH manager 3/3] Move Max Backups field below the Content Type Selector

2017-10-31 Thread Emmanuel Kasper
On 10/31/2017 02:06 PM, Dominik Csapak wrote: > In general, i am in favor of keeping the order as it is (to avoid > confusion), but i get why this could be more logical > > i am not opposed to this though (maybe someone else has a stronger > opinion?) > since the behaviour of the field is changed

[pve-devel] [PATCH manager v2 0/3] Fix #1523: Disable 'Max Backup' entry when not applicable

2017-10-31 Thread Emmanuel Kasper
changes since V1: * remove wrong whitespace in DirEdit.js * reset Max Backups value before disabling it in StorageEdit.js Emmanuel Kasper (3): Add Storage Controller class Fix #1523: Display the Max Backups field only if relevant Move Max Backups field below the Content Type Selector

[pve-devel] [PATCH manager v2 2/3] Fix #1523: Display the Max Backups field only if relevant

2017-10-31 Thread Emmanuel Kasper
Signed-off-by: Emmanuel Kasper --- www/manager6/storage/DirEdit.js | 3 +++ www/manager6/storage/GlusterFsEdit.js | 3 +++ www/manager6/storage/NFSEdit.js | 3 +++ 3 files changed, 9 insertions(+) diff --git a/www/manager6/storage/DirEdit.js b/www/manager6/storage/DirEdit.js index

[pve-devel] [PATCH manager v2 1/3] Add Storage Controller class

2017-10-31 Thread Emmanuel Kasper
This controller will display the 'Max Backups' field only if the storage can hold backups. Signed-off-by: Emmanuel Kasper --- www/manager6/Makefile | 1 + www/manager6/controller/StorageEdit.js | 18 ++ 2 files changed, 19 insertions(+) create mode

[pve-devel] [PATCH manager v2 3/3] Move Max Backups field below the Content Type Selector

2017-10-31 Thread Emmanuel Kasper
Since the Max Backups field is now depending of having the Content Type set to 'backup', it makes sense to group these two fields. Signed-off-by: Emmanuel Kasper --- www/manager6/storage/DirEdit.js | 22 +++--- www/manager6/storage/GlusterFsEd

[pve-devel] [PATCH docs 2/2] Create a 10 gibibytes diskimage instead of 10 gigabytes

2017-11-08 Thread Emmanuel Kasper
Otherwise the disk import may fail on block storages requiring volumes size to be a multiple of the block size, like ZFS. This fixes the error: 'volume size must be a multiple of volume block size' when importing the generated disk image as a zvol. Signed-off-by: Emmanuel Kasper --

[pve-devel] [PATCH docs 1/2] Fix formatting failure

2017-11-08 Thread Emmanuel Kasper
Signed-off-by: Emmanuel Kasper --- pct.adoc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pct.adoc b/pct.adoc index 7a7bcc6..c509308 100644 --- a/pct.adoc +++ b/pct.adoc @@ -325,7 +325,7 @@ Backup of Containers mount points By default additional mount points besides the

[pve-devel] [PATCH manager 1/6] Do not translate Ceph specific terms

2017-11-08 Thread Emmanuel Kasper
Signed-off-by: Emmanuel Kasper --- www/manager6/ceph/StatusDetail.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/www/manager6/ceph/StatusDetail.js b/www/manager6/ceph/StatusDetail.js index 5373e2d5..7625b366 100644 --- a/www/manager6/ceph/StatusDetail.js +++ b/www

[pve-devel] [PATCH manager 0/6] Do not add useless gettext entries to translate

2017-11-08 Thread Emmanuel Kasper
? I split the removals in multiple patch so that the committer can apply / reject the removals individually. Emmanuel Kasper (6): Do not translate Ceph specific terms Do not translate PC hardware specific terms Do not translate IT specific terms Do not translate Qemu specific terms D

[pve-devel] [PATCH manager 3/6] Do not translate IT specific terms

2017-11-08 Thread Emmanuel Kasper
Signed-off-by: Emmanuel Kasper --- www/manager6/grid/Replication.js | 2 +- www/manager6/lxc/Network.js | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/www/manager6/grid/Replication.js b/www/manager6/grid/Replication.js index 2c8f3cf9..654a8368 100644 --- a/www

[pve-devel] [PATCH manager 2/6] Do not translate PC hardware specific terms

2017-11-08 Thread Emmanuel Kasper
Signed-off-by: Emmanuel Kasper --- www/manager6/form/HotplugFeatureSelector.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/www/manager6/form/HotplugFeatureSelector.js b/www/manager6/form/HotplugFeatureSelector.js index 71187cf6..cb373b69 100644 --- a/www/manager6/form

[pve-devel] [PATCH manager 6/6] Do not translate Unix/Linux specific terms

2017-11-08 Thread Emmanuel Kasper
Signed-off-by: Emmanuel Kasper --- www/manager6/lxc/ResourceEdit.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/www/manager6/lxc/ResourceEdit.js b/www/manager6/lxc/ResourceEdit.js index 9770de8d..48e5b57a 100644 --- a/www/manager6/lxc/ResourceEdit.js +++ b/www/manager6

[pve-devel] [PATCH manager 4/6] Do not translate Qemu specific terms

2017-11-08 Thread Emmanuel Kasper
Multiqueue is the proper name as used by Qemu, as seen in https://www.linux-kvm.org/page/Multiqueue Signed-off-by: Emmanuel Kasper --- www/manager6/qemu/HDEdit.js | 2 +- www/manager6/qemu/NetworkEdit.js | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/www/manager6

[pve-devel] [PATCH manager 5/6] Do not translate PC hardware specific terms

2017-11-08 Thread Emmanuel Kasper
The SKU (Stock Keeping Unit) field was never translated anyway in our po files, probably because nobody knew what the initials meant. Signed-off-by: Emmanuel Kasper --- www/manager6/qemu/Smbios1Edit.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/www/manager6/qemu

[pve-devel] Call to translaters: Proxmox VE has new features and need your translations !

2017-11-09 Thread Emmanuel Kasper
Dear Pve Translators (and dear future PVE translators) ! We always add new features to the PVE gui like Storage Replication, Ceph Dashboard, but unfortunately the translations tend to lag behind for many languages, resulting in a mix of English and Locale language when a different language is sele

Re: [pve-devel] Call to translaters: Proxmox VE has new features and need your translations !

2017-11-09 Thread Emmanuel Kasper
On 11/09/2017 03:00 PM, Jostein Hove-Henriksen wrote: > I've updated the Norwegian bokmål (nb) and Norwegian nynorsk (nn) > translation. > > (I'll see if I can learn more about /git/ later...) Thanks Jostein, I had a look at both files, and they look good to me. Did you already sign our Contribut

[pve-devel] [PATCH manager 1/3] Fix JSLint type confusion warnings

2017-11-13 Thread Emmanuel Kasper
The type confusion warnings arose from string and integer concatenation, and object properties of the name which were alternatively set with strings or intergers. Signed-off-by: Emmanuel Kasper --- www/manager6/qemu/HardwareView.js | 29 ++--- 1 file changed, 14

[pve-devel] [PATCH manager 2/3] Fix #1526: Use 'detach' instead of 'remove' when the disk is used

2017-11-13 Thread Emmanuel Kasper
Signed-off-by: Emmanuel Kasper --- www/manager6/qemu/HardwareView.js | 25 - 1 file changed, 20 insertions(+), 5 deletions(-) diff --git a/www/manager6/qemu/HardwareView.js b/www/manager6/qemu/HardwareView.js index 43337c36..3b0f00f6 100644 --- a/www/manager6/qemu

[pve-devel] [PATCH manager 3/3] Add a proper confirmation message when we detach an used disk

2017-11-13 Thread Emmanuel Kasper
Signed-off-by: Emmanuel Kasper --- www/manager6/qemu/HardwareView.js | 13 ++--- 1 file changed, 10 insertions(+), 3 deletions(-) diff --git a/www/manager6/qemu/HardwareView.js b/www/manager6/qemu/HardwareView.js index 3b0f00f6..605958e1 100644 --- a/www/manager6/qemu/HardwareView.js

[pve-devel] [PATCH manager 0/3] Change 'remove' to 'detach' when removing an used disk

2017-11-13 Thread Emmanuel Kasper
A fix for #1526 Emmanuel Kasper (3): Fix JSLint type confusion warnings Fix #1526: Use 'detach' instead of 'remove' when the disk is used Add a proper confirmation message when we detach an used disk www/manager6/qemu/HardwareView.js | 67 +--

Re: [pve-devel] [PATCH manager] buildsys: add excludes to dh_fixperms

2017-11-13 Thread Emmanuel Kasper
Tested-By: Emmanuel Kasper Acked-By: Emmanuel Kasper On 11/13/2017 10:37 AM, Wolfgang Bumiller wrote: > Instead of fixing up permissions manually as the make > install target is actually responsible for this (and already > doing it). > > Signed-off-by: Wolfgang Bumiller > -

[pve-devel] [PATCH manager v2 1/3] Fix JSLint type confusion warnings

2017-11-15 Thread Emmanuel Kasper
The type confusion warnings arose from string and integer concatenation, and object properties of the name which were alternatively set with strings and integers. Signed-off-by: Emmanuel Kasper --- www/manager6/qemu/HardwareView.js | 29 ++--- 1 file changed, 14

[pve-devel] [PATCH manager v2 0/3] Introduce 'Detach' text for used disks

2017-11-15 Thread Emmanuel Kasper
change since V2: * do not call gettext twice on the same string * use 'render' event instead of 'boxready' when computing an optimal box size Emmanuel Kasper (3): Fix JSLint type confusion warnings Fix #1526: Use 'detach' instead of 'remove&#x

[pve-devel] [PATCH manager v2 2/3] Fix #1526: Use 'detach' instead of 'remove' when the disk is used

2017-11-15 Thread Emmanuel Kasper
Signed-off-by: Emmanuel Kasper --- www/manager6/qemu/HardwareView.js | 28 +++- 1 file changed, 23 insertions(+), 5 deletions(-) diff --git a/www/manager6/qemu/HardwareView.js b/www/manager6/qemu/HardwareView.js index 43337c36..2cd0c940 100644 --- a/www/manager6/qemu

[pve-devel] [PATCH manager v2 3/3] Add a proper confirmation message when we detach an used disk

2017-11-15 Thread Emmanuel Kasper
Signed-off-by: Emmanuel Kasper --- www/manager6/qemu/HardwareView.js | 13 ++--- 1 file changed, 10 insertions(+), 3 deletions(-) diff --git a/www/manager6/qemu/HardwareView.js b/www/manager6/qemu/HardwareView.js index 2cd0c940..e6bc0231 100644 --- a/www/manager6/qemu/HardwareView.js

Re: [pve-devel] [PATCH qemu-server] Use schema default values as default values

2017-11-15 Thread Emmanuel Kasper
Any feedback on this ? On 10/23/2017 10:45 AM, Emmanuel Kasper wrote: > This fix a bug where VMs where the memory parameter was not > set where reported as having 0MB instead of 512 via `qm list` > > Signed-off-by: Emmanuel Kasper > --- > PVE/QemuServer.pm | 14 +++---

[pve-devel] [PATCH docs] Fix vzdump backup stop mode description

2017-11-21 Thread Emmanuel Kasper
The VM goes to normal operation after the backup is started, not at end of backup. Signed-off-by: Emmanuel Kasper --- vzdump.adoc | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/vzdump.adoc b/vzdump.adoc index 7643ec6..d354732 100644 --- a/vzdump.adoc +++ b

Re: [pve-devel] [PATCH docs] Fix vzdump backup stop mode description

2017-11-21 Thread Emmanuel Kasper
On 11/21/2017 12:26 PM, Dietmar Maurer wrote: > IMHO it is still not clear that this provides snapshot semantics ... > (snapshot of the stopped VM). Actually, a note a bit below the backup modes actually mention that :) But we were still missing an explanation on the VM apparently running when a st

[pve-devel] [PATCH docs v2 3/3] Explain why shut down VMs appear as running when backed up

2017-11-21 Thread Emmanuel Kasper
Signed-off-by: Emmanuel Kasper --- vzdump.adoc | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/vzdump.adoc b/vzdump.adoc index babf407..da8ea19 100644 --- a/vzdump.adoc +++ b/vzdump.adoc @@ -89,7 +89,10 @@ https://git.proxmox.com/?p=pve-qemu.git;a=blob_plain;f=backup.txt

[pve-devel] [PATCH docs v2 1/3] Fix vzdump backup stop mode description

2017-11-21 Thread Emmanuel Kasper
The VM goes to normal operation after the backup is started, not at end of backup. Signed-off-by: Emmanuel Kasper --- vzdump.adoc | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/vzdump.adoc b/vzdump.adoc index 7643ec6..f21a75f 100644 --- a/vzdump.adoc +++ b/vzdump.adoc

[pve-devel] [PATCH docs v2 2/3] Update path to Backup.txt in new git repo

2017-11-21 Thread Emmanuel Kasper
Signed-off-by: Emmanuel Kasper --- vzdump.adoc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/vzdump.adoc b/vzdump.adoc index f21a75f..babf407 100644 --- a/vzdump.adoc +++ b/vzdump.adoc @@ -85,7 +85,7 @@ consistency. A technical overview of the Proxmox VE live backup for

[pve-devel] [PATCH cluster 2/2] Add utility method to get a SSL finger print from a nodename

2017-11-22 Thread Emmanuel Kasper
This will be used to feed an extra field for an API call Signed-off-by: Emmanuel Kasper --- data/PVE/Cluster.pm | 6 ++ 1 file changed, 6 insertions(+) diff --git a/data/PVE/Cluster.pm b/data/PVE/Cluster.pm index 5d69f0c..051e815 100644 --- a/data/PVE/Cluster.pm +++ b/data/PVE/Cluster.pm

[pve-devel] [PATCH cluster 0/2] Prepare SSL finger information via API call

2017-11-22 Thread Emmanuel Kasper
simply disabling SSL host verification when addressing hosts with self signed certificates * on the long term, provide the info necessary to build a cluster using only API calls Emmanuel Kasper (2): Refactor host fingerprint calculation in two extra subs Add utility method to get a SSL finger

[pve-devel] [PATCH cluster 1/2] Refactor host fingerprint calculation in two extra subs

2017-11-22 Thread Emmanuel Kasper
This will be used later for feeding an extra API call Signed-off-by: Emmanuel Kasper --- data/PVE/Cluster.pm | 51 --- 1 file changed, 40 insertions(+), 11 deletions(-) diff --git a/data/PVE/Cluster.pm b/data/PVE/Cluster.pm index fef5842..5d69f0c

[pve-devel] [PATCH manager] Add each host SSL fingerprint to each node status

2017-11-22 Thread Emmanuel Kasper
Signed-off-by: Emmanuel Kasper --- PVE/API2/Nodes.pm | 1 + 1 file changed, 1 insertion(+) diff --git a/PVE/API2/Nodes.pm b/PVE/API2/Nodes.pm index b7210d4d..15437dc9 100644 --- a/PVE/API2/Nodes.pm +++ b/PVE/API2/Nodes.pm @@ -1746,6 +1746,7 @@ __PACKAGE__->register_method ({ fore

Re: [pve-devel] XenServer to Proxmox in a single step

2017-11-28 Thread Emmanuel Kasper
On 11/23/2017 02:22 PM, Gandalf Corvotempesta wrote: > Here you are: > > https://pastebin.com/raw/4E6rTuqe For discoverability I would advise you to post this too on one of the free git hosting services. ___ pve-devel mailing list pve-devel@pve.proxmo

[pve-devel] [PATCH manager v3 1/3] Fix JSLint type confusion warnings

2017-12-01 Thread Emmanuel Kasper
The type confusion warnings arose from string and integer concatenation, and object properties of the name which were alternatively set with strings and integers. Signed-off-by: Emmanuel Kasper --- www/manager6/qemu/HardwareView.js | 29 ++--- 1 file changed, 14

[pve-devel] [PATCH manager v3 0/3] Introduce Detach Button for used disks

2017-12-01 Thread Emmanuel Kasper
ave the optimal size as a button property Emmanuel Kasper (3): Fix JSLint type confusion warnings Fix #1526: Use 'detach' instead of 'remove' when the disk is used Add a proper confirmation message when we detach an used disk www/manager6/qemu/HardwareView.js | 70 +++

[pve-devel] [PATCH manager v3 2/3] Fix #1526: Use 'detach' instead of 'remove' when the disk is used

2017-12-01 Thread Emmanuel Kasper
Signed-off-by: Emmanuel Kasper --- www/manager6/qemu/HardwareView.js | 28 +++- 1 file changed, 23 insertions(+), 5 deletions(-) diff --git a/www/manager6/qemu/HardwareView.js b/www/manager6/qemu/HardwareView.js index 43337c36..bc22cc98 100644 --- a/www/manager6/qemu

[pve-devel] [PATCH manager v3 3/3] Add a proper confirmation message when we detach an used disk

2017-12-01 Thread Emmanuel Kasper
Signed-off-by: Emmanuel Kasper --- www/manager6/qemu/HardwareView.js | 13 ++--- 1 file changed, 10 insertions(+), 3 deletions(-) diff --git a/www/manager6/qemu/HardwareView.js b/www/manager6/qemu/HardwareView.js index bc22cc98..112410c2 100644 --- a/www/manager6/qemu/HardwareView.js

[pve-devel] [RFC PATCH] Explain that concurrent modifications of the VM config are the error cause

2017-12-11 Thread Emmanuel Kasper
Signed-off-by: Emmanuel Kasper --- While doing PVE trainings last week, I noticed that this error message was not clear to most people when it popped up on the GUI. Reusing here the wording that apt uses when called multiple times ( Unable to lock the administration directory (/var/lib/dpkg

[pve-devel] [PATCH qemu-server v3] Use default values from load_defaults() when none is specified in conf

2017-12-12 Thread Emmanuel Kasper
This also fixes a bug where VMs with no memory defined in the config where reported as using 0MB instead of 512. Signed-off-by: Emmanuel Kasper --- changes since V1: use load_defaults() instead of $confdesc for consistency with the rest of the codebase PVE/QemuServer.pm | 11 --- 1

Re: [pve-devel] [PATCH qemu-server] Use schema default values as default values

2017-12-12 Thread Emmanuel Kasper
On 11/20/2017 02:38 PM, Fabian Grünbichler wrote: > On Wed, Nov 15, 2017 at 11:58:29AM +0100, Emmanuel Kasper wrote: >> Any feedback on this ? > > there already is a "load_defaults" in QemuServer.pm, I'd re-use that. > what about options with default values besid

[pve-devel] [PATCH pve-container 1/2] Test for arguments at beginning of 'pct exec'

2017-12-13 Thread Emmanuel Kasper
Also derefence the given parameters once, for readability Signed-off-by: Emmanuel Kasper --- src/PVE/CLI/pct.pm | 11 ++- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/src/PVE/CLI/pct.pm b/src/PVE/CLI/pct.pm index 05fcb29..1818551 100755 --- a/src/PVE/CLI/pct.pm +++ b

[pve-devel] [PATCH pve-container 2/2] Return proper error message when CT is not running for pct exec

2017-12-13 Thread Emmanuel Kasper
instead of the uglier lx-attach: : attach.c: lxc_attach: 794 Failed to attach and multiple tabs Signed-off-by: Emmanuel Kasper --- src/PVE/CLI/pct.pm | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/PVE/CLI/pct.pm b/src/PVE/CLI/pct.pm index 1818551..d44ed6c 100755 --- a/src/PVE/CLI

Re: [pve-devel] [PATCH docs v2 2/3] Update path to Backup.txt in new git repo

2017-12-13 Thread Emmanuel Kasper
Any feedback on this and serie ? I clicked again on that old link while doing a PVE training ... On 11/21/2017 04:58 PM, Emmanuel Kasper wrote: > Signed-off-by: Emmanuel Kasper > --- > vzdump.adoc | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --g

Re: [pve-devel] PVE Minimal Debian Appliance

2017-12-18 Thread Emmanuel Kasper
On 12/18/2017 12:09 AM, c.mo...@web.de wrote: > Hello! > > Can you consider to provide a PVE Minimal Debian Appliance considering > things like > "Removing Packages for dealing with hardware. This is not usually done > within a container" und "Removing Packages for interactive use." BTW, the Bitn

[pve-devel] [PATCH manager 2/2] Set ZFS over ISCSI window to proper title

2017-12-18 Thread Emmanuel Kasper
This will now Display 'ZFS over iSCSI'. This was reported by users during a Proxmox Training. Signed-off-by: Emmanuel Kasper --- NB: Strings returned by format_storage_type() are not gettext'ed. This is fine, as nobody should try to translate 'LVM-thin' or 'ZFS ove

[pve-devel] [PATCH manager 1/2] Fix Indentation to use Proxmox style

2017-12-18 Thread Emmanuel Kasper
Signed-off-by: Emmanuel Kasper --- www/manager6/storage/ZFSEdit.js | 38 +++--- 1 file changed, 19 insertions(+), 19 deletions(-) diff --git a/www/manager6/storage/ZFSEdit.js b/www/manager6/storage/ZFSEdit.js index bc9d8baf..22f24cb2 100644 --- a/www/manager6

[pve-devel] [PATCH manager 1/4] jslint: remove trailing comma after last objects property

2017-12-19 Thread Emmanuel Kasper
Signed-off-by: Emmanuel Kasper --- www/manager6/button/ConsoleButton.js | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/www/manager6/button/ConsoleButton.js b/www/manager6/button/ConsoleButton.js index a3bf7464..1392c555 100644 --- a/www/manager6/button

[pve-devel] [PATCH manager 2/4] Add new icon for xtermjs consoles, based on xtermjs logo

2017-12-19 Thread Emmanuel Kasper
Signed-off-by: Emmanuel Kasper --- www/images/Makefile| 4 www/images/xtermjs.png | Bin 0 -> 729 bytes 2 files changed, 4 insertions(+) create mode 100644 www/images/xtermjs.png diff --git a/www/images/Makefile b/www/images/Makefile index c76d7aee..798132a7 100644 --- a/www/ima

[pve-devel] [PATCH manager 4/4] Set Console Button icon style at definition time

2017-12-19 Thread Emmanuel Kasper
This will allow the 'Upgrade' button to get an icon too. Signed-off-by: Emmanuel Kasper --- www/manager6/button/ConsoleButton.js | 2 ++ www/manager6/lxc/Config.js | 3 +-- www/manager6/node/Config.js | 3 +-- www/manager6/qemu/Config.js | 3 +-- 4 files

[pve-devel] [PATCH manager 3/4] Use the new xterm.js icon with the corresponding Menu Item

2017-12-19 Thread Emmanuel Kasper
Signed-off-by: Emmanuel Kasper --- www/css/ext6-pve.css | 6 ++ www/manager6/button/ConsoleButton.js | 2 +- 2 files changed, 7 insertions(+), 1 deletion(-) diff --git a/www/css/ext6-pve.css b/www/css/ext6-pve.css index c8fabd6f..2c6de752 100644 --- a/www/css/ext6-pve.css

[pve-devel] [PATCH manager] Allow change of Datacenter wide default console without browser refresh

2017-12-19 Thread Emmanuel Kasper
The previous implementation was relying on PVE.VersionInfo.console, which is set after login and never refreshed after that. We execute the API call before setting the button handler, otherwise the browser would fire its popup blocker Signed-off-by: Emmanuel Kasper --- www/manager6/Utils.js

[pve-devel] [PATCH manager] Update french translation

2017-12-20 Thread Emmanuel Kasper
Signed-off-by: Emmanuel Kasper --- po/fr.po | 369 ++- 1 file changed, 153 insertions(+), 216 deletions(-) diff --git a/po/fr.po b/po/fr.po index 48e03045..b55a8f32 100644 --- a/po/fr.po +++ b/po/fr.po @@ -8,7 +8,7 @@ msgstr

[pve-devel] [PATCH pve-manager] SafeDestroy.js: allow to submit the form with Enter key

2016-03-31 Thread Emmanuel Kasper
also set focus on the confirm field of the Destroy Window on display --- www/manager6/window/SafeDestroy.js | 13 - 1 file changed, 12 insertions(+), 1 deletion(-) diff --git a/www/manager6/window/SafeDestroy.js b/www/manager6/window/SafeDestroy.js index ec4a2f5..fea9594 100644 --- a

[pve-devel] [PATCH pve-manager] Readme.md: add pveproxy restart as neeed step for testing ExtJS6 GUI

2016-03-31 Thread Emmanuel Kasper
--- www/manager6/Readme.md | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/www/manager6/Readme.md b/www/manager6/Readme.md index 81c3b26..e59c6aa 100644 --- a/www/manager6/Readme.md +++ b/www/manager6/Readme.md @@ -11,6 +11,10 @@ symlink the ext6 dir in pve-manager to the

[pve-devel] [PATCH pve-manager] Fix ExtJS6 locales file name

2016-03-31 Thread Emmanuel Kasper
--- PVE/ExtJSIndex.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/PVE/ExtJSIndex.pm b/PVE/ExtJSIndex.pm index 90c6ddd..4dcf454 100644 --- a/PVE/ExtJSIndex.pm +++ b/PVE/ExtJSIndex.pm @@ -29,7 +29,7 @@ _EOD - + _EOD my $jssrc = <<_EOJS; -- 2

Re: [pve-devel] [PATCH pve-manager] SafeDestroy.js: allow to submit the form with Enter key

2016-04-04 Thread Emmanuel Kasper
On 03/31/2016 10:29 AM, Dietmar Maurer wrote: > >> @@ -102,7 +108,12 @@ Ext.define('PVE.window.SafeDestroy', { >> fieldLabel: gettext('Please enter the {item.type} ID to >> confirm'), >> }, >> hideTrigger: true, >> -allowBlank

[pve-devel] [PATCH pve-manager v2] SafeDestroy.js: allow to submit the form with Enter key

2016-04-04 Thread Emmanuel Kasper
also set focus on the confirm field of the Destroy Window on display --- www/manager6/window/SafeDestroy.js | 8 1 file changed, 8 insertions(+) diff --git a/www/manager6/window/SafeDestroy.js b/www/manager6/window/SafeDestroy.js index ec4a2f5..047c48b 100644 --- a/www/manager6/window/S

[pve-devel] [PATCH pve-manager] Use Ext.apply instead of applyIf when loading a task window

2016-04-04 Thread Emmanuel Kasper
Without this the window title is not displayed --- www/manager6/window/TaskViewer.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/www/manager6/window/TaskViewer.js b/www/manager6/window/TaskViewer.js index c3cea39..0750ffd 100644 --- a/www/manager6/window/TaskViewer.js +++

[pve-devel] [PATCH pve-manager] Update French po files

2016-04-05 Thread Emmanuel Kasper
+8,15 @@ msgstr "" "Project-Id-Version: pve-manager 2.0\n" "Report-Msgid-Bugs-To: \n" "POT-Creation-Date: Tue Apr 5 11:10:38 2016\n" -"PO-Revision-Date: 2013-10-16 11:26+0100\n" -"Last-Translator: Damien PIQUET \n" +"PO-Revision-Dat

[pve-devel] [PATCH pve-manager v2] Update French po files

2016-04-07 Thread Emmanuel Kasper
+8,15 @@ msgstr "" "Project-Id-Version: pve-manager 2.0\n" "Report-Msgid-Bugs-To: \n" "POT-Creation-Date: Tue Apr 5 11:10:38 2016\n" -"PO-Revision-Date: 2013-10-16 11:26+0100\n" -"Last-Translator: Damien PIQUET \n" +"PO-Revision-Dat

[pve-devel] [PATCH pve-manager] Overrides Ext.Msg.alert() to always display an Error Icon

2016-04-07 Thread Emmanuel Kasper
--- www/manager6/Toolkit.js | 22 ++ 1 file changed, 22 insertions(+) diff --git a/www/manager6/Toolkit.js b/www/manager6/Toolkit.js index 91a4fa6..a8089aa 100644 --- a/www/manager6/Toolkit.js +++ b/www/manager6/Toolkit.js @@ -137,6 +137,28 @@ Ext.define('PVE.Datepicker', {

[pve-devel] [PATCH pve-manager v3] Update French po files

2016-04-11 Thread Emmanuel Kasper
+8,15 @@ msgstr "" "Project-Id-Version: pve-manager 2.0\n" "Report-Msgid-Bugs-To: \n" "POT-Creation-Date: Tue Apr 5 11:10:38 2016\n" -"PO-Revision-Date: 2013-10-16 11:26+0100\n" -"Last-Translator: Damien PIQUET \n" +"PO-Revision-Dat

[pve-devel] [PATCH pve-manager 2/2] Do not disable a invalid previous tab, as this make the tab fields valid

2016-04-11 Thread Emmanuel Kasper
disable_at() iterates over all the fields of the previously selected tab and disables them however disabling an input field makes it valid for validation purposes. I can't see a reason why disabling the tab fields is needed, since the tab already hidden and after testing, it seems safe to remove t

[pve-devel] [PATCH pve-manager 1/2] Recheck field validation after manually enabling the input field of a ComboGrid

2016-04-11 Thread Emmanuel Kasper
Calling setDisabled(true) on a component makes it valid, but calling setDisabled(false) afterwards did not retrigger a validation check This fixes a serious bug which was happening in the following conditions, for instance in the template tab of LXC Wizard: 1) user selects a storage 2) this trigg

Re: [pve-devel] [PATCH manager] www: monitor: support page up/down, home/end

2016-04-11 Thread Emmanuel Kasper
On 04/11/2016 02:28 PM, Wolfgang Bumiller wrote: > Actually... the home/end key part might annoy some people... > Thoughts? Disclaimer: I rarely use the Monitor in the GUI. But yes people would expect HOME and END to interact within the input field, not with other stuff on the display, so it's b

[pve-devel] [PATCH pve-docs] Add subchapter about ACLs, and make even more clear what quotas are about

2016-04-11 Thread Emmanuel Kasper
Some users thinks quotas relate to the amount of diskspace used for the mountpoint as the whole. --- pct.adoc | 11 +++ 1 file changed, 11 insertions(+) diff --git a/pct.adoc b/pct.adoc index 82f257b..cd817dd 100644 --- a/pct.adoc +++ b/pct.adoc @@ -401,6 +401,8 @@ Similarly device mounts

Re: [pve-devel] [PATCH pve-docs] Add subchapter about ACLs, and make even more clear what quotas are about

2016-04-12 Thread Emmanuel Kasper
On 04/11/2016 05:28 PM, Dietmar Maurer wrote: >> +Please be aware that NFS do not store ACLs, so if you plan to do snapshots >> and >> +restores from a container to a NFS storage, it is advised to disable ACLs >> +in the options of your container mountpoint to avoid bad surprises later. > > Isn't

[pve-devel] Generic term to cover VMs and containers in the documentation

2016-04-12 Thread Emmanuel Kasper
Hi While reading the vzdump documentation, I notice that we use there the term VM to describe both containers and qemu based virtualized systems. For instance: 'vzdump' is a utility to make consistent snapshots of running virtual machines (VMs). It basically creates an archive of the VM private

[pve-devel] [PATCH pve-docs v2] Add subchapter about ACLs, and make even more clear what quotas are about

2016-04-12 Thread Emmanuel Kasper
Document that use of a tmpdir is recommended when doing a 'suspend' backup to a NFS share. --- changes since v1: * move NFS related hints to vzdump documentation, recommend tmpdir * reword quota description pct.adoc| 8 vzdump.adoc | 14 ++ 2 files changed, 18 insertio

Re: [pve-devel] Generic term to cover VMs and containers in the documentation

2016-04-13 Thread Emmanuel Kasper
On 04/12/2016 02:09 PM, Fabian Grünbichler wrote: >> Emmanuel Kasper hat am 12. April 2016 um 13:55 >> geschrieben: >> What would be a good term to cover both of these ? >> >> I am thinking of either 'machine' or 'virtualized system'. &

[pve-devel] [PATCH pve-docs] Replace VM occurences with 'guest' or 'container' when appropriate

2016-04-13 Thread Emmanuel Kasper
also replace Qemu/KVM with QemuServer as it is the detailed term used in the vzdump man page --- vzdump.adoc | 20 ++-- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/vzdump.adoc b/vzdump.adoc index fc42468..b8794d9 100644 --- a/vzdump.adoc +++ b/vzdump.adoc @@ -25

[pve-devel] [PATCH tar 5/5] Reenable upload target

2016-04-18 Thread Emmanuel Kasper
--- Makefile | 2 -- 1 file changed, 2 deletions(-) diff --git a/Makefile b/Makefile index 2b9f655..c5ca59b 100644 --- a/Makefile +++ b/Makefile @@ -37,8 +37,6 @@ deb ${DEB}: ${TARSRC} .PHONY: upload upload: - # this is no longer required - false umount /pve/${RELEASE}; m

[pve-devel] [PATCH tar 4/5] Add readme explaining the backport

2016-04-18 Thread Emmanuel Kasper
--- README.adoc | 32 1 file changed, 32 insertions(+) create mode 100644 README.adoc diff --git a/README.adoc b/README.adoc new file mode 100644 index 000..62b06e5 --- /dev/null +++ b/README.adoc @@ -0,0 +1,32 @@ +PVE backport of tar +~~~ + +

[pve-devel] [PATCH tar 3/5] Remove fix-sparse-archive patches

2016-04-18 Thread Emmanuel Kasper
This was fixed in tar 1.27.1 --- Makefile | 1 - README| 7 --- fix-sparse-archives.patch | 18 -- 3 files changed, 26 deletions(-) delete mode 100644 README delete mode 100644 fix-sparse-archives.patch diff --git a/Makefile b/Makefile

[pve-devel] Backport of Debian Strech tar 1.28 in the pve archive

2016-04-18 Thread Emmanuel Kasper
Hi This patch serie updates creates a backport from the tar package 1.28 from Debian Stretch. It fixes the following bug https://bugzilla.proxmox.com/show_bug.cgi?id=928 ( creating a container from a template or restoring from a backup would create unwanted default acls ) The version string for th

[pve-devel] [PATCH tar 2/5] Don't pass the '--print-directory' MAKEFLAGS to debian/rules

2016-04-18 Thread Emmanuel Kasper
Calling a sub Makefile from a top Makefile causes make to pass a default 'w' flag aka print-directory. However debian/rules in tar packages use these inherited MAKEFLAGS without prepending a dash, causing the 'w' string to be interpreted as a target. The error is then as such: RSH="/usr/bin/rsh"

[pve-devel] [PATCH tar 1/5] rebuild our tar package by doing a backport from Debian Stretch

2016-04-18 Thread Emmanuel Kasper
changelog entries from our previous packages are dropped, as they would break the changelog version ordering ( ie we would have debian entries for 1.28, then our old own entries for 1.27, then our own entries for 1.28) --- Makefile | 6 +++--- changelog | 21 + 2 files change

Re: [pve-devel] Backport of Debian Strech tar 1.28 in the pve archive

2016-04-18 Thread Emmanuel Kasper
> > The problem seems to be with dpkg-deb and was fixed it upstream at: > https://anonscm.debian.org/cgit/dpkg/dpkg.git/commit/?id=fcfe4f3aa2f3cb7f8179d4f2fe6dd65e75f7bbdf > > So the back port of tar will also need dpkg fix(es) and is problematic. The problem is the hard coded position of the ta

[pve-devel] fix acl for tar 1.27.1

2016-04-19 Thread Emmanuel Kasper
Since the backport of tar 1.28 breaks dpkg-deb, we cherry pick the ACL bugfix patch from upstream to tar 1.27.1 The patch applies cleanly and works as expected. ___ pve-devel mailing list pve-devel@pve.proxmox.com http://pve.proxmox.com/cgi-bin/mailman

[pve-devel] [PATCH tar v2 2/5] Add acls-bugfix patch for PVE Bug 928

2016-04-19 Thread Emmanuel Kasper
--- Makefile | 1 + acls-bugfix.patch | 109 ++ 2 files changed, 110 insertions(+) create mode 100644 acls-bugfix.patch diff --git a/Makefile b/Makefile index 3ed2e94..8062c1c 100644 --- a/Makefile +++ b/Makefile @@ -33,6 +33,7 @@ de

[pve-devel] [PATCH tar v2 4/5] reenable upload

2016-04-19 Thread Emmanuel Kasper
--- Makefile | 2 -- 1 file changed, 2 deletions(-) diff --git a/Makefile b/Makefile index edee266..ade5611 100644 --- a/Makefile +++ b/Makefile @@ -38,8 +38,6 @@ deb ${DEB}: ${TARSRC} .PHONY: upload upload: - # this is no longer required - false umount /pve/${RELEASE}; m

[pve-devel] [PATCH tar v2 1/5] Remove fix-sparse-archives.patch

2016-04-19 Thread Emmanuel Kasper
the issue is fixed in tar-1.27.1 --- Makefile | 1 - fix-sparse-archives.patch | 18 -- 2 files changed, 19 deletions(-) delete mode 100644 fix-sparse-archives.patch diff --git a/Makefile b/Makefile index 64aa3ed..3ed2e94 100644 --- a/Makefile +++ b/Makefile @@

[pve-devel] [PATCH tar v2 3/5] Update version and changelog for 1.27.1+pve.3

2016-04-19 Thread Emmanuel Kasper
--- Makefile | 4 ++-- changelog | 8 2 files changed, 10 insertions(+), 2 deletions(-) diff --git a/Makefile b/Makefile index 8062c1c..edee266 100644 --- a/Makefile +++ b/Makefile @@ -1,10 +1,10 @@ -RELEASE=4.0 +RELEASE=4.1 # Note: compile as root fail, so you need to do that as unp

[pve-devel] [PATCH tar v2 5/5] Update README

2016-04-19 Thread Emmanuel Kasper
--- README | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/README b/README index 6b00738..e5f2dfd 100644 --- a/README +++ b/README @@ -1,7 +1,5 @@ We recompile tar ourselfs to fix bug: -https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=737226 +https://bugs.debian.org/c

[pve-devel] RFC: move logout button to the top right corner of the GUI

2016-04-19 Thread Emmanuel Kasper
Hi Since we changed quite a lot of things in the GUI in this cycle, I would like to propose to move the logout button to the top right corner of the workspace GUI. The most popular websites where people have an account follow this convention ( Facebook, Gmail, Github ) so it makes the GUI more fa

[pve-devel] [PATCH pve-manager] Move logout button to the top right corner of the workspace

2016-04-19 Thread Emmanuel Kasper
This makes us similar to 90% of sites and thus make the interface more familiar to new users. --- www/manager6/Workspace.js | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/www/manager6/Workspace.js b/www/manager6/Workspace.js index 771e067..685b909 100644 --- a/www/manage

[pve-devel] [PATCH pve-manager 1/3] Make clear what is the value of setting 'Default' for ACLs

2016-04-21 Thread Emmanuel Kasper
Also replace the strings On/Off with Enabled/disabled, so they get localized We have translations of 'Enabled' in nearly all languages and 'disabled' in 5 languages with unfortunately different case. --- www/manager6/lxc/ResourceEdit.js | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-)

[pve-devel] [PATCH pve-manager 3/3] Do not display the internal value we use for storing ostypes

2016-04-21 Thread Emmanuel Kasper
Strings like 'Linux 4.X/3.X/2.6 Kernel' are difficult enough to visually parse, so don't append the internal representation (l26) at the end: it does not bring any relevant information to the user, and we usually don't display internal representations in the GUI. --- www/manager6/Utils.js | 2 +-

[pve-devel] Minor usability improvements

2016-04-21 Thread Emmanuel Kasper
A couple of usability fixes in the GUI ___ pve-devel mailing list pve-devel@pve.proxmox.com http://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

[pve-devel] [PATCH pve-manager 2/3] Translation update for French and Spanish 'disabled'

2016-04-21 Thread Emmanuel Kasper
-Msgid-Bugs-To: \n" "POT-Creation-Date: Tue Apr 5 11:10:38 2016\n" -"PO-Revision-Date: 2014-08-05 18:36-0400\n" -"Last-Translator: Cesar Peschiera \n" +"PO-Revision-Date: 2016-04-21 11:22+0100\n" +"Last-Translator: Emmanuel Kasper \n" "La

Re: [pve-devel] [PATCH pve-manager 2/3] Translation update for French and Spanish 'disabled'

2016-04-21 Thread Emmanuel Kasper
On 04/21/2016 02:52 PM, Alexandre DERUMIER wrote: > Hi, > > In French, it's not "déactivé", but "désactivé" You're right. Btw I wanted to ask since I read you were doing training for Proxmox VE, do people usually choose the English UI or the French UI at the training sessions ? I've noticed tha

<    1   2   3   4   5   6   7   8   9   10   >