Re: [pve-devel] [PATCH] increase zfs default timeout to 30sec

2018-04-12 Thread Fabian Grünbichler
On Tue, Apr 10, 2018 at 05:40:50PM +0300, Lauri Tirkkonen wrote: > Hi, > > On Tue, Mar 13 2018 10:25:47 +0100, Thomas Lamprecht wrote: > > What Fabian meant with: > > > [...] our API has a timeout per request, [...] > > > > is that our API already has 30 seconds as timeout for response, > > so us

[pve-devel] [PATCH kernel v2 0/2] pve-kernel helper scripts for patch-queue management

2018-04-12 Thread Fabian Grünbichler
exporting patchqueue - expand '--no-cover' to '--no-cover-letter' in export-patchqueue - 'git add' patchdir after rebasing, otherwise new patch files are not committed. Fabian Grünbichler (2): debian/scripts: add patchqueue scripts debian/scripts: add import-upstrea

[pve-devel] [PATCH kernel v2 1/2] debian/scripts: add patchqueue scripts

2018-04-12 Thread Fabian Grünbichler
Signed-off-by: Fabian Grünbichler --- debian/scripts/export-patchqueue | 33 + debian/scripts/import-patchqueue | 29 + 2 files changed, 62 insertions(+) create mode 100755 debian/scripts/export-patchqueue create mode 100755 debian

[pve-devel] [PATCH kernel v2 2/2] debian/scripts: add import-upstream-tag

2018-04-12 Thread Fabian Grünbichler
Signed-off-by: Fabian Grünbichler --- debian/scripts/import-upstream-tag | 119 + 1 file changed, 119 insertions(+) create mode 100755 debian/scripts/import-upstream-tag diff --git a/debian/scripts/import-upstream-tag b/debian/scripts/import-upstream-tag

Re: [pve-devel] [PATCH] increase zfs default timeout to 30sec

2018-04-12 Thread Fabian Grünbichler
On Thu, Apr 12, 2018 at 02:59:22PM +0300, Lauri Tirkkonen wrote: > On Thu, Apr 12 2018 12:59:13 +0200, Fabian Grünbichler wrote: > > On Tue, Apr 10, 2018 at 05:40:50PM +0300, Lauri Tirkkonen wrote: > > > Hi, > > > > > > On Tue, Mar 13 2018 10:25:47 +0100,

Re: [pve-devel] avoiding VMID reuse

2018-04-12 Thread Fabian Grünbichler
On Thu, Apr 12, 2018 at 03:12:50PM +0300, Lauri Tirkkonen wrote: > On Thu, Apr 12 2018 12:42:51 +0200, Fabian Grünbichler wrote: > > > - please send patch series as threads (cover letter and each patch as > > > separate mail) and configure the subjectprefix

[pve-devel] [PATCH corosync-pve 3/3] bump version to 2.4.2-pve4

2018-04-13 Thread Fabian Grünbichler
Signed-off-by: Fabian Grünbichler --- changelog.Debian | 6 ++ Makefile | 2 +- 2 files changed, 7 insertions(+), 1 deletion(-) diff --git a/changelog.Debian b/changelog.Debian index beefe52..974c533 100644 --- a/changelog.Debian +++ b/changelog.Debian @@ -1,3 +1,9 @@ +corosync

[pve-devel] [PATCH corosync-pve 1/3] cherry-pick CVE-2018-1084 fix

2018-04-13 Thread Fabian Grünbichler
DoS via malformed packet. Signed-off-by: Fabian Grünbichler --- ...essary-and-problematic-corosync-qdevice.i.patch | 78 ...08-totemcrypto-Check-length-of-the-packet.patch | 53 ...-totemudp-Check-lenght-of-message-to-sent.patch | 125 +++ ...-msgio-Fix

[pve-devel] [PATCH corosync-pve 2/3] reformat old patches

2018-04-13 Thread Fabian Grünbichler
to reduce future patch churn Signed-off-by: Fabian Grünbichler --- patches/0001-add-Provides-Replaces-corosync-pve.patch | 8 patches/0002-don-t-install-default-corosync.conf.patch | 10 +- patches/0003-restart-after-package-upgrade-is-complete.patch | 8

[pve-devel] [PATCH corosync-pve 0/3] fix CVE-2018-1084

2018-04-13 Thread Fabian Grünbichler
Fabian Grünbichler (3): cherry-pick CVE-2018-1084 fix reformat old patches bump version to 2.4.2-pve4 changelog.Debian | 6 + Makefile | 2 +- .../0001-add-Provides-Replaces-corosync-pve.patch | 8

[pve-devel] IGNORE: [PATCH corosync-pve 0/3] fix CVE-2018-1084

2018-04-13 Thread Fabian Grünbichler
git-send-emailed wrong branch, will resend shortly ___ pve-devel mailing list pve-devel@pve.proxmox.com https://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

[pve-devel] [PATCH v2 corosync-pve 1/3] fix CVE-2018-1084: DoS via malformed packet

2018-04-13 Thread Fabian Grünbichler
Signed-off-by: Fabian Grünbichler --- ...09-totemcrypto-Check-length-of-the-packet.patch | 53 ++ patches/series | 1 + 2 files changed, 54 insertions(+) create mode 100644 patches/0009-totemcrypto-Check-length-of-the-packet.patch diff

[pve-devel] [PATCH v2/RESEND corosync-pve 0/3] fix CVE-2018-1084

2018-04-13 Thread Fabian Grünbichler
Fabian Grünbichler (3): fix CVE-2018-1084: DoS via malformed packet reformat old patches bump version to 2.4.2-pve4 changelog.Debian | 6 +++ Makefile | 2 +- .../0001-add-Provides-Replaces-corosync-pve.patch

[pve-devel] [PATCH v2 corosync-pve 2/3] reformat old patches

2018-04-13 Thread Fabian Grünbichler
to reduce future patch churn Signed-off-by: Fabian Grünbichler --- patches/0001-add-Provides-Replaces-corosync-pve.patch | 8 patches/0002-don-t-install-default-corosync.conf.patch | 10 +- patches/0003-restart-after-package-upgrade-is-complete.patch | 8

[pve-devel] [PATCH v2 corosync-pve 3/3] bump version to 2.4.2-pve4

2018-04-13 Thread Fabian Grünbichler
Signed-off-by: Fabian Grünbichler --- changelog.Debian | 6 ++ Makefile | 2 +- 2 files changed, 7 insertions(+), 1 deletion(-) diff --git a/changelog.Debian b/changelog.Debian index beefe52..974c533 100644 --- a/changelog.Debian +++ b/changelog.Debian @@ -1,3 +1,9 @@ +corosync

[pve-devel] [PATCH corosync-pve 2/2] bump version to 2.4.2-2~pve4+2

2018-04-13 Thread Fabian Grünbichler
Signed-off-by: Fabian Grünbichler --- Makefile | 2 +- debian/changelog | 6 ++ 2 files changed, 7 insertions(+), 1 deletion(-) diff --git a/Makefile b/Makefile index 7308f90..a80e9dd 100644 --- a/Makefile +++ b/Makefile @@ -3,7 +3,7 @@ RELEASE=4.2 # source from http

[pve-devel] [PATCH stable-4 corosync-pve 0/2] fix CVE-2018-1084

2018-04-13 Thread Fabian Grünbichler
Fabian Grünbichler (2): fix CVE-2018-1084: DoS via malformed packet bump version to 2.4.2-2~pve4+2 Makefile | 2 +- debian/patches/cve-2018-1084.patch | 53 ++ debian/changelog | 6 + debian/patches/series

[pve-devel] [PATCH corosync-pve 1/2] fix CVE-2018-1084: DoS via malformed packet

2018-04-13 Thread Fabian Grünbichler
Signed-off-by: Fabian Grünbichler --- debian/patches/cve-2018-1084.patch | 53 ++ debian/patches/series | 1 + 2 files changed, 54 insertions(+) create mode 100644 debian/patches/cve-2018-1084.patch diff --git a/debian/patches/cve-2018-1084

Re: [pve-devel] API - GET /nodes/{node}/storage

2018-04-16 Thread Fabian Grünbichler
On Mon, Apr 16, 2018 at 06:03:58PM +0200, Andreas Steinel wrote: > Hi all, > > I tried to access the storage API and looked through [1] to find, that the > > GET /nodes/{node}/storage > > returns an array of string according to [2] the excerpt is: > > "GET" : { >"description" : "Get status

Re: [pve-devel] Sending patches

2018-04-17 Thread Fabian Grünbichler
On Tue, Apr 17, 2018 at 01:16:11PM +0200, Rene Jochum wrote: > Hi, > > I've read https://pve.proxmox.com/wiki/Developer_Documentation. > > I would like to send ONE patch series for lots of packages where > i add/extend the .gitignore. > > Is that possible? > > Thanks, > René yes, but please se

Re: [pve-devel] API - GET /nodes/{node}/storage

2018-04-17 Thread Fabian Grünbichler
On Tue, Apr 17, 2018 at 02:02:23PM +0200, Andreas Steinel wrote: > Thank you Fabian for the in depth analysis. > > I tried to use the json representation of the API in order to > automatically extract the schema definitions for a consuming API that > generates the code based on the found definitio

Re: [pve-devel] [Patch storage 2/2] fix #1691: increase timeout

2018-04-17 Thread Fabian Grünbichler
On Tue, Apr 17, 2018 at 02:39:06PM +0200, Wolfgang Link wrote: > A ZFS storage under heavy load can take more time. > --- > PVE/Storage/ZFSPoolPlugin.pm | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/PVE/Storage/ZFSPoolPlugin.pm b/PVE/Storage/ZFSPoolPlugin.pm > index 968

Re: [pve-devel] API - GET /nodes/{node}/storage

2018-04-17 Thread Fabian Grünbichler
On Tue, Apr 17, 2018 at 02:47:01PM +0200, Andreas Steinel wrote: > On Tue, Apr 17, 2018 at 2:09 PM, Fabian Grünbichler > wrote: > > there are some places where we really don't know much more than "some > > object" (because the API call does a bit too much, and ca

Re: [pve-devel] Long standing bug in "override_for_missing_acs_capabilities.patch"

2018-04-18 Thread Fabian Grünbichler
On Wed, Apr 18, 2018 at 10:50:10AM +0100, Daniel Boothby wrote: > Apologies, I have indeed misunderstood it as I didn't realise it took into > account the previous chunk alterations. > > Is there any way to know which version of the ACS patch is used in the > current 5.1-3 ISO download of Proxmox?

Re: [pve-devel] no-subscription dist-upgrade : pve-ha-lrm.service crash with compilation aborded

2018-04-18 Thread Fabian Grünbichler
On Wed, Apr 18, 2018 at 12:18:58PM +0200, Alexandre DERUMIER wrote: > Apr 18 12:14:42 kvm1 systemd[1]: pve-ha-lrm.service: Unit entered failed > state. > Apr 18 12:14:42 kvm1 systemd[1]: pve-ha-lrm.service: Failed with result > 'exit-code'. > -- Subject: Unit pve-ha-lrm.service has begun start-up

Re: [pve-devel] [PATCH librados2-perl] Convert to dpkg-buildpackage

2018-04-19 Thread Fabian Grünbichler
?= Date: Thu, 19 Apr 2018 10:04:48 +0200 Subject: [PATCH] WIP MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Signed-off-by: Fabian Grünbichler --- Makefile | 17 + debian/control.in

Re: [pve-devel] [PATCH librados2-perl] Convert to dpkg-buildpackage

2018-04-19 Thread Fabian Grünbichler
On Thu, Apr 19, 2018 at 11:02:44AM +0200, Rene Jochum wrote: > On 2018-04-19 10:16, Fabian Grünbichler wrote: > > some comments inline (your patch also only applies when ignoring > > whitespace changes!) > > > Hi Fabian, > > thank you for looking into it! Can you g

Re: [pve-devel] [PATCH librados2-perl] Convert to dpkg-buildpackage

2018-04-19 Thread Fabian Grünbichler
On Thu, Apr 19, 2018 at 11:31:08AM +0200, Rene Jochum wrote: > Thanks again, comments inline. > > On 2018-04-19 10:16, Fabian Grünbichler wrote: > >> @@ -52,23 +54,27 @@ install: PVE/RADOS.pm RADOS.so > >> .PHONY: deb ${DEB} > >> deb: ${DEB} > >>

[pve-devel] [PATCH v2 common 3/4] acme: add challenge plugins

2018-04-19 Thread Fabian Grünbichler
Signed-off-by: Fabian Grünbichler --- src/PVE/ACME/Challenge.pm | 22 ++ src/PVE/ACME/StandAlone.pm | 74 ++ 2 files changed, 96 insertions(+) create mode 100644 src/PVE/ACME/Challenge.pm create mode 100644 src/PVE/ACME/StandAlone.pm

[pve-devel] [PATCH v2 manager 1/5] add CertHelpers utility

2018-04-19 Thread Fabian Grünbichler
PVE-specific certificate helper functions Signed-off-by: Fabian Grünbichler --- PVE/Makefile | 1 + PVE/CertHelpers.pm | 107 + 2 files changed, 108 insertions(+) create mode 100644 PVE/CertHelpers.pm diff --git a/PVE/Makefile b/PVE

[pve-devel] [PATCH v2 manager 4/5] add ACME certificate API endpoints

2018-04-19 Thread Fabian Grünbichler
for creating/ordering a new certificate and renewing respectively revoking an existing one. Signed-off-by: Fabian Grünbichler --- PVE/API2/Makefile | 1 + PVE/API2/ACME.pm | 325 ++ 2 files changed, 326 insertions(+) create mode 100644 PVE

[pve-devel] [PATCH v2 common 4/4] build: install ACME files

2018-04-19 Thread Fabian Grünbichler
Signed-off-by: Fabian Grünbichler --- src/Makefile | 4 1 file changed, 4 insertions(+) diff --git a/src/Makefile b/src/Makefile index c81991d..17a794a 100644 --- a/src/Makefile +++ b/src/Makefile @@ -7,6 +7,9 @@ MAN1DIR=${MANDIR}/man1/ PERLDIR=${PREFIX}/share/perl5 LIB_SOURCES

[pve-devel] [PATCH cluster/common/manager v2 0/10] ACME library and certificate management

2018-04-19 Thread Fabian Grünbichler
enge with Let's Encrypt) - manage self-signed certificates with same helpers? - deprecate pvecm updatecerts in favour of new code in pve-manager? pve-common diff-stat: Fabian Grünbichler (4): add Certificate helper acme: add ACME library acme: add challenge plugins build: install ACME

[pve-devel] [PATCH v2 common 1/4] add Certificate helper

2018-04-19 Thread Fabian Grünbichler
general purpose certificate related helper functions Signed-off-by: Fabian Grünbichler --- src/Makefile | 1 + src/PVE/Certificate.pm | 396 + 2 files changed, 397 insertions(+) create mode 100644 src/PVE/Certificate.pm diff --git a

[pve-devel] [PATCH v2 manager 2/5] add node configuration file and API

2018-04-19 Thread Fabian Grünbichler
this currently only contains a description and the node-specific ACME configuration, but I am sure we can find other goodies to put there. Signed-off-by: Fabian Grünbichler --- PVE/API2/Makefile | 1 + PVE/Makefile | 1 + PVE/API2/NodeConfig.pm | 101

[pve-devel] [PATCH v2 cluster] cluster: add cfs_lock_acme

2018-04-19 Thread Fabian Grünbichler
to lock an ACME account config file Signed-off-by: Fabian Grünbichler --- data/PVE/Cluster.pm | 8 1 file changed, 8 insertions(+) diff --git a/data/PVE/Cluster.pm b/data/PVE/Cluster.pm index ef7a541..d12c244 100644 --- a/data/PVE/Cluster.pm +++ b/data/PVE/Cluster.pm @@ -960,6 +960,14

[pve-devel] [PATCH v2 manager 5/5] add certificates API endpoints

2018-04-19 Thread Fabian Grünbichler
to allow retrieval of certificate information, and uploading or removing of custom certificate files. Signed-off-by: Fabian Grünbichler --- PVE/API2/Makefile| 1 + PVE/API2/Certificates.pm | 205 +++ PVE/API2/Nodes.pm| 8 ++ 3

[pve-devel] [PATCH v2 manager 3/5] add ACME account API endpoints

2018-04-19 Thread Fabian Grünbichler
for registering, updating, refreshing and deactiving a PVE-managed ACME account, as well as for retrieving the (optional, but required if available) terms of service of the ACME API provider / CA. Signed-off-by: Fabian Grünbichler --- PVE/API2/Makefile | 1 + PVE/API2/ACMEAccount.pm

[pve-devel] [PATCH v2 common 2/4] acme: add ACME library

2018-04-19 Thread Fabian Grünbichler
this implements those parts of draft-ietf-acme-acme-09 which are needed to use Let's Encrypt's v2 API. (based on an internal implement for the Let's Encrypt v1 API) Co-Authored-By: Wolfgang Bumiller Signed-off-by: Fabian Grünbichler --- src/PV

[pve-devel] applied: [PATCH manager] fix #1732: actually post values in IScsiEdit

2018-04-19 Thread Fabian Grünbichler
___ pve-devel mailing list pve-devel@pve.proxmox.com https://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

Re: [pve-devel] iproute2 package for kernel 4.15 ?

2018-04-20 Thread Fabian Grünbichler
On Fri, Apr 20, 2018 at 10:33:31AM +0200, Alexandre DERUMIER wrote: > >>iproute2 4.15 contains a bug in /bin/ss which is in use in the next PVE. > > Just curious, where proxmox is using /bin/ss ? https://git.proxmox.com/?p=pve-common.git;a=blob;f=src/PVE/Tools.pm;h=d5373a4246062887bd778f35f4d2ac

[pve-devel] [PATCH kernel 4.15 0/4] update to 4.15.17-1-pve

2018-04-20 Thread Fabian Grünbichler
pve-kernel: Fabian Grünbichler (3): update source to Ubuntu-4.15.0-17.18 rebase patches bump version to 4.15-7, bump ABI to 4.15.17-1-pve Makefile | 4 ++-- ...003-pci-Enable-overrides-for-missing-ACS-capabilities-4..patch | 2

[pve-devel] [PATCH kernel 4.15 1/3] update source to Ubuntu-4.15.0-17.18

2018-04-20 Thread Fabian Grünbichler
Signed-off-by: Fabian Grünbichler --- submodules/ubuntu-bionic | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/submodules/ubuntu-bionic b/submodules/ubuntu-bionic index e4a338d..62b0412 16 --- a/submodules/ubuntu-bionic +++ b/submodules/ubuntu-bionic @@ -1 +1

[pve-devel] [PATCH kernel 4.15 2/3] rebase patches

2018-04-20 Thread Fabian Grünbichler
Signed-off-by: Fabian Grünbichler --- .../0003-pci-Enable-overrides-for-missing-ACS-capabilities-4..patch | 2 +- .../0007-Revert-UBUNTU-Packaging-retpoline-add-safe-usage-hin.patch | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/patches/kernel/0003-pci-Enable

[pve-devel] [PATCH kernel-meta 4.15 1/1] bump version to 5.1-4

2018-04-20 Thread Fabian Grünbichler
bump ABI to 4.15.17-1-pve Signed-off-by: Fabian Grünbichler --- Makefile | 4 ++-- debian/changelog | 6 ++ 2 files changed, 8 insertions(+), 2 deletions(-) diff --git a/Makefile b/Makefile index 6fe46c1..59449c7 100644 --- a/Makefile +++ b/Makefile @@ -1,8 +1,8 @@ RELEASE=5.1

[pve-devel] [PATCH kernel 4.15 3/3] bump version to 4.15-7, bump ABI to 4.15.17-1-pve

2018-04-20 Thread Fabian Grünbichler
Signed-off-by: Fabian Grünbichler --- Makefile | 4 ++-- debian/changelog | 8 2 files changed, 10 insertions(+), 2 deletions(-) diff --git a/Makefile b/Makefile index 6d808e0..051ff64 100644 --- a/Makefile +++ b/Makefile @@ -1,10 +1,10 @@ RELEASE=5.1 # also update pve

[pve-devel] [PATCH container] update_config: rescan volume size

2018-04-23 Thread Fabian Grünbichler
otherwise the size information gets lost when detaching and reattaching a mountpoint volume, which is less than ideal since mountpoints without size information require manual information when restoring. Signed-off-by: Fabian Grünbichler --- src/PVE/LXC/Config.pm | 19 +-- 1

Re: [pve-devel] [PATCH kernel v2] d/control: add some missing build dependencies

2018-04-24 Thread Fabian Grünbichler
On Tue, Apr 24, 2018 at 08:07:14AM +0200, Thomas Lamprecht wrote: > Signed-off-by: Thomas Lamprecht > --- > > changes v1 -> v2: > * omit libssl-dev for now seems I was wrong there - libssl-dev is needed for some module signing scripts (which are LGPL 2.1+), which we don't use, but some users mig

[pve-devel] [PATCH kernel 0/4] header and perf packaging improvements

2018-04-24 Thread Fabian Grünbichler
for master and pve-kernel-4.15 (modulo 4.15/4.13) Fabian Grünbichler (4): d/rules: reformat header collection d/rules: don't strip headers package d/rules: install perf man pages d/rules: check for accidental perf linkage debian/rules | 38 -- 1

[pve-devel] [PATCH kernel 2/4] d/rules: don't strip headers package

2018-04-24 Thread Fabian Grünbichler
we don't want to debug the contained helper binaries ;) Signed-off-by: Fabian Grünbichler --- debian/rules | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/debian/rules b/debian/rules index e7cedbf..725ca0f 100755 --- a/debian/rules +++ b/debian/rules @@ -77,7

[pve-devel] [PATCH kernel 4/4] d/rules: check for accidental perf linkage

2018-04-24 Thread Fabian Grünbichler
with libraries that are not GPL-2-only compatible. Signed-off-by: Fabian Grünbichler --- debian/rules | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/debian/rules b/debian/rules index a84ae5a..cb892d2 100755 --- a/debian/rules +++ b/debian/rules @@ -125,7 +125,10

[pve-devel] [PATCH kernel 1/4] d/rules: reformat header collection

2018-04-24 Thread Fabian Grünbichler
for better readability and to reduce future churn Signed-off-by: Fabian Grünbichler --- debian/rules | 27 +++ 1 file changed, 19 insertions(+), 8 deletions(-) diff --git a/debian/rules b/debian/rules index 6596254..e7cedbf 100755 --- a/debian/rules +++ b/debian/rules

[pve-devel] [PATCH kernel 3/4] d/rules: install perf man pages

2018-04-24 Thread Fabian Grünbichler
Signed-off-by: Fabian Grünbichler --- debian/rules | 4 1 file changed, 4 insertions(+) diff --git a/debian/rules b/debian/rules index 725ca0f..a84ae5a 100755 --- a/debian/rules +++ b/debian/rules @@ -127,12 +127,16 @@ binary: install .tools_compile_mark: .compile_mark ${MAKE} -C

[pve-devel] [PATCH kernel v2 4/4] d/rules: check for accidental perf linkage

2018-04-25 Thread Fabian Grünbichler
with libraries that are not GPL-2-only compatible, fix previously typoed variable, and add build-dep on libiberty-dev for CPLUS demangling. Signed-off-by: Fabian Grünbichler --- changes since v1: - switch to HAVE_NO_LIBBFD instead of feature-libbfd - add build-dep on libiberty-dev - fix wrong

[pve-devel] [v3 manager/docs 0/7] ACME library and certificate management

2018-04-27 Thread Fabian Grünbichler
cluster and common parts remain identical to v2, thus not resent. changes since v2: - added CLI and update mechanism via pveupdate - renew now errors out if no custom certificate exists - deactivated account files get renamed - fixed return type of custom certificate removal endpoint Fabian

[pve-devel] [v3 manager 1/7] add CertHelpers utility

2018-04-27 Thread Fabian Grünbichler
PVE-specific certificate helper functions Signed-off-by: Fabian Grünbichler --- PVE/Makefile | 1 + PVE/CertHelpers.pm | 107 + 2 files changed, 108 insertions(+) create mode 100644 PVE/CertHelpers.pm diff --git a/PVE/Makefile b/PVE

[pve-devel] [v3 manager 3/7] add ACME account API endpoints

2018-04-27 Thread Fabian Grünbichler
for registering, updating, refreshing and deactiving a PVE-managed ACME account, as well as for retrieving the (optional, but required if available) terms of service of the ACME API provider / CA. Signed-off-by: Fabian Grünbichler --- PVE/API2/Makefile | 1 + PVE/API2/ACMEAccount.pm

[pve-devel] [v3 manager 5/7] add certificates API endpoints

2018-04-27 Thread Fabian Grünbichler
to allow retrieval of certificate information, and uploading or removing of custom certificate files. Signed-off-by: Fabian Grünbichler --- PVE/API2/Makefile| 1 + PVE/API2/Certificates.pm | 207 +++ PVE/API2/Nodes.pm| 8 ++ 3

[pve-devel] [v3 manager 6/7] add pvenode CLIHandler

2018-04-27 Thread Fabian Grünbichler
Signed-off-by: Fabian Grünbichler --- PVE/CLI/Makefile | 2 +- bin/Makefile | 2 +- PVE/CLI/pvenode.pm | 198 + bin/pvenode| 8 +++ 4 files changed, 208 insertions(+), 2 deletions(-) create mode 100644 PVE/CLI/pvenode.pm

[pve-devel] [PATCH docs] add pvenode.adoc

2018-04-27 Thread Fabian Grünbichler
Signed-off-by: Fabian Grünbichler --- this obviously needs more work, but a dummy is required for building of the CLI part.. pvenode.1-synopsis.adoc | 140 pvenode.adoc| 30 +++ 2 files changed, 170 insertions(+) create

[pve-devel] [v3 manager 7/7] pveupdate: add ACME certificate renewal

2018-04-27 Thread Fabian Grünbichler
renew certificate if an acme config entry and a custom certificate exists on the local node and the certificate expires soon. Signed-off-by: Fabian Grünbichler --- this seems like a good place until the pvestatd refactoring.. bin/pveupdate | 21 + 1 file changed, 21

[pve-devel] [v3 manager 2/7] add node configuration file and API

2018-04-27 Thread Fabian Grünbichler
this currently only contains a description and the node-specific ACME configuration, but I am sure we can find other goodies to put there. Signed-off-by: Fabian Grünbichler --- PVE/API2/Makefile | 1 + PVE/Makefile | 1 + PVE/API2/NodeConfig.pm | 101

[pve-devel] [v3 manager 4/7] add ACME certificate API endpoints

2018-04-27 Thread Fabian Grünbichler
for creating/ordering a new certificate and renewing respectively revoking an existing one. Signed-off-by: Fabian Grünbichler --- PVE/API2/Makefile | 1 + PVE/API2/ACME.pm | 328 ++ 2 files changed, 329 insertions(+) create mode 100644 PVE

Re: [pve-devel] [PATCH v2 common 3/4] acme: add challenge plugins

2018-04-29 Thread Fabian Grünbichler
On Fri, Apr 27, 2018 at 03:38:26PM +0200, Thomas Lamprecht wrote: > On 4/19/18 2:01 PM, Fabian Grünbichler wrote: > > Signed-off-by: Fabian Grünbichler > > --- > > src/PVE/ACME/Challenge.pm | 22 ++ > > src/

[pve-devel] [PATCH 2/4] re-add pve-headers meta-package

2018-04-30 Thread Fabian Grünbichler
to depend on pve-headers-4.15, which depends on the actual pve-headers-4.15.x-y-pve package. Signed-off-by: Fabian Grünbichler --- Makefile | 4 +++- debian/control | 6 ++ 2 files changed, 9 insertions(+), 1 deletion(-) diff --git a/Makefile b/Makefile index 1db3eb8..5f3c15f 100644

[pve-devel] [PATCH 1/4] switch to 4.15 series as default kernel

2018-04-30 Thread Fabian Grünbichler
Signed-off-by: Fabian Grünbichler --- debian/control | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/debian/control b/debian/control index 990eb2e..119b612 100644 --- a/debian/control +++ b/debian/control @@ -18,7 +18,7 @@ Depends: apt, libc6 (>= 2.7

[pve-devel] [PATCH 0/4] proxmox-ve: switch to 4.15 kernel, various cleanups

2018-04-30 Thread Fabian Grünbichler
seems like the pve-headers meta package was accidentally dropped in the recent repository/package split, so this series re-introduces it after the switch to 4.15 as default kernel. Fabian Grünbichler (4): switch to 4.15 series as default kernel re-add pve-headers meta-package wrap-and-sort

[pve-devel] [PATCH 3/4] wrap-and-sort

2018-04-30 Thread Fabian Grünbichler
Signed-off-by: Fabian Grünbichler --- debian/proxmox-ve.install | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/debian/proxmox-ve.install b/debian/proxmox-ve.install index 13d16c4..c820b9a 100644 --- a/debian/proxmox-ve.install +++ b/debian/proxmox-ve.install @@ -1,3 +1,3

[pve-devel] [PATCH 4/4] bump version to 5.1-43

2018-04-30 Thread Fabian Grünbichler
Signed-off-by: Fabian Grünbichler --- Makefile | 2 +- debian/changelog | 10 ++ 2 files changed, 11 insertions(+), 1 deletion(-) diff --git a/Makefile b/Makefile index 5f3c15f..c447cdd 100644 --- a/Makefile +++ b/Makefile @@ -1,6 +1,6 @@ RELEASE=5.1 PACKAGE=proxmox-ve

[pve-devel] [PATCH manager 4/7] add ACME certificate API endpoints

2018-04-30 Thread Fabian Grünbichler
for creating/ordering a new certificate and renewing respectively revoking an existing one. Signed-off-by: Fabian Grünbichler --- changes since v3: improve output PVE/API2/Makefile | 1 + PVE/API2/ACME.pm | 331 ++ 2 files changed, 332

[pve-devel] [PATCH v3 common 3/4] acme: add challenge plugins

2018-04-30 Thread Fabian Grünbichler
Signed-off-by: Fabian Grünbichler --- changes since v2: - switch to HTTP::Daemon src/PVE/ACME/Challenge.pm | 22 ++ src/PVE/ACME/StandAlone.pm | 71 ++ 2 files changed, 93 insertions(+) create mode 100644 src/PVE/ACME/Challenge.pm

[pve-devel] [PATCH v4 manager 4/7] add ACME certificate API endpoints

2018-04-30 Thread Fabian Grünbichler
for creating/ordering a new certificate and renewing respectively revoking an existing one. Signed-off-by: Fabian Grünbichler --- changes since v3: improve output PVE/API2/Makefile | 1 + PVE/API2/ACME.pm | 331 ++ 2 files changed, 332

[pve-devel] applied: [PATCH cluster] api: allow cluster wide sys auditors to get join info

2018-05-02 Thread Fabian Grünbichler
On Mon, Apr 30, 2018 at 02:40:48PM +0200, Thomas Lamprecht wrote: > add same permissions as the GET cluster config call has. > > Else the WebUI shows 'Standalone Node' for clustered nodes if the > user is not root but has audit rights. > > Signed-off-by: Thomas Lamprecht > --- > data/PVE/API2/C

[pve-devel] applied: [PATCH cluster] fix #1743: cluster create: default to ring0_addr for bindnet0

2018-05-02 Thread Fabian Grünbichler
On Wed, May 02, 2018 at 10:02:57AM +0200, Thomas Lamprecht wrote: > Else, if a separate network address was passed for ring0_addr but no > bindnet0 adress was set we used the wrong fallback. > Do not fallback to $local_node_ip but always to $ring0_addr, which > itself falls back to local node IP. >

[pve-devel] [PATCH storage] fix #1754: rbd: fix handling of external clusters

2018-05-08 Thread Fabian Grünbichler
correctly using the values from storage.cfg for external librbd clusters. Signed-off-by: Fabian Grünbichler --- PVE/Storage/RBDPlugin.pm | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/PVE/Storage/RBDPlugin.pm b/PVE/Storage/RBDPlugin.pm index f695548..15cbe67 100644 --- a

[pve-devel] [PATCH 4.15 kernel] build: refactor header build

2018-05-09 Thread Fabian Grünbichler
to also include tools and scripts like objtool, which are now needed for external module building Signed-off-by: Fabian Grünbichler --- debian/control.in | 1 + debian/rules | 35 +-- 2 files changed, 30 insertions(+), 6 deletions(-) diff --git a/debian

[pve-devel] applied: [PATCH docs] add documentation for certificate managment

2018-05-11 Thread Fabian Grünbichler
with some slight fixups and a bit of additional info. thanks! ___ pve-devel mailing list pve-devel@pve.proxmox.com https://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

[pve-devel] [PATCH 1/2] switch default kernel/initrd symlink to 4.15

2018-05-15 Thread Fabian Grünbichler
Signed-off-by: Fabian Grünbichler --- Note: this is a fixup for the switch to pve-kernel-4.15! debian/postinst | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/debian/postinst b/debian/postinst index 2a22606..43e081b 100755 --- a/debian/postinst +++ b/debian/postinst

[pve-devel] [PATCH 2/2] bump version to 5.2-2

2018-05-15 Thread Fabian Grünbichler
Signed-off-by: Fabian Grünbichler --- Makefile | 2 +- debian/changelog | 7 +++ 2 files changed, 8 insertions(+), 1 deletion(-) diff --git a/Makefile b/Makefile index aafb890..418781c 100644 --- a/Makefile +++ b/Makefile @@ -1,6 +1,6 @@ RELEASE=5.2 PACKAGE=proxmox-ve -PKGREL=1

[pve-devel] applied/comment: [PatchV2 storage] Handel connection check timeouts.

2018-05-16 Thread Fabian Grünbichler
with fixed-up commit message. but IMHO it would make sense to follow up with some variant of: - warn instead of die if the $out_str contains an error status code - check for more error status codes - maybe 'warn "$err\n";' as well? On Wed, May 16, 2018 at 09:08:06AM +0200, Wolfgang Link wrote: > -

Re: [pve-devel] [PATCH v2 storage] Cephfs storage plugin

2018-05-17 Thread Fabian Grünbichler
some general remarks from a quick run-through: - backup does not seem to work, probably requires qemu-server/pve-container changes? [1] - parts of this could be merged with RBDPlugin code, either by extending it, or by refactoring to use a common helper module - ceph-fuse and the kernel have a

Re: [pve-devel] [PATCH manager v2] ACMEv2 order "ready" status update

2018-06-21 Thread Fabian Grünbichler
LGTM, besides on nit inline (but haven't tested from home - currently staging has the feature enabled, production does not, so this should be quick on your end ;)). On Wed, Jun 20, 2018 at 11:56:05AM +0200, Dominik Csapak wrote: > since letsencrypt updates their implementation to the ACMEv2 spec [

Re: [pve-devel] [PATCH manager v2] ACMEv2 order "ready" status update

2018-06-22 Thread Fabian Grünbichler
ficate is actually issued -- order is valid -- I don't think that part is new though, still needs to be fixed ASAP. > On Thu, 21 Jun 2018 20:34:14 +0200 > Fabian Grünbichler wrote: > > > LGTM, besides on nit inline (but haven't tested from home - currently &

Re: [pve-devel] [RFC docs] api-viewer: use our extjs package

2018-07-20 Thread Fabian Grünbichler
On Fri, Jul 13, 2018 at 12:01:54PM +0200, Thomas Lamprecht wrote: > The loading of an external hosted ExtJS is from a time where we did > not have a extra ExtJS package as it still was in the pve-manager > one. > Add a dependency on libjs-extjs and a link from api-viewer/extjs to > the instalation

Re: [pve-devel] [PATCH docs] doc-generator: synopsis: add parent directory to include path

2018-07-27 Thread Fabian Grünbichler
On Fri, Jul 27, 2018 at 12:35:55PM +0200, Dietmar Maurer wrote: > NOTE: you always need an actual version of package pve-doc-generator, so > your patch does not solve all those build problems. Not sure how we can > solve that cyclic dependency problem cleanly ... in case of patches to repo FOO tha

[pve-devel] applied: [PATCH lxc 1/2] cherry-pick CVE-2018-6556 fix

2018-08-07 Thread Fabian Grünbichler
from upstream's stable-3.0 branch Signed-off-by: Fabian Grünbichler --- ...6556-verify-netns-fd-in-lxc-user-nic.patch | 115 ++ debian/patches/series | 1 + 2 files changed, 116 insertions(+) create mode 100644 debian/patches/extra/0013-CVE-2018

[pve-devel] applied: [PATCH lxc 2/2] bump version to 3.0.1+pve2-1

2018-08-07 Thread Fabian Grünbichler
Signed-off-by: Fabian Grünbichler --- Makefile | 2 +- debian/changelog | 6 ++ 2 files changed, 7 insertions(+), 1 deletion(-) diff --git a/Makefile b/Makefile index 6f7ef62..5139576 100644 --- a/Makefile +++ b/Makefile @@ -1,5 +1,5 @@ PACKAGE=lxc-pve -LXCVER=3.0.1+pve1 +LXCVER

[pve-devel] [RFC pve-container/manager 0/3] fix #1897: bump max. number of MPs to 256

2018-09-05 Thread Fabian Grünbichler
s per guest (currently 100). pve-container: Fabian Grünbichler (1): fix #1897: bump MAX_MOUNT_POINTS to 256 src/PVE/LXC/Config.pm | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) pve-manager: Fabian Grünbichler (2): fix #1897: bump max number of mountpoints to 256 switch MP sel

[pve-devel] [PATCH manager 2/2] switch MP selector to integer input

2018-09-05 Thread Fabian Grünbichler
instead of combobox - 256 elements are too much. Signed-off-by: Fabian Grünbichler --- www/manager6/lxc/MPEdit.js | 29 +++-- 1 file changed, 11 insertions(+), 18 deletions(-) diff --git a/www/manager6/lxc/MPEdit.js b/www/manager6/lxc/MPEdit.js index 63315cfd..c7c3870a

[pve-devel] [PATCH container] fix #1897: bump MAX_MOUNT_POINTS to 256

2018-09-05 Thread Fabian Grünbichler
and filter list of possible mountpoint names by currently used ones before iterating instead of in the loop body. Signed-off-by: Fabian Grünbichler --- src/PVE/LXC/Config.pm | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/PVE/LXC/Config.pm b/src/PVE/LXC/Config.pm

[pve-devel] [PATCH manager 1/2] fix #1897: bump max number of mountpoints to 256

2018-09-05 Thread Fabian Grünbichler
Signed-off-by: Fabian Grünbichler --- www/manager6/Utils.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/www/manager6/Utils.js b/www/manager6/Utils.js index c2007f6d..568ceb7b 100644 --- a/www/manager6/Utils.js +++ b/www/manager6/Utils.js @@ -1042,7 +1042,7 @@ Ext.define

Re: [pve-devel] [PATCH storage v2 2/3] make max number of disks a constant

2018-09-07 Thread Fabian Grünbichler
tiny nit inline On Fri, Sep 07, 2018 at 03:08:41PM +0200, Stoiko Ivanov wrote: > Signed-off-by: Stoiko Ivanov > --- > PVE/Storage/Plugin.pm | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/PVE/Storage/Plugin.pm b/PVE/Storage/Plugin.pm > index 32acf69..7516f4e 100644 >

Re: [pve-devel] Please help: beginner trying to compile Proxmox kernel 4.15

2018-09-10 Thread Fabian Grünbichler
On Mon, Sep 10, 2018 at 06:55:02PM +0700, The Anh Tran wrote: > [...] > > > /install: target > > 'debian/pve-kernel-4.15.18-4-pve/lib/modules/4.15.18-4-pve/kernel/drivers/net/ethernet/intel/igb/' > > is not a directory: No such file or directory// > > > //debian/rules:99: recipe for target '.inst

Re: [pve-devel] Please help: beginner trying to compile Proxmox kernel 4.15

2018-09-12 Thread Fabian Grünbichler
On Tue, Sep 11, 2018 at 04:54:46PM +0700, The Anh Tran wrote: > Dear Teams, > > On 9/11/2018 3:53 AM, Fabian Grünbichler wrote: > > I am not sure whether your manual git clones messed anything up or > > whether you somehow manage to trigger some error in our Make logic &

[pve-devel] [PATCH docs 4/7] d/control: bump debhelper build-dependency

2018-09-12 Thread Fabian Grünbichler
Signed-off-by: Fabian Grünbichler --- debian/control | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/debian/control b/debian/control index a813b98..86f8e14 100644 --- a/debian/control +++ b/debian/control @@ -3,7 +3,7 @@ Section: perl Priority: extra Maintainer: Proxmox

[pve-devel] [PATCH docs 5/7] d/control: add missing build-dependencies

2018-09-12 Thread Fabian Grünbichler
gathered by building in a minimal Debian Stretch chroot with just the listed build-dependencies installed. Signed-off-by: Fabian Grünbichler --- debian/control | 4 1 file changed, 4 insertions(+) diff --git a/debian/control b/debian/control index 86f8e14..fa76199 100644 --- a/debian

[pve-devel] [PATCH docs 3/7] build: wrap-and-sort debian/

2018-09-12 Thread Fabian Grünbichler
for consistency and easier diffing Signed-off-by: Fabian Grünbichler --- no change besides formatting/order debian/control| 33 --- debian/copyright | 4 ++-- debian/pve-docs-mediawiki.docs| 2 +- debian/pve-docs

[pve-devel] [PATCH docs 7/7] d/compat: bump to 10

2018-09-12 Thread Fabian Grünbichler
(enables parallel builds by default) Signed-off-by: Fabian Grünbichler --- debian/compat | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/debian/compat b/debian/compat index ec63514..f599e28 100644 --- a/debian/compat +++ b/debian/compat @@ -1 +1 @@ -9 +10 -- 2.18.0

[pve-devel] [RFC docs 0/7] build improvements

2018-09-12 Thread Fabian Grünbichler
the following changes are contained in this series: - switch to standard, single dpkg-buildpackage invocation to build all binary packages in one go - add missing build dependencies - fix and enable parallel building Fabian Grünbichler (7): update static files build: refactor build process

[pve-devel] [PATCH docs 6/7] build: fix broken parallel builds

2018-09-12 Thread Fabian Grünbichler
a2x only supports destination folders for HTML based variants, but fortunately that is enough in our case without needing extra workarounds. Signed-off-by: Fabian Grünbichler --- note: this cuts down the build time from 1:40 to :40 on my work station! note2: I didn't find any reference t

<    3   4   5   6   7   8   9   10   11   12   >