[pve-devel] [PATCH 3/4] optional socket family parameter for create_reusable_socket

2015-05-08 Thread Wolfgang Bumiller
--- src/PVE/Daemon.pm | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/PVE/Daemon.pm b/src/PVE/Daemon.pm index 0d0e16b..ddbe656 100644 --- a/src/PVE/Daemon.pm +++ b/src/PVE/Daemon.pm @@ -782,7 +782,7 @@ sub register_status_command { # some useful helper sub

[pve-devel] [PATCH 2/4] provide Tools::unpack_sockaddr_in46

2015-05-08 Thread Wolfgang Bumiller
--- src/PVE/Tools.pm | 9 + 1 file changed, 9 insertions(+) diff --git a/src/PVE/Tools.pm b/src/PVE/Tools.pm index d886a3d..75ca5a6 100644 --- a/src/PVE/Tools.pm +++ b/src/PVE/Tools.pm @@ -4,6 +4,7 @@ use strict; use warnings; use POSIX qw(EINTR); use IO::Socket::IP; +use Socket

[pve-devel] [PATCH 2/2] listen on ipv6 if the node's hostname resolves to ipv6

2015-05-08 Thread Wolfgang Bumiller
--- bin/pveproxy | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/bin/pveproxy b/bin/pveproxy index fe25a80..386 100755 --- a/bin/pveproxy +++ b/bin/pveproxy @@ -26,6 +26,8 @@ use PVE::ExtJSIndex5; use PVE::NoVncIndex; use PVE::TouchIndex; +use PVE::Tools; + use

[pve-devel] [PATCH 1/2] HTTPServer.pm: accept ip6 connections

2015-05-08 Thread Wolfgang Bumiller
--- PVE/HTTPServer.pm | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/PVE/HTTPServer.pm b/PVE/HTTPServer.pm index 6395bdd..b991fe9 100755 --- a/PVE/HTTPServer.pm +++ b/PVE/HTTPServer.pm @@ -1504,8 +1504,8 @@ sub accept_connections { } if (my $sin

[pve-devel] [PATCH 0/2] pve-manager: ipv6 support for pveproxy

2015-05-08 Thread Wolfgang Bumiller
or ipv6. (Which means its /etc/hosts entry now decides) Wolfgang Bumiller (2): HTTPServer.pm: accept ip6 connections listen on ipv6 if the node's hostname resolves to ipv6 PVE/HTTPServer.pm | 4 ++-- bin/pveproxy | 5 - 2 files changed, 6 insertions(+), 3 deletions(-) -- 2.1.4

[pve-devel] [PATCH 2/2] use freeaddrinfo on getaddrinfo results when done

2015-05-08 Thread Wolfgang Bumiller
--- data/src/pmxcfs.c | 12 +++- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/data/src/pmxcfs.c b/data/src/pmxcfs.c index be90618..684bc51 100644 --- a/data/src/pmxcfs.c +++ b/data/src/pmxcfs.c @@ -693,6 +693,7 @@ lookup_node_ip(const char *nodename) char

[pve-devel] [PATCH 0/2] pve-cluster: pmxcfs ipv6 check

2015-05-08 Thread Wolfgang Bumiller
added the ipv6 equivalent for the loopback interface check (checking for ::1), and added the missing freeaddrinfo call (as getaddrinfo allocates a linked list the user has to free themselves.) Wolfgang Bumiller (2): ipv6 support for lookup_node_ip use freeaddrinfo on getaddrinfo results when

[pve-devel] [PATCH 1/2] ipv6 support for lookup_node_ip

2015-05-08 Thread Wolfgang Bumiller
--- data/src/pmxcfs.c | 10 -- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/data/src/pmxcfs.c b/data/src/pmxcfs.c index a461165..be90618 100644 --- a/data/src/pmxcfs.c +++ b/data/src/pmxcfs.c @@ -690,6 +690,7 @@ create_symlinks(cfs_plug_base_t *bplug, const char

[pve-devel] [PATCH 0/4] pve-common: ipv6 changes

2015-05-08 Thread Wolfgang Bumiller
/hosts) points to an ipv4 or ipv6 address. For (b) I also added an optional $family parameter to Daemon::create_reusable_socket which is passed as Socket::IP-new's Family option. The rest just replaces Socket::INET with Socket::IP. Wolfgang Bumiller (4): Use IO::Socket::IP instead of INET

[pve-devel] [PATCH 4/4] add utility to fetch the socket family for a hostname

2015-05-08 Thread Wolfgang Bumiller
--- src/PVE/Tools.pm | 12 +++- 1 file changed, 11 insertions(+), 1 deletion(-) diff --git a/src/PVE/Tools.pm b/src/PVE/Tools.pm index 75ca5a6..0e1af09 100644 --- a/src/PVE/Tools.pm +++ b/src/PVE/Tools.pm @@ -4,7 +4,7 @@ use strict; use warnings; use POSIX qw(EINTR); use

[pve-devel] [PATCH 1/4] Use IO::Socket::IP instead of INET

2015-05-08 Thread Wolfgang Bumiller
--- src/PVE/Daemon.pm | 6 +++--- src/PVE/Tools.pm | 12 ++-- 2 files changed, 9 insertions(+), 9 deletions(-) diff --git a/src/PVE/Daemon.pm b/src/PVE/Daemon.pm index 264f8be..0d0e16b 100644 --- a/src/PVE/Daemon.pm +++ b/src/PVE/Daemon.pm @@ -24,7 +24,7 @@ use PVE::INotify; use POSIX

[pve-devel] [PATCH] Switch from netcat-traditional to netcat6

2015-05-11 Thread Wolfgang Bumiller
netcat6 supports both ipv4 and ipv6, contrary to netcat-traditional. Additionally rather than using the alternatives-managed /bin/nc path, /bin/nc6 is now used which always points to the netcat6 implementation, allowing us to drop the netcat-openbsd conflict entry. --- PVE/API2/Qemu.pm | 2 +-

[pve-devel] [PATCH] ipv6 support for Storage::resolv_server

2015-05-11 Thread Wolfgang Bumiller
--- PVE/Storage.pm | 9 +++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/PVE/Storage.pm b/PVE/Storage.pm index b542ee6..b0c63a1 100755 --- a/PVE/Storage.pm +++ b/PVE/Storage.pm @@ -930,9 +930,14 @@ sub storage_info { sub resolv_server { my ($server) = @_; -my

[pve-devel] [PATCH 2/2] new helper: getaddrinfo_all

2015-05-11 Thread Wolfgang Bumiller
As it's commonly used in ipv6 support code a getaddrinfo wrapper passing default flags and dealing with the (err,result) tuple was added. --- src/PVE/Tools.pm | 15 ++- 1 file changed, 10 insertions(+), 5 deletions(-) diff --git a/src/PVE/Tools.pm b/src/PVE/Tools.pm index

[pve-devel] [PATCH] pass port family to next_*_port() calls

2015-05-11 Thread Wolfgang Bumiller
--- PVE/API2/Qemu.pm | 10 ++ PVE/QemuMigrate.pm | 3 ++- PVE/QemuServer.pm | 9 ++--- 3 files changed, 14 insertions(+), 8 deletions(-) diff --git a/PVE/API2/Qemu.pm b/PVE/API2/Qemu.pm index c0a6bc3..f0acb34 100644 --- a/PVE/API2/Qemu.pm +++ b/PVE/API2/Qemu.pm @@ -1299,17

[pve-devel] [PATCH 1/2] pass extra args in next_unused_port functions to IP-new

2015-05-11 Thread Wolfgang Bumiller
Instead of assuming a local address of 0.0.0.0, the next_*_port family of functions can now take extra arguments which will be passed over to IO::Socket::IP-new. Currently used to pass along the desired protocol family (AF_INET/AF_INET6). --- src/PVE/Tools.pm | 12 ++-- 1 file changed, 6

[pve-devel] [PATCH] pass port family to next_vnc_port

2015-05-11 Thread Wolfgang Bumiller
--- src/PVE/API2/LXC.pm | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/src/PVE/API2/LXC.pm b/src/PVE/API2/LXC.pm index a6b2e2e..b4f8b0f 100644 --- a/src/PVE/API2/LXC.pm +++ b/src/PVE/API2/LXC.pm @@ -650,14 +650,16 @@ __PACKAGE__-register_method ({ $sslcert

[pve-devel] [PATCH] pass port family to next_vnc_port

2015-05-11 Thread Wolfgang Bumiller
--- PVE/API2/Nodes.pm | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/PVE/API2/Nodes.pm b/PVE/API2/Nodes.pm index 1191925..e124026 100644 --- a/PVE/API2/Nodes.pm +++ b/PVE/API2/Nodes.pm @@ -680,14 +680,16 @@ __PACKAGE__-register_method ({ $sslcert =

[pve-devel] [PATCH 2/2] new helper: getaddrinfo_all

2015-05-12 Thread Wolfgang Bumiller
As it's commonly used in ipv6 support code a getaddrinfo wrapper passing default flags and dealing with the (err,result) tuple was added. --- src/PVE/Tools.pm | 15 ++- 1 file changed, 10 insertions(+), 5 deletions(-) diff --git a/src/PVE/Tools.pm b/src/PVE/Tools.pm index

[pve-devel] [PATCH 0/2] pve-common: smaller next_*_port interface

2015-05-12 Thread Wolfgang Bumiller
Adapted the pve-common patchset so next_*_port functions explicitly take a family argument instead of an array passed to Socket::IP. Wolfgang Bumiller (2): add a socket family argument to next_*_port functions new helper: getaddrinfo_all src/PVE/Tools.pm | 28 ++-- 1

[pve-devel] [PATCH 1/2] add a socket family argument to next_*_port functions

2015-05-12 Thread Wolfgang Bumiller
Instead of assuming a local address of 0.0.0.0, the next_*_port family of functions now takes an optional packet family argument (AF_INET/AF_INET6), used for ipv6 support. --- src/PVE/Tools.pm | 13 - 1 file changed, 8 insertions(+), 5 deletions(-) diff --git a/src/PVE/Tools.pm

[pve-devel] [PATCH] Storage::resolv_server gethostbyname replacement explanation

2015-05-12 Thread Wolfgang Bumiller
this works with ipv4 addresses. At the same time when asking for an actual _name_ instead of an ipv6 address, the result shows an address type of AF_INET, instead of AF_INET6, even if the name is supposed to resolve to ONLY an ipv6 address. Wolfgang Bumiller (1): ipv6 support for Storage::resolv_server

[pve-devel] [PATCH] ipv6 support for Storage::resolv_server

2015-05-12 Thread Wolfgang Bumiller
While in posix gethostbyname(3) does support ipv6, perl's gethostbyname usually returns wrong results for names, or no results for ipv6 addresses. Since we provide a getaddrinfo helper already, we now use that instead. --- PVE/Storage.pm | 9 +++-- 1 file changed, 7 insertions(+), 2

[pve-devel] [PATCH] pass port family to next_vnc_port

2015-05-12 Thread Wolfgang Bumiller
--- src/PVE/API2/LXC.pm | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/src/PVE/API2/LXC.pm b/src/PVE/API2/LXC.pm index a6b2e2e..60ad647 100644 --- a/src/PVE/API2/LXC.pm +++ b/src/PVE/API2/LXC.pm @@ -650,14 +650,16 @@ __PACKAGE__-register_method ({ $sslcert

[pve-devel] [PATCH] pass port family to next_*_port() calls

2015-05-12 Thread Wolfgang Bumiller
--- PVE/API2/Qemu.pm | 10 ++ PVE/QemuMigrate.pm | 3 ++- PVE/QemuServer.pm | 9 ++--- 3 files changed, 14 insertions(+), 8 deletions(-) diff --git a/PVE/API2/Qemu.pm b/PVE/API2/Qemu.pm index c0a6bc3..fae2872 100644 --- a/PVE/API2/Qemu.pm +++ b/PVE/API2/Qemu.pm @@ -1299,17

[pve-devel] [PATCH] remote_node_ip: option to include the packet family

2015-05-12 Thread Wolfgang Bumiller
If an array is requested, the function now returns ($ip, $family), otherweise just the IP alone. Several ipv6 related changes in other packages need to pass the packet family to functions and will make use of this functionality. --- data/PVE/Cluster.pm | 28 +--- 1 file

[pve-devel] [PATCH] spiceproxy: same condition for ipv6 socket as in pveproxy

2015-05-12 Thread Wolfgang Bumiller
--- bin/spiceproxy | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/bin/spiceproxy b/bin/spiceproxy index fbeb7a6..07acf32 100755 --- a/bin/spiceproxy +++ b/bin/spiceproxy @@ -60,7 +60,8 @@ sub init { my $lockfh = IO::File-new(${accept_lock_fn}) || die unable to

[pve-devel] [PATCH] pass port family to next_vnc_port

2015-05-12 Thread Wolfgang Bumiller
--- PVE/API2/Nodes.pm | 10 ++ PVE/API2Tools.pm | 5 - 2 files changed, 10 insertions(+), 5 deletions(-) diff --git a/PVE/API2/Nodes.pm b/PVE/API2/Nodes.pm index 1191925..3519117 100644 --- a/PVE/API2/Nodes.pm +++ b/PVE/API2/Nodes.pm @@ -680,14 +680,16 @@

[pve-devel] [PATCH] fix bad remote_node_ip usage

2015-05-12 Thread Wolfgang Bumiller
--- src/PVE/API2/LXC.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/PVE/API2/LXC.pm b/src/PVE/API2/LXC.pm index c565326..4a2e329 100644 --- a/src/PVE/API2/LXC.pm +++ b/src/PVE/API2/LXC.pm @@ -651,7 +651,7 @@ __PACKAGE__-register_method ({ my ($remip, $family);

[pve-devel] [PATCH] prevent the use of AI_ADDRCONFIG

2015-05-20 Thread Wolfgang Bumiller
perl's IO::Socket::IP passes this if no GetAddrInfoFlags are passed, which is often useful but also causes it to error when explicitly trying to bind to 127.0.0.1 when there are no _other_ IPv4 addresses present. --- src/PVE/Daemon.pm | 1 + src/PVE/Tools.pm | 3 ++- 2 files changed, 3

[pve-devel] [PATCH 3/3] NFS: replace rpcinfo with showmounts

2015-05-21 Thread Wolfgang Bumiller
rpcinfo from rpcbind-0.2.1 in debian doesn't support ipv6 addresses. At the same time the used command only actually tests for portmapper/rpcbind availability, not for NFS directly. Storage::scan_nfs uses /sbin/showmount to get a list of NFS exports from a server and happily accepts ipv6

[pve-devel] [PATCH] remove superfluous substitution

2015-06-05 Thread Wolfgang Bumiller
regexps are greedy so the first substitution eats up multiple groups of double-colons up to the last one already. So unless there's some intended hidden side effect this statement has no obvious purpose. --- src/PVE/RESTHandler.pm | 2 -- 1 file changed, 2 deletions(-) diff --git

[pve-devel] [PATCH] Added patch for vvfat's file.label option

2015-06-18 Thread Wolfgang Bumiller
Bumiller w.bumil...@proxmox.com +Date: Thu, 18 Jun 2015 11:36:49 +0200 +Subject: [PATCH] vvfat: add a label option + +Till now the vvfat filesystem's label was hardcoded to be +QEMU VVFAT, now you can pass a file.label=labelname option +to the -drive to change it. + +Signed-off-by: Wolfgang Bumiller

Re: [pve-devel] RFC: qemu-server : add cloudinit support

2015-06-18 Thread Wolfgang Bumiller
...@proxmox.com À: Wolfgang Bumiller w.bumil...@proxmox.com, aderumier aderum...@odiso.com Cc: pve-devel pve-devel@pve.proxmox.com Envoyé: Mercredi 17 Juin 2015 11:40:24 Objet: Re: [pve-devel] RFC: qemu-server : add cloudinit support I would like to known when do you want to generate

[pve-devel] [PATCH v2 1/3] PVE::API2::Ceph: network_interfaces update + ipv6

2015-06-25 Thread Wolfgang Bumiller
--- PVE/API2/Ceph.pm | 14 -- 1 file changed, 8 insertions(+), 6 deletions(-) diff --git a/PVE/API2/Ceph.pm b/PVE/API2/Ceph.pm index 217b8ce..b7eea84 100644 --- a/PVE/API2/Ceph.pm +++ b/PVE/API2/Ceph.pm @@ -765,16 +765,18 @@ __PACKAGE__-register_method ({ my $find_node_ip = sub {

[pve-devel] [PATCH v2 0/3] [manager] network interfaces internal API change

2015-06-25 Thread Wolfgang Bumiller
Changes since [PATCH] version 1: * using integer type with minimum and maximum for IPv6 prefix length * UI: removed IP6Prefix field types * UI: IPv6 prefix length is now a number field Wolfgang Bumiller (3): PVE::API2::Ceph: network_interfaces update + ipv6 PVE::API2::Network

[pve-devel] [PATCH v4 1/2] implement cloudinit v2

2015-06-25 Thread Wolfgang Bumiller
From: Alexandre Derumier aderum...@odiso.com Signed-off-by: Alexandre Derumier aderum...@odiso.com --- PVE/QemuServer.pm | 181 +- control.in| 2 +- 2 files changed, 179 insertions(+), 4 deletions(-) diff --git a/PVE/QemuServer.pm

[pve-devel] [PATCH v4 0/2] cloud-init update

2015-06-25 Thread Wolfgang Bumiller
Changes to [PATCH] v3: * moved cloud-init related network config to ipconfigX variables Still on the TODO: * rsync iso on migration * GUI Alexandre Derumier (1): implement cloudinit v2 Wolfgang Bumiller (1): cloud-init changes PVE/QemuServer.pm | 278

[pve-devel] [PATCH v4 2/2] cloud-init changes

2015-06-25 Thread Wolfgang Bumiller
* Add ipconfigX for all netX configuration options and using ip=CIDR, gw=IP, ip6=CIDR, gw6=IP as option names like in LXC. * Adding explicit ip=dhcp and ip6=dhcp options. * Removing the config-update code and instead generating the ide3 commandline in config_to_command. - Adding a

[pve-devel] [PATCH v2 06/11] read_etc_interfaces: missing iface initialization

2015-06-25 Thread Wolfgang Bumiller
If no 'auto' line was read the interface hash has to be initialized. --- src/PVE/INotify.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/PVE/INotify.pm b/src/PVE/INotify.pm index 630e62f..7fc6978 100644 --- a/src/PVE/INotify.pm +++ b/src/PVE/INotify.pm @@ -827,7 +827,7

[pve-devel] [PATCH v2 08/11] importing etc_network_interfaces tests

2015-06-25 Thread Wolfgang Bumiller
--- Makefile | 3 + test/Makefile | 12 ++ test/etc_network_interfaces/Makefile | 7 + test/etc_network_interfaces/base | 16 ++ test/etc_network_interfaces/loopback

[pve-devel] [PATCH v2 07/11] /etc/network/interfaces: deal with OVS allow- lines

2015-06-25 Thread Wolfgang Bumiller
* __read_etc_interfaces: Delete OVS ports from allow-$OVS_BRIDGE option lines in order to prevent them from being duplicated or kept after removing the port from the bridge. * __write_etc_interfaces: Deleting unused OVSPorts has the side effect of them not being written out at all. If, however,

[pve-devel] [PATCH v2 00/11] [common] network interfaces internal API change

2015-06-25 Thread Wolfgang Bumiller
Changes since [PATCH] version 1: *) Dropped unused JSONSchema patch *) Non-/greedy regex fixed *) $once/$done simplified in write_etc_network_interfaces *) squashed patches fixing patch-induced issues *) Bridge port merging now uses spaces instead of newlines Wolfgang Bumiller (11

[pve-devel] [PATCH v2 09/11] PVE::INotify::write_network_interfaces: readability

2015-06-25 Thread Wolfgang Bumiller
--- src/PVE/INotify.pm | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/src/PVE/INotify.pm b/src/PVE/INotify.pm index 5fce0c8..4dd4036 100644 --- a/src/PVE/INotify.pm +++ b/src/PVE/INotify.pm @@ -1304,12 +1304,10 @@ NETWORKDOC return $p1 = $p2 if $p1 != $p2;

[pve-devel] [PATCH v2 05/11] PVE::INotify: testable interface parser

2015-06-25 Thread Wolfgang Bumiller
read_etc_network_interfaces now opens all /proc files and passes them as filehandles to the actual implementation which is now is __read_etc_network_interfaces. Similarly write_etc_network_interfaces now prints the content string returned by the implementation now named

[pve-devel] [PATCH v2 10/11] write_network_interfaces: improved sorting

2015-06-25 Thread Wolfgang Bumiller
This way option line positions between interfaces can be preserved. --- src/PVE/INotify.pm | 19 +-- 1 file changed, 9 insertions(+), 10 deletions(-) diff --git a/src/PVE/INotify.pm b/src/PVE/INotify.pm index 4dd4036..564814e 100644 --- a/src/PVE/INotify.pm +++

[pve-devel] [PATCH v2 01/11] read_etc_network_interfaces: less strict parsing

2015-06-25 Thread Wolfgang Bumiller
*) Don't require indented lines, instead know when to end a section. *) Don't require empty lines between sections. *) Fixed non-/greedy regex issue And turned (.*)\s* into just (.*) as .* eats the whitespace too. --- src/PVE/INotify.pm | 23 +-- 1 file changed, 17

[pve-devel] [PATCH v2 02/11] removed write-only $gateway variable

2015-06-25 Thread Wolfgang Bumiller
--- src/PVE/INotify.pm | 7 +-- 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/src/PVE/INotify.pm b/src/PVE/INotify.pm index b39748c..134305f 100644 --- a/src/PVE/INotify.pm +++ b/src/PVE/INotify.pm @@ -764,8 +764,6 @@ sub read_etc_network_interfaces { # we try to keep

[pve-devel] [PATCH v2 04/11] write_etc_network_interfaces: updated header comment

2015-06-25 Thread Wolfgang Bumiller
The header now mentions that the file is auto-generated and should not be tempered with directly. It now recommends to add custom network configurations via source/source-directory lines. --- src/PVE/INotify.pm | 14 +- 1 file changed, 13 insertions(+), 1 deletion(-) diff --git

[pve-devel] [PATCH v2 11/11] tests: list/create/update network interfaces

2015-06-25 Thread Wolfgang Bumiller
--- test/etc_network_interfaces/brbase | 26 + test/etc_network_interfaces/t.create_network.pl | 91 ++ test/etc_network_interfaces/t.list-interfaces.pl | 109 + test/etc_network_interfaces/t.update_network.pl | 116 +++

[pve-devel] [PATCH 04/16] read_etc_network_interfaces: improved parsing

2015-06-24 Thread Wolfgang Bumiller
* parsing ipv6 blocks * parsing extra lines like source/source-directory/... The returned config hash is not just the interface hash anymore. Interfaces are now in its 'ifaces' member hash. All unknown options (including mappings) end up in its 'options' hash. Added a comment describing the

[pve-devel] [PATCH 12/16] /etc/network/interfaces: deal with OVS allow- lines

2015-06-24 Thread Wolfgang Bumiller
* __read_etc_interfaces: Delete OVS ports from allow-$OVS_BRIDGE option lines in order to prevent them from being duplicated or kept after removing the port from the bridge. * __write_etc_interfaces: Deleting unused OVSPorts has the side effect of them not being written out at all. If, however,

[pve-devel] [PATCH 10/16] write_etc_interfaces: fix: don't write ref of options6

2015-06-24 Thread Wolfgang Bumiller
--- src/PVE/INotify.pm | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/PVE/INotify.pm b/src/PVE/INotify.pm index 846eb2f..57d7e6f 100644 --- a/src/PVE/INotify.pm +++ b/src/PVE/INotify.pm @@ -773,7 +773,7 @@ my $extract_ovs_option = sub { # known options, # like

[pve-devel] [PATCH 07/16] write_etc_network_interfaces: updated header comment

2015-06-24 Thread Wolfgang Bumiller
The header now mentions that the file is auto-generated and should not be tempered with directly. It now recommends to add custom network configurations via source/source-directory lines. --- src/PVE/INotify.pm | 14 +- 1 file changed, 13 insertions(+), 1 deletion(-) diff --git

[pve-devel] [PATCH 15/16] write_network_interfaces: improved sorting

2015-06-24 Thread Wolfgang Bumiller
This way option line positions between interfaces can be preserved. --- src/PVE/INotify.pm | 19 +-- 1 file changed, 9 insertions(+), 10 deletions(-) diff --git a/src/PVE/INotify.pm b/src/PVE/INotify.pm index 8b89488..be69510 100644 --- a/src/PVE/INotify.pm +++

[pve-devel] [PATCH 14/16] PVE::INotify::write_network_interfaces: readability

2015-06-24 Thread Wolfgang Bumiller
--- src/PVE/INotify.pm | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/src/PVE/INotify.pm b/src/PVE/INotify.pm index 13c55bc..8b89488 100644 --- a/src/PVE/INotify.pm +++ b/src/PVE/INotify.pm @@ -1309,12 +1309,10 @@ NETWORKDOC return $p1 = $p2 if $p1 != $p2;

[pve-devel] [PATCH 05/16] merge bridge_port declarations

2015-06-24 Thread Wolfgang Bumiller
--- src/PVE/INotify.pm | 10 +++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/src/PVE/INotify.pm b/src/PVE/INotify.pm index 5bae210..4dde7b0 100644 --- a/src/PVE/INotify.pm +++ b/src/PVE/INotify.pm @@ -854,7 +854,11 @@ sub read_etc_network_interfaces {

[pve-devel] [PATCH 08/16] PVE::INotify: testable interface parser

2015-06-24 Thread Wolfgang Bumiller
read_etc_network_interfaces now opens all /proc files and passes them as filehandles to the actual implementation which is now is __read_etc_network_interfaces. Similarly write_etc_network_interfaces now prints the content string returned by the implementation now named

[pve-devel] [PATCH 16/16] tests: list/create/update network interfaces

2015-06-24 Thread Wolfgang Bumiller
--- test/etc_network_interfaces/brbase | 26 + test/etc_network_interfaces/t.create_network.pl | 91 ++ test/etc_network_interfaces/t.list-interfaces.pl | 109 + test/etc_network_interfaces/t.update_network.pl | 116 +++

[pve-devel] [PATCH 03/16] removed write-only $gateway variable

2015-06-24 Thread Wolfgang Bumiller
--- src/PVE/INotify.pm | 7 +-- 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/src/PVE/INotify.pm b/src/PVE/INotify.pm index 351e325..077975b 100644 --- a/src/PVE/INotify.pm +++ b/src/PVE/INotify.pm @@ -764,8 +764,6 @@ sub read_etc_network_interfaces { # we try to keep

[pve-devel] [PATCH 13/16] importing etc_network_interfaces tests

2015-06-24 Thread Wolfgang Bumiller
--- Makefile | 3 + test/Makefile | 12 ++ test/etc_network_interfaces/Makefile | 7 + test/etc_network_interfaces/base | 16 ++ test/etc_network_interfaces/loopback

[pve-devel] [PATCH 06/16] write_etc_network_interfaces: write options only once

2015-06-24 Thread Wolfgang Bumiller
Options such as bridge ports or ovs_* will now be written out only for the first interface. If multiple protocol families of a bridge contain bridge_ports lines they will be merged into the first interface. --- src/PVE/INotify.pm | 51 --- 1 file

[pve-devel] [PATCH 00/16] [common] network interfaces internal API change

2015-06-24 Thread Wolfgang Bumiller
interfaces not having been reset to manual after removing them from an OVS bridge, (this used to make write-read-write produce two different files on the two writes after removing an ovs port) * warning fixes Wolfgang Bumiller (16): JSONSchema: ipv6prefix and ipsubnet

[pve-devel] [PATCH 09/16] write_network_interfaces: better newline consistency

2015-06-24 Thread Wolfgang Bumiller
Don't write extra newlines between sections where no options are printed when options exist. --- src/PVE/INotify.pm | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/PVE/INotify.pm b/src/PVE/INotify.pm index 3277fae..846eb2f 100644 --- a/src/PVE/INotify.pm +++

[pve-devel] [PATCH 02/16] read_etc_network_interfaces: less strict parsing

2015-06-24 Thread Wolfgang Bumiller
*) Don't require indented lines, instead know when to end a section. *) Don't require empty lines between sections. And turned (.*)\s* into just (.*) as .* eats the whitespace too. --- src/PVE/INotify.pm | 23 +-- 1 file changed, 17 insertions(+), 6 deletions(-) diff

[pve-devel] [PATCH 11/16] read_etc_interfaces: missing iface initialization

2015-06-24 Thread Wolfgang Bumiller
If no 'auto' line was read the interface hash has to be initialized. --- src/PVE/INotify.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/PVE/INotify.pm b/src/PVE/INotify.pm index 57d7e6f..0675538 100644 --- a/src/PVE/INotify.pm +++ b/src/PVE/INotify.pm @@ -827,7 +827,7

[pve-devel] [PATCH 3/3] www/network: ipv6 related columns and edit fields

2015-06-24 Thread Wolfgang Bumiller
IPv6 address shown in cidr notation in the IP address column, the subnet column only includes the ipv4 subnet mask, the gateway includes both. --- www/manager/Toolkit.js | 6 ++ www/manager/Utils.js| 1 + www/manager/node/NetworkEdit.js | 39

[pve-devel] [PATCH 1/3] PVE::API2::Ceph: network_interfaces update + ipv6

2015-06-24 Thread Wolfgang Bumiller
--- PVE/API2/Ceph.pm | 14 -- 1 file changed, 8 insertions(+), 6 deletions(-) diff --git a/PVE/API2/Ceph.pm b/PVE/API2/Ceph.pm index 217b8ce..b7eea84 100644 --- a/PVE/API2/Ceph.pm +++ b/PVE/API2/Ceph.pm @@ -765,16 +765,18 @@ __PACKAGE__-register_method ({ my $find_node_ip = sub {

[pve-devel] [PATCH 2/3] PVE::API2::Network: network_interfaces update + ipv6

2015-06-24 Thread Wolfgang Bumiller
--- PVE/API2/Network.pm | 142 ++-- 1 file changed, 116 insertions(+), 26 deletions(-) diff --git a/PVE/API2/Network.pm b/PVE/API2/Network.pm index dedf9e6..83e203f 100644 --- a/PVE/API2/Network.pm +++ b/PVE/API2/Network.pm @@ -45,6 +45,11 @@ my

[pve-devel] [PATCH 01/16] JSONSchema: ipv6prefix and ipsubnet

2015-06-24 Thread Wolfgang Bumiller
ipv6prefix matches an ipv6 prefix length (0..128) ipsubnet matches an ipv4mask or an ipv6prefix --- src/PVE/JSONSchema.pm | 22 ++ 1 file changed, 22 insertions(+) diff --git a/src/PVE/JSONSchema.pm b/src/PVE/JSONSchema.pm index 36a2de9..8fa5651 100644 ---

[pve-devel] [PATCH 0/3] [manager] network interfaces internal API change

2015-06-24 Thread Wolfgang Bumiller
Changes since the [RFC PATCH]: * made network UI consistent: IPv6 addresses now show up in the same column as IPv4 addresses the same way they do in the LXC configuration. * renamed ipv6 subnet length to ipv6 prefix length Wolfgang Bumiller (3): PVE::API2::Ceph: network_interfaces update

Re: [pve-devel] RFC: qemu-server : add cloudinit support

2015-06-19 Thread Wolfgang Bumiller
to as a config drive: Must be formatted with vfat or iso9660 filesystem or have a filesystem label of config-2 so, does it need to be really labelled config-2 ? - Mail original - De: Wolfgang Bumiller w.bumil...@proxmox.com À: aderumier aderum...@odiso.com Cc: dietmar diet

Re: [pve-devel] RFC: qemu-server : add cloudinit support

2015-06-19 Thread Wolfgang Bumiller
On Fri, Jun 19, 2015 at 12:06:05PM +0200, Wolfgang Bumiller wrote: I had to change my mind there (again). If we add template support it might actually be a better idea to copy it off into /tmp and rsync it over after all. Because even if we do keep vm config changes as pending changes

Re: [pve-devel] RFC: qemu-server : add cloudinit support

2015-06-19 Thread Wolfgang Bumiller
/pve/cloud-init/132/ (of course we need to keep config in vmid.conf, pending, and generat this files when needed) - Mail original - De: dietmar diet...@proxmox.com À: Wolfgang Bumiller w.bumil...@proxmox.com, aderumier aderum...@odiso.com Cc: pve-devel pve-devel

Re: [pve-devel] RFC: qemu-server : add cloudinit support

2015-06-19 Thread Wolfgang Bumiller
Currently I can't get windows to apply my network config either way. And the installer doesn't list the network interface. It only provides me with a completely empty serial port dropdown list... But the vvfat drive shows up as regular drive with the proper label. So we'll see. I'll keep trying

[pve-devel] [RFC PATCH 1/3] PVE::API2::Ceph: network_interfaces update + ipv6

2015-06-22 Thread Wolfgang Bumiller
--- PVE/API2/Ceph.pm | 14 -- 1 file changed, 8 insertions(+), 6 deletions(-) diff --git a/PVE/API2/Ceph.pm b/PVE/API2/Ceph.pm index 217b8ce..b7eea84 100644 --- a/PVE/API2/Ceph.pm +++ b/PVE/API2/Ceph.pm @@ -765,16 +765,18 @@ __PACKAGE__-register_method ({ my $find_node_ip = sub {

[pve-devel] [RFC PATCH 3/3] www/network: ipv6 related columns and edit fields

2015-06-22 Thread Wolfgang Bumiller
--- www/manager/Toolkit.js | 6 ++ www/manager/Utils.js| 1 + www/manager/node/NetworkEdit.js | 39 +++ www/manager/node/NetworkView.js | 20 ++-- 4 files changed, 64 insertions(+), 2 deletions(-) diff --git

[pve-devel] [RFC PATCH 0/3] [manager] network interfaces internal API change

2015-06-22 Thread Wolfgang Bumiller
Emmanuel's workload with piles of patches ;-) ) Wolfgang Bumiller (3): PVE::API2::Ceph: network_interfaces update + ipv6 PVE::API2::Network: network_interfaces update + ipv6 www/network: ipv6 related columns and edit fields PVE/API2/Ceph.pm| 14 ++-- PVE/API2/Network.pm

[pve-devel] [RFC PATCH 6/7] write_etc_network_interfaces: write options only once

2015-06-22 Thread Wolfgang Bumiller
Options such as bridge ports or ovs_* will now be written out only for the first interface. If multiple protocol families of a bridge contain bridge_ports lines they will be merged into the first interface. --- src/PVE/INotify.pm | 51 --- 1 file

[pve-devel] [RFC PATCH 2/3] PVE::API2::Network: network_interfaces update + ipv6

2015-06-22 Thread Wolfgang Bumiller
--- PVE/API2/Network.pm | 142 ++-- 1 file changed, 116 insertions(+), 26 deletions(-) diff --git a/PVE/API2/Network.pm b/PVE/API2/Network.pm index dedf9e6..3ab31d3 100644 --- a/PVE/API2/Network.pm +++ b/PVE/API2/Network.pm @@ -45,6 +45,11 @@ my

[pve-devel] [RFC PATCH 6/7 resend] write_etc_network_interfaces: write options only once

2015-06-22 Thread Wolfgang Bumiller
Options such as bridge ports or ovs_* will now be written out only for the first interface. If multiple protocol families of a bridge contain bridge_ports lines they will be merged into the first interface. (Resent patch 6/7 due to for/foreach style mixup) --- src/PVE/INotify.pm | 51

[pve-devel] [RFC PATCH 1/7] JSONSchema: ipv6subnet and ipsubnet

2015-06-22 Thread Wolfgang Bumiller
ipv6subnet matches an ipv6 subnet length (0..128) ipsubnet matches an ipv4mask or an ipv6subnet --- src/PVE/JSONSchema.pm | 22 ++ 1 file changed, 22 insertions(+) diff --git a/src/PVE/JSONSchema.pm b/src/PVE/JSONSchema.pm index 36a2de9..12a209e 100644 ---

[pve-devel] [RFC PATCH 2/7] read_etc_network_interfaces: less strict parsing

2015-06-22 Thread Wolfgang Bumiller
*) Don't require indented lines, instead know when to end a section. *) Don't require empty lines between sections. And turned (.*)\s* into just (.*) as .* eats the whitespace too. --- src/PVE/INotify.pm | 22 -- 1 file changed, 16 insertions(+), 6 deletions(-) diff --git

Re: [pve-devel] Preview of the GUI with ExtJS5

2015-06-22 Thread Wolfgang Bumiller
Not so many components are working yet, but there are enough stuff which at least display so I can share a screenshot: http://i.imgur.com/y8uMXkx.png Things to notice: * fonts are a bit bigger, 13px instead of 12px. I am testing on At first glance I'd say it seems cleaner and easier to parse

[pve-devel] [RFC PATCH 4/7] read_etc_network_interfaces: improved parsing

2015-06-22 Thread Wolfgang Bumiller
* parsing ipv6 blocks * parsing extra lines like source/source-directory/... The returned config hash is not just the interface hash anymore. Interfaces are now in its 'ifaces' member hash. All unknown options (including mappings) end up in its 'options' hash. Added a comment describing the

[pve-devel] [RFC PATCH 0/7] [common] network interfaces internal API change

2015-06-22 Thread Wolfgang Bumiller
improves the file-header for /etc/network/interfaces to tell the admins that it is recommended to keep custom configurations in separate files included via source or source-directory directives. Wolfgang Bumiller (7): JSONSchema: ipv6subnet and ipsubnet read_etc_network_interfaces: less

[pve-devel] [RFC PATCH 5/7] merge bridge_port declarations

2015-06-22 Thread Wolfgang Bumiller
--- src/PVE/INotify.pm | 10 +++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/src/PVE/INotify.pm b/src/PVE/INotify.pm index c825a11..bc6c345 100644 --- a/src/PVE/INotify.pm +++ b/src/PVE/INotify.pm @@ -853,7 +853,11 @@ sub read_etc_network_interfaces {

[pve-devel] [RFC PATCH 3/7] removed write-only $gateway variable

2015-06-22 Thread Wolfgang Bumiller
--- src/PVE/INotify.pm | 7 +-- 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/src/PVE/INotify.pm b/src/PVE/INotify.pm index d97b5e3..97a379d 100644 --- a/src/PVE/INotify.pm +++ b/src/PVE/INotify.pm @@ -764,8 +764,6 @@ sub read_etc_network_interfaces { # we try to keep

[pve-devel] [RFC PATCH 7/7] write_etc_network_interfaces: updated header comment

2015-06-22 Thread Wolfgang Bumiller
The header now mentions that the file is auto-generated and should not be tempered with directly. It now recommends to add custom network configurations via source/source-directory lines. --- src/PVE/INotify.pm | 14 +- 1 file changed, 13 insertions(+), 1 deletion(-) diff --git

Re: [pve-devel] novnc update ?

2015-06-23 Thread Wolfgang Bumiller
On Tue, Jun 23, 2015 at 11:53:41AM +0200, Alexandre DERUMIER wrote: Hi, I wonder if it could be great to upgrade novnc from 0.4 to 0.5.1 ? Seeing how I've been having some unpredictable keyboard failures with noVNC I'd like to see if this makes a difference. They are a lot of dix for

[pve-devel] [PATCH v5 1/3] implement cloudinit v2

2015-06-26 Thread Wolfgang Bumiller
From: Alexandre Derumier aderum...@odiso.com Signed-off-by: Alexandre Derumier aderum...@odiso.com --- PVE/QemuServer.pm | 181 +- control.in| 2 +- 2 files changed, 179 insertions(+), 4 deletions(-) diff --git a/PVE/QemuServer.pm

[pve-devel] [PATCH v5 2/3] cloud-init changes

2015-06-26 Thread Wolfgang Bumiller
* Add ipconfigX for all netX configuration options and using ip=CIDR, gw=IP, ip6=CIDR, gw6=IP as option names like in LXC. * Adding explicit ip=dhcp and ip6=dhcp options. * Removing the config-update code and instead generating the ide3 commandline in config_to_command. - Adding a

[pve-devel] [PATCH v5 0/3] RFC: cloud-init update

2015-06-26 Thread Wolfgang Bumiller
the rest of the repositories for code affected by this change. It seemed to be all isolated in qemu-server. Please test and comment. Alexandre Derumier (1): implement cloudinit v2 Wolfgang Bumiller (2): cloud-init changes cloudinit: use qcow2 for future snapshot support PVE/API2/Qemu.pm

[pve-devel] [PATCH v5 3/3] cloudinit: use qcow2 for snapshot support

2015-06-26 Thread Wolfgang Bumiller
The config-disk is now generated into a qcow2 located on a configured storage. It is now also storage-managed and solive-migration and live-snapshotting should work as they do for regular hard drives. --- PVE/API2/Qemu.pm | 16 ++--- PVE/QemuMigrate.pm | 8 +-- PVE/QemuServer.pm

Re: [pve-devel] RFC: qemu-server : add cloudinit support

2015-06-11 Thread Wolfgang Bumiller
On Thu, Jun 11, 2015 at 12:51:42PM +0200, Alexandre DERUMIER wrote: For one, it seems to be started on several points during the init process. There seem to be 5 different systemd units specified for it even. yes, I'm seeing this 4 units. I'm think they are related to different

Re: [pve-devel] RFC: qemu-server : add cloudinit support

2015-06-15 Thread Wolfgang Bumiller
/rbd, zfs iscsi shared storage for example). I think that re-generate the configdrive on target host,with same config,should work. - Mail original - De: Wolfgang Bumiller w.bumil...@proxmox.com À: aderumier aderum...@odiso.com Cc: dietmar diet...@proxmox.com, pve-devel pve

Re: [pve-devel] RFC: qemu-server : add cloudinit support

2015-06-12 Thread Wolfgang Bumiller
On June 12, 2015 at 9:35 AM Alexandre DERUMIER aderum...@odiso.com wrote: dpkg-configure cloud-init , and choose configdrive as only datasource. I think at start, cloud-init ask to his datasources if they are a new config. Right, if you can disable this behavior then that's fine. Just need

[pve-devel] [PATCH 1/2] implement cloudinit v2

2015-06-17 Thread Wolfgang Bumiller
From: Alexandre Derumier aderum...@odiso.com Signed-off-by: Alexandre Derumier aderum...@odiso.com --- PVE/QemuServer.pm | 181 +- control.in| 2 +- 2 files changed, 179 insertions(+), 4 deletions(-) diff --git a/PVE/QemuServer.pm

[pve-devel] [PATCH 2/2] cloud-init changes

2015-06-17 Thread Wolfgang Bumiller
* Changing cidr and gatway setting names to ip, ip6, gw, gw6, as these are the names we are using for LXC. * Adding explicit ip=dhcp and ip6=dhcp options. * Removing the config-update code and instead generating the ide3 commandline in config_to_command. - Adding a conflict check to

[pve-devel] [PATCH 0/2] cloud-init v3

2015-06-17 Thread Wolfgang Bumiller
): implement cloudinit v2 Wolfgang Bumiller (1): cloud-init changes PVE/QemuServer.pm | 212 +- control.in| 2 +- 2 files changed, 210 insertions(+), 4 deletions(-) -- 2.1.4 ___ pve-devel

  1   2   3   4   5   6   7   8   9   10   >