[pve-devel] [PATCH manager v2 1/2] ceph: extend the pool view

2020-06-03 Thread Alwin Antreich
to add the pg_autoscale_mode since its activated in Ceph Octopus by default and emmits a waring (ceph status) if a pool has too many PGs. Signed-off-by: Alwin Antreich --- v1 -> v2: split addition of pg_autoscale_mode and pveceph pool output format PVE/API2/Ceph.pm |

[pve-devel] [PATCH manager v2 2/2] ceph: extend pveceph pool ls

2020-06-03 Thread Alwin Antreich
to present more data on pools and a nicer formated output on the command line. Signed-off-by: Alwin Antreich --- PVE/API2/Ceph.pm | 14 ++ PVE/CLI/pveceph.pm | 24 ++-- 2 files changed, 24 insertions(+), 14 deletions(-) diff --git a/PVE/API2/Ceph.pm b/PVE/API2

[pve-devel] [PATCH manager v2] Make PVE6 compatible with supported ceph versions

2020-06-03 Thread Alwin Antreich
Luminous, Nautilus and Octopus. In Octopus the mon_status was dropped. Also the ceph status was cleaned up and doesn't provide the mgrmap and monmap. The rados queries used in the ceph status API endpoints (cluster / node) were factored out and merged to one place. Signed-off-by: Alwin Ant

Re: [pve-devel] [PATCH manager 2/2] error message on failed config dump command

2020-06-02 Thread Alwin Antreich
On Tue, Jun 02, 2020 at 02:05:26PM +0200, Thomas Lamprecht wrote: > On 5/28/20 4:41 PM, Alwin Antreich wrote: > > Prior Ceph Nautilus the ceph config dump command was not available. > > This patch provides a more meaningful info for the user. > > > > what is the ver

[pve-devel] [PATCH manager] ceph: extend the pool view

2020-05-29 Thread Alwin Antreich
to add the pg_autoscale_mode since its activated in Ceph Octopus by default and emmits a waring (ceph status) if a pool has too many PGs. Also present a nicer formated output on the command line. Signed-off-by: Alwin Antreich --- PVE/API2/Ceph.pm | 25 + PVE/CLI

[pve-devel] [PATCH manager 2/2] error message on failed config dump command

2020-05-28 Thread Alwin Antreich
Prior Ceph Nautilus the ceph config dump command was not available. This patch provides a more meaningful info for the user. Signed-off-by: Alwin Antreich --- PVE/API2/Ceph.pm | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/PVE/API2/Ceph.pm b/PVE/API2/Ceph.pm index

[pve-devel] [PATCH manager 1/2] Make PVE6 compatible with supported ceph versions

2020-05-28 Thread Alwin Antreich
Luminous, Nautilus and Octopus. In Octopus the mon_status was dropped. Also the ceph status was cleaned up and doesn't provide the mgrmap and monmap. The rados queries used in the ceph status API endpoints (cluster / node) were factored out and merged to one place. Signed-off-by: Alwin Ant

[pve-devel] [PATCH storage] Fix #2737: Can't call method "mode"

2020-05-13 Thread Alwin Antreich
on an undefined value at /usr/share/perl5/PVE/Storage/Plugin.pm line 928 This error message crops up when a file is deleted after getting the file list and before the loop passed the file entry. Signed-off-by: Alwin Antreich --- PVE/Storage/Plugin.pm | 2 +- 1 file changed, 1 insertion(+), 1

[pve-devel] [PATCH storage] Fix: backup: relax file name matching regex

2020-05-12 Thread Alwin Antreich
The rework of the backup file detection logic missed the non-standard file name case. This patch allows to restore backups with different file names. Though the config extraction fails, since the type is unknown. Signed-off-by: Alwin Antreich --- Note: This fixes the issue reported on the forum

[pve-devel] [PATCH i18n] update German translation

2020-05-08 Thread Alwin Antreich
Signed-off-by: Alwin Antreich --- de.po | 80 +-- 1 file changed, 39 insertions(+), 41 deletions(-) diff --git a/de.po b/de.po index babde6d..82722fc 100644 --- a/de.po +++ b/de.po @@ -460,7 +460,7 @@ msgstr "Base DN für Gruppen"

[pve-devel] [PATCH v3 docs] add section about backup compression algorithms

2020-05-07 Thread Alwin Antreich
as a short description about the different algorithms in use by vzdump. Signed-off-by: Alwin Antreich --- v1 -> v2: * add Aaron's suggestions v2 -> v3: * remove 'And' on sentence beginning, as Aaron's preference, ;) otherwise the sam

[pve-devel] [PATCH v2 docs] add section about backup compression algorithms

2020-05-07 Thread Alwin Antreich
as a short description about the different algorithms in use by vzdump. Signed-off-by: Alwin Antreich --- v1 -> v2: * incorporate Aaron's suggestions https://pve.proxmox.com/pipermail/pve-devel/2020-May/043481.html vzdump.adoc | 35 ++- 1 file

[pve-devel] [PATCH docs] add section about backup compression algorithms

2020-05-07 Thread Alwin Antreich
as a short description about the different algorithms in use by vzdump. Signed-off-by: Alwin Antreich --- vzdump.adoc | 36 +++- 1 file changed, 35 insertions(+), 1 deletion(-) diff --git a/vzdump.adoc b/vzdump.adoc index 404ad09..3fd9ca9 100644 --- a

[pve-devel] [PATCH manager v2] Fix #1210: ceph: extend pveceph purge

2020-05-05 Thread Alwin Antreich
to clean service directories as well as disable and stop Ceph services. Addtionally provide the option to remove crash and log information. This patch is also in addtion to #2607, as the current cleanup doesn't allow to re-configure Ceph, without manual steps during purge. Signed-off-by:

[pve-devel] [PATCH manager] ceph: extend pveceph purge

2020-05-03 Thread Alwin Antreich
to clean service directories as well as disable and stop Ceph services. Addtionally provide the option to remove crash and log information. This patch is in addtion to #2607, as the current cleanup doesn't allow to re-configure Ceph, without manual steps during purge. Signed-off-by:

Re: [pve-devel] [PATCH docs] add documenation for ldap syncing

2020-04-30 Thread Alwin Antreich
My suggestions inline. On Thu, Apr 30, 2020 at 01:14:27PM +0200, Dominik Csapak wrote: > explaining the main Requirements and limitations, as well as the > most important sync options > > Signed-off-by: Dominik Csapak > --- > pveum.adoc | 47 +++ > 1

[pve-devel] [PATCH storage v5 04/12] test: list_volumes

2020-04-28 Thread Alwin Antreich
Test to reduce the potential for accidental breakage on regex changes. Co-Authored-by: Dominic Jaeger Signed-off-by: Alwin Antreich --- test/list_volumes_test.pm | 519 ++ test/run_plugin_tests.pl | 6 +- 2 files changed, 524 insertions(+), 1 deletion

[pve-devel] [PATCH storage v5 12/12] test: filesystem_path

2020-04-28 Thread Alwin Antreich
Signed-off-by: Alwin Antreich --- test/filesystem_path_test.pm | 91 test/run_plugin_tests.pl | 1 + 2 files changed, 92 insertions(+) create mode 100644 test/filesystem_path_test.pm diff --git a/test/filesystem_path_test.pm b/test

[pve-devel] [PATCH storage v5 06/12] test: path_to_volume_id

2020-04-28 Thread Alwin Antreich
Test to reduce the potential for accidental breakage on regex changes. Signed-off-by: Alwin Antreich --- test/path_to_volume_id_test.pm | 242 + test/run_plugin_tests.pl | 2 +- 2 files changed, 243 insertions(+), 1 deletion(-) create mode 100644 test

[pve-devel] [PATCH storage v5 10/12] Fix: #2124 storage: add zstd support

2020-04-28 Thread Alwin Antreich
Signed-off-by: Alwin Antreich --- PVE/Storage.pm | 4 +++- PVE/Storage/Plugin.pm | 2 +- test/archive_info_test.pm | 4 +++- test/list_volumes_test.pm | 18 ++ test/parse_volname_test.pm | 6 +++--- test/path_to_volume_id_test.pm | 16

[pve-devel] [PATCH storage v5 07/12] Fix: path_to_volume_id returned wrong content

2020-04-28 Thread Alwin Antreich
type for backup files. Patch includes changes of the test as well. Signed-off-by: Alwin Antreich --- PVE/Storage.pm | 2 +- test/path_to_volume_id_test.pm | 8 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/PVE/Storage.pm b/PVE/Storage.pm index bdd6ebc

[pve-devel] [PATCH storage v5 09/12] backup: compact regex for backup file filter

2020-04-28 Thread Alwin Antreich
the more compact form of the regex should allow easier addition of new file extensions. Signed-off-by: Alwin Antreich --- PVE/Storage.pm| 4 ++-- PVE/Storage/Plugin.pm | 6 -- 2 files changed, 6 insertions(+), 4 deletions(-) diff --git a/PVE/Storage.pm b/PVE/Storage.pm index

[pve-devel] [PATCH qemu-server v5 1/2] restore: replace archive format/compression

2020-04-28 Thread Alwin Antreich
regex to reduce the code duplication, as archive_info and decompressor_info provides the same information as well. Signed-off-by: Alwin Antreich --- PVE/QemuServer.pm | 36 ++-- 1 file changed, 6 insertions(+), 30 deletions(-) diff --git a/PVE/QemuServer.pm b

[pve-devel] [PATCH storage v5 03/12] test: parse_volname

2020-04-28 Thread Alwin Antreich
Test to reduce the potential for accidental breakage on regex changes. And to make sure that all vtype_subdirs are parsed. Signed-off-by: Alwin Antreich --- PVE/Storage/Plugin.pm | 4 + test/parse_volname_test.pm | 253 + test/run_plugin_tests.pl

[pve-devel] [PATCH storage v5 05/12] Fix: backup: ctime was from stat not file name

2020-04-28 Thread Alwin Antreich
igned-off-by: Alwin Antreich --- PVE/Storage/Plugin.pm | 3 ++- test/list_volumes_test.pm | 16 2 files changed, 10 insertions(+), 9 deletions(-) diff --git a/PVE/Storage/Plugin.pm b/PVE/Storage/Plugin.pm index 0925910..a6071eb 100644 --- a/PVE/Storage/Plugin.pm +++ b/PVE/St

[pve-devel] [PATCH storage v5 11/12] test: get_subdir

2020-04-28 Thread Alwin Antreich
Co-Authored-by: Dominic Jaeger Signed-off-by: Alwin Antreich --- test/get_subdir_test.pm | 44 test/run_plugin_tests.pl | 1 + 2 files changed, 45 insertions(+) create mode 100644 test/get_subdir_test.pm diff --git a/test/get_subdir_test.pm b/test

[pve-devel] [PATCH storage v5 02/12] storage: replace build-in stat occurrences

2020-04-28 Thread Alwin Antreich
with File::stat::stat to minimize variable declarations. And allow to mock this method in tests instead of the perl build-in stat. Signed-off-by: Alwin Antreich --- PVE/Diskmanage.pm | 9 + PVE/Storage/Plugin.pm | 34 ++ 2 files changed, 15

[pve-devel] [PATCH qemu-server v5 2/2] Fix #2124: Add support for zstd

2020-04-28 Thread Alwin Antreich
Signed-off-by: Alwin Antreich --- PVE/QemuServer.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/PVE/QemuServer.pm b/PVE/QemuServer.pm index 265d4f8..fda1acb 100644 --- a/PVE/QemuServer.pm +++ b/PVE/QemuServer.pm @@ -7165,7 +7165,7 @@ sub complete_backup_archives { my

[pve-devel] [PATCH storage v5 08/12] Fix: add missing snippets subdir

2020-04-28 Thread Alwin Antreich
since it is a valid content type and adapt the path_to_volume_id_test. Also adds an extra check if all vtype_subdirs are returned. Signed-off-by: Alwin Antreich --- PVE/Storage.pm | 4 test/path_to_volume_id_test.pm | 26 +- 2 files changed, 25

[pve-devel] [PATCH storage v5 01/12] storage: test: split archive format/compressor

2020-04-28 Thread Alwin Antreich
detection into separate functions so they are reusable and easier modifiable. This patch also adds the test for archive_info. Signed-off-by: Alwin Antreich --- test/Makefile | 5 +- PVE/Storage.pm| 79 +--- test/archive_info_test.pm | 125

[pve-devel] [PATCH manager v5] Fix #2124: Add support for zstd

2020-04-28 Thread Alwin Antreich
This patch adds the zstd to the compression selection for backup on the GUI and add .zst to the backup file filter. Including zstd as package install dependency. Signed-off-by: Alwin Antreich --- PVE/VZDump.pm| 11 +-- debian/control

[pve-devel] [PATCH container v5] Fix: #2124 add zstd

2020-04-28 Thread Alwin Antreich
Signed-off-by: Alwin Antreich --- src/PVE/LXC/Create.pm | 1 + 1 file changed, 1 insertion(+) diff --git a/src/PVE/LXC/Create.pm b/src/PVE/LXC/Create.pm index 52b0b48..39902a2 100644 --- a/src/PVE/LXC/Create.pm +++ b/src/PVE/LXC/Create.pm @@ -123,6 +123,7 @@ sub restore_tar_archive

[pve-devel] [PATCH storage v5 00/17] Fix: #2124 zstd

2020-04-28 Thread Alwin Antreich
in advance. [0] https://facebook.github.io/zstd/ Alwin Antreich (17): __pve-storage__ storage: test: split archive format/compressor storage: replace build-in stat with File::stat test: parse_volname test: list_volumes Fix: backup: ctime was from stat not file name test: path_to_volume_id

[pve-devel] [PATCH guest-common v5] Fix: #2124 add zstd support

2020-04-28 Thread Alwin Antreich
Signed-off-by: Alwin Antreich --- PVE/VZDump/Common.pm | 9 - 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/PVE/VZDump/Common.pm b/PVE/VZDump/Common.pm index 4789a50..909e3af 100644 --- a/PVE/VZDump/Common.pm +++ b/PVE/VZDump/Common.pm @@ -88,7 +88,7 @@ my $confdesc

[pve-devel] [PATCH storage] Fix #2705: cephfs: mount fails with bad option

2020-04-24 Thread Alwin Antreich
unt.ceph helper. Signed-off-by: Alwin Antreich --- PVE/CephConfig.pm | 29 + PVE/Storage/CephFSPlugin.pm | 6 +- PVE/Storage/RBDPlugin.pm| 31 +-- 3 files changed, 35 insertions(+), 31 deletions(-) diff --git a/PVE/Ceph

Re: [pve-devel] [PATCH storage v4 00/12] Fix: #2124 zstd

2020-04-23 Thread Alwin Antreich
ps in the GUI with the new option, > too. Thanks for testing. > > Tested-by: Dominic Jäger > > On Wed, Apr 22, 2020 at 04:57:51PM +0200, Alwin Antreich wrote: > > Zstandard (zstd) [0] is a data compression algorithm, in addition to > > gzip, lzo for our backup/r

Re: [pve-devel] [PATCH storage v4 02/12] storage: replace build-in stat with File::stat

2020-04-23 Thread Alwin Antreich
On Thu, Apr 23, 2020 at 05:52:29AM +0200, Dietmar Maurer wrote: > > On April 22, 2020 6:00 PM Alwin Antreich wrote: > > > > > > On Wed, Apr 22, 2020 at 05:35:05PM +0200, Dietmar Maurer wrote: > > > AFAIK this can have ugly side effects ... > > Okay, I

Re: [pve-devel] [PATCH storage v4 02/12] storage: replace build-in stat with File::stat

2020-04-22 Thread Alwin Antreich
and Fabian G. If there is a better solution, I am happy to work on it. > > > On April 22, 2020 4:57 PM Alwin Antreich wrote: > > > > > > to minimize variable declarations. And allow to mock this method in > > tests instead of the perl build-in stat. &g

[pve-devel] [PATCH container v4] Fix: #2124 add zstd

2020-04-22 Thread Alwin Antreich
Signed-off-by: Alwin Antreich --- src/PVE/LXC/Create.pm | 1 + 1 file changed, 1 insertion(+) diff --git a/src/PVE/LXC/Create.pm b/src/PVE/LXC/Create.pm index 52b0b48..39902a2 100644 --- a/src/PVE/LXC/Create.pm +++ b/src/PVE/LXC/Create.pm @@ -123,6 +123,7 @@ sub restore_tar_archive

[pve-devel] [PATCH storage v4 00/12] Fix: #2124 zstd

2020-04-22 Thread Alwin Antreich
container restores Thanks for any comment or suggestion in advance. [0] https://facebook.github.io/zstd/ Alwin Antreich (12): __pve-storage__ storage: test: split archive format/compressor storage: replace build-in stat with File::stat test: parse_volname test: list_volumes Fix: backup:

[pve-devel] [PATCH storage v4 05/12] Fix: backup: ctime was from stat not file name

2020-04-22 Thread Alwin Antreich
igned-off-by: Alwin Antreich --- PVE/Storage/Plugin.pm | 3 ++- test/list_volumes_test.pm | 16 2 files changed, 10 insertions(+), 9 deletions(-) diff --git a/PVE/Storage/Plugin.pm b/PVE/Storage/Plugin.pm index 71a83f7..9dde46e 100644 --- a/PVE/Storage/Plugin.pm +++ b/PVE/St

[pve-devel] [PATCH storage v4 06/12] test: path_to_volume_id

2020-04-22 Thread Alwin Antreich
Test to reduce the potential for accidental breakage on regex changes. Signed-off-by: Alwin Antreich --- test/path_to_volume_id_test.pm | 242 + test/run_plugin_tests.pl | 2 +- 2 files changed, 243 insertions(+), 1 deletion(-) create mode 100644 test

[pve-devel] [PATCH storage v4 04/12] test: list_volumes

2020-04-22 Thread Alwin Antreich
Test to reduce the potential for accidental breakage on regex changes. Co-Authored-by: Dominic Jaeger Signed-off-by: Alwin Antreich --- test/list_volumes_test.pm | 519 ++ test/run_plugin_tests.pl | 6 +- 2 files changed, 524 insertions(+), 1 deletion

[pve-devel] [PATCH storage v4 12/12] test: filesystem_path

2020-04-22 Thread Alwin Antreich
Signed-off-by: Alwin Antreich --- test/filesystem_path_test.pm | 91 test/run_plugin_tests.pl | 1 + 2 files changed, 92 insertions(+) create mode 100644 test/filesystem_path_test.pm diff --git a/test/filesystem_path_test.pm b/test

[pve-devel] [PATCH storage v4 11/12] test: get_subdir

2020-04-22 Thread Alwin Antreich
Co-Authored-by: Dominic Jaeger Signed-off-by: Alwin Antreich --- test/get_subdir_test.pm | 44 test/run_plugin_tests.pl | 1 + 2 files changed, 45 insertions(+) create mode 100644 test/get_subdir_test.pm diff --git a/test/get_subdir_test.pm b/test

[pve-devel] [PATCH storage v4 10/12] Fix: #2124 storage: add zstd support

2020-04-22 Thread Alwin Antreich
Signed-off-by: Alwin Antreich --- PVE/Storage.pm | 4 +++- PVE/Storage/Plugin.pm | 2 +- test/archive_info_test.pm | 4 +++- test/list_volumes_test.pm | 18 ++ test/parse_volname_test.pm | 6 +++--- test/path_to_volume_id_test.pm | 16

[pve-devel] [PATCH qemu-server v4 2/2] Fix #2124: Add support for zstd

2020-04-22 Thread Alwin Antreich
Signed-off-by: Alwin Antreich --- PVE/QemuServer.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/PVE/QemuServer.pm b/PVE/QemuServer.pm index 265d4f8..fda1acb 100644 --- a/PVE/QemuServer.pm +++ b/PVE/QemuServer.pm @@ -7165,7 +7165,7 @@ sub complete_backup_archives { my

[pve-devel] [PATCH storage v4 03/12] test: parse_volname

2020-04-22 Thread Alwin Antreich
Test to reduce the potential for accidental breakage on regex changes. And to make sure that all vtype_subdirs are parsed. Signed-off-by: Alwin Antreich --- PVE/Storage/Plugin.pm | 4 + test/parse_volname_test.pm | 253 + test/run_plugin_tests.pl

[pve-devel] [PATCH storage v4 08/12] Fix: add missing snippets subdir

2020-04-22 Thread Alwin Antreich
since it is a valid content type and adapt the path_to_volume_id_test. Also adds an extra check if all vtype_subdirs are returned. Signed-off-by: Alwin Antreich --- PVE/Storage.pm | 4 test/path_to_volume_id_test.pm | 26 +- 2 files changed, 25

[pve-devel] [PATCH storage v4 01/12] storage: test: split archive format/compressor

2020-04-22 Thread Alwin Antreich
detection into separate functions so they are reusable and easier modifiable. This patch also adds the test for archive_info. Signed-off-by: Alwin Antreich --- test/Makefile | 5 +- PVE/Storage.pm| 79 +--- test/archive_info_test.pm | 125

[pve-devel] [PATCH storage v4 07/12] Fix: path_to_volume_id returned wrong content

2020-04-22 Thread Alwin Antreich
type for backup files. Patch includes changes of the test as well. Signed-off-by: Alwin Antreich --- PVE/Storage.pm | 2 +- test/path_to_volume_id_test.pm | 8 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/PVE/Storage.pm b/PVE/Storage.pm index bdd6ebc

[pve-devel] [PATCH storage v4 09/12] backup: compact regex for backup file filter

2020-04-22 Thread Alwin Antreich
the more compact form of the regex should allow easier addition of new file extensions. Signed-off-by: Alwin Antreich --- PVE/Storage.pm| 4 ++-- PVE/Storage/Plugin.pm | 6 -- 2 files changed, 6 insertions(+), 4 deletions(-) diff --git a/PVE/Storage.pm b/PVE/Storage.pm index

[pve-devel] [PATCH manager v4] Fix #2124: Add support for zstd

2020-04-22 Thread Alwin Antreich
This patch adds the zstd to the compression selection for backup on the GUI and add .zst to the backup file filter. Including zstd as package install dependency. Signed-off-by: Alwin Antreich --- PVE/VZDump.pm| 11 +-- debian/control

[pve-devel] [PATCH storage v4 02/12] storage: replace build-in stat with File::stat

2020-04-22 Thread Alwin Antreich
to minimize variable declarations. And allow to mock this method in tests instead of the perl build-in stat. Signed-off-by: Alwin Antreich --- PVE/Diskmanage.pm | 9 + PVE/Storage/Plugin.pm | 34 ++ 2 files changed, 15 insertions(+), 28 deletions

[pve-devel] [PATCH qemu-server v4 1/2] restore: replace archive format/compression

2020-04-22 Thread Alwin Antreich
regex to reduce the code duplication, as archive_info and decompressor_info provides the same information as well. Signed-off-by: Alwin Antreich --- PVE/QemuServer.pm | 36 ++-- 1 file changed, 6 insertions(+), 30 deletions(-) diff --git a/PVE/QemuServer.pm b

[pve-devel] [PATCH guest-common v4] Fix: #2124 add zstd support

2020-04-22 Thread Alwin Antreich
Signed-off-by: Alwin Antreich --- PVE/VZDump/Common.pm | 9 - 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/PVE/VZDump/Common.pm b/PVE/VZDump/Common.pm index 4789a50..909e3af 100644 --- a/PVE/VZDump/Common.pm +++ b/PVE/VZDump/Common.pm @@ -88,7 +88,7 @@ my $confdesc

Re: [pve-devel] [PATCH v3 0/13] Fix: #2124 zstd

2020-04-09 Thread Alwin Antreich
On Thu, Apr 09, 2020 at 02:29:46PM +0200, Fabian Ebner wrote: > Hi, > series looks mostly good to me. Some comments on individual patches. > Backup/restore seems to work, also still with the other compression formats. > The tests for path_to_volume_id actually uncover a bug and a missing feature >

Re: [pve-devel] [PATCH storage v3 5/7] test: path_to_volume_id

2020-04-09 Thread Alwin Antreich
On Thu, Apr 09, 2020 at 02:20:36PM +0200, Fabian Ebner wrote: > Two comments inline. > > On 08.04.20 12:26, Alwin Antreich wrote: > > Test to reduce the potential for accidental breakage on regex changes. > > > > Signed-off-by: Alwin Antreich > > --- > >

Re: [pve-devel] [PATCH storage 1/4] base plugin: Increase test coverage

2020-04-09 Thread Alwin Antreich
On Thu, Apr 02, 2020 at 01:34:11PM +0200, Dominic Jäger wrote: > Signed-off-by: Dominic Jäger > --- > This did not exist separately in RFC > > test/Makefile| 5 +- > test/run_plugin_tests.pl | 184 +++ > 2 files changed, 188 insertions(+), 1 dele

[pve-devel] [PATCH storage v3 7/7] Fix: #2124 storage: add zstd support

2020-04-08 Thread Alwin Antreich
Signed-off-by: Alwin Antreich --- PVE/Storage.pm | 4 +++- PVE/Storage/Plugin.pm | 2 +- test/test_archive_info.pm | 9 ++--- test/test_list_volumes.pm | 4 test/test_parse_volname.pm | 3 +++ test/test_path_to_volume_id.pm | 2 ++ 6 files changed

[pve-devel] [PATCH qemu-server v3 1/2] restore: replace archive

2020-04-08 Thread Alwin Antreich
format/compression regex to reduce the code duplication, as archive_info and decompressor_info provides the same information as well. Signed-off-by: Alwin Antreich --- PVE/QemuServer.pm | 36 ++-- 1 file changed, 6 insertions(+), 30 deletions(-) diff --git a/PVE

[pve-devel] [PATCH storage v3 6/7] backup: more compact regex for backup filter

2020-04-08 Thread Alwin Antreich
The more compact form of the regex should allow easier addition of new file extensions. Signed-off-by: Alwin Antreich --- PVE/Storage.pm| 4 ++-- PVE/Storage/Plugin.pm | 6 -- 2 files changed, 6 insertions(+), 4 deletions(-) diff --git a/PVE/Storage.pm b/PVE/Storage.pm index

[pve-devel] [PATCH guest-common v3] Fix: #2124 add zstd support

2020-04-08 Thread Alwin Antreich
Signed-off-by: Alwin Antreich --- PVE/VZDump/Common.pm | 9 - 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/PVE/VZDump/Common.pm b/PVE/VZDump/Common.pm index 4789a50..9a7c4f6 100644 --- a/PVE/VZDump/Common.pm +++ b/PVE/VZDump/Common.pm @@ -88,7 +88,7 @@ my $confdesc

[pve-devel] [PATCH storage v3 5/7] test: path_to_volume_id

2020-04-08 Thread Alwin Antreich
Test to reduce the potential for accidental breakage on regex changes. Signed-off-by: Alwin Antreich --- test/run_parser_tests.pl | 2 +- test/test_path_to_volume_id.pm | 102 + 2 files changed, 103 insertions(+), 1 deletion(-) create mode 100644 test

[pve-devel] [PATCH storage v3 3/7] test: list_volumes

2020-04-08 Thread Alwin Antreich
Test to reduce the potential for accidental breakage on regex changes. Signed-off-by: Alwin Antreich --- test/run_parser_tests.pl | 6 +- test/test_list_volumes.pm | 309 ++ 2 files changed, 314 insertions(+), 1 deletion(-) create mode 100644 test

[pve-devel] [PATCH v3 0/13] Fix: #2124 zstd

2020-04-08 Thread Alwin Antreich
d * made the regex pattern of backup files more compact, easier to read (hopefully) * less code changes for container restores Thanks for any comment or suggestion in advance. [0] https://facebook.github.io/zstd/ Alwin Antreich (13): __pve-storage__ storage: test: split archive f

[pve-devel] [PATCH manager v3] Fix #2124: Add support for zstd

2020-04-08 Thread Alwin Antreich
This patch adds zstd to the compression selection for backup on the GUI and add .zst to the backup file filter. Including zstd as package install dependency. Signed-off-by: Alwin Antreich --- PVE/VZDump.pm| 11 +-- debian/control

[pve-devel] [PATCH storage v3 4/7] Fix: backup: ctime taken from stat

2020-04-08 Thread Alwin Antreich
ackup was made. Signed-off-by: Alwin Antreich --- PVE/Storage/Plugin.pm | 3 ++- test/test_list_volumes.pm | 16 2 files changed, 10 insertions(+), 9 deletions(-) diff --git a/PVE/Storage/Plugin.pm b/PVE/Storage/Plugin.pm index 8c0dae1..0ab44ce 100644 --- a/PVE/Storage/Plug

[pve-devel] [PATCH qemu-server v3 2/2] Fix #2124: Add support for zstd

2020-04-08 Thread Alwin Antreich
Signed-off-by: Alwin Antreich --- PVE/QemuServer.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/PVE/QemuServer.pm b/PVE/QemuServer.pm index e5bf41b..c72ddf4 100644 --- a/PVE/QemuServer.pm +++ b/PVE/QemuServer.pm @@ -7039,7 +7039,7 @@ sub complete_backup_archives { my

[pve-devel] [PATCH storage v3 2/7] test: parse_volname

2020-04-08 Thread Alwin Antreich
Test to reduce the potential for accidental breakage on regex changes. Signed-off-by: Alwin Antreich --- test/run_parser_tests.pl | 2 +- test/test_parse_volname.pm | 95 ++ 2 files changed, 96 insertions(+), 1 deletion(-) create mode 100644 test

[pve-devel] [PATCH storage v3 1/7] storage: test: split archive format/compressor

2020-04-08 Thread Alwin Antreich
detection into separate functions so they are reusable and easier modifiable. Signed-off-by: Alwin Antreich --- test/Makefile | 5 ++- PVE/Storage.pm| 79 --- test/run_parser_tests.pl | 12 ++ test/test_archive_info.pm | 54

[pve-devel] [PATCH container v3] Fix: #2124 add zstd

2020-04-08 Thread Alwin Antreich
Signed-off-by: Alwin Antreich --- src/PVE/LXC/Create.pm | 1 + 1 file changed, 1 insertion(+) diff --git a/src/PVE/LXC/Create.pm b/src/PVE/LXC/Create.pm index 9faec63..91904b6 100644 --- a/src/PVE/LXC/Create.pm +++ b/src/PVE/LXC/Create.pm @@ -123,6 +123,7 @@ sub restore_tar_archive

Re: [pve-devel] [PATCH qemu-server 2/2] Die on misaligned memory for hotplugging

2020-03-19 Thread Alwin Antreich
On Wed, Mar 18, 2020 at 04:18:45PM +0100, Stefan Reiter wrote: > ...instead of booting with an invalid config once and then silently > changing the memory size for consequent VM starts. > > Signed-off-by: Stefan Reiter > --- Tested-by: Alwin Antreich > > This confused

Re: [pve-devel] [PATCH qemu-server 1/2] Disable memory hotplugging for custom NUMA topologies

2020-03-19 Thread Alwin Antreich
here, since it otherwise fails early with "total > memory for NUMA nodes must be equal to vm static memory". > > With this change the error message reflects what is actually happening > and doesn't allow VMs with exactly 1GB of RAM either. > > Signed-off-by: Stef

[pve-devel] [PATCH manager 1/3] ceph: remove unused variable assignment

2020-03-11 Thread Alwin Antreich
Signed-off-by: Alwin Antreich --- PVE/Ceph/Services.pm | 1 - 1 file changed, 1 deletion(-) diff --git a/PVE/Ceph/Services.pm b/PVE/Ceph/Services.pm index c17008cf..7015cafe 100644 --- a/PVE/Ceph/Services.pm +++ b/PVE/Ceph/Services.pm @@ -63,7 +63,6 @@ sub get_cluster_service { sub

[pve-devel] [PATCH manager 3/3] Fix #2422: allow multiple Ceph public networks

2020-03-11 Thread Alwin Antreich
Multiple public networks can be defined in the ceph.conf. The networks need to be routed to each other. On first service start the Ceph MON will register itself with one of the IPs configured locally, matching one of the public networks defined in the ceph.conf. Signed-off-by: Alwin Antreich

[pve-devel] [PATCH manager 2/3] Fix: ceph: mon_address not considered by new MON

2020-03-11 Thread Alwin Antreich
- public_network is in the ceph.conf * with a single network, take the first available IP * on multiple networks, walk through the list orderly and start on the first network where an IP is found Signed-off-by: Alwin Antreich --- PVE/API2/Ceph/MON.pm | 9 +++-- 1 file changed, 3

[pve-devel] [PATCH docs] pveceph: reword memory precondition

2020-02-17 Thread Alwin Antreich
and add the memory target for OSDs, included since Luminous. As well as distinguish the memory usage between the OSD backends. Signed-off-by: Alwin Antreich --- pveceph.adoc | 13 ++--- 1 file changed, 10 insertions(+), 3 deletions(-) diff --git a/pveceph.adoc b/pveceph.adoc index

Re: [pve-devel] [PATCH pve-guest-common 1/1] vzdump: added "includename" option

2020-02-05 Thread Alwin Antreich
On Thu, Nov 14, 2019 at 03:01:37PM +0100, Thomas Lamprecht wrote: > On 11/14/19 6:30 AM, Dietmar Maurer wrote: > >> The main reason for this is to identify backups residing on an old backup > >> store like an archive. > >> > >> But I am open. Would you prefer having a manifest included in the ar

Re: [pve-devel] [PATCH manager v2 1/2] Fix #2124: Add support for zstd

2020-02-04 Thread Alwin Antreich
On Mon, Feb 03, 2020 at 05:51:38PM +0100, Stefan Reiter wrote: > On 1/31/20 5:00 PM, Alwin Antreich wrote: > > Adds the zstd to the compression selection for backup on the GUI and the > > .zst extension to the backup file filter. > > > > Signed-off-by: Alwin Antre

[pve-devel] [PATCH manager v2 2/2] Fix #2124: Add zstd pkg as install dependency

2020-01-31 Thread Alwin Antreich
Signed-off-by: Alwin Antreich --- debian/control | 1 + 1 file changed, 1 insertion(+) diff --git a/debian/control b/debian/control index bcc6bb6e..497395da 100644 --- a/debian/control +++ b/debian/control @@ -60,6 +60,7 @@ Depends: apt-transport-https | apt (>= 1.5~), logrot

[pve-devel] [PATCH qemu-server v2 1/2] restore: replace archive regex

2020-01-31 Thread Alwin Antreich
to reduce the code duplication, as archive_info provides the same information as well. Signed-off-by: Alwin Antreich --- PVE/QemuServer.pm | 36 ++-- 1 file changed, 6 insertions(+), 30 deletions(-) diff --git a/PVE/QemuServer.pm b/PVE/QemuServer.pm index

[pve-devel] [PATCH qemu-server v2 2/2] Fix #2124: Add support for zstd

2020-01-31 Thread Alwin Antreich
Signed-off-by: Alwin Antreich --- PVE/QemuServer.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/PVE/QemuServer.pm b/PVE/QemuServer.pm index ff7dcab..8af1cb6 100644 --- a/PVE/QemuServer.pm +++ b/PVE/QemuServer.pm @@ -7217,7 +7217,7 @@ sub complete_backup_archives { my

[pve-devel] [PATCH manager v2 1/2] Fix #2124: Add support for zstd

2020-01-31 Thread Alwin Antreich
Adds the zstd to the compression selection for backup on the GUI and the .zst extension to the backup file filter. Signed-off-by: Alwin Antreich --- PVE/VZDump.pm| 6 -- www/manager6/form/CompressionSelector.js | 3 ++- 2 files changed, 6 insertions(+), 3

[pve-devel] [PATCH storage v2 1/3] compact regex for backup file filter

2020-01-31 Thread Alwin Antreich
this, more compact form of the regex should allow easier addition of new file extensions. Signed-off-by: Alwin Antreich --- PVE/Storage.pm| 2 +- PVE/Storage/Plugin.pm | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/PVE/Storage.pm b/PVE/Storage.pm index 0bd103e

[pve-devel] [PATCH guest-common v2] Fix: #2124 add zstd support

2020-01-31 Thread Alwin Antreich
Signed-off-by: Alwin Antreich --- PVE/VZDump/Common.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/PVE/VZDump/Common.pm b/PVE/VZDump/Common.pm index 4789a50..a661552 100644 --- a/PVE/VZDump/Common.pm +++ b/PVE/VZDump/Common.pm @@ -88,7 +88,7 @@ my $confdesc

[pve-devel] [PATCH storage v2 2/3] storage: merge archive format/compressor

2020-01-31 Thread Alwin Antreich
detection into a separate function to reduce code duplication and allow for easier modification. Signed-off-by: Alwin Antreich --- PVE/Storage.pm | 78 -- 1 file changed, 57 insertions(+), 21 deletions(-) diff --git a/PVE/Storage.pm b/PVE

[pve-devel] [PATCH storage v2 3/3] Fix: #2124 storage: add zstd support

2020-01-31 Thread Alwin Antreich
Signed-off-by: Alwin Antreich --- PVE/Storage.pm| 10 +++--- PVE/Storage/Plugin.pm | 4 ++-- 2 files changed, 9 insertions(+), 5 deletions(-) diff --git a/PVE/Storage.pm b/PVE/Storage.pm index bf12634..51c8bc9 100755 --- a/PVE/Storage.pm +++ b/PVE/Storage.pm @@ -514,7 +514,7 @@ sub

[pve-devel] [PATCH container v2] Fix #2124: Add support for zstd

2020-01-31 Thread Alwin Antreich
kup files more compact, easier to read (hopefully) * less code changes for container restores Thanks for any comment or suggestion in advance. [0] https://facebook.github.io/zstd/ __pve-container__ Alwin Antreich (1): Fix: #2124 add zstd support src/PVE/LXC/Create.pm | 1 + 1 f

[pve-devel] [PATCH container v2] Fix: #2124 add zstd support

2020-01-31 Thread Alwin Antreich
Signed-off-by: Alwin Antreich --- v1 -> v2: less code changes for container restores src/PVE/LXC/Create.pm | 1 + 1 file changed, 1 insertion(+) diff --git a/src/PVE/LXC/Create.pm b/src/PVE/LXC/Create.pm index c13f30d..65d5068 100644 --- a/src/PVE/LXC/Create.pm +++ b/src/PVE/LXC/Create

[pve-devel] [PATCH container v2] Fix: fsck: rbd volume not mapped

2020-01-17 Thread Alwin Antreich
Signed-off-by: Alwin Antreich --- V1 -> V2: run unmap only if it has a storage id. src/PVE/CLI/pct.pm | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/PVE/CLI/pct.pm b/src/PVE/CLI/pct.pm index 98e2c6e..ec071c5 100755 --- a/src/PVE/CLI/pct.pm +++ b/src/PVE/CLI/pct

[pve-devel] [PATCH container] Fix: fsck: rbd volume not mapped

2020-01-13 Thread Alwin Antreich
Signed-off-by: Alwin Antreich --- src/PVE/CLI/pct.pm | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/PVE/CLI/pct.pm b/src/PVE/CLI/pct.pm index 98e2c6e..9dee68d 100755 --- a/src/PVE/CLI/pct.pm +++ b/src/PVE/CLI/pct.pm @@ -247,7 +247,7 @@ __PACKAGE__->register_met

Re: [pve-devel] [PATCH ceph 1/2] fix Ceph version string handling

2020-01-09 Thread Alwin Antreich
Hello Martin, On Thu, Jan 09, 2020 at 02:23:07PM +0100, Martin Verges wrote: > Hello Thomas, > > 1. we provide 14.2.5, the latest stable release available (we have upcoming > > 14.2.6 already on track) > > > > Good to know, does not seem to be a knowledge that some proxmox users have > nor was i

Re: [pve-devel] [PATCH manager] API: OSD: Fix #2496 Check OSD Network

2019-12-13 Thread Alwin Antreich
Some comments inline. On Fri, Dec 13, 2019 at 03:56:42PM +0100, Aaron Lauterer wrote: > It's possible to have a situation where the cluster network (used for > inter-OSD traffic) is not configured on a node. The OSD can still be > created but can't communicate. > > This check will abort the creat

[pve-devel] [PATCH proxmox-ve] Update kernel links for install CD (rescue boot)

2019-12-03 Thread Alwin Antreich
Signed-off-by: Alwin Antreich --- Note: Thanks to Stoiko, he build an ISO to test the patch. This works with LVM based installs, but fails currently for ZFS with "Compression algorithm inherit not supported. Unable to find bootdisk automatically" debian/postinst |

[pve-devel] [PATCH manager] ceph: Create symlink on standalone MGR creation

2019-12-03 Thread Alwin Antreich
Ceph MGR fails to start when installed on a node without existing symlink to /etc/pve/ceph.conf. Signed-off-by: Alwin Antreich --- PVE/API2/Ceph/MGR.pm | 1 + 1 file changed, 1 insertion(+) diff --git a/PVE/API2/Ceph/MGR.pm b/PVE/API2/Ceph/MGR.pm index d3d86c0d..ffae7495 100644 --- a/PVE/API2

[pve-devel] [PATCH docs] Fix: pveceph: spelling in section Trim/Discard

2019-11-07 Thread Alwin Antreich
Signed-off-by: Alwin Antreich --- pveceph.adoc | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/pveceph.adoc b/pveceph.adoc index 99c610a..122f063 100644 --- a/pveceph.adoc +++ b/pveceph.adoc @@ -762,9 +762,9 @@ Trim/Discard It is a good measure to run

[pve-devel] [PATCH docs] Fix: pveceph: broken ref anchor pveceph_mgr_create

2019-11-07 Thread Alwin Antreich
Signed-off-by: Alwin Antreich --- pveceph.adoc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pveceph.adoc b/pveceph.adoc index ef257ac..99c610a 100644 --- a/pveceph.adoc +++ b/pveceph.adoc @@ -286,7 +286,7 @@ monitor the cluster. Since the Ceph luminous release at least

Re: [pve-devel] [PATCH docs] qm: spice foldersharing: Add experimental warning

2019-11-06 Thread Alwin Antreich
On Wed, Nov 06, 2019 at 03:45:26PM +0100, Aaron Lauterer wrote: > Hmm, What about: > > Currently this feature does not work reliably. > > > On 11/6/19 3:29 PM, Alwin Antreich wrote: > > On Wed, Nov 06, 2019 at 03:20:59PM +0100, Aaron Lauterer wrote: > > &

Re: [pve-devel] [PATCH docs] qm: spice foldersharing: Add experimental warning

2019-11-06 Thread Alwin Antreich
On Wed, Nov 06, 2019 at 03:20:59PM +0100, Aaron Lauterer wrote: > Signed-off-by: Aaron Lauterer > --- > qm.adoc | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/qm.adoc b/qm.adoc > index 9ee4460..c0fe892 100644 > --- a/qm.adoc > +++ b/qm.adoc > @@ -856,6 +856,8 @@ Select the folder to

  1   2   3   4   >