Re: [pve-devel] [PATCH xtermjs] termproxy: rewrite in rust

2020-07-06 Thread Dietmar Maurer
> so we have a 'termproxy' crate+binary and a binary package with name > 'pve-xtermjs' This is quite confusing ... ___ pve-devel mailing list pve-devel@pve.proxmox.com https://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

Re: [pve-devel] Feature Request - HA for KVM Templates?

2020-07-03 Thread Dietmar Maurer
> How difficult would it be to add functionality to Proxmox, such that > templates on shared storage (or Ceph) could be HA as well, and available > across the cluster? AFAIK this is already implemented. Simply mark the template as HA. Already tried that?

[pve-devel] [Patch qemu] PVE-Backup: qmp_query_backup - improve monitor output

2020-07-02 Thread Dietmar Maurer
--- monitor/hmp-cmds.c | 45 +--- pve-backup.c | 26 + qapi/block-core.json | 9 +++-- 3 files changed, 63 insertions(+), 17 deletions(-) diff --git a/monitor/hmp-cmds.c b/monitor/hmp-cmds.c index

[pve-devel] [PATCH qemu] PVE-Backup: remove dirty-bitmap in pvebackup_complete_cb for failed jobs

2020-07-01 Thread Dietmar Maurer
Note: We remove the device from di_list, so pvebackup_co_cleanup does not handle this case. --- pve-backup.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/pve-backup.c b/pve-backup.c index 61a8b4d2a4..1c4f6cf9e0 100644 --- a/pve-backup.c +++ b/pve-backup.c @@ -318,6 +318,12 @@ static

Re: [pve-devel] [RFC pve-qemu] Add systemd journal logging patch

2020-06-30 Thread Dietmar Maurer
comments inline > On 06/30/2020 2:06 PM Stefan Reiter wrote: > > > Prints QEMU errors that occur *after* the "-daemonize" fork to the > systemd journal, instead of pushing them into /dev/null like before. > > Signed-off-by: Stefan Reiter > --- > > Useful for debugging rust panics for

[pve-devel] [PATCH qemu-server] avoid backup command timeout with pbs

2020-06-25 Thread Dietmar Maurer
--- PVE/VZDump/QemuServer.pm | 2 ++ 1 file changed, 2 insertions(+) diff --git a/PVE/VZDump/QemuServer.pm b/PVE/VZDump/QemuServer.pm index 1a0d437..147a3e6 100644 --- a/PVE/VZDump/QemuServer.pm +++ b/PVE/VZDump/QemuServer.pm @@ -403,6 +403,8 @@ sub archive_pbs { $params->{fingerprint} =

Re: [pve-devel] cloudinit: generate server ssh keys on proxmox side ?

2020-06-25 Thread Dietmar Maurer
> Maybe could we generate them once at proxmox side ? -1 Copying private keys is bad ... ___ pve-devel mailing list pve-devel@pve.proxmox.com https://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

Re: [pve-devel] RFC: sdn: add ip management (IPAM -DHCP) ideas

2020-06-21 Thread Dietmar Maurer
comments inline > When user will create a new vm or add a nic to the vm, he could choose ip > address "auto", > and the next available ip addresse will be returned with the ipam driver. Each NIC may have an associated network allocation pool, where "auto" tries to figure out the correct pool

Re: [pve-devel] bug in backup/restore for non-64K aligned disks + host mem leak to backups

2020-06-18 Thread Dietmar Maurer
May I request that you open a bug at: https://bugzilla.proxmox.com That way it is easier to track the bug status ... > On 06/18/2020 3:22 PM Dietmar Maurer wrote: > > > > Don't get me wrong, I just wanted to report what IMO is a bug in a > > backup tool (an actually pret

Re: [pve-devel] bug in backup/restore for non-64K aligned disks + host mem leak to backups

2020-06-18 Thread Dietmar Maurer
> Don't get me wrong, I just wanted to report what IMO is a bug in a > backup tool (an actually pretty clever one looking at the format), and > that to me is the point of view that really matters here. Sure, this is clearly a bug a we should fix it - thanks for reporting. But AFAIK this does not

Re: [pve-devel] bug in backup/restore for non-64K aligned disks + host mem leak to backups

2020-06-17 Thread Dietmar Maurer
> I initially noticed that backup/restore has a bug when the disk size is > not a multiple of 64K for DRBD devices. But qemu block size is 64K, so disk size should/must always be a multiple of 64K? AFAIK we never generate such disk sizes? ___

Re: [pve-devel] [PATCH storage/manager] create zpools with stable disk paths

2020-06-04 Thread Dietmar Maurer
Why do we handle this at the GUI side? I would prefer to do that on the host instead... ___ pve-devel mailing list pve-devel@pve.proxmox.com https://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

Re: [pve-devel] [PATCH container] lxc: fall back to 'unmanaged' on unknown ostype

2020-05-16 Thread Dietmar Maurer
> Rather than failing, it would be nice to fall back to 'unmanaged' when > the ostype cannot be determined/found. Why exactly would that be nice? FWICT it would start the container with wrong and unexpected setup. ___ pve-devel mailing list

Re: [pve-devel] [PATCH storage v4 02/12] storage: replace build-in stat with File::stat

2020-04-22 Thread Dietmar Maurer
> On April 22, 2020 6:00 PM Alwin Antreich wrote: > > > On Wed, Apr 22, 2020 at 05:35:05PM +0200, Dietmar Maurer wrote: > > AFAIK this can have ugly side effects ... > Okay, I was not aware of any know side effects. > > I took the File::stat, since we use it alr

Re: [pve-devel] [PATCH storage v4 02/12] storage: replace build-in stat with File::stat

2020-04-22 Thread Dietmar Maurer
AFAIK this can have ugly side effects ... > On April 22, 2020 4:57 PM Alwin Antreich wrote: > > > to minimize variable declarations. And allow to mock this method in > tests instead of the perl build-in stat. > > Signed-off-by: Alwin Antreich > --- > PVE/Diskmanage.pm | 9 + >

Re: [pve-devel] Fwd: proxmox-backup dev env

2020-04-07 Thread Dietmar Maurer
> Hi I downloaded and did the proxmox-backup cargo build, but now when I try > to build make dinstall it fails because it can't find the crate on the > registry, how did you solve this problem you have an internal cargo > registry ? I tried cargo local registry and also cargo vendor but I can't >

Re: [pve-devel] learning a new language: rust vs golang vs raku ?

2020-03-23 Thread Dietmar Maurer
> I think I'm going to learn a new language. > > What do you think about rust vs golang vs raku, coming from perl/python/php. > (I don't have touch C too much since school in 99 ;) > > > I'm seeing that some rust code is available proxmox git repo, We decided to use RUST for future projects,

Re: [pve-devel] [zsync] fix: check for incremental sync snapshot.

2020-03-18 Thread Dietmar Maurer
Why does the patch ignore the output from the command? > On March 18, 2020 7:51 AM Wolfgang Link wrote: > > > For an incremental sync you need the last_snap on both sides. > --- > pve-zsync | 13 - > 1 file changed, 4 insertions(+), 9 deletions(-) > > diff --git a/pve-zsync

Re: [pve-devel] Proxmox Backup Server

2020-03-14 Thread Dietmar Maurer
> What is the roadmap for this tool? It will be announced here as soon as we have detailed plans. > What is then features it's supposed to support to? > Just curious! As already stated, sources are available at git.proxmox.com. ___ pve-devel

Re: [pve-devel] Proxmox Backup Server

2020-03-14 Thread Dietmar Maurer
> I've seen quite a few mentions of Proxmox Backup Server recently (in commit > messages). Is there some doc written about it somewhere ? What kind of > features will it provide etc. ? This is still experimental code, so we only have the source code available: https://git.proxmox.com/ All

Re: [pve-devel] [PATCH qemu-server 4/4] implement PoC migration to remote cluster/node

2020-03-10 Thread Dietmar Maurer
> do we need a stored mapping for intra-cluster migration as well? we > could put the same entities into the node config as well, and the > order of precedence would be: IMHO this is not necessary ___ pve-devel mailing list

Re: [pve-devel] [PATCH qemu-server 4/4] implement PoC migration to remote cluster/node

2020-03-10 Thread Dietmar Maurer
> I like the second option > > "mapping of source storage/bridge to target storage/bridge" ... > Also, it could be great to save mapping for reusing later Maybe in the new remote configuration (@fabian)? ___ pve-devel mailing list

Re: [pve-devel] [PATCH 24/31] PVE: move snapshot cleanup into bottom half

2020-03-06 Thread Dietmar Maurer
> for the record, this could be squashed into "[PATCH 17/31] PVE: internal > snapshot async" no biggie, but if we already go for a cleanup round.. In the first step, I only merged backup related patches (keep the rest as they was). Hoped this makes review easier ... Once that is finished, I can

[pve-devel] [PATCH 31/31] PVE-Backup - proxmox backup patches for qemu

2020-03-06 Thread Dietmar Maurer
--- blockdev.c| 823 ++ hmp-commands-info.hx | 13 + hmp-commands.hx | 31 ++ include/monitor/hmp.h | 3 + monitor/hmp-cmds.c| 69 qapi/block-core.json | 91 + qapi/common.json | 13 + qapi/misc.json| 13

[pve-devel] [PATCH 30/31] PVE-Backup: add backup-dump block driver

2020-03-06 Thread Dietmar Maurer
- add backup-dump block driver block/backup-dump.c - move BackupBlockJob declaration from block/backup.c to include/block/block_int.h - block/backup.c - backup-job-create: also consider source cluster size - block/io.c - bdrv_do_drained_begin_quiesce: check for coroutine - job.c: make

[pve-devel] [PATCH 16/31] PVE: qapi: modify spice query

2020-03-06 Thread Dietmar Maurer
From: Wolfgang Bumiller Provide the last ticket in the SpiceInfo struct optionally. Signed-off-by: Thomas Lamprecht --- qapi/ui.json| 3 +++ ui/spice-core.c | 5 + 2 files changed, 8 insertions(+) diff --git a/qapi/ui.json b/qapi/ui.json index e04525d8b4..6127990e23 100644 ---

[pve-devel] [PATCH 19/31] PVE: backup: modify job api

2020-03-06 Thread Dietmar Maurer
From: Wolfgang Bumiller Introduce a pause_count parameter to start a backup in paused mode. This way backups of multiple drives can be started up sequentially via the completion callback while having been started at the same point in time. Signed-off-by: Thomas Lamprecht --- block/backup.c

[pve-devel] [PATCH 13/31] PVE: [Up] qemu-img dd : add -n skip_create

2020-03-06 Thread Dietmar Maurer
From: Alexandre Derumier Signed-off-by: Thomas Lamprecht --- qemu-img.c | 23 ++- 1 file changed, 14 insertions(+), 9 deletions(-) diff --git a/qemu-img.c b/qemu-img.c index 8da1ea3951..ea3edb4f04 100644 --- a/qemu-img.c +++ b/qemu-img.c @@ -4535,7 +4535,7 @@ static int

[pve-devel] [PATCH 18/31] PVE: block: add the zeroinit block driver filter

2020-03-06 Thread Dietmar Maurer
From: Wolfgang Bumiller Signed-off-by: Thomas Lamprecht --- block/Makefile.objs | 1 + block/zeroinit.c| 204 2 files changed, 205 insertions(+) create mode 100644 block/zeroinit.c diff --git a/block/Makefile.objs b/block/Makefile.objs index

[pve-devel] [PATCH 20/31] PVE: Add dummy -id command line parameter

2020-03-06 Thread Dietmar Maurer
From: Wolfgang Bumiller This used to be part of the qemu-side PVE authentication for VNC. Now this does nothing. Signed-off-by: Wolfgang Bumiller Signed-off-by: Thomas Lamprecht --- qemu-options.hx | 3 +++ vl.c| 8 2 files changed, 11 insertions(+) diff --git

[pve-devel] [PATCH 27/31] PVE: [Compat]: 4.0 used balloon qemu-4-0-config-size false here

2020-03-06 Thread Dietmar Maurer
From: Thomas Lamprecht The underlying issue why this change from upstream to us arised in the first place is that QEMU 4.0 was already released at the point we run into this migration issue, so we did the then obvious fallback to false for virtio-balloon-device qemu-4-0-config-size. QEMU made

[pve-devel] [PATCH 29/31] PVE-Backup - add vma code

2020-03-06 Thread Dietmar Maurer
Proxmox Server Solutions + * + * Authors: + * Dietmar Maurer (diet...@proxmox.com) + * + * This work is licensed under the terms of the GNU GPL, version 2 or later. + * See the COPYING file in the top-level directory. + * + */ + +#include "qemu/osdep.h" +#include +#include + +#inc

[pve-devel] [PATCH 23/31] PVE: savevm-async: kick AIO wait on block state write

2020-03-06 Thread Dietmar Maurer
From: Thomas Lamprecht Signed-off-by: Thomas Lamprecht --- savevm-async.c | 1 + 1 file changed, 1 insertion(+) diff --git a/savevm-async.c b/savevm-async.c index 5a20009b9a..e4bb0d24b2 100644 --- a/savevm-async.c +++ b/savevm-async.c @@ -157,6 +157,7 @@ static void coroutine_fn

[pve-devel] [PATCH 26/31] PVE: Acquire aio_context before calling block_job_add_bdrv

2020-03-06 Thread Dietmar Maurer
From: Stefan Reiter Otherwise backups immediately fail with 'permission denied' since _add_bdrv tries to release a lock we don't own. Signed-off-by: Stefan Reiter --- blockjob.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/blockjob.c b/blockjob.c index

[pve-devel] [PATCH 24/31] PVE: move snapshot cleanup into bottom half

2020-03-06 Thread Dietmar Maurer
From: Wolfgang Bumiller as per: (0ceccd858a8d) migration: qemu_savevm_state_cleanup() in cleanup may affect held locks and therefore change assumptions made by that function! Signed-off-by: Wolfgang Bumiller Signed-off-by: Thomas Lamprecht --- savevm-async.c | 3 ++- 1 file changed, 2

[pve-devel] [PATCH 22/31] PVE: [Up+Config] file-posix: make locking optiono on create

2020-03-06 Thread Dietmar Maurer
From: Wolfgang Bumiller Otherwise creating images on nfs/cifs can be problematic. Signed-off-by: Wolfgang Bumiller Signed-off-by: Thomas Lamprecht --- block/file-posix.c | 61 +--- qapi/block-core.json | 3 ++- 2 files changed, 43 insertions(+), 21

[pve-devel] [PATCH 25/31] PVE: monitor: disable oob capability

2020-03-06 Thread Dietmar Maurer
From: Wolfgang Bumiller A bisect revealed that commit 8258292e18c3 ("monitor: Remove "x-oob", offer capability "oob" unconditionally") causes unexpected hangs when restoring live snapshots from some types of block devices (particularly RBD). We need to figure out what's happnening there. For

[pve-devel] [PATCH 14/31] PVE: virtio-balloon: improve query-balloon

2020-03-06 Thread Dietmar Maurer
From: Wolfgang Bumiller Actually provide memory information via the query-balloon command. Signed-off-by: Thomas Lamprecht --- hw/virtio/virtio-balloon.c | 33 +++-- monitor/hmp-cmds.c | 30 +- qapi/misc.json | 22

[pve-devel] [PATCH 21/31] PVE: [Config] Revert "target-i386: disable LINT0 after reset"

2020-03-06 Thread Dietmar Maurer
From: Wolfgang Bumiller This reverts commit b8eb5512fd8a115f164edbbe897cdf8884920ccb. Signed-off-by: Thomas Lamprecht --- hw/intc/apic_common.c | 9 + 1 file changed, 9 insertions(+) diff --git a/hw/intc/apic_common.c b/hw/intc/apic_common.c index 375cb6abe9..e7d479c7e9 100644 ---

[pve-devel] [PATCH 11/31] PVE: [Up] qemu-img dd: add osize and read from/to stdin/stdout

2020-03-06 Thread Dietmar Maurer
From: Wolfgang Bumiller Neither convert nor dd were previously able to write to or read from a pipe. Particularly serializing an image file into a raw stream or vice versa can be useful, but using `qemu-img convert -f qcow2 -O raw foo.qcow2 /dev/stdout` in a pipe will fail trying to seek. While

[pve-devel] [PATCH 17/31] PVE: internal snapshot async

2020-03-06 Thread Dietmar Maurer
Signed-off-by: Thomas Lamprecht Signed-off-by: Dietmar Maurer --- Makefile.objs| 1 + hmp-commands-info.hx | 13 + hmp-commands.hx | 32 +++ include/migration/snapshot.h | 1 + include/monitor/hmp.h| 5 + monitor/hmp-cmds.c | 57

[pve-devel] [PATCH 28/31] PVE: Allow version code in machine type

2020-03-06 Thread Dietmar Maurer
E.g. pc-i440fx-4.0+pve3 would print 'pve3' as version code while selecting pc-i440fx-4.0 as machine type. Version is made available as 'pve-version' in query-machines (same as, and only if 'is-current'). Signed-off-by: Stefan Reiter --- hw/core/machine-qmp-cmds.c | 6 ++

[pve-devel] [PATCH 15/31] PVE: qapi: modify query machines

2020-03-06 Thread Dietmar Maurer
provide '*is-current' in MachineInfo struct Signed-off-by: Thomas Lamprecht Signed-off-by: Dietmar Maurer --- hw/core/machine-qmp-cmds.c | 6 ++ qapi/machine.json | 4 +++- 2 files changed, 9 insertions(+), 1 deletion(-) diff --git a/hw/core/machine-qmp-cmds.c b/hw/core/machine

[pve-devel] [PATCH 07/31] PVE: [Config] rbd: block: rbd: disable rbd_cache_writethrough_until_flush

2020-03-06 Thread Dietmar Maurer
From: Wolfgang Bumiller Either the cache mode asks for a cache or not. There's no point in having a "temporary" cache mode. This option AFAIK was introduced as a hack for ancient virtio drivers. If anything, we should have a separate option for it. Better yet, VMs affected by the related issue

[pve-devel] [PATCH 05/31] PVE: [Config] smm_available = false

2020-03-06 Thread Dietmar Maurer
From: Alexandre Derumier Signed-off-by: Alexandre Derumier Signed-off-by: Thomas Lamprecht --- hw/i386/pc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/i386/pc.c b/hw/i386/pc.c index ac08e63604..4bd9ab52a0 100644 --- a/hw/i386/pc.c +++ b/hw/i386/pc.c @@ -2040,7

[pve-devel] [PATCH 06/31] PVE: [Config] glusterfs: no default logfile if daemonized

2020-03-06 Thread Dietmar Maurer
From: Wolfgang Bumiller Signed-off-by: Thomas Lamprecht --- block/gluster.c | 15 +++ 1 file changed, 11 insertions(+), 4 deletions(-) diff --git a/block/gluster.c b/block/gluster.c index 4fa4a77a47..bfb57ba098 100644 --- a/block/gluster.c +++ b/block/gluster.c @@ -42,7 +42,7 @@

[pve-devel] [PATCH 10/31] PVE: [Up] qemu-img: return success on info without snapshots

2020-03-06 Thread Dietmar Maurer
From: Wolfgang Bumiller Signed-off-by: Thomas Lamprecht --- qemu-img.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/qemu-img.c b/qemu-img.c index 95a24b9762..12211bed76 100644 --- a/qemu-img.c +++ b/qemu-img.c @@ -2791,7 +2791,8 @@ static int img_info(int argc, char

[pve-devel] [PATCH 12/31] PVE: [Up] qemu-img dd: add isize parameter

2020-03-06 Thread Dietmar Maurer
From: Wolfgang Bumiller for writing small images from stdin to bigger ones In order to distinguish between an actually unexpected and an expected end of input. Signed-off-by: Wolfgang Bumiller Signed-off-by: Thomas Lamprecht --- qemu-img.c | 29 ++--- 1 file changed,

[pve-devel] [PATCH 04/31] PVE: [Config] ui/spice: default to pve certificates

2020-03-06 Thread Dietmar Maurer
From: Wolfgang Bumiller Signed-off-by: Thomas Lamprecht --- ui/spice-core.c | 15 +-- 1 file changed, 9 insertions(+), 6 deletions(-) diff --git a/ui/spice-core.c b/ui/spice-core.c index ecc2ec2c55..ca04965ead 100644 --- a/ui/spice-core.c +++ b/ui/spice-core.c @@ -668,32 +668,35

[pve-devel] [PATCH 09/31] PVE: [Up] glusterfs: allow partial reads

2020-03-06 Thread Dietmar Maurer
From: Wolfgang Bumiller This should deal with qemu bug #1644754 until upstream decides which way to go. The general direction seems to be away from sector based block APIs and with that in mind, and when comparing to other network block backends (eg. nfs) treating partial reads as errors doesn't

[pve-devel] [PATCH 01/31] PVE: [Config] block/file: change locking default to off

2020-03-06 Thread Dietmar Maurer
From: Wolfgang Bumiller 'auto' only checks whether the system generally supports OFD locks but not whether the storage the file resides on supports any locking, causing issues with NFS. Signed-off-by: Wolfgang Bumiller Signed-off-by: Thomas Lamprecht --- block/file-posix.c | 4 ++-- 1 file

[pve-devel] [PATCH 03/31] PVE: [Config] set the CPU model to kvm64/32 instead of qemu64/32

2020-03-06 Thread Dietmar Maurer
From: Wolfgang Bumiller Signed-off-by: Thomas Lamprecht --- target/i386/cpu.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/target/i386/cpu.h b/target/i386/cpu.h index cde2a16b94..3e73104bf9 100644 --- a/target/i386/cpu.h +++ b/target/i386/cpu.h @@ -1940,9 +1940,9 @@

[pve-devel] [PATCH 08/31] PVE: [Up] qmp: add get_link_status

2020-03-06 Thread Dietmar Maurer
From: Wolfgang Bumiller Signed-off-by: Thomas Lamprecht --- net/net.c | 27 +++ qapi/net.json | 15 +++ qapi/qapi-schema.json | 1 + 3 files changed, 43 insertions(+) diff --git a/net/net.c b/net/net.c index 84aa6d8d00..f548202ec6

[pve-devel] [PATCH 02/31] PVE: [Config] Adjust network script path to /etc/kvm/

2020-03-06 Thread Dietmar Maurer
From: Wolfgang Bumiller Signed-off-by: Thomas Lamprecht --- include/net/net.h | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/include/net/net.h b/include/net/net.h index e175ba9677..5b9f099d21 100644 --- a/include/net/net.h +++ b/include/net/net.h @@ -208,8 +208,9 @@

[pve-devel] [PATCH 00/31 qemu] PVE qemu patches rebased for qemu 4.2.0

2020-03-06 Thread Dietmar Maurer
-img dd : add -n skip_create Dietmar Maurer (6): PVE: qapi: modify query machines PVE: internal snapshot async PVE: Allow version code in machine type PVE-Backup - add vma code PVE-Backup: add backup-dump block driver PVE-Backup - proxmox backup patches for qemu Stefan Reiter (1): PVE

[pve-devel] [PATCH pve-manager] www/manager6/storage/ContentView.js: consider new ctime value

2020-03-04 Thread Dietmar Maurer
Signed-off-by: Dietmar Maurer --- www/manager6/storage/ContentView.js | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/www/manager6/storage/ContentView.js b/www/manager6/storage/ContentView.js index ffd38fb9..001efc7f 100644 --- a/www/manager6/storage/ContentView.js

[pve-devel] [PATCH pve-storage 4/6] PVE/Storage/Plugin.pm: add ctime for all files

2020-03-04 Thread Dietmar Maurer
Creation time makes sense for other file types also. Signed-off-by: Dietmar Maurer --- PVE/Storage/Plugin.pm | 10 -- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/PVE/Storage/Plugin.pm b/PVE/Storage/Plugin.pm index bd4bb8c..85af1c8 100644 --- a/PVE/Storage/Plugin.pm

[pve-devel] [PATCH pve-storage 5/6] PVE/Storage/Plugin.pm: return ctime for vm images

2020-03-04 Thread Dietmar Maurer
Changed file_size_info() to additionally return ctime to avoid another stat() call. Signed-off-by: Dietmar Maurer --- PVE/Storage/Plugin.pm | 18 +- 1 file changed, 13 insertions(+), 5 deletions(-) diff --git a/PVE/Storage/Plugin.pm b/PVE/Storage/Plugin.pm index 85af1c8

[pve-devel] [PATCH pve-storage 6/6] LVM list_images: return creation time

2020-03-04 Thread Dietmar Maurer
Signed-off-by: Dietmar Maurer --- PVE/Storage/LVMPlugin.pm | 15 +++ PVE/Storage/LvmThinPlugin.pm | 1 + 2 files changed, 12 insertions(+), 4 deletions(-) diff --git a/PVE/Storage/LVMPlugin.pm b/PVE/Storage/LVMPlugin.pm index f02c110..c9fc191 100644 --- a/PVE/Storage

[pve-devel] [PATCH pve-storage 2/6] PVE/Storage/PBSPlugin.pm - list_volumes: add ctime

2020-03-04 Thread Dietmar Maurer
Signed-off-by: Dietmar Maurer --- PVE/Storage/PBSPlugin.pm | 9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/PVE/Storage/PBSPlugin.pm b/PVE/Storage/PBSPlugin.pm index fcb1597..2a4c19c 100644 --- a/PVE/Storage/PBSPlugin.pm +++ b/PVE/Storage/PBSPlugin.pm @@ -282,18

[pve-devel] [PATCH pve-storage 3/6] PVE/API2/Storage/Content.pm - index: add ctime to return schema

2020-03-04 Thread Dietmar Maurer
Signed-off-by: Dietmar Maurer --- PVE/API2/Storage/Content.pm | 6 ++ 1 file changed, 6 insertions(+) diff --git a/PVE/API2/Storage/Content.pm b/PVE/API2/Storage/Content.pm index ce89ec5..80c9501 100644 --- a/PVE/API2/Storage/Content.pm +++ b/PVE/API2/Storage/Content.pm @@ -81,6 +81,12

[pve-devel] [PATCH pve-storage 1/6] PVE/Storage/Plugin.pm: add ctime for backup files

2020-03-04 Thread Dietmar Maurer
Signed-off-by: Dietmar Maurer --- PVE/Storage/Plugin.pm | 6 ++ 1 file changed, 6 insertions(+) diff --git a/PVE/Storage/Plugin.pm b/PVE/Storage/Plugin.pm index eab73f5..bd4bb8c 100644 --- a/PVE/Storage/Plugin.pm +++ b/PVE/Storage/Plugin.pm @@ -6,6 +6,7 @@ use warnings; use File::chdir

[pve-devel] [PATCH pve-storage 1/3] PVE/Storage/Plugin.pm: introduce on_update_hook

2020-02-20 Thread Dietmar Maurer
We need this to correctly update the password file. --- PVE/API2/Storage/Config.pm | 25 +++-- PVE/Storage/Plugin.pm | 9 + 2 files changed, 32 insertions(+), 2 deletions(-) diff --git a/PVE/API2/Storage/Config.pm b/PVE/API2/Storage/Config.pm index

[pve-devel] [PATCH pve-storage 2/3] CIFSPlugin.pm: fix crediential handling using new on_update_hook

2020-02-20 Thread Dietmar Maurer
--- PVE/Storage/CIFSPlugin.pm | 32 ++-- 1 file changed, 26 insertions(+), 6 deletions(-) diff --git a/PVE/Storage/CIFSPlugin.pm b/PVE/Storage/CIFSPlugin.pm index 6115a96..6c8cd72 100644 --- a/PVE/Storage/CIFSPlugin.pm +++ b/PVE/Storage/CIFSPlugin.pm @@ -34,6 +34,15

Re: [pve-devel] working on ifupdown2 openvswitch addon

2020-02-14 Thread Dietmar Maurer
> I'm currently working on a openvswitch addon for ifupdown2. > > I think it'll be finished next week. (It's almost working,need more test and > polish) > > I have also implemented reloading, seem to works fine :) great! ___ pve-devel mailing list

Re: [pve-devel] Polish translation

2019-12-15 Thread Dietmar Maurer
see https://pve.proxmox.com/wiki/Translations > On 14 December 2019 17:55 Daniel Koć wrote: > > > Hi, all! > > I find the Proxmox a great piece of software for clusters, so thanks a > lot for it! I currently test a pilot deployment in my work. > > I'd like to make some updates to the Polish

Re: [pve-devel] [PATCH pve-guest-common 1/1] vzdump: added "includename" option

2019-11-13 Thread Dietmar Maurer
> The main reason for this is to identify backups residing on an old backup > store like an archive. > > > > But I am open. Would you prefer having a manifest included in the archive or > as a separate file on the same storage? The backup archive already contains the full VM config. I

Re: [pve-devel] [PATCH pve-guest-common 1/1] vzdump: added "includename" option

2019-11-13 Thread Dietmar Maurer
> IMHO this is the wrong way to store additional information about > the backup. I am thinking about adding a manifest.json file which may contain such information ___ pve-devel mailing list pve-devel@pve.proxmox.com

Re: [pve-devel] [PATCH pve-guest-common 1/1] vzdump: added "includename" option

2019-11-13 Thread Dietmar Maurer
IMHO this is the wrong way to store additional information about the backup. > On 13 November 2019 15:02 Marco Gabriel wrote: > > > Signed-off-by: Marco Gabriel > --- > PVE/VZDump/Common.pm | 6 ++ > 1 file changed, 6 insertions(+) > > diff --git a/PVE/VZDump/Common.pm

Re: [pve-devel] [PATCH qemu 1/4] pvebackup_co_dump_cb: do not call job->cancel()

2019-10-27 Thread Dietmar Maurer
Despite of the subject (1/4), this is just a single patch (sorry). > On 27 October 2019 08:24 Dietmar Maurer wrote: > > > The backup loop will automatically abort if we return an error. > --- > blockdev.c | 6 ++ > 1 file changed, 2 insertions(+), 4 deletio

[pve-devel] [PATCH qemu 1/4] pvebackup_co_dump_cb: do not call job->cancel()

2019-10-27 Thread Dietmar Maurer
The backup loop will automatically abort if we return an error. --- blockdev.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/blockdev.c b/blockdev.c index 07561b6f96..3343388978 100644 --- a/blockdev.c +++ b/blockdev.c @@ -3254,10 +3254,8 @@ static int coroutine_fn

[pve-devel] [PATCH qemu] pvebackup_complete_cb: avoid poll loop if already inside coroutine

2019-10-27 Thread Dietmar Maurer
--- blockdev.c | 10 -- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/blockdev.c b/blockdev.c index 1bfd85ebc1..5580d36da7 100644 --- a/blockdev.c +++ b/blockdev.c @@ -3170,6 +3170,8 @@ static void coroutine_fn block_on_coroutine_wrapper(void *opaque) static void

Re: [pve-devel] [PATCH qemu] fix backup job completion

2019-10-26 Thread Dietmar Maurer
Please wait, seem this is still buggy - need to do more tests ... > On 25 October 2019 11:22 Dietmar Maurer wrote: > > > With recent changes, pvebackup_co_run_next_job cancels the job async, > so we need to run pvebackup_co_cleanup in the completion handler >

[pve-devel] [PATCH qemu] fix backup job completion

2019-10-25 Thread Dietmar Maurer
With recent changes, pvebackup_co_run_next_job cancels the job async, so we need to run pvebackup_co_cleanup in the completion handler instead. We call pvebackup_co_run_next as long as there are jobs in the list. Signed-off-by: Dietmar Maurer --- blockdev.c | 9 - 1 file changed, 4

[pve-devel] [PATCH qemu 1/3] backup_job_create: pass cluster size for dump

2019-10-24 Thread Dietmar Maurer
Signed-off-by: Dietmar Maurer --- block/backup.c| 8 +++- block/replication.c | 2 +- blockdev.c| 10 ++ include/block/block_int.h | 4 4 files changed, 18 insertions(+), 6 deletions(-) diff --git a/block/backup.c b/block/backup.c index

[pve-devel] [PATCH qemu 2/3] avoid calling dump_cb with NULL data pointer for small/last cluster

2019-10-24 Thread Dietmar Maurer
The last block of a backup may be smaller than cluster_size. Signed-off-by: Dietmar Maurer --- block/backup.c | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/block/backup.c b/block/backup.c index 2ccec79db6..cc20d77b9f 100644 --- a/block/backup.c +++ b/block/backup.c

[pve-devel] [PATCH qemu 3/3] rename config_to_vma into pvebackup_co_add_config

2019-10-24 Thread Dietmar Maurer
- mark it with coroutine_fn - add an additional parameter 'name' - return -1 on error (instead of 1) - code cleanup Signed-off-by: Dietmar Maurer --- blockdev.c | 40 ++-- 1 file changed, 26 insertions(+), 14 deletions(-) diff --git a/blockdev.c b/blockdev.c

[pve-devel] [PATCH pve-qemu] add patch to fix #1071

2019-10-21 Thread Dietmar Maurer
Signed-off-by: Dietmar Maurer --- ...-vma-writer.c-use-correct-AioContext.patch | 52 +++ debian/patches/series | 1 + 2 files changed, 53 insertions(+) create mode 100644 debian/patches/pve/0032-PVE-bug-fix-1071-vma-writer.c-use-correct

Re: [pve-devel] scsi-hd vs scsi-generic with iSCSI

2019-10-10 Thread Dietmar Maurer
also see: https://pve.proxmox.com/pipermail/pve-devel/2012-August/003347.html > On 9 October 2019 17:39 Thomas Lamprecht wrote: > > > On 10/8/19 12:54 PM, Daniel Berteaud wrote: > > - Le 8 Oct 19, à 12:28, Thomas Lamprecht t.lampre...@proxmox.com a > > écrit : > > > >> > >> Thanks for

Re: [pve-devel] cpu type ppc/s390

2019-10-07 Thread Dietmar Maurer
> I would like ask if it is possible to add other CPU types to the proxmox > admin interface > Such as PowerPC (ppc64le/be) and s390x There are no plans to add ppc or s390. ___ pve-devel mailing list pve-devel@pve.proxmox.com

Re: [pve-devel] scsi-hd vs scsi-generic with iSCSI

2019-09-28 Thread Dietmar Maurer
> After some digging, I found that when using scsi-hd (instead of the default > scsi-generic), everything is working correctly. What exactly is the problem with scsi-generic? Maybe we can fix it? ___ pve-devel mailing list pve-devel@pve.proxmox.com

Re: [pve-devel] applied: [RFC PATCH common] cli: prettify tables even more

2019-09-04 Thread Dietmar Maurer
ok, sorry for the noise ... > On 5 September 2019 07:08 Thomas Lamprecht wrote: > > > On 04.09.19 19:36, Dietmar Maurer wrote: > > What about my doubts? AFAIK nobody answered my mail? (or maybe i missed a > > mail) > > > > Wolfgang did answer: >

Re: [pve-devel] applied: [RFC PATCH common] cli: prettify tables even more

2019-09-04 Thread Dietmar Maurer
What about my doubts? AFAIK nobody answered my mail? (or maybe i missed a mail) > On 4 September 2019 16:06 Thomas Lamprecht wrote: > > > On 21.08.19 14:33, Wolfgang Bumiller wrote: > > Separate the header with a double line. > > > > Signed-off-by: Wolfgang Bumiller > > --- > >

Re: [pve-devel] [RFC PATCH common] cli: prettify tables even more

2019-08-21 Thread Dietmar Maurer
Are your sure common terminals support those characters? They did not when I tested ... > On 21 August 2019 14:33 Wolfgang Bumiller wrote: > > > Separate the header with a double line. > > Signed-off-by: Wolfgang Bumiller > --- > src/PVE/CLIFormatter.pm | 18 +- > 1 file

[pve-devel] [PATCH pve-storage v3] storage plugin: new list_volumes plugin method

2019-07-19 Thread Dietmar Maurer
This cleanup improve code reuse, and allows plugins to override list_volumes. --- Changes in v3: - keep template_list compatible with previous behavior - rename $template_list into $get_subdir_files Changes in v2: - remove debug statements - move implementaion to Plugin.pm for max.

[pve-devel] [PATCH pve-storage v2] storage plugin: new list_volumes plugin method

2019-07-19 Thread Dietmar Maurer
This cleanup improve code reuse, and allows plugins to override list_volumes. Note: This changes the template_list return value into an array. --- Changes in v2: - remove debug statements - move implementaion to Plugin.pm for max. compatibility with old code - cleanup regex (use i flag) - bump

[pve-devel] [PATCH pve-storage] PVE/Storage/Plugin.pm: new list_volumes plugin method

2019-07-19 Thread Dietmar Maurer
This cleanup improve code reuse, and allows plugins to override list_volumes. Note: This changes the template_list return value into an array. --- PVE/Storage.pm | 147 +++-- PVE/Storage/DirPlugin.pm | 84 ++-

Re: [pve-devel] pve-firewall : log for default accept action and action format consistency in logs

2019-06-30 Thread Dietmar Maurer
> On 1 July 2019 03:03 Alexandre DERUMIER wrote: > > > >>I always tried to minimize log overhead. If you log ACCEPT, that will > >>generate very large amounts of logs? > > yes sure, but we have the option to set nolog for in/out default rules. Ah, good. > I have some server where customer

Re: [pve-devel] pve-firewall : log for default accept action and action format consistency in logs

2019-06-29 Thread Dietmar Maurer
I always tried to minimize log overhead. If you log ACCEPT, that will generate very large amounts of logs? > On 29 June 2019 19:15 Alexandre DERUMIER wrote: > > > Hi, > > > I have noticed that when default action is accept, no log are currently > generated. > > > They are no log for

Re: [pve-devel] [RFC v2 0/3] fix #1291: add purge option for VM/CT destroy

2019-06-28 Thread Dietmar Maurer
> On 28 June 2019 15:05 Thomas Lamprecht wrote: > > > On 6/26/19 6:02 PM, Christian Ebner wrote: > > The purge flag allows to remove the vmid from the vzdump.cron backup jobs on > > VM/CT destruction. > > > > A few things I'm still missing: > * Web GUI integration (simple checkbox?) > *

Re: [pve-devel] [PATCH pve-manager 1/2] pvestatd : broadcast sdn transportzone status

2019-06-25 Thread Dietmar Maurer
> >>So do we want to generate some RRD databases with that data? > > I don't think we need a rrd here, it's a simple status (ok/error/pending/...) > on the transportzone. Ok > I don't want to stream vnet status, because it could be really huge. > (like 20 servers broadcasting 300vnets for

Re: [pve-devel] [PATCH pve-manager 1/2] pvestatd : broadcast sdn transportzone status

2019-06-25 Thread Dietmar Maurer
I am not sure if json is a good idea here. We use colon separated lists for everything else, so I would prefer that. It is easier to parse inside C, which is important when you want to generate RRD databases from inside pmxcfs ... Also, consider that it is quite hard to change that format later,

[pve-devel] applied: [PATCH pve-network 0/3] add ifquery && status code

2019-06-03 Thread Dietmar Maurer
applied > On 03 June 2019 at 17:57 Alexandre Derumier wrote: > > > prelimary code to handle status of vnets && transports > for later use in pvestatd > > Alexandre Derumier (3): > create api: test if $scfg vnet exist > add ifquery compare status > add test statuscheck.pl > >

Re: [pve-devel] ZFS 0.8 and __kernel_fpu_{begin,restore} symbols

2019-05-30 Thread Dietmar Maurer
> > I have seen zfs 0.8 has been merged in to the pve kernel master branch > > including the update to Kernel 5.0.8 for buster. > > > > Does the Ubuntu/PVE kernel export the __kernel_fpu symbols? > > I ask because I didn't found a patch for this and it would be painful if > > we have zfs with

Re: [pve-devel] ZFS 0.8 and __kernel_fpu_{begin,restore} symbols

2019-05-30 Thread Dietmar Maurer
> I have seen zfs 0.8 has been merged in to the pve kernel master branch > including the update to Kernel 5.0.8 for buster. > > Does the Ubuntu/PVE kernel export the __kernel_fpu symbols? > I ask because I didn't found a patch for this and it would be painful if > we have zfs with crypto without

Re: [pve-devel] opensource vm scheduler : btrplace

2019-05-29 Thread Dietmar Maurer
> Now, the main problem, is that it's java. (seem that scientific like it, > redhat rhev/ovirt have also implement scheduling algo model with java). > I don't known if it could be implemented in proxmox? (or at least with a > daemon like the daemon, and rest api call from perl to java? Importing

Re: [pve-devel] qemu : add disk option for physical/logical block (could improve windows guest performance wit ceph)

2019-05-15 Thread Dietmar Maurer
> could we add this as disk option ? (not defined by default). Sounds like a good idea. Maybe we can even set a better default (512e)? ___ pve-devel mailing list pve-devel@pve.proxmox.com https://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

Re: [pve-devel] [RFC manager 1/2] node: add journal api

2019-05-13 Thread Dietmar Maurer
comments inline > On 13 May 2019 at 14:49 Dominik Csapak wrote: > > > this uses the new journalreader instead of journalctl, which is a bit > faster and can read from/to cursor and returns a start/end cursor > > also you can give an unix epoch as time parameters > > Signed-off-by: Dominik

Re: [pve-devel] [PATCH 0/2] fix #2190: allow multiple words separated by whitespaces in SMBIOS manufacturer string

2019-05-09 Thread Dietmar Maurer
It is probably a bad idea to allow newlines! > On 09 May 2019 at 10:28 Christian Ebner wrote: > > > Christian Ebner (1): > fix #2190: allow multiple words separated by whitespaces in SMBIOS > manufacturer string > > PVE/QemuServer.pm | 2 +- > 1 file changed, 1 insertion(+), 1

[pve-devel] applied: [PATCH pve-network 0/3] plugins update && networks.cfg.new

2019-05-08 Thread Dietmar Maurer
applied ___ pve-devel mailing list pve-devel@pve.proxmox.com https://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

  1   2   3   4   5   6   7   8   9   10   >