hi,
what about the 'dist-upgrade' occurences? should these also be replaced
by 'full-upgrade' for completeness sake?
On Mon, Jul 06, 2020 at 01:38:29PM +0200, Moayad Almalat wrote:
> Signed-off-by: Moayad Almalat
> ---
> api-viewer/apidata.js| 8
> local-zfs.adoc
hi,
the email i've sent to qemu-discuss list to ask about this issue while
reattaching a drive with the same id has gone unanswered...
how do we want to proceed with this feature?
maybe we can fix this issue or workaround it somehow?
On Mon, May 18, 2020 at 05:34:01PM +0200, Oguz Bektas
hi,
> +
> > + if (deletes.length) {
> > + values.delete = deletes.join(',');
> > + }
> > +
> > + return values;
> > +},
> > +
> > +
> > +initComponent: function() {
> > + var me = this;
> > +
> > + var items = [];
>
> how's that not just a static
> items: [
> { ... },
v3 of the timezone series.
since pve-common patch has already been applied, it's not included.
only the widget-toolkit patch is different than v2.
v2->v3:
* use radiofield in widget-toolkit
proxmox-widget-toolkit:
Oguz Bektas (1):
add TimezonePanel for containers
src/
ime symlink from the host node will be
cached and set in the container rootfs.
Signed-off-by: Oguz Bektas
---
v2->v3:
no change
src/PVE/LXC/Config.pm | 14 ++
src/PVE/LXC/Setup.pm | 13 +
src/PVE/LXC/Setup/Base.pm | 33 ++---
3 f
this allows us to set the timezone of a container in the options menu.
Signed-off-by: Oguz Bektas
---
v2->v3:
no change
www/manager6/lxc/Options.js | 13 +
1 file changed, 13 insertions(+)
diff --git a/www/manager6/lxc/Options.js b/www/manager6/lxc/Options.js
index 40bde
renames the 'DNS' step to 'DNS / Time' and allows one to set the
timezone of the container during setup.
Signed-off-by: Oguz Bektas
---
v2->v3:
no change
www/manager6/lxc/CreateWizard.js | 16 +---
1 file changed, 13 insertions(+), 3 deletions(-)
diff -
with 3 modes;
- CT managed (no action)
- match host (use same timezone as host)
- select from list
also move 'UTC' to the top of the TimezoneStore for convenience
Signed-off-by: Oguz Bektas
---
v2->v3:
* use radiofields
src/Makefile | 1 +
src/data/TimezoneS
check if the given mpX already exists in the config. if it does, then
skip hotplugging and write the changes to [pve:pending] for the next
reboot of CT.
after rebooting the CT, the preexisting mpX will be added as unused and
the mpX will be mounted.
Signed-off-by: Oguz Bektas
---
src/PVE/LXC
fabian's variant can be done like this:
---
diff --git a/src/PVE/LXC/Config.pm b/src/PVE/LXC/Config.pm
index 0a28380..ba5e548 100644
--- a/src/PVE/LXC/Config.pm
+++ b/src/PVE/LXC/Config.pm
@@ -1248,6 +1248,9
if a user tries to add a mountpoint mpX which is waiting for a pending
delete, hotplugging a new mountpoint with name mpX before the
previous one is detached should not be allowed.
do a simple check to see if the given mpX is already in the pending delete
section.
Signed-off-by: Oguz Bektas
hi,
is anyone reviewing this patch?
On Wed, Jun 17, 2020 at 03:32:28PM +0200, Oguz Bektas wrote:
> this patch series implements the 'timezone' option for containers.
>
> more detailed info is in the commit messages.
>
> v1->v2:
>
> * don't us
do a simple check to see if our $opt is already in the delete section.
Signed-off-by: Oguz Bektas
---
src/PVE/LXC/Config.pm | 3 +++
1 file changed, 3 insertions(+)
diff --git a/src/PVE/LXC/Config.pm b/src/PVE/LXC/Config.pm
index 0a28380..237e2e5 100644
--- a/src/PVE/LXC/Config.pm
+++ b/src
initializing 'mounts' array in the panel scope causes edits on subsequent
containers to get the values (mount=nfs) from the previous container. fix this
by
initializing the 'mounts' array in 'onGetValues' and 'setValues'
separately.
Signed-of
instead of unconditionally pushing to the 'mounts' array we need to check
if we already have the option in there. without this, we get config
options like:
features: nfs;nfs;nfs
Signed-off-by: Oguz Bektas
---
www/manager6/lxc/FeaturesEdit.js | 2 +-
1 file changed, 1 insertion(+),
being executed in 'pre-start' and 'post-start'.
to call the hooks correctly we can just make use of the
PVE::LXC::vm_start routine which already handles them.
Signed-off-by: Oguz Bektas
---
src/PVE/VZDump/LXC.pm | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff
renames the 'DNS' step to 'DNS / Time' and allows one to set the
timezone of the container during setup.
Signed-off-by: Oguz Bektas
---
v1->v2:
no changes
www/manager6/lxc/CreateWizard.js | 16 +---
1 file changed, 13 insertions(+), 3 deletions(-)
diff -
ime symlink from the host node will be
cached and set in the container rootfs.
Signed-off-by: Oguz Bektas
---
v1->v2:
* s/zone1970/zone/
* use 'pve-ct-timezone' format instead of 'timezone' format directly
* avoid IO if target is already set to correct zone
* create a tmpf
it according to \t while doing the comparison)
* add thomas' suggestions about atomic move on tmpfile before doing
symlink
* add 'pve-ct-timezone' format in pve-container to special-case the
'host' setting without breaking 'timezone' format in pve-common for more
ge
with 3 modes;
- CT managed (no action)
- match host (use same timezone as host)
- select from list
also move 'UTC' to the top of the TimezoneStore for convenience
Signed-off-by: Oguz Bektas
---
v1->v2:
no changes
src/Makefile | 1 +
src/data/TimezoneStore.js
/usr/share/zoneinfo/zone.tab has the valid list of time zones.
Signed-off-by: Oguz Bektas
---
v1->v2:
* don't use array for verifying format
src/PVE/JSONSchema.pm | 19 +++
1 file changed, 19 insertions(+)
diff --git a/src/PVE/JSONSchema.pm b/src/PVE/JSONSchema.
this allows us to set the timezone of a container in the options menu.
Signed-off-by: Oguz Bektas
---
v1->v2:
no changes
www/manager6/lxc/Options.js | 13 +
1 file changed, 13 insertions(+)
diff --git a/www/manager6/lxc/Options.js b/www/manager6/lxc/Options.js
index 40bde
hi,
On Tue, Jun 16, 2020 at 04:45:34PM +0200, Thomas Lamprecht wrote:
> Am 6/16/20 um 3:36 PM schrieb Oguz Bektas:
> > optionally enabled.
> >
> > adds the 'timezone' option to config, which takes a valid timezone (i.e.
> > Europe/Vienna) to set in the conta
hi,
On Tue, Jun 16, 2020 at 04:28:05PM +0200, Thomas Lamprecht wrote:
> Am 6/16/20 um 3:36 PM schrieb Oguz Bektas:
> > /usr/share/zoneinfo/zone.tab has the valid list of time zones.
> >
> > Signed-off-by: Oguz Bektas
> > ---
> > src/PVE/JSONSchema.pm | 24 +++
/usr/share/zoneinfo/zone.tab has the valid list of time zones.
Signed-off-by: Oguz Bektas
---
src/PVE/JSONSchema.pm | 24
1 file changed, 24 insertions(+)
diff --git a/src/PVE/JSONSchema.pm b/src/PVE/JSONSchema.pm
index 84fb694..ff97a3d 100644
--- a/src/PVE
with 3 modes;
- CT managed (no action)
- match host (use same timezone as host)
- select from list
also move 'UTC' to the top of the TimezoneStore for convenience
Signed-off-by: Oguz Bektas
---
src/Makefile | 1 +
src/data/TimezoneStore.js | 2 +-
src/panel/Timezo
ime symlink from the host node will be
cached and set in the container rootfs.
Signed-off-by: Oguz Bektas
---
src/PVE/LXC/Config.pm | 5 +
src/PVE/LXC/Setup.pm | 13 +
src/PVE/LXC/Setup/Base.pm | 28 +---
3 files changed, 43 insertions(+), 3 dele
this patch series implements the 'timezone' option for containers.
more detailed info is in the commit messages.
pve-common:
Oguz Bektas (1):
jsonschema: register 'timezone' format and add verification method
src/PVE/JSONSchema.pm | 24
this allows us to set the timezone of a container in the options menu.
Signed-off-by: Oguz Bektas
---
www/manager6/lxc/Options.js | 13 +
1 file changed, 13 insertions(+)
diff --git a/www/manager6/lxc/Options.js b/www/manager6/lxc/Options.js
index 40bde35f..f6e457a3 100644
--- a
renames the 'DNS' step to 'DNS / Time' and allows one to set the
timezone of the container during setup.
Signed-off-by: Oguz Bektas
---
www/manager6/lxc/CreateWizard.js | 16 +---
1 file changed, 13 insertions(+), 3 deletions(-)
diff --git a/www/manager6/lxc/C
we cache the /etc/localtime symlink path from the node and set it in the
container rootfs if zone file exists in the container
Signed-off-by: Oguz Bektas
---
src/PVE/LXC/Setup.pm | 3 +++
src/PVE/LXC/Setup/Base.pm | 20 +---
2 files changed, 20 insertions(+), 3 deletions
in template_fixup we only call this method for version < 7, but greater
versions also need to allow lxc/tty[N] as secure.
Signed-off-by: Oguz Bektas
---
v1->v2:
* call setup_securetty unconditionally
src/PVE/LXC/Setup/CentOS.pm | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
On Mon, May 25, 2020 at 02:24:34PM +0200, Thomas Lamprecht wrote:
> On 5/25/20 2:15 PM, Oguz Bektas wrote:
> > in template_fixup we only call this method for version < 7, but greater
> > versions also need to allow lxc/tty[N] as secure.
> >
> > Signed-off-by: Oguz Be
in template_fixup we only call this method for version < 7, but greater
versions also need to allow lxc/tty[N] as secure.
Signed-off-by: Oguz Bektas
---
src/PVE/LXC/Setup/CentOS.pm | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/src/PVE/LXC/Setup/CentOS.pm b/src/PVE/
Signed-off-by: Oguz Bektas
---
www/manager6/Utils.js | 3 ++-
www/manager6/form/BusTypeSelector.js| 2 ++
www/manager6/form/ControllerSelector.js | 4 ++--
www/manager6/qemu/CloudInit.js | 4 ++--
www/mobile/QemuSummary.js | 2 +-
5 files changed, 9
always be increased without
breaking anything (although the same isn't valid for decreasing it).
Signed-off-by: Oguz Bektas
---
v1->v2:
* serial can be configured by user
* add missing "id=drive-nvme[X]" in the device string, without this we
can't unplug at a
Signed-off-by: Oguz Bektas
---
PVE/QemuServer/Drive.pm | 25 ++---
1 file changed, 6 insertions(+), 19 deletions(-)
diff --git a/PVE/QemuServer/Drive.pm b/PVE/QemuServer/Drive.pm
index b8a553a..5dc5508 100644
--- a/PVE/QemuServer/Drive.pm
+++ b/PVE/QemuServer/Drive.pm
ll work however...
i'm not sure why this happens, something in qemu isn't being deleted after
removing the device/drive, but `info qtree` and `info qom-tree` do
not show nvme4 after being unplugged.
qemu-server:
Oguz Bektas (2):
fix #2255: add support for nvme emulation
hi,
On Thu, May 14, 2020 at 09:27:31AM +0200, Thomas Lamprecht wrote:
>
> please always include the bug/feature # somewhere as reference, e.g. a
> "fix #2255: ..." ideally in the subject, or at least in the commit message
> would be good.
will do for v2
>
> On
add nvme emulation support for disks.
qemu-server:
Oguz Bektas (1):
add support for nvme emulation
PVE/QemuServer.pm | 20 +---
PVE/QemuServer/Drive.pm | 21 +
2 files changed, 38 insertions(+), 3 deletions(-)
pve-manager:
Oguz Bektas (1):
gui
add nvme to the bus list and relevant spots in gui
Signed-off-by: Oguz Bektas
---
www/manager6/Utils.js | 3 ++-
www/manager6/form/BusTypeSelector.js| 2 ++
www/manager6/form/ControllerSelector.js | 4 ++--
www/manager6/qemu/.Snapshot.js.swp | Bin 0 -> 12
now we can add nvme drives;
nvme0: local-lvm:vm-103-disk-0,size=32G
max number is 8
Signed-off-by: Oguz Bektas
---
PVE/QemuServer.pm | 20 +---
PVE/QemuServer/Drive.pm | 21 +
2 files changed, 38 insertions(+), 3 deletions(-)
diff --git a/PVE
Signed-off-by: Oguz Bektas
---
PVE/AAB.pm | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/PVE/AAB.pm b/PVE/AAB.pm
index 405841b..6620ac8 100644
--- a/PVE/AAB.pm
+++ b/PVE/AAB.pm
@@ -11,8 +11,7 @@ use IPC::Open2;
use IPC::Open3;
use UUID;
use Cwd;
-
-my @BASE_PACKAGES
the given template (different distros can
be chosen as well, f.e. existing alpine container reinstalled as
archlinux).
password or ssh key is required for this, since it calls setup
routines like post_create_hook (otherwise we won't be able to log-in to
CT).
Signed-off-by: Oguz Bektas
---
src/
On Thu, Mar 12, 2020 at 02:18:07PM +0100, Thomas Lamprecht wrote:
> On 3/12/20 2:11 PM, Oguz Bektas wrote:
> > On Tue, Mar 10, 2020 at 11:25:23AM +0100, Thomas Lamprecht wrote:
> >> On 2/19/20 5:07 PM, Oguz Bektas wrote:
> >>> adds a loop after the main fastplu
hi,
On Tue, Mar 10, 2020 at 11:25:23AM +0100, Thomas Lamprecht wrote:
> On 2/19/20 5:07 PM, Oguz Bektas wrote:
> > adds a loop after the main fastplug loop, to check if any of the options
> > are partially fast pluggable.
> >
> > these are defined in $partial_fast_
the first two patches were mistakenly left out during the 4.2 qemu
rebase.
also adds another patch for issue CVE-2019-14378 (heap-based BOF)
Signed-off-by: Oguz Bektas
---
.../0001-util-add-slirp_fmt-helpers.patch | 126
...2-tcp_emu-fix-unsafe-snprintf-usages.patch | 135
hi,
works fine. also tested with symlinks.
i'd remove the extra whitespace near the end though.
Tested-by: Oguz Bektas
On Thu, Mar 12, 2020 at 12:18:18PM +0100, Moayad Almalat wrote:
> Signed-off-by: Moayad Almalat
> ---
> PVE/VZDump.pm | 6 ++
> 1 file changed, 6 insert
On Wed, Mar 11, 2020 at 04:05:22PM +0100, Dominik Csapak wrote:
> [...]
> > diff --git a/debian/patches/series b/debian/patches/series
> > index 651c609..63598ab 100644
> > --- a/debian/patches/series
> > +++ b/debian/patches/series
> > @@ -30,3 +30,7 @@ pve/0029-PVE-Backup-add-vma-backup-format-co
the first two patches were mistakenly left out during the 4.2 qemu
rebase.
also adds another patch for issue CVE-2019-14378 (heap-based BOF)
Signed-off-by: Oguz Bektas
---
.../0001-util-add-slirp_fmt-helpers.patch | 126
...2-tcp_emu-fix-unsafe-snprintf-usages.patch | 135
hi,
On Thu, Mar 05, 2020 at 03:21:11PM +0100, Thomas Lamprecht wrote:
> On 3/5/20 2:16 PM, Oguz Bektas wrote:
> > the first rpool we create during setup with our installer has
> > cachefile=none set.
> >
> > when this isn't specified, zfs defaults to /etc/zfs
#post-298984
Signed-off-by: Oguz Bektas
---
PVE/API2/Disks/ZFS.pm | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/PVE/API2/Disks/ZFS.pm b/PVE/API2/Disks/ZFS.pm
index 551f21a..78484eb 100644
--- a/PVE/API2/Disks/ZFS.pm
+++ b/PVE/API2/Disks/ZFS.pm
@@ -371,7 +371,7 @@ __PACK
Tested-by: Dominik Csapak
Signed-off-by: Oguz Bektas
---
...-fix-memory-leak-when-vnc-disconnect.patch | 1016 +
debian/patches/series |1 +
2 files changed, 1017 insertions(+)
create mode 100644
debian/patches/extra/0003-vnc-fix-memory-lea
Tested-by: Dominik Csapak
Signed-off-by: Oguz Bektas
---
...-fix-memory-leak-when-vnc-disconnect.patch | 1016 +
debian/patches/series |1 +
2 files changed, 1017 insertions(+)
create mode 100644
debian/patches/extra/0003-vnc-fix-memory-lea
and an entry for the corrupted cachefile problem which keeps showing up
in forum posts.
Signed-off-by: Oguz Bektas
---
local-zfs.adoc | 29 +
1 file changed, 29 insertions(+)
diff --git a/local-zfs.adoc b/local-zfs.adoc
index 5cce677..c516db8 100644
--- a/local
e-5] fix ...
that makes it easier to realize when sorting through emails for review
>
> Should i edit the PATCH?
yes, please make it '<= 9' to match with the current branch so we don't
have to do it one more time later :)
>
> > On March 2, 2020 2:51 PM Oguz Be
hi,
i assume this is for the older 5.x branch. you should mention that in
your message.
in the 6.x branch this is already set to '<= 9' so you can do that here
as well.
On Mon, Mar 02, 2020 at 02:33:32PM +0100, Moayad Almalat wrote:
> Signed-off-by: Moayad Almalat
> ---
> src/PVE/LXC/Setup/Cen
hi,
i only received the cover letter here and no patch. perhaps you forgot
to send it?
On Thu, Feb 27, 2020 at 11:01:43PM +0100, Csanádi Norbert wrote:
> From: Norbert Csanadi
>
>
> Norbert Csanadi (1):
> Update Hungarian translation, focused on ProxMox Mail Gateway webUI
>
> hu.po | 1108
On Wed, Feb 19, 2020 at 05:10:54PM +0100, Wolfgang Bumiller wrote:
> On Tue, Feb 18, 2020 at 02:38:52PM +0100, Oguz Bektas wrote:
> > 'stop' mode deactivates the volumes (relevant for LVM backend), and
> > they're not reactivated before trying to mount them for bac
adds a loop after the main fastplug loop, to check if any of the options
are partially fast pluggable.
these are defined in $partial_fast_plug_option
Signed-off-by: Oguz Bektas
---
v1->v2:
* set $changes according to partial_fast_plug result as well as fast_plug result
* do cleanup_pend
allows partial fast plugging of functions as defined in the
$partial_fast_plug_option in qemuserver (and possibly lxc later on)
Signed-off-by: Oguz Bektas
---
v1->v2:
* rename get_partial_fast_plug_map -> get_partial_fast_plug_option
* rename variables in partial_fast_plug for reada
remove safe_string_ne and safe_num_ne code which is now shared in
GuestHelpers. also change all the calls.
Signed-off-by: Oguz Bektas
---
v1->v2:
* use helpers from @EXPORT_OK
src/PVE/LXC.pm | 38 +-
1 file changed, 9 insertions(+), 29 deletions(-)
d
move the safe_string_ne and safe_num_ne functions to guesthelpers to
remove duplicate code.
add the new safe_boolean_ne and typesafe_ne helper functions
also add them in @EXPORT_OK
Signed-off-by: Oguz Bektas
---
v1->v2:
* add new helpers to @EXPORT_OK for easy use
* add a die to typesafe
removes safe_string_ne and safe_num_ne code which is now shared in
GuestHelpers. also change all the calls to use the shared definitions.
Signed-off-by: Oguz Bektas
---
v1->v2:
* use helpers from @EXPORT_OK
PVE/QemuServer.pm | 86 ++-
1 f
'stop' mode deactivates the volumes (relevant for LVM backend), and
they're not reactivated before trying to mount them for backup.
reactivating the volumes before the mount in 'stop' mode backup solves
the issue.
Signed-off-by: Oguz Bektas
---
src/PVE/VZDump/LXC.pm
this might not be working correctly, please wait before applying
On Tue, Feb 18, 2020 at 01:35:21PM +0100, Oguz Bektas wrote:
> when doing a 'stop' backup with an LVM backend, volumes are deactivated
> by the stop operation. they're not activated before the backup, whic
rum.proxmox.com/threads/problem-backups-proxmox-6-1.65317/
Signed-off-by: Oguz Bektas
---
PVE/VZDump.pm | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/PVE/VZDump.pm b/PVE/VZDump.pm
index 87d4b699..514f432b 100644
--- a/PVE/VZDump.pm
+++ b/PVE/VZDump.pm
@@ -757,
hi,
On Thu, Feb 13, 2020 at 11:16:31AM +0100, Stefan Reiter wrote:
> On 1/28/20 4:03 PM, Oguz Bektas wrote:
> > move the safe_string_ne and safe_num_ne functions to guesthelpers to
> > remove duplicate code.
> >
> > add the new safe_boolean_ne and typesafe_ne helper fu
* rephrase some parts.
* update old information
* add info about pending changes and other "new" features
Co-Authored-by: Aaron Lauterer
Co-Authored-by: Thomas Lamprecht
Signed-off-by: Oguz Bektas
---
v2->v3:
* move info about disabling apparmor further down
* add suggested
"PVE Cluster Resource Manager Daemon" should be "PVE Cluster HA Resource
Manager Daemon"
[0]: https://forum.proxmox.com/threads/typo-omission.65107/
Signed-off-by: Oguz Bektas
---
debian/pve-ha-crm.service | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff -
hi,
On Fri, Feb 07, 2020 at 09:03:50AM +0100, Thomas Lamprecht wrote:
> On 2/6/20 3:25 PM, Oguz Bektas wrote:
> > original commits and email can be found here[0]
> >
> > A out-of-bounds heap buffer access issue was found in the SLiRP
> > networking implementation of t
apparently sometimes users have problems reaching outside internet with
some network setups. this is the workaround a user suggested that
we should add in the wiki.
Signed-off-by: Oguz Bektas
---
v1->v2:
* add more rationale as suggested by stoiko
* fix indent on one line in the example con
On Thu, Feb 06, 2020 at 05:15:18PM +0100, Thomas Lamprecht wrote:
> On 2/6/20 5:13 PM, Oguz Bektas wrote:
> >> Further, while this resolves the issue of a broken config in general the
> >> underlying "when are config property values equal" is not solved. I can
&g
property strings the same way (i.e., sorted) - that would be possible
> cheaper but not solve that effect for all clients using the API.
>
but still if you want i can take a look at implementing that soon.
> > 0: https://pve.proxmox.com/pipermail/pve-devel/2020-February/041548.htm
use this flaw to crash the Qemu process on the host
resulting in DoS or potentially execute arbitrary code with privileges
of the QEMU process on the host.
[0]: https://seclists.org/oss-sec/2020/q1/64
Signed-off-by: Oguz Bektas
---
.../0003-util-add-slirp_fmt-helpers.patch | 126
hi,
any update here?
On Tue, Jan 14, 2020 at 05:47:01PM +0100, Oguz Bektas wrote:
> * rephrase some parts.
> * update old information
> * add info about pending changes and other "new" features
>
> Co-Authored-by: Aaron Lauterer
> Signed-off-by: Oguz Bektas
>
apparently sometimes users have problems reaching outside internet with
some network setups. this is the workaround a user suggested that
we should add in the wiki.
Signed-off-by: Oguz Bektas
---
pve-network.adoc | 9 +
1 file changed, 9 insertions(+)
diff --git a/pve-network.adoc b
instead of calling it while iterating, inbetween the loops is a better
place in terms of similarity with qemu side (also this should fix the bug that
dominik found[0])
[0]: https://pve.proxmox.com/pipermail/pve-devel/2020-February/041573.html
Signed-off-by: Oguz Bektas
---
src/PVE/LXC
node ''
Signed-off-by: Oguz Bektas
---
PVE/API2/Qemu.pm | 10 ++
1 file changed, 6 insertions(+), 4 deletions(-)
diff --git a/PVE/API2/Qemu.pm b/PVE/API2/Qemu.pm
index e15c0c3..fe68e87 100644
--- a/PVE/API2/Qemu.pm
+++ b/PVE/API2/Qemu.pm
@@ -2749,10 +2749,12 @@ __PACKAGE__-&
adds a loop after the main fastplug loop, to check if any of the options
are partially fast pluggable.
these are defined in $partial_fast_plug_option
our first use case is the fstrim_cloned_disks option of the
qemu-guest-agent
Signed-off-by: Oguz Bektas
---
PVE/QemuConfig.pm | 7 +++
PVE
removes safe_string_ne and safe_num_ne code which is now shared in
GuestHelpers. also change all the calls
Signed-off-by: Oguz Bektas
---
PVE/QemuServer.pm | 82 ++-
1 file changed, 31 insertions(+), 51 deletions(-)
diff --git a/PVE/QemuServer.pm b
remove safe_string_ne and safe_num_ne code which is now shared in
GuestHelpers. also change all the calls.
Signed-off-by: Oguz Bektas
---
src/PVE/LXC.pm | 36
1 file changed, 8 insertions(+), 28 deletions(-)
diff --git a/src/PVE/LXC.pm b/src/PVE/LXC.pm
move the safe_string_ne and safe_num_ne functions to guesthelpers to
remove duplicate code.
add the new safe_boolean_ne and typesafe_ne helper functions
Signed-off-by: Oguz Bektas
---
these will be used in the partial fast plug function in this series
PVE/GuestHelpers.pm | 49
allows partial fast plugging of functions as defined in the
$partial_fast_plug_option in qemuserver (and possibly lxc later on)
Signed-off-by: Oguz Bektas
---
PVE/AbstractConfig.pm | 44 +++
1 file changed, 44 insertions(+)
diff --git a/PVE
Signed-off-by: Oguz Bektas
---
src/PVE/LXC/Config.pm | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/PVE/LXC/Config.pm b/src/PVE/LXC/Config.pm
index 760ec23..eec6b38 100644
--- a/src/PVE/LXC/Config.pm
+++ b/src/PVE/LXC/Config.pm
@@ -1188,7 +1188,7 @@ sub
hi,
thanks for the review!
On Thu, Jan 23, 2020 at 07:41:11AM +0100, Thomas Lamprecht wrote:
> On 1/22/20 5:37 PM, Oguz Bektas wrote:
> > this patch adds the partial_fast_plug function, which allows to partially
> > fastplug an option with a property string.
> >
> > t
-by: Stefan Reiter
Signed-off-by: Oguz Bektas
---
i added stefan as a co-author for this, to thank for his help debugging and
testing it with me
also please note that i'm sending this as RFC for review only, and it
shouldn't be applied yet since i'm working on generalizing it a bi
so that we handle all the point releases between 8-9
Signed-off-by: Oguz Bektas
---
src/PVE/LXC/Setup/CentOS.pm | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/PVE/LXC/Setup/CentOS.pm b/src/PVE/LXC/Setup/CentOS.pm
index 34430ff..d73c0cf 100644
--- a/src/PVE/LXC/Setup
[0]:
https://forum.proxmox.com/threads/centos-8-1-lxc-unsupported-centos-release.63530/
Signed-off-by: Oguz Bektas
---
src/PVE/LXC/Setup/CentOS.pm | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/PVE/LXC/Setup/CentOS.pm b/src/PVE/LXC/Setup/CentOS.pm
index cc4c5bb
from hotplug_pending we go into 'vmconfig_update_disk', where we check the
hotpluggability of options.
add 'ssd' there as a non-hotpluggable option (since we'd have to unplug/plug to
change the drive type)
Signed-off-by: Oguz Bektas
---
PVE/QemuServer.pm | 3 ++-
1 f
Signed-off-by: Oguz Bektas
---
some thoughts about this, based on our offline discussion with dominik.
this patch currently allows us to hotplug the fstrim option for agent,
when it's the only change.
however if the user changes both the type and this option for example,
it will not hotplu
since we handle errors gracefully now, we don't need to write & save
config every time we change a setting.
Signed-off-by: Oguz Bektas
---
v5 -> v6:
* style nit from fabian
* combine two elsif statements into one, get rid of $new_val and
$old_val from last version (not neede
* rephrase some parts.
* update old information
* add info about pending changes and other "new" features
Co-Authored-by: Aaron Lauterer
Signed-off-by: Oguz Bektas
---
v1->v2:
changed some of the writing in terms of phrasing and style, with
feedback from aaron. thanks!
p
since we handle errors gracefully now, we don't need to write & save
config every time we change a setting.
Signed-off-by: Oguz Bektas
---
v4 -> v5:
changed some stuff according to the feedback from fabian and thomas,
thanks a lot!
* remove forgotten load_config call
* some style
"ACPI" instead of "ACPI " with whitespace.
Signed-off-by: Oguz Bektas
---
tr.po | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/tr.po b/tr.po
index e94b0fa..b2db822 100644
--- a/tr.po
+++ b/tr.po
@@ -8,7 +8,7 @@ msgstr ""
"Project
wrap around code which can possibly fail in evals to handle them
gracefully, and log errors.
Signed-off-by: Oguz Bektas
---
v3 -> v4:
* use $errors parameter while calling vmconfig_apply_pending
PVE/API2/Qemu.pm | 6 ++---
PVE/QemuServer.pm |
for some reason, it will get logged in the
tasklog but the vm will continue booting regardless. the non-applied
change will stay in the pending section of the configuration.
Signed-off-by: Oguz Bektas
---
v3 -> v4:
* add explanation in commit message about behavior change in API
since we handle errors gracefully now, we don't need to write & save
config every time we change a setting.
Signed-off-by: Oguz Bektas
---
PVE/QemuServer.pm | 21 +
1 file changed, 5 insertions(+), 16 deletions(-)
diff --git a/PVE/QemuServer.pm b/PVE/QemuServer
wrap around code which can possibly fail in evals to handle them
gracefully, and log errors.
Signed-off-by: Oguz Bektas
---
PVE/API2/Qemu.pm | 4 ++--
PVE/QemuServer.pm | 61 ---
2 files changed, 44 insertions(+), 21 deletions(-)
diff --git a/PVE
Signed-off-by: Oguz Bektas
---
tr.po | 110 +++---
1 file changed, 44 insertions(+), 66 deletions(-)
diff --git a/tr.po b/tr.po
index 1d67201..e94b0fa 100644
--- a/tr.po
+++ b/tr.po
@@ -8,7 +8,7 @@ msgstr ""
"Project-Id-V
1 - 100 of 479 matches
Mail list logo
