Tested locally in a VM:
The setsid was necessary to give the bash job-control (otherwise Ctrl+C would
simply kill the shell).
Signed-off-by: Stoiko Ivanov
---
unconfigured.sh | 3 +++
1 file changed, 3 insertions(+)
diff --git a/unconfigured.sh b/unconfigured.sh
index ed492c9..e36ffc9 100755
27;' > /etc/zfs/zpool.cache`, `update-initramfs -k all -u`, reboot
Signed-off-by: Stoiko Ivanov
---
This should address multiple reports in the forum (e.g. [0,1,2]), about
containers on ZFS not starting after a reboot (mitigated by setting the correct
cache-file, thus making the pool get impo
sorry - forgot (again :/ ) to add the bugreference:
fix #2796
On Fri, 12 Jun 2020 11:14:38 +0200
Stoiko Ivanov wrote:
> Signed-off-by: Stoiko Ivanov
> ---
> Tested by installing libpve-common-perl=6.0-4 on a buster system w/o
> /etc/aliases and then installing one with this patch
Signed-off-by: Stoiko Ivanov
---
Tested by installing libpve-common-perl=6.0-4 on a buster system w/o
/etc/aliases and then installing one with this patch applied (and the
libproxmox-acme-perl dependency removed).
debian/postinst | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a
and improve the layout by adding flex values and increasing the width.
Signed-off-by: Stoiko Ivanov
---
www/manager6/node/ZFS.js | 16 +---
1 file changed, 13 insertions(+), 3 deletions(-)
diff --git a/www/manager6/node/ZFS.js b/www/manager6/node/ZFS.js
index c978f742..88c285df
pass them to guests).
Additionally the tests were adapted to run successfully.
Signed-off-by: Stoiko Ivanov
---
PVE/API2/Disks/ZFS.pm | 3 +++
PVE/Diskmanage.pm | 8
test/disk_tests/sas/disklist_expected.json | 3 ++-
3 files changed, 13 inser
ger patches could probably be squashed - can gladly send a v2
but am fine if you squash them while applying.
pve-storage:
Stoiko Ivanov (1):
fix #2777 create zpools with stable dev paths
PVE/API2/Disks/ZFS.pm | 3 +++
PVE/Diskmanage.pm | 8
t
If a device has a stable /dev/disk/by-id link use that instead of /dev/sdX
Signed-off-by: Stoiko Ivanov
---
www/manager6/node/ZFS.js | 10 +-
1 file changed, 9 insertions(+), 1 deletion(-)
diff --git a/www/manager6/node/ZFS.js b/www/manager6/node/ZFS.js
index c978f742..b8978559 100644
installer and virtio-block
devices).
The manager patches could probably be squashed - can gladly send a v2
but am fine if you squash them while applying.
pve-storage:
Stoiko Ivanov (1):
fix #2777 add by-id link to disk udev info
PVE/API2/Disks/ZFS.pm | 4 ++--
PVE
pass them to guests).
Additionally the tests were adapted to run successfully.
Signed-off-by: Stoiko Ivanov
---
PVE/API2/Disks/ZFS.pm | 4 ++--
PVE/Diskmanage.pm | 8
test/disk_tests/sas/disklist_expected.json | 3 ++-
3 files change
Signed-off-by: Stoiko Ivanov
---
www/manager6/node/Disks.js | 8
1 file changed, 8 insertions(+)
diff --git a/www/manager6/node/Disks.js b/www/manager6/node/Disks.js
index 555956f6..7a1358ff 100644
--- a/www/manager6/node/Disks.js
+++ b/www/manager6/node/Disks.js
@@ -97,6 +97,14
hide the Serial column (the by-id link contains the same information) and
add flex to all columns
Signed-off-by: Stoiko Ivanov
---
www/manager6/node/ZFS.js | 12 +---
1 file changed, 9 insertions(+), 3 deletions(-)
diff --git a/www/manager6/node/ZFS.js b/www/manager6/node/ZFS.js
index
missed that there was a bugzilla issue for this:
this fixes #2773
On Tue, 2 Jun 2020 10:06:17 +0200
Stoiko Ivanov wrote:
> currently all ebtalbes chains are created with a hardcoded policy of ACCEPT.
> This patch changes the functionality to store the configured policy of a
> ch
chains not generated by pve-firewall (the
ones having an action of 'ignore' in the status-hash).
Reported on the pve-user list:
https://pve.proxmox.com/pipermail/pve-user/2020-May/171731.html
Minimally tested with the example from the thread.
Signed-off-by: Stoiko Ivanov
---
src
From: Antonio Russo
adapted from debian-upstream [0] commit
594e747e14f3051513ea499c40c17cadb5d0e92b
[0] https://salsa.debian.org/zfsonlinux-team/zfs.git
Signed-off-by: Stoiko Ivanov
---
.../patches/0007-Use-installed-python3.patch | 60 +++
debian/patches/series
adapted from debian-upstream [0] commit
53276c973c5e69f75b43371a6c94adc5d9dcfec0
(the systemd sequence is enabled by default since debhelper v10 - see
debhelper(7))
[0] https://salsa.debian.org/zfsonlinux-team/zfs.git
Signed-off-by: Stoiko Ivanov
---
debian/rules | 2 +-
1 file changed, 1
From: Antonio Russo
nfs-kernel-server is required for some tests
Signed-off-by: Stoiko Ivanov
---
debian/control | 2 ++
1 file changed, 2 insertions(+)
diff --git a/debian/control b/debian/control
index d9196716..62ab6221 100644
--- a/debian/control
+++ b/debian/control
@@ -185,6 +185,7
Signed-off-by: Stoiko Ivanov
---
.../0004-import-with-d-dev-disk-by-id-in-scan-service.patch | 4 ++--
upstream | 2 +-
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git
a/debian/patches/0004-import-with-d-dev-disk-by-id-in-scan
=2666
Antonio Russo (3):
Use installed python3
Add dependencies for zfs-test
Refresh debian/not-installed
Stoiko Ivanov (3):
update submodule and patches for zfs-0.8.4
Bump Standards-Version to 4.5.0 (no change).
Remove the unnecessary --with systemd dh opti
ff-by: Stoiko Ivanov
---
debian/control | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/debian/control b/debian/control
index 62ab6221..422b2c52 100644
--- a/debian/control
+++ b/debian/control
@@ -14,7 +14,7 @@ Build-Depends: debhelper (>= 10~),
python3
://salsa.debian.org/zfsonlinux-team/zfs.git
Signed-off-by: Stoiko Ivanov
---
debian/not-installed | 2 ++
1 file changed, 2 insertions(+)
diff --git a/debian/not-installed b/debian/not-installed
index 89061916..db0e5603 100644
--- a/debian/not-installed
+++ b/debian/not-installed
@@ -1,5 +1,6 @@
usr/share/zfs
if a file does not exist PVE::Tools::file_read_firstline returns undef.
This happens e.g. if you install the libpve-network-perl package before
creating the local sdn file.
Signed-off-by: Stoiko Ivanov
---
caught in my journal after installing updates today:
May 05 17:17:20 rosa pvestatd[21735
PVE installation, PMG can run quite happily with a different
kernel (the reporter had this on an openstack instance at OVH).
a quick grep through our codebase showed only the API2::Nodes::Nodeinfo::status
call as user of the memshared property.
Signed-off-by: Stoiko Ivanov
---
reported in our
l.
Tested by creating an unprivileged and a privileged CentOS6 container and
with nesting enabled and disabled for both - the console showed up in
all cases with this fix.
[0] https://wiki.centos.org/About/Product
Signed-off-by: Stoiko Ivanov
---
I shortly considered setting the contents of '
patchqueue.
Signed-off-by: Stoiko Ivanov
---
noticed while trying to cherry-pick a patch for #2546
.../0006-dont-symlink-zed-scripts.patch | 19 ++-
1 file changed, 18 insertions(+), 1 deletion(-)
diff --git a/debian/patches/0006-dont-symlink-zed-scripts.patch
b/debian
From: Mo Zhou
(cherry picked from 7916839f3f9f8735b6ee18ee4e25cf1670963272 [0])
[0] https://salsa.debian.org/zfsonlinux-team/zfs.git
Signed-off-by: Stoiko Ivanov
---
debian/copyright | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/debian/copyright b/debian/copyright
configuration on upgrade
Mo Zhou (1):
Refresh upstream Git repo URL in d/copyright.
Richard Laager (1):
cron: Do not error if already scrubbing
Stoiko Ivanov (1):
Reword ZFS Description
debian/control| 44 +--
debian/copyright
it
Signed-off-by: Stoiko Ivanov
---
debian/tree/zfsutils-linux/usr/lib/zfs-linux/scrub | 7 +--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/debian/tree/zfsutils-linux/usr/lib/zfs-linux/scrub
b/debian/tree/zfsutils-linux/usr/lib/zfs-linux/scrub
index 29b77096..38f071af 10
(cherry-picked and adapted from ff8fbee152caa6b995839dae723dab484c3d295a [0])
[0] https://salsa.debian.org/zfsonlinux-team/zfs.git
Signed-off-by: Stoiko Ivanov
---
debian/control | 44 ++--
1 file changed, 22 insertions(+), 22 deletions(-)
diff --git a
ymlinks to removed zedlets at package
postinst.
(cherry picked and adapted from 5cee380324d74e640d5dd7a360faba3994c8007f [0])
[0] https://salsa.debian.org/zfsonlinux-team/zfs.git
Signed-off-by: Stoiko Ivanov
---
.../0006-dont-symlink-zed-scripts.patch | 12 +++
debian/patc
:
Reviewed-By: Stoiko Ivanov
Tested-By: Stoiko Ivanov
On Thu, 12 Mar 2020 15:49:07 +0100
Thomas Lamprecht wrote:
> On 3/12/20 3:24 PM, Thomas Lamprecht wrote:
> > + } elsif (my $mask =
> > PVE::JSONSchema::get_netmask_bits("netmask$suffix")) {
sorry - hadn't setup the subject prefix for the dab repo!
On Thu, 20 Feb 2020 19:25:48 +0100
Stoiko Ivanov wrote:
> otherwise mail received via TCP (localhost port 25) is not accepted, since
> there is no default smptd_relay_restriction set, which would make the system
> a
ation'
reported via the pve-user list:
https://pve.proxmox.com/pipermail/pve-user/2020-February/171368.html
Signed-off-by: Stoiko Ivanov
---
DAB.pm | 2 ++
1 file changed, 2 insertions(+)
diff --git a/DAB.pm b/DAB.pm
index 3d51c1e..ebc541f 100644
--- a/DAB.pm
+++ b/DAB.pm
@@ -42,6 +42,8 @@
After a (not so) short detour into debian policy and the current state of
policy-rc.d usage:
Thanks for tracking this down so fast (and sorry for introducing the
regression in the first place).
The patch definitely makes sense - and works in my few tests:
Reviewed-By: Stoiko Ivanov
Tested-By
fixed, glitch (missing '||true')
in pve-lxc's postinst script.
[0] https://people.debian.org/~hmh/invokerc.d-policyrc.d-specification.txt
(did not find anything more current, contradicting the information there)
Signed-off-by: Stoiko Ivanov
---
Sent as RFC because I'm not
On Wed, 5 Feb 2020 15:57:13 +0100
Oguz Bektas wrote:
> apparently sometimes users have problems reaching outside internet with
> some network setups. this is the workaround a user suggested that
> we should add in the wiki.
Thanks for the initiative - that does come up indeed every now and then
c/pve/local' is a symlink to
'/etc/pve/nodes/NODENAME' should make the warning more clear.
Signed-off-by: Stoiko Ivanov
---
reported in:
https://forum.proxmox.com/threads/setting-up-cluster-and-certificates-which-order.63955/
I tried explicitly naming both paths for both files, b
s the verification if not (in order to not depend on an
installed clamav package).
Signed-off-by: Stoiko Ivanov
---
v1 -> v2
* changed the check for sigtool's existence to the posix compatible
`command -v $cmd` instead of relying on hardcoded paths (and not using them
during the actu
rmail/pmg-devel/2019-December/000869.html
Stoiko Ivanov (2):
pmg: include clamav cvd files in template
pmg: optionally verify cvd files with sigtool
debian-10.0-pmg-64/Makefile | 13 -
1 file changed, 12 insertions(+), 1 deletion(-)
--
2
ng an image, starting a container from that image and
verifying that clamav-daemon starts up upon first boot.
Signed-off-by: Stoiko Ivanov
---
debian-10.0-pmg-64/Makefile | 12 +++-
1 file changed, 11 insertions(+), 1 deletion(-)
diff --git a/debian-10.0-pmg-64/Makefile b/debian-10.0-p
s the verification if not (in order to not depend on an
installed clamav package).
Signed-off-by: Stoiko Ivanov
---
debian-10.0-pmg-64/Makefile | 1 +
1 file changed, 1 insertion(+)
diff --git a/debian-10.0-pmg-64/Makefile b/debian-10.0-pmg-64/Makefile
index b2ff0b0..87d5e51 100644
--- a/debian-10.0-p
Stoiko Ivanov (3):
buildsys: run lintian for all packages
buildsys: fix lintian warning for proxmox-ve
buildsys: fix lintian warnings for pve-headers
Makefile | 2 +-
debian/control | 5 +++--
2 files changed, 4 insertions(+), 3 deletions(-)
--
2.20.1
Signed-off-by: Stoiko Ivanov
---
Makefile | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Makefile b/Makefile
index 8ca3f52..94c3377 100644
--- a/Makefile
+++ b/Makefile
@@ -21,7 +21,7 @@ ${PVE_DEB}: debian
cp -ar debian/* ${BUILD_DIR}/debian/
echo "git
fix 'description-synopsis-starts-with-article' lintian warning by
simply dropping the article.
Signed-off-by: Stoiko Ivanov
---
debian/control | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/debian/control b/debian/control
index b5a1e3f..f49eb98 100644
--- a/debi
fix 'empty-binary-package' [0] and 'extended-description-line-too-long' [1]
lintian warnings for the pve-headers metapackage.
[0] https://lintian.debian.org/tags/empty-binary-package.html
[1]
https://lintian.debian.org/tags/description-synopsis-starts-with-article.html
S
since the check runs at the same time as the one for existing ESPs and rpool
move the code there.
Signed-off-by: Stoiko Ivanov
---
proxinstall | 120 ++--
1 file changed, 60 insertions(+), 60 deletions(-)
diff --git a/proxinstall b/proxinstall
alog generation from ask_existing_diskconfig_or_abort.
Signed-off-by: Stoiko Ivanov
---
proxinstall | 19 ---
1 file changed, 8 insertions(+), 11 deletions(-)
diff --git a/proxinstall b/proxinstall
index d2abdcd..7eddafb 100755
--- a/proxinstall
+++ b/proxinstall
@@ -10
named pve), since
this would fail if the pool is not importable (e.g. user added only one old
disk from a RAIDZ install to that system.
The alternative of running `zpool labelclear` would potentially destroy data.
Signed-off-by: Stoiko Ivanov
---
proxinstall | 27 +++
1 file
address 2 improvments suggested by Fabian.
Signed-off-by: Stoiko Ivanov
---
proxinstall | 7 ++-
1 file changed, 2 insertions(+), 5 deletions(-)
diff --git a/proxinstall b/proxinstall
index 399faa4..911ee3d 100755
--- a/proxinstall
+++ b/proxinstall
@@ -1767,14 +1767,11 @@ _EOD
recursively unmount testdir before removing it. This prevents the subsequent
call to try to remove files in potentially still bindmounted /proc, /sys, /dev
filesystems.
Signed-off-by: Stoiko Ivanov
---
Makefile | 4
1 file changed, 4 insertions(+)
diff --git a/Makefile b/Makefile
index
'OK' button might lead to unexpected data-loss.
ESPs are identified by their partition-type, using `lsblk`'s json output
The message dialog generation is factored in a sub of its own for later reuse.
Signed-off-by: Stoiko Ivanov
---
debian/control | 2 ++
prox
27;), which starts proxinstall and runs a clear_disk on all disks
found after you confirm. (But this would be a future improvement)
Stoiko Ivanov (6):
fixup 4kn install support
umount testdir recursively in check-* targets
warn users about existing ESPs on unused disks
warn on existing rp
On Wed, Nov 27, 2019 at 07:19:02PM +0100, Thomas Lamprecht wrote:
> On 11/27/19 5:06 PM, Stoiko Ivanov wrote:
> > This patchset adds support for installing on 4kn disks.
> >
> > v1->v2:
> > * Dominik suggested to do it correctly - so i tried, which resulted in a
&g
Signed-off-by: Stoiko Ivanov
---
proxinstall | 16
1 file changed, 12 insertions(+), 4 deletions(-)
diff --git a/proxinstall b/proxinstall
index fec9772..d81d71d 100755
--- a/proxinstall
+++ b/proxinstall
@@ -1294,8 +1294,12 @@ sub extract_data
/sys/block/$dev/size is also given in 512b sectors even for 4kn disks.
Since it surprised me - mention it explicitly in the comment
Signed-off-by: Stoiko Ivanov
---
proxinstall | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/proxinstall b/proxinstall
index 5d02b34..1a5acc5
e consistency in `lsblk`
outputs and the like
* should we still install grub with target i386 on 512b sector disks in
setups that mix 4kn and 512e disks?
Feedback welcome!
Stoiko Ivanov (6):
expand comment on /sys/block/$dev/size
add logical_blocksize to hd_list infos
linewrap bootdevinfo genera
in legacy mode grub fails to install, if any 4kn disk is in the
pool, even if it's not in the first vdev)
* EXT4
[0] http://savannah.gnu.org/bugs/?46700
Signed-off-by: Stoiko Ivanov
---
proxinstall | 58 +++--
1 file changed, 47 insertions(+),
by wiping the partition table after the initial sanity checks regarding
minimal size and blocksize of the device, no data is destroyed for an
install that would fail in any case.
Signed-off-by: Stoiko Ivanov
---
proxinstall | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a
in preparation for 4kn installer support add the logical_blocksize to each
disk found.
Signed-off-by: Stoiko Ivanov
---
proxinstall | 30 +++---
1 file changed, 23 insertions(+), 7 deletions(-)
diff --git a/proxinstall b/proxinstall
index 1a5acc5..fec9772 100755
--- a
vdevs.
Signed-off-by: Stoiko Ivanov
---
proxinstall | 7 +++
1 file changed, 7 insertions(+)
diff --git a/proxinstall b/proxinstall
index 7873ace..b531619 100755
--- a/proxinstall
+++ b/proxinstall
@@ -1354,6 +1354,13 @@ sub extract_data {
$vdev =~ s/ $devname/ $osdev
reate an empty 1M partition on 4k disks (we cannot use it
to install grub with target i386 anyways) for more consistency in `lsblk`
outputs and the like
* should we still install grub with target i386 on 512b sector disks in
setups that mix 4kn and 512e disks?
Feedback welcome!
Stoiko Ivan
/sys/block/$dev/size is also given in 512b sectors even for 4kn disks.
Since it surprised me - mention it explicitly in the comment
Signed-off-by: Stoiko Ivanov
---
proxinstall | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/proxinstall b/proxinstall
index 5d02b34..1a5acc5
Signed-off-by: Stoiko Ivanov
---
proxinstall | 16
1 file changed, 12 insertions(+), 4 deletions(-)
diff --git a/proxinstall b/proxinstall
index 1a5acc5..a0ba91f 100755
--- a/proxinstall
+++ b/proxinstall
@@ -1278,8 +1278,12 @@ sub extract_data
' to the disk's device lines
and installing:
* ZFS RAIDZ1
* ZFS single-disk
* EXT4
[0] http://savannah.gnu.org/bugs/?46700
Signed-off-by: Stoiko Ivanov
---
proxinstall | 58 ++---
1 file changed, 42 insertions(+), 16 deletions(-)
d
On Fri, 22 Nov 2019 19:37:20 +0100
Thomas Lamprecht wrote:
> Do not check for cycles or for self-validation if not in a build
> environment.
>
> The slight drawback is that we also avoid this cycle checks when we
> do (development) testing through the API and don't remeber to set the
> PROXMOX_F
On Fri, 22 Nov 2019 19:05:44 +0100
Thomas Lamprecht wrote:
> On 11/22/19 7:03 PM, Thomas Lamprecht wrote:
> > On 11/22/19 6:21 PM, Stoiko Ivanov wrote:
> >> When validating the parameters (or return values) of an API call against
> >> the
> >> schema we
overriding the warnhandler ($SIG{'__WARN__'}, [0,1]) for the
time when find_cycle runs, to ignore messages starting with
'Unhandled type: GLOB at'. The particular location of and in in Devel::Cycle
might change and is left out of the match.
[0] man perlvar
[1] perldoc -f warn
S
otherwise a warning was issued (when missing /etc/aliases.db) that the system
is using the backward compatible setting of $mydestination for $relay_domain
(see [0]).
[0] http://www.postfix.org/COMPATIBILITY_README.html#relay_domains
Signed-off-by: Stoiko Ivanov
---
proxinstall | 2 ++
1 file
e-manager's postinst script calling newaliases
(to fix the issue for users having installed from our ISO before)
Thanks to Martin for reporting this!
pve-installer:
Stoiko Ivanov (2):
raise postifx main.cf compatibility_level to 2
ensure /etc/aliases.db is generated
proxinstall | 4
When installing from ISO '/etc/aliases' gets written correctly, however
postfix needs '/etc/aliases.db' (generated by running newaliases)
in order to work.
added to the postinst script to fix the issue for users having installed from
the ISO before this fix.
Signed-o
postfix relies on /etc/aliases.db for forwarding mail, without this file
all mails get deferred. (see `man newaliases`)
Signed-off-by: Stoiko Ivanov
---
proxinstall | 2 ++
1 file changed, 2 insertions(+)
diff --git a/proxinstall b/proxinstall
index 6ee3aa0..5d02b34 100755
--- a/proxinstall
On Tue, 22 Oct 2019 09:22:24 +0200
Thomas Lamprecht wrote:
> On 10/21/19 10:11 PM, Stoiko Ivanov wrote:
> > by:
> > * running /usr/bin/newaliases (generating /etc/aliases.db)
> > * setting the compatibility_level to 2
> > ** otherwise a warning was issued with broken
ISO and creating a cronjob which runs 'echo test'
every minute.
Thanks to Martin for reporting this!
[0] http://www.postfix.org/COMPATIBILITY_README.html#relay_domains
Signed-off-by: Stoiko Ivanov
---
proxinstall | 4
1 file changed, 4 insertions(+)
diff --git a/proxinstall b/p
With introducing pmx-hint to pmg as well, by adding a 'pmx-hint' css-class
to proxmox-widget-toolkit, it makes sense to use the definition everywhere.
this patch drops the .pve-hint class from pve's css and replaces all occurences
in the GUI-source.
Signed-off-by: Stoiko Ivanov
--
since we need it in PMG as well - pull it here (and independently
refactor pve-manager)
Signed-off-by: Stoiko Ivanov
---
This patch also got sent to pmg-de...@proxmox.com with the dkim-series
css/ext6-pmx.css | 4
1 file changed, 4 insertions(+)
diff --git a/css/ext6-pmx.css b/css/ext6
Since we need the pve-hint css-class in pmg as well this patchset pulls the
definition into proxmox-widget-toolkit and changes its use throughout
pve-manager.
widget-toolkit:
Stoiko Ivanov (1):
add pmx-hint css class
css/ext6-pmx.css | 4
1 file changed, 4 insertions(+)
pve-manager
orted.' warning)
in Ubuntu-4.15.0-63.72, so it is not as high a priority.
(Discards still don't work for LVS with 2T+ sizes)
Signed-off-by: Stoiko Ivanov
---
This patch fixes the issue on my reproducer. However - given that the
original commit-message indicates to fix an issue introduced
Hi,
Thanks for the patches and the work you put into them.
On a first quick glance the changes look reasonable.
I'll try to take a more detailed look and do some testing in
the coming 1-2 weeks and provide some feedback!
Best Regards,
stoiko
On Tue, 17 Sep 2019 12:44:01 +0200
Daniel Berteaud
f the
available (sub) commands anymore.
By checking if the current argument is a valid prefix of a possible command,
and conditionally not setting the 'ref' hash to undef, the functionality is
restored.
Additionally a small whitespace glitch was fixed.
Signed-off-by: Stoiko
command is a prefix of
a valid command, and returns undef otherwise.
Roughly tested, but 'resolve_cmd' is used in quite a few contexts and its
return values often serve more than one purpose - so I'd be grateful for
a review!
Stoiko Ivanov (2):
CLIHandler: remove spurious abor
The abort currently cannot be reached, instead the error with the same
message (unknown command '$cmdstr') in handle_cmd is raised.
Signed-off-by: Stoiko Ivanov
---
src/PVE/CLIHandler.pm | 1 -
1 file changed, 1 deletion(-)
diff --git a/src/PVE/CLIHandler.pm b/src/PVE/CLIHandle
Editing the kernel commandline is described centrally in the bootloaders
chapter. Refer to it where appropriate (qm-pci-passthrough.adoc).
Additionally update the documentation on ZFS as rpool to the inclusion of
`systemd-boot`
Signed-off-by: Stoiko Ivanov
---
local-zfs.adoc | 20
able for
reading on the command-line (e.g. by creating a manpage out of it, or by
copying it to /usr/share/doc/pve-docs as plain-text) - then we could refer to
the information also in man-pages.
Stoiko Ivanov (2):
Add documentation on bootloaders (systemd-boot)
Refer to the bootloader chapter in
stemd-boot`
Signed-off-by: Stoiko Ivanov
---
sysadmin.adoc | 2 +
system-booting.adoc | 174
2 files changed, 176 insertions(+)
create mode 100644 system-booting.adoc
diff --git a/sysadmin.adoc b/sysadmin.adoc
index 21537f1..e045610 100644
/hostid from the installer into the target system we ensure
that it stays consistent
Signed-off-by: Stoiko Ivanov
---
proxinstall | 3 +++
1 file changed, 3 insertions(+)
diff --git a/proxinstall b/proxinstall
index 97af4b9..b256c6e 100755
--- a/proxinstall
+++ b/proxinstall
@@ -1514,6 +1514,9
by installing twice successfully and comparing ids
Stoiko Ivanov (2):
fix #1603: create a new and unique machine-id
copy /etc/hostid from installer root to target
proxinstall | 5 +
1 file changed, 5 insertions(+)
--
2.20.1
*** BLURB HERE ***
Stoiko Ivanov (2):
fix #1603: create a new
-by: Stoiko Ivanov
---
proxinstall | 4
1 file changed, 4 insertions(+)
diff --git a/proxinstall b/proxinstall
index 380abdf..97af4b9 100755
--- a/proxinstall
+++ b/proxinstall
@@ -1510,6 +1510,10 @@ sub extract_data {
diversion_add($targetdir, "/usr/sbin/update-grub",
/hostid from the installer into the target system we ensure
that it stays consistent
Signed-off-by: Stoiko Ivanov
---
proxinstall | 2 ++
1 file changed, 2 insertions(+)
diff --git a/proxinstall b/proxinstall
index 19d0896..8ac00d0 100755
--- a/proxinstall
+++ b/proxinstall
@@ -1511,6 +1511,8
see machine-id(5). The machine-id serves as a partial replacement to the hostid
(gethostid(3)) used by systemd and should be unique, by not shipping one in the
ISO and generating one after the installation the installer ensures the
uniqueness.
Signed-off-by: Stoiko Ivanov
---
proxinstall | 3
was not shipped in the installed system, which
could lead to unimportable pools if it gets generated later on.
Stoiko Ivanov (2):
fix #1603: create a new and unique machine-id
copy /etc/hostid from installer root to target
proxinstall | 5 +
1 file changed, 5 insertions(+)
--
2.20.1
On Mon, 8 Jul 2019 11:09:38 +0200
Aaron Lauterer wrote:
> Some things that I have seen, mostly regarding style and readability.
Thanks big time - incorporated and will be included in my v2
>
> On 7/5/19 6:31 PM, Stoiko Ivanov wrote:
> > With the recently added support for boot
On Fri, 5 Jul 2019 19:21:52 +0200
Thomas Lamprecht wrote:
> On 7/5/19 6:31 PM, Stoiko Ivanov wrote:
> > With the recently added support for booting ZFS on root on EFI
> > systems via `systemd-boot` the documentation needs adapting (mostly
> > related to editing t
/Booting_a_ZFS_root_file_system_via_UEFI
I was wondering whether we want to make the sysadmin chapter available for
reading on the command-line (e.g. by creating a manpage out of it, or by
copying it to /usr/share/doc/pve-docs as plain-text) - then we could refer to
the information also in man-pages.
Stoiko Ivanov (2):
Add
Editing the kernel commandline is described centrally in the bootloaders
chapter. Refer to it where appropriate (qm-pci-passthrough.adoc).
Additionally update the documentation on ZFS as rpool to the inclusion of
`systemd-boot`
Signed-off-by: Stoiko Ivanov
---
local-zfs.adoc | 20
stemd-boot`
Signed-off-by: Stoiko Ivanov
---
sysadmin.adoc | 2 +
system-booting.adoc | 144
2 files changed, 146 insertions(+)
create mode 100644 system-booting.adoc
diff --git a/sysadmin.adoc b/sysadmin.adoc
index 21537f1..e045610 100644
along with `pvremove -ff` and writing zeroes to the first 16M of all
partitions, which belong to disks selected in the installer run `zpool
labelclear`.
This prevents a failure to boot after installation, if the disks were
previously also used as a zpool called rpool, but in a different configurat
With the recent fixes to the installers initial /dev creation, the installer
and the kernel should now have the same view on the created devices and links
---
proxinstall | 5 +
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/proxinstall b/proxinstall
index 5f4544a..d3b2f7c 100755
to forget sending them next
month ;)
Stoiko Ivanov (2):
clear zpool labels on selected disks' partitions
use by-id diskpath for zpool create
proxinstall | 6 ++
1 file changed, 2 insertions(+), 4 deletions(-)
--
2.20.1
___
pve-devel m
run the kernel-postinst hook once (like we do for update-grub) instead
of once per ESP. This fixes an error (the hook does not write entries for
mounted partitions), and save quite a bit of (un)mounting and copying in case
of multiple ESPs
Signed-off-by: Stoiko Ivanov
---
tested by successfully
In order to add support for booting with ZFS on Root on EFI systems this
patch uses systemd-boot as boot loader.
The rationale for not using grub is that there have been quite a few problems
observed with grub and ZFS, e.g. certain RAID-controllers only having a 32bit
implementation in grub, but Z
1 - 100 of 425 matches
Mail list logo
