Re: [pve-devel] [PATCH storage 3/6] Introduce prune-backups property for directory-based storages

2020-07-06 Thread Thomas Lamprecht
On 07.07.20 08:36, Fabian Grünbichler wrote: > On June 4, 2020 11:08 am, Fabian Ebner wrote: >> @@ -43,6 +43,54 @@ cfs_register_file ('storage.cfg', >> sub { __PACKAGE__->parse_config(@_); }, >> sub { __PACKAGE__->write_config(@_); }); >> >> +my %prune_option = ( >

Re: [pve-devel] [PATCH xtermjs] termproxy: rewrite in rust

2020-07-06 Thread Thomas Lamprecht
On 07.07.20 08:24, Fabian Grünbichler wrote: > On July 7, 2020 6:42 am, Dietmar Maurer wrote: >>> so we have a 'termproxy' crate+binary and a binary package with name >>> 'pve-xtermjs' >> >> This is quite confusing ... > > well, it replaces a 'pve-xtermjs' binary package that ships a 'termproxy' >

Re: [pve-devel] [PATCH xtermjs] termproxy: rewrite in rust

2020-07-06 Thread Thomas Lamprecht
On 06.07.20 12:57, Dominik Csapak wrote: > termproxy is now completely written in rust (instead of perl) but > it is a drop-in replacement > > this contains all other necessary changes to the build-system > for it to successfully build > > Signed-off-by: Dominik Csapak > --- > > changelog needs

Re: [pve-devel] [RFC v2 0/3] nvme emulation

2020-07-06 Thread Thomas Lamprecht
On 06.07.20 13:38, Oguz Bektas wrote: > hi, > > the email i've sent to qemu-discuss list to ask about this issue while > reattaching a drive with the same id has gone unanswered... > > how do we want to proceed with this feature? maybe actually put also the maintainers of nvme in to/cc, I do not

Re: [pve-devel] [PATCH widget-toolkit 2/4] add TimezonePanel for containers

2020-07-06 Thread Thomas Lamprecht
On 06.07.20 11:02, Oguz Bektas wrote: >>> + >>> +initComponent: function() { >>> + var me = this; >>> + >>> + var items = []; >> how's that not just a static >> items: [ >> { ... }, >> ], >> >> definition? >> >> And even if it would need to be in initComponent then to me.items = [ ... ]

[pve-devel] applied: [PATCH access-control 1/2] authkey: use variable instead of hard coded grace period value

2020-07-04 Thread Thomas Lamprecht
Signed-off-by: Thomas Lamprecht --- PVE/AccessControl.pm | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/PVE/AccessControl.pm b/PVE/AccessControl.pm index ae8eaae..78e5cc5 100644 --- a/PVE/AccessControl.pm +++ b/PVE/AccessControl.pm @@ -48,6 +48,7 @@ my

[pve-devel] applied: [PATCH access-control 2/2] partially fix #2825: authkey: rotate if it was generated in the future

2020-07-04 Thread Thomas Lamprecht
. Signed-off-by: Thomas Lamprecht --- PVE/AccessControl.pm | 15 ++- 1 file changed, 14 insertions(+), 1 deletion(-) diff --git a/PVE/AccessControl.pm b/PVE/AccessControl.pm index 78e5cc5..6a85c1a 100644 --- a/PVE/AccessControl.pm +++ b/PVE/AccessControl.pm @@ -149,9 +149,22 @@ sub

[pve-devel] applied: [PATCH manager 2/2] vzdump: set target key for PBS based backups

2020-07-03 Thread Thomas Lamprecht
Signed-off-by: Thomas Lamprecht --- PVE/VZDump.pm | 9 +++-- 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/PVE/VZDump.pm b/PVE/VZDump.pm index 52f40a1b..7a9f1fe0 100644 --- a/PVE/VZDump.pm +++ b/PVE/VZDump.pm @@ -726,6 +726,7 @@ sub exec_backup_task { if ($self

[pve-devel] applied: [PATCH manager 1/2] vzdump: rename tasks 'tarfile' key to 'target'

2020-07-03 Thread Thomas Lamprecht
Even now we can have plain vma files which, while an archive, are not a TARfile. Use the generic (backup) target as key instead. Makes it less confusing to be reused for PBS in a later patch. Signed-off-by: Thomas Lamprecht --- PVE/VZDump.pm | 23 +++ 1 file changed, 11

[pve-devel] applied-series: Re: [PATCH pve-network 0/3] add simple zone plugin

2020-07-03 Thread Thomas Lamprecht
On 01.07.20 09:10, Alexandre Derumier wrote: > This add a new simple plugin, to create standalone/isolated > bridge without any vlan tag. > This can be used for routed setup or NAT bridge (I'll look > to implemented NAT with subnets) > > Tag is now optionnal, and tag value is checked in zone plug

Re: [pve-devel] [PATCH widget-toolkit 2/4] add TimezonePanel for containers

2020-07-02 Thread Thomas Lamprecht
On 02.07.20 14:49, Oguz Bektas wrote: > with 3 modes; > - CT managed (no action) > - match host (use same timezone as host) > - select from list > > also move 'UTC' to the top of the TimezoneStore for convenience > > Signed-off-by: Oguz Bektas > --- > > v2->v3: > * use radiofields > > > > s

[pve-devel] applied: Re: [PATCH qemu] PVE-Backup: remove dirty-bitmap in pvebackup_complete_cb for failed jobs

2020-07-02 Thread Thomas Lamprecht
On 01.07.20 14:17, Dietmar Maurer wrote: > Note: We remove the device from di_list, so pvebackup_co_cleanup does > not handle this case. > --- > pve-backup.c | 6 ++ > 1 file changed, 6 insertions(+) > > applied, thanks! ___ pve-devel mailing list

[pve-devel] applied: Re: [Patch qemu] PVE-Backup: qmp_query_backup - improve monitor output

2020-07-02 Thread Thomas Lamprecht
On 02.07.20 12:00, Dietmar Maurer wrote: > --- > monitor/hmp-cmds.c | 45 +--- > pve-backup.c | 26 + > qapi/block-core.json | 9 +++-- > 3 files changed, 63 insertions(+), 17 deletions(-) > > applied, thanks! __

Re: [pve-devel] Proxmox pveproxy - "to many http header lines" - issues with Cloudflare + latest Chrome

2020-07-01 Thread Thomas Lamprecht
Hi, On 02.07.20 03:46, Victor Hooi wrote: > Hi, > > Google Chrome is rolling out some changes to headers (UA-CH - which causes > extra headers to be included), which seems to be unearthing some latent > issues with Proxmox. Dominik looked into this, and it seems that not only Chrome is at fault

[pve-devel] applied: [PATCH http-server] increase max headers to 64 to cope with modern browsers + proxy combinations

2020-07-01 Thread Thomas Lamprecht
This is mostly a "do not allow infinity headers" limit in the sense of "it's good to have limits". With modern browsers and users behind proxies we may actually get over 30 headers, so increase it for now to 64 - hopefully enough for another decade ;) Signed-off-by: Thom

Re: [pve-devel] [PATCH container] fix #2820: block adding new volume with same id if it's pending delete

2020-07-01 Thread Thomas Lamprecht
On 01.07.20 14:43, Fabian Grünbichler wrote: > On July 1, 2020 2:05 pm, Thomas Lamprecht wrote: >> On 01.07.20 09:11, Fabian Grünbichler wrote: >>> - we can actually just put the new mpX into the pending queue, and >>> remove the entry from the pending deleti

Re: [pve-devel] [PATCH v2 widget-toolkit 3/5] add TimezonePanel for containers

2020-07-01 Thread Thomas Lamprecht
On 17.06.20 15:32, Oguz Bektas wrote: > with 3 modes; > - CT managed (no action) > - match host (use same timezone as host) > - select from list > > also move 'UTC' to the top of the TimezoneStore for convenience > > Signed-off-by: Oguz Bektas > --- > > v1->v2: > no changes > > > src/Makefile

Re: [pve-devel] [PATCH container] fix #2820: block adding new volume with same id if it's pending delete

2020-07-01 Thread Thomas Lamprecht
On 01.07.20 09:11, Fabian Grünbichler wrote: > - we can actually just put the new mpX into the pending queue, and > remove the entry from the pending deletion queue? (it's hotplugging > that is the problem, not queuing the pending change) Even if we could I'm not sure I want to be able to ad

[pve-devel] applied: Re: [PATCH v3 storage 02/13] Extend archive_info to include filename and logfilename

2020-07-01 Thread Thomas Lamprecht
On 30.06.20 10:24, Fabian Ebner wrote: > Only expect the logfilename if the archive has a standard name. > This also gives a mechanism to get an untainted filename. > > archive_info can take either a volume ID or a path as it's > currently implemented. This is useful for vzdump when there > is no

[pve-devel] applied: Re: [PATCH v3 storage 04/13] PBSPlugin: Add print_volid helper

2020-07-01 Thread Thomas Lamprecht
On 30.06.20 10:24, Fabian Ebner wrote: > Signed-off-by: Fabian Ebner > --- > PVE/Storage/PBSPlugin.pm | 13 + > 1 file changed, 9 insertions(+), 4 deletions(-) > > applied, thanks! ___ pve-devel mailing list pve-devel@pve.proxmox.com http

[pve-devel] applied: Re: [PATCH v3 storage 03/13] Add archive_remove

2020-07-01 Thread Thomas Lamprecht
On 30.06.20 10:24, Fabian Ebner wrote: > Signed-off-by: Fabian Ebner > --- > > Changes in v3: > * die if unlink of archive fails > * check whether log file exists before trying to unlink it > * warn if unlink of log file fails > > PVE/Storage.pm | 17 + > 1 file chan

[pve-devel] applied: [PATCH storage 5/5] scan storage: order scanned shares alphabetically

2020-07-01 Thread Thomas Lamprecht
Signed-off-by: Thomas Lamprecht --- PVE/CLI/pvesm.pm | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/PVE/CLI/pvesm.pm b/PVE/CLI/pvesm.pm index c5e2d91..4f934d6 100755 --- a/PVE/CLI/pvesm.pm +++ b/PVE/CLI/pvesm.pm @@ -434,7 +434,7 @@ __PACKAGE__->register_met

[pve-devel] applied: [PATCH storage 2/5] scan_cifs: pass user/pass over environment

2020-07-01 Thread Thomas Lamprecht
As command line argument they are readable by ever user in the same PID namespace. Signed-off-by: Thomas Lamprecht --- PVE/Storage.pm | 11 +-- 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/PVE/Storage.pm b/PVE/Storage.pm index e2a6fd0..42e769a 100755 --- a/PVE

[pve-devel] applied: [PATCH storage 4/5] scan_cifs: do not add NT_STATUS lines to result

2020-07-01 Thread Thomas Lamprecht
Signed-off-by: Thomas Lamprecht --- PVE/CLI/pvesm.pm | 1 - PVE/Storage.pm | 5 +++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/PVE/CLI/pvesm.pm b/PVE/CLI/pvesm.pm index 8c86714..c5e2d91 100755 --- a/PVE/CLI/pvesm.pm +++ b/PVE/CLI/pvesm.pm @@ -504,7 +504,6 @@ __PACKAGE__

[pve-devel] applied: [PATCH storage 1/5] scan_cifs: add workgroup domain independent of user param

2020-07-01 Thread Thomas Lamprecht
they are not really bound to each other Signed-off-by: Thomas Lamprecht --- PVE/Storage.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/PVE/Storage.pm b/PVE/Storage.pm index 9ed8c07..e2a6fd0 100755 --- a/PVE/Storage.pm +++ b/PVE/Storage.pm @@ -1199,10 +1199,10 @@ sub

[pve-devel] applied: [PATCH storage 3/5] scan_cifs: do not enforce password for users

2020-07-01 Thread Thomas Lamprecht
there can be accounts with explicit null password others than the mapped guest account. Signed-off-by: Thomas Lamprecht --- PVE/Storage.pm | 1 - 1 file changed, 1 deletion(-) diff --git a/PVE/Storage.pm b/PVE/Storage.pm index 42e769a..1de2bcb 100755 --- a/PVE/Storage.pm +++ b/PVE/Storage.pm

[pve-devel] applied: Re: [PATCH qemu-server 02/11] update_disksize: make interface leaner

2020-07-01 Thread Thomas Lamprecht
On 20.05.20 10:20, Fabian Ebner wrote: > Pass new size directly, so the function doesn't need to know about > how some hash is organized. And return a message directly, instead > of both size-strings. Also dropped the wantarray, because both > existing callers use the message anyways. > > Signed-o

[pve-devel] applied: Re: [PATCH qemu-server 01/11] sync_disks: fix check

2020-07-01 Thread Thomas Lamprecht
On 20.05.20 10:20, Fabian Ebner wrote: > Signed-off-by: Fabian Ebner > --- > > This is a re-send of a previously stand-alone patch. > > PVE/QemuMigrate.pm | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > applied, thanks! ___ pve-devel

Re: [pve-devel] [PATCH container] fix #2820: block adding new volume with same id if it's pending delete

2020-06-30 Thread Thomas Lamprecht
On 30.06.20 15:56, Oguz Bektas wrote: > do a simple check to see if our $opt is already in the delete section. > When can this even happen? If a delete is pending the real property is still in the config? > Signed-off-by: Oguz Bektas > --- > src/PVE/LXC/Config.pm | 3 +++ > 1 file changed, 3 i

[pve-devel] applied: Re: [PATCH v2 common 1/5] jsonschema: register 'timezone' format and add verification method

2020-06-30 Thread Thomas Lamprecht
On 17.06.20 15:32, Oguz Bektas wrote: > /usr/share/zoneinfo/zone.tab has the valid list of time zones. > > Signed-off-by: Oguz Bektas > --- > > v1->v2: > * don't use array for verifying format > > src/PVE/JSONSchema.pm | 19 +++ > 1 file changed, 19 insertions(+) > > diff --gi

Re: [pve-devel] [PATCH v2 manager] ui: auth: add api token authentication to login window

2020-06-30 Thread Thomas Lamprecht
On 07.05.20 14:28, Tim Marx wrote: > Signed-off-by: Tim Marx > --- > > Notes: > changed since v1: > * store token including the product prefix > * add token id to username to make it more obvious that it's note the > actual user > > www/manager6/Workspace.js | 5 ++ > ww

[pve-devel] applied: Re: [PATCH v3 manager 10/13] Simplify how maxfiles is determined

2020-06-30 Thread Thomas Lamprecht
On 30.06.20 10:24, Fabian Ebner wrote: > No functional change is intended. > The preference order is: option, then storage config, then vzdump defaults. > > Signed-off-by: Fabian Ebner > --- > > IMHO the old method was very confusing. > > PVE/VZDump.pm | 11 --- > 1 file changed, 4 ins

[pve-devel] applied: Re: [PATCH v3 storage 06/13] Whitespace cleanup

2020-06-30 Thread Thomas Lamprecht
On 30.06.20 10:24, Fabian Ebner wrote: > Signed-off-by: Fabian Ebner > --- > PVE/API2/Storage/Status.pm | 65 +++--- > 1 file changed, 32 insertions(+), 33 deletions(-) > > applied, thanks! ___ pve-devel mailing list p

[pve-devel] applied: Re: [PATCH v3 manager 09/13] storage_info: avoid duplication

2020-06-30 Thread Thomas Lamprecht
On 30.06.20 10:24, Fabian Ebner wrote: > Signed-off-by: Fabian Ebner > --- > PVE/VZDump.pm | 19 +-- > 1 file changed, 9 insertions(+), 10 deletions(-) > > applied, thanks! ___ pve-devel mailing list pve-devel@pve.proxmox.com https://

[pve-devel] applied: Re: [PATCH v3 manager 08/13] Die if dumpdir and storage are both defined

2020-06-30 Thread Thomas Lamprecht
On 30.06.20 10:24, Fabian Ebner wrote: > dumpdir will be overwritten if a storage is specified > > Signed-off-by: Fabian Ebner > --- > PVE/VZDump.pm | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > applied, thanks! ___ pve-devel mailin

[pve-devel] applied: Re: [PATCH v2 widget-toolkit] adapt auth utils for proxmox token authentication

2020-06-30 Thread Thomas Lamprecht
On 07.05.20 14:28, Tim Marx wrote: > Signed-off-by: Tim Marx > --- > > Notes: > changed since v1: > * store user info as product independent object > > Utils.js | 23 --- > 1 file changed, 20 insertions(+), 3 deletions(-) > > Had to resolve the merge conflict due t

[pve-devel] applied: Re: [RFC v2 manager] change permissions for non-network cloudinit settings

2020-06-26 Thread Thomas Lamprecht
On 25.06.20 16:48, Mira Limbeck wrote: > With the introduction of VM.Config.Cloudinit we can set the user, > password and an SSH key without VM.Config.Network permission. > Keep the fallback for VM.Config.Network so custom roles don't break. > > Signed-off-by: Mira Limbeck > --- > v2: > - fallba

[pve-devel] applied: Re: [RFC v2 qemu-server] close #2741: add VM.Config.Cloudinit permission

2020-06-26 Thread Thomas Lamprecht
On 25.06.20 16:48, Mira Limbeck wrote: > This allows setting ciuser, cipassword and all other cloudinit settings that > are not part of the network without VM.Config.Network permissions. > Keep VM.Config.Network still as fallback so custom roles that add > VM.Config.Network but not VM.Config.Cloudi

[pve-devel] applied: Re: [RFC v2 access-control] introduce VM.Config.Cloudinit permission

2020-06-26 Thread Thomas Lamprecht
On 25.06.20 16:48, Mira Limbeck wrote: > It is added to PVEVMUser by default. > > Signed-off-by: Mira Limbeck > --- > v2: > - unchanged > > PVE/AccessControl.pm | 1 + > 1 file changed, 1 insertion(+) > > applied, thanks! ___ pve-devel mailing lis

[pve-devel] applied: Re: [PATCH qemu-server] avoid backup command timeout with pbs

2020-06-26 Thread Thomas Lamprecht
On 26.06.20 07:10, Dietmar Maurer wrote: > --- > PVE/VZDump/QemuServer.pm | 2 ++ > 1 file changed, 2 insertions(+) > > applied, thanks! ___ pve-devel mailing list pve-devel@pve.proxmox.com https://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

[pve-devel] applied: Re: [PATCH pve-network] improve status

2020-06-25 Thread Thomas Lamprecht
On 19.06.20 13:47, Alexandre Derumier wrote: > check all plumbing interfaces needed for vnets > > Signed-off-by: Alexandre Derumier > --- > PVE/Network/SDN/Zones.pm| 29 +--- > PVE/Network/SDN/Zones/Plugin.pm | 35 > PVE/Network/SDN/Zones/QinQPlug

[pve-devel] applied widget-toolkit: [PATCH widget-toolkit/manager] move/refactor ZFS related gui components into widget-toolkit

2020-06-25 Thread Thomas Lamprecht
On 25.06.20 13:59, Dominik Csapak wrote: > to be used outside of pve > includes some refactor/rewriting, but the components are not that big, > so it should be rather straightforward > > manager patches depend on widget-toolkit, but they do not conflict > so we could apply manager sometime later >

[pve-devel] applied: Re: [PATCH pve-manager] sdn: fix zone icon in tree view

2020-06-25 Thread Thomas Lamprecht
On 19.06.20 17:50, Alexandre Derumier wrote: > also add status icon: > -pending (yellow triangle) > -error (red cross) > > Signed-off-by: Alexandre Derumier > --- > www/css/ext6-pve.css | 4 > www/manager6/tree/ResourceTree.js | 4 ++-- > 2 files changed, 6 insertions(+), 2

[pve-devel] applied: Re: [PATCH qemu-server 3/3] fix #2794: allow legacy IGD passthrough

2020-06-25 Thread Thomas Lamprecht
On 18.06.20 16:36, Stefan Reiter wrote: > Legacy IGD passthrough requires address 00:1f.0 to not be assigned to > anything on QEMU startup (currently it's assigned to bridge pci.2). > Changing this in general would break live-migration, so introduce a new > hostpci parameter "legacy-igd", which if

[pve-devel] applied: Re: [PATCH qemu-server 2/3] cfg2cmd: hostpci: move code to PCI.pm

2020-06-25 Thread Thomas Lamprecht
On 18.06.20 16:36, Stefan Reiter wrote: > To avoid further cluttering config_to_command with subsequent changes. > > Signed-off-by: Stefan Reiter > --- > PVE/QemuServer.pm | 170 ++ > PVE/QemuServer/PCI.pm | 170

[pve-devel] applied: Re: [PATCH qemu 1/3] fix #2794: Include legacy-igd passthrough fix

2020-06-25 Thread Thomas Lamprecht
On 18.06.20 16:36, Stefan Reiter wrote: > See https://bugs.launchpad.net/qemu/+bug/1882784 > > Signed-off-by: Stefan Reiter > --- > ...ks-Fix-broken-legacy-IGD-passthrough.patch | 34 +++ > debian/patches/series | 1 + > 2 files changed, 35 insertions(+)

[pve-devel] applied-series: Re: [PATCH qemu 1/2] Add some qemu_vfree statements to prevent memory leaks

2020-06-24 Thread Thomas Lamprecht
On 6/22/20 2:54 PM, Stefan Reiter wrote: > Suggested-by: Lars Ellenberg > Signed-off-by: Stefan Reiter > --- > vma-writer.c | 2 ++ > vma.c| 2 ++ > 2 files changed, 4 insertions(+) > > applied series, thanks! ___ pve-devel mailing list pve-

Re: [pve-devel] [PATCH manager v2 2/2] ui: fw: Show warning only if some rule is enabled

2020-06-24 Thread Thomas Lamprecht
Am 6/24/20 um 11:32 AM schrieb Dominic Jäger: > Fixup for #2815: The existence of a rule alone should NOT yet trigger the > warning. Only if it is enabled but the whole firewall for that level is not. > > Signed-off-by: Dominic Jäger > --- > Didn't exist in v1. Not sure if we want this. If yes yo

[pve-devel] applied: [PATCH pve-zsync 1/1] pve-zsync: Flip Source and Dest in functions to so jobs can share Dest

2020-06-24 Thread Thomas Lamprecht
Am 6/16/20 um 8:53 PM schrieb Bruce Wainer: > Signed-off-by: Bruce Wainer > --- > pve-zsync | 42 +- > 1 file changed, 25 insertions(+), 17 deletions(-) > With Wolfgangs T-b/R-b tags: applied, thanks to both! _

[pve-devel] applied-series: [PATCH v7 0/4] add needed changes for backup detail view

2020-06-24 Thread Thomas Lamprecht
Am 6/22/20 um 4:34 PM schrieb Aaron Lauterer: > The first part of this series which touched pve-manager has been applied > with v6 [0][1]. > > Missing are the qemu-server and pve-container patches. With the last > suggestions [2] incorporated it is also necessary to update the > AbstractConfig.pm

[pve-devel] applied: [PATCH installer] fix #2804: add a root shell on tty3

2020-06-24 Thread Thomas Lamprecht
Am 6/19/20 um 4:25 PM schrieb Stoiko Ivanov: > Tested locally in a VM: > The setsid was necessary to give the bash job-control (otherwise Ctrl+C would > simply kill the shell). > > Signed-off-by: Stoiko Ivanov > --- > unconfigured.sh | 3 +++ > 1 file changed, 3 insertions(+) > had quite a sim

Re: [pve-devel] [PATCH qemu-server 3/3] fix #2794: allow legacy IGD passthrough

2020-06-24 Thread Thomas Lamprecht
Am 6/22/20 um 10:17 AM schrieb Stefan Reiter: >>> @@ -89,7 +97,8 @@ sub get_pci_addr_map { >>>   $pci_addr_map = { >>>   piix3 => { bus => 0, addr => 1, conflict_ok => qw(ehci)  }, >>>   ehci => { bus => 0, addr => 1, conflict_ok => qw(piix3) }, # instead  >>> of piix3 on arm >>> -v

[pve-devel] [PATCH qemu-server] vncproxy: allow to request a generated VNC password

2020-06-18 Thread Thomas Lamprecht
64^8 possibilities, which even with millions of guesses per second one would need years of guessing and mostly just DDOS the server with websocket upgrade requests. Signed-off-by: Thomas Lamprecht --- We could also extract the last 8 chars of the ticket, but as that ticket is only secure as a whole

[pve-devel] [PATCH novnc-pve] POV: always request the server to generate a random password

2020-06-18 Thread Thomas Lamprecht
Signed-off-by: Thomas Lamprecht --- mostly sent along to have something to test this also with our implementation, I'd not plan to adopt it during 6.x, for us it does not matters much after all debian/patches/0001-add-pve-specific-js-code.patch | 10 ++ 1 file changed, 6 inser

Re: [pve-devel] [PATCH v2 qemu-server 2/3] CPUConfig: add add_cpu_json_properties()

2020-06-18 Thread Thomas Lamprecht
Am 6/18/20 um 3:44 PM schrieb Stefan Reiter: > Useful for APIs and docs. > > Signed-off-by: Stefan Reiter > --- > PVE/QemuServer/CPUConfig.pm | 10 ++ > 1 file changed, 10 insertions(+) > Ah, fun times adding a new manpage ahead - the ol' dependency dance can begin ;) applied, thanks!

[pve-devel] applied: [PATCH container] fix #2778: use vm_start instead of systemctl to start/restart container

2020-06-18 Thread Thomas Lamprecht
Am 6/18/20 um 4:42 PM schrieb Oguz Bektas: > when a backup task in 'stop' mode is executed, VZDump calls 'start_vm' > sub instead of 'PVE::LXC::vm_start'. > > 'start_vm' however does not follow our regular process but instead uses > systemctl to start the container, which results in the guest hook

Re: [pve-devel] [PATCH qemu-server 3/3] fix #2794: allow legacy IGD passthrough

2020-06-18 Thread Thomas Lamprecht
Am 6/18/20 um 4:36 PM schrieb Stefan Reiter: > Legacy IGD passthrough requires address 00:1f.0 to not be assigned to > anything on QEMU startup (currently it's assigned to bridge pci.2). > Changing this in general would break live-migration, so introduce a new > hostpci parameter "legacy-igd", whic

[pve-devel] applied-series: [PATCH docs 1/2] zfs-local: fix #2704 add disk replacement steps for grub

2020-06-18 Thread Thomas Lamprecht
Am 5/20/20 um 4:05 PM schrieb Aaron Lauterer: > The documentation only covered replacing the disk with systemd-boot but > not if grub is used. > > Signed-off-by: Aaron Lauterer > --- > > Once this is applied and rolled out (in the Wiki), we should remove the > old steps in the ZFS tips and trick

Re: [pve-devel] [PATCH v6 qemu-server] vzdump: move include logic for volumes to method

2020-06-18 Thread Thomas Lamprecht
Am 6/17/20 um 2:13 PM schrieb Aaron Lauterer: > Move the logic which volumes are included in the backup job to its own > method and adapt the VZDump code accordingly. This makes it possible to > develop other features around backup jobs. > > Signed-off-by: Aaron Lauterer > --- > > v5 -> v6: crea

Re: [pve-devel] [PATCH v2 0/6] Custom CPU models API/GUI basics

2020-06-17 Thread Thomas Lamprecht
Am 5/4/20 um 12:58 PM schrieb Stefan Reiter: > Permission handling, the beginnings of the API and getting the GUI to play > nice > with custom models (no editor yet, but it'll behave as expected if a > determined > user creates a custom model by editing the config). > > First 3 patches are API s

[pve-devel] applied-series: [PATCH v2 manager 3/6] api: register /nodes/X/cpu call for CPU models

2020-06-17 Thread Thomas Lamprecht
Am 6/17/20 um 3:19 PM schrieb Stefan Reiter: > On 6/17/20 3:12 PM, Thomas Lamprecht wrote: >> Am 6/10/20 um 3:40 PM schrieb Stefan Reiter: >>> Ping on this? The API part in qemu-server was already applied, but it's not >>> callable without this (and not ver

[pve-devel] applied: [PATCH v6 manager 2/2] vzdump: test: adapt and add more tests that are possible now

2020-06-17 Thread Thomas Lamprecht
Am 6/17/20 um 2:13 PM schrieb Aaron Lauterer: > Now, with the logic for `all` and `exclude` in the same single method, > additional tests for these cases are possible. > > Adapt to hash return value of `get_included_guests`. > > Signed-off-by: Aaron Lauterer > --- > > v5 -> v6: adapt call to PV

[pve-devel] applied: [PATCH v6 manager 1/2] vzdump: move remaining guest include logic to single method

2020-06-17 Thread Thomas Lamprecht
Am 6/17/20 um 2:13 PM schrieb Aaron Lauterer: > The `guest include` logic handling `all` and `exclude` parameters was in > the `PVE::VZDump->exec_backup()` method. Moving this logic into the > `get_included_guests` method allows us to simplify and generalize it. > > This helps to make the overall

Re: [pve-devel] [PATCH v2 manager 3/6] api: register /nodes/X/cpu call for CPU models

2020-06-17 Thread Thomas Lamprecht
Am 6/10/20 um 3:40 PM schrieb Stefan Reiter: > Ping on this? The API part in qemu-server was already applied, but it's not > callable without this (and not very useful without the GUI patches). what about the replues to 2/6 - I though some api paths are moving or the like? __

Re: [pve-devel] [PATCH v5 manager 1/2] vzdump: move remaining guest include logic to single method

2020-06-17 Thread Thomas Lamprecht
Am 6/15/20 um 4:02 PM schrieb Aaron Lauterer: > > > On 6/5/20 8:39 PM, Thomas Lamprecht wrote: >> On 5/6/20 11:57 AM, Aaron Lauterer wrote: > [...] >>> @@ -1169,34 +1158,39 @@ sub get_included_guests { >>>     my $nodename = PVE::INotify::nodename(); &

Re: [pve-devel] [PATCH container 2/5] fix #1423: add timezone config option

2020-06-17 Thread Thomas Lamprecht
Am 6/17/20 um 2:48 PM schrieb Oguz Bektas: >>> diff --git a/src/PVE/LXC/Setup.pm b/src/PVE/LXC/Setup.pm >>> index c738e64..0e07796 100644 >>> --- a/src/PVE/LXC/Setup.pm >>> +++ b/src/PVE/LXC/Setup.pm >>> @@ -5,6 +5,8 @@ use warnings; >>> use POSIX; >>> use PVE::Tools; >>> >>> +use Cwd 'abs_path

Re: [pve-devel] [PATCH common 1/5] jsonschema: register 'timezone' format and add verification method

2020-06-17 Thread Thomas Lamprecht
Am 6/17/20 um 2:34 PM schrieb Oguz Bektas: > hi, > > On Tue, Jun 16, 2020 at 04:28:05PM +0200, Thomas Lamprecht wrote: >> Am 6/16/20 um 3:36 PM schrieb Oguz Bektas: >>> /usr/share/zoneinfo/zone.tab has the valid list of time zones. >>> >>> Signed

[pve-devel] applied: [PATCH qemu-server 2/2] properly parse 'vga' for termproxy

2020-06-17 Thread Thomas Lamprecht
Am 6/17/20 um 10:41 AM schrieb Fabian Grünbichler: > 'vga' is a property string, we can't just assume it starts with the default > key's value here either. > > Signed-off-by: Fabian Grünbichler > --- > PVE/API2/Qemu.pm | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > applied, th

[pve-devel] applied: [PATCH qemu-server 1/2] fix #2787: properly parse 'vga' for vncproxy

2020-06-17 Thread Thomas Lamprecht
Am 6/17/20 um 10:41 AM schrieb Fabian Grünbichler: > 'vga' is a property string, we can't just assume it starts with the > default key's value. > > Signed-off-by: Fabian Grünbichler > --- > PVE/API2/Qemu.pm | 13 + > 1 file changed, 9 insertions(+), 4 deletions(-) > applied, thanks

[pve-devel] applied: [PATCH manager] fix #2784: always compare ACME domains in lower case

2020-06-17 Thread Thomas Lamprecht
Am 6/17/20 um 11:15 AM schrieb Fabian Grünbichler: > otherwise the ACME endpoint might return the ordered domain in lower > case and we fail to find our plugin config. > > Signed-off-by: Fabian Grünbichler > --- > PVE/API2/ACME.pm | 4 +++- > PVE/NodeConfig.pm | 9 - > 2 files changed,

[pve-devel] applied: [PATCH manager] fix #2771: relax cert API endpoints permissions

2020-06-17 Thread Thomas Lamprecht
Am 6/17/20 um 11:42 AM schrieb Fabian Grünbichler: > allow users with Sys.Modify to modify custom or ACME certificates. those > users can already hose the system in plenty of ways, no reason to > restrict this in particular to being root@pam only. > > Signed-off-by: Fabian Grünbichler > --- > PV

[pve-devel] applied: [PATCH manager 1/2] ui: use pmxDiskSelector from widget-toolkit

2020-06-16 Thread Thomas Lamprecht
Am 6/16/20 um 11:06 AM schrieb Dominik Csapak: > Signed-off-by: Dominik Csapak > --- > www/manager6/Makefile | 1 - > www/manager6/ceph/OSD.js | 6 +-- > www/manager6/form/DiskSelector.js | 80 --- > www/manager6/node/Directory.js| 2 +- > w

[pve-devel] applied: [PATCH manager 2/2] ui: use pmxDiskList from widget-toolkit

2020-06-16 Thread Thomas Lamprecht
Am 6/16/20 um 11:06 AM schrieb Dominik Csapak: > Signed-off-by: Dominik Csapak > --- > www/manager6/Makefile | 1 - > www/manager6/node/Config.js | 3 +- > www/manager6/node/Disks.js | 387 > 3 files changed, 2 insertions(+), 389 deletions(-) > del

[pve-devel] applied: [PATCH manager] dc/Tasks: pass endtime to make duration calculation correct

2020-06-16 Thread Thomas Lamprecht
Signed-off-by: Thomas Lamprecht --- www/manager6/dc/Tasks.js | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/www/manager6/dc/Tasks.js b/www/manager6/dc/Tasks.js index b1441a72..6708d67d 100644 --- a/www/manager6/dc/Tasks.js +++ b/www/manager6/dc/Tasks.js @@ -44,7 +44,8

Re: [pve-devel] [PATCH container 2/5] fix #1423: add timezone config option

2020-06-16 Thread Thomas Lamprecht
Am 6/16/20 um 3:36 PM schrieb Oguz Bektas: > optionally enabled. > > adds the 'timezone' option to config, which takes a valid timezone (i.e. > Europe/Vienna) to set in the container. > > if nothing is selected, then it will show as 'container managed' in > GUI, and nothing will be done. > > if

Re: [pve-devel] [PATCH common 1/5] jsonschema: register 'timezone' format and add verification method

2020-06-16 Thread Thomas Lamprecht
Am 6/16/20 um 3:36 PM schrieb Oguz Bektas: > /usr/share/zoneinfo/zone.tab has the valid list of time zones. > > Signed-off-by: Oguz Bektas > --- > src/PVE/JSONSchema.pm | 24 > 1 file changed, 24 insertions(+) > > diff --git a/src/PVE/JSONSchema.pm b/src/PVE/JSONSchema.

[pve-devel] applied: [PATCH widget-toolkit 2/2] add DiskSmart window and DiskList from PVE

2020-06-16 Thread Thomas Lamprecht
Am 6/16/20 um 11:06 AM schrieb Dominik Csapak: > for use with other produts. > > the models are now all prefixed with 'pmx' instead of pve, so they > should not conflict > > includes some changes to the model for remapping some fields and > some small refactors (change to controller for the DiskL

[pve-devel] applied: [PATCH widget-toolkit 1/2] add DiskSelector from PVE

2020-06-16 Thread Thomas Lamprecht
Am 6/16/20 um 11:06 AM schrieb Dominik Csapak: > to be usable with other products. > also add a parameter 'typeProperty' to be able to configure > the backend property for the usage type > > Signed-off-by: Dominik Csapak > --- > src/Makefile | 1 + > src/form/DiskSelector.js | 80 ++

[pve-devel] applied: [PATCH widget-toolkit v2 3/4] TaskViewer: show endtime and duration in status

2020-06-16 Thread Thomas Lamprecht
Am 6/16/20 um 12:26 PM schrieb Dominik Csapak: > On 6/16/20 11:19 AM, Thomas Lamprecht wrote: >> Am 6/15/20 um 4:07 PM schrieb Dominik Csapak: >>> but only when the caller gives us the endtime, since the status >>> api call does not give us the endtime >>&g

Re: [pve-devel] [PATCH widget-toolkit v2 3/4] TaskViewer: show endtime and duration in status

2020-06-16 Thread Thomas Lamprecht
Am 6/15/20 um 4:07 PM schrieb Dominik Csapak: > but only when the caller gives us the endtime, since the status > api call does not give us the endtime > > Signed-off-by: Dominik Csapak > --- > changes from v1: > * always show duration and calculate the endtime from 'now' > > src/node/Tasks.js

[pve-devel] applied: [PATCH widget-toolkit v2 4/4] format_duration_human: say <0.1s instead of 0s

2020-06-16 Thread Thomas Lamprecht
Am 6/15/20 um 4:07 PM schrieb Dominik Csapak: > if we get a duration of <=0.1s it should actually be somewhere > betweeen 0 and 0.1 so return <0.1s > > Signed-off-by: Dominik Csapak > --- > changes from v1: > * change <1s to <0.1s which is more inline with our normal display (e.g. 1.5s) > > src

[pve-devel] applied: [PATCH widget-toolkit v2 2/4] show Task warnings differently

2020-06-16 Thread Thomas Lamprecht
Am 6/15/20 um 4:07 PM schrieb Dominik Csapak: > tasks can now show also 'WARNINGS: ' > filter it out and provide a 'parse_task_status' function for easy reuse > > Signed-off-by: Dominik Csapak > --- > src/Utils.js | 17 + > src/css/ext6-pmx.css | 4 > src/node/Tasks

[pve-devel] applied: [PATCH widget-toolkit v2 1/4] ProxmoxProxy: add duration fields for proxmox-tasks

2020-06-16 Thread Thomas Lamprecht
Am 6/15/20 um 4:07 PM schrieb Dominik Csapak: > Signed-off-by: Dominik Csapak > --- > changes from v1: > * do not truncate the decimal places > src/data/ProxmoxProxy.js | 12 > 1 file changed, 12 insertions(+) > applied, thanks! ___ pve-

[pve-devel] applied: [PATCH common] debian/postinst: check for existing /etc/aliases

2020-06-15 Thread Thomas Lamprecht
Am 6/12/20 um 11:14 AM schrieb Stoiko Ivanov: > Signed-off-by: Stoiko Ivanov > --- > Tested by installing libpve-common-perl=6.0-4 on a buster system w/o > /etc/aliases and then installing one with this patch applied (and the > libproxmox-acme-perl dependency removed). > debian/postinst | 2 +- >

[pve-devel] applied: [PATCH pve-manager] api : cluster resources: add sdn audit permission

2020-06-15 Thread Thomas Lamprecht
Am 6/12/20 um 1:31 PM schrieb Alexandre Derumier: > Signed-off-by: Alexandre Derumier > --- > PVE/API2/Cluster.pm | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/PVE/API2/Cluster.pm b/PVE/API2/Cluster.pm > index 76560fa4..062ca849 100644 > --- a/PVE/API2/Cluster.pm > +++

[pve-devel] applied: [PATCH pve-manager] sdn: browser: fix Permissions.Modify

2020-06-15 Thread Thomas Lamprecht
Am 6/12/20 um 11:58 AM schrieb Alexandre Derumier: > Signed-off-by: Alexandre Derumier > --- > www/manager6/sdn/Browser.js | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) applied, thanks! ___ pve-devel mailing list pve-devel@pve.proxmox.co

[pve-devel] applied: [PATCH pve-access-control] api2: AccessControl: add sdn permissions.modify

2020-06-15 Thread Thomas Lamprecht
Am 6/12/20 um 11:53 AM schrieb Alexandre Derumier: > Signed-off-by: Alexandre Derumier > --- > PVE/API2/AccessControl.pm | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > applied, thanks! ___ pve-devel mailing list pve-devel@pve.proxmox.com h

Re: [pve-devel] [PATCH widget-toolkit 4/4] format_duration_human: say <1s instead of 0s

2020-06-15 Thread Thomas Lamprecht
Am 6/12/20 um 1:29 PM schrieb Dominik Csapak: > if we get a duration of <=0s it should actually be somewhere > betweeen 0 and 1s so return <1s Hmm, I get where you come from it was initially just as a safe guard and 0s should be understandable as well if start and endtime is shown the same. If we

Re: [pve-devel] [PATCH widget-toolkit 3/4] TaskViewer: show endtime and duration in status

2020-06-15 Thread Thomas Lamprecht
Am 6/12/20 um 1:29 PM schrieb Dominik Csapak: > but only when the caller gives us the endtime, since the status > api call does not give us the endtime > > Signed-off-by: Dominik Csapak > --- > src/node/Tasks.js| 1 + > src/window/TaskViewer.js | 23 +++ > 2 files ch

Re: [pve-devel] [PATCH widget-toolkit 1/4] ProxmoxProxy: add duration fields for proxmox-tasks

2020-06-15 Thread Thomas Lamprecht
Am 6/12/20 um 1:29 PM schrieb Dominik Csapak: > Signed-off-by: Dominik Csapak > --- > src/data/ProxmoxProxy.js | 12 > 1 file changed, 12 insertions(+) > > diff --git a/src/data/ProxmoxProxy.js b/src/data/ProxmoxProxy.js > index 53e92f3..40fdc08 100644 > --- a/src/data/ProxmoxProxy.

[pve-devel] applied: [PATCH common] fix #2374: bridge-ports is assumed to be defined

2020-06-15 Thread Thomas Lamprecht
Am 6/10/20 um 4:03 PM schrieb Mira Limbeck: > bridge-ports is an optional parameter but was assumed to be defined in > the code. This resulted in 'use of uninitialized value' warnings. > > By reordering of the $ports definition before the replace, we get rid of > the 'use of uninitialized value' w

Re: [pve-devel] [PATCH v2 storage 05/13] Add prune_backups to storage API

2020-06-15 Thread Thomas Lamprecht
Am 6/10/20 um 1:23 PM schrieb Fabian Ebner: > Implement it for generic storages supporting backups > (i.e. directory-based storages) and add a wrapper for PBS. > > Signed-off-by: Fabian Ebner > --- > > Changes in v2: > * Return actual volid in PBS using the new print_volid helper > * Spl

Re: [pve-devel] [PATCH v2 storage 03/13] Add archive_remove

2020-06-15 Thread Thomas Lamprecht
Am 6/10/20 um 1:23 PM schrieb Fabian Ebner: > to keep the removal of the archive and its log file together. > > Signed-off-by: Fabian Ebner > --- > > New in v2 > > PVE/Storage.pm | 11 +++ > 1 file changed, 11 insertions(+) > > diff --git a/PVE/Storage.pm b/PVE/Storage.pm > index ac0d

Re: [pve-devel] Adding creation time as metadata field to VM/containers?

2020-06-09 Thread Thomas Lamprecht
Hi, On 6/9/20 11:13 PM, Victor Hooi wrote: > Hi, > > Is there any chance of adding creation time as a queryable metadata field > for VMs/containers? > > The use-case for us is - we want to know the overall age of a machine, for > things like patching schedules etc. (We want to auto-kill machines

[pve-devel] applied: [PATCH access-control] comput coarse UI permissions: also check SDN ones

2020-06-09 Thread Thomas Lamprecht
Signed-off-by: Thomas Lamprecht --- fixes: https://forum.proxmox.com/threads/proxmox-6-2-sdn-beta-test.69655/page-8#post-318789 PVE/API2/AccessControl.pm | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/PVE/API2/AccessControl.pm b/PVE/API2/AccessControl.pm index

Re: [pve-devel] Integration of FreeNAS iSCSI target initiator in Proxmox Enterprise repo

2020-06-09 Thread Thomas Lamprecht
On 6/8/20 5:16 PM, Michael Rasmussen wrote: > On Mon, 8 Jun 2020 15:00:11 +0200 > Thomas Lamprecht wrote: > >> >> You can effectively provide a full custom plugin, so it has not more >> limitations than any existing one. What extra functionality regarding >>

[pve-devel] applied: Re: [PATCH pve-common] Inotify: write_network_interfaces : always autostart bond slaves interfaces

2020-06-08 Thread Thomas Lamprecht
On 6/7/20 1:39 PM, Alexandre Derumier wrote: > Currently, bond slaves are mostly working without autostart, > because bond slaves scripts from ifupdown1 && also ifupdown2 > have some kind of hacks to start the slaves. > > But if users want to do some tuning on the ifaces, they are not applied. >

Re: [pve-devel] [PATCH proxmox-widget-toolkit] networkedit: display mtu for ovsbond too

2020-06-08 Thread Thomas Lamprecht
On 6/7/20 1:30 PM, Alexandre Derumier wrote: > --- > node/NetworkEdit.js | 23 --- > 1 file changed, 12 insertions(+), 11 deletions(-) > Change looks OK, but I made the repo pass our new eslint JavaScript linter config and moved sources into a src/ directory to separate pack

[pve-devel] applied-series: Re: [PATCH v3 manager 1/2] vzdump: make guest include logic testable

2020-06-08 Thread Thomas Lamprecht
On 6/8/20 3:00 PM, Aaron Lauterer wrote: > As a first step to make the whole guest include logic more testable the > part from the API endpoint has been moved to its own method with as > little changes as possible. > > Everything concerning `all` and `exclude` logic is still in the > PVE::VZDump->

Re: [pve-devel] [PATCH v5 manager 1/2] vzdump: move remaining guest include logic to single method

2020-06-08 Thread Thomas Lamprecht
On 6/8/20 1:55 PM, Aaron Lauterer wrote: >> >> $vmids = [ grep { !$excludehash->{$_} } sort keys $vmlist->{ids}->%* ]; >> >> but no hard feeling here. > > I agree on the early sorting, but I am not sure about that oneliner. It's not > as easy to comprehend what's going on for someone who isn't us

  1   2   3   4   5   6   7   8   9   10   >