Re: [pve-devel] [PATCH] Make qm clone working with devices.

2014-10-26 Thread Dietmar Maurer
+ } elsif (PVE::QemuServer::drive_is_device($drive)) { + $newconf-{$opt} = $value; # simply copy configuration So where do you make a copy of the device data? ___ pve-devel mailing list pve-devel@pve.proxmox.com

Re: [pve-devel] [PATCH] Make qm clone working with devices.

2014-10-26 Thread Jasmin J.
Hi! Wouldn't this cause issues with multiple systems attempting to control the same device simultaneously? Whenever you use software, you need to think. The same applies here. It is possible to clone the VM manually by copying the conf file and the referenced virtual disks. The advantage of

Re: [pve-devel] [PATCH] Make qm clone working with devices.

2014-10-26 Thread Jasmin J.
Hello Dietmar! So where do you make a copy of the device data? I do the same like for CDROMs. This line will copy the configuration entry in the conf file. The device data is on the device and remains there (like it does for CDROMs). BR, Jasmin

Re: [pve-devel] [PATCH] Make qm clone working with devices.

2014-10-26 Thread Michael Rasmussen
On Sun, 26 Oct 2014 11:04:40 +0100 Jasmin J. jas...@anw.at wrote: I intended to use cloning a VM with a device to make a copy of the current state just before I do changes in the VM (e.g: update, install new software). And yes, it might be a problem to start the cloned VM together with the

Re: [pve-devel] [PATCH] Make qm clone working with devices.

2014-10-26 Thread Jasmin J.
Hi! In your case choosing Qcow2 as image format for your VMs seems appropriate since this will give you the choice of doing snapshots of your VMs before doing any changes and the decide after your changes whether to rollback the changes or delete the snapshot. a) We discuss a patch to

Re: [pve-devel] [PATCH] Make qm clone working with devices.

2014-10-26 Thread Dietmar Maurer
So where do you make a copy of the device data? I do the same like for CDROMs. This line will copy the configuration entry in the conf file. The device data is on the device and remains there (like it does for CDROMs). This is not a 'clone', and nothing I want to add.

Re: [pve-devel] [PATCH] Make qm clone working with devices.

2014-10-26 Thread Jasmin J.
This is not a 'clone', and nothing I want to add. And virtual disks are copied to new disks as expected for a clone. Only the disk device content isn't copied. Imagine there is a device with 4TB mapped to a guest. There is no possibility to copy this huge amount of data. When people do disk

Re: [pve-devel] [PATCH] Make qm clone working with devices.

2014-10-26 Thread Dietmar Maurer
Imagine there is a device with 4TB mapped to a guest. There is no possibility to copy this huge amount of data. When people do disk device mappings, they know what they are doing, so indeed they know that a copy will reference the same physical disk. Again, this is not a 'clone'. What

[pve-devel] [PATCH] Make qm clone working with devices.

2014-10-25 Thread Jasmin Jessich
Signed-off-by: Jasmin Jessich jas...@anw.at --- PVE/API2/Qemu.pm | 5 - PVE/QemuServer.pm | 8 2 files changed, 12 insertions(+), 1 deletion(-) diff --git a/PVE/API2/Qemu.pm b/PVE/API2/Qemu.pm index a0fcd28..32ee6de 100644 --- a/PVE/API2/Qemu.pm +++ b/PVE/API2/Qemu.pm @@ -71,6

Re: [pve-devel] [PATCH] Make qm clone working with devices.

2014-10-25 Thread Daniel Hunsaker
Wouldn't this cause issues with multiple systems attempting to control the same device simultaneously? On Oct 25, 2014 12:07 PM, Jasmin Jessich jas...@anw.at wrote: Signed-off-by: Jasmin Jessich jas...@anw.at --- PVE/API2/Qemu.pm | 5 - PVE/QemuServer.pm | 8 2 files changed,