-} else { # hotplug new disks
-
+} elsif (!$old_volid) { # hotplug new disks
die error hotplug $opt if !PVE::QemuServer::vm_deviceplug($storecfg,
$conf, $vmid, $opt, $drive);
}
This does not display any errors if $old_volid is set?
I think we should raise an error to
...@odiso.com]
Sent: Freitag, 29. August 2014 09:25
To: Dietmar Maurer
Cc: pve-devel@pve.proxmox.com
Subject: Re: [pve-devel] [PATCH] don't try to hotplug disk if a disk already
exist.
This does not display any errors if $old_volid is set?
I think we should raise an error to indicate that something
[mailto:aderum...@odiso.com]
Sent: Freitag, 29. August 2014 09:25
To: Dietmar Maurer
Cc: pve-devel@pve.proxmox.com
Subject: Re: [pve-devel] [PATCH] don't try to hotplug disk if a disk already
exist.
This does not display any errors if $old_volid is set?
I think we should raise an error
...@odiso.com
Cc: pve-devel@pve.proxmox.com
Envoyé: Vendredi 29 Août 2014 11:26:00
Objet: RE: [pve-devel] [PATCH] don't try to hotplug disk if a disk already
exist.
what about this:
} else { # hotplug new disks
+ die some useful error mesage if $old_volid;
die error hotplug $opt if !PVE
-
De: Alexandre DERUMIER aderum...@odiso.com
À: Dietmar Maurer diet...@proxmox.com
Cc: pve-devel@pve.proxmox.com
Envoyé: Vendredi 29 Août 2014 12:22:49
Objet: Re: [pve-devel] [PATCH] don't try to hotplug disk if a disk already
exist.
We need also to check if the vm is running and hotplug
