e code more
>>complex)?
yes, for transaction, all drives need to support it.
(so don't work with zfs for example, or mixing rbd and zfs)
- Mail original -
De: "dietmar"
À: "aderumier" , "Wolfgang Link"
Cc: "pve-devel"
Envoyé: Je
> I wonder if we could replace qmp "snapshot-drive" (from
> internal-snapshot-async.patch)
>
> by upstream qemu qmp method
>
> blockdev-snapshot-internal-sync
>
> http://git.qemu.org/?p=qemu.git;a=blob_plain;f=qmp-commands.hx;hb=HEAD
>
> One advantage is that multiple drive can be snapshotted
I still see calls to that function using the $runnig parameter:
PVE/Storage/RBDPlugin.pm:$class->volume_snapshot($scfg, $storeid, $newname,
$snap, $running);
PVE/Storage/SheepdogPlugin.pm:$class->volume_snapshot($scfg, $storeid,
$newname, $snap, $running);
PVE/Storage/ZFSPlugin.pm:$cla
apshot0",
"vm-state-size": 0,
"date-sec": 112,
"date-nsec": 10,
"vm-clock-sec": 100,
"vm-clock-nsec": 20
}
}
- Mail original -
It is better to check if a VM is running in QemuServer then in Storage.
for the Storage there is no difference if it is running or not.
Signed-off-by: Wolfgang Link
---
PVE/QemuServer.pm | 29 +++--
1 file changed, 23 insertions(+), 6 deletions(-)
diff --git a/PVE/QemuSe
It is better to check if a VM is running in QemuServer then in Storage.
for the Storage there is no difference if it is running or not.
Signed-off-by: Wolfgang Link
---
PVE/Storage.pm | 4 ++--
PVE/Storage/ISCSIDirectPlugin.pm | 2 +-
PVE/Storage/LVMPlugin.pm | 2 +-
PV
img
snapshot command while the virtual machine is running.
Otherwise, you can damage the disk image with the state of the virtual machine
saved.
"-
Mail original -
De: "dietmar"
À: "aderumier"
Cc: "pve-devel"
Envoyé: Jeudi 30 Avril 2015 13:11:35
Ob
> > So, with this code, we always call qemu-img snasphot for qcow2, which is
> > wrong
> > if the vm is running.
> > (for rbd,zfs,.. no problem).
> >
> > I think that's why we passed the running flag to pve-storage.
>
> Ah, yes - the logic is wrong, but fixable.
Or is it the other way around? We
> So, with this code, we always call qemu-img snasphot for qcow2, which is wrong
> if the vm is running.
> (for rbd,zfs,.. no problem).
>
> I think that's why we passed the running flag to pve-storage.
Ah, yes - the logic is wrong, but fixable.
___
pve
lag to pve-storage.
- Mail original -
De: "dietmar"
À: "aderumier" , "Wolfgang Link"
Cc: "pve-devel"
Envoyé: Jeudi 30 Avril 2015 12:28:36
Objet: Re: [pve-devel] [PATCH] remove running from Storage and check it in
QemuServer
> + PVE::Storage::vol
> + PVE::Storage::volume_snapshot($storecfg, $volid, $snap) if
> storage_support_snapshop($volid, $storecfg);
>
> This seem to be wrong.
>
> we can't do a qcow2 snapshot with qemu-img if the vm is running, we need to
> use qmp in this case.
Form what I see this case is already handled inside st
> Couldn't we reuse volume_has_feature from storage plugins ?
We can, but this is misleading. It is not a storage feature, it
is a feature of qemu.
___
pve-devel mailing list
pve-devel@pve.proxmox.com
http://pve.proxmox.com/cgi-bin/mailman/listinfo/pve
"
À: "pve-devel"
Envoyé: Jeudi 30 Avril 2015 09:47:03
Objet: [pve-devel] [PATCH] remove running from Storage and check it in
QemuServer
It is better to check if a VM is running in QemuServer then in Storage.
for the Storage there is no difference if it is running or not.
Sig
ot;
À: "pve-devel"
Envoyé: Jeudi 30 Avril 2015 09:47:03
Objet: [pve-devel] [PATCH] remove running from Storage and check it in
QemuServer
It is better to check if a VM is running in QemuServer then in Storage.
for the Storage there is no difference if it is running or not.
Si
> # Note about locking: we use flock on the config file protect
> @@ -3777,7 +3779,7 @@ sub qemu_volume_snapshot {
>
> my $running = check_running($vmid);
>
> -return if !PVE::Storage::volume_snapshot($storecfg, $volid, $snap,
> $running);
> +PVE::Storage::volume_snapshot($storec
It is better to check if a VM is running in QemuServer then in Storage.
for the Storage there is no difference if it is running or not.
Signed-off-by: Wolfgang Link
---
PVE/QemuServer.pm | 21 -
1 file changed, 20 insertions(+), 1 deletion(-)
diff --git a/PVE/QemuServer.pm b
It is better to check if a VM is running in QemuServer then in Storage.
for the Storage there is no difference if it is running or not.
Signed-off-by: Wolfgang Link
---
PVE/Storage.pm | 4 ++--
PVE/Storage/ISCSIDirectPlugin.pm | 2 +-
PVE/Storage/LVMPlugin.pm | 2 +-
PV
17 matches
Mail list logo
