Currently,if we don't have a machine option in running config,
and we take a vmstate snapshot
the machine option is write in the snapshot (ok), but also in the running
config (bad)
Signed-off-by: Alexandre Derumier aderum...@odiso.com
---
PVE/QemuServer.pm |3 ++-
1 file changed, 2
Currently,if we don't have a machine option in running config, and we take a
vmstate snapshot
the machine option is write in the snapshot (ok), but also in the running
config
(bad)
Yes, we should fix this when we create a snapshot.
But your patch also affect rollback, where we have
DERUMIER aderum...@odiso.com
À: Dietmar Maurer diet...@proxmox.com
Cc: pve-devel@pve.proxmox.com
Envoyé: Vendredi 29 Août 2014 09:25:46
Objet: Re: [pve-devel] [PATCH] vmstate snapshot : do no write machine to
running config
For example, in snapshot_rollback(),$forcemachine is wrong because you do
What do you thing about this (looks more obvious to me)?
diff --git a/PVE/QemuServer.pm b/PVE/QemuServer.pm
index 327ea35..b4358b0 100644
--- a/PVE/QemuServer.pm
+++ b/PVE/QemuServer.pm
@@ -4741,6 +4741,8 @@ my $snapshot_commit = sub {
die missing snapshot lock\n
if
] vmstate snapshot : do no write machine to
running config
What do you thing about this (looks more obvious to me)?
diff --git a/PVE/QemuServer.pm b/PVE/QemuServer.pm
index 327ea35..b4358b0 100644
--- a/PVE/QemuServer.pm
+++ b/PVE/QemuServer.pm
@@ -4741,6 +4741,8 @@ my $snapshot_commit = sub
