Re: [pve-devel] [PATCH manager 3/3] fix #427: add notes panel to node

[Thomas Lamprecht]

On 5/22/18 5:02 PM, Dominik Csapak wrote:
> Signed-off-by: Dominik Csapak 
> ---
>  www/manager6/node/Config.js | 13 +
>  1 file changed, 13 insertions(+)
> 
> diff --git a/www/manager6/node/Config.js b/www/manager6/node/Config.js
> index 9e9f49c5..077d543d 100644
> --- a/www/manager6/node/Config.js
> +++ b/www/manager6/node/Config.js
> @@ -125,6 +125,19 @@ Ext.define('PVE.node.Config', {
>   iconCls: 'fa fa-book',
>   itemId: 'summary',
>   xtype: 'pveNodeSummary'
> + },
> + {
> + title: gettext('Notes'),
> + iconCls: 'fa fa-sticky-note-o',
> + itemId: 'notes',
> + xtype: 'panel',
> + items: [
> + {
> + xtype: 'pveNotesView',
> + pveSelNode: me.pveSelNode,
> + border: false
> + }
> + ]
>   }
>   );
>   }
> 

Hmm, do we really want this as full new panel?
Or should it be in integrated in the summary panel?
I honestly expected that you put it there once  I saw this series,
would then be consistent with VMs and CTs...

___
pve-devel mailing list
pve-devel@pve.proxmox.com
https://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

[pve-devel] [PATCH manager 3/3] fix #427: add notes panel to node

[Dominik Csapak]

Signed-off-by: Dominik Csapak 
---
 www/manager6/node/Config.js | 13 +
 1 file changed, 13 insertions(+)

diff --git a/www/manager6/node/Config.js b/www/manager6/node/Config.js
index 9e9f49c5..077d543d 100644
--- a/www/manager6/node/Config.js
+++ b/www/manager6/node/Config.js
@@ -125,6 +125,19 @@ Ext.define('PVE.node.Config', {
iconCls: 'fa fa-book',
itemId: 'summary',
xtype: 'pveNodeSummary'
+   },
+   {
+   title: gettext('Notes'),
+   iconCls: 'fa fa-sticky-note-o',
+   itemId: 'notes',
+   xtype: 'panel',
+   items: [
+   {
+   xtype: 'pveNotesView',
+   pveSelNode: me.pveSelNode,
+   border: false
+   }
+   ]
}
);
}
-- 
2.11.0


___
pve-devel mailing list
pve-devel@pve.proxmox.com
https://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel