On Tue, 13 Jun 2017 09:39:37 +0200
Dominik Csapak wrote:
>
> but a better way for the whole plugin would probably be a credentials
> file with limited read access (so only root can read it)
>
The password is written in /etc/pve/storage.cfg which is -rw-r root
www-data. I cannot see how this
On 06/13/2017 09:01 AM, Michael Rasmussen wrote:
On Mon, 12 Jun 2017 14:18:59 +0200
Dominik Csapak wrote:
i just gave this patch a quick glance, here a few remarks:
a bit nitpicky, but your indentation needs fixing, the FreeNASEdit.js seems
mostly ok, but nearly every other file you touched
On Mon, 12 Jun 2017 14:18:59 +0200
Dominik Csapak wrote:
> i just gave this patch a quick glance, here a few remarks:
>
> a bit nitpicky, but your indentation needs fixing, the FreeNASEdit.js seems
> mostly ok, but nearly every other file you touched has wrong indentation
>
The reason is that
i just gave this patch a quick glance, here a few remarks:
a bit nitpicky, but your indentation needs fixing, the FreeNASEdit.js
seems mostly ok, but nearly every other file you touched has wrong
indentation
other comments inline
On 06/12/2017 03:19 AM, Michael Rasmussen wrote:
Signed-off-b
Signed-off-by: Michael Rasmussen
---
www/manager6/Makefile | 1 +
www/manager6/Utils.js | 4 +-
www/manager6/dc/StorageView.js | 15 +++-
www/manager6/lxc/ResourceEdit.js| 6 +-
www/manager6/qemu/Clone.js | 3 +-
www/manager6/qemu/HDEdit.js
