e
- Mail original -
De: "Thomas Lamprecht"
À: "pve-devel" , "aderumier"
Envoyé: Mercredi 30 Mai 2018 07:39:00
Objet: Re: [pve-devel] [PATCH qemu-server] Fix #1242 : clone_disk : call qga
fstrim after clone
On 5/28/18 5:36 PM, Alexandre Derumier wrote:
>
On 5/28/18 5:36 PM, Alexandre Derumier wrote:
> Some storage like rbd or lvm can't keep thin-provising after a qemu-mirror.
>
> Call qga guest-fstrim if qga is available
Shouldn't the VM internal fstrim cronjob/timer (or windows equivalent)
do this anyway sooner or later?
I mean, although I
hink that a simple "fstrim" button in the gui could be enough.
- Mail original -----
De: "Alwin Antreich"
À: "pve-devel"
Envoyé: Mardi 29 Mai 2018 14:03:09
Objet: Re: [pve-devel] [PATCH qemu-server] Fix #1242 : clone_disk : call qga
fstrim after clone
On Tue,
forward too.
maybe something like qga: clonedisk-fstrim=1, ... ?
(fstrim=1 sound like we always allow fstrim or not )
- Mail original -
De: "Alwin Antreich"
À: "pve-devel"
Envoyé: Mardi 29 Mai 2018 09:19:39
Objet: Re: [pve-devel] [PATCH qemu-server] Fix #1242 : clo
On Mon, May 28, 2018 at 08:49:29PM +0200, Alexandre DERUMIER wrote:
> >>If I understood it right, then the fstrim is called on every migrate with a
> >>running guest agent. While, I guess the command is called also if you don't
> >>have discard in the vm config activated and might only produce a
On Mon, May 28, 2018 at 05:36:50PM +0200, Alexandre Derumier wrote:
> Some storage like rbd or lvm can't keep thin-provising after a qemu-mirror.
>
> Call qga guest-fstrim if qga is available
> ---
> PVE/API2/Qemu.pm | 8
> PVE/QemuMigrate.pm | 5 +
> 2 files changed, 13
>>And we really want to ignore error messages?
I think yes, it's best effort. This don't break migration/mirroring.
- Mail original -
De: "dietmar"
À: "aderumier" , "pve-devel"
Envoyé: Lundi 28 Mai 2018 19:29:36
Objet: Re: [pve-devel] [PATCH qemu-s
gt;>it and are knowing that this also has its drawbacks on their systems.
maybe can we add it in datacenter.cfg ? or storage.cfg option ?
- Mail original -
De: "Alwin Antreich"
À: "pve-devel"
Envoyé: Lundi 28 Mai 2018 19:50:24
Objet: Re: [pve-devel] [PATCH qemu-server] F
And we really want to ignore error messages?
> + if ($running && $conf->{agent} &&
> PVE::QemuServer::qga_check_running($vmid)) {
> + eval { PVE::QemuServer::vm_mon_cmd($vmid,
> "guest-fstrim"); };
> + }
> +
Some storage like rbd or lvm can't keep thin-provising after a qemu-mirror.
Call qga guest-fstrim if qga is available
---
PVE/API2/Qemu.pm | 8
PVE/QemuMigrate.pm | 5 +
2 files changed, 13 insertions(+)
diff --git a/PVE/API2/Qemu.pm b/PVE/API2/Qemu.pm
index 8d4b10d..86fac9d
10 matches
Mail list logo
