Re: [pve-devel] [PATCH storage] fix #2085: Handle non-default mount point in path() by introducing new mountpoint property

2019-11-12 Thread Thomas Lamprecht
On 11/12/19 12:18 PM, Fabian Ebner wrote: > > I don't see a clean way to do the automatic adding of the mount point > property (doing it in path() is possible, but we need to assume that our > caller doesn't hold the lock on storage.cfg). Maybe it's better to just do > the warning in activate_s

Re: [pve-devel] [PATCH storage] fix #2085: Handle non-default mount point in path() by introducing new mountpoint property

2019-11-12 Thread Fabian Grünbichler
On November 12, 2019 12:18 pm, Fabian Ebner wrote: > On 11/7/19 12:59 PM, Fabian Grünbichler wrote: >> On November 7, 2019 12:52 pm, Fabian Ebner wrote: >>> On 11/7/19 9:34 AM, Fabian Grünbichler wrote: On November 6, 2019 1:46 pm, Fabian Ebner wrote: > A new mountpoint property is added t

Re: [pve-devel] [PATCH storage] fix #2085: Handle non-default mount point in path() by introducing new mountpoint property

2019-11-12 Thread Fabian Ebner
On 11/7/19 12:59 PM, Fabian Grünbichler wrote: On November 7, 2019 12:52 pm, Fabian Ebner wrote: On 11/7/19 9:34 AM, Fabian Grünbichler wrote: On November 6, 2019 1:46 pm, Fabian Ebner wrote: A new mountpoint property is added to the schema for ZFSPool storages. When needed for the first time,

Re: [pve-devel] [PATCH storage] fix #2085: Handle non-default mount point in path() by introducing new mountpoint property

2019-11-07 Thread Fabian Grünbichler
On November 7, 2019 12:52 pm, Fabian Ebner wrote: > On 11/7/19 9:34 AM, Fabian Grünbichler wrote: >> On November 6, 2019 1:46 pm, Fabian Ebner wrote: >>> A new mountpoint property is added to the schema for ZFSPool storages. >>> When needed for the first time, the current mount point is determined

Re: [pve-devel] [PATCH storage] fix #2085: Handle non-default mount point in path() by introducing new mountpoint property

2019-11-07 Thread Fabian Ebner
On 11/7/19 9:34 AM, Fabian Grünbichler wrote: On November 6, 2019 1:46 pm, Fabian Ebner wrote: A new mountpoint property is added to the schema for ZFSPool storages. When needed for the first time, the current mount point is determined and written to the storage config. Signed-off-by: Fabian Eb

Re: [pve-devel] [PATCH storage] fix #2085: Handle non-default mount point in path() by introducing new mountpoint property

2019-11-07 Thread Fabian Ebner
On 11/7/19 9:34 AM, Fabian Grünbichler wrote: On November 6, 2019 1:46 pm, Fabian Ebner wrote: A new mountpoint property is added to the schema for ZFSPool storages. When needed for the first time, the current mount point is determined and written to the storage config. Signed-off-by: Fabian Eb

Re: [pve-devel] [PATCH storage] fix #2085: Handle non-default mount point in path() by introducing new mountpoint property

2019-11-07 Thread Fabian Grünbichler
On November 6, 2019 1:46 pm, Fabian Ebner wrote: > A new mountpoint property is added to the schema for ZFSPool storages. > When needed for the first time, the current mount point is determined and > written to the storage config. > > Signed-off-by: Fabian Ebner > --- > PVE/Storage/ZFSPoolPlugin

Re: [pve-devel] [PATCH storage] fix #2085: Handle non-default mount point in path() by introducing new mountpoint property

2019-11-06 Thread Thomas Lamprecht
On 11/6/19 1:46 PM, Fabian Ebner wrote: > A new mountpoint property is added to the schema for ZFSPool storages. > When needed for the first time, the current mount point is determined and > written to the storage config. > > Signed-off-by: Fabian Ebner > --- > PVE/Storage/ZFSPoolPlugin.pm | 25

[pve-devel] [PATCH storage] fix #2085: Handle non-default mount point in path() by introducing new mountpoint property

2019-11-06 Thread Fabian Ebner
A new mountpoint property is added to the schema for ZFSPool storages. When needed for the first time, the current mount point is determined and written to the storage config. Signed-off-by: Fabian Ebner --- PVE/Storage/ZFSPoolPlugin.pm | 25 +++-- 1 file changed, 23 insertio