Re: [pve-devel] [PATCH storage 1/3] Lock storage when calling volume_import

2020-01-14 Thread Fabian Grünbichler
On January 13, 2020 12:56 pm, Fabian Ebner wrote: > Could I get some feedback for this? The same locking is done for > 'vdisk_alloc' and 'vdisk_clone' already (among others), so I thought it > makes sense for 'volume_import' as well. the main user of this is storage_migrate via 'pvesm import'. t

Re: [pve-devel] [PATCH storage 1/3] Lock storage when calling volume_import

2020-01-13 Thread Fabian Ebner
Could I get some feedback for this? The same locking is done for 'vdisk_alloc' and 'vdisk_clone' already (among others), so I thought it makes sense for 'volume_import' as well. On 12/12/19 11:17 AM, Fabian Ebner wrote: to avoid a potential race for two processes trying to allocate the same vo

[pve-devel] [PATCH storage 1/3] Lock storage when calling volume_import

2019-12-12 Thread Fabian Ebner
to avoid a potential race for two processes trying to allocate the same volume. Signed-off-by: Fabian Ebner --- This is conceptually independent from patches 2+3 (but patch 3 modfies the same hunk as this one). PVE/Storage.pm | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --