On Thu, Apr 23, 2020 at 05:52:29AM +0200, Dietmar Maurer wrote:
> > On April 22, 2020 6:00 PM Alwin Antreich wrote:
> >
> >
> > On Wed, Apr 22, 2020 at 05:35:05PM +0200, Dietmar Maurer wrote:
> > > AFAIK this can have ugly side effects ...
> > Okay, I was not aware of any know side effects.
> >
> On April 22, 2020 6:00 PM Alwin Antreich wrote:
>
>
> On Wed, Apr 22, 2020 at 05:35:05PM +0200, Dietmar Maurer wrote:
> > AFAIK this can have ugly side effects ...
> Okay, I was not aware of any know side effects.
>
> I took the File::stat, since we use it already in pve-cluster,
> qemu-serv
On Wed, Apr 22, 2020 at 05:35:05PM +0200, Dietmar Maurer wrote:
> AFAIK this can have ugly side effects ...
Okay, I was not aware of any know side effects.
I took the File::stat, since we use it already in pve-cluster,
qemu-server, pve-common, ... . And a off-list discussion with Thomas and
Fabian
AFAIK this can have ugly side effects ...
> On April 22, 2020 4:57 PM Alwin Antreich wrote:
>
>
> to minimize variable declarations. And allow to mock this method in
> tests instead of the perl build-in stat.
>
> Signed-off-by: Alwin Antreich
> ---
> PVE/Diskmanage.pm | 9 +
>
to minimize variable declarations. And allow to mock this method in
tests instead of the perl build-in stat.
Signed-off-by: Alwin Antreich
---
PVE/Diskmanage.pm | 9 +
PVE/Storage/Plugin.pm | 34 ++
2 files changed, 15 insertions(+), 28 deletions(-)