Re: [pve-devel] [PATCH v2 storage 2/3] Incorporate wipe_disks from PVE::Ceph::Tools

2020-03-07 Thread Thomas Lamprecht
On 3/5/20 10:51 AM, Dominik Csapak wrote: >> +# wipefs location: >> +# - Debian 9: /sbin/wipefs >> +# - Debian 10: /usr/sbin/wipefs >> +# The symlink from /sbin to /usr/sbin makes this work for fresh PVE > > the comment is odd: working with a mix of usr merged

Re: [pve-devel] [PATCH v2 storage 2/3] Incorporate wipe_disks from PVE::Ceph::Tools

2020-03-05 Thread Dominik Csapak
Comments inline On 2/25/20 11:28 AM, Dominic Jäger wrote: Move wipe_disks from PVE::Ceph::Tools to PVE::Diskmanage and improve it by - Handling invalid parameters - Adding options for wiping - Making names clearer, especially the sub name to indicate that it works for partitions, too.

Re: [pve-devel] [PATCH v2 storage 2/3] Incorporate wipe_disks from PVE::Ceph::Tools

2020-03-04 Thread Thomas Lamprecht
On 2/25/20 11:28 AM, Dominic Jäger wrote: > Move wipe_disks from PVE::Ceph::Tools to PVE::Diskmanage and improve it by > - Handling invalid parameters > - Adding options for wiping > - Making names clearer, especially the sub name to indicate that it works for >partitions, too. > - Use

[pve-devel] [PATCH v2 storage 2/3] Incorporate wipe_disks from PVE::Ceph::Tools

2020-02-25 Thread Dominic Jäger
Move wipe_disks from PVE::Ceph::Tools to PVE::Diskmanage and improve it by - Handling invalid parameters - Adding options for wiping - Making names clearer, especially the sub name to indicate that it works for partitions, too. - Use `blockdev` system call because it is easier to understand