Re: [pve-devel] avoiding VMID reuse

2018-04-13 Thread Lauri Tirkkonen
On Fri, Apr 13 2018 10:33:20 +0200, Wolfgang Bumiller wrote: > Code/style issues aside, in the current shape this is a > convenience-driven upstream API change for a specific use case / > personal preference. > > NAK. Fair enough. It was a simple hack of to solve the issue without large design

Re: [pve-devel] avoiding VMID reuse

2018-04-13 Thread Wolfgang Bumiller
On Wed, Apr 11, 2018 at 03:12:17PM +0300, Lauri Tirkkonen wrote: > On Tue, Mar 13 2018 11:15:23 +0200, Lauri Tirkkonen wrote: > > > Sorry if I misunderstood you but VMIDs are already _guaranteed_ to be > > > unique cluster wide, so also unique per node? > > > > I'll try to clarify: if I create a

Re: [pve-devel] avoiding VMID reuse

2018-04-12 Thread Alexandre DERUMIER
a.com Envoyé: Jeudi 12 Avril 2018 14:41:44 Objet: Re: [pve-devel] avoiding VMID reuse On Thu, Apr 12 2018 14:26:53 +0200, Fabian Grünbichler wrote: > > Sure, it's not a guarantee (because it isn't an error to use an unused > > ID less than nextid -- it would be easy to convert the wa

Re: [pve-devel] avoiding VMID reuse

2018-04-12 Thread Lauri Tirkkonen
On Thu, Apr 12 2018 14:26:53 +0200, Fabian Grünbichler wrote: > > Sure, it's not a guarantee (because it isn't an error to use an unused > > ID less than nextid -- it would be easy to convert the warning to an > > error though). But we don't especially need it to be a guarantee, we > > just want

Re: [pve-devel] avoiding VMID reuse

2018-04-12 Thread Fabian Grünbichler
On Thu, Apr 12, 2018 at 03:12:50PM +0300, Lauri Tirkkonen wrote: > On Thu, Apr 12 2018 12:42:51 +0200, Fabian Grünbichler wrote: > > > - please send patch series as threads (cover letter and each patch as > > > separate mail) and configure the subjectprefix accordingly for each > > >

Re: [pve-devel] avoiding VMID reuse

2018-04-12 Thread Lauri Tirkkonen
On Thu, Apr 12 2018 12:42:51 +0200, Fabian Grünbichler wrote: > > - please send patch series as threads (cover letter and each patch as > > separate mail) and configure the subjectprefix accordingly for each > > repository. this allows inline comments on each patch. Ok. This particular

Re: [pve-devel] avoiding VMID reuse

2018-04-12 Thread Fabian Grünbichler
On Thu, Apr 12, 2018 at 12:32:08PM +0200, Fabian Grünbichler wrote: > On Wed, Apr 11, 2018 at 03:12:17PM +0300, Lauri Tirkkonen wrote: > > On Tue, Mar 13 2018 11:15:23 +0200, Lauri Tirkkonen wrote: > > > > Sorry if I misunderstood you but VMIDs are already _guaranteed_ to be > > > > unique cluster

Re: [pve-devel] avoiding VMID reuse

2018-04-12 Thread Fabian Grünbichler
On Wed, Apr 11, 2018 at 03:12:17PM +0300, Lauri Tirkkonen wrote: > On Tue, Mar 13 2018 11:15:23 +0200, Lauri Tirkkonen wrote: > > > Sorry if I misunderstood you but VMIDs are already _guaranteed_ to be > > > unique cluster wide, so also unique per node? > > > > I'll try to clarify: if I create a

Re: [pve-devel] avoiding VMID reuse

2018-03-13 Thread Lauri Tirkkonen
On Tue, Mar 13 2018 10:06:41 +0100, Thomas Lamprecht wrote: > On 03/12/2018 03:13 PM, Lauri Tirkkonen wrote: > > Hi, > > > > we'd like to keep VMIDs always unique per node, so that we can use zfs > > for backups more easily (ie. avoid dataset name collisions; granted, > > this still leaves room

Re: [pve-devel] avoiding VMID reuse

2018-03-13 Thread Thomas Lamprecht
Hi, On 03/12/2018 03:13 PM, Lauri Tirkkonen wrote: > Hi, > > we'd like to keep VMIDs always unique per node, so that we can use zfs > for backups more easily (ie. avoid dataset name collisions; granted, > this still leaves room for collisions if disks are removed and added to > a VM). We've

[pve-devel] avoiding VMID reuse

2018-03-13 Thread Lauri Tirkkonen
Hi, we'd like to keep VMIDs always unique per node, so that we can use zfs for backups more easily (ie. avoid dataset name collisions; granted, this still leaves room for collisions if disks are removed and added to a VM). We've implemented the following (crappy) PoC that accomplishes just this