Re: [pve-devel] create snapshots

2012-09-04 Thread Alexandre DERUMIER
I'll read the code this afternoon, thanks ! - Mail original - De: Dietmar Maurer diet...@proxmox.com À: Alexandre DERUMIER aderum...@odiso.com Cc: pve-devel@pve.proxmox.com Envoyé: Mardi 4 Septembre 2012 14:22:12 Objet: RE: [pve-devel] create snapshots I just uploaded a patch - I

[pve-devel] create snapshots

2012-08-31 Thread Dietmar Maurer
I just looked at savevm, and that is relatively simple code: qemu-kvm/savevm.c: do_savevm() 1.)check if all disk support snapshots (call bdrv_can_snapshot()) 2.)vm_stop(RUN_STATE_SAVE_VM) 3.)Delete old snapshots of the same name 4.)save the VM state 5.)create the

Re: [pve-devel] create snapshots

2012-08-31 Thread Alexandre DERUMIER
But I am quite unsure with nexenta - how can we make sure that the nexenta server received all data before we do a snapshot? I think it the same than other, if vm_stop is call, bdrv_drain_all,bdrv_flush_all will use libiscsi. if we don't save vm_state, we need to freeze the filesystem.

Re: [pve-devel] create snapshots

2012-08-31 Thread Dietmar Maurer
I wonder it is would be safe to call an external script to create the snapshot there? Or is there still some data in the qemu block driver cache, or the host cache? yes, I think taking snapshot don't flush datas. rbd devs said me that we need to freeze the filesystem with qemu-ga if we