Re: [pve-devel] pve-firewall: default loglevel behaviour change

2019-05-16 Thread Thomas Lamprecht
d to click the checkbox to enable ratelimit, then click again to > disable it to finally > have the value "log_ratelimit: enable=0" yeah, true, that's a bug, I'm onto it. > > > > - Mail original - > De: "Thomas Lamprecht" > À: "pve-devel"

Re: [pve-devel] pve-firewall: default loglevel behaviour change

2019-05-16 Thread Alexandre DERUMIER
Mail original - De: "Thomas Lamprecht" À: "pve-devel" , "aderumier" , "Christian Ebner" Envoyé: Jeudi 16 Mai 2019 08:53:37 Objet: Re: [pve-devel] pve-firewall: default loglevel behaviour change On 5/16/19 1:18 AM, Alexandre DERUMIER wrote: > Th

Re: [pve-devel] pve-firewall: default loglevel behaviour change

2019-05-16 Thread Thomas Lamprecht
once per cluster... > > > - Mail original - > De: "Christian Ebner" > À: "pve-devel" , "aderumier" > Envoyé: Mercredi 15 Mai 2019 17:03:13 > Objet: Re: [pve-devel] pve-firewall: default loglevel behaviour change > > Hi Alexandre, >

Re: [pve-devel] pve-firewall: default loglevel behaviour change

2019-05-15 Thread Alexandre DERUMIER
but it's correctly disabled with "log_ratelimit: enable=0" in cluster.fw I think the behaviour should be also the same when option is not defined. - Mail original - De: "Christian Ebner" À: "pve-devel" , "aderumier" Envoyé: Mercredi 15 Mai 2019 17:03

Re: [pve-devel] pve-firewall: default loglevel behaviour change

2019-05-15 Thread Christian Ebner
Hi Alexandre, you are right, logging the packets passing the firewall bridge seems a bit overkill and redundant. Will send a patch to fix this. > On May 15, 2019 at 4:08 PM Alexandre DERUMIER wrote: > > > Hi, > > since this commit > > >

[pve-devel] pve-firewall: default loglevel behaviour change

2019-05-15 Thread Alexandre DERUMIER
Hi, since this commit https://git.proxmox.com/?p=pve-firewall.git;a=blobdiff;f=src/PVE/Firewall.pm;h=ccc5d7ffb62f1ef4c4d59e363192f512c88742c9;hp=6ac303831a62f630d437ef0e0508decd2b72f5ac;hb=3489f8a2b9597201fe8e42fa5832507f96169619;hpb=33efd363ab32d3f8f6a9c49e481cb62a8da40b5d @@ -2341,10