Re: [pve-devel] [pve-zsync] Discussion/Feedback: Extending pve-zsync to handle intervening snapshots

2020-06-16 Thread Bruce Wainer
Hi Wolfgang, Understood re: not using a flag and new copies of the functions. The reason I thought to do it that way, is that this can be seen as a change in behavior, even if the new behavior yields the same result. I come from an environment where any change shouldn't happen without the

Re: [pve-devel] [pve-zsync] Discussion/Feedback: Extending pve-zsync to handle intervening snapshots

2020-06-15 Thread Wolfgang Link
Hello, I think that's a good idea. However, I am not sure whether the additional flag described in point 1 is necessary, since old jobs already have an independent dest dataset. So the new logic should not conflict it. I think it would be great to rewrite the "snapshot_get" and

[pve-devel] [pve-zsync] Discussion/Feedback: Extending pve-zsync to handle intervening snapshots

2020-06-15 Thread Bruce Wainer
Hello, I am considering making an improvement to pve-zsync and submitting it as a patch, but I would like some feedback before doing so. Problem: pve-zsync can't be used multiple times between the same source and destination pool. For example, these two commands are allowed: pve-zsync create

[pve-devel] [pve-zsync] Fix send_config with IPv6

2017-07-06 Thread Wolfgang Link
Add square brackets on IP. --- pve-zsync | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pve-zsync b/pve-zsync index 5fa5292..b3241ff 100644 --- a/pve-zsync +++ b/pve-zsync @@ -948,7 +948,7 @@ sub send_image { run_cmd(['scp', '--', $source_target,

Re: [pve-devel] pve-zsync and mount points

2017-03-27 Thread Fabian Grünbichler
On Sat, Mar 25, 2017 at 05:31:09PM +0100, Stephan Leemburg wrote: > Hello All, > > I am new to this list. My name is Stephan. > > I am setting up pve-zsync and ran into some issues. > > Before I start sending patches, I want to check with you all. > > I have a container that has: > > mp0:

[pve-devel] pve-zsync and mount points

2017-03-25 Thread Stephan Leemburg
Hello All, I am new to this list. My name is Stephan. I am setting up pve-zsync and ran into some issues. Before I start sending patches, I want to check with you all. I have a container that has: mp0: /tank/vmdata/subvol-homes,mp=/home mp1: /tank/vmdata/subvol-mail,mp=/var/mail With the

[pve-devel] [pve-zsync 2/2] Fix #1245: Fix snapshot parser.

2017-01-10 Thread Wolfgang Link
Make the snapshot parser more exact. This avoid that a wrong snap-name will returned if two or more job names has the same beginning. --- pve-zsync | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pve-zsync b/pve-zsync index 8bd437e..6a651b8 100644 --- a/pve-zsync +++

[pve-devel] [pve-zsync 1/2] fix cut_taget_width

2017-01-10 Thread Wolfgang Link
--- pve-zsync | 21 ++--- 1 file changed, 14 insertions(+), 7 deletions(-) diff --git a/pve-zsync b/pve-zsync index 194eabf..8bd437e 100644 --- a/pve-zsync +++ b/pve-zsync @@ -72,19 +72,26 @@ sub check_bin { sub cut_target_width { my ($target, $max) = @_; +die "mim

[pve-devel] pve-zsync

2015-06-11 Thread Wolfgang Link
This are some fixes for the pve-sync tool ___ pve-devel mailing list pve-devel@pve.proxmox.com http://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel