Re: [pve-devel] run_command and shellquote

2014-11-04 Thread Dietmar Maurer
sub run_command { my ($cmd, %param) = @_; my $old_umask; my $cmdstr; if (!ref($cmd)) { $cmdstr = $cmd; if ($cmd =~ m/|/) { # see 'man bash' for option pipefail $cmd = [ '/bin/bash', '-c', set -o pipefail $cmd ]; } else

Re: [pve-devel] run_command and shellquote

2014-11-04 Thread Michael Rasmussen
On Tue, 4 Nov 2014 17:39:56 + Dietmar Maurer diet...@proxmox.com wrote: This $cmdstr is only used for logging! See now. A failing command got me confused when the error message contained quotes. -- Hilsen/Regards Michael Rasmussen Get my public GnuPG keys: michael at rasmussen dot cc

Re: [pve-devel] run_command and shellquote

2014-11-03 Thread Michael Rasmussen
On Mon, 3 Nov 2014 05:00:59 + Dietmar Maurer diet...@proxmox.com wrote: Why does shell quoting make the command fail? I thought shell quoting should not have any effect on how the command receives parameters? This is the particular code: my @ssh_opts = ('-o', 'BatchMode=yes'); my

Re: [pve-devel] run_command and shellquote

2014-11-03 Thread Dietmar Maurer
Why does shell quoting make the command fail? I thought shell quoting should not have any effect on how the command receives parameters? This is the particular code: my @ssh_opts = ('-o', 'BatchMode=yes'); my @ssh_cmd = ('/usr/bin/ssh', @ssh_opts); my @params = ('set',

[pve-devel] run_command and shellquote

2014-11-02 Thread Michael Rasmussen
Hi Dietmar, A command needs to be run like this: /usr/bin/ssh -o 'BatchMode=yes' -i /etc/pve/priv/zfs/192.168.3.145_id_rsa root@192.168.3.145 zfs set refreservation=4g tank/vm-100-disk-1 but due to run_command applies shellquote which will apply quotes to the param refreservation=4g because of

Re: [pve-devel] run_command and shellquote

2014-11-02 Thread Dietmar Maurer
but due to run_command applies shellquote which will apply quotes to the param refreservation=4g because of '=' to the command the command ends up like this: /usr/bin/ssh -o 'BatchMode=yes' -i /etc/pve/priv/zfs/192.168.3.145_id_rsa root@192.168.3.145 zfs set 'refreservation=4g'