Re: [pve-devel] training : watchdog not working on 1 server

2016-02-04 Thread Eduard Ahmatgareev
I had problem with watchdog on ipmi, that's why I uses for check next: ii pve-manager 4.1-5 amd64The Proxmox Virtual Environment check: ii status package and test watchdog: echo "A" | socat - UNIX-CONNECT:/var/run/watchdog-mux.sock after this command, server

Re: [pve-devel] training : watchdog not working on 1 server

2016-02-04 Thread Alexandre DERUMIER
Some news, I have rollback to ipmi_watchdog, which was not working yesterday, and It working fine now. So, indeed, maybe it was an hardware problem. (tests servers are 8-9 years old,so ...) Thanks for help ! - Mail original - De: "Thomas Lamprecht" À:

Re: [pve-devel] [PATCH container] Only add actual volumes to volid_list

2016-02-04 Thread Fabian Grünbichler
> Wolfgang Bumiller hat am 4. Februar 2016 um 11:21 > geschrieben: > > > On Thu, Feb 04, 2016 at 11:08:05AM +0100, Fabian Grünbichler wrote: > > skip /dev and bind mounts, otherwise stop backups will > > fail in parse_volume_id. > > --- > > src/PVE/VZDump/LXC.pm | 5

[pve-devel] [PATCH zfsonlinux] fix cherry-picking relevant 0.6.5.4 changes

2016-02-04 Thread Thomas Lamprecht
When cherry-picking range A..B the commit A won't get cherry picked, only the commits after A. To fix that use range A^..B as ^ selects the previous commit. This fixes the build of zfs with linux kernel version 4.4 as one compatibility change commit wasn't included. Signed-off-by: Thomas

[pve-devel] problem with add new node to cluster proxmox4.

2016-02-04 Thread Eduard Ahmatgareev
I tried add new node to proxmox cluster and had problem: pvecm add cluster_ip --force Are you sure you want to continue connecting (yes/no)? yes node cluster-2-4 already defined copy corosync auth key stopping pve-cluster service backup old database Job for corosync.service failed. See

Re: [pve-devel] training : watchdog not working on 1 server

2016-02-04 Thread Alexandre DERUMIER
>>looks OK to me. Seems there is no HA enabled VM on this node? That >>would explain that the watchdog does not trigger. The problem is not that the watchdog is not trigger, is that the watchdog timer is stopped (and with a strange countdown of 15s) # ipmitool mc watchdog get Watchdog Timer

Re: [pve-devel] training : watchdog not working on 1 server

2016-02-04 Thread Wolfgang Bumiller
> On February 4, 2016 at 7:50 AM Alexandre DERUMIER wrote: > > > >>It's just a warning, but it could be great to find a way to clean up it. > > for the warning, > > the problem seem to be that postinst script from pve-ha-manager > > if [ -e

Re: [pve-devel] training : watchdog not working on 1 server

2016-02-04 Thread Thomas Lamprecht
On 02/04/2016 11:07 AM, Alexandre DERUMIER wrote: looks OK to me. Seems there is no HA enabled VM on this node? That would explain that the watchdog does not trigger. The problem is not that the watchdog is not trigger, is that the watchdog timer is stopped (and with a strange countdown of

Re: [pve-devel] [PATCH container] improve mountpoint parsing

2016-02-04 Thread Wolfgang Bumiller
On Thu, Feb 04, 2016 at 11:36:41AM +0100, Dominik Csapak wrote: > currently we sanitize mountpoints with sanitize_mountpoint, which > tries to remove dots, double-dots and multiple slashes, but it does it > not correctly (e.g. /test/././ gets truncated to /test./ ) > > instead of trying to

[pve-devel] [PATCH container v2] improve mountpoint parsing

2016-02-04 Thread Dominik Csapak
changes from v1: renamed function to verify_* added check for ../ at the beginning cleaned up regex (\.)? -> \.? currently we sanitize mountpoints with sanitize_mountpoint, which tries to remove dots, double-dots and multiple slashes, but it does it not correctly (e.g. /test/././ gets truncated

[pve-devel] [PATCH container] improve mountpoint parsing

2016-02-04 Thread Dominik Csapak
currently we sanitize mountpoints with sanitize_mountpoint, which tries to remove dots, double-dots and multiple slashes, but it does it not correctly (e.g. /test/././ gets truncated to /test./ ) instead of trying to truncate the path, we create a format for mp strings which throws an error if

Re: [pve-devel] problem with add new node to cluster proxmox4.

2016-02-04 Thread Eduard Ahmatgareev
proxmox-ve: 4.1-34 (running kernel: 4.2.6-1-pve) pve-manager: 4.1-5 (running version: 4.1-5/f910ef5c) pve-kernel-4.2.6-1-pve: 4.2.6-34 lvm2: 2.02.116-pve2 corosync-pve: 2.3.5-2 libqb0: 0.17.2-1 pve-cluster: 4.0-31 qemu-server: 4.0-49 pve-firmware: 1.1-7 libpve-common-perl: 4.0-45

[pve-devel] [PATCH ha-manager] Fix postinstall script not removing watchdog-mux.socket

2016-02-04 Thread Wolfgang Bumiller
watchdog-mux.socket was removed in f8a3fc80af but the postinstall script used -e instead of -L to test for the symlink, which fails since the destination is already removed at that point. Use -L and remove the dead symlink if it exists. Reported-by: Alexandre Derumier ---

Re: [pve-devel] problem with add new node to cluster proxmox4.

2016-02-04 Thread Thomas Lamprecht
On 02/04/2016 10:58 AM, Eduard Ahmatgareev wrote: I tried add new node to proxmox cluster and had problem: pvecm add cluster_ip --force Are you sure you want to continue connecting (yes/no)? yes node cluster-2-4 already defined copy corosync auth key stopping pve-cluster service backup old

[pve-devel] [PATCH container] Remove mknod call from pre-start hook

2016-02-04 Thread Fabian Grünbichler
Since lxc.autodev defaults to 1, LXC will mount /dev as tmpfs an populate it. The removed code was unnecessary, since the device node was not accessable in the container anyway. A /dev mountpoint is mounted into the rootfs and accessable under its mountpoint, even if there is no associated /dev

Re: [pve-devel] training : watchdog not working on 1 server

2016-02-04 Thread Alexandre DERUMIER
>>echo "A" | socat - UNIX-CONNECT:/var/run/ watchdog -mux.sock >> >>after this command, server rebooted Yes, this is working for me too. The watchdog seem to works fine, simply not started ... - Mail original - De: "Eduard Ahmatgareev" À: "pve-devel"

Re: [pve-devel] training : watchdog not working on 1 server

2016-02-04 Thread Alexandre DERUMIER
>>If it runs fine on the other two with the same hardware it smells strong >>like a possible hardware bug/defective hardware (or firmware)? >> >>The countdown is probably only the default countdown, as it's not active >>and has no action configured this can be dismissed, imo. But this should

Re: [pve-devel] training : watchdog not working on 1 server

2016-02-04 Thread Thomas Lamprecht
On 02/04/2016 11:58 AM, Alexandre DERUMIER wrote: If it runs fine on the other two with the same hardware it smells strong like a possible hardware bug/defective hardware (or firmware)? The countdown is probably only the default countdown, as it's not active and has no action configured this

[pve-devel] [PATCH container 2/3] added $skiplock parameter for pct start/stop

2016-02-04 Thread Wolfgang Bumiller
Like with qemu the root user can use -skiplock with 'pct start' and 'pct stop'. This does not alter the container's lxc config, instead we pass PVE_SKIPLOCK=1 via the environment which will be seen from the prestart hook but not from inside the container. --- src/PVE/API2/LXC/Status.pm | 16

[pve-devel] [PATCH container 3/3] opensuse 13.2 support

2016-02-04 Thread Wolfgang Bumiller
Needs the apparmor /run -> /var/run bind mount patch in lxc-pve. --- src/PVE/LXC/Setup/SUSE.pm | 14 +- 1 file changed, 13 insertions(+), 1 deletion(-) diff --git a/src/PVE/LXC/Setup/SUSE.pm b/src/PVE/LXC/Setup/SUSE.pm index db8d140..13f2760 100644 --- a/src/PVE/LXC/Setup/SUSE.pm +++

[pve-devel] [PATCH lxc] Add apparmor patch for /run -> /var/run binding

2016-02-04 Thread Wolfgang Bumiller
Fixes some issues (mount retry loops) with suse 13.1 and 13.2 containers. --- Note: this patch has been accepted upstream and should be in the next release. ...armor-allow-binding-run-lock-var-run-lock.patch | 32 ++ debian/patches/series | 1 +

[pve-devel] [PATCH container 1/3] Fix #791: warn when resize2fs fails

2016-02-04 Thread Wolfgang Bumiller
At this point the underlying file has already been successfully resized which means it makes sense to refelct that change in the config, but the guest will not see the effect of it, however, a subsequent resize command will further increase the size relative to the 'new' size, so after such an

Re: [pve-devel] [PATCH container v2] improve mountpoint parsing

2016-02-04 Thread Wolfgang Bumiller
> On February 4, 2016 at 4:52 PM Dietmar Maurer wrote: > > > > > with the new behaviour, we don't need sanitize_mountpoint anymore: > > > > > > Signed-off-by: Dominik Csapak > > > > Acked-by: Wolfgang Bumiller > > This

[pve-devel] [PATCH qemu-server 2/2] pass $skiplock all the way through to destroy_vm

2016-02-04 Thread Wolfgang Bumiller
The API passes $skiplock to vm_destroy() which performed a check conditionally depending on the $skiplock parameter and then simply calls destroy_vm() inside lock_config() which did yet another check_lock() without any way to avoid that. Added the $skiplock parameter to destroy_vm() and removed

[pve-devel] [PATCH qemu-server 1/2] Close #880: ability to show paused state via the CLI

2016-02-04 Thread Wolfgang Bumiller
qm list and qm status both show suspended VMs as 'running' while the GUI's status summary shows them as 'paused'. This patch makes 'qm status' always request the full status and adds an optional '-full' parameter for 'qm list' to use a full status query to include the 'paused' state. (This is

[pve-devel] [PATCH container] Improve error handling in snapshot_create

2016-02-04 Thread Fabian Grünbichler
Set unfreeze before trying to freeze, otherwise an aborted or failed lxc-freeze will not be reversed by our error handling, leaving the container in a (partially) frozen state. Add a call to snapshot_commit in its own eval block to the error handling code, because we want to cleanup and unlock

[pve-devel] [PATCH] allow migration with usbhost device

2016-02-04 Thread Alexandre Derumier
We can migrate a vm with a usbhost device plugged without any problem. If the target server don't have the usb device, the device is unplugged on target vm If the target server have same kind of usb device (same vendor:productid or same usb port), it's transparent for the vm. Signed-off-by:

[pve-devel] [PATCH pve-manager 2/3] ext6migrate: push array elements separately

2016-02-04 Thread Emmanuel Kasper
--- www/manager6/form/IPRefSelector.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/www/manager6/form/IPRefSelector.js b/www/manager6/form/IPRefSelector.js index a017e15..fbf8a5d 100644 --- a/www/manager6/form/IPRefSelector.js +++ b/www/manager6/form/IPRefSelector.js

[pve-devel] [PATCH pve-manager 1/3] ext6migrate: replace unsafe pattern

2016-02-04 Thread Emmanuel Kasper
using applyIf is not safe here as the tbar property has already been set by the framework ( and anyway we would like to override any default set by the framework ) this allows the toolbar of the component to be displayed --- www/manager6/grid/FirewallAliases.js | 2 +- 1 file changed, 1

Re: [pve-devel] [PATCH container v2] improve mountpoint parsing

2016-02-04 Thread Wolfgang Bumiller
On Thu, Feb 04, 2016 at 01:40:15PM +0100, Dominik Csapak wrote: > changes from v1: > renamed function to verify_* > added check for ../ at the beginning > cleaned up regex (\.)? -> \.? > > > currently we sanitize mountpoints with sanitize_mountpoint, which > tries to remove dots, double-dots and

Re: [pve-devel] [PATCH container] Remove mknod call from pre-start hook

2016-02-04 Thread Dietmar Maurer
I thought that code is required to make volume resize happy? ___ pve-devel mailing list pve-devel@pve.proxmox.com http://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

[pve-devel] [PATCH] disk hotplug : allow hotplug of physical host /dev/ disks

2016-02-04 Thread Alexandre Derumier
Signed-off-by: Alexandre Derumier --- PVE/QemuServer.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/PVE/QemuServer.pm b/PVE/QemuServer.pm index fbd4830..9b7b07b 100644 --- a/PVE/QemuServer.pm +++ b/PVE/QemuServer.pm @@ -4472,7 +4472,7 @@ sub

Re: [pve-devel] [PATCH container v2] improve mountpoint parsing

2016-02-04 Thread Dietmar Maurer
> > with the new behaviour, we don't need sanitize_mountpoint anymore: > > > > Signed-off-by: Dominik Csapak > > Acked-by: Wolfgang Bumiller This looks potentially dangerous to me. Is there a reason (bug) for that change? Or is this just a

Re: [pve-devel] [PATCH] allow migration with usbhost device

2016-02-04 Thread Dietmar Maurer
> On February 4, 2016 at 4:04 PM Alexandre Derumier wrote: > > > We can migrate a vm with a usbhost device plugged without any problem. > > If the target server don't have the usb device, the device is unplugged on > target vm > > If the target server have same kind of

Re: [pve-devel] [PATCH] allow migration with usbhost device

2016-02-04 Thread Alexandre DERUMIER
>>That makes no sense to me. After migration the VM is connected to a totally >>different usb device! for example , for usb key, yes, they are different. But some devices like usb dongles could work without any problem. (Migrating a vm with propriarity software which need a dongle) (We have

Re: [pve-devel] [PATCH] allow migration with usbhost device

2016-02-04 Thread Dietmar Maurer
> for example , for usb key, yes, they are different. > > But some devices like usb dongles could work without any problem. > > (Migrating a vm with propriarity software which need a dongle) Sure, it can work for special cases. But in general this would be a dangerous feature. Maybe an extra

Re: [pve-devel] [PATCH] disk hotplug : allow hotplug of physical host /dev/ disks

2016-02-04 Thread Dietmar Maurer
applied. ___ pve-devel mailing list pve-devel@pve.proxmox.com http://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

Re: [pve-devel] Another batch of fixes for the firewall tabpanel

2016-02-04 Thread Dietmar Maurer
applied all 4 patches, thanks. ___ pve-devel mailing list pve-devel@pve.proxmox.com http://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

[pve-devel] Another batch of fixes for the firewall tabpanel

2016-02-04 Thread Emmanuel Kasper
Another batch bites the dust ___ pve-devel mailing list pve-devel@pve.proxmox.com http://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

[pve-devel] [PATCH pve-manager 3/3] ext6migrate: fix IPRefSelector ComboGrid

2016-02-04 Thread Emmanuel Kasper
The IPrefSelector ComboGrid can have selected values which are not backed by the component store, ie the store only contains IP aliases, but the ComboGrid can contain an IP adress not registered as an IP alias. In that case we should not try to update the selection in the dropdown, as the

Re: [pve-devel] [PATCH] allow migration with usbhost device

2016-02-04 Thread Alexandre DERUMIER
>>Sure, it can work for special cases. But in general this would be a >>dangerous feature. Maybe an extra flag for such cases? Ok no problem. I think we have already -force boolean Allow to migrate VMs which use local devices. Only root may

Re: [pve-devel] [PATCH zfsonlinux] fix cherry-picking relevant 0.6.5.4 changes

2016-02-04 Thread Dietmar Maurer
applied, thanks. ___ pve-devel mailing list pve-devel@pve.proxmox.com http://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

Re: [pve-devel] [PATCH ha-manager] Fix postinstall script not removing watchdog-mux.socket

2016-02-04 Thread Dietmar Maurer
applied. ___ pve-devel mailing list pve-devel@pve.proxmox.com http://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

Re: [pve-devel] [PATCH] allow migration with usbhost device

2016-02-04 Thread Dietmar Maurer
> >>Sure, it can work for special cases. But in general this would be a > >>dangerous feature. Maybe an extra flag for such cases? > > Ok no problem. > > I think we have already > > -force boolean > > Allow to migrate VMs which use local devices. Only root >

[pve-devel] [PATCH pve-manager] ext6migrate: fix minor selection bug in the ComboGrid

2016-02-04 Thread Emmanuel Kasper
up to now we were only updating the picker selection when the picker was created, which means that subsequent changes in the text field were not propagated to the drop-down list This patch creates a private syncSelection() method which is called each time the picker is shown This is roughly based

Re: [pve-devel] [PATCH container] Remove mknod call from pre-start hook

2016-02-04 Thread Wolfgang Bumiller
> On February 4, 2016 at 4:41 PM Dietmar Maurer wrote: > > > I thought that code is required to make volume resize happy? If you mean `pct resize` then no, since it doesn't care about the guest's /dev, after all it has to work on stopped containers, too. Although we

Re: [pve-devel] training : watchdog not working on 1 server

2016-02-04 Thread Dietmar Maurer
> It's never go inside the if > > > in my case, > /etc/systemd/system/sockets.target.wants/watchdog-mux.socket exist, it's a > symlink, > to > /etc/systemd/system/sockets.target.wants/watchdog-mux.socket -> > /lib/systemd/system/watchdog-mux.socket > > but > >

Re: [pve-devel] training : watchdog not working on 1 server

2016-02-04 Thread Alexandre DERUMIER
>>but it looks like softdog is working on both nodes? yes >>What is the output of: # systemctl status watchdog-mux.service ● watchdog-mux.service - Proxmox VE watchdog multiplexer Loaded: loaded (/lib/systemd/system/watchdog-mux.service; static) Active: active (running) since Thu

Re: [pve-devel] training : watchdog not working on 1 server

2016-02-04 Thread Dietmar Maurer
> >>What is the output of: > > # systemctl status watchdog-mux.service > > > ● watchdog-mux.service - Proxmox VE watchdog multiplexer >Loaded: loaded (/lib/systemd/system/watchdog-mux.service; static) >Active: active (running) since Thu 2016-02-04 09:09:26 CET; 1min 38s ago > Main