[pve-devel] [PATCH cluster 3/4] ssh_merge_known_hosts: refactor and simplify

Signed-off-by: Thomas Lamprecht (cherry picked from commit 53922f63700e47eb9efb1d669ccd9eb3c2f5779b) --- data/PVE/Cluster.pm | 19 ++- 1 file changed, 6 insertions(+), 13 deletions(-) diff --git a/data/PVE/Cluster.pm b/data/PVE/Cluster.pm index

[pve-devel] [PATCH cluster 4/4] pvecm: lock corosync config on addition and deletion

This avoids potential races which would lead to an inconsistent corosync config. Signed-off-by: Thomas Lamprecht (cherry picked from commit b778c013a2fc245008512365ac0b1a37287b30b3) --- use `git show -w` to see what really changed. Note: I squashed the "pass code ref

[pve-devel] [PATCH cluster 1/4] pvecm delnode: prevent deleting current node

Else corosync really delete himself from the cluster which pmxcfs cannot really handle and this is a bad idea in general. Signed-off-by: Thomas Lamprecht (cherry picked from commit a8dbb454dbb7a5b4bbff0f63ed39e4eb45328242) --- data/PVE/CLI/pvecm.pm | 3 +++ 1 file

[pve-devel] [PATCH cluster stable-4 0/4] cherry-pick selected improvements for PVE 4.4

Cherry pick some selected fixes which where made after branching of stable-4. Summarized: Allow uppercase nodenames, ensure corosync.conf gets locked on node addition and deletion and forbid deletion of itself. This avoids hard-to-get-out situations for users. Thomas Lamprecht (4): pvecm

[pve-devel] [PATCH cluster 2/4] ssh_merge_known_hosts: address auth failure problem

On node addition we create two entries in the cluster-wide known_host file with our public host key, one with the pve-localhost bound IP address and one with our nodename. SSH always lower cases hostnames or their aliases before comparing them to the known host entry. This is allowed as per RFC

[pve-devel] applied: [PATCH cluster stable-4 0/4] cherry-pick selected improvements for PVE 4.4

applied On Thu, Sep 21, 2017 at 01:31:20PM +0200, Thomas Lamprecht wrote: > Cherry pick some selected fixes which where made after branching of > stable-4. Summarized: Allow uppercase nodenames, ensure corosync.conf > gets locked on node addition and deletion and forbid deletion of > itself. >

Re: [pve-devel] pve api offline during log rotation

On 09/20/2017 01:26 PM, Stefan Priebe - Profihost AG wrote: Hi, Am 20.09.2017 um 10:36 schrieb Thomas Lamprecht: On 09/20/2017 06:40 AM, Stefan Priebe - Profihost AG wrote: Nobody? We register the restart command from pveproxy with the $use_hup parameter, this then send a SIGHUP when

[pve-devel] [PATCH cluster] cfs-func-plug: use RW lock for save cached data access

fuse may spawn multiple threads if there are concurrent accesses. Our virtual files, e.g. ".members", ".rrd", are registered over our "func" cfs plug which is a bit special. For each unique virtual file there exists a single cfs_plug_func_t instance, shared between all threads. As we directly

Re: [pve-devel] [PATCH RFC qemu-kvm 1/1] Provides a virtual package qemu-system-x86

On 09/21/2017 10:50 AM, Wolfgang Bumiller wrote: > On Thu, Sep 21, 2017 at 10:26:46AM +0200, Emmanuel Kasper wrote: >> Mainly to allow libguestfs and associated tools to work with our qemu binary. >> >> libguestfs tests at run timethe output of qemu -help and qemu -device ? >> to detect which

Re: [pve-devel] [PATCH access-control v3 1/3] fix #1501: pveum: die when deleting special role

On 09/21/2017 11:09 AM, Philip Abernethy wrote: Die with a helpful error message instead of silently ignoring the user when trying to delete a special role. Also add a property to the API answer for possible later use by the WebUI. --- PVE/API2/Role.pm | 6 +- PVE/AccessControl.pm | 5

[pve-devel] [PATCH access-control] api: fix typo in 'GET ticket' description

Signed-off-by: Thomas Lamprecht --- PVE/API2/AccessControl.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/PVE/API2/AccessControl.pm b/PVE/API2/AccessControl.pm index 444fb69..318ee15 100644 --- a/PVE/API2/AccessControl.pm +++

Re: [pve-devel] [PATCH V5 qemu-server] Move option 'pve-snapshot-name' to PVE::JSONSchema.

> Wolfgang Bumiller hat am 21. September 2017 um 09:25 > geschrieben: > > > On Mon, Sep 18, 2017 at 11:52:48AM +0200, Wolfgang Link wrote: > > To avoid update problems rename pve-snapshot-name to pve-snapshotname. > > When not renaming this the new pve-common clashes

Re: [pve-devel] [PATCH access-control v2 1/3] fix #1501: pveum: die when deleting special role

On 09/20/2017 05:10 PM, Philip Abernethy wrote: Die with a helpful error message instead of silently ignoring the user when trying to delete a special role. --- v2: Fixed 'special' appearing in WebUI roles list PVE/API2/Role.pm | 7 ++- PVE/AccessControl.pm | 1 + 2 files changed, 7

Re: [pve-devel] [PATCH access-control v2 2/3] Remove unused Dumper use

On 09/20/2017 05:10 PM, Philip Abernethy wrote: --- PVE/API2/Role.pm | 2 -- 1 file changed, 2 deletions(-) diff --git a/PVE/API2/Role.pm b/PVE/API2/Role.pm index d6d17db..107523e 100644 --- a/PVE/API2/Role.pm +++ b/PVE/API2/Role.pm @@ -7,8 +7,6 @@ use PVE::AccessControl; use

[pve-devel] applied: [PATCH access-control] api: fix typo in 'GET ticket' description

applied On Thu, Sep 21, 2017 at 08:44:17AM +0200, Thomas Lamprecht wrote: > Signed-off-by: Thomas Lamprecht > --- > PVE/API2/AccessControl.pm | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/PVE/API2/AccessControl.pm b/PVE/API2/AccessControl.pm

Re: [pve-devel] [PATCH V5 qemu-server] Move option 'pve-snapshot-name' to PVE::JSONSchema.

On Mon, Sep 18, 2017 at 11:52:48AM +0200, Wolfgang Link wrote: > To avoid update problems rename pve-snapshot-name to pve-snapshotname. When not renaming this the new pve-common clashes with the old qemu-server. When renaming this the next updates to manager, qemu-server and container all need to

[pve-devel] [PATCH access-control v3 3/3] Whitespace fixes

--- PVE/API2/ACL.pm | 44 +++--- PVE/API2/Role.pm | 71 ++- PVE/API2/User.pm | 102 +-- PVE/AccessControl.pm | 3 -- PVE/Auth/Plugin.pm | 14 +++ 5 files changed, 115

[pve-devel] [PATCH access-control v3 1/3] fix #1501: pveum: die when deleting special role

Die with a helpful error message instead of silently ignoring the user when trying to delete a special role. Also add a property to the API answer for possible later use by the WebUI. --- PVE/API2/Role.pm | 6 +- PVE/AccessControl.pm | 5 + 2 files changed, 10 insertions(+), 1

[pve-devel] [PATCH access-control v3 2/3] Remove unused Dumper uses

--- PVE/API2/ACL.pm | 2 -- PVE/API2/Role.pm | 2 -- PVE/API2/User.pm | 2 -- PVE/AccessControl.pm | 2 -- PVE/Auth/Plugin.pm | 2 -- 5 files changed, 10 deletions(-) diff --git a/PVE/API2/ACL.pm b/PVE/API2/ACL.pm index 84d7549..fb4fbce 100644 --- a/PVE/API2/ACL.pm +++

Re: [pve-devel] [PATCH RFC qemu-kvm 1/1] Provides a virtual package qemu-system-x86

On 09/21/2017 10:50 AM, Wolfgang Bumiller wrote: On Thu, Sep 21, 2017 at 10:26:46AM +0200, Emmanuel Kasper wrote: Mainly to allow libguestfs and associated tools to work with our qemu binary. libguestfs tests at run timethe output of qemu -help and qemu -device ? to detect which features it

[pve-devel] [PATCH manager] ui: reuse ResourceStores default handling for guest description

First, there was an additional space between "'" and ")" which lead me to this. I could never trigger the case where vmname is undefined, and saw that we have a almost same default handling in data/ResourceStore.js So, just use that one instead here - it misses the single-quotes inside the

[pve-devel] applied: [PATCH common] tools: df: handle a failing df

applied On Mon, Sep 11, 2017 at 09:23:09AM +0200, Wolfgang Bumiller wrote: > This function assumed df() will work or hang, but it can > also actually fail and return undef which results in > warnings - let's silence those. > --- > src/PVE/Tools.pm | 9 + > 1 file changed, 5

[pve-devel] applied: [PATCH docs] pvecm: pve-manager service was renamed to pve-guests

applied On Wed, Sep 13, 2017 at 08:02:30AM +0200, Wolfgang Bumiller wrote: > --- > pvecm.adoc | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/pvecm.adoc b/pvecm.adoc > index 4414d20..179406e 100644 > --- a/pvecm.adoc > +++ b/pvecm.adoc > @@ -846,7 +846,7 @@ NOTE: It is

[pve-devel] [PATCH RFC qemu-kvm 1/1] Provides a virtual package qemu-system-x86

Mainly to allow libguestfs and associated tools to work with our qemu binary. libguestfs tests at run timethe output of qemu -help and qemu -device ? to detect which features it can use, so it should not depend on which configure flags were used when compiling our qemu binary. --- debian/control

[pve-devel] [PATCH RFC qemu-kvm 0/1] Provides a qemu-system-x86 virtual package

This will allow the installation of extra packages requiring qemu Bigger use case is libguestfs0 and libguestfs-tools , this has been asked in a few different forum threads libguestfs-tools allow to inspect and edit disk images of offline guests and do not require libvirt domains to be used.

[pve-devel] applied: [PATCH guest-common 1/1] VZDump/Plugin: avoid cyclic dependency

applied On Wed, Sep 13, 2017 at 10:30:14AM +0200, Thomas Lamprecht wrote: > pve-guest-common is above qemu-server, pve-container and thus also > pve-manager in the package hierarchy. > The latter hosts PVE::VZDump, so using it here adds a cyclic > dependency between pve-manager and

Re: [pve-devel] [PATCH access-control] api: fix typo in 'GET ticket' description

On Thu, Sep 21, 2017 at 08:44:17AM +0200, Thomas Lamprecht wrote: > Signed-off-by: Thomas Lamprecht > --- > PVE/API2/AccessControl.pm | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/PVE/API2/AccessControl.pm b/PVE/API2/AccessControl.pm > index

Re: [pve-devel] [PATCH RFC qemu-kvm 1/1] Provides a virtual package qemu-system-x86

On Thu, Sep 21, 2017 at 10:26:46AM +0200, Emmanuel Kasper wrote: > Mainly to allow libguestfs and associated tools to work with our qemu binary. > > libguestfs tests at run timethe output of qemu -help and qemu -device ? > to detect which features it can use, so it should not > depend on which