[pve-devel] [PATCH manager v3 2/5] add xtermjs to pveproxy dirs

Signed-off-by: Dominik Csapak --- PVE/Service/pveproxy.pm | 9 - 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/PVE/Service/pveproxy.pm b/PVE/Service/pveproxy.pm index 7d39900a..ec1eb9a5 100755 --- a/PVE/Service/pveproxy.pm +++

[pve-devel] [PATCH qemu-server v3 1/2] add termproxy api call

for xtermjs web client Signed-off-by: Dominik Csapak --- PVE/API2/Qemu.pm | 95 1 file changed, 95 insertions(+) diff --git a/PVE/API2/Qemu.pm b/PVE/API2/Qemu.pm index 5f9d105..2b23c6b 100644 --- a/PVE/API2/Qemu.pm

[pve-devel] [PATCH manager v3 1/5] add termproxy api call for nodes

and add dependency for pve-xtermjs Signed-off-by: Dominik Csapak --- PVE/API2/Nodes.pm | 97 +++ debian/control| 1 + 2 files changed, 98 insertions(+) diff --git a/PVE/API2/Nodes.pm b/PVE/API2/Nodes.pm index

[pve-devel] [PATCH manager v3 3/5] add new xtermjs viewer window to Utils

Signed-off-by: Dominik Csapak --- www/manager6/Utils.js | 14 ++ 1 file changed, 14 insertions(+) diff --git a/www/manager6/Utils.js b/www/manager6/Utils.js index 3efe4e71..578ba81e 100644 --- a/www/manager6/Utils.js +++ b/www/manager6/Utils.js @@ -1156,6

[pve-devel] [PATCH container v3 1/1] add termproxy api call for lxc

Signed-off-by: Dominik Csapak --- src/PVE/API2/LXC.pm | 84 + 1 file changed, 84 insertions(+) diff --git a/src/PVE/API2/LXC.pm b/src/PVE/API2/LXC.pm index a1897c7..733826e 100644 --- a/src/PVE/API2/LXC.pm +++

[pve-devel] [PATCH qemu-server v3 2/2] enable vncproxy with vncterm for serial ports

this enables the output via vncterm when the vm has configured a serial port Signed-off-by: Dominik Csapak --- PVE/API2/Qemu.pm | 14 +++--- 1 file changed, 11 insertions(+), 3 deletions(-) diff --git a/PVE/API2/Qemu.pm b/PVE/API2/Qemu.pm index 2b23c6b..8ff6bd4

[pve-devel] [PATCH manager v3 4/5] add xtermjs flag to VNCConsole iframe

so that we can open an xtermjs iframe instead of novnc Signed-off-by: Dominik Csapak --- www/manager6/VNCConsole.js | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/www/manager6/VNCConsole.js b/www/manager6/VNCConsole.js index 4b1b39ef..1438dd0c

[pve-devel] [PATCH v3 3/3] fix error message

status_line is a method and cannot be expanded in a string Signed-off-by: Dominik Csapak --- src/PVE/CLI/termproxy.pm | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/PVE/CLI/termproxy.pm b/src/PVE/CLI/termproxy.pm index 1628337..28935b4 100644 ---

[pve-devel] [PATCH v3 0/3] multiple fixes

this series fixes some things with the pve-xtermjs package * really fix the dependency for libpve-access-control (RPCEnvironment was in there) * fix the error message for the authentication * make the 'perm' parameter really optional changes from v2: do not use a default for 'perm', but make it

[pve-devel] applied: [PATCH v3 0/3] multiple fixes

applied ___ pve-devel mailing list pve-devel@pve.proxmox.com https://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

[pve-devel] applied: [PATCH manager] Fix #1589: auth_handler: raise exception on init_request error

___ pve-devel mailing list pve-devel@pve.proxmox.com https://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

[pve-devel] applied: [PATCH] auth_handler: respond with passed error if we get a PVE::Exception

___ pve-devel mailing list pve-devel@pve.proxmox.com https://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

[pve-devel] [PATCH v3 1/3] remove dependcy to libpve-access-control

since we do not use any functionality of the RPCEnvironment, we remove it Signed-off-by: Dominik Csapak --- src/PVE/CLI/termproxy.pm | 5 - src/bin/termproxy| 2 -- 2 files changed, 7 deletions(-) diff --git a/src/PVE/CLI/termproxy.pm

[pve-devel] [PATCH v3 2/3] make perm an optional parameter

and only pass it to the api call if it exists, also delete the default path, since it is non-optional (and thus a default makes no sense) Signed-off-by: Dominik Csapak --- src/PVE/CLI/termproxy.pm | 28 ++-- 1 file changed, 14 insertions(+), 14

[pve-devel] [PATCH v3] add new xtermjs client

this series adds support for the xtermjs terminal client for the host shell, container consoles, and serial terminal for qemu vms this series depends on the 'pve-xtermjs' package to be found under: https://git.proxmox.com/?p=pve-xtermjs.git;a=summary changes since v2: * added path to termproxy

Re: [pve-devel] [PATCH 1/3] remove dependcy to libpve-access-control

I think PVE::RESTEnvironment is (should be) an Abstract class, so I am not sure if we can use it that way. > On December 11, 2017 at 10:58 AM Dominik Csapak wrote: > > > and use PVE::RESTEnvironment instead of > PVE::RPCEnvironment for setup_default_cli_env > >

[pve-devel] [PATCH widget toolkit] HelpButton: be backward compatible with PVE help mapping

pve-doc-generator used pveOnlineHelp as variable name while the widget toolkit expects proxmoxOnlineHelp, allow both for now. As its not quite clear when the switch to the widget toolkit happens this is more flexible than changing the generator and adding a versioned build dependency in

[pve-devel] [PATCH 3/3] fix error message

status_line is a method and cannot be expanded in a string Signed-off-by: Dominik Csapak --- src/PVE/CLI/termproxy.pm | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/PVE/CLI/termproxy.pm b/src/PVE/CLI/termproxy.pm index dae1dfd..473d2f8 100644 ---

[pve-devel] [RFC PATCH] Explain that concurrent modifications of the VM config are the error cause

Signed-off-by: Emmanuel Kasper --- While doing PVE trainings last week, I noticed that this error message was not clear to most people when it popped up on the GUI. Reusing here the wording that apt uses when called multiple times ( Unable to lock the administration

[pve-devel] [PATCH docs] scan-extjs: rename pveOnlineHelpInfo to proxmoxOnlineHelpInfo

For the swap to the widget toolkit. Signed-off-by: Thomas Lamprecht --- It's probably better to apply this only after the switch happened, we added a backward compatible check there to cope with an non-renamed variable asciidoc-pve.in | 2 +- 1 file changed, 1

[pve-devel] [PATCH v2 1/3] remove dependcy to libpve-access-control

since we do not use any functionality of the RPCEnvironment, we remove it Signed-off-by: Dominik Csapak --- changes from v1: do not use RESTHandler, but remove the call instead src/PVE/CLI/termproxy.pm | 5 - src/bin/termproxy| 2 -- 2 files changed, 7

[pve-devel] [PATCH v2 0/3] multiple fixes

this series fixes some things with the pve-xtermjs package * really fix the dependency for libpve-access-control (RPCEnvironment was in there) * fix the error message for the authentication * make the paramters really optional changes from v1: remove setup_environment altogether since we don't

[pve-devel] [PATCH v2 3/3] fix error message

status_line is a method and cannot be expanded in a string Signed-off-by: Dominik Csapak --- src/PVE/CLI/termproxy.pm | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/PVE/CLI/termproxy.pm b/src/PVE/CLI/termproxy.pm index 7378821..c524671 100644 ---

[pve-devel] [PATCH v2 2/3] make path and perm optional parameters

and only pass perm to the api call if it is not empty Signed-off-by: Dominik Csapak --- src/PVE/CLI/termproxy.pm | 16 +++- 1 file changed, 11 insertions(+), 5 deletions(-) diff --git a/src/PVE/CLI/termproxy.pm b/src/PVE/CLI/termproxy.pm index 382270d..7378821

[pve-devel] [PATCH 1/3] remove dependcy to libpve-access-control

and use PVE::RESTEnvironment instead of PVE::RPCEnvironment for setup_default_cli_env Signed-off-by: Dominik Csapak --- src/PVE/CLI/termproxy.pm | 4 ++-- src/bin/termproxy| 2 -- 2 files changed, 2 insertions(+), 4 deletions(-) diff --git

[pve-devel] [PATCH 2/3] make path and perm optional parameters

and only pass perm to the api call if it is not empty Signed-off-by: Dominik Csapak --- the optional privs parameter is needed for non-pve environments, where no privs exist src/PVE/CLI/termproxy.pm | 16 +++- 1 file changed, 11 insertions(+), 5 deletions(-)

[pve-devel] [PATCH 0/3] multiple fixes

this series fixes some things with the pve-xtermjs package * really fix the dependency for libpve-access-control (RPCEnvironment was in there) * fix the error message for the authentication * make the paramters really optional Dominik Csapak (3): remove dependcy to libpve-access-control

Re: [pve-devel] [PATCH v2 2/3] make path and perm optional parameters

On 12/11/2017 11:28 AM, Dominik Csapak wrote: > and only pass perm to the api call if it is not empty > > Signed-off-by: Dominik Csapak > --- > src/PVE/CLI/termproxy.pm | 16 +++- > 1 file changed, 11 insertions(+), 5 deletions(-) > > diff --git

[pve-devel] [RFC manager 23/28] use RestProxy from widget toolkit

Split PVE specific models, which where not moved to the general widget toolkit, in a separate file, data/Models.js Signed-off-by: Thomas Lamprecht --- www/manager6/Makefile | 2 +- www/manager6/ceph/Monitor.js | 2 +-

[pve-devel] [RFC manager 22/28] use ObjectStore from widget toolkit

Signed-off-by: Thomas Lamprecht --- www/manager6/Makefile | 1 - www/manager6/data/ObjectStore.js| 35 --- www/manager6/ha/Status.js | 2 +- www/manager6/lxc/Config.js | 2 +-

[pve-devel] [RFC manager 04/28] use Checkbox from widget toolkit

Signed-off-by: Thomas Lamprecht --- www/manager6/Makefile | 1 - www/manager6/ceph/OSD.js | 4 ++-- www/manager6/ceph/Pool.js | 2 +- www/manager6/dc/ACLView.js| 2 +- www/manager6/dc/AuthEdit.js | 4

[pve-devel] [RFC manager 25/28] use LogView from widget toolkit

Signed-off-by: Thomas Lamprecht --- www/manager6/Makefile| 1 - www/manager6/grid/Replication.js | 2 +- www/manager6/lxc/Config.js | 2 +- www/manager6/node/Config.js | 6 +- www/manager6/panel/LogView.js| 274

[pve-devel] [RFC manager 18/28] use DiffStore from widget toolkit

The alias stayed the same (store.diff) so we need to change direct usage of 'PVE.data.DiffStore' only. Signed-off-by: Thomas Lamprecht --- www/manager6/Makefile| 1 - www/manager6/ceph/Monitor.js | 2 +- www/manager6/ceph/Pool.js| 2 +-

[pve-devel] [RFC manager 14/28] use windowEdit from widget toolkit

Signed-off-by: Thomas Lamprecht --- www/manager6/Makefile | 1 - www/manager6/ceph/Monitor.js | 2 +- www/manager6/ceph/OSD.js | 4 +- www/manager6/ceph/Pool.js | 2 +- www/manager6/dc/ACLView.js| 2

[pve-devel] [RFC manager 15/28] use TaskViewer & TaskProgress window from widget toolkit

Signed-off-by: Thomas Lamprecht --- www/manager6/Makefile | 1 - www/manager6/ceph/Monitor.js| 4 +- www/manager6/ceph/OSD.js| 2 +- www/manager6/dc/Tasks.js| 2 +- www/manager6/lxc/CreateWizard.js| 2 +-

[pve-devel] [RFC manager 26/28] use InputPanel from widget toolkit

Signed-off-by: Thomas Lamprecht --- www/manager6/Makefile | 1 - www/manager6/dc/ACLView.js| 2 +- www/manager6/dc/AuthEdit.js | 2 +- www/manager6/dc/Backup.js | 2 +- www/manager6/dc/SecurityGroups.js | 2

[pve-devel] [RFC manager 10/28] lxc/Options: cleanup & use a few new features from ObjectGrid

Use also same store update interval as qemu/Options Signed-off-by: Thomas Lamprecht --- www/manager6/lxc/Options.js | 52 +++-- 1 file changed, 12 insertions(+), 40 deletions(-) diff --git a/www/manager6/lxc/Options.js

[pve-devel] [RFC manager 05/28] use RRDTypeSelector from widget toolkit

Signed-off-by: Thomas Lamprecht --- www/manager6/Makefile| 1 - www/manager6/data/RRDStore.js| 2 +- www/manager6/form/RRDTypeSelector.js | 49 www/manager6/lxc/Summary.js | 2 +-

[pve-devel] [RFC manager 09/28] lxc/Resources: cleanup & use new features from ObjectGrid

Signed-off-by: Thomas Lamprecht --- www/manager6/lxc/Resources.js | 87 ++- 1 file changed, 20 insertions(+), 67 deletions(-) diff --git a/www/manager6/lxc/Resources.js b/www/manager6/lxc/Resources.js index ad7712b6..e9411e16

[pve-devel] [RFC manager 19/28] use TimezoneStore from widget toolkit

Signed-off-by: Thomas Lamprecht --- www/manager6/Makefile | 1 - www/manager6/data/TimezoneStore.js | 418 - www/manager6/node/TimeEdit.js | 2 +- 3 files changed, 1 insertion(+), 420 deletions(-) delete mode

[pve-devel] [RFC manager 06/28] use KVCombobox from widget toolkit

Signed-off-by: Thomas Lamprecht --- www/manager6/Makefile | 1 - www/manager6/dc/AuthEdit.js| 2 +- www/manager6/dc/Backup.js | 4 +- www/manager6/dc/OptionView.js | 2 +-

[pve-devel] [RFC manager 21/28] use JsonObject reader from widget toolkit

Alias stayed the same and we had only a single direct user (ObjectStore) which uses said alias to refer to this reader. Also ObjectStore itself will get replaced by the proxmox widget toolkit version in the next patch anyway. Signed-off-by: Thomas Lamprecht ---

[pve-devel] [RFC manager 17/28] use HelpButton from widget toolkit

Proxmox.button.Help renamed the css class for the button styling, as this class is only used rarely and the widget toolkit does not provides a (shared) css file itself, just rename it here too. Signed-off-by: Thomas Lamprecht --- www/css/ext6-pve.css | 2

[pve-devel] [RFC manager 24/28] use GaugeWidget from widget toolkit

Signed-off-by: Thomas Lamprecht --- www/manager6/Makefile | 1 - www/manager6/ceph/Status.js | 2 +- www/manager6/dc/Summary.js| 2 +- www/manager6/panel/GaugeWidget.js | 96 --- 4 files changed, 2

[pve-devel] [RFC manager 08/28] dc/OptionView: cleanup & use new features from ObjectGrid

Signed-off-by: Thomas Lamprecht --- www/manager6/Toolkit.js | 6 + www/manager6/Utils.js | 6 + www/manager6/dc/OptionView.js | 255 -- 3 files changed, 56 insertions(+), 211 deletions(-) diff --git

[pve-devel] [RFC manager 07/28] use ObjectGrid from widget toolkit

Signed-off-by: Thomas Lamprecht --- www/manager6/Makefile | 1 - www/manager6/dc/OptionView.js | 2 +- www/manager6/grid/FirewallOptions.js | 2 +- www/manager6/grid/ObjectGrid.js| 132 -

[pve-devel] [RFC manager 11/28] grid/FireWallOptions: cleanup & use new features from ObjectGrid

switch add_boolean and add_integer row to a simple wrapper. We really use it often and can save quite some lines with it so it does not make sense to remove it completely yet. Signed-off-by: Thomas Lamprecht --- www/manager6/grid/FirewallOptions.js | 125

[pve-devel] [RFC manager 12/28] qemu/Options: cleanup & use new features from ObjectGrid

Ther's a little delay with the revert button on pending changes, but that was the case previously too, so don't worry for that in this patch Signed-off-by: Thomas Lamprecht --- www/manager6/qemu/Options.js | 51 1 file

[pve-devel] [RFC manager 00/28] Integrate widget toolkit into PVE webUI

This is my split of the widget toolkit (re)integration. I looked at the following shared modules, compared the changes made since the fork and switched the usage to them. ./form/LanguageSelector.js ./form/BondModeSelector.js ./form/Checkbox.js ./form/RRDTypeSelector.js ./form/KVComboBox.js

[pve-devel] [RFC manager 28/28] buildsys: we need pve-doc-generator to build package

E.g., for asciidoc-pver scan-extjs to generate the OnlineHelp info map Signed-off-by: Thomas Lamprecht --- debian/control | 1 + 1 file changed, 1 insertion(+) diff --git a/debian/control b/debian/control index 5952adc3..5ea61972 100644 --- a/debian/control +++

[pve-devel] [RFC manager 27/28] RealmComboBox: use schematic declaration and ViewController

Signed-off-by: Thomas Lamprecht --- www/manager6/form/RealmComboBox.js | 53 +++--- 1 file changed, 26 insertions(+), 27 deletions(-) diff --git a/www/manager6/form/RealmComboBox.js b/www/manager6/form/RealmComboBox.js index

[pve-devel] [RFC manager 13/28] use PendingObjectGrid from widget toolkit

Signed-off-by: Thomas Lamprecht --- www/manager6/Makefile | 1 - www/manager6/grid/PendingObjectGrid.js | 95 -- www/manager6/qemu/HardwareView.js | 2 +- www/manager6/qemu/Options.js | 2 +- 4 files

[pve-devel] [RFC manager 16/28] use window.PasswordEdit from widget toolkit

Signed-off-by: Thomas Lamprecht --- www/manager6/dc/UserView.js | 55 + 1 file changed, 1 insertion(+), 54 deletions(-) diff --git a/www/manager6/dc/UserView.js b/www/manager6/dc/UserView.js index 740465f4..1fc8a2d2 100644 ---

[pve-devel] [RFC manager 20/28] TimeEdit: use schematic declaration

Signed-off-by: Thomas Lamprecht --- www/manager6/node/TimeEdit.js | 47 +-- 1 file changed, 23 insertions(+), 24 deletions(-) diff --git a/www/manager6/node/TimeEdit.js b/www/manager6/node/TimeEdit.js index e2d884d5..f05dc16e

[pve-devel] [RFC manager 02/28] use LanguageSelector from widget toolkit

Signed-off-by: Thomas Lamprecht --- www/manager6/Makefile | 1 - www/manager6/Utils.js | 42 --- www/manager6/form/LanguageSelector.js | 5 - www/manager6/window/LoginWindow.js| 2 +- 4 files

[pve-devel] [RFC manager 01/28] add proxmox-widget-toolkit to pve gui

From: Dominik Csapak we will use components from proxmox-widget-toolkit rather than directly from pve-manager Signed-off-by: Dominik Csapak Signed-off-by: Thomas Lamprecht --- PVE/Service/pveproxy.pm | 3 +++ debian/control

[pve-devel] [RFC manager 03/28] use BondModeSelector & BondPolicySelector from widget toolkit

widget name stayed the same, so no need to change Signed-off-by: Thomas Lamprecht --- www/manager6/Makefile | 1 - www/manager6/form/BondModeSelector.js | 42 --- 2 files changed, 43 deletions(-) delete mode 100644

Re: [pve-devel] [PATCH manager] api: nodes/subscription: implement reasonable access rights

any comments? On 11/30/2017 08:20 AM, Thomas Lamprecht wrote: > Allow users which have Sys.Audit on a specific node to get the > subscription status and those with Sys.Modify to set and check > (update) it. > > This mirrors the required permissions from other node specific > actions, e.g., APT

[pve-devel] applied: [PATCH container v3 1/1] add termproxy api call for lxc

applied On Mon, Dec 11, 2017 at 02:55:31PM +0100, Dominik Csapak wrote: > Signed-off-by: Dominik Csapak > --- > src/PVE/API2/LXC.pm | 84 > + > 1 file changed, 84 insertions(+) > > diff --git a/src/PVE/API2/LXC.pm

Re: [pve-devel] [PATCH V4 guset-common] Remove noerr form replication.

On 12/07/2017 12:06 PM, Wolfgang Link wrote: > We will handle this errors in the API and decide what to do. Most stuff is indentation change, so mail look more noisy than it is. In general OK, *but* we need a to handle package versions of this, i.e.: The package version of guest-common which

[pve-devel] applied: [PATCH manager] api: nodes/subscription: implement reasonable access rights

applied On Thu, Nov 30, 2017 at 08:20:34AM +0100, Thomas Lamprecht wrote: > Allow users which have Sys.Audit on a specific node to get the > subscription status and those with Sys.Modify to set and check > (update) it. > > This mirrors the required permissions from other node specific > actions,

Re: [pve-devel] [PATCH V4 manager 1/2] Indentation cleanup.

On 12/07/2017 12:06 PM, Wolfgang Link wrote: > --- > PVE/API2/Replication.pm | 14 +++--- > 1 file changed, 7 insertions(+), 7 deletions(-) > > diff --git a/PVE/API2/Replication.pm b/PVE/API2/Replication.pm > index f396615d..38449892 100644 > --- a/PVE/API2/Replication.pm > +++

Re: [pve-devel] [PATCH qemu-server v3 1/2] add termproxy api call

applied both, will follow up with a patch to remove the ^O escape key from qm terminal when used with xtermjs On Mon, Dec 11, 2017 at 02:55:32PM +0100, Dominik Csapak wrote: > for xtermjs web client > > Signed-off-by: Dominik Csapak > --- > PVE/API2/Qemu.pm | 95 >

Re: [pve-devel] [PATCH manager v3 1/5] add termproxy api call for nodes

applied whole series On Mon, Dec 11, 2017 at 02:55:26PM +0100, Dominik Csapak wrote: > and add dependency for pve-xtermjs > > Signed-off-by: Dominik Csapak > --- > PVE/API2/Nodes.pm | 97 > +++ > debian/control| 1

[pve-devel] [PATCH dab appliances] add ubuntu-artful-standard-64

Signed-off-by: Thomas Lamprecht --- Needs my not yet applied DAB patch "add support for Ubuntu 17.10 (artful)" to generate the actual template ubuntu-artful-standard-64/Makefile | 19 +++ ubuntu-artful-standard-64/dab.conf | 13 + 2 files

Re: [pve-devel] [PATCH V4 manager 2/2] Send an email when a replication job fails.

On 12/07/2017 12:07 PM, Wolfgang Link wrote: > A email notification will be send for each job when the job fails. > This message will only send when an error occurs and the fail count is on 1. > --- > PVE/API2/Replication.pm | 18 -- > PVE/CLI/pvesr.pm | 11 ++- >