Before:
...
USAGE: pvesm aaa zfsscan
With this patch applied:
no such command 'aaa'
Signed-off-by: Dietmar Maurer
---
src/PVE/CLIHandler.pm | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/src/PVE/CLIHandler.pm b/src/PVE/CLIHandler.pm
index 316d29d..5cdffa3 100644
---
Please note that we group similar commands inside a single command class.
Our CLIHandler then nicely groups this commands inside help.
Signed-off-by: Dietmar Maurer
---
Makefile | 1 +
PVE/APIClient/Commands/GuestStatus.pm | 76 +++
when a vm is suspended (e.g. autosuspend on windows)
we detect that it is not running, display the resume button,
but 'cont' does not wakeup the system from suspend
with this we can wake up suspended vms
Signed-off-by: Dominik Csapak
---
PVE/QemuServer.pm | 11 +--
1 file changed, 9
---
Makefile | 18 ++---
PVE/{ => APIClient}/CLIHandler.pm | 29 +++--
PVE/APIClient/Commands/GuestStatus.pm | 8 +++---
PVE/APIClient/Commands/config.pm | 4 +--
PVE/APIClient/Commands/lxc.pm | 1 -
applied (rebased on upstream)
___
pve-devel mailing list
pve-devel@pve.proxmox.com
https://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
On Tue, Jun 12, 2018 at 02:48:48PM +0200, Thomas Lamprecht wrote:
> On 6/11/18 11:31 AM, Alwin Antreich wrote:
> > - ability to mount through kernel and fuse client
> > - allow mount options
> > - get MONs from ceph config if not in storage.cfg
> > - allow the use of ceph config with fuse
applied
___
pve-devel mailing list
pve-devel@pve.proxmox.com
https://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
---
PVE/APIClient/Commands/GuestStatus.pm | 44 +++
pveclient | 3 ++-
2 files changed, 46 insertions(+), 1 deletion(-)
diff --git a/PVE/APIClient/Commands/GuestStatus.pm
b/PVE/APIClient/Commands/GuestStatus.pm
index 7903a2b..50730db
we do not complete them in bash copletion either and their just there
for backward compatibillity, so filter them out.
Signed-off-by: Thomas Lamprecht
---
src/PVE/CLIHandler.pm | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/src/PVE/CLIHandler.pm b/src/PVE/CLIHandler.pm
applied
> On June 12, 2018 at 11:55 AM René Jochum wrote:
>
>
> Signed-off-by: René Jochum
> ---
> PVE/APIClient/Commands/lxc.pm | 5 +
> 1 file changed, 1 insertion(+), 4 deletions(-)
>
> diff --git a/PVE/APIClient/Commands/lxc.pm b/PVE/APIClient/Commands/lxc.pm
> index
applied
___
pve-devel mailing list
pve-devel@pve.proxmox.com
https://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
hi, thanks for the patches
i looked briefly over them (and will dive deeper into the code in the
following days) and played a little around
here an initial review of what i saw/found
nitpicks:
you used the wrong git repository in the subject (container vs storage),
not really important,
before:
$ pveum acl
ERROR: incomplete command 'pveum acl'
USAGE: pveum [ARGS] [OPTIONS]
pveum acl delete --roles [OPTIONS]
pveum acl modify --roles [OPTIONS]
pveum group add [OPTIONS]
pveum group delete
pveum group modify [OPTIONS]
pveum role add
we have a param_mapping now, with which we can impement that
e.g. instead of using:
sub read_password {
# read password
}
we can do:
sub param_mapping {
my ($name) = @_;
my $password_map = ['password', sub{
# read password
}, ' [$password_map],
'apicall2' =>
On 6/13/18 8:00 AM, Dietmar Maurer wrote:
> Before:
>
> ...
> USAGE: pvesm aaa zfsscan
>
> With this patch applied:
>
> no such command 'aaa'
>
applied, thanks. I followed up with:
diff --git a/src/PVE/CLIHandler.pm b/src/PVE/CLIHandler.pm
index 5cdffa3..9bbc156 100644
---
On 06/12/2018 03:36 PM, Thomas Lamprecht wrote:
On 6/12/18 12:33 PM, Dominik Csapak wrote:
we have a param_mapping now, with which we can impement that
e.g. instead of using:
sub read_password {
# read password
}
we can do:
sub param_mapping {
my ($name) = @_;
my
applied
___
pve-devel mailing list
pve-devel@pve.proxmox.com
https://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
From: René Jochum
Signed-off-by: Dietmar Maurer
---
Changes in v2:
- use make instead of separate shell file
- do not copy Exception.pm
- install to correct path
- remove "use lib ..."
Makefile | 42 ++
PVE/{ => APIClient}/CLIHandler.pm | 27 +++
On 6/13/18 11:17 AM, Dominik Csapak wrote:
> when a vm is suspended (e.g. autosuspend on windows)
> we detect that it is not running, display the resume button,
> but 'cont' does not wakeup the system from suspend
>
> with this we can wake up suspended vms
>
> Signed-off-by: Dominik Csapak
>
Looks Good To Merge :)
On 2018-06-13 13:45, Dietmar Maurer wrote:
> Signed-off-by: Dietmar Maurer
> ---
> Makefile | 19 +++
> 1 file changed, 11 insertions(+), 8 deletions(-)
>
> diff --git a/Makefile b/Makefile
> index 4c9572a..0e11af5 100644
> --- a/Makefile
> +++ b/Makefile
Signed-off-by: Dietmar Maurer
---
Makefile | 19 +++
1 file changed, 11 insertions(+), 8 deletions(-)
diff --git a/Makefile b/Makefile
index 4c9572a..0e11af5 100644
--- a/Makefile
+++ b/Makefile
@@ -19,6 +19,16 @@ PVE_COMMON_FILES=\
SafeSyslog.pm
applied
___
pve-devel mailing list
pve-devel@pve.proxmox.com
https://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
---
PVE/APIClient/Commands/GuestStatus.pm | 18 ++
PVE/APIClient/Helpers.pm | 10 ++
2 files changed, 20 insertions(+), 8 deletions(-)
diff --git a/PVE/APIClient/Commands/GuestStatus.pm
b/PVE/APIClient/Commands/GuestStatus.pm
index 4a50164..7f90798 100644
see commit c7616abcb278e2b888febc082b557f60676fc376
---
PVE/Storage/CIFSPlugin.pm | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/PVE/Storage/CIFSPlugin.pm b/PVE/Storage/CIFSPlugin.pm
index ff24c8d..ffd16e3 100644
--- a/PVE/Storage/CIFSPlugin.pm
+++
This works but currently 'qemu' is hard coded in the
"merge_api_definition_properties" path which
has the behavior that we ALWAYS get qemu "properties" where we want LXC
properties often.
The only solution I can think of is to split those commands for Qemu/LXC
as in:
$ pveclient qemu
Signed-off-by: Thomas Lamprecht
---
src/PVE/API2/LXC.pm | 11 +++
1 file changed, 11 insertions(+)
diff --git a/src/PVE/API2/LXC.pm b/src/PVE/API2/LXC.pm
index d85c1a2..9f94bf3 100644
--- a/src/PVE/API2/LXC.pm
+++ b/src/PVE/API2/LXC.pm
@@ -167,6 +167,12 @@ __PACKAGE__->register_method({
Signed-off-by: Thomas Lamprecht
---
www/manager6/lxc/CreateWizard.js | 9 +
1 file changed, 9 insertions(+)
diff --git a/www/manager6/lxc/CreateWizard.js b/www/manager6/lxc/CreateWizard.js
index c39db169..a913ca0c 100644
--- a/www/manager6/lxc/CreateWizard.js
+++
> This works but currently 'qemu' is hard coded in the
> "merge_api_definition_properties" path which
> has the behavior that we ALWAYS get qemu "properties" where we want LXC
> properties often.
>
> The only solution I can think of is to split those commands for Qemu/LXC
> as in:
>
> $
comments inline:
> On June 13, 2018 at 2:17 PM René Jochum wrote:
>
>
> ---
> PVE/APIClient/Commands/GuestStatus.pm | 18 ++
> PVE/APIClient/Helpers.pm | 10 ++
> 2 files changed, 20 insertions(+), 8 deletions(-)
>
> diff --git
On 6/13/18 1:21 PM, Wolfgang Link wrote:
> see commit c7616abcb278e2b888febc082b557f60676fc376
> ---
> PVE/Storage/CIFSPlugin.pm | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/PVE/Storage/CIFSPlugin.pm b/PVE/Storage/CIFSPlugin.pm
> index ff24c8d..ffd16e3 100644
> ---
comments inline:
> On June 12, 2018 at 12:41 PM Stoiko Ivanov wrote:
>
>
> print_api_list takes an array of columns to print, the data, and the returns
> definitions of the API, and prints the data by using print_text_table.
>
> handle_cmd and handle_simple_cmd call the output sub with the
31 matches
Mail list logo
