On 6/15/18 11:00 AM, Wolfgang Bumiller wrote:
> Signed-off-by: Wolfgang Bumiller
> ---
applied with fixed up module name (SystemD -> Systemd)
> PVE/QemuServer.pm | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/PVE/QemuServer.pm b/PVE/QemuServer.pm
> index
On 6/15/18 11:00 AM, Wolfgang Bumiller wrote:
> Signed-off-by: Wolfgang Bumiller
> ---
> And appeased Perl::Critic a little during the move ;-)
>
Applied and followed up with a rename from SystemD -> Systemd
see: https://www.freedesktop.org/wiki/Software/systemd/#spelling
(I kept the initial
Hi,
I just detected a bug with 5.0 released,
so I'll rollback to 4.0 or 4.1 until it's fixed, and resend a new patch serie
- Mail original -
De: "aderumier"
À: "pve-devel"
Cc: "aderumier"
Envoyé: Vendredi 15 Juin 2018 03:39:37
Objet: [PATCH frr 00/10] frr 5.0 package
This add
we only need this for cifs as this is the only type
of storage where we expect a password
Signed-off-by: Dominik Csapak
---
PVE/CLI/pvesm.pm | 17 +++--
1 file changed, 15 insertions(+), 2 deletions(-)
diff --git a/PVE/CLI/pvesm.pm b/PVE/CLI/pvesm.pm
index 5774364..d95b5f5 100755
we have a param_mapping now, with which we can impement that
e.g. instead of using:
sub read_password {
# read password
}
we can do:
sub param_mapping {
my ($name) = @_;
my $password_map = ['password', sub{
# read password
}, ' [$password_map],
'apicall2' =>
and use get_standard_mapping from CLIHandler
Signed-off-by: Dominik Csapak
---
bin/pvesh | 24 ++--
1 file changed, 6 insertions(+), 18 deletions(-)
diff --git a/bin/pvesh b/bin/pvesh
index 36ce7636..41aec001 100755
--- a/bin/pvesh
+++ b/bin/pvesh
@@ -16,6 +16,7 @@ use
Signed-off-by: Dominik Csapak
---
PVE/CLI/qm.pm | 10 +-
1 file changed, 1 insertion(+), 9 deletions(-)
diff --git a/PVE/CLI/qm.pm b/PVE/CLI/qm.pm
index c017a59..a90aa75 100755
--- a/PVE/CLI/qm.pm
+++ b/PVE/CLI/qm.pm
@@ -671,15 +671,7 @@ sub param_mapping {
my $ssh_key_map =
with this we do not need Term::ReadLine anymore
Signed-off-by: Dominik Csapak
---
src/PVE/CLI/pct.pm | 17 -
1 file changed, 8 insertions(+), 9 deletions(-)
diff --git a/src/PVE/CLI/pct.pm b/src/PVE/CLI/pct.pm
index 897d595..ede8a4f 100755
--- a/src/PVE/CLI/pct.pm
+++
instead of writing:
['name', sub {...}, 'description', 1]
one can now use:
{
name => 'name',
func => sub { ... },
desc => 'desc',
interactive => 1,
}
which makes it more obvious what is what
(and allows later patches to easily override some things)
Signed-off-by: Dominik Csapak
Signed-off-by: Dominik Csapak
---
src/PVE/CLIHandler.pm | 14 +-
1 file changed, 13 insertions(+), 1 deletion(-)
diff --git a/src/PVE/CLIHandler.pm b/src/PVE/CLIHandler.pm
index b677105..98972b7 100644
--- a/src/PVE/CLIHandler.pm
+++ b/src/PVE/CLIHandler.pm
@@ -6,6 +6,7 @@ use
and replace it with param_mapping, since that implements a very
similar, but more general behaviour
also introduce a get_confirmed_password, as suggested by Thomas[1]
[1]: https://pve.proxmox.com/pipermail/pve-devel/2018-June/032338.html
this further implements a 'get_standard_mapping' sub to
so we can reuse often used parameter mappings
Signed-off-by: Dominik Csapak
---
src/PVE/CLIHandler.pm | 18 ++
1 file changed, 18 insertions(+)
diff --git a/src/PVE/CLIHandler.pm b/src/PVE/CLIHandler.pm
index c0b9406..b677105 100644
--- a/src/PVE/CLIHandler.pm
+++
since we use it in the code
Signed-off-by: Dominik Csapak
---
bin/pvesh | 1 +
1 file changed, 1 insertion(+)
diff --git a/bin/pvesh b/bin/pvesh
index 41aec001..5f9b7241 100755
--- a/bin/pvesh
+++ b/bin/pvesh
@@ -16,6 +16,7 @@ use PVE::SafeSyslog;
use PVE::Cluster;
use PVE::INotify;
use
use the get_standar_mapping 'pve-password'
then we can get rid of the Term::ReadLine dependency
we use this change to only ask for the password once on
'pveum ticket'
Signed-off-by: Dominik Csapak
---
PVE/CLI/pveum.pm | 28 ++--
debian/control| 1 -
applied both patches
___
pve-devel mailing list
pve-devel@pve.proxmox.com
https://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
applied both patches
___
pve-devel mailing list
pve-devel@pve.proxmox.com
https://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
Signed-off-by: Dietmar Maurer
---
PVE/APIClient/Commands/config.pm | 57 +++--
PVE/APIClient/Commands/remote.pm | 78
PVE/APIClient/Config.pm | 12 +++
3 files changed, 90 insertions(+), 57 deletions(-)
diff --git
applied
> On June 15, 2018 at 12:29 PM Dietmar Maurer wrote:
>
>
> Signed-off-by: Dietmar Maurer
> ---
> PVE/APIClient/Commands/config.pm | 57 +++--
> PVE/APIClient/Commands/remote.pm | 78
>
> PVE/APIClient/Config.pm
So I'm having issues with vlan-aware bridges. They seem to not apply
their addresses and then die at adding the gateway...
Can you check?
(ie. simpley standard config 1 physical interface on a vmbr0 with vlan
filtering enabled)
___
pve-devel mailing
On Wed, 2018-06-13 at 09:31 +0200, Dominik Csapak wrote:
> hi, thanks for the patches
>
> i looked briefly over them (and will dive deeper into the code in
> the
> following days) and played a little around
>
> here an initial review of what i saw/found
>
> nitpicks:
>
> you used the wrong
Hi wolfgang,
This thanks to apply my patches !
can you post your config ?
also you need to add "bridge-vids 2-4094" to the bridge option, to match old
config behaviour.
to allow vlans.
(I have add a note about this in the cover letter)
- Mail original -
De: "Wolfgang Bumiller"
À:
On 06/14/2018 11:19 AM, Udo Rader wrote:
On Fri, 2018-06-08 at 06:42 +0200, Dietmar Maurer wrote:
Yes, there is interest :-) Please read:
https://pve.proxmox.com/wiki/Developer_Documentation
We need to ask contributors to send us a contributor license
agreement form by email. If you do
during my initial tests, it worked (mostly) but i found some strange
behaviours:
when we execute a zfs request not in a worker (e.g. a content
listing)
and then create a lun in a worker, only that worker, and no future
worker knows of it (because when we fork, we copy all data currently
in
On 6/15/18 11:28 AM, Chris Hofstaedtler wrote:
> Current versions of this package ship files that are also
> shipped by firmware-amd-graphics et al. Update the now outdated
> Conflicts/Replaces lists.
>
> Signed-off-by: Chris Hofstaedtler
> Cc: Thomas Lamprecht
>
> [v2: fixed From: to match
>>So I'm having issues with vlan-aware bridges. They seem to not apply
>>their addresses and then die at adding the gateway...
>>Can you check?
>>(ie. simpley standard config 1 physical interface on a vmbr0 with vlan
>>filtering enabled)
Also, on a bridge with vlan-aware option,
I don't
It seem that indeed, in classic ifupdown,
we can setup an ip on vlan aware bridge. (untagged ip, then tagged on default
vlan pvid (1)).
I have looked in ifupdown2, it's not possible
addons/address.py:
def _process_bridge(self, ifaceobj, up):
hwaddress = self._get_hwaddress(ifaceobj)
I have found the correct check code, it's in utils.py
is_addr_ip_allowed_on
I have open an issue to see why it's disable
https://github.com/CumulusNetworks/ifupdown2/issues/58
(But it's to remove the check if needed)
- Mail original -
De: "aderumier"
À: "pve-devel"
Envoyé: Vendredi
> I really don't known if users use the default vlan for the proxmox management
> ip ? (generally,It's a bad pratice)
>
> But I think it possible to add a patch to ifupdown2 to have the old behaviour.
Anything improving compatibility with current setup is highly appreciated ;-)
On Fri, Jun 15, 2018 at 09:10:32AM +0200, Wolfgang Bumiller wrote:
> So I'm gonna push this to git.proxmox.com soon, but I'll remove most of
> the files from the debian/ directory since they're mostly copied from
> the ifupdown2 git repo anyway, and just add a source/format file and a
> patches
applied
On Wed, May 16, 2018 at 12:01:57PM +0200, Alexandre Derumier wrote:
> ifupdown2 conflict with ifenslave, as it's replace it
> ---
> debian/control | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/debian/control b/debian/control
> index 64588075..830f0f0c 100644
>
applied
On Wed, May 16, 2018 at 12:01:50PM +0200, Alexandre Derumier wrote:
> with ifupdown2, we can't call ifup for each ovs_ports in OvsBridge.
> But as we define also ovs_bridge for each interface, we can simply add
> the bridge here, to be sure that it's exist before adding the interface.
>
Applied with some followup commits, see
git.proxmox.com/ifupdown2
git.proxmox.com/mirror_ifupdown2
On Fri, Jun 15, 2018 at 01:52:00AM +0200, Alexandre Derumier wrote:
> Changelog v3:
> - update to master-next branch (2.0)
> - remove 1 extra patch
>
>
> Hi,
>
> Theses last months, I'm
So I'm gonna push this to git.proxmox.com soon, but I'll remove most of
the files from the debian/ directory since they're mostly copied from
the ifupdown2 git repo anyway, and just add a source/format file and a
patches directory. There's one difference I noticed though:
On Fri, Jun 15, 2018 at
Signed-off-by: Dietmar Maurer
---
PVE/APIClient/Helpers.pm | 55
1 file changed, 55 insertions(+)
diff --git a/PVE/APIClient/Helpers.pm b/PVE/APIClient/Helpers.pm
index 8a96e81..c4bc2c8 100644
--- a/PVE/APIClient/Helpers.pm
+++
Signed-off-by: Dietmar Maurer
---
PVE/APIClient/Config.pm | 56 ++---
1 file changed, 44 insertions(+), 12 deletions(-)
diff --git a/PVE/APIClient/Config.pm b/PVE/APIClient/Config.pm
index 910e9c5..3878425 100644
--- a/PVE/APIClient/Config.pm
+++
Signed-off-by: Wolfgang Bumiller
---
And appeased Perl::Critic a little during the move ;-)
src/Makefile | 1 +
src/PVE/SystemD.pm | 81 ++
src/PVE/Tools.pm | 74 -
3 files changed, 82
To get rid of the dbus dependency of PVE::Tools (and thereby dropping it
from pve-client) and in anticipation of at least one more systemd
related helper (waiting for jobs to complete...) we now get a
PVE::SystemD helper package to be used in qemu-server.
NOTE: that we now need a new version
Signed-off-by: Wolfgang Bumiller
---
PVE/QemuServer.pm | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/PVE/QemuServer.pm b/PVE/QemuServer.pm
index 277bc58..2d22382 100644
--- a/PVE/QemuServer.pm
+++ b/PVE/QemuServer.pm
@@ -34,6 +34,7 @@ use PVE::QemuServer::PCI
Current versions of this package ship files that are also
shipped by firmware-amd-graphics et al. Update the now outdated
Conflicts/Replaces lists.
Signed-off-by: Chris Hofstaedtler
Cc: Thomas Lamprecht
[v2: fixed From: to match CLA]
---
debian/control | 14 --
1 file changed, 12
39 matches
Mail list logo
