Re: [pve-devel] [RFC pve-manager] ui: storage: combine RBD external and hyperconverged add dialog

2018-06-25 Thread Dominik Csapak
the code looks good and i'm all for doing this, but i do not really like how the endresult looks an improvement would be to put the checkbox more at the top, or in the footer area? it feels rather weird to have a checkbox at the bottom of the form which changes the items before it also i

[pve-devel] [PATCH pve-common] PVE::CLIHandler::print_api_result - add $props_to_print parameter

2018-06-25 Thread Dietmar Maurer
Signed-off-by: Dietmar Maurer --- src/PVE/CLIHandler.pm | 14 ++ 1 file changed, 10 insertions(+), 4 deletions(-) diff --git a/src/PVE/CLIHandler.pm b/src/PVE/CLIHandler.pm index 1c754e4..9933df7 100644 --- a/src/PVE/CLIHandler.pm +++ b/src/PVE/CLIHandler.pm @@ -540,7 +540,7 @@ sub

[pve-devel] [PATCH storage v5 3/3] Cephfs storage plugin

2018-06-25 Thread Alwin Antreich
- ability to mount through kernel and fuse client - allow mount options - get MONs from ceph config if not in storage.cfg - allow the use of ceph config with fuse client Signed-off-by: Alwin Antreich --- PVE/API2/Storage/Config.pm | 28 ++- PVE/Storage.pm | 2 +

[pve-devel] [PATCH storage v5 1/3] Merge RBD and CephFS code into a helper module

2018-06-25 Thread Alwin Antreich
Some methods for connecting to a ceph cluster are the same for RBD and CephFS, these are merged into the helper modules. Signed-off-by: Alwin Antreich --- PVE/Storage/CephTools.pm | 55 PVE/Storage/Makefile | 2 +- PVE/Storage/RBDPlugin.pm |

[pve-devel] [PATCH manager v5 1/2] Cephfs storage wizard

2018-06-25 Thread Alwin Antreich
Add internal and external storage wizard for cephfs Signed-off-by: Alwin Antreich --- www/manager6/Makefile | 1 + www/manager6/Utils.js | 10 ++ www/manager6/storage/CephFSEdit.js | 71 ++ 3 files changed, 82 insertions(+)

[pve-devel] [PATCH manager v5 2/2] Add cephfs to allowed storages for vzdump backup

2018-06-25 Thread Alwin Antreich
Signed-off-by: Alwin Antreich --- PVE/VZDump.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/PVE/VZDump.pm b/PVE/VZDump.pm index a0376ef9..7fc69f98 100644 --- a/PVE/VZDump.pm +++ b/PVE/VZDump.pm @@ -223,7 +223,7 @@ sub storage_info { die "can't use storage type

[pve-devel] [PATCH v5 storage/manager] Cephfs storage plugin

2018-06-25 Thread Alwin Antreich
This patch series is an update and adds the Cephfs to our list of storages. You can mount the storage through the kernel or fuse client. The plugin for now allows all content formats, but this needs further testing. Config and keyfile locations are the same as in the RBD plugin. Example entry:

[pve-devel] [PATCH storage v5 2/3] Add simple keyring check for cephfs/rbd

2018-06-25 Thread Alwin Antreich
Signed-off-by: Alwin Antreich --- PVE/Storage/CephTools.pm | 33 + 1 file changed, 33 insertions(+) diff --git a/PVE/Storage/CephTools.pm b/PVE/Storage/CephTools.pm index 7aa6069..3e2cede 100644 --- a/PVE/Storage/CephTools.pm +++ b/PVE/Storage/CephTools.pm @@

[pve-devel] [PATCH docs] Add storage plugin CephFS to docs

2018-06-25 Thread Alwin Antreich
Signed-off-by: Alwin Antreich --- pve-storage-cephfs.adoc | 106 pvesm.adoc | 3 ++ 2 files changed, 109 insertions(+) create mode 100644 pve-storage-cephfs.adoc diff --git a/pve-storage-cephfs.adoc b/pve-storage-cephfs.adoc new

Re: [pve-devel] [PATCH v4 storage/manager] Cephfs storage plugin

2018-06-25 Thread Alwin Antreich
On Wed, Jun 20, 2018 at 03:02:43PM +0200, Thomas Lamprecht wrote: > On 6/18/18 7:49 PM, Alwin Antreich wrote: > > This patch series is an update and adds the Cephfs to our list of storages. > > You can mount the storage through the kernel or fuse client. The plugin for > > now allows all content

[pve-devel] applied: [PATCH pve-common 1/5] PVE::CLIHandler - new helper print_api_result

2018-06-25 Thread Dietmar Maurer
applied all 5 patches ___ pve-devel mailing list pve-devel@pve.proxmox.com https://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

[pve-devel] applied: [PATCH common 1/3] PVE::CLIHandler::print_text_table - fix sorting

2018-06-25 Thread Dietmar Maurer
applied all 3 patches ___ pve-devel mailing list pve-devel@pve.proxmox.com https://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

[pve-devel] [PATCH container v3] replace read_password with param_mapping

2018-06-25 Thread Dominik Csapak
with this we do not need Term::ReadLine anymore and we can merge the string_param_file_mapping into the param_mapping Signed-off-by: Dominik Csapak --- this is the missing v3 of the container read_password patch src/PVE/CLI/pct.pm | 20 ++-- 1 file changed, 6 insertions(+), 14

[pve-devel] [PATCH qemu-server v2] use get_standard_mapping for cipassword_map

2018-06-25 Thread Dominik Csapak
Signed-off-by: Dominik Csapak --- changes from v1: * use correct 'cipassword' not 'password' PVE/CLI/qm.pm | 10 +- 1 file changed, 1 insertion(+), 9 deletions(-) diff --git a/PVE/CLI/qm.pm b/PVE/CLI/qm.pm index c017a59..42b8f2c 100755 --- a/PVE/CLI/qm.pm +++ b/PVE/CLI/qm.pm @@ -671,15

[pve-devel] applied: [PATCH manager v2] ACMEv2 order "ready" status update

2018-06-25 Thread Wolfgang Bumiller
applied On Wed, Jun 20, 2018 at 11:56:05AM +0200, Dominik Csapak wrote: > since letsencrypt updates their implementation to the ACMEv2 spec [1], > we should correctly parse the order status > > 1: https://community.letsencrypt.org/t/acmev2-order-ready-status/62866 > > note that we (for now) try

Re: [pve-devel] [PATCH pve-common 1/3] Inotify: add mtu support

2018-06-25 Thread Wolfgang Bumiller
On Mon, Jun 25, 2018 at 05:41:33AM +0200, Alexandre Derumier wrote: > --- > src/PVE/INotify.pm | 5 - > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/src/PVE/INotify.pm b/src/PVE/INotify.pm > index 0b9ea4a..25ab868 100644 > --- a/src/PVE/INotify.pm > +++

[pve-devel] [PATCH pve-client] Use print_text_table in 'list' and 'remote list'

2018-06-25 Thread René Jochum
Signed-off-by: René Jochum --- PVE/APIClient/Commands/list.pm | 22 -- PVE/APIClient/Commands/remote.pm | 21 ++--- 2 files changed, 34 insertions(+), 9 deletions(-) diff --git a/PVE/APIClient/Commands/list.pm b/PVE/APIClient/Commands/list.pm index

Re: [pve-devel] [PATCH pve-common 2/3] Inotify : add vxlan interface support

2018-06-25 Thread Wolfgang Bumiller
Comments inline. Also, I would like a test case for this btw. (Which reminds me, I should probably explain the functions used for t.*.pl files a bit better in the comments... Short summary: The t.create_network.pl should be a good place to copy from, r() and w() call

Re: [pve-devel] [PATCH pve-common 3/3] Inotify : add bridge ports options

2018-06-25 Thread Wolfgang Bumiller
On Mon, Jun 25, 2018 at 05:41:35AM +0200, Alexandre Derumier wrote: > --- > src/PVE/INotify.pm | 53 +++-- > 1 file changed, 51 insertions(+), 2 deletions(-) > > diff --git a/src/PVE/INotify.pm b/src/PVE/INotify.pm > index 2c1af3c..2401ec0 100644 >