Re: [pve-devel] Unit 240.scope already exists.

2018-09-12 Thread Wolfgang Bumiller
On Wed, Sep 12, 2018 at 08:29:02AM +0200, Stefan Priebe - Profihost AG wrote: > Hello, > > i don't know whether this is a known bug but since Proxmox V5 i have > seen the following error message several times while trying to start a > vm after shutdown: > ERROR: start failed: > org.freedesktop.sys

[pve-devel] [PATCH manager v3 1/2] add /node/{NODE}/hosts API Call

2018-09-12 Thread Dominik Csapak
to get and set the content of /etc/hosts Signed-off-by: Dominik Csapak --- changes from v2: * add digest check code * lock file during write PVE/API2/Nodes.pm | 74 +++ 1 file changed, 74 insertions(+) diff --git a/PVE/API2/Nodes.pm b/PVE/API2

[pve-devel] [PATCH common v3 3/3] INotify.pm: add methods for reading/writing /etc/hosts

2018-09-12 Thread Dominik Csapak
Signed-off-by: Dominik Csapak --- changes from v2: * also encode during write * remove digest check code (done in api call) * better regex for comments (leading whitespace) src/PVE/INotify.pm | 49 + 1 file changed, 49 insertions(+) diff --git a/sr

[pve-devel] [PATCH manager v3 2/2] make /etc/hosts editable via gui

2018-09-12 Thread Dominik Csapak
with adding the NodeHostsView to the node tabs Signed-off-by: Dominik Csapak --- www/manager6/node/Config.js | 9 + 1 file changed, 9 insertions(+) diff --git a/www/manager6/node/Config.js b/www/manager6/node/Config.js index 14738296..e7a38296 100644 --- a/www/manager6/node/Config.js ++

[pve-devel] [PATCH common v3 1/3] de- and encode comments in /etc/network/interfaces as utf8

2018-09-12 Thread Dominik Csapak
decode comments as utf8 during reading and encode it during writing Signed-off-by: Dominik Csapak --- changes from v2: * also encode when writing src/PVE/INotify.pm | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/src/PVE/INotify.pm b/src/PVE/INotify.pm index fc9471d..d

[pve-devel] [PATCH common v3 2/3] INotify.pm: use run_command instead of open for calling diff

2018-09-12 Thread Dominik Csapak
decode it as utf8, else we get garbage on the gui when having utf8 characters in comments in /etc/network/interfaces Signed-off-by: Dominik Csapak --- src/PVE/INotify.pm | 15 +++ 1 file changed, 7 insertions(+), 8 deletions(-) diff --git a/src/PVE/INotify.pm b/src/PVE/INotify.pm in

[pve-devel] [PATCH widget-toolkit v3 1/1] add node/HostsView

2018-09-12 Thread Dominik Csapak
to show/edit /etc/hosts Signed-off-by: Dominik Csapak --- Makefile | 1 + node/HostsView.js | 95 +++ 2 files changed, 96 insertions(+) create mode 100644 node/HostsView.js diff --git a/Makefile b/Makefile index ad820a2..20dba60 100

[pve-devel] [PATCH common/widget-toolkit/manager v3] make /etc/hosts/editable via gui

2018-09-12 Thread Dominik Csapak
this series aims to make /etc/hosts view/editable via the gui the first 2 patches of pve-common are strictly not necessary for the series, but improve the read_network_interfaces to also read UTF-8 comments correctly (as in if you have utf8 characters in your /etc/network/interfaces comments, they

Re: [pve-devel] Unit 240.scope already exists.

2018-09-12 Thread Stefan Priebe - Profihost AG
Am 12.09.2018 um 10:19 schrieb Wolfgang Bumiller: > On Wed, Sep 12, 2018 at 08:29:02AM +0200, Stefan Priebe - Profihost AG wrote: >> Hello, >> >> i don't know whether this is a known bug but since Proxmox V5 i have >> seen the following error message several times while trying to start a >> vm aft

[pve-devel] [PATCH qemu-server v2] improve 'pending changes' message for clone

2018-09-12 Thread Dominik Csapak
$newconf->{pending} is a reference to an empty hash, which is not falsy, thus we always printed the warning so check if there are actual values there and if yes, give the names of the properties for which pending changes are found Signed-off-by: Dominik Csapak --- changes from v1: * use (my @cha

[pve-devel] applied: [PATCH qemu-server v2] improve 'pending changes' message for clone

2018-09-12 Thread Thomas Lamprecht
On 9/12/18 10:53 AM, Dominik Csapak wrote: > $newconf->{pending} is a reference to an empty hash, which is not falsy, > thus we always printed the warning > > so check if there are actual values there and if yes, > give the names of the properties for which pending changes are found > > Signed-of

Re: [pve-devel] Unit 240.scope already exists.

2018-09-12 Thread Wolfgang Bumiller
On Wed, Sep 12, 2018 at 10:28:24AM +0200, Stefan Priebe - Profihost AG wrote: > > Am 12.09.2018 um 10:19 schrieb Wolfgang Bumiller: > > On Wed, Sep 12, 2018 at 08:29:02AM +0200, Stefan Priebe - Profihost AG > > wrote: > > When it's not a timing issue, a `systemctl stop $name.scope` should work >

Re: [pve-devel] [PATCH common v3 3/3] INotify.pm: add methods for reading/writing /etc/hosts

2018-09-12 Thread Thomas Lamprecht
On 9/12/18 10:24 AM, Dominik Csapak wrote: > Signed-off-by: Dominik Csapak > --- > changes from v2: > * also encode during write > * remove digest check code (done in api call) > * better regex for comments (leading whitespace) > src/PVE/INotify.pm | 49 +++

Re: [pve-devel] Please help: beginner trying to compile Proxmox kernel 4.15

2018-09-12 Thread Fabian Grünbichler
On Tue, Sep 11, 2018 at 04:54:46PM +0700, The Anh Tran wrote: > Dear Teams, > > On 9/11/2018 3:53 AM, Fabian Grünbichler wrote: > > I am not sure whether your manual git clones messed anything up or > > whether you somehow manage to trigger some error in our Make logic > > (entirely possible!), bu

Re: [pve-devel] Please help: beginner trying to compile Proxmox kernel 4.15

2018-09-12 Thread Thomas Lamprecht
On 9/12/18 11:28 AM, Fabian Grünbichler wrote: > On Tue, Sep 11, 2018 at 04:54:46PM +0700, The Anh Tran wrote: >> /On branch master// >> //Your branch is up-to-date with 'origin/master'.// >> //nothing to commit (use -u to show untracked files)// >> / >> >> /compile-pve:/source# git clone -b pve-ke

Re: [pve-devel] [PATCH common v3 3/3] INotify.pm: add methods for reading/writing /etc/hosts

2018-09-12 Thread Dominik Csapak
On 09/12/2018 11:14 AM, Thomas Lamprecht wrote: On 9/12/18 10:24 AM, Dominik Csapak wrote: Signed-off-by: Dominik Csapak --- changes from v2: * also encode during write * remove digest check code (done in api call) * better regex for comments (leading whitespace) src/PVE/INotify.pm | 49 +

[pve-devel] [PATCH docs 2/2] use https for the website

2018-09-12 Thread Dominik Csapak
Signed-off-by: Dominik Csapak --- asciidoc/asciidoc-pve.conf | 2 +- getting-help.adoc | 2 +- pve-installation.adoc | 2 +- pve-package-repos.adoc | 2 +- 4 files changed, 4 insertions(+), 4 deletions(-) diff --git a/asciidoc/asciidoc-pve.conf b/asciidoc/asciidoc-pve.conf inde

[pve-devel] [PATCH docs 1/2] change pricing link to en

2018-09-12 Thread Dominik Csapak
since the language on proxmox.com depends on the cookie, using no language in the url leads to a 404 if the cookie says 'german', so always link to the english site Signed-off-by: Dominik Csapak --- getting-help.adoc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/getting-hel

[pve-devel] [PATCH zsync] fix #1907: cron entry duplicated on disable/enable

2018-09-12 Thread David
match only the interval instead of everything in front of every "root" Signed-off-by: David --- pve-zsync | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pve-zsync b/pve-zsync index 10d6bac..3a137fe 100755 --- a/pve-zsync +++ b/pve-zsync @@ -426,7 +426,7 @@ sub format_job {

[pve-devel] [PATCH storage] krbd_feature_disable was not setting features

2018-09-12 Thread Alwin Antreich
this broke creation and migration of disks on rbd storages Signed-off-by: Alwin Antreich --- PVE/Storage/RBDPlugin.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/PVE/Storage/RBDPlugin.pm b/PVE/Storage/RBDPlugin.pm index 84b1abd..ee373d6 100644 --- a/PVE/Storage/RBDPlugin.

[pve-devel] [PATCH 1/3] Add libpve-common-perl to Build-Depends

2018-09-12 Thread Rhonda D'Vine
This one was missing. Formating got adjusted too. Signed-off-by: Rhonda D'Vine --- debian/control | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/debian/control b/debian/control index f991da7..b84ae1c 100644 --- a/debian/control +++ b/debian/control @@ -2,7 +2,10 @@ Sour

[pve-devel] [PATCH 2/3] Use https:// for Homepage directly

2018-09-12 Thread Rhonda D'Vine
Signed-off-by: Rhonda D'Vine --- debian/control | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/debian/control b/debian/control index b84ae1c..60bc8b0 100644 --- a/debian/control +++ b/debian/control @@ -7,7 +7,7 @@ Build-Depends: debhelper (>= 9), librsvg2-bin

[pve-devel] [PATCH 3/3] Fix #1527: Use iso-codes country naming

2018-09-12 Thread Rhonda D'Vine
The iso 3166-1 information in the iso-codes package seems to be more up to par than the one that was used from tzdata. Signed-off-by: Rhonda D'Vine --- country.pl | 18 -- debian/control | 1 + 2 files changed, 13 insertions(+), 6 deletions(-) diff --git a/country.pl b/coun

[pve-devel] [PATCH 0/3] Fix #1527: Use iso-codes country naming

2018-09-12 Thread Rhonda D'Vine
The iso 3166-1 information in the iso-codes package seems to be more up to par than the one that was used from tzdata. Needed a new Build-Depends, so I formated it and added the missing libpve-common-perl. Also, Homepage update to https:// directly. This results in 45 countries to get their name

[pve-devel] applied: [PATCH storage] krbd_feature_disable was not setting features

2018-09-12 Thread Thomas Lamprecht
On 9/12/18 2:49 PM, Alwin Antreich wrote: > this broke creation and migration of disks on rbd storages > > Signed-off-by: Alwin Antreich > --- > PVE/Storage/RBDPlugin.pm | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/PVE/Storage/RBDPlugin.pm b/PVE/Storage/RBDPlugin.pm

[pve-devel] [PATCH docs 4/7] d/control: bump debhelper build-dependency

2018-09-12 Thread Fabian Grünbichler
Signed-off-by: Fabian Grünbichler --- debian/control | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/debian/control b/debian/control index a813b98..86f8e14 100644 --- a/debian/control +++ b/debian/control @@ -3,7 +3,7 @@ Section: perl Priority: extra Maintainer: Proxmox Supp

[pve-devel] [PATCH docs 5/7] d/control: add missing build-dependencies

2018-09-12 Thread Fabian Grünbichler
gathered by building in a minimal Debian Stretch chroot with just the listed build-dependencies installed. Signed-off-by: Fabian Grünbichler --- debian/control | 4 1 file changed, 4 insertions(+) diff --git a/debian/control b/debian/control index 86f8e14..fa76199 100644 --- a/debian/contr

[pve-devel] [PATCH docs 3/7] build: wrap-and-sort debian/

2018-09-12 Thread Fabian Grünbichler
for consistency and easier diffing Signed-off-by: Fabian Grünbichler --- no change besides formatting/order debian/control| 33 --- debian/copyright | 4 ++-- debian/pve-docs-mediawiki.docs| 2 +- debian/pve-docs-mediawiki.i

[pve-devel] [PATCH docs 7/7] d/compat: bump to 10

2018-09-12 Thread Fabian Grünbichler
(enables parallel builds by default) Signed-off-by: Fabian Grünbichler --- debian/compat | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/debian/compat b/debian/compat index ec63514..f599e28 100644 --- a/debian/compat +++ b/debian/compat @@ -1 +1 @@ -9 +10 -- 2.18.0 ___

[pve-devel] [RFC docs 0/7] build improvements

2018-09-12 Thread Fabian Grünbichler
the following changes are contained in this series: - switch to standard, single dpkg-buildpackage invocation to build all binary packages in one go - add missing build dependencies - fix and enable parallel building Fabian Grünbichler (7): update static files build: refactor build process

[pve-devel] [PATCH docs 6/7] build: fix broken parallel builds

2018-09-12 Thread Fabian Grünbichler
a2x only supports destination folders for HTML based variants, but fortunately that is enough in our case without needing extra workarounds. Signed-off-by: Fabian Grünbichler --- note: this cuts down the build time from 1:40 to :40 on my work station! note2: I didn't find any reference to the chu

[pve-devel] [PATCH docs 2/7] build: refactor build process

2018-09-12 Thread Fabian Grünbichler
build packages in one go by moving individual .deb targets into install targets called by dpkg-buildpackage. all three binary packages are bootstrappable on a straight Debian host, so there is no need to call dpkg-buildpackage separately for each of them. Signed-off-by: Fabian Grünbichler --- M

Re: [pve-devel] [PATCH docs 1/7] update static files

2018-09-12 Thread Dietmar Maurer
apidata.js looks strange??? + "net27" : { + "description" : "Specify network devices.", + "format" : { we already have net[n] there.