Re: [pve-devel] [PATCH manager 2/4] api: new parameter for each shell to pass custom command string

2019-01-15 Thread Fabian Grünbichler
On Thu, Jan 10, 2019 at 01:54:31PM +0100, Tim Marx wrote: > Signed-off-by: Tim Marx > --- > PVE/API2/Nodes.pm | 21 + > 1 file changed, 21 insertions(+) > > diff --git a/PVE/API2/Nodes.pm b/PVE/API2/Nodes.pm > index dd5471f8..c1f73cd0 100644 > --- a/PVE/API2/Nodes.pm > +++

[pve-devel] [PATCH v2 #1752 pve-manager 2/3] patch #1752 Impl basic wake on LAN

2019-01-15 Thread Christian Ebner
Signed-off-by: Christian Ebner --- PVE/API2/Nodes.pm | 26 +++--- PVE/NodeConfig.pm | 2 +- 2 files changed, 16 insertions(+), 12 deletions(-) diff --git a/PVE/API2/Nodes.pm b/PVE/API2/Nodes.pm index f59133dc..f831bc41 100644 --- a/PVE/API2/Nodes.pm +++ b/PVE/API2/Nodes.pm

[pve-devel] [PATCH v2 #1752 pve-manager 1/3] [PATCH #1752 pve-manager] Impl basic wake on LAN

2019-01-15 Thread Christian Ebner
Provides the basic functionality to provide a wake on LAN feature implementation to start nodes in a cluster from other nodes. Signed-off-by: Christian Ebner --- PVE/API2/Nodes.pm | 41 + PVE/NodeConfig.pm | 6 ++ 2 files changed, 47 insertions(+)

[pve-devel] [PATCH v2 #1752 pve-manager 0/3] Impl basic wake on LAN

2019-01-15 Thread Christian Ebner
Fix #1752 Version 2 of patches: * Changed properity name form 'mac' to 'wakeonlan' * Changed permissions from '/nodes/{node}' to '/nodes/' * Include 'use Socket;' * Refactoring of code according to suggestions on mailing list Christian Ebner (3): Impl basic wake on LAN patch #1752 Impl basic

[pve-devel] [PATCH v2 #1752 pve-manager 3/3] Impl basic wake on LAN functionality

2019-01-15 Thread Christian Ebner
Implements the basic requirements for waking a sleeping node in a cluster via wake on LAN. Signed-off-by: Christian Ebner --- PVE/API2/Nodes.pm | 21 +++-- PVE/NodeConfig.pm | 2 +- 2 files changed, 12 insertions(+), 11 deletions(-) diff --git a/PVE/API2/Nodes.pm

Re: [pve-devel] [PATCH manager 2/4] api: new parameter for each shell to pass custom command string

2019-01-15 Thread Tim Marx
> Fabian Grünbichler hat am 15. Januar 2019 um > 13:53 geschrieben: > > > On Thu, Jan 10, 2019 at 01:54:31PM +0100, Tim Marx wrote: > > Signed-off-by: Tim Marx > > --- > > PVE/API2/Nodes.pm | 21 + > > 1 file changed, 21 insertions(+) > > > > diff --git

[pve-devel] Feature request

2019-01-15 Thread Gilberto Nunes
Hi there Is there a way to show time remaining in the web gui for all - or something - operations, like move disk, for instance? Currently we got only bytes remaining Thanks a lot --- Gilberto Nunes Ferreira (47) 3025-5907 (47) 99676-7530 - Whatsapp / Telegram Skype: gilberto.nunes36

Re: [pve-devel] [PATCH #1752 pve-manager 1/1] [PATCH #1752 pve-manager] Impl basic wake on LAN

2019-01-15 Thread Thomas Lamprecht
On 1/14/19 5:04 PM, Dietmar Maurer wrote: >> +permissions => { >> +check => ['perm', '/nodes/{node}', [ 'Sys.PowerMgmt' ]], >> +}, > > You can wake up and Host in the network? If so, we may want to > restrict that too: > > check => ['perm', '/nodes/', [ 'Sys.PowerMgmt' ]], > No,

[pve-devel] applied: [PATCH pve-manager 1/1] Fix #1982 Check handler exists

2019-01-15 Thread Thomas Lamprecht
On 1/15/19 10:32 AM, Christian Ebner wrote: > Checks that the handler for the API call even exists before verifying the > parameter schema. By this the reported error message is more descriptive. > > Signed-off-by: Christian Ebner > --- > PVE/CLI/pvesh.pm | 8 ++-- > 1 file changed, 6

Re: [pve-devel] [PATCH v2 #1752 pve-manager 2/3] patch #1752 Impl basic wake on LAN

2019-01-15 Thread Thomas Lamprecht
If you send a v2 squash the changes in the original patch, it looks weird to introduce new code and then a patch later fixing it. Besides that it makes it a bit harder to review and harder to see what happened here when looking back at this in a few months via git. On 1/15/19 11:54 AM, Christian

Re: [pve-devel] [PATCH #1752 pve-manager 1/1] [PATCH #1752 pve-manager] Impl basic wake on LAN

2019-01-15 Thread Dietmar Maurer
> > Yes - that is exactly my point (it makes no sense to have Sys.PowerMgnt on > > node). > > It makes fully sense. They way this inteded to work is like: We have three > nodes > A, B, C. C is powered off. An user has the Sys.PowerMgmt permissions on only > Node > C. As it's powered off he

Re: [pve-devel] [PATCH #1752 pve-manager 1/1] [PATCH #1752 pve-manager] Impl basic wake on LAN

2019-01-15 Thread Thomas Lamprecht
On 1/16/19 7:02 AM, Dietmar Maurer wrote: > >>> check => ['perm', '/nodes/', [ 'Sys.PowerMgmt' ]], >>> >> >> No, this does not gets proxied to the {node}, > > Yes - that is exactly my point (it makes no sense to have Sys.PowerMgnt on > node). It makes fully sense. They way this inteded to

Re: [pve-devel] [PATCH #1752 pve-manager 1/1] [PATCH #1752 pve-manager] Impl basic wake on LAN

2019-01-15 Thread Dietmar Maurer
> > check => ['perm', '/nodes/', [ 'Sys.PowerMgmt' ]], > > > > No, this does not gets proxied to the {node}, Yes - that is exactly my point (it makes no sense to have Sys.PowerMgnt on node). ___ pve-devel mailing list pve-devel@pve.proxmox.com

Re: [pve-devel] [PATCH #1752 pve-manager 1/1] [PATCH #1752 pve-manager] Impl basic wake on LAN

2019-01-15 Thread Fabian Grünbichler
On Mon, Jan 14, 2019 at 04:24:55PM +0100, Thomas Lamprecht wrote: > > + send($sock, $packet, 0, $to) or die "Unable to send wake on LAN magic > > packet!\n"; > > + close($sock); > > + > > + return undef; > > +}}); > > > > __PACKAGE__->register_method({ > > name => 'rrd', > >

[pve-devel] applied: [PATCH cluster] pve-cluster: dont pretend to be a time-sync provider

2019-01-15 Thread Thomas Lamprecht
On 1/15/19 8:46 AM, Fabian Grünbichler wrote: > time-sync.target is a special passive unit, consumers (i.e., units that > intend to say "I want to start after synchronized time has been > established") should only order themselves after it. only providers > (i.e., units that intend to say "I am

[pve-devel] [PATCH pve-manager 0/1] Fix #1982 Check handler exists

2019-01-15 Thread Christian Ebner
Fix #1982 Checks that the handler for the provided API call even exists before starting with verification of the parameter schema, therefore returning a more descriptive error message if the handler does not exist. Christian Ebner (1): fix 1982 Check handler exists PVE/CLI/pvesh.pm | 8

[pve-devel] [PATCH pve-manager 1/1] Fix #1982 Check handler exists

2019-01-15 Thread Christian Ebner
Checks that the handler for the API call even exists before verifying the parameter schema. By this the reported error message is more descriptive. Signed-off-by: Christian Ebner --- PVE/CLI/pvesh.pm | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/PVE/CLI/pvesh.pm

Re: [pve-devel] [PATCH storage 0/2] Fix #2046 and disksize-mismatch with shared LVM

2019-01-15 Thread Thomas Lamprecht
On 1/4/19 2:06 PM, Stoiko Ivanov wrote: > The issue was observed recently and can lead to potential dataloss. When using > a shared LVM storage (e.g. over iSCSI) in a clustered setup only the node, > where > a guest is active notices the size change upon disk-resize > (lvextend/lvreduce). > >

Re: [pve-devel] [PATCH #1752 pve-manager 1/1] [PATCH #1752 pve-manager] Impl basic wake on LAN

2019-01-15 Thread Thomas Lamprecht
On 1/15/19 9:24 AM, Fabian Grünbichler wrote: > On Mon, Jan 14, 2019 at 04:24:55PM +0100, Thomas Lamprecht wrote: >>> + send($sock, $packet, 0, $to) or die "Unable to send wake on LAN magic >>> packet!\n"; >>> + close($sock); >>> + >>> + return undef; >>> +}}); >>> >>>