Re: [pve-devel] [PATCH pve-manager 1/2] pvestatd : broadcast sdn transportzone status

2019-06-25 Thread Dietmar Maurer
I am not sure if json is a good idea here. We use colon separated lists for everything else, so I would prefer that. It is easier to parse inside C, which is important when you want to generate RRD databases from inside pmxcfs ... Also, consider that it is quite hard to change that format later,

Re: [pve-devel] [RFC manager 2/2] upgrade checklist

2019-06-25 Thread Thomas Lamprecht
applied, with follow ups.. On 6/24/19 1:56 PM, Fabian Grünbichler wrote: > diff --git a/bin/Makefile b/bin/Makefile > index 52044ca9..31229477 100644 > --- a/bin/Makefile > +++ b/bin/Makefile > @@ -7,7 +7,7 @@ PERL_DOC_INC_DIRS=.. > include /usr/share/pve-doc-generator/pve-doc-generator.mk > >

Re: [pve-devel] [RFC manager 2/2] upgrade checklist

2019-06-25 Thread Thomas Lamprecht
On 6/24/19 1:56 PM, Fabian Grünbichler wrote: > Signed-off-by: Fabian Grünbichler > --- > Notes: > leftout on purpose: > - checking of sources.list (no parser, lots of false negatives, needs to > happen after upgrade to corosync 3) > > still missing for PVE 6.x / post-upgrade

Re: [pve-devel] [RFC manager] ui: workspace: cope better with upgrade related false positive 401 HTTP codes

2019-06-25 Thread Dominik Csapak
LGTM, do we want to apply this to master only or also to stable-5 ? ___ pve-devel mailing list pve-devel@pve.proxmox.com https://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

[pve-devel] [PATCH docs] add cloudinit dump and snippets documentation

2019-06-25 Thread Mira Limbeck
Adds documentation for the cloudinit snippets support and how 'qm cloudinit dump' can be used to get a base config file. Signed-off-by: Mira Limbeck --- qm-cloud-init.adoc | 36 1 file changed, 36 insertions(+) diff --git a/qm-cloud-init.adoc

[pve-devel] applied: [PATCH manager 1/2] Ceph: add get_cluster_versions helper

2019-06-25 Thread Thomas Lamprecht
On 6/24/19 1:56 PM, Fabian Grünbichler wrote: > to make 'ceph versions' and 'ceph XX versions' accessible. > > Signed-off-by: Fabian Grünbichler > --- > PVE/Ceph/Tools.pm | 8 > 1 file changed, 8 insertions(+) > > diff --git a/PVE/Ceph/Tools.pm b/PVE/Ceph/Tools.pm > index

Re: [pve-devel] [RFC manager] ui: workspace: cope better with upgrade related false positive 401 HTTP codes

2019-06-25 Thread Thomas Lamprecht
On 6/25/19 11:22 AM, Dominik Csapak wrote: > LGTM, do we want to apply this to master only or also to stable-5 ? > thanks for looking at this, applied (to master and stable-5)! ___ pve-devel mailing list pve-devel@pve.proxmox.com

[pve-devel] applied: [PATCH manager] backup jobs: Aquire lock before modifying vzdump.cron

2019-06-25 Thread Thomas Lamprecht
On 6/24/19 5:26 PM, Christian Ebner wrote: > Signed-off-by: Christian Ebner > --- > PVE/API2/Backup.pm | 108 > + > 1 file changed, 59 insertions(+), 49 deletions(-) > applied, thanks! ___

[pve-devel] applied: [PATCH v2 docs] Update pvecm doc regarding IP vs hostname as corosync address

2019-06-25 Thread Thomas Lamprecht
On 6/18/19 3:24 PM, Stefan Reiter wrote: > Signed-off-by: Stefan Reiter > --- > > v2: > * Removed mentions of ring addresses to avoid confusion >(removed in Corosync 3 - though the rest of the file should be >updated for coro 3 too) > * Changed section title > * Added CAUTION: about

Re: [pve-devel] [PATCH manager 3/3] fix #1278 gui: backup: add backup mode pool

2019-06-25 Thread Dominik Csapak
i could not apply 2/3 so i looked only at the gui for now looks mostly good, some comments inline On 6/19/19 12:08 PM, Tim Marx wrote: Signed-off-by: Tim Marx --- www/manager6/dc/Backup.js | 77 +++ 1 file changed, 71 insertions(+), 6

[pve-devel] [RFC guest-common 1/3] fix #1291: implement remove_vmid_from_cronjobs

2019-06-25 Thread Christian Ebner
remove_vmid_from_cronjobs updates the vzdump.cron backup jobs, excluding the given vmid. Signed-off-by: Christian Ebner --- PVE/VZDump/Plugin.pm | 51 +++ 1 file changed, 51 insertions(+) diff --git a/PVE/VZDump/Plugin.pm b/PVE/VZDump/Plugin.pm

[pve-devel] [RFC container 3/3] fix #1291: add option purge for destroy_vm api call

2019-06-25 Thread Christian Ebner
The purge option allows to remove the vmid from the vzdump.cron jobs. Signed-off-by: Christian Ebner --- src/PVE/API2/LXC.pm | 11 +++ 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/src/PVE/API2/LXC.pm b/src/PVE/API2/LXC.pm index cf14d75..563cfb9 100644 ---

[pve-devel] [RFC 0/3] fix #1291: add purge option for VM/CT destroy

2019-06-25 Thread Christian Ebner
The purge flag allows to remove the vmid from the vzdump.cron backup jobs on VM/CT destruction. Christian Ebner (1): fix #1291: implement remove_vmid_from_cronjobs PVE/VZDump/Plugin.pm | 51 +++ 1 file changed, 51 insertions(+) Christian Ebner

[pve-devel] [RFC qemu 2/3] fix #1291: add purge option to vm_destroy api call

2019-06-25 Thread Christian Ebner
The purge flag allows to remove the vmid from the vzdump.cron backup jobs. Signed-off-by: Christian Ebner --- PVE/API2/Qemu.pm | 18 -- 1 file changed, 8 insertions(+), 10 deletions(-) diff --git a/PVE/API2/Qemu.pm b/PVE/API2/Qemu.pm index a628a20..60b0f11 100644 ---

[pve-devel] [PATCH qemu-server] Fix guest agent shutdown without timeout

2019-06-25 Thread Stefan Reiter
Regression from change allowing timeouts to be set, now shutting down also works without timeouts again (previously qmp failed because of the unknown "timeout" parameter passed to it). We always delete the timeout value from the arguments, regardless of truthiness. "delete" returns the deleted

[pve-devel] applied: [PATCH qemu-server] Fix guest agent shutdown without timeout

2019-06-25 Thread Thomas Lamprecht
On 6/25/19 4:44 PM, Stefan Reiter wrote: > Regression from change allowing timeouts to be set, now shutting down > also works without timeouts again (previously qmp failed because of > the unknown "timeout" parameter passed to it). > > We always delete the timeout value from the arguments,

[pve-devel] applied: [PATCH manager] switch over default console viewer to xterm.js

2019-06-25 Thread Thomas Lamprecht
at least where possible, this affects mostly the node shell button. Signed-off-by: Thomas Lamprecht --- www/manager6/Utils.js | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/www/manager6/Utils.js b/www/manager6/Utils.js index 06d7b5fa..9387c582 100644 ---

[pve-devel] [PATCH ceph] add ceph-volume zap fix

2019-06-25 Thread Dominik Csapak
this is pending review upstream Signed-off-by: Dominik Csapak --- ...vm.zap-fix-cleanup-for-db-partitions.patch | 29 +++ patches/series| 1 + 2 files changed, 30 insertions(+) create mode 100644

Re: [pve-devel] [PATCH pve-manager 1/2] pvestatd : broadcast sdn transportzone status

2019-06-25 Thread Alexandre DERUMIER
>>I am not sure if json is a good idea here. We use colon separated lists for >>everything else, so I would prefer that. It is easier to parse inside C, >>which >>is important when you want to generate RRD databases from inside pmxcfs ... >>Also, consider that it is quite hard to change that

Re: [pve-devel] [PATCH pve-manager 1/2] pvestatd : broadcast sdn transportzone status

2019-06-25 Thread Dietmar Maurer
> >>So do we want to generate some RRD databases with that data? > > I don't think we need a rrd here, it's a simple status (ok/error/pending/...) > on the transportzone. Ok > I don't want to stream vnet status, because it could be really huge. > (like 20 servers broadcasting 300vnets for

Re: [pve-devel] [PATCH pve-manager 1/2] pvestatd : broadcast sdn transportzone status

2019-06-25 Thread Alexandre DERUMIER
>>But I can use implement colon lists, no problem. After thinking about it. actually, colon list are mainly used for rrd, but we have 1 rrd by object (and the filename is the key). If I'm using kvstore for broadcast, with columnlist, I think I'll have 1key by transportzone, not sure it'll