On March 4, 2020 9:10 am, Thomas Lamprecht wrote:
> On 3/3/20 11:08 PM, Alexandre DERUMIER wrote:
hmm, can we not just add a after dependency in the "networking.service" on
the
already existing "systemd-udev-settle.service" service?
>>
>> this was the first proposal in the
On 2/27/20 4:14 PM, Dominik Csapak wrote:
> for big vms (many disks/nics) a single status update can be bigger
> than 20k (i measured about 21k for a vm with 31 disks and nics)
> which means that a single update can bring the length of
> $txn->{data} over 65k (if it was >45k before)
nice catch
>
On 2/18/20 12:31 PM, Fabian Ebner wrote:
> Trying to back up a container with a ZFS dataset with non-standard mount
> would fail, see [0].
>
> This also removes the near-dead code
> $name .= "\@$snapname";
> when snapname is false-y, but defined and turns
> the check for $snapname into one for
On 3/4/20 2:11 PM, Dominik Csapak wrote:
> one comment inline
>
> On 3/4/20 11:46 AM, Dietmar Maurer wrote:
>> Signed-off-by: Dietmar Maurer
>> ---
>> PVE/Storage/Plugin.pm | 6 ++
>> 1 file changed, 6 insertions(+)
>>
>> diff --git a/PVE/Storage/Plugin.pm b/PVE/Storage/Plugin.pm
>> index
On 2/20/20 12:55 PM, Alexandre Derumier wrote:
> netmask/broadcast options are deprecated since buster
> https://manpages.debian.org/buster/ifupdown/interfaces.5.en.html
>
> This still read both "old address/netmask" or "address cidr" format,
> but always convert it to cidr address format
>
>
On 2/24/20 4:32 PM, Dominik Csapak wrote:
> instead of having multiple regexes in various places for the name,
> define a 'SERVICE_REGEX' in PVE::Ceph::Services, and use that
> everywhere in the api where we need it
>
> additionally limit new sevices to 200 characters, since
> systemd units have
On 2/24/20 12:01 PM, Dominik Csapak wrote:
> the network and the cluster network are optional in the ceph config
> and with 'pveceph init', so only check if we have an ip address
> from those networks if it is actually configured
>
> otherwise, the createosd call dies with an 'ip' error message
>
On 2/20/20 4:20 PM, Dominik Csapak wrote:
> This will be used for PMG and PVE LDAP Authentication & Sync.
> The code is largely copied/inspired by the already existing LDAP code in
> PVEs AccessControl and PMGs LDAPCache
>
> Signed-off-by: Dominik Csapak
> ---
> src/Makefile| 1 +
>
On 2/19/20 12:47 PM, Alexandre Derumier wrote:
> ifupdown1 have a service to launch "udevadm settle",
> to be sure that networking devices are correctly setup
> before networking service is started.
>
> https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=920623
> Signed-off-by: Alexandre Derumier
On 2/27/20 12:01 PM, Stefan Reiter wrote:
> On 2/27/20 11:48 AM, Fabian Grünbichler wrote:
>> On February 26, 2020 11:53 am, Aaron Lauterer wrote:
>>> If IO-Thread is activated and a new enough Qemu version installed the
>>> program still ran into the elsif clause and never in the else clause.
>>>
Hi,
yes, it need an small api change. I dind't sent the patch serie as it was just
an RFC.
I'll send it today
- Mail original -
De: "Thomas Lamprecht"
À: "pve-devel" , "aderumier"
Envoyé: Mercredi 4 Mars 2020 15:15:24
Objet: Re: [pve-devel] [pve-common 3/3] allow multiple address by
one comment inline
On 3/4/20 11:46 AM, Dietmar Maurer wrote:
Signed-off-by: Dietmar Maurer
---
PVE/Storage/Plugin.pm | 6 ++
1 file changed, 6 insertions(+)
diff --git a/PVE/Storage/Plugin.pm b/PVE/Storage/Plugin.pm
index eab73f5..bd4bb8c 100644
--- a/PVE/Storage/Plugin.pm
+++
On 2/20/20 12:55 PM, Alexandre Derumier wrote:
> only 1 space like all others options
>
> Signed-off-by: Alexandre Derumier
> ---
> src/PVE/INotify.pm| 4 ++--
> test/etc_network_interfaces/t.bridge-v4-v6.pl | 12 +--
> .../t.create_network.pl
On 2/20/20 12:55 PM, Alexandre Derumier wrote:
> Signed-off-by: Alexandre Derumier
> ---
> src/PVE/INotify.pm| 64 +--
> test/etc_network_interfaces/t.bridge-v4-v6.pl | 4 +-
> .../t.create_network.pl | 6 +-
>
On 2/27/20 11:01 AM, Aaron Lauterer wrote:
Signed-off-by: Aaron Lauterer
---
v1[0] -> v2:
given the feedback from Fabian I
* changed name of the method
* added more details as to what implementations should return
[0] https://pve.proxmox.com/pipermail/pve-devel/2020-January/041267.html
On 3/3/20 10:47 AM, Dominik Csapak wrote:
> and expose the range in its own sub to reuse it in http-server
>
> Signed-off-by: Dominik Csapak
> ---
> src/PVE/Tools.pm | 6 +-
> 1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/src/PVE/Tools.pm b/src/PVE/Tools.pm
> index
On 2/25/20 11:28 AM, Dominic Jäger wrote:
> Move wipe_disks from PVE::Ceph::Tools to PVE::Diskmanage and improve it by
> - Handling invalid parameters
> - Adding options for wiping
> - Making names clearer, especially the sub name to indicate that it works for
>partitions, too.
> - Use
On 2/24/20 9:37 AM, Aaron Lauterer wrote:
> in some situations it is possible, that a disk does not have a
> /dev/disk/by-id path. Reported cases are KVM with virtio-blk [0] and
> with VMware player / workstation when using the paravirtual SCSI disk
> types [1]. It can be reproduced in Proxmox VE
On 2/21/20 7:55 AM, Wolfgang Link wrote:
> Improvement of grammar and punctuation.
> Clarify the HA limitations.
> Remove future tense in some sentences.
> It is not good to use it in technical/scientific papers.
> Rewrite some sentences to improve understanding.
> ---
> pvesr.adoc | 112
Following the pve-common patch serie
Alexandre Derumier (1):
API2: Network: allow cidr-list && use cidr for address
PVE/API2/Network.pm | 23 +++
1 file changed, 15 insertions(+), 8 deletions(-)
--
2.20.1
___
pve-devel mailing
Signed-off-by: Alexandre Derumier
---
PVE/API2/Network.pm | 23 +++
1 file changed, 15 insertions(+), 8 deletions(-)
diff --git a/PVE/API2/Network.pm b/PVE/API2/Network.pm
index 84bd3c3a..82ae9037 100644
--- a/PVE/API2/Network.pm
+++ b/PVE/API2/Network.pm
@@ -153,7 +153,7 @@
>>The dependency ordering ones? FYI, we did already try to upstream
>>that:
>>https://github.com/CumulusNetworks/ifupdown2/pull/68
oh, I totally miss this.
>>But cumulus devs closed quite a few of Wolfgangs tries by force pushing
>>to master a few times, which makes github close all pull
>>applied, thanks! Would you like to look into up-streaming this to
>>ifupdown2?
yes,sure.
I'll also try to push other changes in networking.service
- Mail original -
De: "Thomas Lamprecht"
À: "pve-devel" , "aderumier"
Envoyé: Mercredi 4 Mars 2020 14:50:52
Objet: applied: [pve-devel]
On 3/4/20 5:59 PM, Alexandre DERUMIER wrote:
>>> applied, thanks! Would you like to look into up-streaming this to
>>> ifupdown2?
>
> yes,sure.
> I'll also try to push other changes in networking.service
The dependency ordering ones? FYI, we did already try to upstream
that:
and an entry for the corrupted cachefile problem which keeps showing up
in forum posts.
Signed-off-by: Oguz Bektas
---
local-zfs.adoc | 29 +
1 file changed, 29 insertions(+)
diff --git a/local-zfs.adoc b/local-zfs.adoc
index 5cce677..c516db8 100644
---
Signed-off-by: Dietmar Maurer
---
www/manager6/storage/ContentView.js | 6 +-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/www/manager6/storage/ContentView.js
b/www/manager6/storage/ContentView.js
index ffd38fb9..001efc7f 100644
--- a/www/manager6/storage/ContentView.js
+++
On 3/3/20 11:08 PM, Alexandre DERUMIER wrote:
>>> hmm, can we not just add a after dependency in the "networking.service" on
>>> the
>>> already existing "systemd-udev-settle.service" service?
>
> this was the first proposal in the discuss
>
>
On 3/4/20 9:46 AM, Thomas Lamprecht wrote:
On 2/27/20 4:14 PM, Dominik Csapak wrote:
for big vms (many disks/nics) a single status update can be bigger
than 20k (i measured about 21k for a vm with 31 disks and nics)
which means that a single update can bring the length of
$txn->{data} over 65k
On 3/4/20 10:01 AM, Dominik Csapak wrote:
> On 3/4/20 9:46 AM, Thomas Lamprecht wrote:
>> On 2/27/20 4:14 PM, Dominik Csapak wrote:
>>> for big vms (many disks/nics) a single status update can be bigger
>>> than 20k (i measured about 21k for a vm with 31 disks and nics)
>>> which means that a
This reverts commit b5490d8a98e5e7328eb4cebb0ae0b60e6d406c38.
When resizing a volume of a running VM, a qmp block_resize command
is issued. This is non-blocking, so the size on the storage immediately
after issuing the command might still be the old one.
This is part of the issue reported in bug
Signed-off-by: Dietmar Maurer
---
PVE/Storage/PBSPlugin.pm | 9 ++---
1 file changed, 6 insertions(+), 3 deletions(-)
diff --git a/PVE/Storage/PBSPlugin.pm b/PVE/Storage/PBSPlugin.pm
index fcb1597..2a4c19c 100644
--- a/PVE/Storage/PBSPlugin.pm
+++ b/PVE/Storage/PBSPlugin.pm
@@ -282,18
Signed-off-by: Dietmar Maurer
---
PVE/API2/Storage/Content.pm | 6 ++
1 file changed, 6 insertions(+)
diff --git a/PVE/API2/Storage/Content.pm b/PVE/API2/Storage/Content.pm
index ce89ec5..80c9501 100644
--- a/PVE/API2/Storage/Content.pm
+++ b/PVE/API2/Storage/Content.pm
@@ -81,6 +81,12 @@
Signed-off-by: Dietmar Maurer
---
PVE/Storage/Plugin.pm | 6 ++
1 file changed, 6 insertions(+)
diff --git a/PVE/Storage/Plugin.pm b/PVE/Storage/Plugin.pm
index eab73f5..bd4bb8c 100644
--- a/PVE/Storage/Plugin.pm
+++ b/PVE/Storage/Plugin.pm
@@ -6,6 +6,7 @@ use warnings;
use File::chdir;
Changed file_size_info() to additionally return ctime to avoid
another stat() call.
Signed-off-by: Dietmar Maurer
---
PVE/Storage/Plugin.pm | 18 +-
1 file changed, 13 insertions(+), 5 deletions(-)
diff --git a/PVE/Storage/Plugin.pm b/PVE/Storage/Plugin.pm
index
Signed-off-by: Dietmar Maurer
---
PVE/Storage/LVMPlugin.pm | 15 +++
PVE/Storage/LvmThinPlugin.pm | 1 +
2 files changed, 12 insertions(+), 4 deletions(-)
diff --git a/PVE/Storage/LVMPlugin.pm b/PVE/Storage/LVMPlugin.pm
index f02c110..c9fc191 100644
---
Creation time makes sense for other file types also.
Signed-off-by: Dietmar Maurer
---
PVE/Storage/Plugin.pm | 10 --
1 file changed, 8 insertions(+), 2 deletions(-)
diff --git a/PVE/Storage/Plugin.pm b/PVE/Storage/Plugin.pm
index bd4bb8c..85af1c8 100644
--- a/PVE/Storage/Plugin.pm
+++
36 matches
Mail list logo
