two nits in-line
On March 12, 2020 1:08 pm, Fabian Ebner wrote:
> and also return the ID of the allocated volume. This option
> allows plugins to choose a new name if there is a collision.
>
> In storage_migrate, the API version for the receiving side is checked.
>
> In Storage.pm's
On March 12, 2020 1:08 pm, Fabian Ebner wrote:
> to guess a valid volname for a targetstorage of a different type.
> This makes it possible to migrate raw volumes between 'dir' and 'lvm'
> storages.
>
> It is only used when the storage type for the source storage X
> and target storage Y differ
On March 12, 2020 1:08 pm, Fabian Ebner wrote:
> Signed-off-by: Fabian Ebner
> ---
> PVE/QemuMigrate.pm | 12
> 1 file changed, 8 insertions(+), 4 deletions(-)
>
> diff --git a/PVE/QemuMigrate.pm b/PVE/QemuMigrate.pm
> index 44e4c57..464abc6 100644
> --- a/PVE/QemuMigrate.pm
> +++
On March 12, 2020 1:08 pm, Fabian Ebner wrote:
> Signed-off-by: Fabian Ebner
> ---
> PVE/CLI/pvesm.pm | 30 ++
> 1 file changed, 30 insertions(+)
>
> diff --git a/PVE/CLI/pvesm.pm b/PVE/CLI/pvesm.pm
> index 510faba..7c0e259 100755
> --- a/PVE/CLI/pvesm.pm
> +++
On March 12, 2020 1:08 pm, Fabian Ebner wrote:
> This function is intened to be used after doing a migration where some
> of the volume IDs changed.
>
> Signed-off-by: Fabian Ebner
> ---
> PVE/AbstractConfig.pm | 30 ++
> 1 file changed, 30 insertions(+)
>
> diff
On March 12, 2020 1:08 pm, Fabian Ebner wrote:
> Introduce a parameter $opts to allow for better control of which
> keys/volumes to use for the iteration and ability to reverse the order.
> Also, allow extra parameters for the function.
>
> Removes the '__snapshot'-prefix for future use from
Signed-off-by: Alexandre Derumier
---
PVE/Network/SDN/Controllers.pm | 3 ++-
PVE/Network/SDN/Vnets.pm | 2 +-
PVE/Network/SDN/Zones.pm | 3 ++-
3 files changed, 5 insertions(+), 3 deletions(-)
diff --git a/PVE/Network/SDN/Controllers.pm b/PVE/Network/SDN/Controllers.pm
index
On March 12, 2020 1:08 pm, Fabian Ebner wrote:
> This is the second half for the previous series [0].
>
> This series aims to allow offline migration with '--targetstorage'
> and improve handling unsued/orphaned disks when migrating.
> It also makes it possible to migrate volumes between storages
With Qemu 4.2 a new `audiodev` property was introduced [0] to explicitly
specify the backend to be used for the audio device. This is accompanied
with a warning that the fallback to the default audio backend is
deprecated.
[0] https://wiki.qemu.org/ChangeLog/4.2#Audio
Signed-off-by: Aaron
On March 12, 2020 11:19 am, Fabian Ebner wrote:
> and make it match with what parse_drive does. Even though the 'real' format
> was pve-volume-id, callers already expected that parse_drive returns a hash
> with a valid 'file' key (e.g. PVE/API2/Qemu.pm:1147ff).
>
> Signed-off-by: Fabian Ebner
>
On 3/16/20 8:04 AM, Fabian Grünbichler wrote:
On March 13, 2020 4:21 pm, Aaron Lauterer wrote:
Add the `,audiodev=` property to audio devices when machine version is
4.2 or higher.
With Qemu 4.2 a new `audiodev` property was introduced [0] to explicitly
specify the backend to be used for the
this got broken with PBS integration patches
Signed-off-by: Fabian Grünbichler
---
https://forum.proxmox.com/threads/proxmox-6-1-7-pct-restore-unable-to-parse-volume-id.67076/
src/PVE/LXC/Create.pm | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/PVE/LXC/Create.pm
On March 13, 2020 4:21 pm, Aaron Lauterer wrote:
> Add the `,audiodev=` property to audio devices when machine version is
> 4.2 or higher.
>
> With Qemu 4.2 a new `audiodev` property was introduced [0] to explicitly
> specify the backend to be used for the audio device. This is accompanied
> with
so that we can choose to only include the versions and not all metadata
this is done to avoid having a seperate 'versions' api call
Signed-off-by: Dominik Csapak
---
PVE/API2/Cluster/Ceph.pm | 12 +++-
1 file changed, 11 insertions(+), 1 deletion(-)
diff --git
this makes it closer to the OSD list, using the new 'version-only'
metadata api call
this partially fixes #2468
Signed-off-by: Dominik Csapak
---
www/manager6/ceph/ServiceList.js | 58 +++-
1 file changed, 57 insertions(+), 1 deletion(-)
diff --git
which also removes some dead code
(the my $local_last_version variable was never used)
Signed-off-by: Dominik Csapak
---
PVE/API2/Cluster/Ceph.pm | 6 ++
PVE/Ceph/Services.pm | 30 ++
PVE/Service/pvestatd.pm | 19 +--
3 files changed, 33
adds more visual hints about the ceph versions (needs upgrade/restart)
and a 'highest cluster version' on the ceph dashboard
to let the admin know what the expected version is
Dominik Csapak (5):
ceph: factor out get/broadcast ceph versions to ceph::services
ceph: add 'scope' parameter to
On 16.03.20 10:10, Fabian Grünbichler wrote:
On March 12, 2020 11:19 am, Fabian Ebner wrote:
and make it match with what parse_drive does. Even though the 'real' format
was pve-volume-id, callers already expected that parse_drive returns a hash
with a valid 'file' key (e.g.
On 16.03.20 12:05, Fabian Grünbichler wrote:
On March 12, 2020 1:08 pm, Fabian Ebner wrote:
Introduce a parameter $opts to allow for better control of which
keys/volumes to use for the iteration and ability to reverse the order.
Also, allow extra parameters for the function.
Removes the
needs a rebase (please always rebase before sending - the last commit on
src/PVE/VZDump/LXC.pm was done before you sent this patch out!)
On February 27, 2020 11:01 am, Aaron Lauterer wrote:
> Move the logic which mountpoints are included in the backup job to its
> own method and adapt the VZDump
On 3/16/20 10:10 AM, Fabian Grünbichler wrote:
> On March 12, 2020 11:19 am, Fabian Ebner wrote:
>> and make it match with what parse_drive does. Even though the 'real' format
>> was pve-volume-id, callers already expected that parse_drive returns a hash
>> with a valid 'file' key (e.g.
On 3/16/20 1:16 PM, Fabian Grünbichler wrote:
needs a rebase (please always rebase before sending - the last commit on
src/PVE/VZDump/LXC.pm was done before you sent this patch out!)
Sorry. I'll send a rebased series later today.
___
pve-devel
On 3/16/20 1:56 PM, Dominik Csapak wrote:
this makes it closer to the OSD list, using the new 'version-only'
metadata api call
this partially fixes #2468
Signed-off-by: Dominik Csapak
---
www/manager6/ceph/ServiceList.js | 58 +++-
1 file changed, 57
instead of always expecting a '.' separated version string
we will use this for the 'structured' version data
Signed-off-by: Dominik Csapak
---
www/manager6/Utils.js | 17 +++--
1 file changed, 15 insertions(+), 2 deletions(-)
diff --git a/www/manager6/Utils.js
so that the admin knows what the 'expected' ceph version is
partially fixes #2468
Signed-off-by: Dominik Csapak
---
www/manager6/ceph/Status.js | 51 ++---
1 file changed, 48 insertions(+), 3 deletions(-)
diff --git a/www/manager6/ceph/Status.js
Hi all,
Commit[1] extended the filter, but if you look closely, there is no ','
between the second and third rule. Quite frankly, I don't know what LVM
makes out of that, most likely it even considers them as 2 separate
rules. Or it concats them and then still parses them as 2. LVM is
mysterious
On 16.03.20 12:07, Fabian Grünbichler wrote:
On March 12, 2020 1:08 pm, Fabian Ebner wrote:
This is the second half for the previous series [0].
This series aims to allow offline migration with '--targetstorage'
and improve handling unsued/orphaned disks when migrating.
It also makes it
On March 16, 2020 2:53 pm, Fabian Ebner wrote:
>
> On 16.03.20 12:07, Fabian Grünbichler wrote:
>> On March 12, 2020 1:08 pm, Fabian Ebner wrote:
>>> This is the second half for the previous series [0].
>>>
>>> This series aims to allow offline migration with '--targetstorage'
>>> and improve
This is a follow up to [0] but only includes the refactored changes to
make ti possible to have other features around the VZDump functionality.
It is moving the following logic into its own methods:
* which guests are included in a backup job
* which volumes / mountpoints of a guest are included
Move the logic which volumes are included in the backup job to its own
method and adapt the VZDump code accordingly. This makes it possible to
develop other features around backup jobs.
Signed-off-by: Aaron Lauterer
---
v2 -> v3: rebased
v1 -> v2:
* implemented the suggestions from Fabian [0]
Move the logic which mountpoints are included in the backup job to its
own method and adapt the VZDump code accordingly. This makes it possible
to develop other features around backup jobs.
Signed-off-by: Aaron Lauterer
---
v2 -> v3: rebased
v1 -> v2: implemented the suggestion from Fabian [0]
This extracts the logic which guests are to be included in a backup job
into its own method 'get_included_guests'. This makes it possible to
develop other features around backup jobs.
Logic which was spread out accross the API2/VZDump.pm file and the
VZDump.pm file is refactored into the new
Signed-off-by: Aaron Lauterer
---
v2->v3:
rebased
v1->v2:
moved the determination of the reason to the same method that decides if
a mountpoint is included in the backup.
src/PVE/LXC/Config.pm | 24 +---
1 file changed, 17 insertions(+), 7 deletions(-)
diff --git
new rebased series it out. I did it for each repo to be rather on the
overdone side than missing something :)
On 3/16/20 1:33 PM, Aaron Lauterer wrote:
On 3/16/20 1:16 PM, Fabian Grünbichler wrote:
needs a rebase (please always rebase before sending - the last commit on
34 matches
Mail list logo
