Re: [pve-devel] [PATCH v3 manager 1/1] backup: move logic to include guests into method

2020-03-18 Thread Aaron Lauterer
On 3/18/20 2:10 PM, Fabian Grünbichler wrote: On March 18, 2020 11:57 am, Aaron Lauterer wrote: On 3/17/20 3:33 PM, Fabian Grünbichler wrote: On March 16, 2020 4:44 pm, Aaron Lauterer wrote: This extracts the logic which guests are to be included in a backup job into its own method

Re: [pve-devel] [PATCH v3 manager 1/1] backup: move logic to include guests into method

2020-03-18 Thread Fabian Grünbichler
On March 18, 2020 11:57 am, Aaron Lauterer wrote: > > > On 3/17/20 3:33 PM, Fabian Grünbichler wrote: >> On March 16, 2020 4:44 pm, Aaron Lauterer wrote: >>> This extracts the logic which guests are to be included in a backup job >>> into its own method 'get_included_guests'. This makes it

[pve-devel] [PATCH container 2/2] move_volume: if deleting old volume fails, add it as unused

2020-03-18 Thread Fabian Ebner
Like this it's clearer that the volume is still there. The warning is easily missed. Signed-off-by: Fabian Ebner --- src/PVE/API2/LXC.pm | 9 - 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/src/PVE/API2/LXC.pm b/src/PVE/API2/LXC.pm index 9eb52dc..6280430 100644 ---

[pve-devel] [PATCH container 1/2] fix #1904: convert to base image when moving a volume of a template

2020-03-18 Thread Fabian Ebner
Signed-off-by: Fabian Ebner --- For VMs this already happens. When adding volumes to templates no such conversion to base images happens yet (affects both VM/LXC). Because templates are more-or-less supposed to be read-only it probably makes sense to disallow adding volumes altogether. Or

Re: [pve-devel] [PATCH v3 manager 1/1] backup: move logic to include guests into method

2020-03-18 Thread Aaron Lauterer
On 3/17/20 3:33 PM, Fabian Grünbichler wrote: On March 16, 2020 4:44 pm, Aaron Lauterer wrote: This extracts the logic which guests are to be included in a backup job into its own method 'get_included_guests'. This makes it possible to develop other features around backup jobs. Logic which

Re: [pve-devel] applied: [PATCH http-server 1/4] websocket: improve masking performance

2020-03-18 Thread Alexandre DERUMIER
Hi, sorry. Didn't have time with this fucking coronavirus :/ We are working at home in France for the next weeks, and I need to keep my child at home at the same time. I think I'll have more time next week. Alexandre - Mail original - De: "Fabian Grünbichler" À: "aderumier" Cc:

[pve-devel] [PATCH qemu-server 1/2] Disable memory hotplugging for custom NUMA topologies

2020-03-18 Thread Stefan Reiter
This cannot work, since we adjust the 'memory' property of the VM config on hotplugging, but then the user-defined NUMA topology won't match for the next start attempt. Check needs to happen here, since it otherwise fails early with "total memory for NUMA nodes must be equal to vm static memory".

[pve-devel] [PATCH qemu-server 2/2] Die on misaligned memory for hotplugging

2020-03-18 Thread Stefan Reiter
...instead of booting with an invalid config once and then silently changing the memory size for consequent VM starts. Signed-off-by: Stefan Reiter --- This confused me for a bit, I don't think that's very nice behaviour as it stands. PVE/QemuServer/Memory.pm | 7 ++- 1 file changed, 2

Re: [pve-devel] [zsync] fix: check for incremental sync snapshot.

2020-03-18 Thread Dietmar Maurer
Why does the patch ignore the output from the command? > On March 18, 2020 7:51 AM Wolfgang Link wrote: > > > For an incremental sync you need the last_snap on both sides. > --- > pve-zsync | 13 - > 1 file changed, 4 insertions(+), 9 deletions(-) > > diff --git a/pve-zsync

[pve-devel] applied-series: [PATCH v2 qemu-server 0/4] fix secure live migration with local

2020-03-18 Thread Fabian Grünbichler
with followup: From db1f8b39e173bcb19113b13bd712f1c2e18c0a9d Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Fabian=20Gr=C3=BCnbichler?= Date: Wed, 18 Mar 2020 08:21:29 +0100 Subject: [PATCH qemu-server] drive_mirror: rename variables and values MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8

[pve-devel] [zsync] fix: check for incremental sync snapshot.

2020-03-18 Thread Wolfgang Link
For an incremental sync you need the last_snap on both sides. --- pve-zsync | 13 - 1 file changed, 4 insertions(+), 9 deletions(-) diff --git a/pve-zsync b/pve-zsync index ea3178e..893baf0 100755 --- a/pve-zsync +++ b/pve-zsync @@ -931,6 +931,7 @@ sub snapshot_destroy { } }

Re: [pve-devel] [zsync] fix: check for incremental sync snapshot.

2020-03-18 Thread Wolfgang Link
The call to the zfs list contains the snapshot. If the snapshot does not exist, the command is returned with an error that we are catching. > On March 18, 2020 8:02 AM Dietmar Maurer wrote: > > > Why does the patch ignore the output from the command? > > > On March 18, 2020 7:51 AM

Re: [pve-devel] applied: [PATCH http-server 1/4] websocket: improve masking performance

2020-03-18 Thread Fabian Grünbichler
On March 10, 2020 2:57 pm, Alexandre DERUMIER wrote: >>>[ 5] 0.00-10.00 sec 2.58 GBytes 2.22 Gbits/sec 0 sender >>>[ 5] 0.00-10.00 sec 2.57 GBytes 2.21 Gbits/sec receiver >>>iperf Done. > >>>this is with TLS and our regular AnyEvent API server handling the >>>connection, with the target being

Re: [pve-devel] [PATCH v2 qemu-server 4/4] add unix socket support for NBD storage migration

2020-03-18 Thread Stefan Reiter
On 17/03/2020 20:56, Mira Limbeck wrote: The reuse of the tunnel, which we're opening to communicate with the target node and to forward the unix socket for the state migration, for the NBD unix socket requires adding support for an array of sockets to forward, not just a single one. We also

Re: [pve-devel] [PATCH v2 qemu-server 2/4] add NBD server unix socket support in vm_start

2020-03-18 Thread Stefan Reiter
On 17/03/2020 20:56, Mira Limbeck wrote: As the NBD server spawned by qemu can only listen on a single socket, we're dependent on a version being passed to vm_start that indicates which protocol can be used, TCP or Unix, by the source node. The change in socket type (TCP to Unix) comes with a

Re: [pve-devel] [PATCH v2 qemu-server 2/4] add NBD server unix socket support in vm_start

2020-03-18 Thread Fabian Grünbichler
On March 18, 2020 10:02 am, Stefan Reiter wrote: > On 17/03/2020 20:56, Mira Limbeck wrote: >> As the NBD server spawned by qemu can only listen on a single socket, >> we're dependent on a version being passed to vm_start that indicates >> which protocol can be used, TCP or Unix, by the source

Re: [pve-devel] [PATCH v2 qemu-server 4/4] add unix socket support for NBD storage migration

2020-03-18 Thread Thomas Lamprecht
On 3/18/20 10:11 AM, Fabian Grünbichler wrote: >>> @@ -594,10 +597,16 @@ sub phase2 { >>> } >>> >>> my $spice_port; >>> +my $tunnel_addr = []; >>> +my $sock_addr = []; >>> +# version > 0 for unix socket support >>> +my $nbd_protocol_version = 1; >>> +my $input =

Re: [pve-devel] [PATCH v2 qemu-server 4/4] add unix socket support for NBD storage migration

2020-03-18 Thread Fabian Grünbichler
On March 18, 2020 10:02 am, Stefan Reiter wrote: > On 17/03/2020 20:56, Mira Limbeck wrote: >> The reuse of the tunnel, which we're opening to communicate with the target >> node and to forward the unix socket for the state migration, for the NBD unix >> socket requires adding support for an array

[pve-devel] [PATCH container v2] lxc_config: mount /sys as mixed for unprivileged by default

2020-03-18 Thread Thomas Lamprecht
CONTAINER_INTERFACE[0] is something systemd people call their API and we need to adapt to it a bit, even if it means doing stupid unnecessary things, as else systemd decides to regress and suddenly break network stack in CT after an upgrade[1]. This mounts the parent /sys as mixed, which is: >

Re: [pve-devel] [PATCH v2 qemu-server 4/4] add unix socket support for NBD storage migration

2020-03-18 Thread Mira Limbeck
> Thomas Lamprecht hat am 18. März 2020 10:32 > geschrieben: > > > On 3/18/20 10:11 AM, Fabian Grünbichler wrote: > >>> @@ -594,10 +597,16 @@ sub phase2 { > >>> } > >>> > >>> my $spice_port; > >>> +my $tunnel_addr = []; > >>> +my $sock_addr = []; > >>> +# version >