[pve-devel] [RFC v2 manager] change permissions for non-network cloudinit settings

2020-06-25 Thread Mira Limbeck
With the introduction of VM.Config.Cloudinit we can set the user, password and an SSH key without VM.Config.Network permission. Keep the fallback for VM.Config.Network so custom roles don't break. Signed-off-by: Mira Limbeck --- v2: - fallback to 'VM.Config.Network' requires both

[pve-devel] [RFC v2 qemu-server] close #2741: add VM.Config.Cloudinit permission

2020-06-25 Thread Mira Limbeck
This allows setting ciuser, cipassword and all other cloudinit settings that are not part of the network without VM.Config.Network permissions. Keep VM.Config.Network still as fallback so custom roles that add VM.Config.Network but not VM.Config.Cloudinit don't break. Signed-off-by: Mira Limbeck

[pve-devel] [RFC v2 access-control] introduce VM.Config.Cloudinit permission

2020-06-25 Thread Mira Limbeck
It is added to PVEVMUser by default. Signed-off-by: Mira Limbeck --- v2: - unchanged PVE/AccessControl.pm | 1 + 1 file changed, 1 insertion(+) diff --git a/PVE/AccessControl.pm b/PVE/AccessControl.pm index f50a510..ae8eaae 100644 --- a/PVE/AccessControl.pm +++ b/PVE/AccessControl.pm @@

[pve-devel] [PATCH qemu-server] avoid backup command timeout with pbs

2020-06-25 Thread Dietmar Maurer
--- PVE/VZDump/QemuServer.pm | 2 ++ 1 file changed, 2 insertions(+) diff --git a/PVE/VZDump/QemuServer.pm b/PVE/VZDump/QemuServer.pm index 1a0d437..147a3e6 100644 --- a/PVE/VZDump/QemuServer.pm +++ b/PVE/VZDump/QemuServer.pm @@ -403,6 +403,8 @@ sub archive_pbs { $params->{fingerprint} =

[pve-devel] cloudinit: generate server ssh keys on proxmox side ?

2020-06-25 Thread Alexandre DERUMIER
Hi, I'm currently testing cloudinit, and I have notice that each time we are doing a change, as we generate a new instance each time (because they are no other easy way to get network configuration regenerate), The server ssh private keys are generate again and again. It's possible to put in

[pve-devel] applied: [PATCH node_config 1/1] node_config: Allow leading underscore in ACME aliases

2020-06-25 Thread Fabian Grünbichler
applied with rename follow-up, thanks! On June 22, 2020 12:10 pm, Fabian Möller wrote: > --- > PVE/NodeConfig.pm | 12 +++- > 1 file changed, 11 insertions(+), 1 deletion(-) > > diff --git a/PVE/NodeConfig.pm b/PVE/NodeConfig.pm > index ad49e288..017f6b30 100644 > ---

Re: [pve-devel] cloudinit: generate server ssh keys on proxmox side ?

2020-06-25 Thread Dietmar Maurer
> Maybe could we generate them once at proxmox side ? -1 Copying private keys is bad ... ___ pve-devel mailing list pve-devel@pve.proxmox.com https://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

[pve-devel] [PATCH v2 node_config 1/1] node_config: Allow leading underscore in ACME aliases

2020-06-25 Thread Fabian Möller
--- PVE/NodeConfig.pm | 12 +++- 1 file changed, 11 insertions(+), 1 deletion(-) diff --git a/PVE/NodeConfig.pm b/PVE/NodeConfig.pm index ad49e288..c16e455f 100644 --- a/PVE/NodeConfig.pm +++ b/PVE/NodeConfig.pm @@ -25,6 +25,16 @@ PVE::JSONSchema::register_format('pve-acme-domain', sub {

[pve-devel] [PATCH v2 node_config 0/1] node_config: Allow leading underscore in ACME aliases

2020-06-25 Thread Fabian Möller
CLA is signed. Created a v2 with the suggested changes. Fabian Möller (1): node_config: Allow leading underscore in ACME aliases PVE/NodeConfig.pm | 12 +++- 1 file changed, 11 insertions(+), 1 deletion(-) -- 2.27.0 ___ pve-devel mailing

[pve-devel] [PATCH v3 common 1/3] JSONSchema: add format validator support and cleanup check_format

2020-06-25 Thread Stefan Reiter
Adds a third, optional parameter to register_format that allows specifying a function that will be called after parsing and can validate the parsed data. A validator should die on failed validation, and can also change the parsed object by returning a modified version of it. This is useful so one

[pve-devel] [PATCH v3 common 2/3] JSONSchema: use validator in print_property_string too

2020-06-25 Thread Stefan Reiter
Suggested-by: Fabian Grünbichler Signed-off-by: Stefan Reiter --- src/PVE/JSONSchema.pm | 5 + 1 file changed, 5 insertions(+) diff --git a/src/PVE/JSONSchema.pm b/src/PVE/JSONSchema.pm index f987006..59a2b5a 100644 --- a/src/PVE/JSONSchema.pm +++ b/src/PVE/JSONSchema.pm @@ -1878,9

[pve-devel] [PATCH v3 0/3] Add format validator support

2020-06-25 Thread Stefan Reiter
Fixes "cpu" format documentation in man pages by introducing format validators, which allow custom validation functions to be used together with format hashes. The plan is to change occurances of hash based formats in parse_property_string to named formats, so that future validators would be

[pve-devel] applied: Re: [PATCH pve-manager] sdn: fix zone icon in tree view

2020-06-25 Thread Thomas Lamprecht
On 19.06.20 17:50, Alexandre Derumier wrote: > also add status icon: > -pending (yellow triangle) > -error (red cross) > > Signed-off-by: Alexandre Derumier > --- > www/css/ext6-pve.css | 4 > www/manager6/tree/ResourceTree.js | 4 ++-- > 2 files changed, 6 insertions(+),

[pve-devel] [PATCH widget-toolkit/manager] move/refactor ZFS related gui components into widget-toolkit

2020-06-25 Thread Dominik Csapak
to be used outside of pve includes some refactor/rewriting, but the components are not that big, so it should be rather straightforward manager patches depend on widget-toolkit, but they do not conflict so we could apply manager sometime later proxmox-widget-toolkit: Dominik Csapak (3):

[pve-devel] [PATCH widget-toolkit 3/3] add window/ZFSDetail

2020-06-25 Thread Dominik Csapak
inspired by pve's detail window, which used two sub components (ZFSStatus, ZFSDevices; which were never used elsewhere) combined into one self-contained window Signed-off-by: Dominik Csapak --- src/Makefile| 1 + src/window/ZFSDetail.js | 152

[pve-devel] [PATCH widget-toolkit 2/3] add form/MultiDiskSelector

2020-06-25 Thread Dominik Csapak
from pve's ZFSCreate window, refactored to be self-contained using field mixin, as well as be configureable enough to be used by pve as well as other products Signed-off-by: Dominik Csapak --- src/Makefile | 1 + src/form/MultiDiskSelector.js | 164

[pve-devel] [PATCH manager 1/1] ui: use ZFS components and functions from widget-toolkit

2020-06-25 Thread Dominik Csapak
render_zfs_health is now in widget-toolkit as well as the 'MultiDiskSelector' and the Detailwindow and drop the now unnecessary classes Signed-off-by: Dominik Csapak --- www/manager6/Utils.js| 26 www/manager6/node/ZFS.js | 255 +-- 2 files

[pve-devel] [PATCH widget-toolkit 1/3] Utils: add render_zfs_health

2020-06-25 Thread Dominik Csapak
from pve-manager Signed-off-by: Dominik Csapak --- src/Utils.js | 25 + 1 file changed, 25 insertions(+) diff --git a/src/Utils.js b/src/Utils.js index b5b1acb..d959dee 100644 --- a/src/Utils.js +++ b/src/Utils.js @@ -740,6 +740,31 @@ utilities: { return

Re: [pve-devel] [PATCH qemu-server 3/3] fix #2794: allow legacy IGD passthrough

2020-06-25 Thread Stefan Reiter
On 6/24/20 9:46 AM, Thomas Lamprecht wrote: Am 6/22/20 um 10:17 AM schrieb Stefan Reiter: @@ -89,7 +97,8 @@ sub get_pci_addr_map {   $pci_addr_map = {   piix3 => { bus => 0, addr => 1, conflict_ok => qw(ehci)  },   ehci => { bus => 0, addr => 1, conflict_ok => qw(piix3) }, # 

[pve-devel] applied: Re: [PATCH qemu 1/3] fix #2794: Include legacy-igd passthrough fix

2020-06-25 Thread Thomas Lamprecht
On 18.06.20 16:36, Stefan Reiter wrote: > See https://bugs.launchpad.net/qemu/+bug/1882784 > > Signed-off-by: Stefan Reiter > --- > ...ks-Fix-broken-legacy-IGD-passthrough.patch | 34 +++ > debian/patches/series | 1 + > 2 files changed, 35 insertions(+)

[pve-devel] applied: Re: [PATCH qemu-server 2/3] cfg2cmd: hostpci: move code to PCI.pm

2020-06-25 Thread Thomas Lamprecht
On 18.06.20 16:36, Stefan Reiter wrote: > To avoid further cluttering config_to_command with subsequent changes. > > Signed-off-by: Stefan Reiter > --- > PVE/QemuServer.pm | 170 ++ > PVE/QemuServer/PCI.pm | 170

[pve-devel] [PATCH v3 qemu-server 3/3] fix #2671: include CPU format in man page again

2020-06-25 Thread Stefan Reiter
Use the new register_format(3) call to use a validator (instead of a parser) for 'pve-(vm-)?cpu-conf'. This way the $cpu_fmt hash can be used for generating the documentation, while still applying the same verification rules as before. Since the function no longer parses but only verifies, the

[pve-devel] applied: Re: [PATCH qemu-server 3/3] fix #2794: allow legacy IGD passthrough

2020-06-25 Thread Thomas Lamprecht
On 18.06.20 16:36, Stefan Reiter wrote: > Legacy IGD passthrough requires address 00:1f.0 to not be assigned to > anything on QEMU startup (currently it's assigned to bridge pci.2). > Changing this in general would break live-migration, so introduce a new > hostpci parameter "legacy-igd", which if

Re: [pve-devel] cloudinit: generate server ssh keys on proxmox side ?

2020-06-25 Thread Alexandre DERUMIER
> Maybe could we generate them once at proxmox side ? >>-1 >> >>Copying private keys is bad ... I'll look if I can make sshkey gen occur only once, or simply chattr files it's possible to configure cloudinit modules, to launch only [once,instance,always]. by default, almost all modules run

[pve-devel] applied widget-toolkit: [PATCH widget-toolkit/manager] move/refactor ZFS related gui components into widget-toolkit

2020-06-25 Thread Thomas Lamprecht
On 25.06.20 13:59, Dominik Csapak wrote: > to be used outside of pve > includes some refactor/rewriting, but the components are not that big, > so it should be rather straightforward > > manager patches depend on widget-toolkit, but they do not conflict > so we could apply manager sometime later

[pve-devel] applied: Re: [PATCH pve-network] improve status

2020-06-25 Thread Thomas Lamprecht
On 19.06.20 13:47, Alexandre Derumier wrote: > check all plumbing interfaces needed for vnets > > Signed-off-by: Alexandre Derumier > --- > PVE/Network/SDN/Zones.pm| 29 +--- > PVE/Network/SDN/Zones/Plugin.pm | 35 >