Re: [pve-devel] [PATCH widget-toolkit 2/4] add TimezonePanel for containers

2020-07-06 Thread Thomas Lamprecht
On 06.07.20 11:02, Oguz Bektas wrote: >>> + >>> +initComponent: function() { >>> + var me = this; >>> + >>> + var items = []; >> how's that not just a static >> items: [ >> { ... }, >> ], >> >> definition? >> >> And even if it would need to be in initComponent then to me.items = [ ...

Re: [pve-devel] [PATCH widget-toolkit 2/4] add TimezonePanel for containers

2020-07-06 Thread Oguz Bektas
hi, > + > > + if (deletes.length) { > > + values.delete = deletes.join(','); > > + } > > + > > + return values; > > +}, > > + > > + > > +initComponent: function() { > > + var me = this; > > + > > + var items = []; > > how's that not just a static > items: [ > { ... },

[pve-devel] applied: [PATCH v3 common 1/3] JSONSchema: add format validator support and cleanup check_format

2020-07-06 Thread Fabian Grünbichler
On June 25, 2020 1:35 pm, Stefan Reiter wrote: > Adds a third, optional parameter to register_format that allows specifying > a function that will be called after parsing and can validate the parsed > data. A validator should die on failed validation, and can also change the > parsed object by

Re: [pve-devel] [PATCH v3 qemu-server 3/3] fix #2671: include CPU format in man page again

2020-07-06 Thread Fabian Grünbichler
this looks good, waiting for pve-common bump before applying this with a versioned dependency. On June 25, 2020 1:35 pm, Stefan Reiter wrote: > Use the new register_format(3) call to use a validator (instead of a > parser) for 'pve-(vm-)?cpu-conf'. This way the $cpu_fmt hash can be used for >

[pve-devel] applied: [PATCH v3 common 2/3] JSONSchema: use validator in print_property_string too

2020-07-06 Thread Fabian Grünbichler
On June 25, 2020 1:35 pm, Stefan Reiter wrote: > Suggested-by: Fabian Grünbichler > Signed-off-by: Stefan Reiter > --- > src/PVE/JSONSchema.pm | 5 + > 1 file changed, 5 insertions(+) > > diff --git a/src/PVE/JSONSchema.pm b/src/PVE/JSONSchema.pm > index f987006..59a2b5a 100644 > ---

Re: [pve-devel] [PATCH xtermjs] termproxy: rewrite in rust

2020-07-06 Thread Dietmar Maurer
> so we have a 'termproxy' crate+binary and a binary package with name > 'pve-xtermjs' This is quite confusing ... ___ pve-devel mailing list pve-devel@pve.proxmox.com https://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

Re: [pve-devel] [PATCH pve-docs] Close #1623: replace apt-get to apt

2020-07-06 Thread Oguz Bektas
hi, what about the 'dist-upgrade' occurences? should these also be replaced by 'full-upgrade' for completeness sake? On Mon, Jul 06, 2020 at 01:38:29PM +0200, Moayad Almalat wrote: > Signed-off-by: Moayad Almalat > --- > api-viewer/apidata.js| 8 > local-zfs.adoc

[pve-devel] [PATCH v3 access-control] add ui capabilities endpoint

2020-07-06 Thread Tim Marx
Signed-off-by: Tim Marx --- * no changes PVE/API2/AccessControl.pm | 29 + 1 file changed, 29 insertions(+) diff --git a/PVE/API2/AccessControl.pm b/PVE/API2/AccessControl.pm index fd27786..66319cc 100644 --- a/PVE/API2/AccessControl.pm +++

[pve-devel] [PATCH xtermjs] termproxy: rewrite in rust

2020-07-06 Thread Dominik Csapak
termproxy is now completely written in rust (instead of perl) but it is a drop-in replacement this contains all other necessary changes to the build-system for it to successfully build Signed-off-by: Dominik Csapak --- changelog needs to be adapted to have 'rust-termproxy' as src package,

Re: [pve-devel] [RFC v2 0/3] nvme emulation

2020-07-06 Thread Thomas Lamprecht
On 06.07.20 13:38, Oguz Bektas wrote: > hi, > > the email i've sent to qemu-discuss list to ask about this issue while > reattaching a drive with the same id has gone unanswered... > > how do we want to proceed with this feature? maybe actually put also the maintainers of nvme in to/cc, I do

Re: [pve-devel] [RFC v2 0/3] nvme emulation

2020-07-06 Thread Oguz Bektas
hi, the email i've sent to qemu-discuss list to ask about this issue while reattaching a drive with the same id has gone unanswered... how do we want to proceed with this feature? maybe we can fix this issue or workaround it somehow? On Mon, May 18, 2020 at 05:34:01PM +0200, Oguz Bektas

[pve-devel] [PATCH pve-docs] Close #1623: replace apt-get to apt

2020-07-06 Thread Moayad Almalat
Signed-off-by: Moayad Almalat --- api-viewer/apidata.js| 8 local-zfs.adoc | 4 ++-- pve-firewall.adoc| 2 +- pve-installation.adoc| 4 ++-- pve-package-repos.adoc | 2 +- pve-storage-iscsi.adoc | 2 +- qm-cloud-init.adoc |

[pve-devel] [PATCH v3 widget-toolkit] utils: add api token RegExp

2020-07-06 Thread Tim Marx
Signed-off-by: Tim Marx --- src/Utils.js | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/Utils.js b/src/Utils.js index 9a156dd..14da82e 100644 --- a/src/Utils.js +++ b/src/Utils.js @@ -867,5 +867,8 @@ utilities: { me.IP6_dotnotation_match = new RegExp("^" + IPV6_REGEXP +

[pve-devel] [PATCH v3 manager] ui: add api token authentication to login window

2020-07-06 Thread Tim Marx
Signed-off-by: Tim Marx --- changes since v2: * let/var * removed checkbox * autodetect api token on change www/manager6/Workspace.js | 5 ++ www/manager6/window/LoginWindow.js | 106 + 2 files changed, 81 insertions(+), 30 deletions(-) diff --git

Re: [pve-devel] [PATCH pve-docs] Close #1623: replace apt-get to apt

2020-07-06 Thread Moayad Almalat
Hi, Thanks, i'll replaces apt dist-upgrade as well :) > On 07/06/2020 1:39 PM Oguz Bektas wrote: > > > hi, > > what about the 'dist-upgrade' occurences? should these also be replaced > by 'full-upgrade' for completeness sake? > > On Mon, Jul 06, 2020 at 01:38:29PM +0200, Moayad Almalat

[pve-devel] mailing list server maintenance

2020-07-06 Thread Martin Maurer
Hi all, We will move all mailing lists to an new host. Maintenance will take place on 7th of July 2020 (tomorrow). We try to minimize downtime, no emails will be lost. Thanks for your understanding. -- Best Regards, Martin Maurer mar...@proxmox.com https://www.proxmox.com

Re: [pve-devel] [PATCH xtermjs] termproxy: rewrite in rust

2020-07-06 Thread Thomas Lamprecht
On 06.07.20 12:57, Dominik Csapak wrote: > termproxy is now completely written in rust (instead of perl) but > it is a drop-in replacement > > this contains all other necessary changes to the build-system > for it to successfully build > > Signed-off-by: Dominik Csapak > --- > > changelog

Re: [pve-devel] Adding creation time as metadata field to VM/containers?

2020-07-06 Thread Victor Hooi
Hi, I'd still love the ability to query creation time for a VM - did you have any more info on Dominik's metadata field you mentioned? How difficult would this be to add? Thanks, Victor Thanks, Victor On Tue, Jun 16, 2020 at 8:45 PM Victor Hooi wrote: > Hi, > > In our case, we have users