[pve-devel] [PATCH docs] added missing ipv4/ip_forward in routed network section

2017-08-02 Thread Alwin Antreich
Signed-off-by: Alwin Antreich <a.antre...@proxmox.com> --- pve-network.adoc | 1 + 1 file changed, 1 insertion(+) diff --git a/pve-network.adoc b/pve-network.adoc index 315ba63..62cad85 100644 --- a/pve-network.adoc +++ b/pve-network.adoc @@ -137,6 +137,7 @@ iface eno1 inet

[pve-devel] [PATCH manager v2 1/3] pveceph: create mgr with mon, use nodename for id

2017-08-14 Thread Alwin Antreich
From: Dominik Csapak we now want to add a ceph-mgr daemon to every node where a ceph-mon daemon runs, as per ceph documentation recommendation, because in luminous the mgr daemons will not be automatically created/started with a monitor anymore we also give the createmon

[pve-devel] [PATCH manager v2 0/3] pveceph create/destroymgr backport

2017-08-14 Thread Alwin Antreich
Alwin Antreich (1): add check if ceph-mgr is installed Dominik Csapak (2): pveceph: create mgr with mon, use nodename for id pveceph: add createmgr/destroymgr commands PVE/API2/Ceph.pm | 197 + PVE/CLI/pveceph.pm | 2 + PVE

[pve-devel] [PATCH manager v2 2/3] pveceph: add createmgr/destroymgr commands

2017-08-14 Thread Alwin Antreich
From: Dominik Csapak this patch adds the create-/destroymgr commands to the api and pveceph, so that advanced users can split monitor and manager daemons Signed-off-by: Dominik Csapak (cherry picked from commit

[pve-devel] [PATCH manager v2 3/3] add check if ceph-mgr is installed

2017-08-14 Thread Alwin Antreich
in API endpoints createmgr/destroymgr/createmon Signed-off-by: Alwin Antreich <a.antre...@proxmox.com> --- changes in v2: - add check with noerr to createmon as well PVE/API2/Ceph.pm | 6 +- PVE/CephTools.pm | 12 2 files changed, 17 insertions(+), 1 deletion(-) diff

[pve-devel] [PATCH pve-manager 1/3] pveceph: create mgr with mon, use nodename for id

2017-08-14 Thread Alwin Antreich
atemon an optional id parameter, so that one can set a custom id, and make the creation/removal of the manager optional but the default Signed-off-by: Dominik Csapak <d.csa...@proxmox.com> (cherry picked from commit f77a087446390840846cd9300ce3dbe7f4bc7fd6) Signed-off-by: Alwin Antre

[pve-devel] [PATCH pve-manager 3/3] add check if ceph-mgr is installed in create/destroymgr

2017-08-14 Thread Alwin Antreich
adding manager instances is only needed for upgrading PVE 4 to PVE 5 Signed-off-by: Alwin Antreich <a.antre...@proxmox.com> --- PVE/API2/Ceph.pm | 4 PVE/CephTools.pm | 12 2 files changed, 16 insertions(+) diff --git a/PVE/API2/Ceph.pm b/PVE/API2/Ceph.pm index 11

[pve-devel] [PATCH pve-manager 2/3] pveceph: add createmgr/destroymgr commands

2017-08-14 Thread Alwin Antreich
from commit ad9411c9480aa8f9b5fdbf677e0fb4a1e6997cb7) Signed-off-by: Alwin Antreich <a.antre...@proxmox.com> --- PVE/API2/Ceph.pm | 87 ++ PVE/CLI/pveceph.pm | 2 ++ 2 files changed, 89 insertions(+) diff --git a/PVE/API2/Ceph.pm b/PVE/API2/Ceph.pm index c36f31ff..11035e5

[pve-devel] [PATCH stable-4 pve-manager 0/3] pveceph create/destroymgr backport

2017-08-14 Thread Alwin Antreich
Alwin Antreich (1): add check if ceph-mgr is installed in create/destroymgr Dominik Csapak (2): pveceph: create mgr with mon, use nodename for id pveceph: add createmgr/destroymgr commands PVE/API2/Ceph.pm | 197 + PVE/CLI/pveceph.pm

[pve-devel] [PATCH] check for ceph-mgr on destroymon

2017-08-14 Thread Alwin Antreich
Signed-off-by: Alwin Antreich <a.antre...@proxmox.com> --- PVE/API2/Ceph.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/PVE/API2/Ceph.pm b/PVE/API2/Ceph.pm index 71ea687f..6424f02f 100644 --- a/PVE/API2/Ceph.pm +++ b/PVE/API2/Ceph.pm @@ -1087,7 +1087,7 @@ __PAC

[pve-devel] [PATCH cluster] fix #1486 pmxcfs spelling mistake

2017-08-23 Thread Alwin Antreich
Signed-off-by: Alwin Antreich <a.antre...@proxmox.com> --- data/src/pmxcfs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/data/src/pmxcfs.c b/data/src/pmxcfs.c index 8fa3bcc..5547d5d 100644 --- a/data/src/pmxcfs.c +++ b/data/src/pmxcfs.c @@ -909,7 +909,7 @@ int ma

[pve-devel] stable-4 [PATCH cluster] fix #1486 pmxcfs spelling mistake

2017-08-23 Thread Alwin Antreich
Signed-off-by: Alwin Antreich <a.antre...@proxmox.com> --- data/src/pmxcfs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/data/src/pmxcfs.c b/data/src/pmxcfs.c index 8fa3bcc..5547d5d 100644 --- a/data/src/pmxcfs.c +++ b/data/src/pmxcfs.c @@ -909,7 +909,7 @@ int ma

[pve-devel] [PATCH manager] fix default text for SCSI Controller Type

2017-09-15 Thread Alwin Antreich
Signed-off-by: Alwin Antreich <a.antre...@proxmox.com> --- www/manager6/Utils.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/www/manager6/Utils.js b/www/manager6/Utils.js index 0b850977..09e6be90 100644 --- a/www/manager6/Utils.js +++ b/www/manager6/Utils.js @@

[pve-devel] [PATCH access-control 3/3] Change naming to keep command abbreviation

2017-09-22 Thread Alwin Antreich
Signed-off-by: Alwin Antreich <a.antre...@proxmox.com> --- PVE/CLI/pveum.pm | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/PVE/CLI/pveum.pm b/PVE/CLI/pveum.pm index 7a4930f..d960437 100755 --- a/PVE/CLI/pveum.pm +++ b/PVE/CLI/pveum.pm @@ -50,7 +50,7 @@ our $

[pve-devel] [PATCH access-control 1/3] Add parameter userlist to pveum for listing users

2017-09-22 Thread Alwin Antreich
Signed-off-by: Alwin Antreich <a.antre...@proxmox.com> --- PVE/CLI/pveum.pm | 21 + 1 file changed, 21 insertions(+) diff --git a/PVE/CLI/pveum.pm b/PVE/CLI/pveum.pm index aef7089..0426cfb 100755 --- a/PVE/CLI/pveum.pm +++ b/PVE/CLI/pveum.pm @@ -18,6 +18,7 @@ use PVE

[pve-devel] [PATCH access-control 2/3] Add grouplist to pveum for group listing

2017-09-22 Thread Alwin Antreich
Signed-off-by: Alwin Antreich <a.antre...@proxmox.com> --- PVE/CLI/pveum.pm | 12 1 file changed, 12 insertions(+) diff --git a/PVE/CLI/pveum.pm b/PVE/CLI/pveum.pm index 0426cfb..7a4930f 100755 --- a/PVE/CLI/pveum.pm +++ b/PVE/CLI/pveum.pm @@ -74,6 +74,18 @@ our $

[pve-devel] [PATCH docs] add link for convenience on adding nodes to separated cluster network

2017-10-17 Thread Alwin Antreich
Signed-off-by: Alwin Antreich <a.antre...@proxmox.com> --- pvecm.adoc | 4 1 file changed, 4 insertions(+) diff --git a/pvecm.adoc b/pvecm.adoc index 36d18c2..11c6849 100644 --- a/pvecm.adoc +++ b/pvecm.adoc @@ -170,6 +170,7 @@ Membership information 4

Re: [pve-devel] [PATCH access-control] pveum: Allow listing of roles and their privileges

2017-09-25 Thread Alwin Antreich
On Mon, Sep 25, 2017 at 10:19:50AM +0200, Philip Abernethy wrote: > On Mon, Sep 25, 2017 at 10:13:29AM +0200, Thomas Lamprecht wrote: > > On 09/25/2017 07:05 AM, Dietmar Maurer wrote: > > > > > > > + sub { > > > > + my ($res) = @_; > > > > + my $longest = 0; > > > > +

[pve-devel] [PATCH manager] implement checks for ceph version & binaries

2017-08-23 Thread Alwin Antreich
add version check to ceph init to require luminous or higher and fix #1481: check existence of ceph binaries before use Signed-off-by: Alwin Antreich <a.antre...@proxmox.com> --- PVE/API2/Ceph.pm | 17 - PVE/CephTools.pm | 44 +++- 2

[pve-devel] [PATCH manager v2] implement checks for ceph version & binaries

2017-08-24 Thread Alwin Antreich
add version check to ceph init to require luminous or higher and fix #1481: check existence of ceph binaries before use Signed-off-by: Alwin Antreich <a.antre...@proxmox.com> --- PVE/API2/Ceph.pm | 17 - PVE/CephTools.pm | 34 +- 2 files c

[pve-devel] [PATCH guest-common] Fix #1480: die if snapshot name is not found before set_lock is used

2017-08-28 Thread Alwin Antreich
Signed-off-by: Alwin Antreich <a.antre...@proxmox.com> --- PVE/AbstractConfig.pm | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/PVE/AbstractConfig.pm b/PVE/AbstractConfig.pm index 64d19e4..82c495c 100644 --- a/PVE/AbstractConfig.pm +++ b/PVE/AbstractConfig.pm @@

[pve-devel] [PATCH stable-4 guest-common] Fix #1480: die if snapshot name is not found before set_lock is used

2017-08-28 Thread Alwin Antreich
Signed-off-by: Alwin Antreich <a.antre...@proxmox.com> --- PVE/AbstractConfig.pm | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/PVE/AbstractConfig.pm b/PVE/AbstractConfig.pm index 482f0e2..9495798 100644 --- a/PVE/AbstractConfig.pm +++ b/PVE/AbstractConfig.pm @@

Re: [pve-devel] PVE Minimal Debian Appliance

2017-12-18 Thread Alwin Antreich
Hello Thomas, On Mon, Dec 18, 2017 at 12:09:01AM +0100, c.mo...@web.de wrote: > Hello! > > Can you consider to provide a PVE Minimal Debian Appliance considering > things like > "Removing Packages for dealing with hardware. This is not usually done > within a container" und "Removing Packages for

[pve-devel] [PATCH docs] Add section Ceph CRUSH and device classes for pool assignment

2017-11-17 Thread Alwin Antreich
Signed-off-by: Alwin Antreich <a.antre...@proxmox.com> --- pveceph.adoc | 71 1 file changed, 71 insertions(+) diff --git a/pveceph.adoc b/pveceph.adoc index c5eec4f..f152052 100644 --- a/pveceph.adoc +++ b/pveceph.adoc @@

[pve-devel] [PATCH docs v2] Add section Ceph CRUSH and device classes for pool assignment

2017-11-20 Thread Alwin Antreich
Signed-off-by: Alwin Antreich <a.antre...@proxmox.com> --- pveceph.adoc | 79 1 file changed, 79 insertions(+) diff --git a/pveceph.adoc b/pveceph.adoc index c5eec4f..f050b1b 100644 --- a/pveceph.adoc +++ b/pveceph.adoc @@

Re: [pve-devel] [PATCH storage 1/2] Fix: 1542 - show storage utilization per pool, not per global

2017-11-16 Thread Alwin Antreich
On Wed, Nov 15, 2017 at 07:42:57PM +0100, Alexandre DERUMIER wrote: > >>Wouldn't that be totally confusing if you have several pools with different > >>replication factor? > > Personnaly, I don't think it'll be confusing. > Currently you need to do the math manually, and you don't known the >

[pve-devel] [PATCH storage 1/2] Fix: 1542 - show storage utilization per pool, not per global

2017-11-15 Thread Alwin Antreich
Signed-off-by: Alwin Antreich <a.antre...@proxmox.com> --- PVE/Storage/RBDPlugin.pm | 40 +++- 1 file changed, 19 insertions(+), 21 deletions(-) diff --git a/PVE/Storage/RBDPlugin.pm b/PVE/Storage/RBDPlugin.pm index decfbf5..14386c4 100644 --- a/PVE/S

[pve-devel] [PATCH storage 2/2] Addition to #1542, get precent_used from RBDPlugin - add librados2-perl for rados commands - get RBD storage status through librados - calculate %USED if not available

2017-11-15 Thread Alwin Antreich
Signed-off-by: Alwin Antreich <a.antre...@proxmox.com> --- PVE/CLI/pvesm.pm | 1 + PVE/Storage.pm | 6 -- PVE/Storage/RBDPlugin.pm | 14 +- 3 files changed, 18 insertions(+), 3 deletions(-) diff --git a/PVE/CLI/pvesm.pm b/PVE/CLI/pvesm.pm index 9

[pve-devel] [PATCH manager] add %USED calculation for pre luminous clusters

2017-11-03 Thread Alwin Antreich
Signed-off-by: Alwin Antreich <a.antre...@proxmox.com> --- PVE/API2/Ceph.pm | 12 1 file changed, 12 insertions(+) diff --git a/PVE/API2/Ceph.pm b/PVE/API2/Ceph.pm index efea3059..a0260fe2 100644 --- a/PVE/API2/Ceph.pm +++ b/PVE/API2/Ceph.pm @@ -1522,6 +1522,18 @@ __PAC

[pve-devel] [PATCH manager 2/2] Add %-used and min_size to "pveceph lspools" command

2017-10-30 Thread Alwin Antreich
Signed-off-by: Alwin Antreich <a.antre...@proxmox.com> --- PVE/CLI/pveceph.pm | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/PVE/CLI/pveceph.pm b/PVE/CLI/pveceph.pm index 422ac709..a5a04949 100755 --- a/PVE/CLI/pveceph.pm +++ b/PVE/CLI/pveceph.pm @@ -159,9 +

[pve-devel] [PATCH manager 1/2] Fix: #1542, use percent_used key instead of calculation

2017-10-30 Thread Alwin Antreich
Signed-off-by: Alwin Antreich <a.antre...@proxmox.com> --- PVE/API2/Ceph.pm | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/PVE/API2/Ceph.pm b/PVE/API2/Ceph.pm index 54bad234..efea3059 100644 --- a/PVE/API2/Ceph.pm +++ b/PVE/API2/Ceph.pm @@ -1493,7 +1493,6 @@ __PAC

[pve-devel] [PATCH storage] Fix #1750: set monhost split to old behavior

2018-05-04 Thread Alwin Antreich
The path method of the RBDPlugin got a list with comma separated monhosts, but it needs the list with semi-colon for qemu. Signed-off-by: Alwin Antreich <a.antre...@proxmox.com> --- PVE/Storage/RBDPlugin.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/PVE/S

[pve-devel] [PATCH v2 storage] Cephfs storage plugin

2018-05-17 Thread Alwin Antreich
- ability to mount through kernel and fuse client - allow mount options - get MONs from ceph config if not in storage.cfg - allow the use of ceph config with fuse client Signed-off-by: Alwin Antreich <a.antre...@proxmox.com> --- PVE/API2/Storage/Config.pm | 2 +- PVE/API2/S

[pve-devel] [PATCH v2 manager] Cephfs storage wizard

2018-05-17 Thread Alwin Antreich
Add internal and external storage wizard for cephfs Signed-off-by: Alwin Antreich <a.antre...@proxmox.com> --- www/manager6/Makefile | 1 + www/manager6/Utils.js | 10 ++ www/manager6/storage/CephFSEdit.js | 71 ++ 3

[pve-devel] [RFC v2 storage/manager 0/2] Cephfs storage plugin

2018-05-17 Thread Alwin Antreich
linux kernel source from tempfs # -> cephfs real0m23.522s user0m0.744s sys 0m3.292s # -> /root/ (SSD MX100) real0m3.318s user0m0.502s sys 0m2.770s # -> rbd mapped ext4 (SM863a) real0m3.313s user0m0.441s sys 0m2.826s Alwin Antreich (1): Cephfs storage plugin P

[pve-devel] [PATCH v2 storage] Cephfs storage plugin

2018-05-17 Thread Alwin Antreich
- ability to mount through kernel and fuse client - allow mount options - get MONs from ceph config if not in storage.cfg - allow the use of ceph config with fuse client Signed-off-by: Alwin Antreich <a.antre...@proxmox.com> --- PVE/API2/Storage/Config.pm | 2 +- PVE/Stor

[pve-devel] [PATCH storage v4 3/4] Add simple keyring check for cephfs/rbd

2018-06-18 Thread Alwin Antreich
Signed-off-by: Alwin Antreich --- PVE/Storage/CephTools.pm | 33 + 1 file changed, 33 insertions(+) diff --git a/PVE/Storage/CephTools.pm b/PVE/Storage/CephTools.pm index 7aa6069..c020483 100644 --- a/PVE/Storage/CephTools.pm +++ b/PVE/Storage/CephTools.pm

[pve-devel] [PATCH manager v4 1/2] Cephfs storage wizard

2018-06-18 Thread Alwin Antreich
Add internal and external storage wizard for cephfs Signed-off-by: Alwin Antreich --- www/manager6/Makefile | 1 + www/manager6/Utils.js | 10 ++ www/manager6/storage/CephFSEdit.js | 71 ++ 3 files changed, 82 insertions

[pve-devel] [PATCH v4 storage/manager] Cephfs storage plugin

2018-06-18 Thread Alwin Antreich
: cephfs: cephfs0 monhost 192.168.1.2:6789 path /mnt/pve/cephfs0 content iso,backup,images,vztmpl,rootdir subdir /blubb fuse 0 username admin Comments and tests are very welcome. ;) Changes in V4: Code cleanup, as suggest by review. Alwin Antreich (7

[pve-devel] [PATCH storage v4 4/4] Cephfs storage plugin

2018-06-18 Thread Alwin Antreich
- ability to mount through kernel and fuse client - allow mount options - get MONs from ceph config if not in storage.cfg - allow the use of ceph config with fuse client Signed-off-by: Alwin Antreich --- PVE/API2/Storage/Config.pm | 2 +- PVE/Storage.pm | 2 + PVE/Storage

[pve-devel] [PATCH librados2-perl] Make error messages in Rados.pm prettier

2018-06-18 Thread Alwin Antreich
Signed-off-by: Alwin Antreich --- PVE/RADOS.pm | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/PVE/RADOS.pm b/PVE/RADOS.pm index d53f655..d9e2e3b 100644 --- a/PVE/RADOS.pm +++ b/PVE/RADOS.pm @@ -99,7 +99,7 @@ my $sendcmd = sub { $expect_tag = '>' if !$expect_

[pve-devel] [PATCH manager v4 2/2] Add cephfs to allowed storages for vzdump backup

2018-06-18 Thread Alwin Antreich
Signed-off-by: Alwin Antreich --- PVE/VZDump.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/PVE/VZDump.pm b/PVE/VZDump.pm index a0376ef9..7fc69f98 100644 --- a/PVE/VZDump.pm +++ b/PVE/VZDump.pm @@ -223,7 +223,7 @@ sub storage_info { die "can't use storage

[pve-devel] [PATCH storage v4 1/4] Merge RBD and CephFS code into a helper module

2018-06-18 Thread Alwin Antreich
Some methods for connecting to a ceph cluster are the same for RBD and CephFS, these are merged into the helper modules. Signed-off-by: Alwin Antreich --- PVE/Storage/CephTools.pm | 55 PVE/Storage/Makefile | 2 +- 2 files changed, 56

[pve-devel] [PATCH storage v4 2/4] Call methods from Storage::CephTools package

2018-06-18 Thread Alwin Antreich
Replace methods with those merged into Storage::CephTools.pm Signed-off-by: Alwin Antreich --- PVE/Storage/RBDPlugin.pm | 55 +--- 1 file changed, 5 insertions(+), 50 deletions(-) diff --git a/PVE/Storage/RBDPlugin.pm b/PVE/Storage/RBDPlugin.pm index

[pve-devel] [PATCH storage v3 1/5] Add missing dependency to ceph-common

2018-06-11 Thread Alwin Antreich
Signed-off-by: Alwin Antreich --- debian/control | 1 + 1 file changed, 1 insertion(+) diff --git a/debian/control b/debian/control index 2cf585a..908dd24 100644 --- a/debian/control +++ b/debian/control @@ -27,6 +27,7 @@ Depends: cstream, thin-provisioning-tools, udev

[pve-devel] [PATCH manager v3 2/2] Add cephfs to allowed storages for vzdump backup

2018-06-11 Thread Alwin Antreich
Signed-off-by: Alwin Antreich --- PVE/VZDump.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/PVE/VZDump.pm b/PVE/VZDump.pm index a0376ef9..7fc69f98 100644 --- a/PVE/VZDump.pm +++ b/PVE/VZDump.pm @@ -223,7 +223,7 @@ sub storage_info { die "can't use storage

[pve-devel] [PATCH manager v3 1/2] Cephfs storage wizard

2018-06-11 Thread Alwin Antreich
Add internal and external storage wizard for cephfs Signed-off-by: Alwin Antreich --- www/manager6/Makefile | 1 + www/manager6/Utils.js | 10 ++ www/manager6/storage/CephFSEdit.js | 71 ++ 3 files changed, 82 insertions

[pve-devel] [PATCH storage v3 4/5] Call methods from CephStorageTools package

2018-06-11 Thread Alwin Antreich
Replace methods with those merged into CephStorageTools.pm Signed-off-by: Alwin Antreich --- PVE/Storage/RBDPlugin.pm | 55 +--- 1 file changed, 5 insertions(+), 50 deletions(-) diff --git a/PVE/Storage/RBDPlugin.pm b/PVE/Storage/RBDPlugin.pm index

[pve-devel] [PATCH storage v3 5/5] Add simple keyring check for cephfs/rbd

2018-06-11 Thread Alwin Antreich
Signed-off-by: Alwin Antreich --- PVE/CephStorageTools.pm | 33 + 1 file changed, 33 insertions(+) diff --git a/PVE/CephStorageTools.pm b/PVE/CephStorageTools.pm index 4bbfc55..59c7be9 100644 --- a/PVE/CephStorageTools.pm +++ b/PVE/CephStorageTools.pm @@ -5,6

[pve-devel] [PATCH storage v3 3/5] Merge RBD and CephFS code into a helper module

2018-06-11 Thread Alwin Antreich
Some methods for connecting to a ceph cluster are the same for RBD and CephFS, these are merged into the helper modules. Signed-off-by: Alwin Antreich --- PVE/CephStorageTools.pm | 55 + PVE/Makefile| 1 + 2 files changed, 56

[pve-devel] [PATCH storage v3 2/5] Cephfs storage plugin

2018-06-11 Thread Alwin Antreich
- ability to mount through kernel and fuse client - allow mount options - get MONs from ceph config if not in storage.cfg - allow the use of ceph config with fuse client Signed-off-by: Alwin Antreich --- PVE/API2/Storage/Config.pm | 2 +- PVE/Storage.pm | 2 + PVE/Storage

[pve-devel] [PATCH v3 storage/manager] Cephfs storage plugin

2018-06-11 Thread Alwin Antreich
& rbd code into CephStorageTools.pm. Thus adding a very basic content check on the keyring/secret file. Alwin Antreich (7): Add missing dependency to ceph common debian/control | 1 + 1 file changed, 1 insertion(+) Cephfs storage wizard www/manager6/Makefile | 1 + www/mana

Re: [pve-devel] [PATCH qemu-server] Fix #1242 : clone_disk : call qga fstrim after clone

2018-05-28 Thread Alwin Antreich
On Mon, May 28, 2018 at 05:36:50PM +0200, Alexandre Derumier wrote: > Some storage like rbd or lvm can't keep thin-provising after a qemu-mirror. > > Call qga guest-fstrim if qga is available > --- > PVE/API2/Qemu.pm | 8 > PVE/QemuMigrate.pm | 5 + > 2 files changed, 13

Re: [pve-devel] [PATCH qemu-server] Fix #1242 : clone_disk : call qga fstrim after clone

2018-05-29 Thread Alwin Antreich
On Mon, May 28, 2018 at 08:49:29PM +0200, Alexandre DERUMIER wrote: > >>If I understood it right, then the fstrim is called on every migrate with a > >>running guest agent. While, I guess the command is called also if you don't > >>have discard in the vm config activated and might only produce a

Re: [pve-devel] [PATCH qemu-server] Fix #1242 : clone_disk : call qga fstrim after clone

2018-05-29 Thread Alwin Antreich
On Tue, May 29, 2018 at 10:02:45AM +0200, Alexandre DERUMIER wrote: > >>I would think, the best is to have it in the vmid.conf itself, as maybe > >>there > >>is one VM where I want to have flat images (eg. DB server) and not for the > >>rest. > > But I think that if user want flat image,

[pve-devel] [PATCH docs] Update pveceph

2018-06-26 Thread Alwin Antreich
* Combine sections from the wiki * add section for avoiding RAID controllers * correct command line for bluestore DB device creation * minor rewording Signed-off-by: Alwin Antreich --- pveceph.adoc | 92 +++- 1 file changed, 60 insertions

[pve-devel] [PATCH storage v5 3/3] Cephfs storage plugin

2018-06-25 Thread Alwin Antreich
- ability to mount through kernel and fuse client - allow mount options - get MONs from ceph config if not in storage.cfg - allow the use of ceph config with fuse client Signed-off-by: Alwin Antreich --- PVE/API2/Storage/Config.pm | 28 ++- PVE/Storage.pm | 2 + PVE

[pve-devel] [PATCH storage v5 1/3] Merge RBD and CephFS code into a helper module

2018-06-25 Thread Alwin Antreich
Some methods for connecting to a ceph cluster are the same for RBD and CephFS, these are merged into the helper modules. Signed-off-by: Alwin Antreich --- PVE/Storage/CephTools.pm | 55 PVE/Storage/Makefile | 2 +- PVE/Storage/RBDPlugin.pm

[pve-devel] [PATCH manager v5 1/2] Cephfs storage wizard

2018-06-25 Thread Alwin Antreich
Add internal and external storage wizard for cephfs Signed-off-by: Alwin Antreich --- www/manager6/Makefile | 1 + www/manager6/Utils.js | 10 ++ www/manager6/storage/CephFSEdit.js | 71 ++ 3 files changed, 82 insertions

[pve-devel] [PATCH manager v5 2/2] Add cephfs to allowed storages for vzdump backup

2018-06-25 Thread Alwin Antreich
Signed-off-by: Alwin Antreich --- PVE/VZDump.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/PVE/VZDump.pm b/PVE/VZDump.pm index a0376ef9..7fc69f98 100644 --- a/PVE/VZDump.pm +++ b/PVE/VZDump.pm @@ -223,7 +223,7 @@ sub storage_info { die "can't use storage

[pve-devel] [PATCH v5 storage/manager] Cephfs storage plugin

2018-06-25 Thread Alwin Antreich
creation and removal of keyfile for RBD/CephFS storage * Cleanup of get_monlist method * Use of PVE::Tools::file_get_contents & file_set_contents instead of IO::File Alwin Antreich (5): Cephfs storage wizard www/manager6/Makefile | 1 + www/manager6/Utils.js

[pve-devel] [PATCH storage v5 2/3] Add simple keyring check for cephfs/rbd

2018-06-25 Thread Alwin Antreich
Signed-off-by: Alwin Antreich --- PVE/Storage/CephTools.pm | 33 + 1 file changed, 33 insertions(+) diff --git a/PVE/Storage/CephTools.pm b/PVE/Storage/CephTools.pm index 7aa6069..3e2cede 100644 --- a/PVE/Storage/CephTools.pm +++ b/PVE/Storage/CephTools.pm

[pve-devel] [PATCH docs] Add storage plugin CephFS to docs

2018-06-25 Thread Alwin Antreich
Signed-off-by: Alwin Antreich --- pve-storage-cephfs.adoc | 106 pvesm.adoc | 3 ++ 2 files changed, 109 insertions(+) create mode 100644 pve-storage-cephfs.adoc diff --git a/pve-storage-cephfs.adoc b/pve-storage-cephfs.adoc new

Re: [pve-devel] [PATCH v4 storage/manager] Cephfs storage plugin

2018-06-25 Thread Alwin Antreich
On Wed, Jun 20, 2018 at 03:02:43PM +0200, Thomas Lamprecht wrote: > On 6/18/18 7:49 PM, Alwin Antreich wrote: > > This patch series is an update and adds the Cephfs to our list of storages. > > You can mount the storage through the kernel or fuse client. The plugin for > > n

[pve-devel] [PATCH docs 1/2] reflect new PVE features for ceph pool configuration

2017-10-23 Thread Alwin Antreich
Signed-off-by: Alwin Antreich <a.antre...@proxmox.com> --- pve-storage-rbd.adoc | 20 1 file changed, 12 insertions(+), 8 deletions(-) diff --git a/pve-storage-rbd.adoc b/pve-storage-rbd.adoc index 5d0b7b7..ee07371 100644 --- a/pve-storage-rbd.adoc +++ b/pve-storage-rb

[pve-devel] [PATCH docs 2/2] Update docs to the reflect the new Ceph luminous

2017-10-23 Thread Alwin Antreich
Further: * explain the different services for RBD use * be clear about Ceph OSD types * more detail about pools and its PGs * move links into footnotes Signed-off-by: Alwin Antreich <a.antre...@proxmox.com> --- pveceph.adoc | 173

Re: [pve-devel] Patch about Intel processors flaw

2018-01-05 Thread Alwin Antreich
Hello Gilberto, On Thu, Jan 04, 2018 at 03:36:36PM -0200, Gilberto Nunes wrote: > Hi list > > Is there any patch to PVE Kernel about Intel processors flaw?? Please, follow up on the thread on our forum. https://forum.proxmox.com/threads/fuckwit-kaiser-kpti.39025/ > > > --- > Gilberto Ferreira >

Re: [pve-devel] [PATCH manager v4] ui: storage: combine RBD external and hyperconverged add dialog

2018-07-31 Thread Alwin Antreich
*/ > me.column2 = [ > { > xtype: 'pveContentTypeSelector', > @@ -68,14 +168,22 @@ Ext.define('PVE.storage.RBDInputPanel', { > fieldLabel: 'KRBD' > } > ]; > - /*jslint confusion: false*/ > + > + me.columnB = [{ > + xtype: 'proxmoxcheckbox', > + name: 'pveceph', > + reference: 'pvecephRef', > + bind : { > + disabled: '{!pvecephPossible}', > + value: '{pveceph}' > + }, > + checked: true, > + uncheckedValue: 0, > + submitValue: false, > + hidden: !me.isCreate, > + boxLabel: gettext('Use Proxmox VE managed hyper-converged ceph > pool') > + }]; > > me.callParent(); > } > }); > - > -Ext.define('PVE.storage.PVERBDInputPanel', { > -extend: 'PVE.storage.RBDInputPanel', > - > -pveceph: 1 > -}); > -- > 2.18.0 > Tested-by: Alwin Antreich Worked for me on a hyper-converged and on a standalone PVE install. ___ pve-devel mailing list pve-devel@pve.proxmox.com https://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

[pve-devel] [RFC container 0/1] Removes need for two RBD storage entries

2018-07-25 Thread Alwin Antreich
-devel/2018-July/032895.html In this variant I add an extra parameter to the storage entry to not accidentally override the krbd setting in the storage.cfg. But it could be well changed to use krbd parameter. Ideas and suggestions are welcome. :) Alwin Antreich (2): LXC need krbd regardless

[pve-devel] [PATCH storage] Add check to overrule krbd setting on RBD storage

2018-07-25 Thread Alwin Antreich
The scfg variable holds an extra parameter to verify that it's lxc that needs krbd regardless its storage config entry. Without this there would be the need for an extra storage entry to use the same RBD pool with LXC (krbd 0/1). Signed-off-by: Alwin Antreich --- PVE/Storage/RBDPlugin.pm | 12

[pve-devel] [PATCH container] LXC needs krbd regardless of storage entry

2018-07-25 Thread Alwin Antreich
This patch adds the lxc_krbd flag to the storage config, so the RBD storage plugin is aware of the need for krbd from lxc. Removed the check for krbd. Signed-off-by: Alwin Antreich --- src/PVE/API2/LXC.pm | 10 +- src/PVE/LXC.pm | 20 ++-- 2 files changed, 19

[pve-devel] [PATCH container/storage 0/1] Remove the need for 2xRBD storage entries

2018-08-17 Thread Alwin Antreich
. Suggestions and comments are welcome. Note: What didn't and still isn't working, is the move of a base image from one storage to another, when they underlying RBD pool is the same. Alwin Antreich (3): Add flag $map so container images can be mapped PVE/CLI/pvesm.pm | 6 ++--- PVE

[pve-devel] [PATCH container] Add paramter map in used storage methods

2018-08-17 Thread Alwin Antreich
This patch updates the paramter list of methods called from pve-storage to support the use of the flag map. The pve-container code now calls for an explicit device mapping. Checks for krbd support are removed. Signed-off-by: Alwin Antreich --- src/PVE/API2/LXC.pm| 30

[pve-devel] [PATCH storage 2/2] Implement the flag $map in the RBDPlugin

2018-08-17 Thread Alwin Antreich
Signed-off-by: Alwin Antreich --- PVE/Storage/RBDPlugin.pm | 38 +++--- 1 file changed, 19 insertions(+), 19 deletions(-) diff --git a/PVE/Storage/RBDPlugin.pm b/PVE/Storage/RBDPlugin.pm index be88ad7..64dc1f1 100644 --- a/PVE/Storage/RBDPlugin.pm +++ b/PVE

[pve-devel] [PATCH storage 1/2] Add flag $map so container images can be mapped

2018-08-17 Thread Alwin Antreich
This allows methods to request a mapped device/path explicitly, regardles of the storage option, eg. krbd option in the RBDplugin. Signed-off-by: Alwin Antreich --- PVE/CLI/pvesm.pm | 6 ++--- PVE/Storage.pm| 63 +-- PVE/Storage

[pve-devel] [PATCH storage] Addition to fix #1895, use feature array directly

2018-09-05 Thread Alwin Antreich
The rbd_volume_info can return the feature array directly, no need for keeping the conversion into a string. Signed-off-by: Alwin Antreich --- Cloning on a krbd enabled storage broke with the fix #1895, this patch made it work on my cluster. PVE/Storage/RBDPlugin.pm | 7 +++ 1 file changed

Re: [pve-devel] [PATCH storage v2 1/2] fix #1895: use json for 'rbd ls -l' and 'rbd info'

2018-09-06 Thread Alwin Antreich
On Thu, Sep 06, 2018 at 11:35:42AM +0200, Dominik Csapak wrote: > since ceph changed the plain output format for 12.2.8 > we have to change the code anyway, and when were at it, > we can change it to the (hopefully) more robust json output > > Co-authored-by: Alwin Antreic

[pve-devel] [PATCH storage] Addition to fix #1895, skip image if no owner

2018-09-07 Thread Alwin Antreich
Non conforming image names are not ignored anymore by the new rbd_ls implementation, this patch adds the old behaviour. This fix is a temporary workaround and should be removed, once the new image name parser is ready. Signed-off-by: Alwin Antreich --- PVE/Storage/RBDPlugin.pm | 1 + 1 file

Re: [pve-devel] [PATCH manager v3] ui: storage: combine RBD external and hyperconverged add dialog

2018-07-05 Thread Alwin Antreich
On Thu, Jul 05, 2018 at 12:23:13PM +0200, Thomas Lamprecht wrote: > On 7/5/18 11:29 AM, Alwin Antreich wrote: > > Patch tested and works. Two small nits below. > > > > much thanks! > > > On Tue, Jul 03, 2018 at 03:55:10PM +0200, Thomas Lamprecht wrote: > >>

Re: [pve-devel] [PATCH manager v3] ui: storage: combine RBD external and hyperconverged add dialog

2018-07-05 Thread Alwin Antreich
Patch tested and works. Two small nits below. On Tue, Jul 03, 2018 at 03:55:10PM +0200, Thomas Lamprecht wrote: > Combine both dialogues. This not only helps to reuse code but also > reduces storage choices from the Storage -> Add menu, and thus > improves usability. > > Signed-off-by: Thomas

[pve-devel] [PATCH manager v6 2/2] Add cephfs to allowed storages for vzdump backup

2018-07-04 Thread Alwin Antreich
Signed-off-by: Alwin Antreich --- PVE/VZDump.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/PVE/VZDump.pm b/PVE/VZDump.pm index a0376ef9..7fc69f98 100644 --- a/PVE/VZDump.pm +++ b/PVE/VZDump.pm @@ -223,7 +223,7 @@ sub storage_info { die "can't use storage

[pve-devel] [PATCH v6 storage/manager] Cephfs storage plugin

2018-07-04 Thread Alwin Antreich
name field from CephFS (PVE) wizard Alwin Antreich (6): Cephfs storage wizard www/manager6/Makefile | 1 + www/manager6/Utils.js | 10 +++ www/manager6/storage/CephFSEdit.js | 59 ++ 3 files changed, 70 insertions(+) create mode 10

[pve-devel] [PATCH storage v6 3/4] Cephfs storage plugin

2018-07-04 Thread Alwin Antreich
- ability to mount through kernel and fuse client - allow mount options - get MONs from ceph config if not in storage.cfg - allow the use of ceph config with fuse client - Delete secret on cephfs storage creation Signed-off-by: Alwin Antreich --- PVE/API2/Storage/Config.pm | 8 +- PVE

[pve-devel] [PATCH storage v6 2/4] Add simple keyring check for cephfs/rbd

2018-07-04 Thread Alwin Antreich
Signed-off-by: Alwin Antreich --- PVE/Storage/CephTools.pm | 33 + 1 file changed, 33 insertions(+) diff --git a/PVE/Storage/CephTools.pm b/PVE/Storage/CephTools.pm index 7aa6069..3e2cede 100644 --- a/PVE/Storage/CephTools.pm +++ b/PVE/Storage/CephTools.pm

[pve-devel] [PATCH storage v6 4/4] Use keyfile create/remove from CephTools

2018-07-04 Thread Alwin Antreich
in the RBDPlugin, that is also shared by the CephFSPlugin Signed-off-by: Alwin Antreich --- PVE/Storage/RBDPlugin.pm | 22 ++ 1 file changed, 2 insertions(+), 20 deletions(-) diff --git a/PVE/Storage/RBDPlugin.pm b/PVE/Storage/RBDPlugin.pm index 59f7941..be88ad7 100644

[pve-devel] [PATCH manager v6 1/2] Cephfs storage wizard

2018-07-04 Thread Alwin Antreich
Add internal and external storage wizard for cephfs Signed-off-by: Alwin Antreich --- www/manager6/Makefile | 1 + www/manager6/Utils.js | 10 +++ www/manager6/storage/CephFSEdit.js | 59 ++ 3 files changed, 70 insertions

[pve-devel] [PATCH storage v6 1/4] Merge RBD and CephFS code into a helper module

2018-07-04 Thread Alwin Antreich
Some methods for connecting to a ceph cluster are the same for RBD and CephFS, these are merged into the helper modules. Signed-off-by: Alwin Antreich --- PVE/Storage/CephTools.pm | 55 PVE/Storage/Makefile | 2 +- PVE/Storage/RBDPlugin.pm

Re: [pve-devel] [PATCH qemu-server] Fix #1650: add content type filter to rescan

2018-07-04 Thread Alwin Antreich
On Wed, Jul 04, 2018 at 09:51:50AM +0200, Dietmar Maurer wrote: > > > Seems not really wrong, IMO, and we use this for pve ceph, where the > > > same backing storage can get added twice, with and without KRBD to our > > > storage.cfg by our pool creator UI - one for CT which need KRBD and one > >

Re: [pve-devel] [PATCH manager] ui/lxc/CreateWizard: submit pool, if present

2018-07-09 Thread Alwin Antreich
CreateWizard', { > xtype: 'pvePoolSelector', > fieldLabel: gettext('Resource Pool'), > name: 'pool', > - submitValue: false, > value: '', > allowBlank: true > }, >

[pve-devel] [PATCH qemu-server] Fix #1650: add content type filter to rescan

2018-07-03 Thread Alwin Antreich
Unused disk(s) appeared after a rescan of storages. Especially shown with ceph pools, where two storage entries are made, _ct and _vm. The rescan method did include images from both storages. This patch filters any storage not containing the content type 'images'. Signed-off-by: Alwin Antreich

[pve-devel] [PATCH storage v2] Fix #1574: could not disable krbd-incompatible image features

2018-03-01 Thread Alwin Antreich
Signed-off-by: Alwin Antreich <a.antre...@proxmox.com> --- PVE/Storage/RBDPlugin.pm | 17 ++--- 1 file changed, 14 insertions(+), 3 deletions(-) diff --git a/PVE/Storage/RBDPlugin.pm b/PVE/Storage/RBDPlugin.pm index 2ca14ef..06e0a0a 100644 --- a/PVE/Storage/RBDPlugin.pm +++

Re: [pve-devel] NACK: [PATCH storage 2/3] krbd: remove 'exclusive-lock' from blacklist, kernel-4.13

2018-03-01 Thread Alwin Antreich
On Thu, Mar 01, 2018 at 10:59:15AM +0100, Fabian Gr├╝nbichler wrote: > this is problematic because it potentially hides bugs in our application > logic, with currently no benefit. > > with exclusive-locks disabled, mapping on multiple hosts is possible, > but mounting the same image is not (e.g.,

[pve-devel] [PATCH container] Fix pct skiplock

2018-03-13 Thread Alwin Antreich
The method vm_start sets an environment variable that is not picked up anymore by systemd. This patch keeps the environment variable and introduces a skiplock file that is picked up by the lxc-pve-prestart-hook. Signed-off-by: Alwin Antreich <a.antre...@proxmox.com> --- src/PVE/

[pve-devel] [PATCH container v4] Fix pct skiplock

2018-03-14 Thread Alwin Antreich
The method vm_start sets an environment variable that is not picked up anymore by systemd. This patch removes the environment variable and introduces a skiplock file that is picked up by the lxc-pve-prestart-hook. Signed-off-by: Alwin Antreich <a.antre...@proxmox.com> --- note: this v

[pve-devel] [PATCH container v3] Fix pct skiplock

2018-03-14 Thread Alwin Antreich
The method vm_start sets an environment variable that is not picked up anymore by systemd. This patch removes the environment variable and introduces a skiplock file that is picked up by the lxc-pve-prestart-hook. Signed-off-by: Alwin Antreich <a.antre...@proxmox.com> --- note: after disc

[pve-devel] [PATCH container v2] Fix pct skiplock

2018-03-14 Thread Alwin Antreich
The method vm_start sets an environment variable that is not picked up anymore by systemd. This patch removes the environment variable and introduces a skiplock file that is picked up by the lxc-pve-prestart-hook. Signed-off-by: Alwin Antreich <a.antre...@proxmox.com> --- note: after disc

[pve-devel] [PATCH container 1/2] Fix #1547: on migration abort, the CT starts again

2018-03-09 Thread Alwin Antreich
When a migration fails, the final_cleanup phase now starts the container on the source node again, if it was a migration in restart_mode and the CT was running. Signed-off-by: Alwin Antreich <a.antre...@proxmox.com> --- src/PVE/API2/LXC/Status.pm | 8 +--- src/PVE/LXC.pm

[pve-devel] [PATCH container 2/2] Remove obsolete read from storage.cfg in vm_start api call

2018-03-09 Thread Alwin Antreich
Signed-off-by: Alwin Antreich <a.antre...@proxmox.com> --- src/PVE/API2/LXC/Status.pm | 2 -- 1 file changed, 2 deletions(-) diff --git a/src/PVE/API2/LXC/Status.pm b/src/PVE/API2/LXC/Status.pm index 976f264..b98dc24 100644 --- a/src/PVE/API2/LXC/Status.pm +++ b/src/PVE/API2/LXC/Sta

[pve-devel] [PATCH container v5] Fix pct skiplock

2018-03-14 Thread Alwin Antreich
The method vm_start sets an environment variable that is not picked up anymore by systemd. This patch removes the environment variable and introduces a skiplock file that is picked up by the lxc-pve-prestart-hook. Signed-off-by: Alwin Antreich <a.antre...@proxmox.com> --- note: made c

[pve-devel] [PATCH v2 storage 2/2] Refactor of method build_cmd and path

2018-04-09 Thread Alwin Antreich
Method build_cmd and path use similar code to generate the ceph command line or qemu config parameters. They now use the private method ceph_connect_option for parameter generation. Signed-off-by: Alwin Antreich <a.antre...@proxmox.com> --- PVE/Storage/RBDPlugin.pm

  1   2   >