[pve-devel] [PATCH v2 #1752 pve-manager 2/3] patch #1752 Impl basic wake on LAN

Signed-off-by: Christian Ebner --- PVE/API2/Nodes.pm | 26 +++--- PVE/NodeConfig.pm | 2 +- 2 files changed, 16 insertions(+), 12 deletions(-) diff --git a/PVE/API2/Nodes.pm b/PVE/API2/Nodes.pm index f59133dc..f831bc41 100644 --- a/PVE/API2/Nodes.pm +++ b/PVE/API2/Nodes.pm

[pve-devel] [PATCH v2 #1752 pve-manager 1/3] [PATCH #1752 pve-manager] Impl basic wake on LAN

Provides the basic functionality to provide a wake on LAN feature implementation to start nodes in a cluster from other nodes. Signed-off-by: Christian Ebner --- PVE/API2/Nodes.pm | 41 + PVE/NodeConfig.pm | 6 ++ 2 files changed, 47 insertions

[pve-devel] [PATCH v2 #1752 pve-manager 0/3] Impl basic wake on LAN

Fix #1752 Version 2 of patches: * Changed properity name form 'mac' to 'wakeonlan' * Changed permissions from '/nodes/{node}' to '/nodes/' * Include 'use Socket;' * Refactoring of code according to suggestions on mailing list Christian Ebner (3): Impl basic wake on LAN patch #1752 Impl basic

[pve-devel] [PATCH v2 #1752 pve-manager 3/3] Impl basic wake on LAN functionality

Implements the basic requirements for waking a sleeping node in a cluster via wake on LAN. Signed-off-by: Christian Ebner --- PVE/API2/Nodes.pm | 21 +++-- PVE/NodeConfig.pm | 2 +- 2 files changed, 12 insertions(+), 11 deletions(-) diff --git a/PVE/API2/Nodes.pm b/PVE/API2

Re: [pve-devel] [PATCH #1941 qemu-server] Clean up empty image subdirectories on dir based storage on VM destruction

s, it only wants to free an image? > Or did you have specific reasons to put it here? > > Else, maybe you could integrate something like this in the Dir plugin, which > in this case means the base Plugin class DirPlug bases on, as it inherits the > free_image method. > > >

[pve-devel] [PATCH v4 #1752 pve-manager] implement basic wake on LAN functionality

Provides the basic functionality to provide a wake on LAN feature implementation to start nodes in a cluster from other nodes. Signed-off-by: Christian Ebner --- Changes to v4: * Changed description to the suggested one * Directly use IPPROTO_UDP instead of calling getprotobyname('udp

[pve-devel] [PATCH #1941 qemu-server] Clean up empty image subdirectories on dir based storage on VM destruction

Fix #1941 Removes the empty vmid subdirectories when a VM gets destroyed and all the contained image files are deleted. Signed-off-by: Christian Ebner --- PVE/QemuServer.pm | 8 1 file changed, 8 insertions(+) diff --git a/PVE/QemuServer.pm b/PVE/QemuServer.pm index 1ccdccf..da4be85

[pve-devel] [PATCH pve-docs] pvenode: add WOL section to doc

Adds a section containing information about the wake on LAN feature to the pvenode documentation. Signed-off-by: Christian Ebner --- pvenode.adoc | 11 +++ 1 file changed, 11 insertions(+) diff --git a/pvenode.adoc b/pvenode.adoc index a41085f..df17f93 100644 --- a/pvenode.adoc +++ b

[pve-devel] [PATCH pve-manager 2/2] pvenode: Print MAC address used for WOL packet on success

Show the MAC address used in the wake on LAN packet if it was send successfully via 'pvenode wakeonlan '. Signed-off-by: Christian Ebner --- PVE/CLI/pvenode.pm | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/PVE/CLI/pvenode.pm b/PVE/CLI/pvenode.pm index b698d2a5

[pve-devel] [PATCH pve-manager 0/2] Return MAC address on successful WOL packet

Two patches to give some user feedback in form of the MAC address used in the WOL packet. The first makes a change so that the used MAC address is returned by the API call, the second prints the MAC to the user if 'pvenode wakonlan ' returned with success. Christian Ebner (2): Nodes: wakeonlan

[pve-devel] [PATCH pve-manager 1/2] Nodes: wakeonlan return MAC address send via WOL packet

The wake on LAN call now returns a string containing the MAC address send in the WOL packet. Signed-off-by: Christian Ebner --- PVE/API2/Nodes.pm | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/PVE/API2/Nodes.pm b/PVE/API2/Nodes.pm index 7f829b29..2c8bfc35 100644

[pve-devel] [PATCH common] Add mac-addr standard option for MAC address verification

Signed-off-by: Christian Ebner --- src/PVE/JSONSchema.pm | 16 1 file changed, 16 insertions(+) diff --git a/src/PVE/JSONSchema.pm b/src/PVE/JSONSchema.pm index fb58ad3..0408c5d 100644 --- a/src/PVE/JSONSchema.pm +++ b/src/PVE/JSONSchema.pm @@ -113,6 +113,11

[pve-devel] [PATCH v2 pve-docs] pvenode: add WOL section to doc

Adds a section containing information about the wake on LAN feature to the pvenode documentation. Signed-off-by: Christian Ebner --- Version 2: * Added suggested introduction * Rephrased existing text * commands are now inside a listing, not inlined pvenode.adoc | 29

[pve-devel] [PATCH v2 pve-common] JSONSchema: Add format for MAC address verification

Adds a format to verify MAC addresses to JSONSchema. Signed-off-by: Christian Ebner --- Version 2: * Droped standard option as discussed on mailing list * Changed regex to be more strict src/PVE/JSONSchema.pm | 11 +++ 1 file changed, 11 insertions(+) diff --git a/src/PVE

[pve-devel] [PATCH v2 pve-manager] pvenode: Return MAC address used for WoL call on success

Use the new format to verify the MAC addresses. The wakeonlan API call now returns the MAC address of the node to wake on successful sending of the WoL packet. pvenode finally displays this MAC address to the user as feedback. Signed-off-by: Christian Ebner --- Version 2: * Changed the MAC

[pve-devel] [PATCH #1941 storage] Plugin: Remove empty directories on VM destroy

Remove directories if they are empty after destroying a VM. Signed-off-by: Christian Ebner --- PVE/Storage/Plugin.pm | 5 + 1 file changed, 5 insertions(+) diff --git a/PVE/Storage/Plugin.pm b/PVE/Storage/Plugin.pm index e0c2a4e..00131df 100644 --- a/PVE/Storage/Plugin.pm +++ b/PVE/Storage

[pve-devel] [PATCH v3 #1752 pve-manager] implement basic wake on LAN functionality

Provides the basic functionality to allow a wake on LAN call to start sleeping nodes in a cluster from an other cluster member. Signed-off-by: Christian Ebner --- Changes to v3: * 'wol' -> 'wakeonlan' * 'or' -> '||' * Changed the permission back to /nodes/{node} as discussed o

[pve-devel] [PATCH pve-manager] pvenode: Add CLI call interface for wake on LAN

Adds a CLI call interface to pvenode which allows to wake sleeping nodes in a cluster via a wake on LAN packet. pvenode wakeonlan Signed-off-by: Christian Ebner --- PVE/CLI/pvenode.pm | 3 +++ 1 file changed, 3 insertions(+) diff --git a/PVE/CLI/pvenode.pm b/PVE/CLI/pvenode.pm index 5cd855be

[pve-devel] [PATCH pve-manager 0/1] Fix #1982 Check handler exists

Fix #1982 Checks that the handler for the provided API call even exists before starting with verification of the parameter schema, therefore returning a more descriptive error message if the handler does not exist. Christian Ebner (1): fix 1982 Check handler exists PVE/CLI/pvesh.pm | 8

[pve-devel] [PATCH pve-manager 1/1] Fix #1982 Check handler exists

Checks that the handler for the API call even exists before verifying the parameter schema. By this the reported error message is more descriptive. Signed-off-by: Christian Ebner --- PVE/CLI/pvesh.pm | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/PVE/CLI/pvesh.pm b

[pve-devel] [PATCH pve-manager] Nodes: Check if target node even exists before sending WOL packet

Checks if the specified target node even exists before trying to read its MAC address from the config and sending the wake on LAN magic packet. Signed-off-by: Christian Ebner --- PVE/API2/Nodes.pm | 1 + 1 file changed, 1 insertion(+) diff --git a/PVE/API2/Nodes.pm b/PVE/API2/Nodes.pm index

[pve-devel] [PATCH #1752 pve-manager 0/1] Impl basic wake on LAN

Provides the basic functionality to provide a wake on LAN feature implementation to start nodes in a cluster from other nodes. Christian Ebner (1): Impl basic wake on LAN PVE/API2/Nodes.pm | 41 + PVE/NodeConfig.pm | 6 ++ 2 files changed, 47

[pve-devel] [PATCH #1752 pve-manager 1/1] [PATCH #1752 pve-manager] Impl basic wake on LAN

Provides the basic functionality to provide a wake on LAN feature implementation to start nodes in a cluster from other nodes. Signed-off-by: Christian Ebner --- PVE/API2/Nodes.pm | 41 + PVE/NodeConfig.pm | 6 ++ 2 files changed, 47 insertions

[pve-devel] [PATCH manager] Add button to wake nodes via WoL to the node Config.js

This adds a WoL button to the Config.js status bar. In order to be able to correctly enable/disable the button on node status changes, the monitoring code had to be slightly modified. Signed-off-by: Christian Ebner --- www/manager6/node/Config.js | 38 ++ 1

[pve-devel] [PATCH manager] fix: #1145 enable CT/VM firewall by default on creation via WebUI

Signed-off-by: Christian Ebner --- www/manager6/lxc/Network.js | 1 + www/manager6/qemu/HardwareView.js | 3 ++- www/manager6/qemu/NetworkEdit.js | 6 -- 3 files changed, 7 insertions(+), 3 deletions(-) diff --git a/www/manager6/lxc/Network.js b/www/manager6/lxc/Network.js index

[pve-devel] [PATCH manager] fix: #1218 Expose unique MAC address generation on restore of VMs and CTs in UI

Adds a checkbox to the restore window, allowing the user to avoid MAC address collisions when restoring a VM/CT to a different vmid. When restoring to the same vmid the checkbox is not visible. Signed-off-by: Christian Ebner --- www/manager6/window/Restore.js | 10 +- 1 file changed, 9

[pve-devel] [PATCH docs] Extending the firewall documentation regarding standard rules and logging

Signed-off-by: Christian Ebner --- pve-firewall.adoc | 123 -- 1 file changed, 110 insertions(+), 13 deletions(-) diff --git a/pve-firewall.adoc b/pve-firewall.adoc index 0781334..286c24b 100644 --- a/pve-firewall.adoc +++ b/pve-firewall.adoc

[pve-devel] [PATCH qemu-server] qm create: Set the NICs firewall to enabled by default on container creation

Signed-off-by: Christian Ebner --- PVE/API2/Qemu.pm | 4 1 file changed, 4 insertions(+) diff --git a/PVE/API2/Qemu.pm b/PVE/API2/Qemu.pm index 5469089..f9ce355 100644 --- a/PVE/API2/Qemu.pm +++ b/PVE/API2/Qemu.pm @@ -526,6 +526,10 @@ __PACKAGE__->register_met

[pve-devel] [PATCH container] pct create: Set the NICs firewall to enabled by default on container creation

Signed-off-by: Christian Ebner --- src/PVE/API2/LXC.pm | 4 1 file changed, 4 insertions(+) diff --git a/src/PVE/API2/LXC.pm b/src/PVE/API2/LXC.pm index 5a8a9c9..8234df4 100644 --- a/src/PVE/API2/LXC.pm +++ b/src/PVE/API2/LXC.pm @@ -296,6 +296,10 @@ __PACKAGE__->register_met

[pve-devel] [PATCH container] fix: #1218 Add flag 'unique' to pct restore in order to set new MAC addresses to NICs

Signed-off-by: Christian Ebner --- src/PVE/API2/LXC.pm | 9 - src/PVE/LXC/Create.pm | 9 - 2 files changed, 16 insertions(+), 2 deletions(-) diff --git a/src/PVE/API2/LXC.pm b/src/PVE/API2/LXC.pm index 6de121f..3d5460c 100644 --- a/src/PVE/API2/LXC.pm +++ b/src/PVE/API2/LXC.pm

Re: [pve-devel] [RFC firewall] allow to enable/disable and modify cluster wide log ratelimits

Looks good! Acknowledged > On March 21, 2019 at 7:59 AM Thomas Lamprecht wrote: > > > Signed-off-by: Thomas Lamprecht > Cc: Christian Ebner > --- > > just a POC, but should all be working, @christian could you take a look at > this? >

[pve-devel] [PATCH manager] Allow to set the firewall log rate limit and burst from the UI

Signed-off-by: Christian Ebner --- www/manager6/Makefile | 1 + www/manager6/grid/FirewallOptions.js | 8 +++ www/manager6/window/FirewallLograteEdit.js | 105 + 3 files changed, 114 insertions(+) create mode 100644 www/manager6/window

[pve-devel] [PATCH manager v2] Allow to set the firewall log rate limit and burst from the UI

Signed-off-by: Christian Ebner --- Version 2: * Values are retained in config while disable/enable * Removed disabling of the textfield and combobox when unchecking enable in order to get the values instead of undefined. * initComponent -> autoLoad: true www/manager6/Makef

[pve-devel] [PATCH manager] Allow to set the IP broadcast address used to send the WoL packet

In order to send the WoL packet to a specific broadcast domain, the user can define the broadcast address in the config, as fallback 255.255.255.255 is used. By this, the route and therefore the NIC is decided by the kernel. Signed-off-by: Christian Ebner --- PVE/API2/Nodes.pm| 25

Re: [pve-devel] applied: [PATCH qemu-server] Fix 2097 allow to set and pass wwn parameter for ide, sata and scsi disks

Ah, yes sorry for that. Note to myself: include such info in future commit messages. Thx for the feedback! > On February 26, 2019 at 7:58 AM Thomas Lamprecht > wrote: > > > On 2/25/19 5:30 PM, Christian Ebner wrote: > > This allows to set the wwn parameter for ide

[pve-devel] [PATCH qemu-server] Fix 2097 allow to set and pass wwn parameter for ide, sata and scsi disks

This allows to set the wwn parameter for ide, sata and scsi disks in the VM config and passes it to the qemu command on execution. Signed-off-by: Christian Ebner --- PVE/QemuServer.pm | 16 1 file changed, 16 insertions(+) diff --git a/PVE/QemuServer.pm b/PVE/QemuServer.pm

[pve-devel] [PATCH v4 manager] 1145 Warn if datacenter firewall is disabled

This warns the user that the datacenter firewall is disabled when editing the host or the VM/CT firewall status. Signed-off-by: Christian Ebner --- Version 4: * Code refactored to be more declarative as suggested * Removed warning about pve-firewall service not running * Fixed logic

[pve-devel] [PATCH v5 manager] 1145 Warn if datacenter firewall is disabled

This warns the user that the datacenter firewall is disabled when editing the host or the VM/CT firewall status. Signed-off-by: Christian Ebner --- Version 5: * Removed unneeded fieldDefaults * Removed unneeded fwtype * Put warning text into gettext() www/manager6/Makefile

[pve-devel] [PATCH storage] fix #585: remove leftover disks/directory after VM creation failed

When trying to create a qcow2 disk image with a size larger than available on the storage, this will fail. As qemu-img does not clean up the disk afterwards, it needs to be deleted explicitly. Further, the vmid folder is cleaned up once it is empty. Signed-off-by: Christian Ebner --- PVE

[pve-devel] [PATCH 0/7] Add zsh command completion generation

Adds the zsh command completion generation for most of the pve CLI tools. pve-firewall: Christian Ebner (1): 1891 Add zsh command completion for pve-firewall src/Makefile | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) pve-ha-manager: Christian Ebner (1): 1891 Add zsh command

[pve-devel] [PATCH firewall] 1891 Add zsh command completion for pve-firewall

Adds the zsh command completion scripts for pve-firewall. Signed-off-by: Christian Ebner --- src/Makefile | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/src/Makefile b/src/Makefile index 0183a61..2280abd 100644 --- a/src/Makefile +++ b/src/Makefile @@ -8,6 +8,7

[pve-devel] [PATCH ha-manager] 1891 Add zsh command completion for ha-manager CLI tools

Add the zsh command completion generation for the ha-manager CLI tools. This adds the automatic generation of the autocompletion scripts for zsh Signed-off-by: Christian Ebner --- debian/pve-ha-manager.install | 3 +++ src/Makefile | 21 +++-- 2 files changed

[pve-devel] [PATCH storage] 1891 Add zsh command completion for pvesm

This adds the zsh command completion generation for pvesm. Signed-off-by: Christian Ebner --- Makefile | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/Makefile b/Makefile index 8f27cd1..bece3f1 100644 --- a/Makefile +++ b/Makefile @@ -10,6 +10,7 @@ MANDIR=${PREFIX

[pve-devel] [PATCH qemu-server] 1891 Add zsh command completion for qm and qmrestore

This adds the zsh command completion for qm and qmrestore. Signed-off-by: Christian Ebner --- Makefile | 14 +- 1 file changed, 13 insertions(+), 1 deletion(-) diff --git a/Makefile b/Makefile index 369e660..bdad719 100644 --- a/Makefile +++ b/Makefile @@ -20,6 +20,7 @@ MAN1DIR

[pve-devel] [PATCH cluster] 1891 Add zsh command completion for pvecm

This adds the generation of the zsh command completion scripts for pvecm. Signed-off-by: Christian Ebner --- data/PVE/Makefile | 10 -- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/data/PVE/Makefile b/data/PVE/Makefile index b87a0f8..509f0ea 100644 --- a/data/PVE

[pve-devel] [PATCH access-control] 1891 Add zsh command completion for pveum

This generates the zsh command completion scripts for pveum. Signed-off-by: Christian Ebner --- Makefile | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/Makefile b/Makefile index 35dcf10..ed50f5b 100644 --- a/Makefile +++ b/Makefile @@ -10,6 +10,7 @@ MANDIR=${PREFIX

[pve-devel] [PATCH container 7/7] 1891 Add zsh command completion generation for pct

Generates the zsh command completion scripts for pct. Signed-off-by: Christian Ebner --- src/Makefile | 10 +- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/src/Makefile b/src/Makefile index f68eb5d..b0c30de 100644 --- a/src/Makefile +++ b/src/Makefile @@ -16,6 +16,7

[pve-devel] [PATCH v3 manager] 1145 Warn if datacenter firewall or host firewall service is disabled

This shows a warning when the user edits the host firewall status or the VM/CT firewall status, but the datacenter level firewall is disabled or the pve-firewall service is not running on the host. Signed-off-by: Christian Ebner --- Version 3: * As discussed offline with Dominik and Thomas

[pve-devel] [RFC firewall] fix: #2123 Logging of user defined firewall rules

is limited to 1 entry per second. For now the rule has to be created or edited via the pvesh API call or via the firewall config in order to set the log level. Signed-off-by: Christian Ebner --- This is a tentative patch in order to allow fine grained logging of packets dropped by user defined rules

Re: [pve-devel] [RFC firewall] fix: #2123 Logging of user defined firewall rules

> On 3/14/19 1:06 PM, Christian Ebner wrote: > > This allows a user to log traffic filtered by a self defined firewall rule. > > Therefore the API is extended to include a 'log' option allow to specify the > > log level for each rule individually. > > > > The 'l

[pve-devel] [PATCH v6 manager] 1145 Warn if datacenter firewall is disabled

This warns the user that the datacenter firewall is disabled when editing the host or the VM/CT firewall status. Signed-off-by: Christian Ebner --- Version 6: * moved FirewallEnableEdit from grid to window folder * use cbind to set the checkbox * use fixed width of 350 for the window

[pve-devel] [RFC v2 firewall 1/1] fix: #2123 Logging of user defined firewall rules

is limited to 1 entry per second. For now the rule has to be created or edited via the pvesh API call or via the firewall config in order to set the log level. Signed-off-by: Christian Ebner --- Version 2: * Added missing $logmsg to PVEFW-FWBRR-IN and PVEFW-FWBR-OUT rules * Added '--limit

[pve-devel] [RFC v2 manager 1/1] fix: # 2123 Logging of user defined firewall rules

-by: Christian Ebner --- Version 2: * Introduced PVE.FirewallLogLevel to share it between FirewallOptions.js and FirewallRules.js * Reordered elements of the array to be in order of the corresponding numeric value from the log_level_hash as defined in pve-firewall/src/PVE

[pve-devel] [RFC docs 0/3] Add logging for user-defined firewall rules

This patches allow to set per rule log-levels for user-defined firewall rules. pve-docs: Christian Ebner (1): fix: #2123 Logging of user defined firewall rules pve-firewall.adoc | 43 +++ 1 file changed, 43 insertions(+) pve-firewall: Christian Ebner

[pve-devel] [RFC docs 1/1] fix: #2123 Logging of user defined firewall rules

Extends the documentation to mention the additional option to define a per-rule log level for user-defined rules. Signed-off-by: Christian Ebner --- pve-firewall.adoc | 43 +++ 1 file changed, 43 insertions(+) diff --git a/pve-firewall.adoc b/pve

Re: [pve-devel] applied: [RFC v2 firewall 1/1] fix: #2123 Logging of user defined firewall rules

change the current behaviour on default vm log action, where we > don't have limit currently. > > (and I really need to log all dropped/reject) > > > BTW, are you sure that's it's only limiting logging ? What happen on an > ACCEPT log for example ? > > > Ale

[pve-devel] [PATCH firewall] Remove hard coded rate limit of logged packets

As some users rely on logging of all packets dropped/rejected, this removes the hard coded rate limit. Signed-off-by: Christian Ebner --- src/PVE/Firewall.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/PVE/Firewall.pm b/src/PVE/Firewall.pm index f294d36..30e2b4b

[pve-devel] [PATCH docs] Fixed some typos and slight language improvements

Signed-off-by: Christian Ebner --- pve-firewall.adoc | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/pve-firewall.adoc b/pve-firewall.adoc index acaca95..3e417e8 100644 --- a/pve-firewall.adoc +++ b/pve-firewall.adoc @@ -35,7 +35,7 @@ containers. Features like firewall

[pve-devel] [RFC v3 manager] fix: # 2123 Logging of user defined firewall rules

-by: Christian Ebner --- Version 3: * fieldName -> fieldLabel * set defaults for name and fieldLabel www/manager6/grid/FirewallOptions.js | 20 +++- www/manager6/grid/FirewallRules.js | 17 +++-- 2 files changed, 30 insertions(+), 7 deletions(-) diff --git a/

[pve-devel] [PATCH docs] Fix 1891: Add zsh completion generator

with the corresponding patch have to be installed on the build system. Signed-off-by: Christian Ebner --- pve-doc-generator.mk.in | 8 1 file changed, 8 insertions(+) diff --git a/pve-doc-generator.mk.in b/pve-doc-generator.mk.in index d67d1c5..5f9965d 100644 --- a/pve-doc-generator.mk.in +++ b/pve-doc

[pve-devel] [PATCH manager] Fix 1891 Generate zsh tab completion scripts for cli tools

This patch builds the zsh tab completion scripts for the cli tools of pve-manager. In order for it to work, the latest version of pve-common and pve-docs including the corresponding patches have to be installed on the build system. Signed-off-by: Christian Ebner --- bin/Makefile | 12

[pve-devel] [PATCH common] Fix 1891: Add zsh tab completion script generator

Add zsh tab completion generator function to automatically generate the zsh scripts used for autocompletion. This uses the older zsh completion system relying on compctl to call the executables analogos to the bash completer. Signed-off-by: Christian Ebner --- src/PVE/CLIHandler.pm | 27

[pve-devel] [PATCH v2 manager] 1145 Warn if datacenter firewall or host firewall service is disabled

This shows a warning when the user edits the host firewall status, but the firewall is disabled at datacenter level or the pve-firewall service is not running on the host. Signed-off-by: Christian Ebner --- Version 2: * Instead of showing the firewall status continuously in the top bar

[pve-devel] [PATCH docs] Fix double occurrence of be in pveceph docs

This fixes a typo (subsequent occurrence of be) in the CephFS section of the documentation. Signed-off-by: Christian Ebner --- pveceph.adoc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pveceph.adoc b/pveceph.adoc index 2b061e5..f275463 100644 --- a/pveceph.adoc +++ b

[pve-devel] [PATCH docs] Fixed typo in Ceph Metadata Server documentation

This fixes a typo in the Metadata Server section of the documentation. Signed-off-by: Christian Ebner --- pveceph.adoc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pveceph.adoc b/pveceph.adoc index 2b061e5..d260976 100644 --- a/pveceph.adoc +++ b/pveceph.adoc @@ -460,7

[pve-devel] [PATCH manager] 1145 Show datacenter firewall status in firewall options tabs

Display the status of the datacenter firewall in the top bar of every firewall options tab. Signed-off-by: Christian Ebner --- www/manager6/grid/FirewallOptions.js | 58 +++- 1 file changed, 57 insertions(+), 1 deletion(-) diff --git a/www/manager6/grid

[pve-devel] [PATCH v2 common] Fix 1891: Add zsh command completion generator

to be placed in the .zshrc: autoload -U compinit compinit Signed-off-by: Christian Ebner --- Version 2: * Thanks to the input and offline discussion with Thomas this now relies on the new completion system with compadd (although we only use it to wrap to the perl bashcompletion

[pve-devel] [PATCH v2 manager] Fix 1891 Generate zsh tab completion scripts for cli tools

This patch builds the zsh tab completion scripts for the cli tools of pve-manager. In order for it to work, the latest version of pve-common and pve-docs including the corresponding patches have to be installed on the build system. Signed-off-by: Christian Ebner --- Version 2: * zsh

[pve-devel] [PATCH v2 manager] Add context menu entry for WoL calls to nodes in GUI

This adds a context menu entry to the cluster nodes which triggers the wake on LAN API call for the selected node. The entry is disabled if the node is already running or the user has no Sys.PowerMgmt capabilities. Signed-off-by: Christian Ebner --- Thanks for the feedback, here the changes

[pve-devel] [PATCH manager] Add bash completion for wakeonlan API call

This adds the bash completion for the wakeonlan API call. The bash completion returns only those nodes which are offline according to the member status. Signed-off-by: Christian Ebner --- PVE/API2/Nodes.pm | 11 +++ 1 file changed, 11 insertions(+) diff --git a/PVE/API2/Nodes.pm b/PVE

[pve-devel] [PATCH v2 #1941 storage] Plugin: Remove empty directories on VM destroy

Remove directories if they are empty after destroying a VM. Signed-off-by: Christian Ebner --- Version 2: * Changed comment to suggested text * removed File::Basename:: prefix to dirname() PVE/Storage/Plugin.pm | 6 ++ 1 file changed, 6 insertions(+) diff --git a/PVE/Storage

[pve-devel] [PATCH manager] Add context menu entry for WoL calls to nodes in GUI

This adds a context menu entry to the cluster nodes which triggers the wake on LAN API call for the selected node. The entry is disabled if the node is already running or the user has no Sys.PowerMgmt capabilities. Signed-off-by: Christian Ebner --- www/manager6/node/CmdMenu.js | 28

[pve-devel] [PATCH v2 firewall] Fix #1606 Add nf_conntrack_allow_invalid option

This adds the nf_conntrack_allow_invalid host firewall option to allow to disable the dropping of invalid packets from the connection tracker point of view. This is needed for some rare setups with asymmetrical multi-path routing. Signed-off-by: Christian Ebner --- Version 2

[pve-devel] [PATCH firewall] Fix #1606 Add nf_conntrack_allow_invalid option

This adds the nf_conntrack_allow_invalid host firewall option to allow to disable the dropping of invalid packets from the connection tracker point of view. This is needed for some rare setups with asymmetrical multi-path routing. Signed-off-by: Christian Ebner --- src/PVE/Firewall.pm | 20

[pve-devel] [PATCH v4 manager] Fix #1831: Add filter to CT template/appliances download window

This adds the posibility to filter CT template/appliances by package as well as description in the CT template/appliances download window. Signed-off-by: Christian Ebner --- Version 4: * Inlined filter function (thanks, makes it indeed a lot more readable!) * Replaced

[pve-devel] [PATCH v2 manager] Fix #1831: Add filter to CT template/appliances download window

This adds the posibility to filter CT template/appliances by package as well as description in the CT template/appliances download window. Signed-off-by: Christian Ebner --- Version 2: changes made according to off-list discussions * Renamed textfield label from 'Search' to 'Filter

[pve-devel] [PATCH v2 manager] Add context menu to global search entries

This add a context menu to the entries of the global search field instead of showing the browsers default one. This allows to search and easily manage nodes, VMs and CTs similar to the behaviour in the resource tree. Signed-off-by: Christian Ebner --- Version 2: * createCmdMenu() now

[pve-devel] [PATCH manager] Fix #1831: Add search bar to CT template/appliances download window

This add a search bar to filter by package name to the CT template/appliances download window. Signed-off-by: Christian Ebner --- www/manager6/storage/ContentView.js | 23 +++ 1 file changed, 23 insertions(+) diff --git a/www/manager6/storage/ContentView.js b/www/manager6

[pve-devel] [PATCH v3 manager] Fix #1831: Add filter to CT template/appliances download window

This adds the posibility to filter CT template/appliances by package as well as description in the CT template/appliances download window. Signed-off-by: Christian Ebner --- Version 3: * In lack of better alternatives solved via toLowerCase() and indexOf() instead of regex www

[pve-devel] [PATCH manager] Add context menu to global search entries

This add a context menu to the entries of the global search field instead of showing the browsers default one. This allows to search and easily manage nodes, VMs and CTs similar to the behaviour in the resource tree. Signed-off-by: Christian Ebner --- www/manager6/form/GlobalSearchField.js | 1

[pve-devel] [PATCH v2 manager] Add bash completion for wakeonlan API call

This adds the bash completion for the wakeonlan API call. The bash completion returns only those nodes which are offline according to the member status. Signed-off-by: Christian Ebner --- Version 2: * Use more concise way as suggested via mailing list * Return those nodes which

Re: [pve-devel] Change ESC for other keyboard key or combination...

Hi Gilberto, this is an open issue in noVNC, see https://github.com/novnc/noVNC/issues/923 Not sure if we can do much about this behavior!? Regards, Chris > On February 4, 2019 at 4:46 PM Gilberto Nunes > wrote: > > > Hi there > > This is a minor annoying problem, but when using Console

[pve-devel] [PATCH firewall] fix: Check if VM firewall enabled before generating NICs tap rules

Only if the VM firewall is enabled, the tap rules for each of the NICs should be generated, analogous to the current behaviour for CTs. Signed-off-by: Christian Ebner --- src/PVE/Firewall.pm | 24 +--- 1 file changed, 13 insertions(+), 11 deletions(-) diff --git a/src/PVE

Re: [pve-devel] [RFC firewall 1/3] make verbose a global state

Looks fine, definitely an improvement in readability. > On April 11, 2019 at 3:28 PM Thomas Lamprecht wrote: > > > This is part of the project 'stop the parameter rabbit hole madness' > and tries to make reading the firewall code a little bit easier. > > Here we remove passing $verbose from 44

[pve-devel] [PATCH container] fix: #1075: Correctly restore CT templates form backup

to a CT. Signed-off-by: Christian Ebner --- src/PVE/API2/LXC.pm | 28 src/PVE/LXC/Create.pm | 2 +- 2 files changed, 29 insertions(+), 1 deletion(-) diff --git a/src/PVE/API2/LXC.pm b/src/PVE/API2/LXC.pm index 5a8a9c9..42e11fb 100644 --- a/src/PVE/API2/LXC.pm +++ b/src

[pve-devel] [PATCH docs] Remove all mentions of sheepdog from the docs

As sheepdog is no longer actively maintained according to one of the developers, it is planed to remove it for the upcomming version 6 of Proxmox VE. This removes mentions of sheepdog from the docs. Signed-off-by: Christian Ebner --- api-viewer/apidata.js | 2 -- pve-intro.adoc| 5

[pve-devel] [RFC manager] fix: # 2123 Logging of user defined firewall rules

-by: Christian Ebner --- www/manager6/grid/FirewallRules.js | 21 +++-- 1 file changed, 19 insertions(+), 2 deletions(-) diff --git a/www/manager6/grid/FirewallRules.js b/www/manager6/grid/FirewallRules.js index 85b30371..27795e96 100644 --- a/www/manager6/grid/FirewallRules.js +++ b

[pve-devel] [PATCH firewall] Remove redundant logging of packets passing the tap chain.

Incomming and outgoing packets passing the firewall bridge were unneccessarily logged, leading to double entries. The first log entry occurred when passing the bridge, the second when the packets fate was decided (ACCEPT/DROP/REJECT). Signed-off-by: Christian Ebner --- src/PVE/Firewall.pm | 4

Re: [pve-devel] pve-firewall: default loglevel behaviour change

Hi Alexandre, you are right, logging the packets passing the firewall bridge seems a bit overkill and redundant. Will send a patch to fix this. > On May 15, 2019 at 4:08 PM Alexandre DERUMIER wrote: > > > Hi, > > since this commit > > >

[pve-devel] [PATCH manager 2/2] fix #2190: Base64 encode SMBIOS value strings in order to allow more characters

to the corresponding fields in the structure type 1 (System Information). By base64 encoding the values clashing of the config is avoided. Relies on the corresponding patch to qemu-server to pass parameter verification and correct parsing. Signed-off-by: Christian Ebner --- Version 3: * use base64 encoding

[pve-devel] [PATCH 0/2] fix #2190: Base64 encode SMBIOS value strings in order to allow more characters

to the corresponding fields in the structure type 1 (System Information). By base64 encoding the values clashing of the config is avoided, backwards compatibility is maintained. Christian Ebner (1): fix #2190: Base64 encode SMBIOS value strings in order to allow more characters PVE/QemuServer.pm

[pve-devel] [PATCH qemu 1/2] fix #2190: Base64 encode SMBIOS value strings in order to allow more characters

to the corresponding fields in the structure type 1 (System Information). By base64 encoding the values clashing of the config is avoided. Relies on the corresponding patch to pve-manager to obtain base64 encoded values. Signed-off-by: Christian Ebner --- Version 3: * use base64 instead of URL encoding

[pve-devel] [PATCH ha-manager] fix #2234: fix typo in service description

replace Ressource by Resource Signed-off-by: Christian Ebner --- debian/pve-ha-crm.service | 2 +- debian/pve-ha-lrm.service | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/debian/pve-ha-crm.service b/debian/pve-ha-crm.service index 800ce9b..b54992f 100644 --- a/debian

[pve-devel] [PATCH v4 0/2] fix #2190: Base64 encode SMBIOS value strings in order to allow more characters

to the corresponding fields in the structure type 1 (System Information). By base64 encoding the values clashing of the config is avoided, backwards compatibility is maintained. Christian Ebner (1): fix #2190: Base64 encode SMBIOS value strings in order to allow more characters PVE

[pve-devel] [PATCH v4 manager 2/2] fix #2190: Base64 encode SMBIOS value strings in order to allow more characters

to the corresponding fields in the structure type 1 (System Information). By base64 encoding the values clashing of the config is avoided. Relies on the corresponding patch to qemu-server to pass parameter verification and correct parsing. Signed-off-by: Christian Ebner --- Version 4: * Cleaner code

[pve-devel] [PATCH v4 qemu 1/2] fix #2190: Base64 encode SMBIOS value strings in order to allow more characters

to the corresponding fields in the structure type 1 (System Information). By base64 encoding the values clashing of the config is avoided. Relies on the corresponding patch to pve-manager to obtain base64 encoded values. Signed-off-by: Christian Ebner --- Version 4: * Improved regex for base64 encoded

[pve-devel] [RFC guest-common 1/3] fix #1291: implement remove_vmid_from_cronjobs

remove_vmid_from_cronjobs updates the vzdump.cron backup jobs, excluding the given vmid. Signed-off-by: Christian Ebner --- PVE/VZDump/Plugin.pm | 51 +++ 1 file changed, 51 insertions(+) diff --git a/PVE/VZDump/Plugin.pm b/PVE/VZDump/Plugin.pm

[pve-devel] [RFC container 3/3] fix #1291: add option purge for destroy_vm api call

The purge option allows to remove the vmid from the vzdump.cron jobs. Signed-off-by: Christian Ebner --- src/PVE/API2/LXC.pm | 11 +++ 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/src/PVE/API2/LXC.pm b/src/PVE/API2/LXC.pm index cf14d75..563cfb9 100644 --- a/src/PVE/API2

[pve-devel] [RFC 0/3] fix #1291: add purge option for VM/CT destroy

The purge flag allows to remove the vmid from the vzdump.cron backup jobs on VM/CT destruction. Christian Ebner (1): fix #1291: implement remove_vmid_from_cronjobs PVE/VZDump/Plugin.pm | 51 +++ 1 file changed, 51 insertions(+) Christian Ebner

[pve-devel] [RFC qemu 2/3] fix #1291: add purge option to vm_destroy api call

The purge flag allows to remove the vmid from the vzdump.cron backup jobs. Signed-off-by: Christian Ebner --- PVE/API2/Qemu.pm | 18 -- 1 file changed, 8 insertions(+), 10 deletions(-) diff --git a/PVE/API2/Qemu.pm b/PVE/API2/Qemu.pm index a628a20..60b0f11 100644 --- a/PVE/API2

  1   2   >