Re: [pve-devel] [PATCH 1/1] initial ifupdown2 package
On Wed, May 16, 2018 at 12:01:40PM +0200, Alexandre Derumier wrote: > --- > Makefile | 42 + > debian/changelog | 174 > + > debian/compat | 1 + > debian/control | 31 > debian/copyright | 28 > debian/ifupdown2.postinst | 86 ++ > ...0001-start-networking-add-usr-bin-in-PATH.patch | 28 > ...ns-scripts-fix-ENV-for-interfaces-options.patch | 29 > debian/patches/0003-config-tuning.patch| 52 ++ > .../0004-manual-interfaces-set-link-up.patch | 58 +++ > ...e-tap-veth-fwpr-interfaces-from-bridge-on.patch | 27 > ...6-netlink-IFLA_BRPORT_ARP_SUPPRESS-use-32.patch | 29 > ...0007-add-dummy-mtu-bridgevlanport-modules.patch | 69 > .../patches/0008-add-vxlan-physdev-support.patch | 159 +++ > debian/patches/series | 8 + > debian/rules | 21 +++ > 16 files changed, 842 insertions(+) > create mode 100644 Makefile > create mode 100644 debian/changelog > create mode 100644 debian/compat > create mode 100644 debian/control > create mode 100644 debian/copyright > create mode 100644 debian/ifupdown2.postinst > create mode 100644 > debian/patches/0001-start-networking-add-usr-bin-in-PATH.patch > create mode 100644 > debian/patches/0002-addons-scripts-fix-ENV-for-interfaces-options.patch > create mode 100644 debian/patches/0003-config-tuning.patch > create mode 100644 debian/patches/0004-manual-interfaces-set-link-up.patch > create mode 100644 > debian/patches/0005-don-t-remove-tap-veth-fwpr-interfaces-from-bridge-on.patch > create mode 100644 > debian/patches/0006-netlink-IFLA_BRPORT_ARP_SUPPRESS-use-32.patch > create mode 100644 > debian/patches/0007-add-dummy-mtu-bridgevlanport-modules.patch > create mode 100644 debian/patches/0008-add-vxlan-physdev-support.patch > create mode 100644 debian/patches/series > create mode 100755 debian/rules > (...) Looks interesting, seems like you spent quite some time with this already. If we add this, a couple of things: I'd like to have more info on patch 0007-add-dummy-..., probably best to just write a more descriptive commit message there. Note that we started using git submodules with mirrors of upstream git repos for several packages by now, rather than having a `make download` target producing a tarball. We could do that here as well. I think it's more convenient, too. As for the patch workflow, I see there are a bunch which are going upstream and a bunch of pve-specific ones. Would be good to separate them somehow. (I haven't been very consistent in that regard, though. eg. in qemu we have a pve/ and an extra/ direcory, while in lxc we have the pve patches directly in the patches dir and a fixes/ subdir). One or the other might be nice to use. That way it's also more convenient to (automatically) update patch files if you have your custom changes as a branch in a git-clone. PS: You don't need to use a cover letter for single-patch mails, especially if it only copies the commit message, as it's already in the patch itself anyway ;-) ___ pve-devel mailing list pve-devel@pve.proxmox.com https://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
[pve-devel] [PATCH 1/1] initial ifupdown2 package
---
Makefile | 42 +
debian/changelog | 174 +
debian/compat | 1 +
debian/control | 31
debian/copyright | 28
debian/ifupdown2.postinst | 86 ++
...0001-start-networking-add-usr-bin-in-PATH.patch | 28
...ns-scripts-fix-ENV-for-interfaces-options.patch | 29
debian/patches/0003-config-tuning.patch| 52 ++
.../0004-manual-interfaces-set-link-up.patch | 58 +++
...e-tap-veth-fwpr-interfaces-from-bridge-on.patch | 27
...6-netlink-IFLA_BRPORT_ARP_SUPPRESS-use-32.patch | 29
...0007-add-dummy-mtu-bridgevlanport-modules.patch | 69
.../patches/0008-add-vxlan-physdev-support.patch | 159 +++
debian/patches/series | 8 +
debian/rules | 21 +++
16 files changed, 842 insertions(+)
create mode 100644 Makefile
create mode 100644 debian/changelog
create mode 100644 debian/compat
create mode 100644 debian/control
create mode 100644 debian/copyright
create mode 100644 debian/ifupdown2.postinst
create mode 100644
debian/patches/0001-start-networking-add-usr-bin-in-PATH.patch
create mode 100644
debian/patches/0002-addons-scripts-fix-ENV-for-interfaces-options.patch
create mode 100644 debian/patches/0003-config-tuning.patch
create mode 100644 debian/patches/0004-manual-interfaces-set-link-up.patch
create mode 100644
debian/patches/0005-don-t-remove-tap-veth-fwpr-interfaces-from-bridge-on.patch
create mode 100644
debian/patches/0006-netlink-IFLA_BRPORT_ARP_SUPPRESS-use-32.patch
create mode 100644
debian/patches/0007-add-dummy-mtu-bridgevlanport-modules.patch
create mode 100644 debian/patches/0008-add-vxlan-physdev-support.patch
create mode 100644 debian/patches/series
create mode 100755 debian/rules
diff --git a/Makefile b/Makefile
new file mode 100644
index 000..0c7b646
--- /dev/null
+++ b/Makefile
@@ -0,0 +1,42 @@
+PACKAGE=ifupdown2
+VERSION=1.1
+PKGREL=cl3u18
+
+DIR=${PACKAGE}-${VERSION}
+SRC=${PACKAGE}-${VERSION}.orig.tar.xz
+
+
+ARCH:=$(shell dpkg-architecture -qDEB_BUILD_ARCH)
+
+GITVERSION:=$(shell git rev-parse HEAD)
+
+DEB=${PACKAGE}_${VERSION}-${PKGREL}_${ARCH}.deb
+
+.PHONY: deb
+${DEB} deb: ${SRC}
+ rm -rf ${DIR}
+ tar xf ${SRC}
+ cp -a debian ${DIR}
+ cd ${DIR}; dpkg-buildpackage -rfakeroot -b -uc -us
+
+.PHONY: download
+download:
+ rm -rf ${DIR} $(SRC)
+ git clone git://github.com/CumulusNetworks/ifupdown2 ${DIR}
+ cd ${DIR}; git checkout ${PKGREL}
+ tar czf ${SRC} ${DIR}/
+
+.PHONY: upload
+upload: ${DEB}
+ tar cf - ${DEB}|ssh -X repo...@repo.proxmox.com -- upload --product
pmg,pve --dist stretch
+
+.PHONY: distclean
+distclean: clean
+
+.PHONY: clean
+clean:
+ rm -rf *~ debian/*~ *.deb ${BUILDDIR} *.changes *.dsc *.buildinfo
+
+.PHONY: dinstall
+dinstall: deb
+ dpkg -i ${DEB}
diff --git a/debian/changelog b/debian/changelog
new file mode 100644
index 000..9609ca6
--- /dev/null
+++ b/debian/changelog
@@ -0,0 +1,174 @@
+ifupdown2 (1.1-cl3u18) RELEASED; urgency=medium
+
+ * Closes: CM-20069: Link down does not work on SVI configured in a VRF
+ * Closes: CM-20027: ifreload causes MTU to drop on bridge SVIs
+ * Closes: CM-20002: addons: addressvirtual: check if SVI name is first in
routing table
+ * Closes: CM-19587: ifreload error on deleting bond slaves from an already
configured bond
+ * Closes: CM-19882: ifupdown2 error is confusing when netmask is specified
for vxlan-local-tunnelip
+ * Closes: CM-19760: ifupdown2 syntax check needed for vxlan interfaces
+ * Closes: CM-19081: vxlan-ageing default timer doesn't align with
bridge-ageing
+ * Closes: CM-14031: Error with "ifreload -a -n" when MGMT VRF is not Applied
+ * Closes: CM-19075: using reserved VLAN range reports error but ifreload
returns 0
+ * Closes: CM-18882: unable to set bridge-portmcrouter to "2"
+ * Closes: CM-19760: vxlan syntax-check warn on missing vxlan-local-tunnelip
+ * Closes: github #39: addons: vrf: fix vrf slave link kind
+ * New. Enabled: addons: vxlan: add support for vxlan-port attribute
+
+ -- dev-support Thu, 08 Feb 2018 10:42:42
+0100
+
+ifupdown2 (1.1-cl3u17) RELEASED; urgency=medium
+
+ * Closes: CM-19671: ip[6]-forward attributes not set at boot
+
+ -- dev-support Thu, 08 Feb 2018 09:48:37
+0100
+
+ifupdown2 (1.1-cl3u16) RELEASED; urgency=medium
+
+ * Closes: CM-18647, CM-19279. fix python exception on macvlans address dump
+ * Closes: CM-19332. fix eth0 doesn't acquire DHCP address when mgmt VRF is
enabled
+
+ -- dev-support Tue, 09 Jan 2018 02:02:58
+0100
+
+ifupdown2 (1.1-cl3u15) RELEASED;
