Re: [pve-devel] Gitlab-ci
On 9/2/19 2:33 PM, Fabian Grünbichler wrote: >> I'm curious, do you use some kind of email scripts, special email client, to >> manage current workflow ? >> (Sometime I'm lost myself with my patches ;) > most of the actively reviewing people use either (neo)mutt or some > variant of notmuch, but there are some not-yet converted thunderbird > users as well ;) Slight feeling you talking about me ;) Yes, while I'm looking for a good MTA that won't slow down to long hangs and full halts due my few 100k mails (neo)mutt wasn't the full really nice solution either. Or better said, while it looked more promising and nicer to use than Thunderbird (especially for me as vim user) it wasn't behaving that much better that I could convice myself to go over the learning-curve and drop my Thunderbird muscle-memory :) Maybe 'aerc'[0] does it better someday, until then I'll probably stick with Thunderbird. [0]: https://aerc-mail.org/ I do markings of patches which are still-to-review, mine-not-yet-applied or others out of interest with simple tags which get highlighted in different colors. For mid-volume lists like ours that's enough for me. Applying is done by having various SSHFS mounts to my development VMs (PMG, PVE, different versions) and saving the patches there and using git am, quick enough for me. ___ pve-devel mailing list pve-devel@pve.proxmox.com https://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
Re: [pve-devel] Gitlab-ci
On August 27, 2019 11:24 am, Alexandre DERUMIER wrote: > Hi, > > I think 1 benefit of gitlab,github,... is the tracking of merge request. IMHO this is a big downside of Github and Gitlab - cleanly checking out an older iteration of a PR/MR is very cumbersome (and wasn't even really possible for the longest time). The review comments reference (and even link to!) code that is no longer available directly, and it gets confusing quickly. The only thing that's really nice is the direct integration into various CI tools, also for in-progress change requests. with mail, v1 and v2 are simply two mail threads, including any review comments. this is much simpler to keep around, checking the archive, etc. > (To not lost some patches series send months ago). > > For code review it great too. (make comments directly in the merge) see above. I hate the review interface with a passion :-P see [1] for example - some inline comments are included in the discussion, but the full review with all comments is 404[2], even though it is linked from [1]. I am also following sourcehut's progress - it might be able to bridge the gap between both worlds (plain email + nice looking web interface). > I'm curious, do you use some kind of email scripts, special email client, to > manage current workflow ? > (Sometime I'm lost myself with my patches ;) most of the actively reviewing people use either (neo)mutt or some variant of notmuch, but there are some not-yet converted thunderbird users as well ;) 1: https://github.com/corosync/corosync/pull/450 2: https://github.com/corosync/corosync/pull/450/files/68e7b4cbe3a4687bb6168500d3275d5969b9b9c0 ___ pve-devel mailing list pve-devel@pve.proxmox.com https://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
Re: [pve-devel] Gitlab-ci
Hi, I think 1 benefit of gitlab,github,... is the tracking of merge request. (To not lost some patches series send months ago). For code review it great too. (make comments directly in the merge) I'm curious, do you use some kind of email scripts, special email client, to manage current workflow ? (Sometime I'm lost myself with my patches ;) - Mail original - De: "Thomas Lamprecht" À: "pve-devel" , "Kamil Trzciński" Envoyé: Lundi 26 Août 2019 19:47:56 Objet: Re: [pve-devel] Gitlab-ci On 26.08.19 12:43, Kamil Trzciński wrote: > Did you think about using GitLab to at least to host all sources? For now that won't happen soon. > > I think that using Merge Requests workflow could actually be better and > easier to contribute to > than current mailing list. > IMO this depends on what one is accustomed too. I find the mailinglist approach in general easier, I need no account (already have a mail address) can use my own clients, it's all plain text, ... That said, there where some discussions on adding supporting tools like "patchew" and maybe even GitLab may be an option some day, but not soon, the current workflow may seem a bit lowlevel or unused too, especially for people which came to OpenSource relative recently, where GitLab/Hub like platforms were already really popular. But we have docs for the contribution process, and in general will really try to help people who actively try to contribute, if they have any questions. I personally also try to take almost everything resembling a patch in any way, if possible - at least if it comes from people not employed by Proxmox (as then it's their job to do so ;) ) Depending pull-requests and merge base workflow, yes that could sometimes be nicer, but it does not really fits our review procedure and not all like it here. At the end I think that everybody should be able to send a mail, naturally it adds some sort of barrier and it's not anyhow a goal to result in people not contributing because of this. But also if you change the whole process to GitLab/Hub/... one will "lock out" another group of people, or better said make new contributions less likely. btw. I'm currently eyeing sourcehut, it's a bit of a compromise and may develop into something I'd have no issue to use, not that it'd be my decision alone. In the world of OpenSource, mailing list worked good for quite a bit for quite bigger projects, so for now we should get away with it a bit longer. cheers, Thomas > > On Tue, Apr 17, 2018 at 10:53 AM Rene Jochum wrote: > >> On 2018-04-17 10:27, Dietmar Maurer wrote: >>> I personally think this adds much overhead and does not really help >>> developing software. >>> >> >> Ok. ___ pve-devel mailing list pve-devel@pve.proxmox.com https://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel ___ pve-devel mailing list pve-devel@pve.proxmox.com https://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
Re: [pve-devel] Gitlab-ci
On 26.08.19 12:43, Kamil Trzciński wrote: > Did you think about using GitLab to at least to host all sources? For now that won't happen soon. > > I think that using Merge Requests workflow could actually be better and > easier to contribute to > than current mailing list. > IMO this depends on what one is accustomed too. I find the mailinglist approach in general easier, I need no account (already have a mail address) can use my own clients, it's all plain text, ... That said, there where some discussions on adding supporting tools like "patchew" and maybe even GitLab may be an option some day, but not soon, the current workflow may seem a bit lowlevel or unused too, especially for people which came to OpenSource relative recently, where GitLab/Hub like platforms were already really popular. But we have docs for the contribution process, and in general will really try to help people who actively try to contribute, if they have any questions. I personally also try to take almost everything resembling a patch in any way, if possible - at least if it comes from people not employed by Proxmox (as then it's their job to do so ;) ) Depending pull-requests and merge base workflow, yes that could sometimes be nicer, but it does not really fits our review procedure and not all like it here. At the end I think that everybody should be able to send a mail, naturally it adds some sort of barrier and it's not anyhow a goal to result in people not contributing because of this. But also if you change the whole process to GitLab/Hub/... one will "lock out" another group of people, or better said make new contributions less likely. btw. I'm currently eyeing sourcehut, it's a bit of a compromise and may develop into something I'd have no issue to use, not that it'd be my decision alone. In the world of OpenSource, mailing list worked good for quite a bit for quite bigger projects, so for now we should get away with it a bit longer. cheers, Thomas > > On Tue, Apr 17, 2018 at 10:53 AM Rene Jochum wrote: > >> On 2018-04-17 10:27, Dietmar Maurer wrote: >>> I personally think this adds much overhead and does not really help >>> developing software. >>> >> >> Ok. ___ pve-devel mailing list pve-devel@pve.proxmox.com https://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
Re: [pve-devel] Gitlab-ci
Did you think about using GitLab to at least to host all sources? I think that using Merge Requests workflow could actually be better and easier to contribute to than current mailing list. On Tue, Apr 17, 2018 at 10:53 AM Rene Jochum wrote: > On 2018-04-17 10:27, Dietmar Maurer wrote: > > I personally think this adds much overhead and does not really help > > developing software. > > > > Ok. > ___ > pve-devel mailing list > pve-devel@pve.proxmox.com > https://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel > ___ pve-devel mailing list pve-devel@pve.proxmox.com https://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
Re: [pve-devel] Gitlab-ci
On 2018-04-17 10:27, Dietmar Maurer wrote: > I personally think this adds much overhead and does not really help > developing software. > Ok. ___ pve-devel mailing list pve-devel@pve.proxmox.com https://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
Re: [pve-devel] Gitlab-ci
> I've made some Dockerfiles for PVE (easy to add more for PMG). These > don't require the Docker HUB - so it will be able to build them > even when the hub goes down. > > https://git.lxch.eu/git/pve-dockerfiles > > Is that something Proxmox is interested in? If yes, I'll continue my > work on it. > > At last i want to say that "Debian" moves to Gitlab and "Gnome" already > moved. ( https://salsa.debian.org/public ). I personally think this adds much overhead and does not really help developing software. ___ pve-devel mailing list pve-devel@pve.proxmox.com https://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
Re: [pve-devel] Gitlab-ci
Nicely done! I love gitlab :-D On Mon, Apr 16, 2018 at 9:50 PM, Rene Jochum wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA512 > > Hi! > > I've been working on Gitlab CI for Proxmox. In a dockerized environment > I'm now able to build the current 4.15 pve-kernel for Debian Buster and > Stretch. > > The Stretch build: https://git.lxch.eu/git/pve-kernel/-/jobs/43 > > https://git.lxch.eu/git/pve-kernel/-/jobs/43/artifacts/browse > The Buster build: https://git.lxch.eu/git/pve-kernel/-/jobs/41 > > https://git.lxch.eu/git/pve-kernel/-/jobs/41/artifacts/browse > > - From the current point it will be easy to add Support for all pve > packages, it will be a single ".gitlab-ci.yml" per repo: > > https://git.lxch.eu/git/pve-kernel/blob/pve-kernel-4.15-ci/.gitlab-ci.ym > l > > > I've made some Dockerfiles for PVE (easy to add more for PMG). These > don't require the Docker HUB - so it will be able to build them > even when the hub goes down. > > https://git.lxch.eu/git/pve-dockerfiles > > Is that something Proxmox is interested in? If yes, I'll continue my > work on it. > > At last i want to say that "Debian" moves to Gitlab and "Gnome" already > moved. ( https://salsa.debian.org/public ). > > Kind regards, > > René Jochum > > > > -BEGIN PGP SIGNATURE- > > iQIzBAEBCgAdFiEEGw01YDxPNy3/D8pOnoscMvXzGKkFAlrU/mgACgkQnoscMvXz > GKljNQ//eSPKowgnk/M6ipYD/3/lEjzqevXkoJO1N0EHiApSkWPWVniOBdxUJBl9 > E9dGK4lwGcT/uarhMqcR/63HOWYeQMJxb60USyFDXB5AWy5/gOsmoqGdatW3wNnR > xOOgSDCh6haFUXTGg/+3l0xC3sq7kVYfNFz7Lw3epwQdUF0FR3bHl2mq16oqeiiu > fsVoSCKKWyHbjn77o6hiK9Zf3dOdnE8Dk96nBrSIJUKy3mBB87J4eTxukdxyMqJE > nn+5358ixFJvS9SW/k4i0ukxIs7X/Mn86IuGYrYWEKtTTiSFXuGpDObdmH0AdJMJ > q0bwsxtUGr57/+UgzZWkPI51j/4VxXD7DEZuuZIae5It335WD7cUqW1YBnLFMYKe > DJ3Amz9kHxVM8bLSAdsc3D2XZq/yn73rn1HapVuOWwVw668vbn5G9GL/8cWCALee > d3A9qiw2p0Np96neXKEoQbajjb2s4mVA9MgGf9AzUzA3IGShkfqoAXLkRIo0p3vU > YO+1eTE7jNy7wh9ovc1TrvGXlwBrsfsfpCzA4BkSm/6peIYZdAwkaR8spgwJGkDA > SZEZ0DR2dsWeAzgqlHRNICKCb4UyOdVZylrT+fxma0Px2lCGIIQnTvKsXpmHZn0S > LfnT5OV85iYKHuPopt7UpWjGLWOTVBIKRkLryol0hVFO2GfOlXY= > =yJHb > -END PGP SIGNATURE- > ___ > pve-devel mailing list > pve-devel@pve.proxmox.com > https://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel -- With kind regards / Mit freundlichen Grüßen Andreas Steinel M.Sc. Visual Computing M.Sc. Informatik ___ pve-devel mailing list pve-devel@pve.proxmox.com https://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
[pve-devel] Gitlab-ci
-BEGIN PGP SIGNED MESSAGE- Hash: SHA512 Hi! I've been working on Gitlab CI for Proxmox. In a dockerized environment I'm now able to build the current 4.15 pve-kernel for Debian Buster and Stretch. The Stretch build: https://git.lxch.eu/git/pve-kernel/-/jobs/43 https://git.lxch.eu/git/pve-kernel/-/jobs/43/artifacts/browse The Buster build: https://git.lxch.eu/git/pve-kernel/-/jobs/41 https://git.lxch.eu/git/pve-kernel/-/jobs/41/artifacts/browse - From the current point it will be easy to add Support for all pve packages, it will be a single ".gitlab-ci.yml" per repo: https://git.lxch.eu/git/pve-kernel/blob/pve-kernel-4.15-ci/.gitlab-ci.ym l I've made some Dockerfiles for PVE (easy to add more for PMG). These don't require the Docker HUB - so it will be able to build them even when the hub goes down. https://git.lxch.eu/git/pve-dockerfiles Is that something Proxmox is interested in? If yes, I'll continue my work on it. At last i want to say that "Debian" moves to Gitlab and "Gnome" already moved. ( https://salsa.debian.org/public ). Kind regards, René Jochum -BEGIN PGP SIGNATURE- iQIzBAEBCgAdFiEEGw01YDxPNy3/D8pOnoscMvXzGKkFAlrU/mgACgkQnoscMvXz GKljNQ//eSPKowgnk/M6ipYD/3/lEjzqevXkoJO1N0EHiApSkWPWVniOBdxUJBl9 E9dGK4lwGcT/uarhMqcR/63HOWYeQMJxb60USyFDXB5AWy5/gOsmoqGdatW3wNnR xOOgSDCh6haFUXTGg/+3l0xC3sq7kVYfNFz7Lw3epwQdUF0FR3bHl2mq16oqeiiu fsVoSCKKWyHbjn77o6hiK9Zf3dOdnE8Dk96nBrSIJUKy3mBB87J4eTxukdxyMqJE nn+5358ixFJvS9SW/k4i0ukxIs7X/Mn86IuGYrYWEKtTTiSFXuGpDObdmH0AdJMJ q0bwsxtUGr57/+UgzZWkPI51j/4VxXD7DEZuuZIae5It335WD7cUqW1YBnLFMYKe DJ3Amz9kHxVM8bLSAdsc3D2XZq/yn73rn1HapVuOWwVw668vbn5G9GL/8cWCALee d3A9qiw2p0Np96neXKEoQbajjb2s4mVA9MgGf9AzUzA3IGShkfqoAXLkRIo0p3vU YO+1eTE7jNy7wh9ovc1TrvGXlwBrsfsfpCzA4BkSm/6peIYZdAwkaR8spgwJGkDA SZEZ0DR2dsWeAzgqlHRNICKCb4UyOdVZylrT+fxma0Px2lCGIIQnTvKsXpmHZn0S LfnT5OV85iYKHuPopt7UpWjGLWOTVBIKRkLryol0hVFO2GfOlXY= =yJHb -END PGP SIGNATURE- ___ pve-devel mailing list pve-devel@pve.proxmox.com https://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
